Commit Graph

54407 Commits

Author SHA1 Message Date
Sema Checherinda
bae34f4cd2
Merge pull request #59495 from ClickHouse/chesema-remove-objects-capability
generate key for clickhouse_remove_objects_capability
2024-03-06 17:45:32 +01:00
Sema Checherinda
8ac2ef6608
Merge pull request #57575 from ClickHouse/chesema-drop-zk-table-node
drop keeper dir with zero copy locks
2024-03-06 17:43:35 +01:00
vdimir
56b6810122
Merge pull request #60641 from ClickHouse/vdimir/analyzer/comute_alias_columns
Resubmit "Analyzer: compute ALIAS columns right after reading"
2024-03-06 16:52:16 +01:00
Anton Popov
1c0aed896c fix build 2024-03-06 15:25:06 +00:00
Anton Popov
f582797b36 Merge remote-tracking branch 'upstream/master' into HEAD 2024-03-06 14:14:42 +00:00
Igor Nikonov
d64abe2449 Merge remote-tracking branch 'origin/master' into use-minmax-indices-always-first 2024-03-06 13:51:55 +00:00
Kruglov Pavel
d37d0ecb15
Merge pull request #60795 from Avogar/format-detection
Support files without format extension in Filesystem database
2024-03-06 14:31:52 +01:00
Yarik Briukhovetskyi
2eb7fa297b
Merge pull request #60763 from zvonand/zvonand-fix-toStartOf
Fix toStartOfInterval
2024-03-06 13:55:21 +01:00
vdimir
7e908711d0
Respect max_execution_time for dictionary reloading time 2024-03-06 12:54:39 +00:00
Antonio Andelic
381c075391 Throw on query timeout 2024-03-06 13:19:40 +01:00
vdimir
4dede601ef
fix 2024-03-06 12:10:26 +00:00
vdimir
d9f7ac8815
Analyzer: Fix bug with join_use_nulls and PREWHERE 2024-03-06 12:10:25 +00:00
vdimir
70750cb108
Fix possible stuck on error in HashedDictionaryParallelLoader 2024-03-06 12:04:57 +00:00
vdimir
083a251951
Fixes for HashedArrayDictionary 2024-03-06 12:04:13 +00:00
Raúl Marín
7989e9dc70
Merge pull request #60810 from Algunenano/compression_clone
Add missing clone calls related to compression
2024-03-06 12:01:39 +01:00
Dmitry Novik
b675268a9b
Merge pull request #60770 from ClickHouse/analyzer-settings-check
Fix crash with different allow_experimental_analyzer value in subqueries
2024-03-06 11:00:01 +01:00
Robert Schulze
1c10b96361
Merge remote-tracking branch 'rschu1ze/master' into revert-revert-54746_to_millisecond_function 2024-03-06 09:04:57 +00:00
Antonio Andelic
b337c8f32f
Merge pull request #60898 from ClickHouse/revert-60514-show-index-sorting
Revert "Fix wacky primary key sorting in `SHOW INDEX`"
2024-03-06 09:19:19 +01:00
Antonio Andelic
e0fa26ece3
Merge pull request #60806 from Brokenice0415/add-leadership-expiry-setting
Support `leadership_expiry_ms` in  Keeper's settings
2024-03-06 09:05:50 +01:00
Antonio Andelic
655f9cb195
Revert "Fix wacky primary key sorting in SHOW INDEX" 2024-03-06 08:57:20 +01:00
Nikolai Kochetov
b040eadaa1
Merge pull request #60510 from ClickHouse/refactor-system-one-block
Refactor StorageSystemOneBlock
2024-03-06 08:55:50 +01:00
Antonio Andelic
a39c00aab5
Merge pull request #60849 from ClickHouse/avoid-stackoverflow-s3
Remove recursion when reading from S3
2024-03-06 08:51:43 +01:00
李扬
e4b78e7dac
fix bugs 2024-03-06 15:10:45 +08:00
jsc0218
9a99780d2c
Merge pull request #59698 from bigo-sg/opt_column_filter
Reduce peak memory while executing filter
2024-03-05 20:36:46 -05:00
Alexey Milovidov
456157939c
Merge pull request #60823 from azat/thread-fuzzer
Faster (almost 2x) mutexes (was slower due to ThreadFuzzer)
2024-03-06 00:07:50 +03:00
Robert Schulze
9ace8a4a40
Merge pull request #60521 from rschu1ze/clang-tidy-hdr
Enforce clang-tidy in `programs/` and `utils/` headers
2024-03-05 21:01:27 +01:00
Robert Schulze
8735c40ab2
Merge pull request #60514 from rschu1ze/show-index-sorting
Fix wacky primary key sorting in `SHOW INDEX`
2024-03-05 20:59:11 +01:00
Nikita Taranov
4f6cb21d51 set priority when scheduling task in thread pool 2024-03-05 19:45:25 +01:00
Raúl Marín
e1851987d8 Make tidy happy 2024-03-05 19:35:39 +01:00
Nikita Taranov
c8e41dc07c
Merge branch 'master' into davenger-patch-1 2024-03-05 19:12:22 +01:00
Sema Checherinda
8b2bd2125b no warnings at drop 2024-03-05 19:06:09 +01:00
Anton Popov
7fe7f3a79d address review comments 2024-03-05 16:03:02 +00:00
Dmitry Novik
55c028322d
Fix typo 2024-03-05 16:59:22 +01:00
vdimir
a8eeb899e3
Merge pull request #58278 from liuneng1994/optimize-all-join
Lazy build join output to improve performance of ALL join
2024-03-05 16:35:27 +01:00
Yakov Olkhovskiy
34f01c4a02 Merge branch 'master' into imp-analyzer-mask 2024-03-05 15:30:34 +00:00
Zhiguo Zhou
c4009a16f9 Refactor OptimizeDateOrDateTimeConverterWithPreimageVisitor
The generateOptimizedDateFilter function is refactored to enhance
the code readability. And this commit also fixes the duplicate
creations of ColumnNode.
2024-03-05 23:18:54 +08:00
Dmitry Novik
5524f5901f Cleanup code 2024-03-05 16:18:03 +01:00
Raúl Marín
56e0dd0ab0 More fixes 2024-03-05 15:35:06 +01:00
Nikolai Kochetov
97f955fcde Fix sanitizers 2024-03-05 14:10:46 +00:00
Dmitry Novik
04370083bb Merge remote-tracking branch 'origin/master' into analyzer-refactor-constant-name 2024-03-05 14:57:00 +01:00
Jordi Villar
b4e90e5121 Address PR comments 2024-03-05 14:46:55 +01:00
Dmitry Novik
248c93ed2d
Change error code 2024-03-05 14:37:16 +01:00
Raúl Marín
06409a8aa3 Merge remote-tracking branch 'blessed/master' into compression_clone 2024-03-05 14:03:41 +01:00
Sema Checherinda
6e085c713f generate key for clickhouse_remove_objects_capability 2024-03-05 14:02:43 +01:00
Alexander Tokmakov
72a4533c4e Merge branch 'master' into ddl_none_only_active 2024-03-05 13:42:00 +01:00
Yarik Briukhovetskyi
d93dd98b66
Merge pull request #60672 from yariks5s/fix_int_div_decimal_with_datetime
Fix `intDiv` for decimal and date arguments
2024-03-05 13:41:08 +01:00
Nikolai Kochetov
d4570aa3b2 Merge branch 'master' into constant-folding-scalar-subqueries 2024-03-05 12:14:54 +00:00
Nikolai Kochetov
86ad80839a Merge pull request #60515 from ClickHouse/cleanup-lazy-format-always
PullingAsyncPipelineExecutor cleanup
2024-03-05 13:12:07 +01:00
vdimir
6f3e9b6de2
Merge branch 'master' into vdimir/analyzer/comute_alias_columns 2024-03-05 13:08:58 +01:00
Brokenice0415
3058e59950 update notices 2024-03-05 20:06:39 +08:00
Igor Nikonov
e97ea97ba8 Merge remote-tracking branch 'origin/master' into use-minmax-indices-always-first 2024-03-05 11:42:32 +00:00
Robert Schulze
2c0b399c1f
Merge remote-tracking branch 'rschu1ze/master' into show-index-sorting 2024-03-05 11:27:32 +00:00
Robert Schulze
b5a7ef5fd3
Merge remote-tracking branch 'rschu1ze/master' into clang-tidy-hdr 2024-03-05 11:24:28 +00:00
Robert Schulze
7dfe8afa76
Add in-source docs 2024-03-05 11:11:18 +00:00
Kruglov Pavel
be13d8eb39
Merge pull request #60499 from ClickHouse/Avogar-patch-1
Cancel PipelineExecutor properly in case of exception in spawnThreads
2024-03-05 12:06:29 +01:00
Antonio Andelic
0bd4c6afa0 Use while-loop 2024-03-05 11:53:51 +01:00
Nikolai Kochetov
ee3edf2589 Fix system parts _state 2024-03-05 10:40:45 +00:00
Kruglov Pavel
9546b3f5fb
Merge pull request #60808 from Avogar/json-ambg-tuple-inference
Small improvements in JSON schema inference
2024-03-05 11:36:28 +01:00
taiyang-li
8b2e163d76 Merge remote-tracking branch 'origin/master' into opt_multiif_decimal 2024-03-05 17:17:10 +08:00
taiyang-li
4251cc3a11 fix building 2024-03-05 17:05:40 +08:00
lzydmxy
18b17523e4 Move connection drain from prepare to work 2024-03-05 15:32:17 +08:00
Antonio Andelic
09924899ea
Merge pull request #60769 from ClickHouse/catch-finalize-exception
Catch exceptions on finalize in `InterserverIOHTTPHandler`
2024-03-05 08:28:59 +01:00
Kseniia Sumarokova
6f5d79db24
Merge branch 'master' into fix-for-local-object-storage 2024-03-05 14:14:34 +08:00
Alexey Milovidov
2b85498940
Merge pull request #60520 from ClickHouse/sync-with-private-2
Synchronize metrics and Keeper
2024-03-05 07:52:03 +03:00
Alexey Milovidov
3b381fa0cc
Merge branch 'master' into mark-one-setting-as-obsolete 2024-03-05 04:58:54 +03:00
Alexey Milovidov
c8b0f9967f
Merge pull request #60749 from ClickHouse/fix-wrong-order-keeper
Fix `test_keeper_back_to_back/test.py::test_concurrent_watches`
2024-03-05 04:55:26 +03:00
Alexey Milovidov
ec495853a5
Merge pull request #60768 from Algunenano/2024a
Update tzdata to 2024a
2024-03-05 04:53:39 +03:00
Alexey Milovidov
fb9250a1ac
Merge pull request #60775 from azat/fix-32-bit-capabilities
Use 64-bit capabilities if available
2024-03-05 04:52:27 +03:00
Alexey Milovidov
570692fe83
Merge branch 'master' into json-ambg-tuple-inference 2024-03-05 04:50:39 +03:00
Alexey Milovidov
8aeffa0356
Merge pull request #60765 from Avogar/fix-crash-in-input-join
Fix crash when using input() in INSERT SELECT JOIN
2024-03-05 04:32:50 +03:00
Alexey Milovidov
f96db5acd3
Merge pull request #60812 from ClickHouse/pcset
Move userspace page cache settings to the correct section of SettingsChangeHistory.h
2024-03-05 03:59:56 +03:00
Alexey Milovidov
8e200f5c0c
Merge pull request #60807 from ClickHouse/aarch64-profiler
Aarch64 profiler
2024-03-05 03:57:45 +03:00
Nikolai Kochetov
819e7bfc77 Merge branch 'master' into refactor-system-one-block 2024-03-04 21:03:45 +00:00
Azat Khuzhin
d5825ec80d Faster (almost 2x) mutexes (was slower due to ThreadFuzzer)
Recently I noticed that DB::injection() pops up in perf top, so let's
optimize it slightly:
- Add -fomit-frame-pointer -momit-leaf-frame-pointer explicitly --
  almost 0 effect
- Add ALWAYS_INLINE for ThreadFuzzer::isStarted() (just in case)
- Disable ThreadFuzzer if non of env variables had been set, this is
  needed to avoid extra checks in DB::injection()
- Add ALWAYS_INLINE for ThreadFuzzer::injection()

And here are some results for ThreadFuzzer test:
- before:   elapsed 6.27368 / test time 654 ms
- after:    elapsed 3.14167 / test time 325 ms
- disabled: elapsed 2.46666 / test time 263 ms

*But note, it is still slower then with ThreadFuzzer disabled.*

Note, that this numbers for AMD 5975WX, for server with 2x Xeon Silver
4216 2.10:
- before:   elapsed 12.109  / test time 1325 ms
- after:    elapsed 10.506  / test time 1101 ms
- disabled: elapsed 8.41043 / test time 917 ms

P.S. I've also tried with the same glibc version as server had - zero
changes.

Refs: https://gist.github.com/azat/51a5fcc3a40af9f678906a3a6e14e079
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-04 21:14:26 +01:00
Michael Kolupaev
24505ba9b3 Move userspace page cache settings to the correct section of SettingsChangeHistory.h 2024-03-04 19:36:38 +00:00
Raúl Marín
6ac4f60caa
Merge pull request #60764 from Algunenano/i59655
Fix crash in arrayEnumerateRanked
2024-03-04 20:22:30 +01:00
Raúl Marín
680bb3392e More missing trash 2024-03-04 20:01:27 +01:00
Raúl Marín
37891660be More missing resets 2024-03-04 20:01:03 +01:00
Raúl Marín
b86fcf0e7d Add missing compression clone() in ASTQueryWithOutput 2024-03-04 19:53:18 +01:00
Igor Nikonov
ee4e5b1592 Merge remote-tracking branch 'origin/master' into use-minmax-indices-always-first 2024-03-04 18:29:05 +00:00
Nikolai Kochetov
d209508753 Fixing style. 2024-03-04 18:26:42 +00:00
Kruglov Pavel
4bdafed801
Merge pull request #60420 from HowePa/format_case_insensitive
Make all format names case insensitive.
2024-03-04 19:09:10 +01:00
Nikolai Kochetov
47d8f039e5 Cleanup VirtualColumnUtils 2024-03-04 18:01:12 +00:00
avogar
9a05461680 Better exception message 2024-03-04 17:49:33 +00:00
Nikolai Kochetov
2d8ca99860 Refactor more system storages. 2024-03-04 17:48:47 +00:00
avogar
70abdf7a41 Small improvements in JSON schema inference 2024-03-04 17:32:22 +00:00
Alexey Milovidov
a7430004b3 Fix real time query profiler on AArch64 2024-03-04 18:13:49 +01:00
Brokenice0415
cc1c3f2da3 add a keeper setting leadership_expiry 2024-03-05 00:54:25 +08:00
avogar
70acf7a930 Support files without format extension in Filesystem database 2024-03-04 16:16:58 +00:00
Raúl Marín
96826ee8e1
Merge pull request #60362 from Algunenano/parallel_replicas_cte_2
Force reanalysis if parallel replicas changed
2024-03-04 17:16:17 +01:00
Sema Checherinda
71029373f2
Merge pull request #60748 from Beetelbrox/fjurado/dont-add-metadata-headers-to-unsupported-multipart-steps
Prevent setting custom metadata headers on unsupported multipart upload operations
2024-03-04 17:04:33 +01:00
Alexey Milovidov
0d3271e548
Merge pull request #60727 from ClickHouse/allow-enums-and-strings
Make String a supertype for strings and enums
2024-03-04 18:58:58 +03:00
Alexey Milovidov
ce6dec65cf
Merge pull request #60729 from ClickHouse/remove-more-live-view
Remove more code from LIVE VIEW
2024-03-04 18:58:21 +03:00
Alexey Milovidov
bc0cf83668
Merge pull request #60738 from ClickHouse/sql-json-remove-nonsense
Remove nonsense from SQL/JSON
2024-03-04 18:57:50 +03:00
Alexey Milovidov
558cde5e80
Merge pull request #60731 from ClickHouse/fix-buffer-overflow-in-compression-codec-multiple
Fix buffer overflow in CompressionCodecMultiple
2024-03-04 18:57:01 +03:00
Antonio Andelic
fb8241c651 Better 2024-03-04 16:36:46 +01:00
Azat Khuzhin
081ed8de2a Use 64-bit capabilities if available
This will fix the following warning in dmesg:

    capability: warning: `clickhouse-serv' uses 32-bit capabilities (legacy support in use)

P.S. I'm not even sure that the fallback code is useful, since
_LINUX_CAPABILITY_VERSION_3 had been added long time ago, in Linux
2.6.26 (Released 13 July 2008)

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-04 16:20:45 +01:00
Nikolai Kochetov
f421d3d571
Merge pull request #60515 from ClickHouse/cleanup-lazy-format-always
PullingAsyncPipelineExecutor cleanup
2024-03-04 15:54:53 +01:00
Alexey Milovidov
de6c5d3a40
Merge pull request #60552 from ClickHouse/pc2
Userspace page cache again
2024-03-04 17:47:35 +03:00
Dmitry Novik
f2387262ce Fix crash with different allow_experimental_analyzer value in subqueries 2024-03-04 15:32:15 +01:00