Commit Graph

124511 Commits

Author SHA1 Message Date
Azat Khuzhin
33a681bb3f Fix 01051_system_stack_trace flakiness
This should fix possible flakiness [1] due to "Cannot obtain a stack trace for thread":

<details>

    $ zstd -cdq clickhouse-server.log.zst | grep -a 2a66d71f-1340-44c8-9d0f-0779b0218ae4
    2023.09.05 12:04:55.906701 [ 617 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Debug> executeQuery: (from [::1]:52620) (comment: 01051_system_stack_trace.sql) -- { echo }
    2023.09.05 12:04:55.907041 [ 617 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Trace> ContextAccess (default): Access granted: SELECT(query_id) ON system.stack_trace
    2023.09.05 12:04:58.858695 [ 617 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Debug> StorageSystemStackTrace: Cannot obtain a stack trace for thread 617
    2023.09.05 12:05:01.858508 [ 617 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Debug> StorageSystemStackTrace: Cannot obtain a stack trace for thread 812
    2023.09.05 12:05:04.858698 [ 617 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Debug> StorageSystemStackTrace: Cannot obtain a stack trace for thread 1707
    2023.09.05 12:05:05.194543 [ 617 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Trace> InterpreterSelectQuery: FetchColumns -> Complete
    2023.09.05 12:05:05.195960 [ 2835 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Trace> Aggregator: Aggregation method: without_key
    2023.09.05 12:05:05.195997 [ 2835 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Trace> AggregatingTransform: Aggregated. 0 to 1 rows (from 0.00 B) in 0.001220809 sec. (0.000 rows/sec., 0.00 B/sec.)
    2023.09.05 12:05:05.196008 [ 2835 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Trace> Aggregator: Merging aggregated data
    2023.09.05 12:05:05.196020 [ 2835 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Trace> Aggregator: Statistics updated for key=5518594236514924310: new sum_of_sizes=1, median_size=1
    2023.09.05 12:05:05.197646 [ 617 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Debug> executeQuery: Read 1937 rows, 158.08 KiB in 9.291003 sec., 208.48125869725797 rows/sec., 17.01 KiB/sec.
    2023.09.05 12:05:05.197748 [ 617 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Debug> TCPHandler: Processed in 9.291633143 sec.

</details>

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/0/5da7133c9421873c86bf7d5d71e699267fcefbff/stateless_tests__aarch64_.html

v0: increase timeout
v2: revert timeout change and add no-parallel
v3: add filter by thread_name to avoid sending signals to other threads and increase timeout
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-09-06 21:11:07 +02:00
Kruglov Pavel
e11e5fbe2e
Fix fasttest 2023-09-06 21:10:30 +02:00
robot-clickhouse
cd7c57f5d4 Automatic style fix 2023-09-06 19:00:05 +00:00
serxa
664efaf3fa add test 2023-09-06 18:35:40 +00:00
avogar
ab101eaff8 Fix possible error 'URI contains invalid characters' in s3 table function 2023-09-06 18:21:24 +00:00
SmitaRKulkarni
f0146c0ff0
Increase retries for test_merge_tree_azure_blob_storage (#54069)
* Increase max_single_download_retries & max_single_read_retries for test_merge_tree_azure_blob_storage

* Updated logs to log exception leading to detaching part

* Updated to catch RequestFailedException azure exception as its the base exception

* Updated isRetryableExcepion to take std::exception_ptr as input

* Fixed style check fails

* Fix build issue & moved NetException & TimeoutException to retryable exceptions

* Fixed style check with catch
2023-09-06 19:57:59 +02:00
Kruglov Pavel
c3fb0ef5d4
Fix style 2023-09-06 19:42:14 +02:00
robot-ch-test-poll3
7f756ed613
Merge pull request #54354 from ClickHouse/parallel-replicas-cleanup
Parallel replicas: remove unused code
2023-09-06 19:38:14 +02:00
avogar
e44580fa47 Enable hedged requests integration tests with tsan, use max_distributed_connections=1 to fix possible flakiness 2023-09-06 17:15:23 +00:00
Alexander Sapin
4368c00052 Fix logical error in vertical merge + replacing merge tree + optimize cleanup 2023-09-06 18:43:56 +02:00
avogar
76acc77e66 Fix flaky test test_storage_azure_blob_storage/test.py::test_schema_inference_cache 2023-09-06 16:39:45 +00:00
johanngan
bcb058f999 Add case insensitive and dot-all modes to RegExpTree dictionary
The new per-dictionary settings control regex match semantics around
case sensitivity and the '.' wildcard with newlines. They must be set at
the dictionary level since they're applied to regex engines at
pattern-compile-time.

- regexp_dict_flag_case_insensitive: case insensitive matching
- regexp_dict_flag_dotall: '.' matches all characters including newlines

They correspond to HS_FLAG_CASELESS and HS_FLAG_DOTALL in Vectorscan
and case_sensitive and dot_nl in RE2. These are the most useful options
compatible with the internal behavior of RegExpTreeDictionary around
splitting up simple and complex patterns between Vectorscan and RE2.

The alternative is to use (?i) and/or (?s) for all patterns. However,
(?s) isn't handled properly by OptimizedRegularExpression::analyze().
And while (?i) is, it still causes the dictionary to treat the pattern
as "complex" for sequential scanning with RE2 rather than multi-matching
with Vectorscan, even though Vectorscan supports case insensitive
literal matching. Setting dictionary-wide flags is both more convenient,
and circumvents these problems.
2023-09-06 11:28:53 -05:00
Alexey Milovidov
47701d690a
Merge pull request #54136 from aiven-sal/aiven-sal/fix_38585
Fix issues in accurateCastOrNull
2023-09-06 19:14:03 +03:00
Alexey Milovidov
05a62ab5cc
Merge pull request #54322 from priera/fix_replace_partition_test
Fix replace_partition test
2023-09-06 19:13:25 +03:00
Kruglov Pavel
692f4d1f67
Fix test 2023-09-06 18:09:56 +02:00
Alexander Sapin
314fee5698 Disable one more test 2023-09-06 17:26:12 +02:00
Mikhail Koviazin
e5a3a9319f
Review fixes
* Remove generated `tables.h` and use the ones from upstream instead
* Add comment about compiling AVX512 codec
2023-09-06 15:17:52 +00:00
robot-ch-test-poll4
8c71582316
Merge pull request #54185 from ClickHouse/analyzer-partition-id-pruning
Fix partition id pruning for analyzer.
2023-09-06 16:53:35 +02:00
robot-ch-test-poll1
9e50e8ff20
Merge pull request #54193 from ClickHouse/fix_replace_partition_with_zero_copy
Fix REPLACE/MOVE PARTITION with zero-copy replication
2023-09-06 16:04:25 +02:00
Alexey Milovidov
a59cf9cac8
Merge pull request #54338 from ClickHouse/keeper-bad-punctuation
Fix bad punctuation in Keeper's logs
2023-09-06 16:57:59 +03:00
Alexey Milovidov
68e867decc
Merge pull request #54347 from ClickHouse/add-sso-for-s3
Add support for SSO credentials in S3
2023-09-06 16:57:37 +03:00
yariks5s
0c802df855 small improvement 2023-09-06 13:33:11 +00:00
Robert Schulze
f2f24610d0
Improve English grammar by 8.3% 2023-09-06 15:04:18 +02:00
Mikhail Koviazin
f98007a4ed
Replace Turbo-Base64 with aklomp/base64
Closes #31643
2023-09-06 13:01:38 +00:00
Nikita Mikhaylov
18cf06791e Better 2023-09-06 12:54:02 +00:00
Igor Nikonov
c51cfef065 Remove unused code 2023-09-06 12:53:58 +00:00
Mikhail f. Shiryaev
587013d994
Merge pull request #54010 from ClickHouse/modular-workflows
Use pathlib.Path in S3Helper, rewrite build reports, improve small things
2023-09-06 14:29:37 +02:00
Igor Nikonov
54c5158291
Merge pull request #54315 from ClickHouse/add-logs-parallel-replica-over-distributed
Add logs for parallel replica over distributed
2023-09-06 14:23:45 +02:00
Alexander Sapin
a176c38876 Fix tests with database replicated 2023-09-06 14:17:46 +02:00
Mikhail f. Shiryaev
7f34c8e17d
Decouple env_helper.get_job_id_url 2023-09-06 12:43:29 +02:00
Mikhail f. Shiryaev
1afc5b7e05
Use suffix from git tags as version descriptions 2023-09-06 12:43:28 +02:00
Mikhail f. Shiryaev
6fc73e0e1f
Use a single BuildResult class across builds and report checks 2023-09-06 12:43:27 +02:00
Mikhail f. Shiryaev
88664bef3f
Create report status constants 2023-09-06 12:43:25 +02:00
Mikhail f. Shiryaev
428b72e767
Combine rows for build templates with lists 2023-09-06 12:43:23 +02:00
Mikhail f. Shiryaev
e0f6242af8
Use the same style for all reports 2023-09-06 12:43:21 +02:00
Mikhail f. Shiryaev
e18d9d39e8
Migrate S3Helper to pathlib.Path 2023-09-06 12:43:20 +02:00
Alexander Sapin
518d4b4357 Merge branch 'master' into alter-table-add-comment 2023-09-06 12:34:04 +02:00
Anton Popov
401496aa1f Apply suggestions from code review
Co-authored-by: Nikita Mikhaylov <mikhaylovnikitka@gmail.com>
2023-09-06 10:27:46 +00:00
Nikolay Degterinsky
42ce81e62a
Merge pull request #54339 from arenadata/ADQM-1158
Improved protection from dereferencing of nullptr
2023-09-06 12:25:57 +02:00
Antonio Andelic
52e4f3c571 Fix style 2023-09-06 09:27:35 +00:00
Antonio Andelic
af43463bfb Better 2023-09-06 08:54:39 +00:00
Salvatore Mesoraca
2bf3c11311
Fix tests when cast_keep_nullable=1
Before this set of changes, when cast_keep_nullable=1,
CAST(toNullable(''), type),
accurateCast(toNullable(''), type),
accurateCastOrDefault(toNullable(''), type), and
accurateCastOrNull('', type)
produced NULL for all types
(at least for those where the empty string is invalid)
except IPv6 and IPv4.
Now they produce NULL also for IP types.
2023-09-06 10:51:21 +02:00
Robert Schulze
b41a4d5c7a
Fix test 2023-09-06 08:43:11 +00:00
Robert Schulze
8f6cd157b9
Merge pull request #54316 from ucasfl/isNull
Fix isZeroOrNull(NULL)
2023-09-06 10:38:22 +02:00
Antonio Andelic
d0c70c0f8a Merge branch 'master' into add-sso-for-s3 2023-09-06 07:29:05 +00:00
Salvatore Mesoraca
f61390e12c
Fix style issue 2023-09-06 08:42:45 +02:00
robot-ch-test-poll1
d9746b5ea1
Merge pull request #54336 from arenadata/ADQM-1157
Used assert_cast instead of dynamic_cast in ExternalDataSourceCache
2023-09-06 08:28:21 +02:00
pufit
ed43a8f1f6 Merge branch 'master' into pufit/keeper-client-reconfig 2023-09-05 23:20:12 -04:00
Alexey Gerasimchuck
076a6e7476 reduced code amount 2023-09-06 02:07:39 +00:00
Yakov Olkhovskiy
0dd6928a13
Merge pull request #53068 from nickitat/unify_keep_alive_setting
Unify setting http keep-alive timeout, increase default to 30s
2023-09-05 22:05:23 -04:00