Commit Graph

59191 Commits

Author SHA1 Message Date
alesapin
7ee72dfd0c Missed tests 2021-02-19 22:24:20 +03:00
Alexey Milovidov
0f77b6fd95 Even more better 2021-02-19 22:01:45 +03:00
Azat Khuzhin
fba1c7fcc1 Fix uncaught exception when HTTP client goes away
Even after #20464 it was still possible, for example [1].

    2021.02.19 11:40:21.886191 [ 68373 ] {} <Trace> DynamicQueryHandler: Request URI: /?database=test_ds2d6y&log_comment=/usr/share/clickhouse-test/queries/0_stateless/01302_aggregate_state_exception_memory_leak.sh&enable_http_compression=1&http_zlib_compression_level=1

    <snip>

    2021.02.19 11:41:35.289940 [ 365 ] {} <Fatal> BaseDaemon: (version 21.3.1.6058, build id: 8D46D65205E2C8B7FE408A0B4EC76CA0483F9E92) (from thread 68373) Terminate called for uncaught exception:
    Code: 24, e.displayText() = DB::Exception: Cannot write to ostream at offset 262568, Stack trace (when copying this message, always include the lines below):

    0. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/exception:0: Poco::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0x15b3c7db in /usr/bin/clickhouse
    1. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:56: DB::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, bool) @ 0x8aba66e in /usr/bin/clickhouse
    2. ./obj-x86_64-linux-gnu/../src/IO/WriteBufferFromOStream.cpp:0: DB::WriteBufferFromOStream::nextImpl() @ 0x8b8c105 in /usr/bin/clickhouse
    3. ./obj-x86_64-linux-gnu/../src/IO/BufferBase.h:39: DB::WriteBufferFromOStream::~WriteBufferFromOStream() @ 0x8b8c537 in /usr/bin/clickhouse
    4. ./obj-x86_64-linux-gnu/../src/IO/WriteBufferFromOStream.cpp:44: DB::Write

  [1]: https://clickhouse-test-reports.s3.yandex.net/16481/5d150cce4778dd14f58dcff67435bdec1efa155b/stress_test_(thread).html#fail1

And according to this partial stacktrace it seems that the dtor of
WriteBufferFromOStream was called from
WriteBufferFromHTTPServerResponse, since the class name starts from
DB::Write*

The problem is that if first time WriteBufferFromOStream::next() fails,
it will reset position to make next write no-op, however
WriteBufferFromHTTPServerResponse::next() will set position to available
buffer back, and next() will throw again, but this time it can be from
dtor.
2021-02-19 22:00:57 +03:00
Denis Zhuravlev
66e775ef88 test for decimal ( p , s) in dictionaries 2021-02-19 14:53:34 -04:00
Alexey Milovidov
252bcccdda Just little better 2021-02-19 21:32:39 +03:00
alexey-milovidov
a78523cf01
Merge pull request #20208 from vzakaznikov/ldap_docs
Adding documentation on how to use LDAP server as external user authenticator or directory
2021-02-19 20:56:01 +03:00
Maksim Kita
fc03c1013c
Fixed style check 2021-02-19 20:42:51 +03:00
alexey-milovidov
2299930c31
Merge pull request #20545 from kssenii/rabbit-format-settings
rabbitmq: add missing format factory settings
2021-02-19 20:24:17 +03:00
alexey-milovidov
91de5628f0
Merge pull request #20866 from CurtizJ/fix-distinct-state
Fix usage of 'distinct' combinator with 'state' combinator
2021-02-19 20:22:53 +03:00
Maksim Kita
0b5213c80d
Added comment 2021-02-19 19:49:19 +03:00
tavplubix
3509fe88d8
Merge pull request #20878 from ClickHouse/fix_18926
Fix COM_FIELD_LIST response in MySQL protocol
2021-02-19 19:25:54 +03:00
Maksim Kita
b84112a603 Function sumMap decimal fix 2021-02-19 19:25:50 +03:00
Alexander Tokmakov
5cfd687dfb fix 2021-02-19 19:22:47 +03:00
alesapin
ad374ec095 Rename file 2021-02-19 19:05:26 +03:00
Denis Glazachev
8cc72b8fe0 Merge branch 'master' into row-policy-with-prewhere
* master: (160 commits)
  Make Poco HTTP Server zero-copy again (#19516)
  Fixed documentation
  ccache 4.2+ does not requires any quirks for SOURCE_DATE_EPOCH
  Add a function `htmlOrXmlCoarseParse` to extract content from html or xml format string. (#19600)
  Reinterpret function added Decimal, DateTim64 support
  Add test
  Update InterpreterSelectQuery.cpp
  Improved serialization for data types combined of Arrays and Tuples. Improved matching enum data types to protobuf enum type. Fixed serialization of the Map data type. Omitted values are now set by default.
  Log stdout and stderr when failed to start docker in integration tests.
  Added comment
  Don't backport base commit of branch in the same branch (#20628)
  Fix fasttest retry for failed tests
  Dictionary create source with functions crash fix
  Added error reinterpretation tests
  Update run.sh
  Updated documentation
  fix subquery with limit
  Rename untyped function reinterpretAs into reinterpret
  ignore data store files
  Support vhost
  ...
2021-02-19 19:49:37 +04:00
Denis Glazachev
5e5b3b80ce Remove debug printouts 2021-02-19 19:46:52 +04:00
Denis Glazachev
bfccfd9eec Fix tests
Add tests
WIP: Failures are legit!
2021-02-19 19:32:35 +04:00
kssenii
30f0e48777 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into fix-postgres-numeric 2021-02-19 14:53:27 +00:00
alesapin
12d05c2792 Better startup 2021-02-19 17:47:53 +03:00
Alexander Tokmakov
033f55f498 fix 2021-02-19 17:38:20 +03:00
alexey-milovidov
ceacae4ee4
Merge pull request #20462 from azat/stress-backtrace-on-failure
Improve backtrace catching on server failures in CI for stress tests
2021-02-19 17:33:29 +03:00
alesapin
068c9cfbf7 Fix logs level 2021-02-19 17:13:29 +03:00
vdimir
946576017f
Update CrossToInnerJoinVisitor, add tests to cross_to_inner_join 2021-02-19 17:06:57 +03:00
alesapin
ea27c3ca32 Add gdb to fasttest image 2021-02-19 16:41:46 +03:00
alesapin
bebc66b0ca
Merge pull request #20960 from kssenii/fixed-aerospike-version
Fix push to dockerhub
2021-02-19 16:22:24 +03:00
alesapin
5c9420c077 More correct epoll usage 2021-02-19 15:56:51 +03:00
Ivan
414f470c79
Make Poco HTTP Server zero-copy again (#19516)
* Refactoring: part 1

* Refactoring: part 2

* Handle request using ReadBuffer interface

* Struggles with ReadBuffer's

* Fix URI parsing

* Implement parsing of multipart/form-data

* Check HTTP_LENGTH_REQUIRED before eof() or will hang

* Fix HTTPChunkedReadBuffer

* Fix build and style

* Fix test

* Resist double-eof

* Fix arcadian build
2021-02-19 15:51:26 +03:00
Nikolai Kochetov
866dfaec79
Update 01731_async_task_queue_wait.sh 2021-02-19 15:25:22 +03:00
vdimir
e052a5a05e
Revert "Support old cross to inner join rewrite behaviour"
This reverts commit 527210b5e4.
2021-02-19 15:14:24 +03:00
vdimir
7b8b77f258
Add tests to join_implicit_cast checks column name clash 2021-02-19 14:53:06 +03:00
Maksim Kita
71c65b5d82
Merge pull request #20611 from kitaisreal/rename-untyped-function-reinterpret-as
Rename untyped function reinterpretAs into reinterpret
2021-02-19 14:35:00 +03:00
vdimir
1a26310d27
Split test join_implicit_cast (due to timeouts in flaky checks) 2021-02-19 14:28:41 +03:00
vdimir
dc9e660522
Remove 'error' from comment from 01710_join_use_nulls 2021-02-19 14:28:41 +03:00
vdimir
ab0719caf0
More tests for join on key type convert 2021-02-19 14:28:41 +03:00
vdimir
1e37d7c84f
Add comments to TableJoin::inferJoinKeyCommonType 2021-02-19 14:28:41 +03:00
vdimir
456414beea
Fix converting join on keys, move actions into TableJoin 2021-02-19 14:28:41 +03:00
vdimir
3a7eddcf3a
Remove addRequiredLeftColumn, some tests for join on different types 2021-02-19 14:28:40 +03:00
vdimir
a378bd08aa
Perform implicit type conversion for JOIN ON keys 2021-02-19 14:28:40 +03:00
vdimir
cd7d9584bd
Add tests to 01720_join_implicit_cast - switch, use_nulls 2021-02-19 14:28:40 +03:00
vdimir
9b79ab2ac0
Fix style in appendJoin 2021-02-19 14:28:40 +03:00
vdimir
4203dd5e38
Give up on name mismatch in inferJoinKeyCommonType 2021-02-19 14:28:39 +03:00
vdimir
435f63f42b
Calculate common type for join using in TreeRewriter
Split before_join and converting_join_columns dags

Add more detailed comments for column type conversion for join using
2021-02-19 14:28:32 +03:00
vdimir
d15c1a203b
Fix TableJoin, upd 01675_join_implicit_cast 2021-02-19 14:24:34 +03:00
vdimir
f5b98015a8
Fix converting right key type in join using 2021-02-19 14:24:33 +03:00
vdimir
4c36cd1737
Add converting step for 'join using' 2021-02-19 14:24:28 +03:00
Nikolai Kochetov
df1cf481cf
Update 01731_async_task_queue_wait.sh 2021-02-19 14:14:31 +03:00
alesapin
3d954c4314 Better request/response logic 2021-02-19 14:06:17 +03:00
Nikolai Kochetov
8f8a4f6423
Update 01731_async_task_queue_wait.sh 2021-02-19 13:59:38 +03:00
kssenii
1c5b10de41 Use fixed version for aerospike 2021-02-19 10:42:25 +00:00
alesapin
6c9322bb2e Sane constant while reading requests 2021-02-19 12:57:39 +03:00