Commit Graph

12945 Commits

Author SHA1 Message Date
Azat Khuzhin
8703b7863d Fix distributed_group_by_no_merge=2 with GROUP BY
Before this patch the following query:

  SELECT assumeNotNull(argMax(dummy, 1))
  FROM remote('127.1', system.one)
  SETTINGS distributed_group_by_no_merge = 2

Leads to:

  Code: 10. DB::Exception: Received from localhost:9000. DB::Exception: Not found column argMax(dummy, 1) in block: while executing 'INPUT : 0 -> argMax(dummy, 1) UInt8 : 0'.

Since it tries to execute function one more time, but shards will not
send this column when the query processed with
distributed_group_by_no_merge=2 (i.e. up to
WithMergeableStateAfterAggregation).

v0: no exception
v2: execut window functions
v3: throw exception, since executing window function in this case will
lead to messy output
2021-05-06 00:21:47 +03:00
Alexey Milovidov
79beaae056 Shave off some lines of code 2021-05-05 15:01:01 +03:00
Alexey Milovidov
6473e956bb Implement TODO 2021-05-05 14:58:17 +03:00
alexey-milovidov
bf8c28a17f
Merge pull request #23885 from azat/dist-broken-metrics
Add metrics for broken files during async distributed sends
2021-05-05 13:41:15 +03:00
alexey-milovidov
c607291042
Merge pull request #23877 from ClickHouse/pvs-studio-fixes-5
Fix some warnings by PVS-Studio
2021-05-04 22:57:19 +03:00
Azat Khuzhin
9c6e8e1462 Add BrokenDistributedFilesToInsert new metric
Number of files for asynchronous insertion into Distributed tables that
has been marked as broken. This metric will starts from 0 on start.
Number of files for every shard is summed.
2021-05-04 22:48:07 +03:00
Azat Khuzhin
74269882f7 Add broken_data_files/broken_data_compressed_bytes into distribution_queue 2021-05-04 22:48:07 +03:00
vdimir
657eda9288
Add Read/WriteBufferFromFileDecorator.cpp to ya.make 2021-05-04 16:07:56 +03:00
Alexey Milovidov
2b118f11b4 PVS-Studio 2021-05-04 15:14:55 +03:00
Alexey Milovidov
9cbdcc1ab5 PVS-Studio 2021-05-04 15:14:47 +03:00
Alexey Milovidov
eea47a65d2 PVS-Studio 2021-05-04 15:13:47 +03:00
alexey-milovidov
4ebc0b79fc
Merge pull request #23868 from ClickHouse/fix-disks3-arcadia
Add DiskRestartProxy.cpp to ya.make
2021-05-04 14:57:18 +03:00
Yegor Levankov
3c02a998c2
Fix typo in comment 2021-05-04 10:54:13 +03:00
vdimir
465341eafd
Add DiskRestartProxy.cpp to ya.make 2021-05-03 20:50:17 +03:00
Azat Khuzhin
5e33604c4d Add file paths into logs on failed distributed async sends 2021-05-03 08:55:38 +03:00
Nikolai Kochetov
08f10dced0
Merge pull request #23743 from ClickHouse/refactor-join-step
Refactor join step
2021-05-02 21:17:23 +03:00
Maksim Kita
b2b9c3950f
Merge pull request #23836 from kitaisreal/xdbc-bridge-helper-use-global-context
XDBCBridgeHelper use global context
2021-05-01 21:29:30 +03:00
alexey-milovidov
f360e7c808
Merge pull request #23766 from kitaisreal/remove-unused-compilers
Remove unused compilers (fixed for the troublesome "unbundled" build)
2021-05-01 16:15:38 +03:00
Vladimir
3b7c68196b
Merge pull request #23429 from Jokser/disk-s3-restart-possibility 2021-05-01 15:28:14 +03:00
Maksim Kita
9f369a0a27
Merge pull request #23825 from kitaisreal/update-field-include-bytes-allocated-fix
Flat, Hashed dictionary include update field bytes into bytes_allocated
2021-05-01 15:25:07 +03:00
Maksim Kita
7d0019515b XDBCBridgeHelper use global context 2021-05-01 15:00:37 +03:00
alexey-milovidov
37f44ca7e8
Merge pull request #23776 from ClickHouse/pvs-workaround
Workaround for PVS-Studio
2021-05-01 11:58:50 +03:00
Alexey Milovidov
2bf4723e2a Additions 2021-05-01 11:58:32 +03:00
Alexey Milovidov
b879d05ec4 Fix build 2021-05-01 10:06:30 +03:00
alexey-milovidov
7ca42d2ce1
Merge pull request #23805 from ClickHouse/fix-hedged-requests-ext-tables
Fix sending external table for hedged connections.
2021-05-01 08:13:13 +03:00
Maksim Kita
66903e4b0c Flat, Hashed dictionary include update field bytes into bytes_allocated 2021-05-01 01:23:22 +03:00
Maksim Kita
fa1e9de7f7
Merge pull request #23782 from ClickHouse/merging-array-product-function
Merging array product function
2021-05-01 00:53:57 +03:00
alexey-milovidov
7fa24d7b26
Merge pull request #23664 from azat/msan-dtor
Enable use-after-destruction detection in MSan
2021-04-30 21:51:28 +03:00
alexey-milovidov
eeae539a9f
Merge pull request #23799 from kitaisreal/function-default-implementation-for-nulls-small-optimization
Function default implementation for nulls small optimization
2021-04-30 21:50:24 +03:00
Nikolai Kochetov
0c063755d9 Fix style 2021-04-30 18:21:55 +03:00
Maksim Kita
14e879cef9
Merge pull request #23781 from ucasFL/fix-clear-column
Fix CLEAR COLUMN does not work after #21303
2021-04-30 17:28:59 +03:00
Nikolai Kochetov
352ec049ad Fix sending external table for hedged connections. 2021-04-30 17:19:48 +03:00
Maksim Kita
bcfcfe7fe9 Fixed style check 2021-04-30 17:16:51 +03:00
Maksim Kita
404b2d8fe8 Return constant branch 2021-04-30 17:14:01 +03:00
Nikolai Kochetov
4bb56849b3
Merge pull request #23763 from amosbird/rowfilterfix
Fix crash when prewhere and row policy filter are both in effect with empty result
2021-04-30 16:25:36 +03:00
Nikolai Kochetov
33fd7206c4 Revert "Try to remove useless code"
This reverts commit 10e3cbe63a.
2021-04-30 16:07:22 +03:00
Nikolai Kochetov
16bad2245d Better comment. 2021-04-30 16:06:17 +03:00
Maksim Kita
9c808c4944
Merge pull request #23786 from kitaisreal/add-examples-folder-filter-to-ya-make-in
Add examples folder filter to ya.make.in
2021-04-30 15:27:54 +03:00
Maksim Kita
7467c5e3cf Function default implementation for nulls small optimization 2021-04-30 13:56:56 +03:00
Nikolai Kochetov
10e3cbe63a Try to remove useless code 2021-04-30 13:50:24 +03:00
Nikolai Kochetov
3d5b61d63f Fix fuild. 2021-04-30 13:18:01 +03:00
alexey-milovidov
dd31634ba4
Merge pull request #23746 from oxidecomputer/master
Adds support for building on Solaris-derived systems
2021-04-30 13:15:52 +03:00
Maksim Kita
44b966af5a Removed const path for arrayAggregation 2021-04-30 12:33:34 +03:00
Kseniia Sumarokova
fa5cea7a0a
Merge pull request #23761 from kssenii/hdfs-fixes
Fix hdfs read with Values format
2021-04-30 11:41:23 +03:00
Maksim Kita
318c4bb80d Add examples folder filter to ya.make.in 2021-04-30 11:25:52 +03:00
Nikolai Kochetov
6b79403cb5 Rename and fix fuild. 2021-04-30 11:25:39 +03:00
Maksim Kita
aa71b4a6df
Merge pull request #22242 from hexiaoting/dev_arrayproduct
Introduce arrayProduct function
2021-04-30 09:55:21 +03:00
Maksim Kita
8c84f3fc8b
Merge pull request #23771 from kitaisreal/poco-timespan-reference-fix
Poco::Timespan reference fix
2021-04-30 09:49:01 +03:00
feng lv
aed2f337e9 Fix CLEAR COLUMN does not work after #21303 2021-04-30 05:02:32 +00:00
Maksim Kita
d0c0054ff0
Merge pull request #23732 from kitaisreal/external-loader-repository-fix-arcadia
ExternalLoaderRepository fix arcadia
2021-04-30 01:26:04 +03:00