Commit Graph

78858 Commits

Author SHA1 Message Date
Vxider
6e23e9f5ca Ping CI 2021-12-12 15:37:56 +00:00
mergify[bot]
dd4eaad2f3
Merge branch 'master' into watch-events-supports 2021-12-12 15:22:53 +00:00
tavplubix
be35ab171b
Merge pull request #32572 from azat/DROP-INSERT-UAF-fix
Fix table lifetime in case of parallel DROP TABLE and INSERT
2021-12-12 17:05:07 +03:00
Vxider
3f6fc6ce08 add window view watch events test 2021-12-12 11:46:40 +00:00
alexey-milovidov
0486c5f341
Merge pull request #32220 from azat/mt-fix-minmax-for-empty-part
[RFC] Fix minmax partition index during merge in case of empty part in future parts
2021-12-12 14:45:10 +03:00
mergify[bot]
72606749ab
Merge branch 'master' into watch-events-supports 2021-12-12 09:51:52 +00:00
Kseniia Sumarokova
5dc7d7e3ef
Merge pull request #32584 from kssenii/rabbitmq-fix
rabbitmq fix
2021-12-12 12:34:09 +03:00
Kseniia Sumarokova
b8210c37ea
Merge pull request #32585 from kssenii/add-test-issue-28316
Add test for issue 28316
2021-12-12 12:28:54 +03:00
alexey-milovidov
6779196c6b
Merge pull request #32587 from ClickHouse/reinterpret-perf
Slight performance improvement of "reinterpret" function
2021-12-12 12:14:43 +03:00
alexey-milovidov
b202bfac52
Merge pull request #32588 from ClickHouse/fix-bad-test-3
Fix bad test #32571
2021-12-12 12:13:36 +03:00
alexey-milovidov
09a6e826e7
Merge pull request #32591 from ClickHouse/fix-indecent-error-message
Fix indecent error message
2021-12-12 12:12:38 +03:00
Vxider
7eb18ea21e watch events support for window view 2021-12-12 07:45:55 +00:00
alexey-milovidov
26d606c158
Merge pull request #32456 from ClickHouse/fix-29890
Fix arraySlice with null args.
2021-12-12 06:38:17 +03:00
alexey-milovidov
71df622b1f
Merge pull request #31888 from ClickHouse/fix-31114
Remove LowCardinality from window function args.
2021-12-12 06:37:55 +03:00
alexey-milovidov
900e443900
Merge pull request #32589 from ClickHouse/fix-perf-test-5
Fix perf test `reinterpret_as`
2021-12-12 05:50:04 +03:00
Alexey Milovidov
453135eb63 Fix indecent error message 2021-12-12 05:24:47 +03:00
alexey-milovidov
151834d743
Merge pull request #32417 from azat/local-atomic-db-fix
clickhouse-local: fix CREATE DATABASE with Atomic engine
2021-12-12 04:33:59 +03:00
alexey-milovidov
33674cbe58
Merge pull request #32535 from azat/avg-ubsan
Suppress UBSan errors for avg() function
2021-12-12 04:32:44 +03:00
Alexey Milovidov
d677a5ab67 Fix perf test 2021-12-12 04:31:56 +03:00
alexey-milovidov
b8a15b666d
Merge pull request #32571 from azat/mv-non-phys-table
Fix LOGICAL_ERROR for MATERIALIZED VIEW over table functions (i.e. numbers())
2021-12-12 03:55:51 +03:00
Alexey Milovidov
e58e69923c Fix bad test 2021-12-12 03:55:23 +03:00
Alexey Milovidov
3b0f026827 Slight performance improvement of "reinterpret" function 2021-12-12 03:29:26 +03:00
alexey-milovidov
bf6e091fe0
Update CHANGELOG.md 2021-12-12 02:54:06 +03:00
alexey-milovidov
3e8ef66f52
Merge pull request #32472 from ClickHouse/rfraposa-patch-1
Update CHANGELOG.md
2021-12-12 02:53:08 +03:00
alexey-milovidov
a4a7b59cf3
Update CHANGELOG.md 2021-12-12 02:52:20 +03:00
alexey-milovidov
9179b338fa
Update CHANGELOG.md 2021-12-12 02:51:58 +03:00
alexey-milovidov
eaf1d764a7
Merge pull request #32578 from bharatnc/ncb/fixes
remove unused headers in test
2021-12-12 01:05:12 +03:00
alexey-milovidov
81f762f33a
Merge pull request #32583 from azat/perf-slow
[RFC] perf: do not fail in case of slow queries (to avoid hiding possible issues)
2021-12-12 01:04:50 +03:00
alexey-milovidov
a1cf07fdd3
Merge pull request #32580 from azat/remove-arcadia
Remove arcadia build support
2021-12-12 01:03:42 +03:00
kssenii
a8484ec06d Add test 2021-12-12 00:47:21 +03:00
kssenii
89db2c57f4 Fix 2021-12-12 00:19:06 +03:00
Azat Khuzhin
8a89b8e395 perf: do not fail in case of slow queries (to avoid hiding possible issues)
Do not stop processing pathologically slow queries,
since this may hide errors in other queries,
i.e. when the test failed on one of servers (upstream or from PR)
and someone interpret this is as OK with the following comment:

  "the failure was on the upstream server it is OK, PR should fix it"

Anyway there is almost zero such queries right now, and before merging
something this should be reviewed.
2021-12-12 00:15:25 +03:00
Vitaly Baranov
8f9b0b4ed0
Merge pull request #32575 from vitlibar/improve-quota-end-of-interval-calculation
Improve quota's end-of-interval calculations.
2021-12-11 22:16:04 +03:00
Azat Khuzhin
8268d8a8c3 Cleanup .gitattributes 2021-12-11 21:27:36 +03:00
Azat Khuzhin
57c027be0e Remove arcadia build support 2021-12-11 21:25:23 +03:00
Vitaly Baranov
463ce1fcee
Merge pull request #27822 from filimonov/kafka_protobuf_issue26643
Test for issue #26643
2021-12-11 20:31:22 +03:00
alexey-milovidov
9ec30b0c1d
Merge pull request #32579 from den-crane/patch-46
Doc. fixed grammar
2021-12-11 20:15:55 +03:00
alexey-milovidov
0bed774d83
Merge pull request #32574 from azat/remove-readline
[RFC] Remove readline support
2021-12-11 20:15:03 +03:00
Denny Crane
7ed4c75e63
Update tips.md
fixed grammar
2021-12-11 13:14:41 -04:00
bharatnc
a3dfb89927 remove unused headers in test 2021-12-11 08:30:22 -08:00
Kseniia Sumarokova
3084d5eac0
Merge pull request #32503 from Vxider/fix-flaky-window-view-tests
Fix flaky window view tests
2021-12-11 17:11:26 +03:00
Vitaly Baranov
eea269a829 Improve quota's end-of-interval calculations. 2021-12-11 13:56:38 +03:00
Azat Khuzhin
d8bf26f705 Remove even minimal support for readline 2021-12-11 11:33:57 +03:00
Azat Khuzhin
4e4837758a Remove readline support
- it was not nested for a long time
- replxx is an upstream way for completion
2021-12-11 11:29:59 +03:00
Vitaly Baranov
abe9dd3368
Merge pull request #32531 from vitlibar/fix-nested-array-sizes-for-missing-columns
Improve handling nested structures with missing columns while reading protobuf
2021-12-11 11:08:34 +03:00
mergify[bot]
1e28f7340e
Merge branch 'master' into kafka_protobuf_issue26643 2021-12-11 08:05:20 +00:00
Azat Khuzhin
ca9c5dc4eb Fix LOGICAL_ERROR for MATERIALIZED VIEW over table functions (i.e. numbers())
Replace LOGICAL_ERROR with QUERY_IS_NOT_SUPPORTED_IN_MATERIALIZED_VIEW
in this case.
2021-12-11 11:04:47 +03:00
Azat Khuzhin
9a71598973 Fix table lifetime in case of parallel DROP TABLE and INSERT
Stress tests founds [1]:

==527==WARNING: MemorySanitizer: use-of-uninitialized-value
    0 0x37078ffd in unsigned long std::__1::__cxx_atomic_fetch_add<unsigned long>(std::__1::__cxx_atomic_base_impl<unsigned long>*, unsigned long, std::__1::memory_order) obj-x86_64-linux-gnu/../contrib/libcxx/include/atomic:1050:12
    1 0x37078ffd in std::__1::__atomic_base<unsigned long, true>::fetch_add(unsigned long, std::__1::memory_order) obj-x86_64-linux-gnu/../contrib/libcxx/include/atomic:1719:17
    2 0x37078ffd in std::__1::__atomic_base<unsigned long, true>::operator++() obj-x86_64-linux-gnu/../contrib/libcxx/include/atomic:1756:57
    3 0x37078ffd in SimpleIncrement::get() obj-x86_64-linux-gnu/../src/Common/SimpleIncrement.h:20:16
    4 0x37078ffd in DB::MergeTreeDataWriter::writeTempPart(DB::BlockWithPartition&, std::__1::shared_ptr<DB::StorageInMemoryMetadata const> const&, std::__1::shared_ptr<DB::Context const>) obj-x86_64-linux-gnu/../src/Storages/MergeTree/MergeTreeDataWriter.cpp:276:46
    5 0x373c446c in DB::MergeTreeSink::consume(DB::Chunk) obj-x86_64-linux-gnu/../src/Storages/MergeTree/MergeTreeSink.cpp:27:65

  Uninitialized value was created by a heap deallocation
    6 0x32d481e8 in DB::DatabaseCatalog::TableMarkedAsDropped::~TableMarkedAsDropped() obj-x86_64-linux-gnu/../src/Interpreters/DatabaseCatalog.h:248:12
    7 0x32d3c134 in DB::DatabaseCatalog::dropTableDataTask() obj-x86_64-linux-gnu/../src/Interpreters/DatabaseCatalog.cpp:908:1

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/32534/fa6090f588dbf4cbb5f28bd2210847b070bb8218/stress_test__memory__actions_.html

The query was CREATE MATERIALIZED VIEW ... POPULATE AS SELECT ... from
00040_aggregating_materialized_view test.
2021-12-11 11:00:31 +03:00
Vitaly Baranov
94e2e3625b
Merge pull request #31656 from sunny19930321/fix-use-quota-bug
Fix use quota bug
2021-12-11 11:00:23 +03:00
Kseniia Sumarokova
9ede6beca7
Merge pull request #32534 from azat/local-file-table-fix
Fix processing initial table (--table/stdin) in clickhouse-local
2021-12-11 10:45:19 +03:00