avogar
02bd5f6542
Finalize write buffers in case of exception
2022-05-06 17:30:18 +00:00
Robert Schulze
330212e0f4
Remove inherited create() method + disallow copying
...
The original motivation for this commit was that shared_ptr_helper used
std::shared_ptr<>() which does two heap allocations instead of
make_shared<>() which does a single allocation. Turned out that
1. the affected code (--> Storages/) is not on a hot path (rendering the
performance argument moot ...)
2. yet copying Storage objects is potentially dangerous and was
previously allowed.
Hence, this change
- removes shared_ptr_helper and as a result all inherited create() methods,
- instead, Storage objects are now created using make_shared<>() by the
caller (for that to work, many constructors had to be made public), and
- all Storage classes were marked as noncopyable using boost::noncopyable.
In sum, we are (likely) not making things faster but the code becomes
cleaner and harder to misuse.
2022-05-02 08:46:52 +02:00
Anton Popov
866a51a948
reduce number of stat calls in storage File
2022-04-25 22:13:15 +00:00
Kruglov Pavel
34c342fdd3
Merge pull request #36205 from Avogar/improve-globs
...
Some refactoring around schema inference with globs
2022-04-25 13:14:46 +02:00
avogar
1f252cedfe
Make better
2022-04-19 19:16:47 +00:00
Anton Popov
2de6668b3f
show names of erroneous files
2022-04-16 00:10:47 +00:00
avogar
1c065f8c7a
Some refactoring around schema inference with globs
2022-04-13 17:02:48 +00:00
xiedeyantu
9441111833
fix INSERT INTO table FROM INFILE does not display progress bar ( #35429 )
...
* fix INSERT INTO table FROM INFILE does not display progress bar
* Update StorageFile.cpp
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2022-03-23 14:24:59 +01:00
Anton Popov
fcdebea925
Merge remote-tracking branch 'upstream/master' into HEAD
2022-02-25 13:41:30 +03:00
Kruglov Pavel
dd863ca2a0
Merge branch 'master' into fix-url-globs
2022-02-16 12:45:31 +03:00
Maksim Kita
e2c8ba9ab2
Added performance test
2022-02-12 16:05:35 +00:00
avogar
bfa96463ca
Fix possible error 'file_size: Operation not supported'
2022-02-10 09:23:27 +03:00
Anton Popov
18940b8637
Merge remote-tracking branch 'upstream/master' into HEAD
2022-02-09 23:38:38 +03:00
avogar
84087c1554
Improve schema inference with globs
2022-02-09 19:16:15 +03:00
feng lv
7bf2243431
use LowCardinality for _file and _path virtual columns in StorageFile
...
fix
2022-02-04 14:15:56 +00:00
Anton Popov
836a348a9c
Merge remote-tracking branch 'upstream/master' into HEAD
2022-02-01 15:23:07 +03:00
Kruglov Pavel
a9d0beb7ae
Fix data race in StorageFile ( #34113 )
...
* Fix data race in StorageFile
* Update StorageFile.h
* Fix
2022-01-31 11:58:40 +03:00
Anton Popov
78b9f15abb
Merge remote-tracking branch 'upstream/master' into HEAD
2022-01-30 03:24:37 +03:00
Kruglov Pavel
7873b4475f
Merge branch 'master' into autodetect-format
2022-01-25 10:56:52 +03:00
avogar
a6740d2f9a
Detect format and schema for stdin in clickhouse-local
2022-01-25 10:25:37 +03:00
Anton Popov
e8ce091e68
Merge remote-tracking branch 'upstream/master' into HEAD
2022-01-21 20:11:18 +03:00
avogar
af54ca4866
Fix partition write
2022-01-14 21:21:36 +03:00
avogar
253035a5df
Fix
2022-01-14 19:17:06 +03:00
avogar
89a181bd19
Make better
2022-01-14 18:16:18 +03:00
avogar
97788b9c21
Allow to create new files on insert for File/S3/HDFS engines
2021-12-29 21:19:13 +03:00
avogar
8112a71233
Implement schema inference for most input formats
2021-12-29 12:18:56 +03:00
Anton Popov
99ebabd822
Merge remote-tracking branch 'upstream/master' into HEAD
2021-12-17 19:02:29 +03:00
Alexey Milovidov
71926a3a97
Fix surprisingly bad code in function "file"
2021-12-13 07:57:54 +03:00
Anton Popov
6f4d9a53b2
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-12-01 15:54:33 +03:00
Raúl Marín
051dddd8df
Reduce dependencies on ASTIdentifier.h
...
Goes from rebuilding 483 objects to 165 when it's modified
2021-11-26 16:49:40 +01:00
Anton Popov
ccd78e3838
Merge remote-tracking branch 'upstream/master' into HEAD
2021-11-22 17:19:35 +03:00
Kruglov Pavel
d9c1a0c8ec
Merge branch 'master' into fix-write-buffers
2021-11-20 17:48:24 +03:00
Kruglov Pavel
1bbe0df945
Fix perf test
2021-11-16 11:41:50 +03:00
avogar
8f7be52ac4
Update test, remove commented code
2021-11-15 14:58:18 +03:00
avogar
e5661b9b62
Minor change
2021-11-11 21:09:21 +03:00
avogar
c521a9131a
Small refactoring of WriteBiffer-s
2021-11-11 02:11:18 +03:00
Anton Popov
a20922b2d3
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-11-09 15:36:25 +03:00
avogar
2dd4393ca1
Small refactoring in formats
2021-11-03 20:07:05 +03:00
kssenii
03d7476864
One more fix
2021-10-29 00:50:59 +03:00
kssenii
d39840376f
Review fixes
2021-10-28 15:44:12 +03:00
kssenii
1d743b9259
Partitoned write
2021-10-25 19:23:44 +03:00
Kseniia Sumarokova
c692155c7e
Merge pull request #30309 from kssenii/fix-file-symlinks
...
Fix symlinks in file table function
2021-10-20 11:09:51 +03:00
Kseniia Sumarokova
5633865df1
Update src/Storages/StorageFile.cpp
...
Co-authored-by: Nikolay Degterinsky <43110995+evillique@users.noreply.github.com>
2021-10-17 14:16:40 +03:00
kssenii
059fc1de69
Allow symlinks in file storage
2021-10-17 09:11:06 +00:00
Nikolai Kochetov
a08c98d760
Move some files.
2021-10-16 17:03:50 +03:00
Nikolai Kochetov
ab28c6c855
Remove BlockInputStream interfaces.
2021-10-14 13:25:43 +03:00
Nikolai Kochetov
2957971ee3
Remove some last streams.
2021-10-13 21:22:02 +03:00
Nikolai Kochetov
ec18340351
Remove streams from formats.
2021-10-11 19:11:50 +03:00
Nikolai Kochetov
341553febd
Fix build.
2021-09-16 20:40:42 +03:00
Nikolai Kochetov
b997214620
Rename QueryPipeline to QueryPipelineBuilder.
2021-09-14 20:48:18 +03:00
Nikolai Kochetov
f569a3e3f7
Merge branch 'master' into rewrite-pushing-to-views
2021-09-09 20:30:23 +03:00
Anton Popov
4c388e3d84
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-09-09 14:10:16 +03:00
Nikolai Kochetov
66a76ab70f
Rewrite PushingToViewsBlockOutputStream part 6
2021-09-03 20:29:36 +03:00
kssenii
c5ee335c68
Fix tests
2021-08-22 21:41:09 +03:00
kssenii
14afb3c509
File progress for local fix
2021-08-22 20:33:55 +03:00
Anton Popov
e36736b50c
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-08-02 22:52:02 +03:00
Nikolai Kochetov
9b5a816b43
Merge branch 'master' into output-streams-to-processors
2021-07-26 18:03:11 +03:00
Nikolai Kochetov
0eb563dc1b
Fix more tests.
2021-07-26 17:47:29 +03:00
Nikolai Kochetov
fa1c223269
Fix some tests.
2021-07-26 13:08:40 +03:00
Alexey Milovidov
2f2dce399a
Fix style
2021-07-25 01:26:21 +03:00
Alexey Milovidov
215505b985
Remove unused error code
2021-07-24 19:51:56 +03:00
Alexey Milovidov
774f6d2617
Allow to read file descriptor multiple times in File storage
2021-07-24 19:50:03 +03:00
BoloniniD
2fa02061b7
Fix parallel reads
2021-07-24 15:31:35 +03:00
BoloniniD
07c57edbfc
Merge branch 'master' of github.com:ClickHouse/ClickHouse into pipe_reading
2021-07-23 23:39:38 +03:00
Nikolai Kochetov
9c92f43359
Update storages.
2021-07-23 22:33:59 +03:00
Nikolai Kochetov
2dc5c89b66
Update Storage::write
2021-07-23 17:25:35 +03:00
Nikolai Kochetov
f38de35b14
Rename some constants.
2021-07-21 19:13:17 +03:00
Nikolai Kochetov
179ec05a72
Remove some streams.
2021-07-20 21:18:43 +03:00
BoloniniD
49ee24e824
What if we replace unique_lock with shared?
2021-07-20 19:22:41 +03:00
Anton Popov
f99374cca6
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-07-20 18:20:21 +03:00
Nikita Mikhaylov
4d3f828beb
Merge pull request #26314 from kssenii/fix-hdfs-crash
...
Fix hdfs crash
2021-07-20 15:01:56 +03:00
BoloniniD
a9deeb6a78
Trying to fix freeze on union all
2021-07-18 15:55:24 +03:00
Alexey Milovidov
261a220227
Remove some code
2021-07-17 21:06:46 +03:00
BoloniniD
19b673fb3b
Style fix for error message
2021-07-17 15:30:03 +03:00
kssenii
61652acede
Add test
2021-07-14 22:49:16 +03:00
BoloniniD
407652457f
Added fstat for table fd + more fixes
2021-07-09 12:20:11 +03:00
Anton Popov
3ed7f5a6cc
dynamic subcolumns: add snapshot for storage
2021-07-09 06:15:41 +03:00
Anton Popov
072e65b728
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-07-07 17:20:38 +03:00
BoloniniD
0f584c3e76
Fix style and add check for seekability
2021-07-07 14:21:32 +03:00
BoloniniD
077c147e8f
First changes after review
2021-07-06 13:23:39 +03:00
BoloniniD
e988f35d86
Added read counter to checker
2021-07-04 21:15:40 +03:00
BoloniniD
bbe33f061e
Merge branch 'master' of github.com:ClickHouse/ClickHouse into pipe_reading
2021-07-04 15:36:49 +03:00
BoloniniD
6f5b4ba49e
First look
2021-07-01 17:04:10 +03:00
Raúl Marín
bfc122df64
Fix some typos in Storage classes
2021-06-28 19:03:56 +02:00
Anton Popov
205a23282b
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-06-07 19:38:22 +03:00
kssenii
de277f8ac4
Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into progress-bar
2021-06-01 07:58:19 +00:00
Anton Popov
0bdf9d207c
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-05-26 00:25:47 +03:00
kssenii
31107816bb
fs::absolute to fs::canonical
2021-05-24 20:37:54 +03:00
kssenii
9b8df78fdd
Merge branch 'master' of github.com:ClickHouse/ClickHouse into poco-file-to-std-fs
2021-05-17 17:42:05 +03:00
kssenii
e9c3bc1836
Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into progress-bar
2021-05-16 20:48:35 +00:00
kssenii
c25be65ebf
Refactor progress bar, adjust progress indication for reading from file
2021-05-14 06:16:31 +00:00
kssenii
02288359c5
Less manual concatenation of paths
2021-05-08 13:59:55 +03:00
Anton Popov
e44706911e
dynamic columns: better getting of sample block
2021-05-05 02:02:54 +03:00
kssenii
c33f358a9a
Better way to track progress, display progress for ch-client
2021-04-28 19:12:28 +00:00
kssenii
563f8a97c6
Fix build, typos check
2021-04-27 17:01:41 +00:00
kssenii
eeb71672a0
Change in Storages/*
2021-04-27 16:49:37 +03:00
kssenii
3a0372535e
Show progress only with --progress option
2021-04-27 13:21:42 +00:00
kssenii
1135c47082
Fixes
2021-04-27 11:47:57 +00:00
kssenii
5efd075ad2
Slightly bette
2021-04-27 00:24:04 +00:00
kssenii
ffcfe5f9a1
Progress bar for file table engine
2021-04-26 21:02:52 +00:00