Azat Khuzhin
75e46f865c
Avoid uncaught exception for onFault handler
...
onFault() is called from the std::thread, and it should catch all
exceptions, otherwise you can unrelated fatal errors.
<details>
<summary>stacktrace</summary>
2024.04.08 13:15:29.526847 [ 2067427 ] {} <Fatal> BaseDaemon: (version 24.2.2.71 (official build), build id: 57F857DCFE8BA6838F6463E4665CD700852BFF0E, git hash: 9293d361e7
) (from thread 2118603) Terminate called for uncaught exception:
2024.04.08 13:15:29.526904 [ 2067427 ] {} <Fatal> BaseDaemon: Code: 210. DB::NetException: I/O error: Broken pipe, while writing to socket (10.61.7.253:9000 -> 10.101.53.134:46036). (NETWORK_ERROR), Stack trace (when copying this message, always include the lines below):
2024.04.08 13:15:29.526983 [ 2067427 ] {} <Fatal> BaseDaemon:
2024.04.08 13:15:29.527042 [ 2067427 ] {} <Fatal> BaseDaemon: 0. ./build_docker/./src/Common/Exception.cpp:96: DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000000cf5af1b
2024.04.08 13:15:29.527061 [ 2067427 ] {} <Fatal> BaseDaemon: 1. ./contrib/llvm-project/libcxx/include/string:1499: DB::NetException::NetException<String, String, String>(int, FormatStringHelperImpl<std::type_identity<String>::type, std::type_identity<String>::type, std::type_identity<String>::type>, String&&, String&&, String&&) @ 0x000000000d07dfe1
2024.04.08 13:15:29.527082 [ 2067427 ] {} <Fatal> BaseDaemon: 2. ./build_docker/./src/IO/WriteBufferFromPocoSocket.cpp:0: DB::WriteBufferFromPocoSocket::nextImpl() @ 0x000000000d07e97e
2024.04.08 13:15:29.527125 [ 2067427 ] {} <Fatal> BaseDaemon: 3. ./src/IO/WriteBuffer.h:65: DB::TCPHandler::sendLogs() @ 0x0000000012fd31c1
2024.04.08 13:15:29.527144 [ 2067427 ] {} <Fatal> BaseDaemon: 4. ./contrib/llvm-project/libcxx/include/atomic:958: void std::__function::__policy_invoker<void ()>::__call_impl<std::__function::__default_alloc_func<DB::TCPHandler::runImpl()::$_0, void ()>>(std::__function::__policy_storage const*) @ 0x0000000012fdcc6e
2024.04.08 13:15:29.527163 [ 2067427 ] {} <Fatal> BaseDaemon: 5. ./contrib/llvm-project/libcxx/include/__functional/function.h:0: ? @ 0x000000000d25c65b
2024.04.08 13:15:29.527182 [ 2067427 ] {} <Fatal> BaseDaemon: 6. ./build_docker/./src/Daemon/BaseDaemon.cpp:286: void* std::__thread_proxy[abi:v15000]<std::tuple<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, SignalListener::run()::'lambda'()>>(void*) @ 0x000000000d25e775
2024.04.08 13:15:29.527191 [ 2067427 ] {} <Fatal> BaseDaemon: 7. ? @ 0x00007f0fe4906609
2024.04.08 13:15:29.527211 [ 2067427 ] {} <Fatal> BaseDaemon: 8. ? @ 0x00007f0fe482b353
2024.04.08 13:15:29.534235 [ 2118604 ] {} <Fatal> BaseDaemon: ########## Short fault info ############
2024.04.08 13:15:29.534347 [ 2118604 ] {} <Fatal> BaseDaemon: (version 24.2.2.71 (official build), build id: 57F857DCFE8BA6838F6463E4665CD700852BFF0E, git hash: 9293d361e7
) (from thread 2118603) Received signal 6
2024.04.08 13:15:29.534476 [ 2118604 ] {} <Fatal> BaseDaemon: Signal description: Aborted
2024.04.08 13:15:29.534484 [ 2118604 ] {} <Fatal> BaseDaemon:
2024.04.08 13:15:29.534510 [ 2118604 ] {} <Fatal> BaseDaemon: Stack trace: 0x00007f0fe474f00b 0x00007f0fe472e859 0x000000000d24f72e 0x0000000017d15be3 0x0000000017d15818 0x0000000012fd350d 0x0000000012fdcc6e 0x000000000d25c65b 0x000000000d25e775 0x00007f0fe4906609 0x00007f0fe482b353
2024.04.08 13:15:29.534531 [ 2118604 ] {} <Fatal> BaseDaemon: ########################################
2024.04.08 13:15:29.534609 [ 2118604 ] {} <Fatal> BaseDaemon: (version 24.2.2.71 (official build), build id: 57F857DCFE8BA6838F6463E4665CD700852BFF0E, git hash: 9293d361e7
) (from thread 2118603) (no query) Received signal Aborted (6)
2024.04.08 13:15:29.534638 [ 2118604 ] {} <Fatal> BaseDaemon:
2024.04.08 13:15:29.534663 [ 2118604 ] {} <Fatal> BaseDaemon: Stack trace: 0x00007f0fe474f00b 0x00007f0fe472e859 0x000000000d24f72e 0x0000000017d15be3 0x0000000017d15818 0x0000000012fd350d 0x0000000012fdcc6e 0x000000000d25c65b 0x000000000d25e775 0x00007f0fe4906609 0x00007f0fe482b353
2024.04.08 13:15:29.534711 [ 2118604 ] {} <Fatal> BaseDaemon: 2. ? @ 0x00007f0fe474f00b
2024.04.08 13:15:29.534728 [ 2118604 ] {} <Fatal> BaseDaemon: 3. ? @ 0x00007f0fe472e859
2024.04.08 13:15:29.613230 [ 2118604 ] {} <Fatal> BaseDaemon: 4.0. inlined from ./contrib/llvm-project/libcxxabi/src/cxa_exception.cpp:670: __cxa_decrement_exception_refcount
2024.04.08 13:15:29.613283 [ 2118604 ] {} <Fatal> BaseDaemon: 4.1. inlined from ./contrib/llvm-project/libcxx/src/support/runtime/exception_pointer_cxxabi.ipp:17: ~exception_ptr
2024.04.08 13:15:29.613311 [ 2118604 ] {} <Fatal> BaseDaemon: 4. ./build_docker/./src/Daemon/BaseDaemon.cpp:591: terminate_handler() @ 0x000000000d24f72e
2024.04.08 13:15:29.617590 [ 2118604 ] {} <Fatal> BaseDaemon: 5. ./build_docker/./contrib/llvm-project/libcxxabi/src/cxa_handlers.cpp:61: std::__terminate(void (*)()) @ 0x0000000017d15be3
2024.04.08 13:15:29.619575 [ 2118604 ] {} <Fatal> BaseDaemon: 6. ./build_docker/./contrib/llvm-project/libcxxabi/src/cxa_exception.cpp:0: __cxa_rethrow @ 0x0000000017d15818
2024.04.08 13:15:30.104097 [ 2118604 ] {} <Fatal> BaseDaemon: 7.0. inlined from ./src/IO/WriteBuffer.h:0: DB::WriteBuffer::next()
2024.04.08 13:15:30.104331 [ 2118604 ] {} <Fatal> BaseDaemon: 7.1. inlined from ./build_docker/./src/Server/TCPHandler.cpp:2225: DB::TCPHandler::sendLogData(DB::Block const&)
2024.04.08 13:15:30.104408 [ 2118604 ] {} <Fatal> BaseDaemon: 7. ./build_docker/./src/Server/TCPHandler.cpp:2303: DB::TCPHandler::sendLogs() @ 0x0000000012fd350d
2024.04.08 13:15:30.217481 [ 2118604 ] {} <Fatal> BaseDaemon: 8.0. inlined from ./contrib/llvm-project/libcxx/include/atomic:958: double std::__cxx_atomic_load[abi:v15000]<double>(std::__cxx_atomic_base_impl<double> const*, std::memory_order)
2024.04.08 13:15:30.217579 [ 2118604 ] {} <Fatal> BaseDaemon: 8.1. inlined from ./contrib/llvm-project/libcxx/include/atomic:1588: std::__atomic_base<double, false>::load[abi:v15000](std::memory_order) const
2024.04.08 13:15:30.217617 [ 2118604 ] {} <Fatal> BaseDaemon: 8.2. inlined from ./src/Common/ThreadFuzzer.cpp:407: pthread_mutex_unlock
2024.04.08 13:15:30.217644 [ 2118604 ] {} <Fatal> BaseDaemon: 8.3. inlined from ./contrib/llvm-project/libcxx/include/__threading_support:314: std::__libcpp_mutex_unlock[abi:v15000](pthread_mutex_t*)
2024.04.08 13:15:30.217676 [ 2118604 ] {} <Fatal> BaseDaemon: 8.4. inlined from ./contrib/llvm-project/libcxx/src/mutex.cpp:52: std::mutex::unlock()
2024.04.08 13:15:30.217699 [ 2118604 ] {} <Fatal> BaseDaemon: 8.5. inlined from ./contrib/llvm-project/libcxx/include/__mutex_base💯 ~lock_guard
2024.04.08 13:15:30.217747 [ 2118604 ] {} <Fatal> BaseDaemon: 8.6. inlined from ./build_docker/./src/Server/TCPHandler.cpp:392: operator()
2024.04.08 13:15:30.217776 [ 2118604 ] {} <Fatal> BaseDaemon: 8.7. inlined from ./contrib/llvm-project/libcxx/include/__functional/invoke.h:394: ?
2024.04.08 13:15:30.217796 [ 2118604 ] {} <Fatal> BaseDaemon: 8.8. inlined from ./contrib/llvm-project/libcxx/include/__functional/invoke.h:479: ?
2024.04.08 13:15:30.217859 [ 2118604 ] {} <Fatal> BaseDaemon: 8.9. inlined from ./contrib/llvm-project/libcxx/include/__functional/function.h:235: ?
2024.04.08 13:15:30.217878 [ 2118604 ] {} <Fatal> BaseDaemon: 8. ./contrib/llvm-project/libcxx/include/__functional/function.h:716: ? @ 0x0000000012fdcc6e
2024.04.08 13:15:30.240809 [ 2118604 ] {} <Fatal> BaseDaemon: 9. ./contrib/llvm-project/libcxx/include/__functional/function.h:0: ? @ 0x000000000d25c65b
2024.04.08 13:15:30.283617 [ 2118604 ] {} <Fatal> BaseDaemon: 10.0. inlined from ./build_docker/./src/Daemon/BaseDaemon.cpp:286: operator()
2024.04.08 13:15:30.283686 [ 2118604 ] {} <Fatal> BaseDaemon: 10.1. inlined from ./contrib/llvm-project/libcxx/include/__functional/invoke.h:394: ?
2024.04.08 13:15:30.283725 [ 2118604 ] {} <Fatal> BaseDaemon: 10.2. inlined from ./contrib/llvm-project/libcxx/include/thread:284: void std::__thread_execute[abi:v15000]<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, SignalListener::run()::'lambda'()>(std::tuple<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, SignalListener::run()::'lambda'()>&, std::__tuple_indices<>)
2024.04.08 13:15:30.283755 [ 2118604 ] {} <Fatal> BaseDaemon: 10. ./contrib/llvm-project/libcxx/include/thread:295: void* std::__thread_proxy[abi:v15000]<std::tuple<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, SignalListener::run()::'lambda'()>>(void*) @ 0x000000000d25e775
2024.04.08 13:15:30.283799 [ 2118604 ] {} <Fatal> BaseDaemon: 11. ? @ 0x00007f0fe4906609
2024.04.08 13:15:30.283821 [ 2118604 ] {} <Fatal> BaseDaemon: 12. ? @ 0x00007f0fe482b353
2024.04.08 13:15:30.574588 [ 2118604 ] {} <Fatal> BaseDaemon: Integrity check of the executable successfully passed (checksum: 3485110FABDB0C94202BD684999A9814)
2024.04.08 13:15:30.574704 [ 2118604 ] {} <Fatal> BaseDaemon: Report this error to https://github.com/ClickHouse/ClickHouse/issues
</details>
v2: fatal logging
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-08 20:20:25 +02:00
Kruglov Pavel
d911d7d2b1
Merge pull request #62290 from ClickHouse/Avogar-patch-1
...
Mark format RowBinaryWithDefaults as not suitable for output
2024-04-04 21:37:03 +02:00
Alexey Milovidov
d4a01dad61
Merge pull request #62284 from ClickHouse/fix-default-value-for-pretty-format-row-numbers
...
Fix docs about default value of `output_format_pretty_row_numbers`
2024-04-04 19:38:36 +02:00
Yarik Briukhovetskyi
05a2d89aa6
Merge pull request #62293 from Misz606/patch-4
...
Update README.md
2024-04-04 19:27:45 +02:00
Yarik Briukhovetskyi
7ef5e25a26
empty commit
2024-04-04 19:16:38 +02:00
Nikolai Kochetov
300904dc83
Merge pull request #60997 from kitaisreal/context-get-global-temporary-volume-use-shared-lock
...
Context getGlobalTemporaryVolume use shared lock
2024-04-04 18:30:20 +02:00
Misz606
51aff6d63c
Update README.md
...
Localy should be spelled locally.
2024-04-04 12:09:05 -04:00
Raúl Marín
1f1a0ff7d4
Merge pull request #62232 from Algunenano/paranoid
...
Include table name in paranoid checks
2024-04-04 16:27:35 +02:00
Kruglov Pavel
01fecadabf
Mark format RowBinaryWithDefaults as not suitable for output
2024-04-04 15:35:51 +02:00
Robert Schulze
7ce2a47ba5
Merge pull request #62265 from rschu1ze/static-instance
...
Don't access static members through instance
2024-04-04 14:36:03 +02:00
Yarik Briukhovetskyi
edacb991e0
Merge pull request #62257 from yariks5s/fix_retention_docs
...
Fix s3-style link mapper for gcs
2024-04-04 14:30:33 +02:00
Yarik Briukhovetskyi
a0925e6bc4
empty commit
2024-04-04 14:19:19 +02:00
Kseniia Sumarokova
1a701921ff
Merge pull request #62160 from ClickHouse/add-more-logging
...
Add some logging
2024-04-04 13:48:28 +02:00
János Benjamin Antal
5d67793609
Fix docs about default value of output_format_pretty_row_numbers
2024-04-04 11:41:28 +00:00
Antonio Andelic
6197a62f0f
Merge pull request #62175 from ClickHouse/user-specific-s3-backup-on-cluster
...
User specific S3 endpoint for Backup/Restore on cluster
2024-04-04 12:46:29 +02:00
Igor Nikonov
a98c3ec632
Merge pull request #62260 from ClickHouse/fix-02980_dist_insert_readonly_replica
...
Disable 02980_dist_insert_readonly_replica for SMT
2024-04-04 12:08:03 +02:00
Dmitry Novik
d86eae3dd9
Merge pull request #62186 from ClickHouse/analyzer-query-param
...
Analyzer: Fix query parameter resolution
2024-04-04 11:26:12 +02:00
vdimir
b4ae81ee00
Merge pull request #62253 from ClickHouse/vdimir/analyzer_legacy_lambda_syntax
...
Fix lambda(tuple(x), x + 1) syntax in analyzer
2024-04-04 11:21:03 +02:00
Robert Schulze
d5229da1ec
Fix tidy build
2024-04-04 09:09:03 +00:00
kssenii
b91d446630
Ping CI
2024-04-04 10:57:29 +02:00
Kseniia Sumarokova
ccd3d7ae18
Merge pull request #62261 from ClickHouse/fix-logical-error-in-cache-eviction
...
Fix logical error from fs cache in stress test
2024-04-04 10:47:22 +02:00
Maksim Kita
414f3aebef
Context getGlobalTemporaryVolume use shared lock
2024-04-04 11:32:39 +03:00
Antonio Andelic
03feab3d20
Merge pull request #62250 from ClickHouse/bad-boy-const
...
Correctly handle const columns in DistinctTransfom
2024-04-04 09:13:40 +02:00
robot-clickhouse
3e66b338b4
Merge pull request #62267 from JosephRedfern/patch-1
...
Correct config key typo in S3 Table Engine documentation
2024-04-03 23:56:48 +02:00
Yarik Briukhovetskyi
3c61a7f4bf
Update storing-data.md
2024-04-03 23:34:31 +02:00
Robert Schulze
dda1a0b9f0
Also enable modernize-use-override
2024-04-03 20:44:02 +00:00
Robert Schulze
d905b83369
Fix something bad
2024-04-03 20:12:22 +00:00
Joseph Redfern
2578ceddad
Correct typo in "use_invironment_credentials" configuration option
...
`use_environment_credentials was incorrectly specified as `use_invironment_credentials`
2024-04-03 21:09:47 +01:00
Robert Schulze
9626506585
More fixes
2024-04-03 19:18:31 +00:00
Robert Schulze
de2a0be025
Don't access static members through instance
...
- clang-tidy rightfully complains (-readability-static-accessed-through-instance)
- not going to enable the warning for now to avoid breaking the build
2024-04-03 18:50:33 +00:00
Kruglov Pavel
9fa84f0397
Merge pull request #61442 from ClickHouse/revert-61435-revert-61316-patch-1
...
Revert "Revert "Updated format settings references in the docs (datetime.md)""
2024-04-03 19:46:03 +02:00
kssenii
c70ecfe5f3
Fix
2024-04-03 19:18:56 +02:00
kssenii
2db1e34517
Better logger name
2024-04-03 19:06:33 +02:00
Igor Nikonov
463691922c
Fix: disable test for SMT
2024-04-03 17:05:49 +00:00
yariks5s
ca27cf3fde
fix mapper for gcs
2024-04-03 16:38:41 +00:00
SmitaRKulkarni
9bb185593e
Merge pull request #61988 from ClickHouse/Azure_fix_exception_in_finalize
...
Fix WriteBufferAzureBlobStorage destructor uncaught exception
2024-04-03 18:22:27 +02:00
Kruglov Pavel
f8ef9fc5d3
Merge pull request #62014 from Avogar/json-extract-variant
...
Support Variant in JSONExtract functions
2024-04-03 17:20:53 +02:00
Kruglov Pavel
7694d78fac
Merge pull request #62251 from ClickHouse/Avogar-patch-1
...
Remove reverted PR from 24.3 changelog
2024-04-03 17:15:20 +02:00
Kruglov Pavel
bbcecd2660
Remove reverted PR from 24.3 changelog
2024-04-03 17:07:44 +02:00
Kruglov Pavel
3116650fa9
Merge pull request #61201 from ClickHouse/revert-61200-revert-60430-max-parallel-replicas-validate
...
Don't allow to set max_parallel_replicas to 0 as it doesn't make sense
2024-04-03 17:05:59 +02:00
Nikita Mikhaylov
6661484e55
Proper fix for LowCardinality together with JSONExtact functions ( #61957 )
2024-04-03 16:31:01 +02:00
Antonio Andelic
d19d09e31e
Correctly handle const columns in DistinctTransfom
2024-04-03 16:17:56 +02:00
Anton Popov
ec22d64fc8
Merge pull request #62195 from CurtizJ/lightweight-deletes-setting
...
Add setting `lightweight_deletes_sync`
2024-04-03 14:34:51 +02:00
Dmitry Novik
90ac11171c
Fix crash
2024-04-03 12:18:54 +00:00
Kruglov Pavel
bb5ffa6888
Merge pull request #61883 from Avogar/skip-bad-escapings
...
Mark CANNOT_PARSE_ESCAPE_SEQUENCE error as parse error to be able to skip it in row input formats
2024-04-03 13:59:21 +02:00
Kruglov Pavel
21abaa14e7
Merge pull request #61951 from Avogar/fix-exception-in-format
...
Fix writing exception message in output format in HTTP when http_wait_end_of_query is used
2024-04-03 13:44:30 +02:00
Raúl Marín
c943018025
Include table name in paranoid checks
2024-04-03 13:00:25 +02:00
Sema Checherinda
19e85c58cf
Merge pull request #62068 from ClickHouse/chesema-fix-url-storage
...
ReadWriteBufferFromHTTP set right header host when redirected
2024-04-03 12:52:49 +02:00
robot-clickhouse
fd0746bab8
Merge pull request #62222 from ClickHouse/pufit/junk/doc-fix-1
...
Docs formatting typo
2024-04-03 12:39:45 +02:00
vdimir
71450c909a
Fix lambda(tuple(x), x + 1) syntax in analyzer
2024-04-03 10:39:43 +00:00