Commit Graph

3752 Commits

Author SHA1 Message Date
alexey-milovidov
40c9b0ae1b
Merge pull request #19461 from ClickHouse/great-circle-distance-ubsan
Avoid UBSan report in greatCircleDistance
2021-01-23 12:03:02 +03:00
alexey-milovidov
bbaa0786d9
Merge pull request #19460 from ClickHouse/running-difference-ubsan
Fix UBSan report in runningDifference
2021-01-23 12:02:48 +03:00
alexey-milovidov
474ff29ded
Merge pull request #19459 from ClickHouse/array-slice-ubsan
Fix UBSan report in arraySlice and substring
2021-01-23 12:02:34 +03:00
Maksim Kita
f5deb6d523
Merge pull request #19354 from kitaisreal/accurate-cast-or-null-fixed-unitialized-values
Function accurateCastOrNull fixed unitialized values for numeric cast
2021-01-23 10:58:52 +03:00
Azat Khuzhin
86ead0f0a9 Suppress UBsan for addMinutes/addHours/addWeeks with inf
https://clickhouse-test-reports.s3.yandex.net/19466/bb6f775b89da564cff9892a2443332a758e884c0/fuzzer_ubsan/report.html#fail1
2021-01-23 08:31:20 +03:00
alexey-milovidov
feebf64cb1
Merge pull request #19397 from ClickHouse/aes-msan
Fix MSan report in AES functions
2021-01-23 04:47:36 +03:00
Alexey Milovidov
b326a4b7f9 Integrate with Big List of Naughty Strings for better fuzzing 2021-01-23 04:42:04 +03:00
Alexey Milovidov
1b6ee55c6a More tests 2021-01-23 04:26:03 +03:00
Alexey Milovidov
7005e3a826 Fix wrong serde of ColumnsDescription 2021-01-23 04:11:18 +03:00
Alexey Milovidov
02d28c1f9b Fix UBSan report in avgWeighted 2021-01-23 03:17:58 +03:00
Alexey Milovidov
f7db6e10d3 Fix very strange code in AES functions 2021-01-23 02:35:40 +03:00
Alexey Milovidov
505898747e Fix buffer overflow in DateLUT 2021-01-23 01:58:41 +03:00
Alexey Milovidov
bbe3c54f34 Merge branch 'aes-msan' into aes-remove-complications 2021-01-23 00:48:45 +03:00
Azat Khuzhin
bb6f775b89 Fix UBsan report in arraySlice (with INT64_MIN as offset)
- arraySlice([], INT64_MIN) -- FunctionArraySlice::executeImpl

Found with fuzzer [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/19378/2c42600cf9bd8e9962b5b5a0ebb4bf11a10887ea/fuzzer_ubsan/report.html#fail1

v2: removed fixes that is already included into #19459
    - arraySlice(groupArray([]), INT64_MIN) -- sliceDynamicOffsetUnbounded
2021-01-23 00:25:50 +03:00
Azat Khuzhin
f2910deec2 Fix UBsan report in date functions
Found with fuzzer [1]:

  [1]: https://clickhouse-test-reports.s3.yandex.net/19381/95c9e57ec13e450ec6535cf723f504a2e68e3e2c/fuzzer_ubsan/report.html#fail1
2021-01-23 00:25:49 +03:00
Alexey Milovidov
0528ca60d6 Avoid UBSan report in greatCircleDistance 2021-01-23 00:03:59 +03:00
alexey-milovidov
25ea281297
Merge pull request #19360 from vdimir/issue-18197
Fix default value in join types with non-zero default (close #18197)
2021-01-22 23:51:56 +03:00
Alexey Milovidov
4047542b61 Fix UBSan report in runningDifference 2021-01-22 23:46:51 +03:00
Alexey Milovidov
4afcb94a8a Fix Style check 2021-01-22 23:41:26 +03:00
Alexey Milovidov
ae8de8259f Fix UBSan report in substring 2021-01-22 23:40:04 +03:00
alexey-milovidov
a04360e6b2
Update 01664_array_slice_ubsan.sql 2021-01-22 23:36:10 +03:00
Alexey Milovidov
fb71a0704e Fix UBSan report in arraySlice 2021-01-22 23:35:16 +03:00
tavplubix
49e1321df4
Merge pull request #19072 from ClickHouse/fix_19021
Fix checkpoint in PeekableReadBuffer over ConcatReadBuffer
2021-01-22 21:00:04 +03:00
Nikolai Kochetov
290eadc121
Merge branch 'master' into split-actions-dag 2021-01-22 18:09:34 +03:00
tavplubix
9801bfc0ee
Merge branch 'master' into fix_18063 2021-01-22 17:28:05 +03:00
alexey-milovidov
f44f169aaa
Merge pull request #19385 from ClickHouse/sum-ubsan
Avoid UBSan report in aggregate function sum
2021-01-22 17:25:55 +03:00
alexey-milovidov
6e1d660e36
Merge pull request #19390 from ClickHouse/http_referer
Add http_referer to client info
2021-01-22 17:25:09 +03:00
alexey-milovidov
9818bd319a
Merge pull request #19381 from azat/parts-types-metrics
Add metrics for MergeTree parts (Wide/Compact/InMemory) types
2021-01-22 17:24:50 +03:00
alexey-milovidov
3431e39587
Merge pull request #19393 from ClickHouse/extract-all-groups-fail-fast
Fail fast in incorrect usage of extractAllGroups
2021-01-22 17:24:13 +03:00
alexey-milovidov
9add38f47b
Merge pull request #19394 from ClickHouse/quantile-weighted-overflow
Fix UBSan report in quantileExactWeighted
2021-01-22 17:18:01 +03:00
alexey-milovidov
7b62871765
Merge pull request #19383 from ClickHouse/h3-fix-buffer-overflow
Fix buffer overflow in Uber H3
2021-01-22 17:14:29 +03:00
Kruglov Pavel
b2d5370b36
Merge pull request #17359 from ildus/tuple_arg_for_argMinMax
Add tuple argument support for argMin and argMax
2021-01-22 17:11:01 +03:00
Nikolai Kochetov
70b4199869 Add test. 2021-01-22 16:30:01 +03:00
Maksim Kita
d712748304 Function accurateCastOrNull fixed unitialized values for numeric cast 2021-01-22 16:24:51 +03:00
tavplubix
2d988f6791
Update arcadia_skip_list.txt 2021-01-22 16:01:04 +03:00
kssenii
6dc32ae4cb More correct for functions and aggr. functions 2021-01-22 11:58:29 +00:00
Alexander Kuzmenkov
6296cc6b09
Merge pull request #19361 from ClickHouse/aku/reconnect
Reconnect after client errors
2021-01-22 13:32:56 +03:00
Alexander Kuzmenkov
8b9105bf39
Merge pull request #18446 from azat/constant-folding
Fix constant folding when the result is unknown
2021-01-22 13:26:24 +03:00
Nikolai Kochetov
2e95000d64 Update tests. 2021-01-22 13:25:59 +03:00
Nikolai Kochetov
b19316a2af Fix test. 2021-01-22 13:06:59 +03:00
Nikolai Kochetov
42d46e2a26 Update tests. 2021-01-22 12:39:33 +03:00
Alexey Milovidov
56d09886e2 Fix MSan report in AES functions 2021-01-22 04:08:10 +03:00
alexey-milovidov
4e11e7cfa9
Merge pull request #18772 from azat/optimize-memory-tracking-fix
[RFC] Fix memory tracking for OPTIMIZE TABLE/merges
2021-01-22 03:48:06 +03:00
Alexey Milovidov
14adc2d5f0 Fix UBSan report in quantileExactWeighted 2021-01-22 03:05:45 +03:00
Alexey Milovidov
e38ff3517d Fail fast in incorrect usage of extractAllGroups 2021-01-22 02:48:26 +03:00
Alexey Milovidov
79229ef25a Skip Arcadia 2021-01-22 02:01:17 +03:00
Alexey Milovidov
117708abc6 Skip Arcadia 2021-01-22 01:59:56 +03:00
Alexey Milovidov
afc6f2fd8e Add http_referer to client info 2021-01-22 01:55:45 +03:00
Alexey Milovidov
056b44b64f Add a test 2021-01-22 01:49:37 +03:00
kssenii
daab2c91bb Better 2021-01-21 21:15:11 +00:00
alexey-milovidov
1883bc546a
Merge pull request #19357 from ClickHouse/values-ubsan
Fix potential nullptr dereference in table function VALUES
2021-01-21 23:34:41 +03:00
alexey-milovidov
37c345f55e
Merge pull request #19347 from ClickHouse/array-element-ubsan
Avoid UBSan report in arrayElement
2021-01-21 23:34:19 +03:00
kssenii
1ec463b61f Fast test fix 2021-01-21 20:02:44 +00:00
Alexander Kuzmenkov
71e663701d update the tests 2021-01-21 22:56:28 +03:00
Alexey Milovidov
d9cb1c1bdd Avoid UBSan report in aggregate function sum 2021-01-21 22:52:00 +03:00
Alexey Milovidov
cc160813ce Add a test 2021-01-21 21:44:48 +03:00
Azat Khuzhin
82e7e7d9cb Fix constant folding for expressions depends from subqueries result
Do not use subquery result, when value is unknown, for constant folding.

v2: fix simple subqueries, fixes 00597_push_down_predicate.
v3:
- use identity over introducing yet another cast analog (as suggested by @akuzm)
- simpler suitable_for_const_folding check
v4: use identity(cast()) since only cast() can provide corrent type (for
data types that does not have it's own type, i.e. DateTime)
v5: do not optimize consts if only_analyze isset, regardless the block
content
2021-01-21 21:26:50 +03:00
Azat Khuzhin
44011061b5 Add missing DROP TABLE at the beginning of 01268_mv_scalars test 2021-01-21 21:22:23 +03:00
Azat Khuzhin
95c9e57ec1 Add 01600_parts_types_metrics 2021-01-21 21:17:01 +03:00
Azat Khuzhin
974f0daeb9 Add set database_atomic_wait_for_drop_and_detach_synchronously=1 for 01600_parts_states_metrics
Without this setting the test will pass only when the table will be
actually removed by the background worker of the Atomic engine.

In CI this is not required since
database_atomic_wait_for_drop_and_detach_synchronously is set explicitly
in via tests/users.d.
2021-01-21 21:17:01 +03:00
Azat Khuzhin
926b0ddc59 Rename 01600_count_of_parts_metrics to 01600_parts_states_metrics 2021-01-21 21:17:00 +03:00
Nikita Mikhaylov
b93732e441
Merge pull request #18788 from hexiaoting/map_functions
Introduce mapContains, mapKeys, mapValues functions for Map data type
2021-01-21 21:02:03 +03:00
Alexander Kuzmenkov
eb7b87ee8d update tests 2021-01-21 21:01:32 +03:00
kssenii
c1702f34ee Add factories info into system.query_log 2021-01-21 15:46:37 +00:00
Alexander Kuzmenkov
36a42a1f96 update tests 2021-01-21 18:30:51 +03:00
Alexander Kuzmenkov
ec8ff21526 Reconnect after client errors 2021-01-21 17:28:46 +03:00
vdimir
2f11fdf4df
Fix default value in join types with non-zero default (close #18197) 2021-01-21 16:49:44 +03:00
Alexey Milovidov
375db8ce7e Update reference 2021-01-21 16:42:47 +03:00
Anton Popov
ac3de63a71 fix several cases, while reading subcolumns 2021-01-21 15:34:11 +03:00
alexey-milovidov
7370335f87
Merge pull request #19339 from ClickHouse/fix-ipv4-formatting
Fix bad formatting of IPv4 addresses
2021-01-21 15:20:24 +03:00
Alexey Milovidov
56012402e2 Fix potential nullptr dereference in table function VALUES 2021-01-21 15:19:00 +03:00
alexey-milovidov
08dc5ebfa7
Merge pull request #19343 from ucasFL/sleep
fix sleep with infinite input
2021-01-21 15:04:30 +03:00
Ildus Kurbangaliev
47a0f4e162 Add tuple argument support for argMin and argMax 2021-01-21 16:47:51 +05:00
Alexey Milovidov
2cd04e8923 Fix UBSan report in arraySum 2021-01-21 14:43:33 +03:00
flynn
e75b116466
Rewrite sum(if()) and sumIf to countIf in special cases (#17041)
Co-authored-by: vdimir <vdimir@yandex-team.ru>
2021-01-21 12:01:35 +03:00
Alexey Milovidov
110089086b Fix UBSan report in GatherUtils #19287 2021-01-21 11:41:19 +03:00
Alexey Milovidov
1bb8cc5c9a Avoid UBSan report in arrayElement 2021-01-21 11:10:46 +03:00
Azat Khuzhin
5f3059555a Fix system.parts _state column
There was LOGICAL_ERROR when querying this column, due to incorrect order:

    SELECT
        *,
        _state
    FROM system.parts

    2021.01.21 10:22:57.731556 [ 22851 ] {02a07c6d-467d-4681-9203-4dc11cc6fbee} <Fatal> : Logical error: 'Invalid Field get from type String to type UInt64'.
2021-01-21 10:41:23 +03:00
feng lv
2094eae23d fix sleep with infinite input 2021-01-21 04:49:35 +00:00
Alexey Milovidov
2d87e52b3a Fix bad formatting of IPv4 addresses 2021-01-21 03:24:44 +03:00
Alexander Kuzmenkov
8663d04b7f
Merge pull request #19298 from ClickHouse/aku/parallel-tests
Avoid mixing output from parallel test runs
2021-01-20 20:22:42 +03:00
Alexander Tokmakov
6560ec3ed5 fix segfault on aggregation when MV has unexpected structure 2021-01-20 19:36:18 +03:00
Daniel Qin
25d8c047c5
Add a check to avoid exception when long alias equals to column (#18968)
* Add a check to avoid exception when long alias equas to column

* try fix with add an underlying table name, add function test

* format code

Co-authored-by: Ling Qin <lqin@freewheel.com>
2021-01-20 18:34:17 +03:00
Nikolai Kochetov
d0fc7098a7 Fix tests. 2021-01-20 15:58:23 +03:00
alesapin
ab325f5d0c Fix test 2021-01-20 13:31:47 +03:00
Nikolai Kochetov
1e4b32aa30
Merge pull request #19273 from CurtizJ/map-subcolumns
Support 'keys' and 'values' subcolumns in type Map
2021-01-20 13:13:01 +03:00
Nikolai Kochetov
67d880dc3a Update test. 2021-01-20 12:38:56 +03:00
Alexander Kuzmenkov
107d83b654 Avoid mixing output from parallel test runs.
Also mark some tests as sequential-only.
2021-01-20 08:31:41 +03:00
Alexander Kuzmenkov
4d16dead0f Merge remote-tracking branch 'origin/master' into HEAD 2021-01-19 20:34:01 +03:00
Alexander Kuzmenkov
f5931a2289
Merge pull request #19236 from ClickHouse/aku/echo-leading
Make `-- { echo }` hint preserve leading comments
2021-01-19 20:20:58 +03:00
Nikolai Kochetov
df56590e21 Update test. 2021-01-19 18:35:32 +03:00
Nikolai Kochetov
17edf238e3 Added test. 2021-01-19 16:35:26 +03:00
Anton Popov
bc796ec391 support 'keys' and 'values' subcolumns in type Map 2021-01-19 14:05:21 +03:00
alexey-milovidov
ee4cc94e6c
Merge pull request #19235 from ClickHouse/redundant-test-for-banner-system
Add redundant test for Yandex banner system
2021-01-19 13:29:52 +03:00
Nikita Mikhaylov
b8fcd75de7
Merge pull request #19200 from den-crane/tests/18839_Expand_macros_for_fetchPartition
test for #18839 Expand_macros_for_fetchPartition
2021-01-19 02:54:20 +03:00
Anton Popov
dbc10b2024
Merge pull request #19063 from CurtizJ/exists-view
Support operations with views in ANTLR parser
2021-01-19 01:15:12 +03:00
Alexander Kuzmenkov
d0922e2985 Merge remote-tracking branch 'origin/master' into tmp 2021-01-18 23:23:49 +03:00
Alexander Kuzmenkov
c1b35da714 old flaky test 2021-01-18 23:22:20 +03:00
Alexander Kuzmenkov
b07d6c5132 old flaky test 2021-01-18 20:15:58 +03:00
Nikita Mikhaylov
8f5d5ebbff
Update arcadia_skip_list.txt 2021-01-18 16:14:30 +03:00