Alexey Milovidov
7df7793724
Docker
2023-12-10 23:53:22 +01:00
Alexey Milovidov
bf96c3a064
Merge branch 'master' of github.com:ClickHouse/ClickHouse into clickbench-ci
2023-12-10 22:02:13 +01:00
Alexey Milovidov
4b13a6d08f
Fix CI
2023-12-10 22:02:05 +01:00
Alexey Milovidov
d74f72d310
Merge pull request #57730 from ClickHouse/revert-57454-fix-rwlock
...
Revert "Fix RWLock inconsistency after write lock timeout"
2023-12-10 21:52:11 +01:00
Alexey Milovidov
644ef7b63f
Revert "Fix RWLock inconsistency after write lock timeout"
2023-12-10 23:51:59 +03:00
Alexey Milovidov
6b55c16b4e
mypy
2023-12-10 20:49:03 +01:00
Alexey Milovidov
c6f1832686
Merge branch 'clickbench-ci' of github.com:ClickHouse/ClickHouse into clickbench-ci
2023-12-10 19:55:18 +01:00
Alexey Milovidov
ce894c28f3
mypy
2023-12-10 19:54:59 +01:00
Alexey Milovidov
75df8db298
Python
2023-12-10 19:52:52 +01:00
Alexey Milovidov
0a20ce5d32
Merge pull request #55271 from azat/local-lazy-database
...
Replace --no-system-tables with loading virtual tables of system database lazily
2023-12-10 19:51:17 +01:00
robot-clickhouse
c1e387d682
Automatic style fix
2023-12-10 18:32:09 +00:00
Alexey Milovidov
99c8430c3e
mypy
2023-12-10 19:10:44 +01:00
Alexey Milovidov
11dda11f22
Python
2023-12-10 19:08:50 +01:00
Alexey Milovidov
bb501a0e13
Shellcheck
2023-12-10 19:06:38 +01:00
Alexey Milovidov
5a33fdcd4d
Merge pull request #57645 from bharatnc/ncb/sha512-256
...
add SHA512_256 function
2023-12-10 18:02:09 +01:00
Alexey Milovidov
98f9d2a5fc
Merge pull request #57714 from azat/tests/fix-test_dictionaries_update_and_reload
...
Fix test_dictionaries_update_and_reload/test.py::test_reload_while_loading flakiness
2023-12-10 17:55:50 +01:00
Alexey Milovidov
e21c60191a
Merge pull request #57710 from azat/sparse-column-fix-aggregation
...
Fix SIGSEGV for aggregation of sparse columns with any() RESPECT NULL
2023-12-10 17:54:57 +01:00
Alexey Milovidov
d119052895
Merge pull request #51858 from ClickHouse/CurtizJ-fix-ttl-non-deterministic
...
Merging #37286
2023-12-10 17:50:36 +01:00
Alexey Milovidov
355fa8dbab
Merge pull request #51866 from ClickHouse/rschu1ze-azure-darwin2
...
Merging #51326 .
2023-12-10 17:49:16 +01:00
Alexey Milovidov
070934afad
Merge branch 'master' of github.com:ClickHouse/ClickHouse into clickbench-ci
2023-12-10 17:43:50 +01:00
Azat Khuzhin
2707e38c69
Fix dead-lock in DatabaseMaterializedPostgreSQL after interface changes
...
Deadlock for ATTACH:
/src/ch/clickhouse/src/Common/ThreadFuzzer.cpp:0::pthread_mutex_lock
/src/ch/clickhouse/contrib/llvm-project/libcxx/src/mutex.cpp:39::std::__1::mutex::lock()
/src/ch/clickhouse/src/Databases/DatabaseOrdinary.cpp:240::DB::DatabaseOrdinary::waitTableStarted(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&) const
/src/ch/clickhouse/src/Databases/DatabasesCommon.cpp:203::DB::DatabaseWithOwnTablesBase::tryGetTable(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, std::__1::shared_ptr<DB::Context const>) const
/src/ch/clickhouse/src/Databases/PostgreSQL/DatabaseMaterializedPostgreSQL.cpp:335::DB::DatabaseMaterializedPostgreSQL::attachTableUnlocked(std::__1::shared_ptr<DB::Context const>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, std::__1::shared_ptr<DB::IStorage> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&)
/src/ch/clickhouse/contrib/llvm-project/libcxx/include/__mutex_base💯 :DB::IDatabase::attachTable(std::__1::shared_ptr<DB::Context const>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, std::__1::shared_ptr<DB::IStorage> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&)
/src/ch/clickhouse/contrib/llvm-project/libcxx/include/string:1499::DB::DatabaseMaterializedPostgreSQL::createTable(std::__1::shared_ptr<DB::Context const>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, std::__1::shared_ptr<DB::IStorage> const&, std::__1::shared_ptr<DB::IAST> const&)
/src/ch/clickhouse/contrib/llvm-project/libcxx/include/string:1499::DB::InterpreterCreateQuery::doCreateTable(DB::ASTCreateQuery&, DB::InterpreterCreateQuery::TableProperties const&, std::__1::unique_ptr<DB::DDLGuard, std::__1::default_delete<DB::DDLGuard>>&)
/src/ch/clickhouse/src/Interpreters/InterpreterCreateQuery.cpp:0::DB::InterpreterCreateQuery::createTable(DB::ASTCreateQuery&)
/src/ch/clickhouse/src/Interpreters/InterpreterCreateQuery.cpp:1751::DB::InterpreterCreateQuery::execute()
/src/ch/clickhouse/src/Interpreters/executeQuery.cpp:0::DB::executeQueryImpl(char const*, char const*, std::__1::shared_ptr<DB::Context>, DB::QueryFlags, DB::QueryProcessingStage::Enum, DB::ReadBuffer*)
/src/ch/clickhouse/src/Interpreters/executeQuery.cpp:1287::DB::executeQuery(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, std::__1::shared_ptr<DB::Context>, DB::QueryFlags, DB::QueryProcessingStage::Enum)
/src/ch/clickhouse/contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:612::DB::TCPHandler::runImpl()
/src/ch/clickhouse/src/Server/TCPHandler.cpp:2294::DB::TCPHandler::run()
/src/ch/clickhouse/base/poco/Net/src/TCPServerConnection.cpp:57::Poco::Net::TCPServerConnection::start()
/src/ch/clickhouse/contrib/llvm-project/libcxx/include/__memory/unique_ptr.h:48::Poco::Net::TCPServerDispatcher::run()
/src/ch/clickhouse/base/poco/Foundation/src/ThreadPool.cpp:202::Poco::PooledThread::run()
/src/ch/clickhouse/base/poco/Foundation/include/Poco/SharedPtr.h:139::Poco::ThreadImpl::runnableEntry(void*)
CI: https://s3.amazonaws.com/clickhouse-test-reports/55271/ece8c86ebc02908e36786ca32d68f9ce0ddcb35d/integration_tests__tsan__[1_6].html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-10 16:06:18 +01:00
Vitaly Baranov
a058a26b7e
Merge pull request #57454 from vitlibar/fix-rwlock
...
Fix RWLock inconsistency after write lock timeout
2023-12-10 14:09:29 +01:00
Azat Khuzhin
ce9fd2c57a
Fix test_dictionaries_update_and_reload/test.py::test_reload_while_loading flakiness
...
On CI this test fails due to start_time == prev_start_time:
start_time, duration = get_loading_start_time("slow"), get_loading_duration("slow")
> assert start_time > prev_start_time
E assert time.struct_time(tm_year=2023, tm_mon=12, tm_mday=9, tm_hour=23, tm_min=42, tm_sec=2, tm_wday=5, tm_yday=343, tm_isdst=-1) > time.struct_time(tm_year=2023, tm_mon=12, tm_mday=9, tm_hour=23, tm_min=42, tm_sec=2, tm_wday=5, tm_yday=343, tm_isdst=-1)
The reason I guess is that there is sleep(0.5), while the
loading_start_time is DateTime not DateTime64, so you cannot distinguish
values if the difference is less then one second
CI: https://s3.amazonaws.com/clickhouse-test-reports/57710/7af1c0885daaf1e41470c5fdd92abfc7b6b2befc/integration_tests__asan__[3_4].html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-10 08:36:10 +01:00
Azat Khuzhin
ece8c86ebc
Fix attaching table in Atomic engine after attachTableUnlocked() interface
2023-12-10 08:28:10 +01:00
Bharat Nallan Chakravarthy
bfe2ffbce9
use the EVP interface to satisfy s390x builds
2023-12-09 21:31:21 -08:00
Alexey Milovidov
3d03a44f15
Merge branch 'master' into rschu1ze-azure-darwin2
2023-12-10 01:43:35 +01:00
Alexey Milovidov
b2572fceda
Add a test
2023-12-10 01:42:43 +01:00
Alexey Milovidov
100b36e8a9
Do not check in replication
2023-12-10 01:32:42 +01:00
Alexey Milovidov
33b0ec7d55
Merge branch 'master' into CurtizJ-fix-ttl-non-deterministic
2023-12-10 01:21:43 +01:00
Alexey Milovidov
af48cb9732
Python
2023-12-10 00:35:04 +01:00
Alexey Milovidov
9a3860581c
YAML
2023-12-10 00:27:11 +01:00
Alexey Milovidov
ea31c8471f
Python
2023-12-10 00:26:44 +01:00
Alexey Milovidov
2602a7ba81
Python
2023-12-10 00:22:19 +01:00
Alexey Milovidov
f2875068be
Style
2023-12-10 00:19:30 +01:00
Alexey Milovidov
01487af489
Merge branch 'clickbench-ci' of github.com:ClickHouse/ClickHouse into clickbench-ci
2023-12-10 00:03:51 +01:00
Alexey Milovidov
17772dc41c
Recommendation from @felixoid
2023-12-10 00:03:33 +01:00
robot-clickhouse
f8f42d82dd
Automatic style fix
2023-12-09 22:52:58 +00:00
Alexey Milovidov
3ac3a06561
Add ClickBench to CI
2023-12-09 23:31:05 +01:00
Alexey Milovidov
ecbae2d8fd
Merge pull request #57711 from ClickHouse/musl-8
...
Switch Fast Test to Musl
2023-12-09 23:23:44 +01:00
Azat Khuzhin
4f9d90761b
Attach tables lazily only for clickhouse-local
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-09 23:08:29 +01:00
Azat Khuzhin
c14721bb03
Move lazy table initialization interface into IDatabase
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-09 23:08:29 +01:00
Azat Khuzhin
f75484a0b1
Make IDatabase::attachTableUnlocked() virtual and use it for overrides (mostly)
2023-12-09 23:08:29 +01:00
Azat Khuzhin
cc9afe6f6e
Replace --no-system-tables with loading virtual tables of system database lazily
...
First of all the problem is that that simple 'SELECT 1' cannot be runned
without system.one, which makes --no-system-tables almost useless:
$ ./clickhouse-debug local --no-system-tables -q "select 1"
Code: 81. DB::Exception: Database system does not exist. (UNKNOWN_DATABASE)
Secondly there are just too much flags, and this one
(--no-system-tables) is too damn specific.
This patch should improve startup time of the clickhouse-local almost
3x in debug builds.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-09 23:08:29 +01:00
Azat Khuzhin
7af1c0885d
Do not call add*() from addBatchSparseSinglePlace() if there are no rows
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-09 22:47:25 +01:00
Azat Khuzhin
472a31e581
Fix SIGSEGV for aggregation of sparse columns with any() RESPECT NULL
...
Add proper check into any() RESPECT NULL
Fixes: https://github.com/ClickHouse/ClickHouse/issues/57709
Fixes: https://github.com/ClickHouse/ClickHouse/pull/57189 (cc @Algunenano)
CI: https://s3.amazonaws.com/clickhouse-test-reports/52717/7ec9c6a7f7490b5075407410dc193a2534216e15/fuzzer_astfuzzerdebug/report.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-09 22:47:15 +01:00
Igor Nikonov
87e47bdbee
Merge pull request #57467 from ClickHouse/rm-select
...
Remove select() usage
2023-12-09 22:27:28 +01:00
Alexey Milovidov
f3def573c6
Switch Fast Test to Musl
2023-12-09 21:54:09 +01:00
Alexey Milovidov
2eeb383579
Merge pull request #57180 from ClickHouse/musl-7
...
Check what will happen if we build ClickHouse with Musl
2023-12-09 21:47:28 +01:00
Vitaly Baranov
179a0a2e8f
Fixed condition and add more chasserts for consistency checks.
2023-12-09 20:22:48 +01:00
Alexey Milovidov
f0df110b15
Enable some libraries
2023-12-09 19:30:53 +01:00