Commit Graph

3870 Commits

Author SHA1 Message Date
KinderRiven
3b2a427002 fix 2022-06-07 11:50:56 +08:00
alesapin
5a213c2396 Followup 2022-06-06 20:52:53 +02:00
alesapin
a459f2e43d Fix bug 2022-06-06 20:51:58 +02:00
Antonio Andelic
2c37fe3d7b Merge branch 'master' into revert-37534-revert-37036-keeper-preprocess-operations 2022-06-06 12:39:55 +00:00
alesapin
daf49dca77 Remove logical error (legal case) 2022-06-06 13:32:58 +02:00
KinderRiven
bfe5150154 better 2022-06-06 16:48:30 +08:00
KinderRiven
4e78bbd414 fix 2022-06-06 03:21:56 +08:00
KinderRiven
13e74bef5e support skip_download_if_exceeds_query_cache 2022-06-06 02:36:23 +08:00
KinderRiven
882104ab77 fix 2022-06-06 01:46:27 +08:00
KinderRiven
d9684daa6f fix better 2022-06-06 01:29:49 +08:00
KinderRiven
ae86f7ceaa fix 2022-06-06 00:00:59 +08:00
KinderRiven
c5fc826fc3 fix style 2022-06-05 17:45:45 +08:00
Amos Bird
a5afb73c52
Remove duplicated peak mem log
Also log "Processed in {} sec" a little bit earlier so that it's also
sent to client and have the log entry related to the query_id.
2022-06-05 17:02:58 +08:00
KinderRiven
cb9927cd00 fix 2022-06-05 16:52:01 +08:00
KinderRiven
3ffb0b3549 support_max_query_cache_size 2022-06-05 16:21:36 +08:00
Alexey Milovidov
f860407af5
Merge pull request #37777 from ClickHouse/avx512_tail_zero
Use multitarget framework for numZerosInTail implementation
2022-06-04 01:46:56 +03:00
Azat Khuzhin
c29768325c Print query in one line on fatal errors
executeQuery() logging query without new lines in SQL, and it is useful,
since you can grep and see the whole query (usually).

So let's use the same in fatal error handler to make CI reports more
informative.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-06-03 18:55:53 +03:00
mergify[bot]
ddf7210ecc
Merge branch 'master' into remove-useless-code-2 2022-06-03 13:58:45 +00:00
alesapin
ac03e3af3e
Merge branch 'master' into metadata_storage 2022-06-03 14:42:21 +02:00
zvonand
5e4e349495 small fixes 2022-06-03 14:14:20 +03:00
Alexey Milovidov
1529d47207
Merge pull request #34754 from ClickHouse/llvm-14
Switch to clang/llvm 14
2022-06-03 14:07:34 +03:00
alesapin
46bccae078 Trying to create metadata layer 2022-06-02 18:09:40 +02:00
Antonio Andelic
7ee47fc5bb Merge branch 'master' into revert-37534-revert-37036-keeper-preprocess-operations 2022-06-02 13:38:52 +00:00
Nikolai Kochetov
edac3d6714 Merge branch 'master' into refactor-read-metrics-and-callbacks 2022-06-02 09:36:20 +00:00
Alexander Gololobov
6433fd6113 Added macros for AVX512BW target 2022-06-02 11:19:46 +02:00
Alexey Milovidov
cb8b0219ac Merge branch 'master' of github.com:ClickHouse/ClickHouse into llvm-14 2022-06-02 08:46:31 +02:00
Alexander Gololobov
a0cf902d49
Merge pull request #37588 from yaqi-zhao/avx512_tail_zero
add avx512 support for mergetree reader
2022-06-02 08:51:52 +03:00
Alexander Gololobov
ec6e413f0b Fixed runtime check for AVX512F 2022-06-01 23:00:49 +02:00
Alexey Milovidov
b5f48a7d3f Merge branch 'master' of github.com:ClickHouse/ClickHouse into llvm-14 2022-06-01 22:09:58 +02:00
Alexey Milovidov
89638de521
Merge pull request #37738 from ClickHouse/fix-intersect-with-const
Fix `Intersect` with constant strings
2022-06-01 19:31:55 +03:00
Antonio Andelic
ded1398565 Fix intersect with const string 2022-06-01 11:13:33 +00:00
mergify[bot]
4aefcf29e3
Merge branch 'revert-37534-revert-37036-keeper-preprocess-operations' into keeper-real-time-digest 2022-06-01 10:17:49 +00:00
Alexander Gololobov
26609a1875 Style fixes 2022-05-31 21:41:10 +02:00
Nikolai Kochetov
86fbb74703 Merge branch 'master' into refactor-read-metrics-and-callbacks 2022-05-31 18:07:47 +00:00
mergify[bot]
ba49c6bb46
Merge branch 'master' into memory-overcommit-improvement 2022-05-31 13:17:06 +00:00
yaqi-zhao
a2857491c4 add avx512 support for mergetreereader 2022-05-30 20:53:00 -04:00
Kseniia Sumarokova
b1ba7b7027
Fix build 2022-05-30 17:30:59 +02:00
Kseniia Sumarokova
1869adfd7d
Update FileCache.cpp 2022-05-30 16:06:58 +02:00
Nikolai Kochetov
5b4658aa5e Merge branch 'master' into refactor-read-metrics-and-callbacks 2022-05-30 09:47:35 +00:00
Andrey Zvonov
c79d87e629 fix style 2022-05-30 02:26:02 +03:00
Alexey Milovidov
5fda199dcf
Update src/Common/ErrorCodes.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2022-05-30 00:20:49 +03:00
Andrey Zvonov
2dbbf14de5
Merge branch 'master' into non-neg-deriv 2022-05-29 10:09:51 +03:00
Alexey Milovidov
c1169019d2 Merge branch 'master' into llvm-14 2022-05-29 02:29:02 +02:00
Alexey Milovidov
11788c8129 Fix clang-tidy-14 2022-05-29 02:28:46 +02:00
zvonand
032e54abbf works now 2022-05-29 03:21:07 +03:00
Alexey Milovidov
73e2e63414
Merge pull request #37612 from ClickHouse/clang-tidy-14
Fix clang-tidy-14, part 1
2022-05-29 03:16:32 +03:00
Anton Popov
1d9b3be7da
Merge pull request #37536 from CurtizJ/profile-events-for-part-types
Add profile events for introspection of part types
2022-05-28 14:25:21 +02:00
Alexey Milovidov
eff285e24a
Update ThreadFuzzer.cpp 2022-05-28 05:13:16 +03:00
Alexey Milovidov
c50791dd3b Fix clang-tidy-14, part 1 2022-05-27 22:52:14 +02:00
Alexey Milovidov
d2c6fd90cb Fix clang-tidy-14, part 1 2022-05-27 22:51:37 +02:00
Kseniia Sumarokova
10c9716467
Fix clang-tidy 2022-05-27 22:48:07 +02:00
Dmitry Novik
60b9d81773 Remove global_memory_usage_overcommit_max_wait_microseconds 2022-05-27 16:30:29 +00:00
Kseniia Sumarokova
8099361cbc
Update FileCache.cpp 2022-05-27 17:48:14 +02:00
tchepavel
42cd854688
Merge branch 'master' into nats-integration 2022-05-27 16:05:08 +03:00
zvonand
5c558d0be9 old work upload 2022-05-27 15:07:22 +03:00
alesapin
6d6779f17a
Merge pull request #37139 from ClickHouse/i_object_storage
Separate object storage operations from disks
2022-05-27 13:59:50 +02:00
Kseniia Sumarokova
f5d69506b4
Merge pull request #37516 from KinderRiven/improve_local_cache
Control cache downloads to avoid negative optimization of local caches
2022-05-27 11:53:17 +02:00
Nikolai Kochetov
84f97b53de Merge branch 'master' into refactor-read-metrics-and-callbacks 2022-05-26 11:07:45 +00:00
KinderRiven
822ecd982f better & support clean stash 2022-05-26 16:36:05 +08:00
alesapin
1db9cf480b Merge remote-tracking branch 'origin/master' into i_object_storage 2022-05-25 22:50:22 +02:00
alesapin
c7b16065e1 Merge with master 2022-05-25 21:47:05 +02:00
alesapin
6f5c86e55e Merge branch 'master' into i_object_storage 2022-05-25 20:49:01 +02:00
KinderRiven
a33c7ce648 fix 2022-05-25 22:58:47 +08:00
Anton Popov
16e839ac71 add profile events for introspection of part types 2022-05-25 14:54:49 +00:00
Nikolai Kochetov
1b85f2c1d6 Merge branch 'master' into refactor-read-metrics-and-callbacks 2022-05-25 16:27:40 +02:00
KinderRiven
875557abc2 fix 2022-05-25 21:53:28 +08:00
KinderRiven
adbb821176 fix 2022-05-25 21:05:15 +08:00
KinderRiven
2211c1ddb8 fix 2022-05-25 20:15:43 +08:00
KinderRiven
d0fcffec66 fix style 2022-05-25 17:51:03 +08:00
KinderRiven
1ce219bae2 fix 2022-05-25 17:24:38 +08:00
KinderRiven
e3f76cab55 impl improve remote fs cache 2022-05-25 16:54:28 +08:00
Robert Schulze
01ab7b9bad
Pass strings in some places as string_view
The original goal was to get change

  const auto & needle = String(
        reinterpret_cast<const char *>(cur_needle_data),
        cur_needle_length);

in Functions/MatchImpl.h into a std::string_view to save an allocation +
copy. The needle is eventually passed as search pattern into the re2
library. Re2 has an alternative constructor taking a const char * i.e. a
NULL-terminated string. Here, the needle is NULL-terminated but
1. this is only because it is passed inside a ColumnString yet this is
   not always the case (e.g. fixed string columns has a dense layout w/o
   NULL terminator).
2. assuming NULL termination for users != MatchImpl of the regex code is
   too dangerous.

So, for now we'll stay with copying to be on the safe side. One fine day
when re2 has a ptr/size ctor, we can use std::string_view.

Just changing a few other places from std::string to std::string_view
but this will not help with performance.
2022-05-25 10:05:51 +02:00
Robert Schulze
e8c96777f6
Make OptimizedRegularExpression::analyze() private 2022-05-25 10:05:45 +02:00
Kseniia Sumarokova
02d162c25d
Merge branch 'master' into nats-integration 2022-05-25 10:04:39 +02:00
Antonio Andelic
fe72cd7478 Merge branch 'master' into keeper-real-time-digest 2022-05-25 07:41:31 +00:00
Robert Schulze
7348a0eb28
Merge pull request #37251 from ClickHouse/non_const_like
Support non-constant SQL functions (NOT) (I)LIKE and MATCH
2022-05-24 20:28:31 +02:00
Maksim Kita
3c0c322d7c
Merge pull request #37480 from kitaisreal/dynamic-dispatch-infrastructure-improvements
Dynamic dispatch infrastructure style fixes
2022-05-24 18:13:53 +02:00
tchepavel
43226a57fc
Merge branch 'master' into nats-integration 2022-05-24 18:15:11 +03:00
Maksim Kita
e6e4b2826d Dynamic dispatch infrastructure style fixes 2022-05-24 14:25:29 +02:00
Alexander Tokmakov
6bc68c0cbc Merge branch 'master' into fixes_for_transactions 2022-05-23 18:49:21 +02:00
Dmitry Novik
e9187ec4b7 Overcommit: update defaults, exception message and add ProfileEvent 2022-05-23 14:35:09 +00:00
tchepavel
d9436ec7dd
Merge branch 'master' into nats-integration 2022-05-23 14:30:09 +03:00
Antonio Andelic
8cb6101a3c Merge branch 'master' into keeper-real-time-digest 2022-05-23 10:34:20 +00:00
mergify[bot]
747aa5575c
Merge branch 'master' into remove-useless-code-2 2022-05-22 17:41:57 +00:00
Robert Schulze
0299cc87e4
Improve naming consistency of string search code
Just renamings, nothing major ...
2022-05-22 17:50:38 +02:00
alesapin
c8d92b87c8 Merge branch 'master' into i_object_storage 2022-05-22 12:16:10 +02:00
Robert Schulze
19d53c14fa
Merge pull request #37382 from ClickHouse/wc++98-compat-extra-semi
Enable -Wc++98-compat-extra-semi
2022-05-22 09:40:45 +02:00
Nikolai Kochetov
56feef01e7 Move some resources 2022-05-20 19:49:31 +00:00
Alexander Tokmakov
1027798517 handle connection loss on commit 2022-05-20 17:35:29 +02:00
Anton Popov
cb0e6c2718 mark all operators bool() as explicit 2022-05-20 15:29:54 +00:00
Robert Schulze
0f6715bd91
Follow-up to PR #37300: semicolon warnings
In PR #37300, Alexej asked why we the compiler does not warn about
unnecessary semicolons, e.g.

  f()
  {
  }; // <-- here

The answer is surprising: In C++98, above syntax was disallowed but by
most compilers accepted it regardless. C++>11 introduced "empty
declarations" which made the syntax legal.

The previous behavior can be restored using flag
-Wc++98-compat-extra-semi. This finds many useless semicolons which were
removed in this change. Unfortunately, there are also false positives
which would require #pragma-s and HAS_* logic (--> check_flags.cmake) to
suppress. In the end, -Wc++98-compat-extra-semi comes with extra effort
for little benefit. Therefore, this change only fixes some semicolons
but does not enable the flag.
2022-05-20 15:06:34 +02:00
Alexander Tokmakov
12bbb7de87 fix race on TID allocation 2022-05-20 12:41:44 +02:00
alesapin
654b27e307 Merge branch 'master' into i_object_storage 2022-05-20 11:56:13 +02:00
Antonio Andelic
fc9beb2933 Merge branch 'master' into keeper-real-time-digest 2022-05-20 09:54:44 +00:00
Robert Schulze
b475fbc9a7
Merge pull request #37300 from ClickHouse/cmake-cleanup-pt3
Various cmake cleanups
2022-05-20 10:02:36 +02:00
Antonio Andelic
c133f815bd Merge branch 'keeper-preprocess-operations' into keeper-real-time-digest 2022-05-20 07:57:47 +00:00
Antonio Andelic
f5759e2d7e Cache nodes latest state 2022-05-19 12:30:57 +00:00
Yakov Olkhovskiy
cd2ae72aac
Merge pull request #37273 from ClickHouse/client-dns-list
Multiple client connection attempts if hostname resolves to multiple addresses
2022-05-19 01:50:39 -04:00
Maksim Kita
df0cb06209
Merge pull request #37289 from kitaisreal/unary-arithmetic-functions-improve-performance-dynamic-dispatch
Improve performance of unary arithmetic functions
2022-05-18 19:16:30 +02:00
mergify[bot]
d5f870eac8
Merge branch 'master' into client-dns-list 2022-05-18 12:40:02 +00:00
alesapin
2bdc718923 Merge branch 'i_object_storage' of github.com:ClickHouse/ClickHouse into i_object_storage 2022-05-18 12:37:00 +02:00
Dmitry Novik
20c537addd Make noncopyable 2022-05-18 01:42:13 +00:00
Dmitry Novik
a97ba9741e Fix possible deadlock in OvercommitTracker during logging 2022-05-17 18:07:52 +00:00
Maksim Kita
31a29d8315 Fixed dynamic dispatch macro 2022-05-17 16:59:11 +02:00
tchepavel
2692d88a42
Merge branch 'master' into nats-integration 2022-05-17 16:59:57 +03:00
Antonio Andelic
a29286ce09 Remove data from request string 2022-05-17 13:54:44 +00:00
Antonio Andelic
6fba1c96ed Define small test for digest check 2022-05-17 13:53:12 +00:00
alesapin
5872781ac6 Merge with master 2022-05-17 15:50:30 +02:00
alesapin
824176f61d Merge branch 'master' into i_object_storage 2022-05-17 15:49:15 +02:00
alesapin
f9cd820854 Fix style 2022-05-17 15:39:46 +02:00
Yakov Olkhovskiy
c8a4be4c64 refactoring 2022-05-17 08:31:31 -04:00
Antonio Andelic
fc5a79f186 Polishing changes 2022-05-17 08:16:55 +00:00
Yakov Olkhovskiy
fc26505111 multiple client connection attempts if hostname resolves to multiple addresses 2022-05-16 17:47:07 -04:00
Kseniia Sumarokova
94683786dc
Merge branch 'master' into MeiliSearch 2022-05-16 22:42:09 +02:00
Maksim Kita
20380fa87b
Merge pull request #37257 from kitaisreal/dynamic-dispatch-infrastructure-for-class-members
Dynamic dispatch infrastructure for class member functions
2022-05-16 22:15:10 +02:00
Vitaly Baranov
72bff5242a
Merge pull request #37168 from vitlibar/backup-improvements-5
Backups Improvements 5
2022-05-16 21:25:54 +02:00
Robert Schulze
43945cea1b
Fixing some warnings 2022-05-16 20:59:27 +02:00
tchepavel
270c01bcb7 Merge branch 'master' of github.com:ClickHouse/ClickHouse into nats-integration 2022-05-16 19:18:51 +03:00
Maksim Kita
032b5d3fc3 Dynamic dispatch infrastructure for class member functions 2022-05-16 17:05:16 +02:00
Antonio Andelic
2ec61a8d7f Initial implementation of digest 2022-05-16 13:36:31 +00:00
Kseniia Sumarokova
ff37d7d5c3
Update ErrorCodes.cpp 2022-05-16 15:30:07 +02:00
Mikhail Artemenko
535b3ea686 refactor code & change exception numbers 2022-05-16 16:13:05 +03:00
tchepavel
58d8bc40aa Merge branch 'master' of github.com:ClickHouse/ClickHouse into nats-integration 2022-05-16 13:01:45 +03:00
Robert Schulze
e3cfec5b09
Merge remote-tracking branch 'origin/master' into clangtidies 2022-05-16 10:12:50 +02:00
Dmitry Novik
2259add1fa
Merge pull request #37197 from ClickHouse/overcommit-ratio-overflow
Fix possible overflow in OvercommitRatio
2022-05-15 15:09:19 +02:00
tchepavel
7317c76d3c
Merge branch 'master' into nats-integration 2022-05-15 14:41:22 +03:00
Kseniia Sumarokova
f4a8a0cefe
Merge pull request #37200 from kssenii/add-s3-requests-metric
Add S3Requests metric
2022-05-14 10:08:21 +02:00
kssenii
5dd3ad08a1 Add S3Requests metric 2022-05-13 18:12:46 +02:00
Dmitry Novik
45585f0e7f Fix possible overflow in OvercommitRatio 2022-05-13 15:39:05 +00:00
Kseniia Sumarokova
6e0a910fcd
Merge branch 'master' into better-read-from-cache 2022-05-12 19:44:18 +02:00
alesapin
e7296a2b28
Merge pull request #36825 from kssenii/cache-fix-1
Removed forceful drop cache command, fix detached status state
2022-05-12 17:18:21 +02:00
kssenii
7700d51ae4 Update profile events descriptions 2022-05-12 15:02:07 +02:00
kssenii
ef044a5df7 Merge 2022-05-12 14:59:27 +02:00
kssenii
483e056bcc Merge master 2022-05-12 14:58:24 +02:00
Vitaly Baranov
30005a1eff BACKUP ON CLUSTER correctly collects data of a replicated table from all replicas now,
and if some part doesn't exist on either replica it's no problem anymore.
2022-05-12 13:33:42 +02:00
tchepavel
5f8fcb748f Select, MV, Insert working 2022-05-12 13:58:50 +03:00
Kseniia Sumarokova
5ae28f6fd8
Update ProfileEvents.cpp 2022-05-12 12:28:48 +02:00
Kseniia Sumarokova
d636a02e7a
Update FileSegment.cpp 2022-05-12 12:16:12 +02:00
Kseniia Sumarokova
2a4f763a5e
Merge pull request #37075 from kssenii/fix-progress-for-insert-select
Fix progress indication for `INSERT SELECT` in clickhouse-local and for file progress in client
2022-05-12 12:05:53 +02:00
Robert Schulze
f8c24c5fe8
Merge pull request #37117 from ClickHouse/bug-37114
Fix Bug 37114 - ilike on FixedString(N)s produces wrong results
2022-05-12 09:39:36 +02:00
Kseniia Sumarokova
4483e5783a
Update FileSegment.h 2022-05-11 23:33:38 +02:00
Kseniia Sumarokova
2d15520ddb
Update FileSegment.cpp 2022-05-11 23:33:15 +02:00
kssenii
c5e84950d6 Update test, add descriptions to profile events 2022-05-11 14:57:51 +02:00
Robert Schulze
7232f47c68
Fix Bug 37114 - ilike on FixedString(N) columns produces wrong results
The main fix is in MatchImpl.h where the "case_insensitive" parameter is
added to Regexps::get().

Also made "case_insensitive" a non-default template parameter to reduce
the risk of future bugs.

The remainder of this commit are minor random code improvements.

resoves #37114
2022-05-11 14:30:21 +02:00
Kseniia Sumarokova
a440e1376a
Update FileSegment.cpp 2022-05-11 12:05:50 +02:00
mergify[bot]
0e2a86dcee
Merge branch 'master' into MeiliSearch 2022-05-11 08:49:19 +00:00
kssenii
5385a4da8a Fix review comments 2022-05-11 10:45:20 +02:00
kssenii
18dd74be0c Remove unneede changes 2022-05-11 10:26:30 +02:00
alesapin
0f276a0956
Merge pull request #36947 from ClickHouse/dump_ordered_sessions_map
Force keeper snapshot equality on different replicas
2022-05-10 23:36:09 +02:00
kssenii
ccab49e3cf Merge master 2022-05-10 19:33:34 +02:00
kssenii
61f2737e17 Merge master 2022-05-10 19:31:22 +02:00
kssenii
f4b45a5805 Better profile events 2022-05-10 16:00:53 +02:00
kssenii
0feda67ec4 Fix progress for insert select 2022-05-10 15:04:08 +02:00
Alexander Tokmakov
897a0393b2
Merge pull request #37072 from jiahui-97/fix_comment_num
just fix a number
2022-05-10 15:39:50 +03:00
jiahui-97
4c1244d06d just fix a number
Find a number wrong when reading SAHA paper and related code.
2022-05-10 20:33:25 +08:00
kssenii
2f0f76369a Better 2022-05-09 21:25:26 +02:00
Anton Popov
e911900054 remove last mentions of data streams 2022-05-09 19:15:24 +00:00
Robert Schulze
1b81bb49b4
Enable clang-tidy modernize-deprecated-headers & hicpp-deprecated-headers
Official docs:

  Some headers from C library were deprecated in C++ and are no longer
  welcome in C++ codebases. Some have no effect in C++. For more details
  refer to the C++ 14 Standard [depr.c.headers] section. This check
  replaces C standard library headers with their C++ alternatives and
  removes redundant ones.
2022-05-09 08:23:33 +02:00
kssenii
f43c09b53c Fix incorrect assetion 2022-05-08 14:18:43 +02:00
kssenii
50d229651f Fix exception message 2022-05-07 23:33:28 +02:00
kssenii
0e9e1dd000 Fix assert in case cache forcefully dropped 2022-05-07 23:19:44 +02:00
mergify[bot]
ac5e69d940
Merge branch 'master' into dump_ordered_sessions_map 2022-05-07 21:17:23 +00:00
alesapin
e54e33a6df I'm not ready for 3-way comparison 2022-05-07 15:33:34 +02:00
Alexey Milovidov
4eac661588
Merge branch 'master' into master 2022-05-07 13:21:59 +03:00
kssenii
0db83d7002 Merge master 2022-05-07 11:52:25 +02:00
kssenii
7e9913509f Fix build 2022-05-06 14:22:01 +02:00
kssenii
35ed60f5f6 Merge master 2022-05-06 13:56:14 +02:00
kssenii
c0248d4250 Merge master 2022-05-06 13:50:09 +02:00
Kruglov Pavel
80df398bfc
Merge pull request #36883 from kssenii/add-asynchronous-metrics-for-filesystem-cache
Add some asynchronous metrics for fs cache
2022-05-06 13:39:55 +02:00
kssenii
23d9230acd Do not throw logical error for detached file segment 2022-05-06 12:48:16 +02:00
alesapin
931a5f11f1
Update src/Common/ZooKeeper/IKeeper.h
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
2022-05-06 12:13:51 +02:00
kssenii
2275196ef0 Merge master 2022-05-06 11:21:10 +02:00
Kseniia Sumarokova
83a4b94970
Merge pull request #36952 from ClickHouse/remove-nested-exception
Remove nested exception
2022-05-06 11:14:16 +02:00
Alexey Milovidov
996d838ca3
Merge pull request #36817 from DevTeamBK/Clang-tidy-Fixes
Clang -Tidy Fixes
2022-05-06 02:01:00 +03:00
kssenii
3aef08b887 Fix style 2022-05-06 00:25:13 +02:00
kssenii
b26098735f Merge 2022-05-06 00:08:14 +02:00
kssenii
3a3a756d18 Fix failed checks 2022-05-06 00:07:22 +02:00
Alexey Milovidov
7841f02cf0 Remove nested exception 2022-05-05 23:05:52 +02:00
mergify[bot]
9ce436733f
Merge branch 'master' into fix-current-size-count-in-cache 2022-05-05 17:33:56 +00:00
alesapin
f4cdd86ae8 Force keeper snapshot equality on different replicas 2022-05-05 19:23:01 +02:00
mergify[bot]
2a8aad42dc
Merge branch 'master' into add-asynchronous-metrics-for-filesystem-cache 2022-05-05 15:43:38 +00:00
kssenii
78d3fd505f Merge master 2022-05-05 17:41:13 +02:00
kssenii
0117fd40a6 Review fixes 2022-05-05 17:39:36 +02:00
Vitaly Baranov
dd51265218
Merge pull request #36864 from vitlibar/backup-improvements-4
Backup improvements
2022-05-05 15:37:51 +02:00
Anton Popov
fa1feb238e
Merge pull request #36853 from qoega/add-other-time-microsecons
Add Other Query Time Microseconds Profile Event
2022-05-05 13:58:13 +02:00
Alexander Gololobov
7e3a805ae3
Merge pull request #36572 from ClickHouse/fix-trash-s3-metrics
Everything related to S3 metrics was not good
2022-05-05 11:44:02 +02:00
alesapin
aba78e5ed0
Merge pull request #36859 from ClickHouse/revert-36858-revert-35637-memory-overcommit-free
Revert "Revert "Memory overcommit: continue query execution if memory is available""
2022-05-04 23:43:00 +02:00
kssenii
e604677c85 Better 2022-05-04 22:52:01 +02:00
Alexander Tokmakov
e30365a531
Merge pull request #36872 from ClickHouse/fix_exception_message
Add extra info when sending exception
2022-05-04 23:24:47 +03:00
Robert Schulze
c48d9a4174
Merge pull request #36844 from rschu1ze/shared_ptr_helper3
Remove inherited create() method + disallow copying of storages
2022-05-04 19:16:30 +02:00
mergify[bot]
e0fa563092
Merge branch 'master' into fix_exception_message 2022-05-04 15:56:03 +00:00
Robert Schulze
78cdb3ec64
Merge pull request #36862 from rschu1ze/new-clangtidies
Activated a bunch of LLVM 12/13/14 clang-tidy warnings
2022-05-04 15:26:57 +02:00
kssenii
c8b5decf29 Fix lock inversion 2022-05-04 14:28:55 +02:00
mergify[bot]
6ecddf4077
Merge branch 'master' into fix-trash-s3-metrics 2022-05-04 10:14:29 +00:00
Robert Schulze
590a01d39d
Linux build fix 2022-05-04 11:42:23 +02:00
Dmitry Novik
9087ab0e11 Use free_continue_and_alloc_3_test 2022-05-04 00:41:15 +00:00
kssenii
ef7d5b2a65 Fix 2022-05-04 00:19:36 +02:00
Vitaly Baranov
160bc288d3 Fix implementation of totalBytes() & totalRows() for Log family. 2022-05-04 00:15:21 +02:00
mergify[bot]
64084b5e32
Merge branch 'master' into shared_ptr_helper3 2022-05-03 20:46:16 +00:00
kssenii
8f99046100 Add come asynchronous metrics 2022-05-03 20:02:19 +02:00
kssenii
ab65e163fa Add current metrics 2022-05-03 19:35:04 +02:00
mergify[bot]
ddd1c3e1b3
Merge branch 'master' into add-other-time-microsecons 2022-05-03 15:45:40 +00:00
Vitaly Baranov
828f45f078 Add new restore setting 'allow_non_empty_tables'. 2022-05-03 16:18:45 +02:00
Dmitry Novik
455742ec7a Make unit tests stable 2022-05-03 13:20:57 +00:00
Alexander Tokmakov
94af11dd74 add extra info when sending exception 2022-05-03 15:13:47 +02:00
kssenii
025e632a66 Merge master 2022-05-03 14:46:59 +02:00
kssenii
b0d43e3f40 Better 2022-05-03 14:20:23 +02:00
kssenii
a3c9ff7fe8 Tiny changes 2022-05-03 11:46:22 +02:00
Vitaly Baranov
409edfd3fa Rework RestoreCoordination: make restore deterministic. 2022-05-03 11:01:44 +02:00
Vitaly Baranov
2c754f44fc Make calculation of shard_num & replica_num not dependant on match of the cluster's definitions on nodes. 2022-05-03 11:01:44 +02:00
Larry Luo
ee131eefd8 Removed move for trivially-copyable type and added noexcept for move constructor 2022-05-02 18:46:34 -07:00
Dmitry Novik
2815f22152 Remove incorrect assert 2022-05-02 23:02:43 +00:00
Dmitry Novik
2ed5a4013a
Revert "Revert "Memory overcommit: continue query execution if memory is available"" 2022-05-03 00:45:13 +02:00
alesapin
f0b7af0aa2
Revert "Memory overcommit: continue query execution if memory is available" 2022-05-03 00:36:50 +02:00
alesapin
73f3334d80 Better fix for cache 2022-05-03 00:28:53 +02:00
Dmitry Novik
71b6f89166
Merge pull request #35637 from ClickHouse/memory-overcommit-free
Memory overcommit: continue query execution if memory is available
2022-05-02 19:00:18 +02:00
kssenii
70e2bb6264 Reimplement write-through cache 2022-05-02 18:55:11 +02:00
Ilya Yatsishin
6c3bbb4933 Add Other Time Microseconds Profile Event 2022-05-02 17:13:57 +02:00
Vladimir C
7293a69e5e
Merge pull request #36656 from amosbird/timefunctionunderflow
Saturate date/datetime to zero (part 2)
2022-05-02 17:10:48 +02:00
Maksim Kita
9bea207680
Merge pull request #36839 from rschu1ze/concepts
Replace uses of SFINAE by C++20 concepts
2022-05-02 14:20:12 +02:00
Robert Schulze
ad0b3be79d
Replace uses of SFINAE by C++20 concepts
- enable_if is usually regarded as fragile and unreadable

- C++20 concepts are much easier to read and produce more expressive
  error messages
2022-05-02 09:23:53 +02:00
Robert Schulze
330212e0f4
Remove inherited create() method + disallow copying
The original motivation for this commit was that shared_ptr_helper used
std::shared_ptr<>() which does two heap allocations instead of
make_shared<>() which does a single allocation. Turned out that
1. the affected code (--> Storages/) is not on a hot path (rendering the
performance argument moot ...)
2. yet copying Storage objects is potentially dangerous and was
   previously allowed.

Hence, this change

- removes shared_ptr_helper and as a result all inherited create() methods,

- instead, Storage objects are now created using make_shared<>() by the
  caller (for that to work, many constructors had to be made public), and

- all Storage classes were marked as noncopyable using boost::noncopyable.

In sum, we are (likely) not making things faster but the code becomes
cleaner and harder to misuse.
2022-05-02 08:46:52 +02:00
Alexey Milovidov
ef9633499c Merge branch 'master' into fix-trash-s3-metrics 2022-05-02 03:55:10 +02:00
Mikhail Artemenko
cf48390cb9
Merge branch 'master' into MeiliSearch 2022-05-02 00:28:42 +03:00
KinderRiven
7d0789472c fix 2022-05-01 19:45:16 +08:00
KinderRiven
e1acacf831 fix 2022-05-01 19:45:16 +08:00
KinderRiven
d80aa0fd17 impl system.filesystem_cache_log 2022-05-01 19:45:16 +08:00
KinderRiven
d595df1604 fix 2022-05-01 19:45:16 +08:00
KinderRiven
6a2e4559c8 impl system.cache_log 2022-05-01 19:45:16 +08:00
KinderRiven
ce9a6965d0 impl system.log_table 2022-05-01 19:45:16 +08:00
KinderRiven
a4b8f9e9cf impl system.cache_log 2022-05-01 19:45:16 +08:00
KinderRiven
9c9870f021 build cache_log table 2022-05-01 19:45:16 +08:00
KinderRiven
5a361a0db5 impl cache_log in filecache 2022-05-01 19:45:16 +08:00
KinderRiven
5b7b2d26ea fix add miss header 2022-05-01 19:45:16 +08:00
KinderRiven
df81496ba1 fix bug for cache log table 2022-05-01 19:45:16 +08:00
KinderRiven
de7e89661d resubmit 2022-05-01 19:45:16 +08:00
Mikhail Artemenko
41f657d8ed
Merge branch 'master' into MeiliSearch 2022-05-01 10:01:56 +03:00
kssenii
8cf83a2daf Fix 2022-04-30 22:02:44 +02:00
Robert Schulze
89aa9ae00f
Fixed clang-tidy check "bugprone-branch-clone"
The check is currently *not* part of .clang-tidy. It complains about:
(1) "switch has multiple consecutive identical branches"
(2) "repeated branch in conditional chain"

About (1): Lots of findings in switches were about redundant
"[[fallthrough]]" in places where the compiler would not warn anyways. I
have cleaned these up.

About (2): In if-else_if-else chains, fixing the warning would usually
mean concatenating multiple if-conditions. As this would reduce
readability in most cases, I did not fix these places.

Because of (2), I also refrained from adding "bugprone-branch-clone" to
.clang-tidy.
2022-04-30 19:40:28 +02:00
Kseniia Sumarokova
66f62b2ba6
Merge pull request #36632 from DevTeamBK/Fix-Coverity-Issues
Minor Coverity defects fixes
2022-04-30 15:11:40 +02:00
kssenii
eea0a009dc Debug 2022-04-30 15:02:21 +02:00
mergify[bot]
cc08ccb420
Merge branch 'master' into remove-useless-code-2 2022-04-30 12:48:15 +00:00
Alexey Milovidov
1ddb04b992
Merge pull request #36715 from amosbird/refactorbase
Reorganize source files so that base won't depend on Common
2022-04-30 09:40:58 +03:00
HeenaBansal2009
042157efca Clang -Tidy Fixes 2022-04-29 20:17:45 -07:00
mergify[bot]
e9fde5d067
Merge branch 'master' into memory-overcommit-free 2022-04-29 19:31:59 +00:00
Nikolai Kochetov
5807ca47b0
Merge pull request #36425 from ClickHouse/pool-size-hot-reload
Allow to increase number of threads and tasks for background executors
2022-04-29 17:24:12 +02:00
Kseniia Sumarokova
ca994e0861
Merge pull request #36660 from kssenii/fix-stress-test
Fix stress test after 36639
2022-04-29 12:56:25 +02:00
Amos Bird
4a5e4274f0
base should not depend on Common 2022-04-29 10:26:35 +08:00
Amos Bird
e81929a8b5
Saturate date/datetime to zero (part 2)
For partial hours/minutes timezones.
2022-04-29 10:24:18 +08:00
Kseniia Sumarokova
ace3fe253d
Merge pull request #36737 from KinderRiven/fix_bug_for_local_cache
fix bug for local cache
2022-04-29 02:54:33 +02:00