thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-02 12:32:04 +00:00
Code Issues Packages Projects Releases Wiki Activity
134,052 Commits 9,194 Branches 1,782 Tags 2.2 GiB
813020a1a6
Commit Graph

52734 Commits

Author SHA1 Message Date
avogar
584694ed51 Add function variantType 2024-01-30 18:01:12 +00:00
Alexey Milovidov
bb95790c83
Merge pull request #59393 from ClickHouse/24.2-prepare 
Update version after release
 2024-01-30 18:50:20 +01:00
Alexey Milovidov
4ddba907c8 Update autogenerated version to 24.2.1.1 and contributors 2024-01-30 18:49:28 +01:00
Alexander Gololobov
82c06ca294 Use ZooKeeperRetriesControl 2024-01-30 18:31:37 +01:00
Maksim Kita
600eae00cc Fixed code review issues 2024-01-30 19:50:18 +03:00
Alexander Gololobov
023b8cbd53 Retry disconnects and expired sessions 2024-01-30 17:47:11 +01:00
Maksim Kita
1c5b377b3a Fixed code review issues 2024-01-30 19:36:40 +03:00
Yarik Briukhovetskyi
5816424c2b
Merge pull request #59119 from AVMusorin/trailing-comma-tuples 
Allow trailing commas in types with several items
 2024-01-30 16:31:54 +01:00
kssenii
145f6a31cb Fix 2024-01-30 16:29:40 +01:00
Dmitry Novik
5a024dfc09
Merge pull request #59117 from ClickHouse/fix-analyzer-order-by-all 
Followup 57875
 2024-01-30 15:54:18 +01:00
Maksim Kita
948f3f1f62 Fixed style check 2024-01-30 17:15:29 +03:00
Maksim Kita
86a542b5c4 Updated implementation 2024-01-30 17:15:29 +03:00
Maksim Kita
20c1f0c18f Revert "Revert "Add new aggregation function groupArraySorted()"" 2024-01-30 17:15:29 +03:00
Raúl Marín
f79a402e6d Add sanity checks for function return types 2024-01-30 14:10:20 +01:00
Igor Nikonov
6624e34580 RemoteQueryExecutor constructors formatting 2024-01-30 13:06:47 +00:00
Igor Nikonov
416910db00 Remove unnecessary outer loop 2024-01-30 13:03:43 +00:00
Raúl Marín
b3483eede3 Fix translate() return type 2024-01-30 13:41:04 +01:00
Alexey Milovidov
fd959f0bd2
Merge pull request #59372 from ClickHouse/rename-ddsketch 
Rename `quantileDDSketch` to `quantileDD`
 2024-01-30 13:13:31 +01:00
Nikolai Kochetov
f11163fe36
Merge pull request #59347 from kitaisreal/loggers-build-loggers-fix 
Loggers initialization fix
 2024-01-30 13:07:47 +01:00
Kruglov Pavel
3105960fd8
Merge pull request #59352 from Avogar/fix-bad-attached-rabbitmq 
Fix lazy initialization in RabbitMQ
 2024-01-30 12:52:07 +01:00
Alexey Milovidov
8eac21c963 Merge branch 'master' of github.com:ClickHouse/ClickHouse into rename-ddsketch 2024-01-30 11:50:52 +01:00
Alexey Milovidov
798f655276 Rename quantileDDSketch to quantileDD 2024-01-30 11:49:56 +01:00
Raúl Marín
ccc4295542 More typos in settings 2024-01-30 11:35:14 +01:00
Jordi Villar
f984770223
Minor typos in Settings.h 2024-01-30 11:23:07 +01:00
Kseniia Sumarokova
e16aaa8d81
Merge branch 'master' into broken-projections-better-handling 2024-01-30 10:54:22 +01:00
Dmitry Novik
5a34641e91 Merge remote-tracking branch 'origin/master' into fix-analyzer-resolve-distr-id 2024-01-30 07:17:15 +00:00
Dmitry Novik
c339a74ac3
Merge pull request #59177 from ClickHouse/fix-analyzer-cte-resolve 
Analyzer: Fix CTE name clash resolution
 2024-01-30 08:13:38 +01:00
Alexey Milovidov
b7a8933b2c
Merge pull request #59319 from bigo-sg/improve_regexp_extract 
Improve exception message of function regexp_extract
 2024-01-30 08:13:14 +01:00
Alexey Milovidov
a286d500c3
Merge pull request #59124 from amosbird/dashboard-compress-state 
Compress state of dashboard
 2024-01-30 08:05:38 +01:00
Alexey Milovidov
5cf1242a72
Merge pull request #59293 from slvrtrn/reapply-net-read-write-mysql 
Re-apply MySQL net write/read settings changeset
 2024-01-30 06:37:09 +01:00
Alexey Milovidov
b4a5b6060e
Merge pull request #59341 from rschu1ze/non-string-concat-with-separator 
Allow non-string arguments in `concatWithSeparator()`
 2024-01-30 04:10:06 +01:00
Alexey Milovidov
35ea956255
Merge pull request #59295 from ClickHouse/fix_block_number 
Fix `_block_number` column with non-default serializations and mutation
 2024-01-30 04:07:09 +01:00
Alexey Milovidov
ac90637170
Merge pull request #59122 from arthurpassos/bring_back_attach_partition_pr 
Revert revert attach partition PR
 2024-01-30 04:02:31 +01:00
Alexey Milovidov
fe2b5cde05
Merge pull request #59338 from vitlibar/support-format-clause-in-backup-query 
Support the FORMAT clause in BACKUP and RESTORE queries
 2024-01-30 04:00:21 +01:00
Alexey Milovidov
de341a6d6e
Merge pull request #59351 from ClickHouse/fix-non-redy-set-system-tables 
Fix not-ready set for system.tables
 2024-01-30 03:59:18 +01:00
Alexey Milovidov
2a1cbc2db4
Merge pull request #59354 from CurtizJ/better-memory-usage-async-read 
Slightly better memory usage in `AsynchronousBoundedReadBuffer`
 2024-01-30 03:55:42 +01:00
Alexey Milovidov
50532c485f
Merge pull request #59340 from CurtizJ/lower-memory-usage-vertical-merges 
Lower memory usage in vertical merges
 2024-01-30 03:42:28 +01:00
taiyang-li
815c73f1e5 change as request 2024-01-30 10:41:42 +08:00
Alexey Gerasimchuck
b1d2c0d93a minor update 2024-01-29 23:56:54 +00:00
Alexey Gerasimchuck
559de083a3 Implemented failed login attempt counting using quota 2024-01-29 23:20:38 +00:00
Raúl Marín
dfc761ce5f
Merge pull request #59343 from ClickHouse/Fix_new_setting_for_azure 
Fix upgrade check for new setting
 2024-01-29 23:22:06 +01:00
Yarik Briukhovetskyi
5ba82eed81
Merge pull request #58841 from yariks5s/dictionary_table_exception_fix 
Fixing exceptions when table/dictionary already exist
 2024-01-29 22:41:06 +01:00
Anton Popov
182d1c08b8 slightly better memory usage in AsynchronousBoundedReadBuffer 2024-01-29 21:21:52 +00:00
Raúl Marín
1580f73795
Update SettingsChangesHistory.h 2024-01-29 21:53:05 +01:00
Raúl Marín
45776ea035
Update SettingsChangesHistory.h 2024-01-29 21:24:20 +01:00
avogar
3a5ba56c36 Fix lazy initialization in RabbitMQ, fix possible deadlock on insert into unitialized queue engine 2024-01-29 20:09:09 +00:00
Raúl Marín
5108393157 Merge remote-tracking branch 'blessed/master' into Fix_new_setting_for_azure 2024-01-29 21:09:00 +01:00
Alexey Milovidov
69a1935a3e
Merge pull request #59345 from Algunenano/sccache_fix 
Fix sccache when building without coverage
 2024-01-29 21:06:29 +01:00
Robert Schulze
7683b44bf6
Merge pull request #58961 from ClibMouse/seriesDecompose 
Return baseline component from function `seriesDecomposeSTL()`
 2024-01-29 20:41:09 +01:00
Robert Schulze
2cfcaf8ff4
Merge pull request #59040 from MochiXu/fix_remove_inverted_index_files 
`DROP INDEX` of inverted index now removes all relevant files from persistence
 2024-01-29 20:39:56 +01:00
Robert Schulze
8ddda0caf0
Merge pull request #59229 from rschu1ze/cleanup-msan-usage 
Minor cleanup of msan usage
 2024-01-29 20:39:06 +01:00
Robert Schulze
80066118d9
Merge pull request #59132 from HarryLeeIBM/hlee-arm64-hash 
Fix aggregation issue in mixed x86_64 and ARM clusters
 2024-01-29 20:37:52 +01:00
slvrtrn
e2476e9f89 Merge remote-tracking branch 'origin' into reapply-net-read-write-mysql 2024-01-29 20:11:17 +01:00
slvrtrn
7cef679f6d Address PR feedback 2024-01-29 20:11:02 +01:00
kssenii
df7d3b8a40 Allocate current shard number from keeper 2024-01-29 19:36:16 +01:00
Arthur Passos
15d04d0a78
Merge branch 'master' into bring_back_attach_partition_pr 2024-01-29 15:16:49 -03:00
Arthur Passos
516daadeef add static storage assert in datapartcloner 2024-01-29 15:16:00 -03:00
Nikolai Kochetov
d0143380d7 Fix not-ready set for system.tables 2024-01-29 17:53:59 +00:00
Raúl Marín
925582bec2
Merge branch 'master' into Fix_new_setting_for_azure 2024-01-29 18:27:22 +01:00
Raúl Marín
f22762fcdc
Merge pull request #59335 from kitaisreal/volume-constructor-improve-exception-message 
IVolume constructor improve exception message
 2024-01-29 18:25:57 +01:00
Maksim Kita
7892adc18b Add setting update_insert_deduplication_token_in_dependent_materialized_views to settings changes history 2024-01-29 20:18:25 +03:00
Maksim Kita
5b1919aff1 Loggers initialization fix 2024-01-29 20:11:14 +03:00
Raúl Marín
b88d0a2b15 Don't apply O2 on release builds 2024-01-29 17:34:11 +01:00
Raúl Marín
468c7cf835
Merge pull request #59329 from Algunenano/prefertch 
Fix typo
 2024-01-29 17:02:01 +01:00
Smita Kulkarni
621c3e8596 Fix upgrade check for new setting 2024-01-29 16:50:01 +01:00
Nikolai Kochetov
5b2648929b
Merge pull request #59273 from kitaisreal/atomic-logger 
Added AtomicLogger
 2024-01-29 16:49:18 +01:00
Vitaly Baranov
1f446f78b5 Fix parameter's name. 2024-01-29 16:24:16 +01:00
Robert Schulze
c2b7d2047e
Support arguments of arbitary type in function concatWithSeparator() 
Follow-up to #56540
 2024-01-29 14:11:21 +00:00
Anton Popov
d3cdc8826e lower memory usage in vertical merges 2024-01-29 14:06:46 +00:00
Robert Schulze
1aae7d7d95
Cosmetics: Rename variable 2024-01-29 13:35:19 +00:00
Robert Schulze
2191569d6b
Cosmetics: remove superfluous inline 2024-01-29 13:24:43 +00:00
Vitaly Baranov
9fa76bea7e Support FORMAT clause in BACKUP/RESTORE query. 2024-01-29 14:19:16 +01:00
Raúl Marín
a6de4a21a3 Merge remote-tracking branch 'blessed/master' into parallel_replicas_cte 2024-01-29 13:33:22 +01:00
Maksim Kita
5affd6af2e IVolume constructor improve exception message 2024-01-29 15:32:22 +03:00
Yarik Briukhovetskyi
9f2093df75
Restart CI 2024-01-29 12:54:29 +01:00
Nikolai Kochetov
a51aa7b668
Merge pull request #59238 from kitaisreal/update-insert-deduplication-token-in-dependent-materialized-views 
Added setting update_insert_deduplication_token_in_dependent_materialized_views
 2024-01-29 12:52:06 +01:00
kssenii
d0ea5392db Fix storing iterated keys 2024-01-29 12:36:32 +01:00
kssenii
ef252d8376 Validate settings with keeper, add a test 2024-01-29 12:36:00 +01:00
Raúl Marín
ab2b12ba9f Fix typo 2024-01-29 11:40:12 +01:00
Kruglov Pavel
6858d2f4ca
Merge pull request #58047 from Avogar/variant-data-type 
Implement Variant data type
 2024-01-29 11:36:08 +01:00
Kseniia Sumarokova
6903957414
Merge pull request #59001 from ClickHouse/Add_configurable_write_retry_azure 
Add settings max_unexpected_write_error_retries for Azure Blob Storage
 2024-01-29 10:48:17 +01:00
Kseniia Sumarokova
a29ab8f29c
Merge pull request #59170 from azat/disks/s3-plain-improvements 
Small improvements for tables on write-once (s3_plain)/read-only (web) disks
 2024-01-29 10:44:37 +01:00
Kseniia Sumarokova
0f88da5fd4
Merge pull request #59275 from ClickHouse/Avogar-patch-1 
Fix abort in iceberg metadata on bad file paths
 2024-01-29 10:35:34 +01:00
alesapin
b864b122fa Merge branch 'master' into fix_block_number 2024-01-29 10:19:43 +01:00
taiyang-li
7aea3847db improve exception message of function regexp_extract 2024-01-29 11:54:19 +08:00
taiyang-li
49fc8a7099 Merge branch 'master' into improve_if_with_floating 2024-01-29 11:02:05 +08:00
Alexey Milovidov
2cb2bcfbc3
Merge pull request #59315 from ClickHouse/support-backups-for-compressed-memory-tables 
Support backups for compressed in-memory tables
 2024-01-29 01:50:41 +01:00
Alexey Milovidov
a7483ec10b
Merge pull request #59242 from rschu1ze/dont-force-libssh-on-me 
Make libssh build dependent on `-DENABLE_LIBRARIES`
 2024-01-29 00:02:03 +01:00
Alexey Milovidov
caded18be5
Merge pull request #59290 from CurtizJ/lower-memory-usage 
Lower memory usage after reading from `MergeTree` tables
 2024-01-29 00:00:02 +01:00
Alexey Milovidov
aec3f28ccb Support backups for compressed in-memory tables 2024-01-28 23:06:50 +01:00
Alexey Milovidov
8326f5ffb7
Merge pull request #59308 from ClickHouse/fix-async-loader-stop 
Fix deadlock in `AsyncLoader::stop()`
 2024-01-28 22:18:00 +01:00
Arthur Passos
0bbfef884c
Merge branch 'ClickHouse:master' into bring_back_attach_partition_pr 2024-01-28 17:43:38 -03:00
serxa
aa6c7e78be fix deadlock in AsyncLoader::stop() 2024-01-28 15:47:17 +00:00
Anton Popov
ef133bfd47 Merge remote-tracking branch 'upstream/master' into lower-memory-usage 2024-01-28 15:07:44 +00:00
avogar
92db86b829 Merge branch 'master' of github.com:ClickHouse/ClickHouse into variant-data-type 2024-01-28 14:33:49 +00:00
Kruglov Pavel
29700fbad1
Fix special build 2024-01-28 15:33:27 +01:00
Alexey Milovidov
267b077038 Merge remote-tracking branch 'origin/master' into remove-kql 2024-01-28 14:24:26 +01:00
Alexey Milovidov
e0f0b21e90 Remove KQL 2024-01-28 14:24:13 +01:00
Alexey Milovidov
29d54dab55
Merge pull request #59288 from azat/rmt/drop-update-zk 
Use fresh ZooKeeper client on DROP (to have higher chances on success)
 2024-01-28 13:16:21 +01:00
Maksim Kita
5165fb7286 Fixed build 2024-01-28 13:55:44 +03:00
Maksim Kita
50309dfd90 Fixed tests 2024-01-28 13:55:44 +03:00
Maksim Kita
07750ee949 Added AtomicLogger 2024-01-28 13:55:44 +03:00
avogar
00c140b7bb Fix getting filename from read buffer wrappers 2024-01-27 21:13:08 +00:00
alesapin
7022ca9ece Fix _block_number column with non-default serializations and mutation 2024-01-27 20:24:03 +01:00
slvrtrn
eb909a5db4 Reapply add MySQL net write/read settings 2024-01-27 18:36:38 +01:00
Smita Kulkarni
b7a6dbfbb9 Check engine to avoid possible seg fault 2024-01-27 18:22:37 +01:00
Anton Popov
9d3b4e5308 lower memory usage 2024-01-27 16:40:11 +00:00
Azat Khuzhin
d94547d338 Use fresh ZooKeeper client on DROP (to have higher chances on success) 
In case of DROP the client can be expired, and even though
StorageReplicatedMergeTree::drop() uses getZooKeeperIfTableShutDown(),
which creates new client if current is expired, it is not enough, since
current_zookeeper (cached client) will be used implicitly from
dropAllData().

This had been found by stress tests, that leads to DROP query hang [1].

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/59255/94eb33ef27a9ab7c4a99af40772ea287e67efcbf/stress_test__tsan_.html

<details>

<summary>stacktrace</summary>

    2024.01.26 17:41:41.138577 [ 3319 ] {} <Error> DatabaseCatalog: Cannot drop table test_vzfk1xoc.alter_table1 (455a674c-161d-44d8-abc2-fd205bad1116). Will retry later.: Code: 999. Coordination::Exception: Session expired. (KEEPER_EXCEPTION), Stack trace (when copying this message, always include the lines below):

    0. ./contrib/llvm-project/libcxx/include/exception:134: Poco::Exception::Exception(String const&, int) @ 0x000000001e06a5e3 in /usr/bin/clickhouse
    1. ./build_docker/./src/Common/Exception.cpp:96: DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000000f697c74 in /usr/bin/clickhouse
    2. ./src/Common/Exception.h:0: Coordination::Exception::Exception<char const (&) [16]>(char const (&) [16], Coordination::Error) @ 0x000000001adc298b in /usr/bin/clickhouse
    3. ./src/Common/ZooKeeper/IKeeper.h:0: Coordination::ZooKeeper::pushRequest(Coordination::ZooKeeper::RequestInfo&&) @ 0x000000001adfb418 in /usr/bin/clickhouse
    4. ./build_docker/./src/Common/ZooKeeper/ZooKeeperImpl.cpp:1343: Coordination::ZooKeeper::get(String const&, std::function<void (Coordination::GetResponse const&)>, std::shared_ptr<std::function<void (Coordination::WatchResponse const&)>>) @ 0x000000001adfd8e5 in /usr/bin/clickhouse
    5. ./contrib/llvm-project/libcxx/include/__functional/function.h:818: ? @ 0x000000001ad890bd in /usr/bin/clickhouse
    6. ./contrib/llvm-project/libcxx/include/__functional/function.h:818: ? @ 0x000000001ad88a36 in /usr/bin/clickhouse
    7. ./build_docker/./src/Common/ZooKeeper/ZooKeeper.cpp:580: zkutil::ZooKeeper::tryGetWatch(String const&, String&, Coordination::Stat*, std::function<void (Coordination::WatchResponse const&)>, Coordination::Error*) @ 0x000000001ad898bf in /usr/bin/clickhouse
    8. ./build_docker/./src/Common/ZooKeeper/ZooKeeper.cpp:570: zkutil::ZooKeeper::tryGet(String const&, String&, Coordination::Stat*, std::shared_ptr<Poco::Event> const&, Coordination::Error*) @ 0x000000001ad89554 in /usr/bin/clickhouse
    9. ./build_docker/./src/Common/ZooKeeper/ZooKeeperWithFaultInjection.cpp:0: DB::ZooKeeperWithFaultInjection::tryGet(String const&, String&, Coordination::Stat*, std::shared_ptr<Poco::Event> const&, Coordination::Error*) @ 0x000000001ae110dc in /usr/bin/clickhouse
    10. ./contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:701: DB::StorageReplicatedMergeTree::unlockSharedDataByID(String, String const&, DB::MergeTreePartInfo const&, String const&, String const&, std::shared_ptr<DB::ZooKeeperWithFaultInjection> const&, DB::MergeTreeSettings const&, std::shared_ptr<Poco::Logger>, String const&, StrongTypedef<unsigned int, DB::MergeTreeDataFormatVersionTag>) @ 0x000000001975527e in /usr/bin/clickhouse
    11. ./build_docker/./src/Storages/StorageReplicatedMergeTree.cpp:0: DB::StorageReplicatedMergeTree::removeSharedDetachedPart(std::shared_ptr<DB::IDisk>, String const&, String const&, String const&, String const&, String const&, std::shared_ptr<DB::Context const> const&, std::shared_ptr<zkutil::ZooKeeper> const&) @ 0x000000001976c980 in /usr/bin/clickhouse
    12. ./build_docker/./src/Storages/StorageReplicatedMergeTree.cpp:10171: DB::StorageReplicatedMergeTree::removeDetachedPart(std::shared_ptr<DB::IDisk>, String const&, String const&) @ 0x000000001976bdc6 in /usr/bin/clickhouse
    13. ./build_docker/./src/Storages/MergeTree/MergeTreeData.cpp:2798: DB::MergeTreeData::dropAllData() @ 0x0000000019c643c8 in /usr/bin/clickhouse
    14. ./build_docker/./src/Storages/StorageReplicatedMergeTree.cpp:1117: DB::StorageReplicatedMergeTree::drop() @ 0x0000000019664e0a in /usr/bin/clickhouse
    15. ./build_docker/./src/Interpreters/DatabaseCatalog.cpp:0: DB::DatabaseCatalog::dropTableFinally(DB::DatabaseCatalog::TableMarkedAsDropped const&) @ 0x0000000017bf1fac in /usr/bin/clickhouse
    16. ./build_docker/./src/Interpreters/DatabaseCatalog.cpp:0: DB::DatabaseCatalog::dropTableDataTask() @ 0x0000000017bf175e in /usr/bin/clickhouse
    17. ./contrib/llvm-project/libcxx/include/__functional/function.h:717: ? @ 0x0000000017bf94c2 in /usr/bin/clickhouse
    18. ./contrib/llvm-project/libcxx/include/__functional/function.h:0: ? @ 0x00000000170bd0b8 in /usr/bin/clickhouse
    19. ./contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:701: DB::BackgroundSchedulePool::threadFunction() @ 0x00000000170c06ce in /usr/bin/clickhouse
    20. ./build_docker/./src/Core/BackgroundSchedulePool.cpp:0: void std::__function::__policy_invoker<void ()>::__call_impl<std::__function::__default_alloc_func<ThreadFromGlobalPoolImpl<false>::ThreadFromGlobalPoolImpl<DB::BackgroundSchedulePool::BackgroundSchedulePool(unsigned long, StrongTypedef<unsigned long, CurrentMetrics::MetricTag>, StrongTypedef<unsigned long, CurrentMetrics::MetricTag>, char const*)::$_0>(DB::BackgroundSchedulePool::BackgroundSchedulePool(unsigned long, StrongTypedef<unsigned long, CurrentMetrics::MetricTag>, StrongTypedef<unsigned long, CurrentMetrics::MetricTag>, char const*)::$_0&&)::'lambda'(), void ()>>(std::__function::__policy_storage const*) @ 0x00000000170c0feb in /usr/bin/clickhouse
    21. ./base/base/../base/wide_integer_impl.h:809: ThreadPoolImpl<std::thread>::worker(std::__list_iterator<std::thread, void*>) @ 0x000000000f7c6a2f in /usr/bin/clickhouse
    22. ./contrib/llvm-project/libcxx/include/__memory/unique_ptr.h:302: void* std::__thread_proxy[abi:v15000]<std::tuple<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, void ThreadPoolImpl<std::thread>::scheduleImpl<void>(std::function<void ()>, Priority, std::optional<unsigned long>, bool)::'lambda0'()>>(void*) @ 0x000000000f7cc8f2 in /usr/bin/clickhouse
    23. ? @ 0x000000000733904f in /usr/bin/clickhouse
    24. ? @ 0x00007f28b2319ac3
    25. ? @ 0x00007f28b23ab850

</details>

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-27 16:04:18 +01:00
Maksim Kita
0f46200d5a Fixed tests 2024-01-27 15:57:49 +03:00
Maksim Kita
5d62cdd58c Added setting update_insert_deduplication_token_in_dependent_materialized_views 2024-01-27 15:57:48 +03:00
Kruglov Pavel
1e61521dcc
Add missing setting optimize_injective_functions_in_group_by to SettingsChangesHistory 2024-01-26 23:33:04 +01:00
kssenii
0a21e6aa5d Fix 2024-01-26 19:07:30 +01:00
Aleksandr Musorin
e6352234c3 Added parsing trailing symbols for type expressions 
```sql
SELECT (1, 'foo')::Tuple(a Int, b String,);
SELECT (1, 'foo')::Tuple(Int, String,);
SELECT (1, (2,'foo'))::Tuple(Int, Tuple(Int, String,),);
````

fix
 2024-01-26 17:56:14 +01:00
avogar
5833641fa5 Merge branch 'master' of github.com:ClickHouse/ClickHouse into variant-data-type 2024-01-26 16:54:02 +00:00
Kruglov Pavel
8fcedddcda
Fix abort in iceberg metadata on bad file paths 2024-01-26 17:46:49 +01:00
Arthur Passos
d8deebaaba
Merge branch 'ClickHouse:master' into bring_back_attach_partition_pr 2024-01-26 13:27:57 -03:00
Azat Khuzhin
90ab986be6 Revert "Prohibit CREATE on static storages (ATTACH should be used instead)" 
CREATE is used by Replicated database even for ATTACH, and anyway ATTACH
creates format_version.txt as well (without previuos patch).

This reverts commit 323f1f320ebe7e588d443abf78efa2c60193e7a9.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 16:47:36 +01:00
Azat Khuzhin
7ba31bf55c Do not create format_version.txt on write-once storages 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 16:47:36 +01:00
Azat Khuzhin
66a40bda0a Revert "Prohibit DROP from static storages" 
It is actually OK to DROP at least from read-only disk, as for the
write-once it should be OK as well, since CREATE is prohibited anyway,
so there should be no leftovers

CI: https://s3.amazonaws.com/clickhouse-test-reports/59170/c82050d1925439f0ede2b32acb5b1b8df4acae5d/stress_test__asan_.html
CI: https://s3.amazonaws.com/clickhouse-test-reports/59170/c82050d1925439f0ede2b32acb5b1b8df4acae5d/integration_tests__asan__[3_4].html

This reverts commit 082e62712c5e2f4c48d1abc6141ccfd1249d26b4.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 16:47:35 +01:00
Azat Khuzhin
aafc149c1e Prohibit CREATE on static storages (ATTACH should be used instead) 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 16:47:35 +01:00
Azat Khuzhin
1ee723d50d Prohibit DROP from static storages 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 16:47:35 +01:00
Azat Khuzhin
d79c1f7e1c Fix MetadataStorageFromPlainObjectStorage::iterateDirectory() (add prefix) 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 16:47:35 +01:00
Azat Khuzhin
9ce18bbf43 Implement MetadataStorageFromPlainObjectStorageTransaction::removeDirectory (for DROP TABLE) 
This is required to remove format_version.txt for MergeTree after DROP

    (lldb) bt
    * thread 192, name = 'BgSchPool', stop reason = breakpoint 1.1
        frame 0: 0x0000000016c7f452 clickhouse`__cxa_throw(thrown_object=0x00007ffd7a53c480, tinfo=0x00000000011602a0, dest=(clickhouse`DB::Exception::~Exception() at Exception.h:40)) + 18 at cxa_exception.cpp:258
        frame 1: 0x00000000109bf709 clickhouse`DB::IMetadataTransaction::throwNotImplemented() + 137 at IMetadataStorage.h:151
        frame 2: 0x00000000109bf126 clickhouse`DB::IMetadataTransaction::removeDirectory(this=<unavailable>, (null)=<unavailable>) + 6 at IMetadataStorage.h:96
        frame 3: 0x0000000010968978 clickhouse`DB::(anonymous namespace)::RemoveRecursiveObjectStorageOperation::removeMetadataRecursive(this=0x00007ffd7a7327a0, tx=std::__1::shared_ptr<DB::IMetadataTransaction>::element_type @ 0x00007ffd7a6f6018 strong=4 weak=1, path_to_remove="tmp_insert_all_2_2_0") + 376 at DiskObjectStorageTransaction.cpp:364
        frame 4: 0x000000001096893d clickhouse`DB::(anonymous namespace)::RemoveRecursiveObjectStorageOperation::removeMetadataRecursive(this=0x00007ffd7a7327a0, tx=std::__1::shared_ptr<DB::IMetadataTransaction>::element_type @ 0x00007ffd7a6f6018 strong=4 weak=1, path_to_remove="store/27f/27f6f9d2-ab2e-4817-b771-0e706e485b15/") + 317 at DiskObjectStorageTransaction.cpp:362
        frame 5: 0x0000000010965a7f clickhouse`DB::(anonymous namespace)::RemoveRecursiveObjectStorageOperation::execute(this=0x00007ffd7a7327a0, tx=std::__1::shared_ptr<DB::IMetadataTransaction>::element_type @ 0x00007ffd7a6f6018 strong=4 weak=1) + 95 at DiskObjectStorageTransaction.cpp:372
        frame 6: 0x0000000010963a2f clickhouse`DB::DiskObjectStorageTransaction::commit(this=0x00007ffea22b6168) + 79 at DiskObjectStorageTransaction.cpp:903
        frame 7: 0x00000000109577e5 clickhouse`DB::DiskObjectStorage::removeSharedRecursive(this=<unavailable>, path="store/27f/27f6f9d2-ab2e-4817-b771-0e706e485b15/", keep_all_batch_data=false, file_names_remove_metadata_only=size=0) + 133 at DiskObjectStorage.cpp:426
        frame 8: 0x000000001095af79 clickhouse`DB::DiskObjectStorage::removeRecursive(this=<unavailable>, path=<unavailable>) + 57 at DiskObjectStorage.h:79
      * frame 9: 0x0000000010b5c3d5 clickhouse`DB::DatabaseCatalog::dropTableFinally(this=0x00007ffff7096800, table=0x00007ffe853e1bd0) + 1365 at DatabaseCatalog.cpp:1317
        frame 10: 0x0000000010b5b7e7 clickhouse`DB::DatabaseCatalog::dropTableDataTask(this=0x00007ffff7096800) + 2375 at DatabaseCatalog.cpp:1270

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 16:47:35 +01:00
Azat Khuzhin
f3b4f28f0d Disable mutable operations into {Replicated,}MergeTree with static storage 
Mutable operations includes:
- INSERT
- OPTIMIZE
- parts manipulation
- ...

But does not include DROP, since you need an ability to DROP it.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 16:47:35 +01:00
Azat Khuzhin
41ebaefeda Add a note for MetadataStorageFromPlainObjectStorage to support transactions 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 16:47:35 +01:00
Azat Khuzhin
6751e01cc3 Do not drop parts for static (ro/write-once) storages for Replicated engine 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 16:47:35 +01:00
Dmitry Novik
6c5057c4f2
Merge pull request #58919 from ClickHouse/analyzer-inj-func-elemination 
Analyzer: Support GROUP BY injective function elimination
 2024-01-26 16:45:09 +01:00
kssenii
5cd757dd9a Merge remote-tracking branch 'origin/master' into s3-queue-parallelize-ordered-mode 2024-01-26 16:33:22 +01:00
Kseniia Sumarokova
99653fc778
Merge branch 'master' into broken-projections-better-handling 2024-01-26 16:27:23 +01:00
kssenii
ee15b6e646 Fix 2024-01-26 16:26:59 +01:00
Dmitry Novik
a9d2e13697 Handle CTEs more careafully 2024-01-26 15:20:09 +00:00
Dmitry Novik
e38face46b Fix style 2024-01-26 15:20:09 +00:00
Dmitry Novik
778f4371c2 Cleanup the code 2024-01-26 15:20:09 +00:00
Dmitry Novik
e3c07d4562 Analyzer: Fix CTE name clash resolution 2024-01-26 15:20:09 +00:00
Raúl Marín
335c7da319 Merge remote-tracking branch 'blessed/master' into parallel_replicas_cte 2024-01-26 16:19:56 +01:00
Dmitry Novik
394e37894f Small improvement in QueryAnalysisPass 2024-01-26 15:03:35 +00:00
avogar
7908f69d84 Fix special builds and tests 2024-01-26 14:01:06 +00:00
Arthur Passos
ce6877cbb6
Merge branch 'ClickHouse:master' into bring_back_attach_partition_pr 2024-01-26 10:57:11 -03:00
Raúl Marín
176d8beac9 Disable parallel replicas JOIN with CTE (not analyzer) 2024-01-26 14:36:38 +01:00
Nikolai Kochetov
75edbdd39c
Merge pull request #59147 from ClickHouse/vdimir/fix_agg_nothing_2 
Fix AggregateFunctionNothing result type issues introducing it with different names
 2024-01-26 14:33:38 +01:00
Yarik Briukhovetskyi
0cbadc9b52
Merge pull request #59190 from yariks5s/fix_to_string_nullable_timezone 
Fix crash with nullable timezone for `toString`
 2024-01-26 13:33:12 +01:00
taiyang-li
56db02c953 Merge branch 'master' into improve_if_with_floating 2024-01-26 19:21:49 +08:00
Nikolai Kochetov
10d4f1fd87
Merge pull request #59228 from kitaisreal/actions-dag-build-filter-actions-refactoring 
Actions dag build filter actions refactoring
 2024-01-26 11:34:19 +01:00
Sergei Trifonov
4fb511bfb3
Merge pull request #59137 from ClickHouse/fix-async-loader-shutdown-deadlock 
Fix not started database shutdown deadlock
 2024-01-26 11:21:13 +01:00
taiyang-li
29b3cf60a6 fix perf regression 2024-01-26 16:45:09 +08:00
Vitaly Baranov
3fbdf48b53
Merge pull request #59244 from vitlibar/disable-copy-constructor-for-multi-version 
Disable copy constructor for MultiVersion
 2024-01-26 09:29:43 +01:00
pufit
92e63bf45c
Load server configs in clickhouse local (#59231) 
Load server configs in clickhouse local
 2024-01-25 23:13:31 -05:00
taiyang-li
626e30609a change as request 2024-01-26 10:43:27 +08:00
avogar
7f6784937d Fix 2024-01-25 23:59:24 +00:00
Vitaly Baranov
a7b1fe9fa2 Disable copy constructor for MultiVersion. 2024-01-25 23:53:54 +01:00
Alexey Milovidov
aedffeaab0
Merge pull request #58959 from Algunenano/fix_sum_map 
Fix sumMapFiltered with NaN values
 2024-01-25 23:50:28 +01:00
Robert Schulze
caeb31940c
Allow to build without libssl 2024-01-25 21:14:03 +00:00
avogar
ff15ab12b8 Remove bad implementation of DataTypeVariant::createColumnConst, support use_variant_as_common_type setting in functions array/map 2024-01-25 21:06:50 +00:00
Sema Checherinda
a69a0aea0e
Merge pull request #59066 from ClickHouse/chesema-remove-flaky-test 
remove flaky test
 2024-01-25 21:39:46 +01:00
Kruglov Pavel
e431f89339
Restart CI 2024-01-25 18:19:46 +01:00
Nikita Taranov
368ef60c77
Merge pull request #59093 from ClickHouse/nickitat-patch-18 
Add `[[nodiscard]]` to a couple of methods
 2024-01-25 17:03:05 +01:00
Robert Schulze
16a9e95605
Minor cleanup of msan usage 2024-01-25 15:40:11 +00:00
Maksim Kita
5bb734a4bb ActionsDAG buildFilterActionsDAG refactoring 2024-01-25 18:24:14 +03:00
Kseniia Sumarokova
70514e3d14
Merge pull request #57615 from ClickHouse/filecache-small-optimization 
fs cache: small optimization
 2024-01-25 15:50:09 +01:00
Yarik Briukhovetskyi
da1cf46b14
Fix fuzzer 2024-01-25 15:47:32 +01:00
avogar
4b26de9660 Rename setting to use it not only in if/multiIf in future 2024-01-25 13:26:13 +00:00
taiyang-li
aca8e90ec9 optimize when if condition is constant 2024-01-25 20:09:26 +08:00
yariks5s
1620c069b7 Merge branch 'fix_to_string_nullable_timezone' of github.com:yariks5s/ClickHouse into fix_to_string_nullable_timezone 2024-01-25 12:02:49 +00:00
yariks5s
c277148ee1 enhanced tests, fix 2024-01-25 12:01:51 +00:00
Maksim Kita
109337e91e Updated implementation 2024-01-25 14:31:49 +03:00
Maksim Kita
2a327107b6 Updated implementation 2024-01-25 14:31:49 +03:00
Maksim Kita
42029f42e7 Table CREATE DROP Poco::Logger memory leak fix 2024-01-25 14:31:18 +03:00
serxa
a40da92761 Merge branch 'master' into fix-async-loader-shutdown-deadlock 2024-01-25 11:31:05 +00:00
Kseniia Sumarokova
951c874aa9
Merge pull request #59080 from ClickHouse/data-lakes-survive-restart 
Allow server to start with broken data lake table and fix itself lazily
 2024-01-25 11:50:16 +01:00
Kseniia Sumarokova
b13be4fd55
Merge pull request #59175 from ClickHouse/filecache-minor 
Move some headers
 2024-01-25 11:33:57 +01:00
taiyang-li
e8629cf4f5 add another perf and tests 2024-01-25 18:02:55 +08:00
Antonio Andelic
0386830b98
Merge pull request #59145 from ClickHouse/capability-check-s3-plain 
Capability check for `s3_plain`
 2024-01-25 09:28:36 +01:00
Dmitry Novik
a2d7bcbd5f
Merge pull request #58958 from ClickHouse/analyzer-insert-block 
Analyzer: fix storage replacement with insertion block
 2024-01-25 09:25:50 +01:00
Igor Nikonov
7ae7086a2d
Merge pull request #59153 from ClickHouse/fix-pr-limit-by 
Fix: LIMIT BY and LIMIT in distributed query
 2024-01-25 01:51:52 +01:00
Yarik Briukhovetskyi
f71c38f71c
Merge branch 'ClickHouse:master' into fix_to_string_nullable_timezone 2024-01-25 00:12:16 +01:00
Nikita Taranov
1e3f6894a3
Merge pull request #59089 from nickitat/sort_res_ranges_before_sending_to_replica 
Coordinator returns ranges for reading in sorted order
 2024-01-24 21:04:53 +01:00
yariks5s
4deb1eab19 init 2024-01-24 18:17:19 +00:00
Bhavna Jindal
926982856d Merge remote-tracking branch 'upstream/master' into seriesDecompose 2024-01-24 10:11:00 -08:00
kssenii
9038f0710a Minor 2024-01-24 18:44:13 +01:00
Kseniia Sumarokova
d674a5ce24
Merge pull request #59168 from ClickHouse/kssenii-patch-9 
Decrease log level for one log message
 2024-01-24 18:39:55 +01:00
Kseniia Sumarokova
235980d52e
Update FileCache.cpp 2024-01-24 17:28:01 +01:00
kssenii
5ecf36f275 Fix style check 2024-01-24 17:19:52 +01:00
Dmitry Novik
95e2a3d6da
Merge pull request #58911 from ClickHouse/fix-index-hint-crash 
Fix crash when indexHint() is used
 2024-01-24 17:16:22 +01:00
Kseniia Sumarokova
a4186dc4d3
Decrease log level for one log message 2024-01-24 16:34:29 +01:00
kssenii
7f8f379d7f Parallel & disrtibuted processing for ordered mode 2024-01-24 16:32:15 +01:00
Dmitry Novik
7826706ff9
Small fix 2024-01-24 16:09:26 +01:00
Igor Nikonov
698aef50c2 Fix: LIMIT BY in distriubted query 2024-01-24 12:43:01 +00:00
Kruglov Pavel
89bafbcda6
Merge pull request #59133 from Avogar/allow-to-ignore-schema-evolution-in-iceberg 
Allow to ignore schema evolution in Iceberg table engine under a setting
 2024-01-24 13:19:09 +01:00
taiyang-li
2418798e3c fix code style 2024-01-24 20:02:07 +08:00
taiyang-li
4e337f8317 add perf tests 2024-01-24 20:00:26 +08:00
taiyang-li
eae7878609 fix style 2024-01-24 19:53:50 +08:00
kssenii
0d7710ee4b Fix build 2024-01-24 12:39:01 +01:00
Kruglov Pavel
6c0615d493
Merge pull request #59099 from skyoct/fix/fix_mult_redirect 
Disable "Too many redirects" error  retry
 2024-01-24 12:22:01 +01:00
Kruglov Pavel
718064bb43
Minor change to restart CI 2024-01-24 12:19:10 +01:00
kssenii
ed607fbd2c Merge remote-tracking branch 'origin/master' into filecache-small-optimization 2024-01-24 11:58:44 +01:00
Antonio Andelic
34463fd5e5
Merge pull request #59002 from ClickHouse/keeper-reduce-memory 
Reduce Keeper memory usage
 2024-01-24 11:54:16 +01:00
taiyang-li
393cab820e add some comment 2024-01-24 18:48:29 +08:00
taiyang-li
622a0f65b3 optimize for float 2024-01-24 18:46:06 +08:00
Antonio Andelic
62a3847888
Update src/Disks/ObjectStorages/ObjectStorageFactory.cpp 2024-01-24 11:15:52 +01:00
vdimir
bcfe691954
Use different names for nothing function with different result types 2024-01-24 09:55:09 +00:00