thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-03 04:52:10 +00:00
Code Issues Packages Projects Releases Wiki Activity
134,052 Commits 9,181 Branches 1,782 Tags 2.2 GiB
813020a1a6
Commit Graph

52734 Commits

Author SHA1 Message Date
Maksim Kita
50309dfd90 Fixed tests 2024-01-28 13:55:44 +03:00
Maksim Kita
07750ee949 Added AtomicLogger 2024-01-28 13:55:44 +03:00
avogar
00c140b7bb Fix getting filename from read buffer wrappers 2024-01-27 21:13:08 +00:00
alesapin
7022ca9ece Fix _block_number column with non-default serializations and mutation 2024-01-27 20:24:03 +01:00
slvrtrn
eb909a5db4 Reapply add MySQL net write/read settings 2024-01-27 18:36:38 +01:00
Smita Kulkarni
b7a6dbfbb9 Check engine to avoid possible seg fault 2024-01-27 18:22:37 +01:00
Anton Popov
9d3b4e5308 lower memory usage 2024-01-27 16:40:11 +00:00
Azat Khuzhin
d94547d338 Use fresh ZooKeeper client on DROP (to have higher chances on success) 
In case of DROP the client can be expired, and even though
StorageReplicatedMergeTree::drop() uses getZooKeeperIfTableShutDown(),
which creates new client if current is expired, it is not enough, since
current_zookeeper (cached client) will be used implicitly from
dropAllData().

This had been found by stress tests, that leads to DROP query hang [1].

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/59255/94eb33ef27a9ab7c4a99af40772ea287e67efcbf/stress_test__tsan_.html

<details>

<summary>stacktrace</summary>

    2024.01.26 17:41:41.138577 [ 3319 ] {} <Error> DatabaseCatalog: Cannot drop table test_vzfk1xoc.alter_table1 (455a674c-161d-44d8-abc2-fd205bad1116). Will retry later.: Code: 999. Coordination::Exception: Session expired. (KEEPER_EXCEPTION), Stack trace (when copying this message, always include the lines below):

    0. ./contrib/llvm-project/libcxx/include/exception:134: Poco::Exception::Exception(String const&, int) @ 0x000000001e06a5e3 in /usr/bin/clickhouse
    1. ./build_docker/./src/Common/Exception.cpp:96: DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000000f697c74 in /usr/bin/clickhouse
    2. ./src/Common/Exception.h:0: Coordination::Exception::Exception<char const (&) [16]>(char const (&) [16], Coordination::Error) @ 0x000000001adc298b in /usr/bin/clickhouse
    3. ./src/Common/ZooKeeper/IKeeper.h:0: Coordination::ZooKeeper::pushRequest(Coordination::ZooKeeper::RequestInfo&&) @ 0x000000001adfb418 in /usr/bin/clickhouse
    4. ./build_docker/./src/Common/ZooKeeper/ZooKeeperImpl.cpp:1343: Coordination::ZooKeeper::get(String const&, std::function<void (Coordination::GetResponse const&)>, std::shared_ptr<std::function<void (Coordination::WatchResponse const&)>>) @ 0x000000001adfd8e5 in /usr/bin/clickhouse
    5. ./contrib/llvm-project/libcxx/include/__functional/function.h:818: ? @ 0x000000001ad890bd in /usr/bin/clickhouse
    6. ./contrib/llvm-project/libcxx/include/__functional/function.h:818: ? @ 0x000000001ad88a36 in /usr/bin/clickhouse
    7. ./build_docker/./src/Common/ZooKeeper/ZooKeeper.cpp:580: zkutil::ZooKeeper::tryGetWatch(String const&, String&, Coordination::Stat*, std::function<void (Coordination::WatchResponse const&)>, Coordination::Error*) @ 0x000000001ad898bf in /usr/bin/clickhouse
    8. ./build_docker/./src/Common/ZooKeeper/ZooKeeper.cpp:570: zkutil::ZooKeeper::tryGet(String const&, String&, Coordination::Stat*, std::shared_ptr<Poco::Event> const&, Coordination::Error*) @ 0x000000001ad89554 in /usr/bin/clickhouse
    9. ./build_docker/./src/Common/ZooKeeper/ZooKeeperWithFaultInjection.cpp:0: DB::ZooKeeperWithFaultInjection::tryGet(String const&, String&, Coordination::Stat*, std::shared_ptr<Poco::Event> const&, Coordination::Error*) @ 0x000000001ae110dc in /usr/bin/clickhouse
    10. ./contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:701: DB::StorageReplicatedMergeTree::unlockSharedDataByID(String, String const&, DB::MergeTreePartInfo const&, String const&, String const&, std::shared_ptr<DB::ZooKeeperWithFaultInjection> const&, DB::MergeTreeSettings const&, std::shared_ptr<Poco::Logger>, String const&, StrongTypedef<unsigned int, DB::MergeTreeDataFormatVersionTag>) @ 0x000000001975527e in /usr/bin/clickhouse
    11. ./build_docker/./src/Storages/StorageReplicatedMergeTree.cpp:0: DB::StorageReplicatedMergeTree::removeSharedDetachedPart(std::shared_ptr<DB::IDisk>, String const&, String const&, String const&, String const&, String const&, std::shared_ptr<DB::Context const> const&, std::shared_ptr<zkutil::ZooKeeper> const&) @ 0x000000001976c980 in /usr/bin/clickhouse
    12. ./build_docker/./src/Storages/StorageReplicatedMergeTree.cpp:10171: DB::StorageReplicatedMergeTree::removeDetachedPart(std::shared_ptr<DB::IDisk>, String const&, String const&) @ 0x000000001976bdc6 in /usr/bin/clickhouse
    13. ./build_docker/./src/Storages/MergeTree/MergeTreeData.cpp:2798: DB::MergeTreeData::dropAllData() @ 0x0000000019c643c8 in /usr/bin/clickhouse
    14. ./build_docker/./src/Storages/StorageReplicatedMergeTree.cpp:1117: DB::StorageReplicatedMergeTree::drop() @ 0x0000000019664e0a in /usr/bin/clickhouse
    15. ./build_docker/./src/Interpreters/DatabaseCatalog.cpp:0: DB::DatabaseCatalog::dropTableFinally(DB::DatabaseCatalog::TableMarkedAsDropped const&) @ 0x0000000017bf1fac in /usr/bin/clickhouse
    16. ./build_docker/./src/Interpreters/DatabaseCatalog.cpp:0: DB::DatabaseCatalog::dropTableDataTask() @ 0x0000000017bf175e in /usr/bin/clickhouse
    17. ./contrib/llvm-project/libcxx/include/__functional/function.h:717: ? @ 0x0000000017bf94c2 in /usr/bin/clickhouse
    18. ./contrib/llvm-project/libcxx/include/__functional/function.h:0: ? @ 0x00000000170bd0b8 in /usr/bin/clickhouse
    19. ./contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:701: DB::BackgroundSchedulePool::threadFunction() @ 0x00000000170c06ce in /usr/bin/clickhouse
    20. ./build_docker/./src/Core/BackgroundSchedulePool.cpp:0: void std::__function::__policy_invoker<void ()>::__call_impl<std::__function::__default_alloc_func<ThreadFromGlobalPoolImpl<false>::ThreadFromGlobalPoolImpl<DB::BackgroundSchedulePool::BackgroundSchedulePool(unsigned long, StrongTypedef<unsigned long, CurrentMetrics::MetricTag>, StrongTypedef<unsigned long, CurrentMetrics::MetricTag>, char const*)::$_0>(DB::BackgroundSchedulePool::BackgroundSchedulePool(unsigned long, StrongTypedef<unsigned long, CurrentMetrics::MetricTag>, StrongTypedef<unsigned long, CurrentMetrics::MetricTag>, char const*)::$_0&&)::'lambda'(), void ()>>(std::__function::__policy_storage const*) @ 0x00000000170c0feb in /usr/bin/clickhouse
    21. ./base/base/../base/wide_integer_impl.h:809: ThreadPoolImpl<std::thread>::worker(std::__list_iterator<std::thread, void*>) @ 0x000000000f7c6a2f in /usr/bin/clickhouse
    22. ./contrib/llvm-project/libcxx/include/__memory/unique_ptr.h:302: void* std::__thread_proxy[abi:v15000]<std::tuple<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, void ThreadPoolImpl<std::thread>::scheduleImpl<void>(std::function<void ()>, Priority, std::optional<unsigned long>, bool)::'lambda0'()>>(void*) @ 0x000000000f7cc8f2 in /usr/bin/clickhouse
    23. ? @ 0x000000000733904f in /usr/bin/clickhouse
    24. ? @ 0x00007f28b2319ac3
    25. ? @ 0x00007f28b23ab850

</details>

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-27 16:04:18 +01:00
Maksim Kita
0f46200d5a Fixed tests 2024-01-27 15:57:49 +03:00
Maksim Kita
5d62cdd58c Added setting update_insert_deduplication_token_in_dependent_materialized_views 2024-01-27 15:57:48 +03:00
Kruglov Pavel
1e61521dcc
Add missing setting optimize_injective_functions_in_group_by to SettingsChangesHistory 2024-01-26 23:33:04 +01:00
kssenii
0a21e6aa5d Fix 2024-01-26 19:07:30 +01:00
Aleksandr Musorin
e6352234c3 Added parsing trailing symbols for type expressions 
```sql
SELECT (1, 'foo')::Tuple(a Int, b String,);
SELECT (1, 'foo')::Tuple(Int, String,);
SELECT (1, (2,'foo'))::Tuple(Int, Tuple(Int, String,),);
````

fix
 2024-01-26 17:56:14 +01:00
avogar
5833641fa5 Merge branch 'master' of github.com:ClickHouse/ClickHouse into variant-data-type 2024-01-26 16:54:02 +00:00
Kruglov Pavel
8fcedddcda
Fix abort in iceberg metadata on bad file paths 2024-01-26 17:46:49 +01:00
Arthur Passos
d8deebaaba
Merge branch 'ClickHouse:master' into bring_back_attach_partition_pr 2024-01-26 13:27:57 -03:00
Azat Khuzhin
90ab986be6 Revert "Prohibit CREATE on static storages (ATTACH should be used instead)" 
CREATE is used by Replicated database even for ATTACH, and anyway ATTACH
creates format_version.txt as well (without previuos patch).

This reverts commit 323f1f320ebe7e588d443abf78efa2c60193e7a9.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 16:47:36 +01:00
Azat Khuzhin
7ba31bf55c Do not create format_version.txt on write-once storages 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 16:47:36 +01:00
Azat Khuzhin
66a40bda0a Revert "Prohibit DROP from static storages" 
It is actually OK to DROP at least from read-only disk, as for the
write-once it should be OK as well, since CREATE is prohibited anyway,
so there should be no leftovers

CI: https://s3.amazonaws.com/clickhouse-test-reports/59170/c82050d1925439f0ede2b32acb5b1b8df4acae5d/stress_test__asan_.html
CI: https://s3.amazonaws.com/clickhouse-test-reports/59170/c82050d1925439f0ede2b32acb5b1b8df4acae5d/integration_tests__asan__[3_4].html

This reverts commit 082e62712c5e2f4c48d1abc6141ccfd1249d26b4.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 16:47:35 +01:00
Azat Khuzhin
aafc149c1e Prohibit CREATE on static storages (ATTACH should be used instead) 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 16:47:35 +01:00
Azat Khuzhin
1ee723d50d Prohibit DROP from static storages 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 16:47:35 +01:00
Azat Khuzhin
d79c1f7e1c Fix MetadataStorageFromPlainObjectStorage::iterateDirectory() (add prefix) 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 16:47:35 +01:00
Azat Khuzhin
9ce18bbf43 Implement MetadataStorageFromPlainObjectStorageTransaction::removeDirectory (for DROP TABLE) 
This is required to remove format_version.txt for MergeTree after DROP

    (lldb) bt
    * thread 192, name = 'BgSchPool', stop reason = breakpoint 1.1
        frame 0: 0x0000000016c7f452 clickhouse`__cxa_throw(thrown_object=0x00007ffd7a53c480, tinfo=0x00000000011602a0, dest=(clickhouse`DB::Exception::~Exception() at Exception.h:40)) + 18 at cxa_exception.cpp:258
        frame 1: 0x00000000109bf709 clickhouse`DB::IMetadataTransaction::throwNotImplemented() + 137 at IMetadataStorage.h:151
        frame 2: 0x00000000109bf126 clickhouse`DB::IMetadataTransaction::removeDirectory(this=<unavailable>, (null)=<unavailable>) + 6 at IMetadataStorage.h:96
        frame 3: 0x0000000010968978 clickhouse`DB::(anonymous namespace)::RemoveRecursiveObjectStorageOperation::removeMetadataRecursive(this=0x00007ffd7a7327a0, tx=std::__1::shared_ptr<DB::IMetadataTransaction>::element_type @ 0x00007ffd7a6f6018 strong=4 weak=1, path_to_remove="tmp_insert_all_2_2_0") + 376 at DiskObjectStorageTransaction.cpp:364
        frame 4: 0x000000001096893d clickhouse`DB::(anonymous namespace)::RemoveRecursiveObjectStorageOperation::removeMetadataRecursive(this=0x00007ffd7a7327a0, tx=std::__1::shared_ptr<DB::IMetadataTransaction>::element_type @ 0x00007ffd7a6f6018 strong=4 weak=1, path_to_remove="store/27f/27f6f9d2-ab2e-4817-b771-0e706e485b15/") + 317 at DiskObjectStorageTransaction.cpp:362
        frame 5: 0x0000000010965a7f clickhouse`DB::(anonymous namespace)::RemoveRecursiveObjectStorageOperation::execute(this=0x00007ffd7a7327a0, tx=std::__1::shared_ptr<DB::IMetadataTransaction>::element_type @ 0x00007ffd7a6f6018 strong=4 weak=1) + 95 at DiskObjectStorageTransaction.cpp:372
        frame 6: 0x0000000010963a2f clickhouse`DB::DiskObjectStorageTransaction::commit(this=0x00007ffea22b6168) + 79 at DiskObjectStorageTransaction.cpp:903
        frame 7: 0x00000000109577e5 clickhouse`DB::DiskObjectStorage::removeSharedRecursive(this=<unavailable>, path="store/27f/27f6f9d2-ab2e-4817-b771-0e706e485b15/", keep_all_batch_data=false, file_names_remove_metadata_only=size=0) + 133 at DiskObjectStorage.cpp:426
        frame 8: 0x000000001095af79 clickhouse`DB::DiskObjectStorage::removeRecursive(this=<unavailable>, path=<unavailable>) + 57 at DiskObjectStorage.h:79
      * frame 9: 0x0000000010b5c3d5 clickhouse`DB::DatabaseCatalog::dropTableFinally(this=0x00007ffff7096800, table=0x00007ffe853e1bd0) + 1365 at DatabaseCatalog.cpp:1317
        frame 10: 0x0000000010b5b7e7 clickhouse`DB::DatabaseCatalog::dropTableDataTask(this=0x00007ffff7096800) + 2375 at DatabaseCatalog.cpp:1270

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 16:47:35 +01:00
Azat Khuzhin
f3b4f28f0d Disable mutable operations into {Replicated,}MergeTree with static storage 
Mutable operations includes:
- INSERT
- OPTIMIZE
- parts manipulation
- ...

But does not include DROP, since you need an ability to DROP it.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 16:47:35 +01:00
Azat Khuzhin
41ebaefeda Add a note for MetadataStorageFromPlainObjectStorage to support transactions 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 16:47:35 +01:00
Azat Khuzhin
6751e01cc3 Do not drop parts for static (ro/write-once) storages for Replicated engine 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 16:47:35 +01:00
Dmitry Novik
6c5057c4f2
Merge pull request #58919 from ClickHouse/analyzer-inj-func-elemination 
Analyzer: Support GROUP BY injective function elimination
 2024-01-26 16:45:09 +01:00
kssenii
5cd757dd9a Merge remote-tracking branch 'origin/master' into s3-queue-parallelize-ordered-mode 2024-01-26 16:33:22 +01:00
Kseniia Sumarokova
99653fc778
Merge branch 'master' into broken-projections-better-handling 2024-01-26 16:27:23 +01:00
kssenii
ee15b6e646 Fix 2024-01-26 16:26:59 +01:00
Dmitry Novik
a9d2e13697 Handle CTEs more careafully 2024-01-26 15:20:09 +00:00
Dmitry Novik
e38face46b Fix style 2024-01-26 15:20:09 +00:00
Dmitry Novik
778f4371c2 Cleanup the code 2024-01-26 15:20:09 +00:00
Dmitry Novik
e3c07d4562 Analyzer: Fix CTE name clash resolution 2024-01-26 15:20:09 +00:00
Raúl Marín
335c7da319 Merge remote-tracking branch 'blessed/master' into parallel_replicas_cte 2024-01-26 16:19:56 +01:00
Dmitry Novik
394e37894f Small improvement in QueryAnalysisPass 2024-01-26 15:03:35 +00:00
avogar
7908f69d84 Fix special builds and tests 2024-01-26 14:01:06 +00:00
Arthur Passos
ce6877cbb6
Merge branch 'ClickHouse:master' into bring_back_attach_partition_pr 2024-01-26 10:57:11 -03:00
Raúl Marín
176d8beac9 Disable parallel replicas JOIN with CTE (not analyzer) 2024-01-26 14:36:38 +01:00
Nikolai Kochetov
75edbdd39c
Merge pull request #59147 from ClickHouse/vdimir/fix_agg_nothing_2 
Fix AggregateFunctionNothing result type issues introducing it with different names
 2024-01-26 14:33:38 +01:00
Yarik Briukhovetskyi
0cbadc9b52
Merge pull request #59190 from yariks5s/fix_to_string_nullable_timezone 
Fix crash with nullable timezone for `toString`
 2024-01-26 13:33:12 +01:00
taiyang-li
56db02c953 Merge branch 'master' into improve_if_with_floating 2024-01-26 19:21:49 +08:00
Nikolai Kochetov
10d4f1fd87
Merge pull request #59228 from kitaisreal/actions-dag-build-filter-actions-refactoring 
Actions dag build filter actions refactoring
 2024-01-26 11:34:19 +01:00
Sergei Trifonov
4fb511bfb3
Merge pull request #59137 from ClickHouse/fix-async-loader-shutdown-deadlock 
Fix not started database shutdown deadlock
 2024-01-26 11:21:13 +01:00
taiyang-li
29b3cf60a6 fix perf regression 2024-01-26 16:45:09 +08:00
Vitaly Baranov
3fbdf48b53
Merge pull request #59244 from vitlibar/disable-copy-constructor-for-multi-version 
Disable copy constructor for MultiVersion
 2024-01-26 09:29:43 +01:00
pufit
92e63bf45c
Load server configs in clickhouse local (#59231) 
Load server configs in clickhouse local
 2024-01-25 23:13:31 -05:00
taiyang-li
626e30609a change as request 2024-01-26 10:43:27 +08:00
avogar
7f6784937d Fix 2024-01-25 23:59:24 +00:00
Vitaly Baranov
a7b1fe9fa2 Disable copy constructor for MultiVersion. 2024-01-25 23:53:54 +01:00
Alexey Milovidov
aedffeaab0
Merge pull request #58959 from Algunenano/fix_sum_map 
Fix sumMapFiltered with NaN values
 2024-01-25 23:50:28 +01:00
Robert Schulze
caeb31940c
Allow to build without libssl 2024-01-25 21:14:03 +00:00
avogar
ff15ab12b8 Remove bad implementation of DataTypeVariant::createColumnConst, support use_variant_as_common_type setting in functions array/map 2024-01-25 21:06:50 +00:00
Sema Checherinda
a69a0aea0e
Merge pull request #59066 from ClickHouse/chesema-remove-flaky-test 
remove flaky test
 2024-01-25 21:39:46 +01:00
Kruglov Pavel
e431f89339
Restart CI 2024-01-25 18:19:46 +01:00
Nikita Taranov
368ef60c77
Merge pull request #59093 from ClickHouse/nickitat-patch-18 
Add `[[nodiscard]]` to a couple of methods
 2024-01-25 17:03:05 +01:00
Robert Schulze
16a9e95605
Minor cleanup of msan usage 2024-01-25 15:40:11 +00:00
Maksim Kita
5bb734a4bb ActionsDAG buildFilterActionsDAG refactoring 2024-01-25 18:24:14 +03:00
Kseniia Sumarokova
70514e3d14
Merge pull request #57615 from ClickHouse/filecache-small-optimization 
fs cache: small optimization
 2024-01-25 15:50:09 +01:00
Yarik Briukhovetskyi
da1cf46b14
Fix fuzzer 2024-01-25 15:47:32 +01:00
avogar
4b26de9660 Rename setting to use it not only in if/multiIf in future 2024-01-25 13:26:13 +00:00
taiyang-li
aca8e90ec9 optimize when if condition is constant 2024-01-25 20:09:26 +08:00
yariks5s
1620c069b7 Merge branch 'fix_to_string_nullable_timezone' of github.com:yariks5s/ClickHouse into fix_to_string_nullable_timezone 2024-01-25 12:02:49 +00:00
yariks5s
c277148ee1 enhanced tests, fix 2024-01-25 12:01:51 +00:00
Maksim Kita
109337e91e Updated implementation 2024-01-25 14:31:49 +03:00
Maksim Kita
2a327107b6 Updated implementation 2024-01-25 14:31:49 +03:00
Maksim Kita
42029f42e7 Table CREATE DROP Poco::Logger memory leak fix 2024-01-25 14:31:18 +03:00
serxa
a40da92761 Merge branch 'master' into fix-async-loader-shutdown-deadlock 2024-01-25 11:31:05 +00:00
Kseniia Sumarokova
951c874aa9
Merge pull request #59080 from ClickHouse/data-lakes-survive-restart 
Allow server to start with broken data lake table and fix itself lazily
 2024-01-25 11:50:16 +01:00
Kseniia Sumarokova
b13be4fd55
Merge pull request #59175 from ClickHouse/filecache-minor 
Move some headers
 2024-01-25 11:33:57 +01:00
taiyang-li
e8629cf4f5 add another perf and tests 2024-01-25 18:02:55 +08:00
Antonio Andelic
0386830b98
Merge pull request #59145 from ClickHouse/capability-check-s3-plain 
Capability check for `s3_plain`
 2024-01-25 09:28:36 +01:00
Dmitry Novik
a2d7bcbd5f
Merge pull request #58958 from ClickHouse/analyzer-insert-block 
Analyzer: fix storage replacement with insertion block
 2024-01-25 09:25:50 +01:00
Igor Nikonov
7ae7086a2d
Merge pull request #59153 from ClickHouse/fix-pr-limit-by 
Fix: LIMIT BY and LIMIT in distributed query
 2024-01-25 01:51:52 +01:00
Yarik Briukhovetskyi
f71c38f71c
Merge branch 'ClickHouse:master' into fix_to_string_nullable_timezone 2024-01-25 00:12:16 +01:00
Nikita Taranov
1e3f6894a3
Merge pull request #59089 from nickitat/sort_res_ranges_before_sending_to_replica 
Coordinator returns ranges for reading in sorted order
 2024-01-24 21:04:53 +01:00
yariks5s
4deb1eab19 init 2024-01-24 18:17:19 +00:00
Bhavna Jindal
926982856d Merge remote-tracking branch 'upstream/master' into seriesDecompose 2024-01-24 10:11:00 -08:00
kssenii
9038f0710a Minor 2024-01-24 18:44:13 +01:00
Kseniia Sumarokova
d674a5ce24
Merge pull request #59168 from ClickHouse/kssenii-patch-9 
Decrease log level for one log message
 2024-01-24 18:39:55 +01:00
Kseniia Sumarokova
235980d52e
Update FileCache.cpp 2024-01-24 17:28:01 +01:00
kssenii
5ecf36f275 Fix style check 2024-01-24 17:19:52 +01:00
Dmitry Novik
95e2a3d6da
Merge pull request #58911 from ClickHouse/fix-index-hint-crash 
Fix crash when indexHint() is used
 2024-01-24 17:16:22 +01:00
Kseniia Sumarokova
a4186dc4d3
Decrease log level for one log message 2024-01-24 16:34:29 +01:00
kssenii
7f8f379d7f Parallel & disrtibuted processing for ordered mode 2024-01-24 16:32:15 +01:00
Dmitry Novik
7826706ff9
Small fix 2024-01-24 16:09:26 +01:00
Igor Nikonov
698aef50c2 Fix: LIMIT BY in distriubted query 2024-01-24 12:43:01 +00:00
Kruglov Pavel
89bafbcda6
Merge pull request #59133 from Avogar/allow-to-ignore-schema-evolution-in-iceberg 
Allow to ignore schema evolution in Iceberg table engine under a setting
 2024-01-24 13:19:09 +01:00
taiyang-li
2418798e3c fix code style 2024-01-24 20:02:07 +08:00
taiyang-li
4e337f8317 add perf tests 2024-01-24 20:00:26 +08:00
taiyang-li
eae7878609 fix style 2024-01-24 19:53:50 +08:00
kssenii
0d7710ee4b Fix build 2024-01-24 12:39:01 +01:00
Kruglov Pavel
6c0615d493
Merge pull request #59099 from skyoct/fix/fix_mult_redirect 
Disable "Too many redirects" error  retry
 2024-01-24 12:22:01 +01:00
Kruglov Pavel
718064bb43
Minor change to restart CI 2024-01-24 12:19:10 +01:00
kssenii
ed607fbd2c Merge remote-tracking branch 'origin/master' into filecache-small-optimization 2024-01-24 11:58:44 +01:00
Antonio Andelic
34463fd5e5
Merge pull request #59002 from ClickHouse/keeper-reduce-memory 
Reduce Keeper memory usage
 2024-01-24 11:54:16 +01:00
taiyang-li
393cab820e add some comment 2024-01-24 18:48:29 +08:00
taiyang-li
622a0f65b3 optimize for float 2024-01-24 18:46:06 +08:00
Antonio Andelic
62a3847888
Update src/Disks/ObjectStorages/ObjectStorageFactory.cpp 2024-01-24 11:15:52 +01:00
vdimir
bcfe691954
Use different names for nothing function with different result types 2024-01-24 09:55:09 +00:00
Antonio Andelic
e112288c0b Capability check for s3_plain 2024-01-24 09:27:27 +00:00
taiyang-li
aed8ffe3d8 optimize for decimal 2024-01-24 16:30:37 +08:00
skyoct
95829e074e Opt code 2024-01-24 03:49:21 +00:00
Yarik Briukhovetskyi
f0be1ac2c4
Merge pull request #58936 from wheatdog/level-int-to-word 
Display word-descriptive log level while enabling structured log formatting in json
 2024-01-24 00:18:25 +01:00
serxa
c36090ec99 cleanup 2024-01-23 19:14:49 +00:00
serxa
8728ab768f Fix not started database shutdown deadlock 2024-01-23 19:01:57 +00:00
Arthur Passos
dba792dff0
Remove duplicate includ 2024-01-23 15:03:31 -03:00
Arthur Passos
e6b17377d0
Merge branch 'master' into bring_back_attach_partition_pr 2024-01-23 14:52:47 -03:00
avogar
be3b5dc45f Allow to ignore schema evolution in Iceberg table engine under a setting 2024-01-23 17:45:41 +00:00
HarryLeeIBM
94a79c081d Fix aggregation issue in mixed cluster of x86_64 and aarch64 2024-01-23 09:21:17 -08:00
Nikolai Kochetov
d64b491b45 Fixing build 2024-01-23 17:00:21 +00:00
Nikolai Kochetov
a26f8f5425
Merge pull request #59076 from ClickHouse/revert-59059-revert-58838-allow-parallel-replicas-for-join-with-analyzer 
Revert "Revert "Allow parallel replicas for JOIN with analyzer [part 1].""
 2024-01-23 17:01:19 +01:00
Amos Bird
7e86c0e928
Compress state of dashboard 2024-01-23 23:04:19 +08:00
Arthur Passos
5179891aef remove static log 2024-01-23 11:43:08 -03:00
Arthur Passos
799a94081b Revert "Revert "Allow to attach partition from table with different partition expression when destination partition expression doesn't re-partition"" 
This reverts commit a1c83e2f51.
 2024-01-23 11:40:42 -03:00
Tim Liou
7981d182bc Merge branch 'master' into level-int-to-word 2024-01-23 22:29:07 +08:00
Robert Schulze
a1c83e2f51
Revert "Allow to attach partition from table with different partition expression when destination partition expression doesn't re-partition" 2024-01-23 15:26:04 +01:00
Anton Popov
4292ee7d51
Merge pull request #58886 from CurtizJ/better-read-buffers 
Less error prone interface of read buffers
 2024-01-23 14:59:27 +01:00
Dmitry Novik
bef0fcb482
Fix is_order_by_all flag in QueryNode 2024-01-23 14:56:24 +01:00
Nikita Taranov
c7be7363cf fix 2024-01-23 14:46:33 +01:00
Dmitry Novik
e9ea1307e0 Make optimization more general 2024-01-23 13:03:09 +00:00
Antonio Andelic
74dd68afbc
Merge pull request #59102 from ClickHouse/keeper-startup-fix 
Avoid election timeouts during startup in Keeper
 2024-01-23 13:55:52 +01:00
Alexander Gololobov
9a0e5d0aac
Merge pull request #58914 from ClickHouse/ot_spans_in_insert 
Opentelemetry spans to analyze CPU and S3 bottlenecks on inserts
 2024-01-23 13:53:13 +01:00
Nikolai Kochetov
fcbab407b8
Merge branch 'master' into revert-59059-revert-58838-allow-parallel-replicas-for-join-with-analyzer 2024-01-23 12:21:44 +01:00
Kruglov Pavel
b8d2af9574
Merge pull request #59104 from ClickHouse/Avogar-patch-1 
Add missing setting max_estimated_execution_time in  SettingsChangesHistory
 2024-01-23 12:05:49 +01:00
Dmitry Novik
7a95eb8bd1
Review fixes 2024-01-23 11:59:41 +01:00
Robert Schulze
9752079983
Cosmetics 2024-01-23 10:58:09 +00:00
Robert Schulze
e23e7e6b73
Merge pull request #53710 from rschu1ze/system-reload-asynchronous-metrics 
Add statement `SYSTEM RELOAD ASYNCHRONOUS METRICS`
 2024-01-23 11:56:25 +01:00
kssenii
bca73d4b0a Fix 2024-01-23 11:51:21 +01:00
kssenii
b76630c955 Merge remote-tracking branch 'origin/master' into broken-projections-better-handling 2024-01-23 11:34:58 +01:00
Dmitry Novik
6962859e43
Merge pull request #59068 from ClickHouse/check-optimization-setting 
Followup to 57853
 2024-01-23 11:24:31 +01:00
Kseniia Sumarokova
f6ffbb4c0a
Merge pull request #59049 from ClickHouse/fix-data-race-in-factories 
Fix data race on query_factories_info
 2024-01-23 11:22:40 +01:00
Robert Schulze
e67076ea2b
Merge pull request #55201 from canhld94/column_level_compress_block 
Column-level compression block sizes
 2024-01-23 11:22:03 +01:00
Robert Schulze
bfec324b28
Some fixups + test 2024-01-23 10:17:16 +00:00
Robert Schulze
81543c0a46
Merge remote-tracking branch 'rschu1ze/master' into fix_remove_inverted_index_files 2024-01-23 09:45:09 +00:00
Kruglov Pavel
415589d4fc
Fix typo 2024-01-23 10:32:28 +01:00
Kruglov Pavel
35a3879c1f
Add missing setting max_estimated_execution_time in SettingsChangesHistory 2024-01-23 10:17:19 +01:00
Nikita Mikhaylov
bd7024ff9b
Merge pull request #59083 from ClickHouse/fix-startup-failure 
Fix server shutdown due to exception while loading metadata
 2024-01-23 09:48:38 +01:00
Antonio Andelic
9ce3f8a7aa
typo 2024-01-23 09:18:51 +01:00
Antonio Andelic
ff644831e2 Avoid election timeouts during startup 2024-01-23 08:02:30 +00:00
Robert Schulze
ebdad85c4f
Sort integer aliases 2024-01-23 06:11:47 +00:00
Robert Schulze
6f4c0925ab
Merge pull request #58954 from slvrtrn/mysql-add-signed-unsigned-aliases 
MySQL compatibility: add SIGNED/UNSIGNED aliases for Int64/UInt64
 2024-01-23 07:01:31 +01:00
serxa
6db59de888 use LOGICAL_ERROR to see if it breaks 2024-01-23 05:54:25 +00:00
serxa
a1de16d660 wait for currently running jobs to finish 2024-01-22 23:46:54 +00:00
Nikita Taranov
3355ed7139
Add [[nodiscard]] to a couple of methods 2024-01-23 00:28:15 +01:00
Nikita Taranov
09e24ed6c5
Merge pull request #58068 from zhongyuankai/limit_materialized_view_size 
A limit on the number of materialized views attached to a table.
 2024-01-22 22:50:56 +01:00
Nikita Taranov
b161921825 impl 2024-01-22 22:33:23 +01:00
Bhavna Jindal
084ee74b68 minor fix 2024-01-22 13:32:57 -08:00
Bhavna Jindal
d9edd5a7f3 fix spell check 2024-01-22 13:32:57 -08:00
Bhavna Jindal
f935493f28 fix trailing whitespaces 2024-01-22 13:32:57 -08:00
Bhavna Jindal
c59f3e164f Return baseline component as fourth array 2024-01-22 13:32:57 -08:00
Max K
4932b1cad9
Merge branch 'master' into better-read-buffers 2024-01-22 21:52:55 +01:00
Arthur Passos
24b8bbe9fa
Allow to attach partition from table with different partition expression when destination partition expression doesn't re-partition (#39507) 
* temp commit

* temp commit

* draft impl for feedback

* fix weird style changes

* fix weird style changes

* fix weird style changes

* fix weird style changes

* fix weird style changes

* aa

* aa

* Add integ tests and remove partition key restriction

* fix small incosistency in partition id

* style fix

* style fix

* style fix

* use existing DataPartStorageBuilder instead of new one

* Refactor part clone to make it more readable and maintainable

* Add MergeTreeDataPartCloner docs

* define ErrorCodes::BAD_ARGUMENTS

* Rebase

* camel case methods

* address some comments

* yet another rebase?

* Move from integ tests to stateless tests

* address more comments

* add finalize on min_max_idx files

* Add sync option to DistinctPartitionExpCloner

* just a temp test

* revert temp change

* Use echoOn to distinguish test queries

* remove comment

* fix build issue during rebase

* atempt to fix build after rebase

* finally fix build

* clear minmaxidx hyperrectangle before loading it

* Fix error on min_max files deletion where it was being assumed that partition expression contained all columns

* get it to the state it was previously

* add missing include

* getting functional?

* refactoring and renaming

* some more refactoring

* extern bad arguments

* try to fix style

* improvements and docs

* remove duplicate includes

* fix crash

* make tests more stable by ordering

* rebase once again..

* fix

* make ci happy?

* fix rebase issues

* docs

* rebase, but prolly needs to be improved

* refactor out from nasty inheritance to static methods

* fix style

* work around optional

* refactor & integrate some changes

* update column_type

* add tests by dencrane

* set utc

* fix ref file

* fix tests

* use MergeTree instead of SummingMergeTree

* mark MergeTreeDataPart::getBlock as const

* address a few comments

* compute module function name size at compile time

* simplify branching in getPartitionAstFieldsCount

* remove column_indexes argument

* merge getBlock with buildBlock

* add some const specifiers

* small adjustments

* remove no longer needed isNull check

* use std::min and max to update global min max idx

* add some assertions

* forward declare some symbols

* fix grammar

* forward decl

* try to fix build..

* remove IFunction forward decl

* Revert "use std::min and max to update global min max idx"

This reverts commit b2fe79dda7.

* Revert "remove no longer needed isNull check"

This reverts commit 129db2610f.

* Revert "Revert "remove no longer needed isNull check""

This reverts commit 9416087dd8.

* Revert "Revert "use std::min and max to update global min max idx""

This reverts commit 20246d4416.

* remove some comments

* partial use of MonotonicityCheckMatcher

* ranges

* remove KeyDescriptionMonotonicityChecker

* remove duplication of applyfunction

* move functions to anonymous namespace

* move functions to cpp

* Relax partition compatibility requirements by accepting subset, add tests from partitioned to unpartitioned

* updte reference file

* Support for partition by a, b, c to partition by a, b

* refactoring part 1

* refactoring part 2, use hyperrectangle, still not complete

* refactoring part 3, build hyperrectangle with intersection of source & destination min max columns

* Support attaching to table with partition expression of multiple expressions

* add tests

* rename method

* remove some code duplication

* draft impl for replicatedmergetree, need to dive deeper

* ship ref file

* fix impl for replicatedmergetree..

* forbid attach empty partition replicatedmergetree

* Add replicated merge tree integration tests

* add test missing files

* fix black

* do not check for monotonicity of empty partition

* add empty tests & fix replicated

* remove no longer needed buildBlockWithMinMaxINdexes

* remove column logic in buildHyperrectangle

* simplify implementation by using existing methods

* further simplify implementation

* move all MergeTreeDataPartClone private methods to .cpp file

* decrease decomposition

* use different namespaces

* reduce code duplication

* fix style

* address a few comments

* add chassert to assert arguments size on MonotonicityCheckVisitor

* remove deleteMinMaxFiles method

* remove useless checks from sanitycheck

* add tests for attach partition (not id)

* Remove sanityCheckASTPartition and bring back conditional getPartitionIDFromQuery

* remove empty block comment

* small fixes

* fix formatting

* add missing include

* remove duplicate iuncludes

* trigger ci

* reduce some code duplication

* use updated partition id on replicatedmergetree

* fix build

* fix build

* small refactor

* do not use insert increment on fetch part

* remove duplicate includes

* add one more integ test

* black

* black

* rely on partition exp instead of partition id on replicated part fetch to decide if it is a different partition exp

* add one more integ test

* add order by clause

* fix black

---------

Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
 2024-01-22 21:00:04 +01:00
serxa
f1ab22d4c3 fix style 2024-01-22 19:54:50 +00:00
serxa
fad5aeede3 fix 2024-01-22 19:43:25 +00:00
serxa
1d6d1182fd Fix server shutdown due to exception while loading metadata 2024-01-22 19:38:26 +00:00
Raúl Marín
f5ffe4e473 Try getting a better error 2024-01-22 18:58:06 +01:00
Raúl Marín
a5a3ad2afe Merge remote-tracking branch 'blessed/master' into fix_sum_map 2024-01-22 18:56:15 +01:00
kssenii
1aa8e62bb7 Fix 2024-01-22 18:26:44 +01:00
Robert Schulze
90a0ea36b3
Add statement 'SYSTEM RELOAD ASYNCHRONOUS METRICS' 2024-01-22 17:14:58 +00:00
Robert Schulze
748371d127
Refactor locking in AsynchronousMetrics 2024-01-22 16:51:02 +00:00
Robert Schulze
1262945df7
Cosmetics 2024-01-22 16:51:02 +00:00
Nikolai Kochetov
65c5ea31a8
Revert "Revert "Allow parallel replicas for JOIN with analyzer [part 1]."" 2024-01-22 17:09:34 +01:00
Duc Canh Le
ed031f32af address review comments 
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
 2024-01-22 16:06:29 +00:00
Dmitry Novik
4e5249275e
Do not resolve remote table id on initiator 2024-01-22 16:45:25 +01:00
Dmitry Novik
f702afb72d Fix includes 2024-01-22 15:26:25 +00:00
Dmitry Novik
1abe1307db Make test to check the feature 2024-01-22 15:15:30 +00:00
Anton Popov
e1e7a9cd45
Merge branch 'master' into better-read-buffers 2024-01-22 15:50:48 +01:00
Alexander Tokmakov
2f1d4f094b
Add a parameter for testing purposes (#59027) 
* Update ConnectionParameters.cpp

* Update ConnectionParameters.cpp

* Update ConnectionParameters.cpp
 2024-01-22 15:48:44 +01:00
Alexander Tokmakov
cddd41ccd5
Merge pull request #59070 from ClickHouse/revert-55575-no-octal-leading-zeroes 
Revert "Consume leading zeroes when parsing a number in ConstantExpressionTemplate"
 2024-01-22 15:35:16 +01:00
Alexander Tokmakov
c2202ff347
Skip unavailable replicas in parallel distributed insert select (#58931) 
* Update StorageDistributed.cpp

* Update StorageDistributed.cpp

* Update StorageDistributed.cpp

* add a test

* Update 01099_parallel_distributed_insert_select.sql
 2024-01-22 15:34:46 +01:00
Alexander Tokmakov
9b6455122c
Revert "Consume leading zeroes when parsing a number in ConstantExpressionTemplate" 2024-01-22 15:31:08 +01:00
mochi
0606a77267
Update src/Storages/MergeTree/MutateTask.cpp 
Co-authored-by: Dmitry Novik <mrnovikd@gmail.com>
 2024-01-22 22:02:50 +08:00
Raúl Marín
1e875431db
Style 2024-01-22 14:59:53 +01:00
vdimir
0791c75315
Merge pull request #58654 from yariks5s/paste_join_aliases_requirement 
Avoid alias duplicates in PASTE JOIN and fix aliases requirement
 2024-01-22 14:48:13 +01:00
Dmitry Novik
3d0e915088
Followup to 57853 2024-01-22 14:44:07 +01:00
avogar
b4dcd6755a Use ColumnConst instead of Field in IColumn::createWithOffsets 2024-01-22 13:41:58 +00:00
Sema Checherinda
66cd61eb7e remove flaky test 2024-01-22 14:17:25 +01:00
Nikita Taranov
4d6ef8ed86
Merge pull request #56961 from nickitat/some_questionable_code 
Bypass `Poco::BasicBufferedStreamBuf` in `ReadBufferFromIStream`
 2024-01-22 14:08:09 +01:00
Alexander Tokmakov
0f0785cf20
Merge pull request #59059 from ClickHouse/revert-58838-allow-parallel-replicas-for-join-with-analyzer 
Revert "Allow parallel replicas for JOIN with analyzer [part 1]."
 2024-01-22 14:07:26 +01:00
Dmitry Novik
a18a8d8ea3
Merge pull request #59009 from nickitat/uniq_optimisation_for_distributed 
`uniqExact` state parallel merging for distributed queries
 2024-01-22 14:05:02 +01:00
kssenii
4b4eac7c06 Fix 2024-01-22 13:55:15 +01:00
Alexander Tokmakov
4315d44517
Revert "Allow parallel replicas for JOIN with analyzer [part 1]." 2024-01-22 13:30:35 +01:00
alesapin
478b91cc37
Merge pull request #59010 from ClickHouse/alesapin-patch-1 
Change log level for super imporant message in Keeper
 2024-01-22 13:16:56 +01:00
kssenii
3faf4087e3 Fix 2024-01-22 12:07:49 +01:00
Sema Checherinda
9adab57771
Correct initialization of ConnectionTimeouts (#59000) 2024-01-22 12:03:36 +01:00
Kseniia Sumarokova
aec76d6653
Merge pull request #58877 from ClickHouse/multiple-read-file-log-storage-in-mv 
Multiple read file log storage in mv
 2024-01-22 12:02:41 +01:00
Alexander Sapin
f7b21b6016 Fix build 2024-01-22 11:53:21 +01:00
Antonio Andelic
274c128bd7 Free memory 2024-01-22 10:48:39 +00:00
skyoct
fdf8008804 Fix redirect retry 2024-01-22 10:27:35 +00:00
Sergei Trifonov
04a040ee5c
Merge pull request #59013 from ClickHouse/remove-static-resource-manager 2024-01-22 10:59:58 +01:00
Raúl Marín
d9ab300300
Merge pull request #57853 from jiebinn/rewriteSumFunction 
Rewrite the AST/Analyzer of sum(column +/- literal) function
 2024-01-22 10:41:30 +01:00
Antonio Andelic
59f9abcf58 Merge branch 'master' into keeper-reduce-memory 2024-01-22 08:04:17 +00:00
Antonio Andelic
ecaef80ea0
Merge pull request #58938 from ClickHouse/keeper-fetch-max-file-desc-once 
Call `getMaxFileDescriptorCount` once in Keeper
 2024-01-22 08:57:58 +01:00
MochiXu
02b178cc9c fix drop inverted index 2024-01-22 11:10:58 +08:00
jsc0218
6f3124acdb
Merge pull request #58402 from zhangyifan27/add_max_estimated_execution_time 
Seperate max_execution_time and max_estimated_execution_time
 2024-01-21 19:57:06 -05:00
Alexey Milovidov
37f70e07bd
Merge pull request #59022 from ClickHouse/better-visible-width 
Better behavior of `visibleWidth`
 2024-01-22 01:08:12 +01:00
Alexey Milovidov
eb4f61ba31
Update visibleWidth.cpp 2024-01-21 17:50:21 +03:00
alesapin
72f5dce9f4
Update src/Coordination/KeeperDispatcher.cpp 
Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
 2024-01-21 11:16:27 +01:00
Vitaly Baranov
01aafda27b
Merge pull request #58804 from vitlibar/allow-kill-query-for-backups 
Allow KILL QUERY for backups
 2024-01-20 23:48:18 +01:00
Vitaly Baranov
9377f4276b
Merge pull request #58962 from vitlibar/fix-memory-dealloc-in-copy-data-to-s3 
Fix memory management in copyDataToS3File
 2024-01-20 23:35:42 +01:00
Igor Nikonov
4be068c73b
Merge pull request #58993 from ClickHouse/revert-58992-revert_flaky 
Revive: Parallel replicas custom key: skip unavailable replicas
 2024-01-20 19:44:56 +01:00
Nikita Taranov
bbf25b9cb9
Merge pull request #58996 from nickitat/fix_02404_with_analyzer 
Fix 02404_memory_bound_merging with analyzer (follow up #56419)
 2024-01-20 18:39:07 +01:00
serxa
5738a7cb36 Merge branch 'master' into remove-static-resource-manager 2024-01-20 17:33:56 +00:00
Sema Checherinda
1bbb5f7f51
Merge pull request #59015 from ClickHouse/chesema-adaptive-timeouts-gcp 
preserve 'amz-sdk-invocation-id' and 'amz-sdk-request' headers with gcp
 2024-01-20 17:48:20 +01:00
robot-clickhouse
273a06856a
Merge pull request #59025 from ClickHouse/cpu-scheduler 
Split resource scheduler off `IO/` into `Common/Scheduler/`
 2024-01-20 15:43:50 +01:00
Kseniia Sumarokova
f3a1a2f3ad
Fix build 2024-01-20 15:02:13 +01:00
Kseniia Sumarokova
5d67e26fc4
Merge pull request #58869 from ClickHouse/force-check-for-cached-custom-disk 
Fix for custom cached disk creation
 2024-01-20 14:47:36 +01:00
Kseniia Sumarokova
689e617c12
Merge pull request #58963 from ClickHouse/follow-up-disk-configuration 
Follow up to #58357
 2024-01-20 14:41:34 +01:00
serxa
208c92a7dc rename tests accordingly 2024-01-20 12:51:13 +00:00
serxa
172d68ceca Merge branch 'master' into cpu-scheduler 2024-01-20 12:21:21 +00:00
serxa
824deab761 split resource scheduler off IO/ into Common/Scheduler/ 2024-01-20 12:06:26 +00:00
Sergei Trifonov
50a153ef7e
Merge pull request #59011 from ClickHouse/fix-async-loader-assert 
Fix async loader stress test
 2024-01-20 12:11:26 +01:00
Alexey Milovidov
a8022ed624 Better behavior of visibleWidth 2024-01-20 11:22:23 +01:00
Alexey Milovidov
587295aca1
Merge pull request #58981 from azat/prom-handler 
Fix timeout for prometheus exporter for HTTP/1.1 (due to keep-alive)
 2024-01-20 09:42:05 +01:00
Alexey Milovidov
0951cf8d64
Merge pull request #59006 from ClickHouse/disk-web-follow-up 
DiskWeb fix loading
 2024-01-20 06:54:39 +01:00
Alexey Milovidov
8acc981e8c
Merge pull request #59008 from ClickHouse/fix-log-level-for-http 
Update log level for http buffer
 2024-01-20 04:02:42 +01:00
Igor Nikonov
59025b2d3a Merge remote-tracking branch 'origin/master' into revert-58992-revert_flaky 2024-01-19 23:38:24 +00:00
Kruglov Pavel
20379d34d5
Merge branch 'master' into variant-data-type 2024-01-19 23:17:42 +01:00
Kruglov Pavel
e34b8b931d
Merge pull request #58555 from Avogar/settings-changes-check 
Add settings changes check to Upgrade check (debug)
 2024-01-19 23:16:37 +01:00
Sema Checherinda
539451bbe3 preserve 'amz-sdk-invocation-id' and 'amz-sdk-request' headers with gcp 2024-01-19 21:07:47 +01:00
Michael Kolupaev
fd361273f0 Fix StorageURL forgetting headers on server restart 2024-01-19 11:35:12 -08:00
serxa
3ace1cd087 Remove StaticResourceManager 2024-01-19 19:33:56 +00:00
Yarik Briukhovetskyi
e28fd94e1c
fix style 2024-01-19 20:19:34 +01:00
serxa
c8b1aff2a7 remove unnecessary assertion 2024-01-19 19:10:33 +00:00
alesapin
d275d79947
Update KeeperDispatcher.cpp 2024-01-19 19:25:27 +01:00
yariks5s
76b43a6aba small changes(revert) 2024-01-19 18:13:05 +00:00
Nikita Taranov
60a910e94f better 2024-01-19 18:47:21 +01:00
Jiebin Sun
e9662d4d62 polish the code and adjust some code style 2024-01-20 01:43:06 +08:00
Nikita Taranov
f1efb29a66 better 2024-01-19 18:13:03 +01:00
Alexey Milovidov
044df784e0
Update getMaxFileDescriptorCount.cpp 2024-01-19 20:07:38 +03:00
Vitaly Baranov
1a1b0894eb Rename function checkQueryNotCancelled() and add check for thread_group. 2024-01-19 18:05:30 +01:00
kssenii
4c8ced6af8 Fix log level 2024-01-19 18:04:58 +01:00
Alexey Milovidov
6a75641048
Merge pull request #58966 from ClickHouse/arseek 
Fix seek in ReadBufferFromZipArchive
 2024-01-19 18:04:03 +01:00
Alexey Milovidov
b249416671
Merge pull request #58968 from ClickHouse/clickhouse-local-less-threads 
Less threads in `clickhouse-local`
 2024-01-19 18:03:36 +01:00
Alexey Milovidov
3557bb6c73
Merge pull request #58971 from ClickHouse/better-error-message-tuples 
Better error message about tuples
 2024-01-19 18:03:13 +01:00
Antonio Andelic
0132455b39 Reduce Keeper memory usage 2024-01-19 17:00:53 +00:00
kssenii
f9fc4c9fe1 Fix style check 2024-01-19 17:59:44 +01:00
kssenii
226026e2aa Fix 2024-01-19 17:55:03 +01:00
Nikita Taranov
a47d15ab62 impl 2024-01-19 16:59:01 +01:00
Alexey Milovidov
decdb62cef
Merge pull request #58800 from ZhiguoZh/20240115-combine-filter-bmi2 
Optimize DB::combineFilters with BMI2/SSE intrinsics
 2024-01-19 16:50:04 +01:00
Smita Kulkarni
d22fc3a224 Updated to fetch default from settings 2024-01-19 16:13:58 +01:00
Dmitry Novik
728276ab3f Fix crash when indexHint() is used 2024-01-19 14:59:33 +00:00
Smita Kulkarni
c51d1f04f6 Add settings max_unexpected_write_error_retries for Azure Blob Storage 2024-01-19 15:57:20 +01:00
zhongyuankai
cbb51659f6
Merge branch 'master' into limit_materialized_view_size 2024-01-19 22:00:12 +08:00
Dmitry Novik
d8b5623c67 Analyzer: Support GROUP BY injective function elimination 2024-01-19 14:00:12 +00:00
Raúl Marín
47df16f896 Style is not happy with orphan headers 2024-01-19 14:28:18 +01:00
Nikita Taranov
0cafb58c47 impl 2024-01-19 14:17:50 +01:00
Raúl Marín
f6f30eb990 Fix DB::Field operators for Float64 2024-01-19 14:15:49 +01:00
Kseniia Sumarokova
facbd89d48
Merge pull request #58986 from ClickHouse/fix-typo 
Fix typo
 2024-01-19 14:12:50 +01:00
Igor Nikonov
131f71b50a
Revert "Revert flaky" 2024-01-19 13:51:30 +01:00
Raúl Marín
477489a05d Revert "Merge pull request #57235 from ClickHouse/pr-custom-key-failover" 
This reverts commit 8ba9b4a7ef, reversing
changes made to 0f39245cb8.
 2024-01-19 12:46:05 +00:00
Vitaly Baranov
19bc0b744f Add comments and const after review. 2024-01-19 12:54:55 +01:00
Azat Khuzhin
d940afd6cd Fix timeouts for HTTP/1.1 non-chunked requests (missing Connection: close) 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-19 14:48:50 +03:00
kssenii
5113b719e9 Fix typo 2024-01-19 12:48:48 +01:00
kssenii
f055d668af Merge remote-tracking branch 'origin/follow-up-disk-configuration' into follow-up-disk-configuration 2024-01-19 12:31:44 +01:00
kssenii
9dea75b1e7 Fix 2024-01-19 12:30:49 +01:00
avogar
b1c67f143e Add more missing settings 2024-01-19 11:22:24 +00:00
Kseniia Sumarokova
7beb288b27
Update RegisterDiskObjectStorage.cpp 2024-01-19 12:09:58 +01:00
avogar
580501c2b4 Add new settings to settings changes history 2024-01-19 11:08:56 +00:00
avogar
8f2d78bbbf Merge branch 'master' of github.com:ClickHouse/ClickHouse into settings-changes-check 2024-01-19 11:04:50 +00:00
Kseniia Sumarokova
b6094ac233
Merge branch 'master' into filecache-small-optimization 2024-01-19 11:59:04 +01:00
avogar
0c85339ddb Fix style 2024-01-19 10:50:13 +00:00
Azat Khuzhin
38ad4ef493 Fix timeout for prometheus exporter for HTTP/1.1 (due to keep-alive) 
Before:

    $ time curl -s --http1.1 127.1:9363/metrics > /dev/null
    real    0m10.018s # default keep_alive_timeout is 10 seconds
    user    0m0.005s
    sys     0m0.001s

After

    $ time curl -s --http1.1 127.1:9363/metrics > /dev/null
    real    0m0.008s
    user    0m0.006s
    sys     0m0.000s

And if you will look at the test_prometheus_endpoint, you will see that
it takes > 30 seconds (it obtains metrics 3 times), after this patch it
should be finished more or less instantly.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-19 13:29:17 +03:00
avogar
7ae631de1e Remove wron check, remove duplicate tests 2024-01-19 10:23:40 +00:00
kssenii
2f34ef6ff8 Follow up 2024-01-19 11:19:59 +01:00
kssenii
48e489682b Merge remote-tracking branch 'origin/master' into broken-projections-better-handling 2024-01-19 10:49:27 +01:00
vdimir
b8340afddf
Merge pull request #58943 from ClickHouse/vdimir/analyzer_column_not_found 
Analyzer: fix join column not found with compound identifiers
 2024-01-19 10:40:03 +01:00
Kseniia Sumarokova
1c74e7fa08
Merge pull request #58902 from ClickHouse/fs-cache-refactorings 
fs cache: minor refactoring
 2024-01-19 10:25:45 +01:00
Jiebin Sun
0fb7d2290c
Update src/Analyzer/Passes/RewriteSumFunctionWithSumAndCountPass.cpp 
Co-authored-by: Raúl Marín <git@rmr.ninja>
 2024-01-19 17:01:11 +08:00
Alexey Milovidov
e9acae7774
Merge pull request #58950 from ClickHouse/fix-data-race-in-slru-2 
Fix data race in slru (2)
 2024-01-19 09:31:25 +01:00
Alexey Milovidov
8a288055c9
Merge pull request #58949 from MikhailBurdukov/fix_s3_copy 
Using the destination object for  paths generation in S3copy.
 2024-01-19 09:28:13 +01:00
Antonio Andelic
19ca00f233 Call getMaxFileDescriptorCount once 2024-01-19 08:19:20 +00:00
zhangyifan27
7e56a2d925 fix test failure when allow_experimental_analyzer=1 2024-01-19 16:11:30 +08:00
Alexey Milovidov
ff8e1d1595
Merge pull request #58930 from CurtizJ/fix-functions-to-subcolumns-pass 
Fix `FunctionToSubcolumnsPass` in debug build
 2024-01-19 08:40:55 +01:00
Alexey Milovidov
6792f72c6b Better error message about tuples 2024-01-19 06:26:11 +01:00
Alexey Milovidov
0c1e92aea5 Less threads in clickhouse-local 2024-01-19 04:53:14 +01:00
Alexey Milovidov
dcdbaf9150
Merge pull request #58900 from MikhailBurdukov/restriction_for_s3_access_key_id 
Restriction for the access key id for s3.
 2024-01-19 04:13:17 +01:00
Alexey Milovidov
370815803e
Update Client.cpp 2024-01-19 06:12:44 +03:00
Alexey Milovidov
bcff1bac47
Merge pull request #58874 from ClickHouse/disk-minor-improvement 
DiskWeb minor improvement in loading
 2024-01-19 03:52:05 +01:00
Michael Kolupaev
3a19ea6e6c Fix seek in ReadBufferFromZipArchive 2024-01-19 01:46:07 +00:00
avogar
cfc8c60aa7 Fix build 2024-01-18 21:26:55 +00:00
Robert Schulze
1bfeee1954
Some fixups 2024-01-18 20:49:50 +00:00
Kseniia Sumarokova
7f92bf6f0b
Merge pull request #58921 from ClickHouse/add-a-test-for-azure 
Fix and test for azure #58697
 2024-01-18 21:41:54 +01:00
avogar
3dcc2056a5 Fix conflicts 2024-01-18 20:39:36 +00:00
Vitaly Baranov
24ca8fbbec Improve logs. 2024-01-18 21:15:39 +01:00
Vitaly Baranov
0caafe4810 Fix memory deallocation in copyDataToS3File() 
- ReadBufferFromS3 is created now only when it's necessary and destroyed after that.
 2024-01-18 20:48:56 +01:00
Yakov Olkhovskiy
43aaccdaa1 clang tidy 2024-01-18 19:17:05 +00:00
Robert Schulze
15700592f7
Merge remote-tracking branch 'ClickHouse/master' into column_level_compress_block 2024-01-18 19:12:57 +00:00
Nikita Taranov
b5e333df96 remove test 2024-01-18 19:56:02 +01:00
Yakov Olkhovskiy
1144f60515 clenup 2024-01-18 18:17:07 +00:00
Yakov Olkhovskiy
b914938c4c clenup 2024-01-18 18:10:54 +00:00
Yakov Olkhovskiy
bb1058e2b2 fix storage replacement with insertion block for analyzer 2024-01-18 17:59:23 +00:00
Kruglov Pavel
5444cde408
Merge branch 'master' into variant-data-type 2024-01-18 18:31:27 +01:00
avogar
f202d71371 Make alter with variant espansion as no-op, add tests for alters 2024-01-18 17:29:36 +00:00
slvrtrn
0ec385064c Add SIGNED/UNSIGNED aliases for Int64/UInt64 2024-01-18 17:28:47 +01:00
Anton Popov
d2142041cd Merge remote-tracking branch 'upstream/master' into HEAD 2024-01-18 16:03:54 +00:00
Kseniia Sumarokova
bfe8037653
Merge branch 'master' into fix-data-race-in-slru-2 2024-01-18 16:54:52 +01:00
kssenii
d20a33424f Fix race 2024-01-18 16:53:10 +01:00
yariks5s
6ad6d6a121 fix due to review 2024-01-18 15:41:25 +00:00