Commit Graph

82867 Commits

Author SHA1 Message Date
Anton Popov
822b58247a
Merge pull request #34132 from CurtizJ/fix-distributed-inserts
Fix inserts to distributed tables in case of change of native protocol
2022-02-09 14:58:44 +03:00
Maksim Kita
9f29c977de
Merge pull request #34234 from azat/agg-leak
Fix memory leak in AggregatingInOrderTransform
2022-02-09 12:42:04 +01:00
Kruglov Pavel
4ec0f6f091
Merge pull request #33824 from ManagedDatabases/client-fault-tolerant-connection
Client fault tolerant connection
2022-02-09 14:26:11 +03:00
alesapin
f1762de790
Merge pull request #34450 from ClickHouse/fix_style
Fix style
2022-02-09 14:14:23 +03:00
alesapin
b84a171aa7 Fix style 2022-02-09 14:13:53 +03:00
Kruglov Pavel
892e9e80d3
Merge pull request #34415 from Avogar/short-circuit-bug
Fix possible error 'Cannot convert column Function to mask'
2022-02-09 14:04:30 +03:00
mergify[bot]
fd5caa3196
Merge branch 'master' into short-circuit-bug 2022-02-09 11:04:19 +00:00
alesapin
437940b29d
Merge pull request #34422 from ClickHouse/add_settings_to_part_size_in_s3
Add settings for multipart upload part size in s3
2022-02-09 12:51:20 +03:00
Nikolay Degterinsky
05b89ee865
Merge pull request #34443 from fanofxiaofeng/patch-3
remove (nearly) duplicated description
2022-02-09 12:41:54 +03:00
Anton Popov
4d6e048d46
Merge pull request #34435 from fanofxiaofeng/patch-2
the `name` field seems to be missing
2022-02-09 11:56:37 +03:00
靳阳
cad23926aa
remove (nearly) duplicate description
remove (nearly) duplicate description
2022-02-09 16:48:31 +08:00
Kseniia Sumarokova
e4d6125dd5
Merge pull request #34410 from kssenii/fixing-test-storage-postgresql
Fixing test_storage_postgresql
2022-02-09 09:36:54 +01:00
Kseniia Sumarokova
86956ca08b
Merge pull request #34392 from kssenii/http-buffer-skip-not-found-url-for-globs
Allow to skip not found urls for globs
2022-02-09 09:32:09 +01:00
Azat Khuzhin
4fa2ae76bc Fix memory leak in AggregatingInOrderTransform
Reproducer:

    # NOTE: we need clickhouse from 33957 since right now LSan is broken due to getauxval().
    $ url=https://s3.amazonaws.com/clickhouse-builds/33957/e04b862673644d313712607a0078f5d1c48b5377/package_asan/clickhouse
    $ wget $url -o clickhouse-asan
    $ chmod +x clickhouse-asan
    $ ./clickhouse-asan server &

    $ ./clickhouse-asan client
    :) create table data (key Int, value String) engine=MergeTree() order by key
    :) insert into data select number%5, toString(number) from numbers(10e6)

    # usually it is enough one query, benchmark is just for stability of the results
    # note, that if the exception was not happen from AggregatingInOrderTransform then add --continue_on_errors and wait
    $ ./clickhouse-asan benchmark --query 'select key, uniqCombined64(value), groupArray(value) from data group by key' --optimize_aggregation_in_order=1 --memory_tracker_fault_probability=0.01, max_untracked_memory='2Mi'

LSan report:

    ==24595==ERROR: LeakSanitizer: detected memory leaks

    Direct leak of 3932160 byte(s) in 6 object(s) allocated from:
        0 0xcadba93 in realloc ()
        1 0xcc108d9 in Allocator<false, false>::realloc() obj-x86_64-linux-gnu/../src/Common/Allocator.h:134:30
        2 0xde19eae in void DB::PODArrayBase<>::realloc<DB::Arena*&>(unsigned long, DB::Arena*&) obj-x86_64-linux-gnu/../src/Common/PODArray.h:161:25
        3 0xde5f039 in void DB::PODArrayBase<>::reserveForNextSize<DB::Arena*&>(DB::Arena*&) obj-x86_64-linux-gnu/../src/Common/PODArray.h
        4 0xde5f039 in void DB::PODArray<>::push_back<>(DB::GroupArrayNodeString*&, DB::Arena*&) obj-x86_64-linux-gnu/../src/Common/PODArray.h:432:19
        5 0xde5f039 in DB::GroupArrayGeneralImpl<>::add() const obj-x86_64-linux-gnu/../src/AggregateFunctions/AggregateFunctionGroupArray.h:465:31
        6 0xde5f039 in DB::IAggregateFunctionHelper<>::addBatchSinglePlaceFromInterval() const obj-x86_64-linux-gnu/../src/AggregateFunctions/IAggregateFunction.h:481:53
        7 0x299df134 in DB::Aggregator::executeOnIntervalWithoutKeyImpl() obj-x86_64-linux-gnu/../src/Interpreters/Aggregator.cpp:869:31
        8 0x2ca75f7d in DB::AggregatingInOrderTransform::consume() obj-x86_64-linux-gnu/../src/Processors/Transforms/AggregatingInOrderTransform.cpp:124:13

    ...

    SUMMARY: AddressSanitizer: 4523184 byte(s) leaked in 12 allocation(s).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-09 09:23:56 +03:00
靳阳
673b874cc4
the name seems to be missing
the `name` seems to be missing
2022-02-09 10:50:53 +08:00
alexey-milovidov
00330461d1
Update int-uint.md 2022-02-09 03:56:57 +03:00
mergify[bot]
43459ee7b3
Merge branch 'master' into fixing-test-storage-postgresql 2022-02-09 00:54:18 +00:00
Maksim Kita
63bffb0110
Merge pull request #34431 from kitaisreal/clang-tidy-move-fix-build
clang-tidy move fix build
2022-02-09 01:34:18 +01:00
Maksim Kita
b8e350054c clang-tidy move fix build 2022-02-08 21:21:32 +00:00
kssenii
e8a8f46864 Fix style check 2022-02-08 21:58:03 +01:00
tavplubix
15bcbb97e5
Merge pull request #34416 from kssenii/fixing-postgresql-replica-test-1
Fix test test_postgresql_replica_database_engine_2/test.py::test_table_schema_changes_2
2022-02-08 22:38:38 +03:00
DF5HSE
cfefa57485 Merge branch 'master' of github.com:ClickHouse/ClickHouse into client-fault-tolerant-connection 2022-02-08 19:53:55 +03:00
alesapin
ddd541f324 Redundat change 2022-02-08 19:39:51 +03:00
alesapin
f6e7cea1f8 Add settings for S3 multipart upload parts size 2022-02-08 19:38:04 +03:00
kssenii
9f2628b8f2 Fix 2022-02-08 16:41:55 +01:00
avogar
08c009ab50 Fix possible error 'Cannot convert column Function to mask' 2022-02-08 18:23:43 +03:00
Vitaly Baranov
9a8e45805a
Merge pull request #34226 from vitlibar/add-submodule-minizip
Add submodule minizip
2022-02-08 22:07:34 +07:00
Mikhail f. Shiryaev
69fa79a875
Merge pull request #34413 from ClickHouse/docker-tz
Revert "Merge pull request #34373 from ClickHouse/docker-tz"
2022-02-08 15:36:16 +01:00
Mikhail f. Shiryaev
2d02eab750
Revert "Merge pull request #34373 from ClickHouse/docker-tz"
This reverts commit efd8044ab7, reversing
changes made to 4bb69bcb15.
2022-02-08 15:34:01 +01:00
Kruglov Pavel
cae1517693
Fix build 2022-02-08 17:31:02 +03:00
Mikhail f. Shiryaev
efd8044ab7
Merge pull request #34373 from ClickHouse/docker-tz
Use UTC in docker images
2022-02-08 15:21:54 +01:00
Maksim Kita
4bb69bcb15
Merge pull request #34398 from DevTeamBK/input_format
Method called on already moved
2022-02-08 15:20:07 +01:00
Nikolai Kochetov
0f7c0c72bd
Merge pull request #34305 from amosbird/projection-fix27
Fix various issues when projection is enabled by default
2022-02-08 17:19:56 +03:00
Nikolai Kochetov
428d6f1581
Update Settings.h 2022-02-08 17:19:37 +03:00
Anton Popov
496d77c3c3
Merge pull request #33467 from cmsxbc/addressToLineWithInlines
add function addressToLineWithInlines
2022-02-08 17:03:46 +03:00
Kruglov Pavel
720310fcf1
Merge branch 'master' into http-buffer-skip-not-found-url-for-globs 2022-02-08 16:56:22 +03:00
kssenii
71c57bed8e Fix 2022-02-08 14:52:07 +01:00
Kruglov Pavel
3e216adc17
Merge pull request #34405 from Avogar/fix-segfault-in-url
Fix segfault in schema inference from url
2022-02-08 16:48:37 +03:00
Anton Popov
7e9770dcf0 minor enhancements 2022-02-08 15:57:23 +03:00
kssenii
dc5f035265 Fix 2022-02-08 13:28:10 +01:00
alesapin
daf431a0a0 Fix yml tags_stable 2022-02-08 15:10:12 +03:00
alesapin
8e9ccbd077
Merge pull request #33933 from sunny19930321/fix-substr-zk-metadata
Better local metadata comparison with ZooKeeper metadata
2022-02-08 14:58:46 +03:00
alesapin
bb0cadc6c3
Merge pull request #34264 from andycol/patch-1
Update clickhouse-keeper.md
2022-02-08 14:47:12 +03:00
alesapin
31fdd5c6dc
Merge pull request #34364 from vitlibar/fix-inserting-into-temp-tables-via-grpc
Fix inserting to temporary tables via gRPC.
2022-02-08 14:46:48 +03:00
avogar
e118c89bb2 Fix segfault in schema inference from url 2022-02-08 13:40:03 +03:00
kssenii
3834bdbae0 Fixes 2022-02-08 11:11:18 +01:00
DF5HSE
e657219e01 Delete not used include 2022-02-08 12:40:44 +03:00
Kruglov Pavel
b4fec2af7c
Merge pull request #34065 from Avogar/msgpack
Support UUID in MsgPack format
2022-02-08 11:42:17 +03:00
DF5HSE
c08bc7ad65 Merge branch 'master' of github.com:ClickHouse/ClickHouse into client-fault-tolerant-connection 2022-02-08 11:37:31 +03:00
Maksim Kita
3c0572bb86
Merge pull request #34388 from DevTeamBK/Fix-clang-tidy
Fix clang tidy
2022-02-08 09:25:01 +01:00