Commit Graph

141469 Commits

Author SHA1 Message Date
Michael Kolupaev
82e6a36bd4
Merge pull request #61966 from ClickHouse/constlc
Fix crash when calling some functions on const low-cardinality columns
2024-05-11 01:27:47 +00:00
Michael Kolupaev
302e56d916
Merge pull request #62104 from ClickHouse/iff
Fix optimize_if_chain_to_multiif const NULL handling
2024-05-11 01:26:47 +00:00
Alexey Milovidov
095b8ca635
Merge pull request #63635 from mstetsyuk/fix-02362-part-log-merge-algorithm
Fix `02362_part_log_merge_algorithm` flaky test
2024-05-10 23:57:29 +00:00
Alexey Milovidov
8b0599b10e
Merge pull request #63634 from azat/tests/log_and_exception_messages_formatting
Fixes for 00002_log_and_exception_messages_formatting
2024-05-10 23:52:58 +00:00
Alexey Milovidov
925714d03d
Merge pull request #63639 from azat/tests/02362_part_log_merge_algorithm
Fix tests flakiness due to long SYSTEM FLUSH LOGS (explicitly specify old_parts_lifetime)
2024-05-10 23:51:17 +00:00
Michael Kolupaev
0323e4e178 Add 02944_variant_as_common_type_analyzer that is just like 02944_variant_as_common_type, but with different expected output 2024-05-10 22:37:35 +00:00
Michael Kolupaev
02fa09dd4c Preserve the non-analyzer behavior to fix a test 2024-05-10 22:37:35 +00:00
Michael Kolupaev
c1ea1726b4 Remove weird special case in if() return type inference, to match multiIf() 2024-05-10 22:37:35 +00:00
Michael Kolupaev
6d3d0cfbcc Revert the type change 2024-05-10 22:04:09 +00:00
Michael Kolupaev
95bdd81d26 Fix crash when calling some functions on const low-cardinality columns 2024-05-10 22:04:09 +00:00
Azat Khuzhin
83a62c1d7c Adjust old_parts_lifetime in 02362_part_log_merge_algorithm as well
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-05-10 23:00:18 +02:00
Azat Khuzhin
b849890d45 Fix 02362_part_log_merge_algorithm flakiness
SYSTEM FLUSH LOGS can take awhile, which leads to that some parts may be
removed in case of old_parts_lifetime randomized to 10 [1]:

    2024.05.10 21:17:49.920514 [ 14551 ] {c15b0b5e-a1d1-4c87-b983-61ab185d50c1} <Debug> executeQuery: (from [::1]:58902) (comment: 02362_part_log_merge_algorithm.sql) SYSTEM FLUSH LOGS; (stage: Complete)
    2024.05.10 21:17:59.216021 [ 1416 ] {} <Trace> test_9436z6sd.data_horizontal (80dc2a4b-5a0c-4e10-9956-2b0cc1fa0b49): Found 1 old parts to remove. Parts: [all_1_1_0]
    2024.05.10 21:17:59.216192 [ 1416 ] {} <Debug> test_9436z6sd.data_horizontal (80dc2a4b-5a0c-4e10-9956-2b0cc1fa0b49): Removing 1 parts from filesystem (serially): Parts: [all_1_1_0]
    2024.05.10 21:17:59.217760 [ 1416 ] {} <Debug> test_9436z6sd.data_horizontal (80dc2a4b-5a0c-4e10-9956-2b0cc1fa0b49): Removing 1 parts from memory: Parts: [all_1_1_0]
    2024.05.10 21:18:09.403934 [ 14551 ] {8e961419-d1d1-4c0b-b706-8a0b3cdbb1af} <Debug> executeQuery: (from [::1]:58902) (comment: 02362_part_log_merge_algorithm.sql) SELECT table, part_name, event_type, merge_algorithm FROM system.part_log WHERE event_date >= yesterday() AND database = currentDatabase() AND table = 'data_horizontal' ORDER BY event_time_microseconds; (stage: Complete)

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/63634/72f813a42067a94284bdac649751c52c056d53be/stateless_tests__debug__[1_5]/run.log

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-05-10 22:54:01 +02:00
Michael Stetsyuk
20363c6dcc fix 02362_part_log_merge_algorithm flaky test 2024-05-10 19:10:24 +01:00
Azat Khuzhin
72f813a420 Cleanup excludes for 00002_log_and_exception_messages_formatting
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-05-10 20:02:20 +02:00
Azat Khuzhin
ee76eede55 Add file path into "File must not be a directory" message
This is to fix 00002_log_and_exception_messages_formatting

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-05-10 20:02:01 +02:00
Raúl Marín
059f1abcf6
Merge pull request #63631 from ClickHouse/tylerhannan-patch-1
Update README.md
2024-05-10 16:07:35 +00:00
Tyler Hannan
4da5cfda6c
Update README.md
Removing Bangalore Meetup & Adding Boston Meetup
2024-05-10 17:49:38 +02:00
Alexander Gololobov
f89f8b7c2d
Merge pull request #63619 from yohannj/sumMapErrorMsg
harmonize sumMap error messages on ILLEGAL_TYPE_OF_ARGUMENT
2024-05-10 15:17:27 +00:00
Kruglov Pavel
6247f6a2b0
Merge pull request #62423 from Avogar/better-exception-s3-globs-partitions
Fix exception message during writing to partitioned s3/hdfs/azure path with globs
2024-05-10 12:35:04 +00:00
Kruglov Pavel
a406871c80
Fix style 2024-05-10 14:28:55 +02:00
Kseniia Sumarokova
a76058aa20
Merge pull request #63397 from kirillgarbar/mysql
Allow to create MaterializedMySQL database without connection to MySQL
2024-05-10 12:08:59 +00:00
Sergei Trifonov
e8d43fa572
Merge pull request #63404 from ClickHouse/fix-oklch-for-firefox
Workaround for `oklch()` inside canvas bug for firefox
2024-05-10 12:05:35 +00:00
Yohann Jardin
d3ff638d4e harmonize sumMap error messages on ILLEGAL_TYPE_OF_ARGUMENT 2024-05-10 13:04:16 +02:00
Raúl Marín
e5e55ff91c
Merge pull request #63596 from alexvanolst/fix-base58-links
Fix broken links in documentation to IETF Base58 draft
2024-05-10 10:47:12 +00:00
Kseniia Sumarokova
e2756e02c2
Merge pull request #63426 from ClickHouse/fix-backup-with-missing-projection
Fix backup/restore of projection part in case projection was removed from table metadata, but part still has projection
2024-05-10 10:11:56 +00:00
Mikhail f. Shiryaev
98dcef6389
Merge pull request #63400 from ClickHouse/docker-server-official-review
The Dockerfile is reviewed by docker-official
2024-05-10 10:03:01 +00:00
alesapin
83ee9a6e3d
Merge pull request #63353 from ClickHouse/fix_unexpected_return_type_from
Fix logical error during SELECT query after ALTER in rare case
2024-05-10 09:50:33 +00:00
Alexander van Olst
0586952eca
Fix links to IETF Base58 draft 2024-05-10 11:29:18 +02:00
Mikhail f. Shiryaev
544875fd2f
Apply markdownfmt.sh from https://github.com/docker-library/docs 2024-05-10 10:55:24 +02:00
Mikhail f. Shiryaev
291bb14696
The Dockerfile is reviewed by docker-official
`apt-get upgrade` shouldn't be executed during the build
`apt-get clean` is a noop
`gpg` should use batch and download key by full fingreprints
The CI specific steps shouln't be presented in docker library
Using `COPY --chmod` instead of two layers is not possible yet, but
  entrypoint.sh already contains +x bit in the git repo
2024-05-10 10:54:27 +02:00
Antonio Andelic
78af18ac87
Merge pull request #63513 from ClickHouse/threadpool-runner-local-prefetch-read-pool
Make `MergeTreePrefetchedReadPool` safer
2024-05-10 07:38:33 +00:00
Alexey Milovidov
c34ae6d189
Merge pull request #63583 from ClickHouse/ij
Fix logical error in ColumnTuple::tryInsert()
2024-05-10 05:09:34 +00:00
Michael Kolupaev
3de1fc674f Fix logical error in ColumnTuple::tryInsert() 2024-05-10 02:30:18 +00:00
Michael Kolupaev
1b43c58489
Merge pull request #62087 from ClickHouse/checkmate
Avoid crashing on column type mismatch in a few dozen places
2024-05-09 23:59:59 +00:00
Alexey Milovidov
40b5aaa939
Merge pull request #63580 from ClickHouse/docs-data-replication-examples
[Docs] Use ReplicatedMergeTree not ReplicatedReplacingMergeTree for d…
2024-05-09 23:50:20 +00:00
Justin de Guzman
849dd825c5
[Docs] Use ReplicatedMergeTree not ReplicatedReplacingMergeTree for data replication examples 2024-05-09 15:33:40 -07:00
Alexey Milovidov
8ed245677d
Merge pull request #63493 from Volodyachan/fix-tabs-in-pretty-format
Tabs in pretty format
2024-05-09 15:24:56 +00:00
Alexey Milovidov
7be88cca1f
Merge pull request #63548 from azat/fix-sentry-crash-on-exit
Fix crash on exit with sentry enabled (due to openssl destroyed before sentry)
2024-05-09 15:24:20 +00:00
Alexey Milovidov
3ac5853fe8
Merge pull request #63574 from Algunenano/main_lz4
Go back to upstream lz4 submodule
2024-05-09 15:22:02 +00:00
Raúl Marín
2f00ad489a Go back to upstream lz4 2024-05-09 17:06:26 +02:00
Konstantin Bogdanov
6a00c0ec6b
Merge pull request #63551 from ClickHouse/thevar1able-patch-2
Add `jwcrypto` to integration tests runner
2024-05-09 12:40:57 +00:00
Mikhail f. Shiryaev
acae60b55f
Merge pull request #63543 from ClickHouse/find-proper-commit-for-a-sync
Find a proper commit for cumulative `A Sync` status
2024-05-09 12:08:50 +00:00
Mikhail f. Shiryaev
38604eb3bc
Add more logging about the status will be post 2024-05-09 13:40:56 +02:00
Mikhail f. Shiryaev
f294f6d16f
Move update_upstream_sync_status to commit_status_helper 2024-05-09 13:40:53 +02:00
Raúl Marín
83d8c1071a
Merge pull request #63522 from Algunenano/prefetch_projection_name
MergeTreePrefetchedReadPool: Print parent name when logging projection parts
2024-05-09 09:59:36 +00:00
Antonio Andelic
3fd8b46264
Merge pull request #63538 from ClickHouse/race-distributed-sink
Fix data race in `DistributedSink`
2024-05-09 06:53:44 +00:00
Antonio Andelic
d1c20d08c3
Merge pull request #63323 from ClickHouse/use-getparentpartname
Try fix segfault in `MergeTreeReadPoolBase::createTask`
2024-05-09 06:52:12 +00:00
Antonio Andelic
bc9d50cf16
Merge pull request #63523 from ClickHouse/leftover-threads-copy
Correctly stop `asyncCopy` tasks in all cases
2024-05-09 06:50:51 +00:00
Azat Khuzhin
27b41650f8 Fix crash on exit with sentry enabled (due to openssl destroyed before sentry)
The problem is tha openssl registers OPENSSL_cleanup() as atexit
handler, which called before destroying of SentryWriter, so to avoid
this problem, let's destroy it explicitly.

<details>

<summary>stack trace example</summary>

    Thread 2 (Thread 0x7ffff54006c0 (LWP 24847) "clickhouse-serv"):
    0  ___pthread_rwlock_rdlock (rwlock=0x0) at pthread_rwlock_rdlock.c:26
    1  0x00000000164c18a9 in CRYPTO_THREAD_read_lock (lock=0x0) at threads_pthread.c:93
    2  0x000000001642e6b9 in int_err_get_item (d=0x7ffff53f74e0) at err.c:192
    ...
    7  ossl_connect_common (cf=0x7ffff7812c80, data=0x7ffff70a4c00, nonblocking=bool_true, done=0x7ffff53f834c) at openssl.c:4486
    ...
    17 curl_easy_perform (data=data@entry=0x7ffff70a4c00) at easy.c:787
    18 0x000000000b4c3854 in sentry__curl_send_task (_envelope=<optimized out>, _state=0x7ffff7074300) at sentry_transport_curl.c:225
    19 0x000000000b4ba880 in worker_thread (data=0x7ffff70e5500) at sentry_sync.c:262

    Thread 1 (Thread 0x7ffff7cb2c80 (LWP 24842) "clickhouse-serv"):
    5  0x000000000b4bb0e2 in sentry__cond_wait_timeout (cv=0x7ffff70e5540, mutex=0x7ffff70e5570, msecs=250) at sentry_sync.h:332
    6  sentry__bgworker_shutdown (bgw=0x7ffff70e5500, timeout=2000) at sentry_sync.c:412
    7  0x000000000b4b3e95 in sentry_close () at sentry_core.c:238
    8  0x000000000b4a5f1f in SentryWriter::~SentryWriter (this=0x7ffff71a1240) at SentryWriter.cpp:147
    9  std::__1::default_delete<SentryWriter>::operator()[abi:v15000](SentryWriter*) const (this=0x7ffff70e5568, __ptr=0x7ffff71a1240) at unique_ptr.h:48
    10 std::__1::unique_ptr<SentryWriter, std::__1::default_delete<SentryWriter> >::reset[abi:v15000](SentryWriter*) (this=0x7ffff70e5568, __p=0x0) at unique_ptr.h:305
    11 std::__1::unique_ptr<SentryWriter, std::__1::default_delete<SentryWriter> >::~unique_ptr[abi:v15000]() (this=0x7ffff70e5568) at unique_ptr.h:259
    12 0x00007ffff7de62e6 in __run_exit_handlers (status=0, listp=<optimized out>, run_list_atexit=run_list_atexit@entry=true, run_dtors=run_dtors@entry=true) at exit.c:108
    13 0x00007ffff7de642e in __GI_exit (status=<optimized out>) at exit.c:138
    14 0x00007ffff7dccd51 in __libc_start_call_main (main=main@entry=0x6111c20 <main(int, char**)>, argc=argc@entry=13, argv=argv@entry=0x7fffffffb718) at libc_start_call_main.h:74
    15 0x00007ffff7dcce0c in __libc_start_main_impl (main=0x6111c20 <main(int, char**)>, argc=13, argv=0x7fffffffb718, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffb708) at libc-start.c:360

    (gdb) p req.body
    $7 = 0x7ffff7816000 "{\"dsn\":\"...\"}\n{\"type\":\"session\",\"length\":190}\n{\"init\":true,\"sid\":\"...\",\"status\":\"exited\",\"errors\":0,\"started\":\"2024-05-08T20:29:23.253Z\",\"duration\":17.213,\"attrs\":{\"release\":\"24.5\",\"environment\":\"test\"}}"

</details>

P.S. Likely started happens after conversion to OpenSSL (#59870).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-05-09 07:39:23 +02:00
Volodyachan
c52af8c259
Merge branch 'master' into fix-tabs-in-pretty-format 2024-05-09 05:22:51 +03:00