Commit Graph

4320 Commits

Author SHA1 Message Date
Alexander Kuzmenkov
7db8edf402
Merge pull request #11446 from ClickHouse/aku/better-error-messages
Improve error messages
2020-06-05 13:11:02 +03:00
Alexander Kuzmenkov
435f53e05a Improve error messages
Also support fmt for exception messages, the same way we use it in
logging macros.
2020-06-04 20:50:29 +03:00
Alexander Kuzmenkov
377da4656d cleanup 2020-06-04 18:51:34 +03:00
Alexander Kuzmenkov
60920c3077 let's be optimistic, it will build eventually 2020-06-03 16:44:36 +03:00
Alexander Kuzmenkov
1ab3201454 Merge remote-tracking branch 'origin/master' into HEAD 2020-06-03 16:36:22 +03:00
Alexander Kuzmenkov
07e4bb7050 Remove assorted synonyms of LOGICAL_ERROR.
We don't need any special handling for them on the client, and, on the
contrary, have to handle them as logical errors in tests.
2020-06-03 16:18:42 +03:00
Alexander Tokmakov
e3aa20708a Merge branch 'master' into merging_external_source_cassandra 2020-06-03 14:55:02 +03:00
Alexander Kuzmenkov
3bf9cec63b Merge remote-tracking branch 'origin/master' into HEAD 2020-06-03 14:49:49 +03:00
Alexander Kuzmenkov
eca69d1a56 please build already 2020-06-03 14:25:56 +03:00
Alexander Kuzmenkov
9ae46722cb build 2020-06-03 11:48:26 +03:00
Alexander Kuzmenkov
609780c153 build fix 2020-06-02 19:52:50 +03:00
Alexander Kuzmenkov
42debdfbb2 build fixes 2020-06-02 17:09:51 +03:00
Alexander Kuzmenkov
0a5cc96b67 Fuzzing-related changes.
* More LOGICAL_ERROR
* Proper cloning of some Asts
* Field::safeGet for user-supplied values
2020-06-02 16:56:10 +03:00
Alexander Kuzmenkov
d9f00a8f48 fix build 2020-06-02 12:58:48 +03:00
Alexander Kuzmenkov
dc24d69566 Merge remote-tracking branch 'origin/master' into HEAD 2020-06-02 12:56:02 +03:00
Denis Glazachev
c61cbe8e98 Merge branch 'master' into ldap-per-user-authentication
* master: (114 commits)
  Update PushingToViewsBlockOutputStream.cpp
  Update PushingToViewsBlockOutputStream.cpp
  make clang-10 happy
  Fix sync_async test (remove timeout)
  CLICKHOUSEDOCS-631: temporary_files_codec, join_on_disk_max_files_to_merge settings. (#11242)
  Suppress output of cancelled queries in clickhouse-client #9473
  Better log messages in ConfigReloader
  fix select from StorageJoin
  Fix unit tests under MSan
  Added test.
  Fix build.
  Fix arguments for AggregateFunctionQuantile/
  Update style.md
  Add a guide on error messages.
  Report dictionary name on dictionary load errors.
  more types in ASOF JOIN (#11301)
  Fix part_log test
  Update test.
  Add perftest.
  Parallel processing for PushingToViewsBlockOutputStream::writeSuffix
  ...
2020-06-02 12:42:29 +04:00
Ivan Blinkov
4bd678a3fd Merge branch 'master' of github.com:ClickHouse/ClickHouse into sentry 2020-06-02 08:21:30 +03:00
Ivan Blinkov
03f4aa19aa apply comment 2020-06-02 08:16:41 +03:00
Ivan Blinkov
35734aadde apply comment 2020-06-02 08:15:11 +03:00
Alexey Milovidov
d34b1a8791 Merge branch 'master' into improve-performance-of-client-interactive-mode 2020-06-02 04:24:17 +03:00
Alexey Milovidov
3019ca3408 Added comments 2020-06-02 04:20:44 +03:00
Ivan Blinkov
5a32d79135 experiment 2020-06-01 23:55:32 +03:00
Ivan Blinkov
e9a04f7741 more build fixes 2020-06-01 23:48:42 +03:00
alexey-milovidov
7c83679a37
Merge pull request #11341 from ClickHouse/config-reloader-better-log
Better log messages in ConfigReloader
2020-06-01 23:17:02 +03:00
Ivan Blinkov
6bd4282727 Merge branch 'master' of github.com:ClickHouse/ClickHouse into sentry 2020-06-01 21:49:56 +03:00
Ivan Blinkov
f6e69355fa experiment 2020-06-01 21:10:19 +03:00
Alexey Milovidov
5bc5459628 Better log messages in ConfigReloader 2020-06-01 20:58:25 +03:00
Alexander Kuzmenkov
03d8bf9242 Merge remote-tracking branch 'origin/master' into HEAD 2020-06-01 20:15:25 +03:00
Alexander Kuzmenkov
aa1f552a8f build fixes 2020-06-01 20:13:54 +03:00
Alexey Milovidov
7fcfcf201d Fix unit tests under MSan 2020-06-01 20:07:27 +03:00
Alexander Tokmakov
62761eddcc Merge branch 'master' into merging_external_source_cassandra 2020-06-01 14:44:46 +03:00
Ivan Blinkov
fcc7ff0ef9 Merge branch 'master' of github.com:ClickHouse/ClickHouse into sentry 2020-06-01 08:42:03 +03:00
alexey-milovidov
166b267dcf
Merge pull request #11323 from ClickHouse/improve-performance-of-client-interactive-mode-2
Improve performance of client interactive mode
2020-06-01 04:21:23 +03:00
Alexey Milovidov
a76bd99e84 Added setting "output_format_pretty_max_value_width" 2020-06-01 01:12:13 +03:00
alexey-milovidov
9984e989c1
Merge pull request #11317 from ClickHouse/logger-fmt-2
Preparation for structured logging
2020-06-01 00:11:29 +03:00
Alexey Milovidov
eb0e28b26d Added a function "computeBytesBeforeWidth" 2020-05-31 23:03:11 +03:00
Alexey Milovidov
ad14025b5e Further improvement 2020-05-31 22:47:39 +03:00
Alexey Milovidov
463d2cf836 Improve performance of UTF8::computeWidth 2020-05-31 22:22:31 +03:00
alexey-milovidov
195635d1cb
Merge pull request #11316 from ClickHouse/better-not-enough-memory-message
Better exception message in case when there is shortage of memory mappings
2020-05-31 16:59:34 +03:00
Denis Glazachev
e8144976fe Merge branch 'master' into ldap-per-user-authentication 2020-05-31 15:09:16 +04:00
Alexey Milovidov
25f941020b Remove namespace pollution 2020-05-31 00:57:37 +03:00
Alexey Milovidov
5aff138956 Preparation for structured logging 2020-05-31 00:35:52 +03:00
Dmitry
4b0d32f026 Merge branch 'master' of github.com:yandex/ClickHouse into group_by_in_order_optimization 2020-05-31 00:21:02 +03:00
Alexey Milovidov
b95b6ec0ee Tested with "trap" function 2020-05-30 23:02:44 +03:00
Alexey Milovidov
9a41eb14a6 Fix build 2020-05-30 22:40:23 +03:00
Alexey Milovidov
09d2f19287 Better exception in case when there is shortage of memory mappings 2020-05-30 22:38:25 +03:00
Alexey Milovidov
43c2a46672 Fix very rare race condition in ThreadPool 2020-05-30 21:57:02 +03:00
MovElb
b4b5c90343 squash 2020-05-30 20:05:05 +03:00
Ivan Blinkov
77d8c9baca Add anonymize option and version tag 2020-05-30 11:02:13 +03:00
Ivan Blinkov
6dfe44f437 style 2020-05-30 11:01:15 +03:00
Ivan Blinkov
95ca1c648d fix __msan_unpoison 2020-05-30 10:59:43 +03:00
Ivan Blinkov
f88b85625a style 2020-05-30 00:36:47 +03:00
Ivan Blinkov
a84123195b adjust comments 2020-05-29 23:08:05 +03:00
Ivan Blinkov
95ee742ee7 merge master 2020-05-29 22:56:10 +03:00
Alexander Tokmakov
8921041706 Merge branch 'master' into merging_external_source_cassandra 2020-05-29 18:20:39 +03:00
alexey-milovidov
9a4fd5cf56
Merge pull request #11272 from ClickHouse/fix-usage-of-fmtlib
Fix potential incorrect usage of fmtlib
2020-05-29 16:22:52 +03:00
Alexander Kuzmenkov
6e3bbf83e3 thread-local perf events 2020-05-29 16:04:32 +03:00
Nikolai Kochetov
cf08299e43
Merge pull request #11249 from ClickHouse/fix-memory-tracked-description-race
Fix race for description in MemoryTracker.
2020-05-29 13:42:07 +03:00
Denis Glazachev
cd5d3ed618 Merge branch 'master' into ldap-per-user-authentication
* master:
  Remove error code
  Better
  Remove redundant header
  Fix unit tests
  Better error codes
2020-05-29 14:07:42 +04:00
Alexander Kazakov
3f53b5b335
Fixed improper logging of failures in destructors of certain metrics (#11264) 2020-05-29 12:45:55 +03:00
alesapin
9a34310ead
Merge pull request #11262 from ClickHouse/fix_unit_broken_tests
Fix unit broken tests
2020-05-29 11:18:46 +03:00
Denis Glazachev
f9d4136792 Merge branch 'master' into ldap-per-user-authentication 2020-05-29 10:52:44 +04:00
Dmitrii Kovalkov
f59b13a58d Fix style issues 2020-05-29 07:34:10 +02:00
Alexey Milovidov
e8f52337aa Fix incorrect usage of fmtlib 2020-05-29 03:09:12 +03:00
alesapin
db72f39594 Remove error code 2020-05-28 22:07:20 +03:00
alesapin
e9c1e1a7e4 Remove redundant header 2020-05-28 21:54:42 +03:00
alesapin
93801a1a9d Fix unit tests 2020-05-28 21:52:08 +03:00
alesapin
a95469020a Better error codes 2020-05-28 21:02:41 +03:00
Maxim Akhmedov
f5b1ab8e4a Use proper versions in Arcadia build. 2020-05-28 16:46:56 +03:00
Nikolai Kochetov
b71d520a3f Fix race for description in MemoryTracker. 2020-05-28 15:30:42 +03:00
alexey-milovidov
545c9e5bac
Merge pull request #11236 from abyss7/CLICKHOUSE-4856
Build universal ClickHouse binary with ya.make
2020-05-28 15:28:49 +03:00
Alexander Kuzmenkov
40b704fb61 remove some C 2020-05-28 15:03:22 +03:00
Alexander Kuzmenkov
3c18344b06 account for counter multiplexing 2020-05-28 13:48:34 +03:00
Ivan Lezhankin
2432ea2c4b Build universal binary using ya make 2020-05-28 00:58:46 +03:00
Denis Glazachev
2863de750e Merge branch 'master' into ldap-per-user-authentication 2020-05-28 01:30:52 +04:00
Denis Glazachev
d74f1357d4 Add LDAP authentication support 2020-05-28 01:06:33 +04:00
Ivan Blinkov
31123236cb Settings for crash report opt-in 2020-05-27 23:15:33 +03:00
Ivan Blinkov
709b4f42c8 Prototype sending crash reports on segfaults 2020-05-27 22:11:04 +03:00
Alexander Kuzmenkov
4e566c3570 support new logging functions 2020-05-27 17:16:34 +03:00
Alexander Kuzmenkov
db84f0e892 Merge remote-tracking branch 'origin/master' into HEAD 2020-05-27 16:30:13 +03:00
Alexey Milovidov
146370934a Keep the value of DistributedFilesToInsert metric on exceptions 2020-05-27 13:07:38 +03:00
Alexander Tokmakov
940132adc4 Merge branch 'master' into merging_external_source_cassandra 2020-05-27 00:13:57 +03:00
Dmitry
38c585f867 Merge branch 'master' of github.com:yandex/ClickHouse into group_by_in_order_optimization 2020-05-26 21:27:50 +03:00
Alexander Kuzmenkov
83aaea7b0f Merge remote-tracking branch 'origin/master' into HEAD 2020-05-26 18:29:42 +03:00
Vasily Nemkov
28a2cc0a82 Functions {to,from}UnixTimestamp64{Milli,Micro,Nano}
* Family of functions to convert DateTime64 to Int64 and back, usefull for
   imporintg/exporting raw timestamp values of certain precision.
 * Docs
 * Tests
 * Fixed ya.make
2020-05-26 16:42:22 +03:00
Vitaly Baranov
e27ded8798
Merge pull request #11172 from vitlibar/grpc-improve-build-scripts
Improve build scripts for protobuf & gRPC
2020-05-26 13:27:54 +03:00
Alexander Kuzmenkov
9d25ae22b5 Merge remote-tracking branch 'origin/master' into HEAD 2020-05-26 09:07:01 +03:00
Alexander Kuzmenkov
bf941755f2 fixup 2020-05-26 09:00:51 +03:00
Alexander Kuzmenkov
7142e68d7a fixup 2020-05-26 08:54:04 +03:00
Alexey Milovidov
55a02c391d Style 2020-05-26 01:06:02 +03:00
Vitaly Baranov
58a2172154 Improve build scripts related to protobuf and gRPC. 2020-05-25 18:46:57 +03:00
Alexander Kuzmenkov
8d5bbed2de Merge remote-tracking branch 'origin/master' into HEAD 2020-05-25 06:44:11 +03:00
alexey-milovidov
bee5849c6a
Merge pull request #11137 from ClickHouse/logger-fmt
fmt-style logging, part 1
2020-05-25 01:38:14 +03:00
Alexey Milovidov
01be2dadb3 Various comments 2020-05-24 21:05:06 +03:00
Alexey Milovidov
d0c0a0aed6 Unrolled histogram calculation 8 times 2020-05-24 18:51:23 +03:00
Alexey Milovidov
e99ed19586 Unrolled histogram calculation 2020-05-24 18:48:11 +03:00
Alexey Milovidov
04022f71b4 Added comment 2020-05-24 18:35:48 +03:00
Alexey Milovidov
4748de9c85 Fix partial radix sort: it was not working at all 2020-05-24 18:26:07 +03:00
Alexey Milovidov
5e7ea6500c Fix error 2020-05-24 17:48:53 +03:00
Alexey Milovidov
32158d9aee Trying to understand and fix the code of RadixSortMSD 2020-05-24 17:42:20 +03:00
Alexey Milovidov
a8e8bc4298 Added a comment 2020-05-24 13:49:43 +03:00
alexey-milovidov
aa8f385085
Merge pull request #11159 from ClickHouse/fix-radix-sort
Fix radix sort after #10981
2020-05-24 02:31:45 +03:00
Alexey Milovidov
7e1813825b Return old names of macros 2020-05-24 01:24:01 +03:00
Alexey Milovidov
61cc605ee7 Remove old method 2020-05-24 01:21:29 +03:00
Alexey Milovidov
f75587e562 Progress on task 2020-05-23 23:13:34 +03:00
Alexey Milovidov
7e2fb9ad65 Apply all transformations again 2020-05-23 22:38:30 +03:00
Alexey Milovidov
eacff92d0e Progress on task 2020-05-23 22:35:08 +03:00
Alexey Milovidov
29762240de Remove duplicate whitespaces (preparation) 2020-05-23 22:31:54 +03:00
Alexey Milovidov
7fed65cbe2 Remove duplicate whitespaces (preparation) 2020-05-23 22:14:58 +03:00
Alexey Milovidov
ab0562a574 Make all LOG in single line (preparation) 2020-05-23 22:05:41 +03:00
Alexey Milovidov
9d2a0d2dd7 Apply all transformations again 2020-05-23 21:59:49 +03:00
Alexey Milovidov
a2ad11897f Remove duplicate whitespaces (preparation) 2020-05-23 21:53:58 +03:00
Alexey Milovidov
1f13515a65 Make all LOG in single line (preparation) 2020-05-23 21:31:37 +03:00
Alexey Milovidov
241f8c5431 find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+" \+ [^+]+ \+ "[^"]+"\);' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+), "([^"]+)" \+ ([^+]+) \+ "([^"]+)"\);/\1_FORMATTED(\2, "\3{}\5", \4);/' 2020-05-23 20:10:21 +03:00
Alexey Milovidov
f69cbdcbfc find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+" \+ [^+]+\);' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+), "([^"]+)" \+ ([^+]+)\);/\1_FORMATTED(\2, "\3{}", \4);/' 2020-05-23 20:09:37 +03:00
Alexey Milovidov
533f86278a find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+" << [^<]+ << "[^"]+" << [^<]+ << "[^"]+"\);' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+), "([^"]+)" << ([^<]+) << "([^"]+)" << ([^<]+) << "([^"]+)"\);/\1_FORMATTED(\2, "\3{}\5{}\7", \4, \6);/' 2020-05-23 20:00:41 +03:00
Alexey Milovidov
8042e5febe find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+" << [^<]+ << "[^"]+" << [^<]+\);' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+), "([^"]+)" << ([^<]+) << "([^"]+)" << ([^<]+)\);/\1_FORMATTED(\2, "\3{}\5{}", \4, \6);/' 2020-05-23 19:58:15 +03:00
Alexey Milovidov
e391b77d81 find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+" << [^<]+ << "[^"]+"\);' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+), "([^"]+)" << ([^<]+) << "([^"]+)"\);/\1_FORMATTED(\2, "\3{}\5", \4);/' 2020-05-23 19:56:05 +03:00
Alexey Milovidov
ee4ffbc332 find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+" << [^<]+\);' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+), "([^"]+)" << ([^<]+)\);/\1_FORMATTED(\2, "\3{}", \4);/' 2020-05-23 19:47:56 +03:00
Alexey Milovidov
8d2e80a5e2 find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+"\)' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+, "[^"]+")\)/\1_FORMATTED(\2)/' 2020-05-23 19:42:39 +03:00
tavplubix
6ece9649f1
Merge pull request #11151 from naorlov/CLICKHOUSE-7224
Add `FailedQuery`, `FailedSelectQuery` and `FailedInsertQuery`
2020-05-23 18:47:44 +03:00
Alexey Milovidov
9c15e3ad92 Make it right 2020-05-23 18:29:43 +03:00
Alexey Milovidov
82f03fa8ce Fix loop unrolling 2020-05-23 18:22:04 +03:00
Alexey Milovidov
73a3394b3d Clarifications #10981 2020-05-23 17:28:22 +03:00
alexey-milovidov
34eb533842
Merge pull request #10981 from g-arslan/master
Try to remove redundant data move in radix sort
2020-05-23 15:55:35 +03:00
Alexey Milovidov
3e87b5fe72 Remove old TODO 2020-05-23 14:50:21 +03:00
Nikita Orlov
dffd15f643
issue-7224 Add failed Insert and Select query counters to ProfileEvents 2020-05-23 01:00:15 +03:00
Alexander Tokmakov
ac54d470da Merge branch 'master' into merging_external_source_cassandra 2020-05-22 17:27:40 +03:00
Andrey Skobtsov
806d2c9838 1 or 4 spaces in example values 2020-05-22 15:30:02 +03:00
Andrey Skobtsov
93d8e8c404 Removed perf page faults as they already exist in rusage 2020-05-22 14:09:14 +03:00
Dmitry
47778c0259 Merge branch 'master' of github.com:yandex/ClickHouse into group_by_in_order_optimization 2020-05-21 23:45:12 +03:00
Andrey Skobtsov
e3b756e65f Added cpu-clock to the list of supported events as it is included in perf and can be disabled if needed 2020-05-21 23:40:47 +03:00
Andrey Skobtsov
790d7c2000 Reverted ctime > sys/time.h include just to not show it in the pull request 2020-05-21 23:29:20 +03:00
Andrey Skobtsov
5217fd7952 Renamed counters_id to latest_counters_id to be more specific about what this variable holds 2020-05-21 23:27:33 +03:00
Andrey Skobtsov
713173a3a5 More precise number of total events 2020-05-21 23:21:42 +03:00
Andrey Skobtsov
72e5545c51 Logging warnings instead of infos and always as the user can select
what metrics he wants to measure and perf measurements will be disabled by default
2020-05-21 23:20:55 +03:00
Andrey Skobtsov
bf5c7c4411 Logging perf event settings name when event is not supported 2020-05-21 23:11:19 +03:00
Andrey Skobtsov
d00609cb70 Validating file descriptors for external modification 2020-05-21 17:14:01 +03:00
alexey-milovidov
765510d5c3
Merge pull request #10991 from ClickHouse/enable-clang-tidy-for-programs-and-utils
Enable clang-tidy for programs and utils
2020-05-21 15:12:07 +03:00
g-arslan
3267eaa498 fix style 2020-05-21 15:00:55 +03:00
g-arslan
b88d0dec1c some little improvements 2020-05-21 15:00:55 +03:00
g-arslan
c01a7ef0e2 Implement reverse in radix sort, fix style, fix build 2020-05-21 15:00:55 +03:00
g-arslan
95668def24 Try to remove redundant data move in radix sort 2020-05-21 15:00:55 +03:00
Andrey Skobtsov
8363ccb9b7 Fixed naming for lambda 2020-05-21 00:03:08 +03:00
Alexander Tokmakov
31b6f5f0d2 Merge branch 'master' into merging_external_source_cassandra 2020-05-20 23:44:53 +03:00
Alexander Kuzmenkov
50df893dc6 Assert that allocator & container are consistent wrt. inline memory
There are lots of places where HashTable is used with
AllocatorWithStackMemory, but the size of allocator inline memory is set
incorrectly, and it's less than the initial HashTable buffer size.
Because of this, HashTable is always allocated on the heap, and the
inline memory becomes a useless dead weight.

For PODArray, we have previously added a helper template that makes sure
these values are in sync, so there was only one such discrepancy left,
in the unit test.
2020-05-20 22:37:13 +03:00
Andrey Skobtsov
a329a6a86a Fixed compilation on non linux devices 2020-05-20 21:54:07 +03:00
Andrey Skobtsov
4151cf7ac8 Removed useless comment 2020-05-20 21:37:16 +03:00
Andrey Skobtsov
97043e588f Space 2020-05-20 21:30:09 +03:00
Andrey Skobtsov
4816abed28 Settings for measuring only particular metrics via perf events 2020-05-20 21:25:49 +03:00
Andrey Skobtsov
844aac40e5 typedef > using 2020-05-19 21:25:40 +03:00
Andrey Skobtsov
b6d6427748 Added file descriptors threshold 2020-05-19 21:22:30 +03:00
Andrey Skobtsov
483c78ba8f Fixed warnings 2020-05-19 17:01:51 +03:00
alesapin
a416813597
Merge pull request #10777 from NanoBjorn/refactor-reservations
VolumePtr instead of DiskPtr in MergeTreeData*
2020-05-19 13:27:11 +03:00
Alexander Tokmakov
175b7aedf3 Merge branch 'master' into merging_external_source_cassandra 2020-05-19 05:21:27 +03:00
Andrey Skobtsov
ef788758bf Revert "Fixed current counter id check"
This reverts commit f98c53e8
2020-05-19 01:30:40 +03:00
Andrey Skobtsov
f98c53e8d8 Fixed current counter id check 2020-05-19 01:29:46 +03:00
Andrey Skobtsov
04a902ba68 Reverted switch case indentation (v2) 2020-05-19 01:27:19 +03:00
Andrey Skobtsov
b8d447297b Reverted switch case indentation 2020-05-19 01:26:35 +03:00
Andrey Skobtsov
4103700aa6 Changed comments 2020-05-19 01:17:19 +03:00
Andrey Skobtsov
b0a3dc2b88 Moved static on top of thread_local 2020-05-19 01:15:04 +03:00
Andrey Skobtsov
e46cabe1d8 UInt64 numbers to track active counters instead of memory addresses 2020-05-19 01:13:55 +03:00
Andrey Skobtsov
979b357c05 Removed unused method 2020-05-19 00:46:46 +03:00
Artem Zuikov
97c7447130
Bitonic sort improvements (#10934) 2020-05-19 00:41:23 +03:00
Andrey Skobtsov
901f546aee Fixed 0 value of paranoid handling 2020-05-19 00:40:15 +03:00
Andrey Skobtsov
1edd29b3f8 Removed custom events as they don't work in an "increment" manner 2020-05-18 15:23:47 +03:00
Andrey Skobtsov
e7bea6e03a Renamed events 2020-05-18 14:44:40 +03:00
Andrey Skobtsov
182e4f2c0b Added running and enabled time for perf metrics 2020-05-18 13:40:01 +03:00
Artem Zuikov
0fe723acc9
Try to fix arcadia sync (#10959) 2020-05-18 13:26:23 +03:00
alesapin
07cb21ccb7
Merge branch 'master' into refactor-reservations 2020-05-18 11:43:48 +03:00
alexey-milovidov
a316184bef
Merge pull request #10990 from ClickHouse/odbc-bridge-wait-exp-backoff
Wait for odbc-bridge with exponential backoff
2020-05-18 10:17:59 +03:00
Nikolai Kochetov
cdb742dd4b Added comment. 2020-05-18 09:06:48 +03:00
Nikolai Kochetov
fcde0d36bd
Merge pull request #10978 from ClickHouse/static-mutate
Try fix performance after static mutate.
2020-05-18 09:02:24 +03:00
alexey-milovidov
7efd2a825f
Merge pull request #10463 from ClickHouse/parallel-final
Parallel final
2020-05-18 05:20:18 +03:00
Alexey Milovidov
b0a5ce7743 Enable clang-tidy for programs and utils 2020-05-18 04:19:50 +03:00
Alexey Milovidov
7b5dfd9c00 Wait for odbc-bridge with exponential backoff 2020-05-18 04:06:04 +03:00
Nikolai Kochetov
aab2599fad Fix build. 2020-05-17 23:26:53 +03:00
alexey-milovidov
6f1d522b6a
Merge pull request #10980 from azat/database-atomic-fixes
Database atomic fixes
2020-05-17 23:25:56 +03:00
alexey-milovidov
8d3c37992a
Merge pull request #10533 from ClickHouse/alter-key-column-better-exception-message
Better exception message and error code for ALTER of key column #9078
2020-05-17 22:21:14 +03:00
Nikolai Kochetov
c8e7ea0d6c Try fix performance. 2020-05-17 21:55:49 +03:00
Azat Khuzhin
31035a3cd1 Allow relative path for renameat2 by using AT_FDCWD
Otherwise this will trigger logical error on CREATE TABLE with default
config.d overrides (path=./).
2020-05-17 17:02:03 +03:00
Andrey Skobtsov
40ad18be8e Fixed compilation namespace issue and formatting 2020-05-17 16:56:17 +03:00
alexey-milovidov
a3346e9331
Merge pull request #10912 from ClickHouse/static-mutate
Static mutate
2020-05-17 09:05:35 +03:00
Alexey Milovidov
9fcfe5fb14 Better exception message and error code for ALTER of key column #9078 2020-05-17 07:46:25 +03:00
Andrey Skobtsov
cae41826a8 Merge branch 'master' into perf_events_metrics
# Conflicts:
#	src/Common/ThreadProfileEvents.cpp
#	src/Common/ThreadProfileEvents.h
#	src/Common/ThreadStatus.cpp
#	src/Common/ThreadStatus.h
2020-05-17 00:21:22 +03:00
Gleb Novikov
1a25ac6e1f Merge branch 'master' into refactor-reservations 2020-05-16 23:34:45 +03:00
Azat Khuzhin
c059ee0085 Use is_trivial+is_standard_layout over is_pod (later is deprecated) 2020-05-16 00:00:38 +03:00
Vitaly Baranov
d92ac9ea47
Merge branch 'master' into RBAC-10 2020-05-15 14:12:43 +03:00
Nikolai Kochetov
70ce0149b1 Try fix build. 2020-05-15 13:10:13 +03:00
alexey-milovidov
985b83a228
Merge pull request #10903 from ClickHouse/lexer-unicode-whitespaces
Support for unicode whitespaces in queries.
2020-05-15 10:31:59 +03:00
Artem Zuikov
8e8a2a17d6 build fixes 2020-05-15 03:01:31 +03:00
Ri
fc7afaa639
Bitonic sort on GPU (OpenCL) (#10232) 2020-05-15 03:01:14 +03:00
Alexey Milovidov
81a5d02628 Fix annoying "Arcadia" build 2020-05-14 20:05:55 +03:00
Nikolai Kochetov
4d22374f24 Merged with master. 2020-05-14 12:06:15 +03:00
Nikolai Kochetov
d68c385d35 Remove old code. 2020-05-14 11:59:15 +03:00
Nikolai Kochetov
4d0503f021 Make IColumn::mutate() static. 2020-05-14 11:30:18 +03:00
Alexey Milovidov
770cc9e863 Fix "Arcadia" build that is using obsolete version of C++ standard 2020-05-14 02:12:16 +03:00
Alexey Milovidov
c3cea85b10 Support for unicode whitespaces in Lexer 2020-05-14 00:31:57 +03:00
alexey-milovidov
623b2e5a43
Merge pull request #10849 from ClickHouse/fix_optimize_and_alter_hangs
Fix mutations and OPTIMIZE hangs when replica becomes inactive
2020-05-13 23:41:13 +03:00
alexey-milovidov
63c6eb1a37
Update ZooKeeper.h 2020-05-13 23:40:54 +03:00
Vitaly Baranov
dd8b29b4fb Use enum Type instead of std::type_index to represent the type of IAccessEntity.
This change simplifies handling of access entities in access storages.
2020-05-13 19:40:48 +03:00
tavplubix
39518fe725
trigger CI 2020-05-13 16:45:39 +03:00
Alexander Tokmakov
032197b015 fix alter and optimize hangs when replica becomes inactive 2020-05-13 10:06:57 +03:00
Azat Khuzhin
e102ad373a Fix SIGSEGV in StringHashTable if such key is not exists 2020-05-13 03:40:05 +03:00
Dmitry
c4295d97f9 Merge branch 'master' of github.com:yandex/ClickHouse into group_by_in_order_optimization 2020-05-12 17:57:32 +03:00
alexey-milovidov
40ef113503
Merge branch 'master' into parallel-final 2020-05-11 06:47:44 +03:00
Gleb Novikov
57b6fb6d80 Merge branch 'master' into refactor-reservations 2020-05-10 13:01:45 +03:00
Gleb Novikov
a961e049a2 VolumeType as class with enum member class 2020-05-10 09:26:33 +03:00
Alexey Milovidov
dda2151f71 Fix build 2020-05-10 02:35:20 +03:00
Alexey Milovidov
fb32dbe6ee Enable more warnings 2020-05-10 00:44:33 +03:00
Gleb Novikov
390b39b272 VolumePtr instead of DiskPtr in MergeTreeData* 2020-05-10 00:24:15 +03:00
Azat Khuzhin
150dd81e3b Fix build with unbundled Poco 2020-05-09 01:22:12 +03:00
Ivan
85d783c247
Poco contrib refactoring (#10396)
* Remove config_common.h
* Refactor libcpuid contrib
* Remove support for libcpuinfo
* Define USE_CPUID in Arcadia
* Refactor Poco libraries
2020-05-08 17:11:19 +03:00
Alexey Milovidov
dea8d366c9 Loose some limitation 2020-05-07 04:29:31 +03:00
alexey-milovidov
443c64abc0
Merge pull request #10638 from ClickHouse/fix-ubsan-hashtable
Fix UBSan report in HashTable
2020-05-04 04:50:25 +03:00
Alexey Milovidov
bb6eabd82d Fix HTTP response code for some parse errors #10636 2020-05-03 22:47:07 +03:00
Alexey Milovidov
8f7374c6de Fix another UBSan warning 2020-05-03 21:39:52 +03:00
Alexey Milovidov
9a344e681f Fix UBSan report in FixedHashTable 2020-05-03 21:24:11 +03:00
Alexey Milovidov
626b9a3ae9 Fix UBSan report in HashTable 2020-05-03 21:21:18 +03:00
Alexey Milovidov
600b396f1b Merge remote-tracking branch 'origin/master' into sampling-memory-profiler 2020-05-01 21:48:20 +03:00
Alexander Kazakov
e9baaa439b
Implementation of new system metrics provider (Procfs) (#10544)
* New metrics provider (Procfs) + Refactored TasksStatsCounters

* Trivial statless test that ProcFS is provided

* Trivial perf test for ProcfsMetricsProvider

Co-authored-by: alexey-milovidov <milovidov@yandex-team.ru>
2020-05-01 21:47:41 +03:00
Alexey Milovidov
c4b64edc14 Merge branch 'master' into sampling-memory-profiler 2020-05-01 16:47:10 +03:00
Alexander Kuzmenkov
2ac26bd3a5 Disable mremap under MemorySanitizer. 2020-05-01 10:38:05 +03:00
Alexey Milovidov
293ae88e7f Add sampling memory profiler 2020-04-30 16:25:17 +03:00
Nikolai Kochetov
19dadb8c2d Add parallel final. 2020-04-30 12:59:08 +03:00
Alexey Milovidov
a7d7dc5034 Fix some bad code 2020-04-26 20:34:36 +03:00
alexey-milovidov
378d73d477
Merge pull request #10449 from azat/metrics-for-new-bg-schedule-pools
Add tasks/memory metrics for distributed/buffer schedule pools
2020-04-26 20:16:02 +03:00
Dmitry
d9ac0e8fef Merge branch 'master' of github.com:yandex/ClickHouse into group_by_in_order_optimization 2020-04-26 14:44:06 +03:00
tavplubix
7928f2eaa1
Merge pull request #7512 from ClickHouse/database_atomic
DatabaseAtomic
2020-04-24 22:28:18 +03:00
Alexander Tokmakov
04d4130b0d update yamake 2020-04-24 20:14:10 +03:00
alexey-milovidov
79d531af87
Merge pull request #10466 from ClickHouse/aku/arena-infinite-loop
Work around a bug leading to an infinite loop in addressToLine
2020-04-24 10:38:07 +03:00
Alexander Kuzmenkov
2bedc82c18 Work around a bug leading to an infinite loop in addressToLine.
Fixing this is hopeless and would entail rewriting the entire
WriteBuffer thing, and also this hack is something we can backport.
2020-04-24 02:42:04 +03:00
Andrey Skobtsov
b6a5b1b12f Fix styling 2020-04-23 22:38:15 +03:00
Andrey Skobtsov
0cf949f1b5 A bit of reformatting code 2020-04-23 21:50:12 +03:00
Andrey Skobtsov
30a87a8a58 perf events' values are 64 bit unsigned; so, read them instead of the signed ones 2020-04-23 21:50:12 +03:00
Andrey Skobtsov
30e19c3abb Using the same file descriptors for all counters on the current thread (only one instance of PerfEventsCounters can be active at a given time for a thread) 2020-04-23 21:50:12 +03:00
Alexander Tokmakov
15e7ce0053 fixes 2020-04-23 21:00:43 +03:00
Alexander Tokmakov
04d6b59ac0 Merge branch 'master' into database_atomic 2020-04-23 17:31:37 +03:00
Alexander Kuzmenkov
9ed9475e46
boop the CI 2020-04-23 03:55:03 +03:00
Azat Khuzhin
d854049d21 Add tasks/memory metrics for distributed/buffer schedule pools
Follow-up-for: #10315
Follow-up-for: #10263
2020-04-23 02:18:37 +03:00
alexey-milovidov
fd27ce619b
Merge pull request #10444 from ClickHouse/server-memory-profiler
Simple server wide memory profiler
2020-04-23 00:34:23 +03:00
Alexey Milovidov
73dd78bac1 Merge branch 'master' into clang-tidy-8 2020-04-22 21:04:47 +03:00
Alexey Milovidov
07dcf40a6a Simple server wide memory profiler 2020-04-22 20:52:21 +03:00
Alexey Milovidov
d189375051 Fix Mac OS build 2020-04-22 17:56:31 +03:00
Alexander Tokmakov
fefbbd37df Merge branch 'master' into database_atomic 2020-04-22 17:02:30 +03:00
Alexey Milovidov
03e17405cd Checkpoint 2020-04-22 10:03:43 +03:00
alexey-milovidov
7065a8ba9c
Merge pull request #10422 from azat/fallback_to_stale_replicas-over-skip_unavailable_shards
Prefer fallback_to_stale_replicas over skip_unavailable_shards
2020-04-22 09:20:25 +03:00
Alexey Milovidov
be22a4b94e Checkpoint 2020-04-22 08:39:31 +03:00
Alexey Milovidov
c805ed4dea Fixes for clang-tidy on clang-10 2020-04-22 03:29:38 +03:00
Azat Khuzhin
0cc9dbd35b Prefer fallback_to_stale_replicas over skip_unavailable_shards
Patch from: @alex-zaitsev
2020-04-22 01:42:23 +03:00
Ivan
555488a458
Fix build in Arcadia (#10413) 2020-04-21 23:23:44 +03:00
alexey-milovidov
2645dede2c
Merge pull request #10386 from palasonic1/palasonic-fix-read-hash-table
Fix reading HashTable from buffer
2020-04-21 02:26:47 +03:00
tavplubix
1a067484c8
Merge pull request #10137 from kekekekule/direct_queries
Add custom settings support for certain dictionary sources
2020-04-21 01:21:32 +03:00
alexey-milovidov
8c2839d3c9
Merge pull request #10308 from ClickHouse/shared-context-lifetime
Shared context lifetime
2020-04-21 00:12:45 +03:00
Maxim Serebryakov
a99a340b0b fix reading HashTable and HashSet 2020-04-20 23:19:03 +03:00
alexey-milovidov
faeab5f649
Merge pull request #10370 from amosbird/clang-10
clang-10 fix
2020-04-20 22:47:12 +03:00
Ivan
d5b0a7e691
Fix Arcadia build (#10380) 2020-04-20 15:21:25 +03:00
Alexander Tokmakov
b29bddac12 Merge branch 'master' into database_atomic 2020-04-20 14:09:09 +03:00
Nikolai Kochetov
052598534a Try fix unit tests. 2020-04-20 12:42:56 +03:00
Amos Bird
2d08c8e4ab
clang-10 fix 2020-04-20 15:45:37 +08:00
Alexey Milovidov
acde587c75 Merge branch 'master' into fixed-string-compare-as-zero-padded 2020-04-20 06:49:21 +03:00
Alexey Milovidov
c893edf46f Fix style 2020-04-20 06:48:35 +03:00
Alexey Milovidov
d783162548 Compare with fixed string as smaller string is zero padded #9272 2020-04-20 04:01:31 +03:00
Alexey Milovidov
ec6b176f3b Rework total memory tracker #10293 2020-04-20 01:59:21 +03:00
Alexey Milovidov
1c00953b3e Added test tool 2020-04-19 23:57:34 +03:00
Alexey Milovidov
71c4418876 More memory statistics 2020-04-19 23:49:13 +03:00
alexey-milovidov
72dd453c3f
Merge pull request #10234 from vitlibar/show-columns-of-not-loaded-dictionary
Show information about not loaded dictionaries in system tables.
2020-04-18 15:06:08 +03:00
Dmitry
25cd4ce132 Merge branch 'master' of github.com:yandex/ClickHouse into group_by_in_order_optimization 2020-04-18 12:56:34 +03:00
Vitaly Baranov
d62345bbaa Show information about not loaded dictionaries in system.columns, system.tables
and in "SHOW TABLES" executed in any database with the "Dictionary" engine.
2020-04-18 12:50:54 +03:00
Alexander Kuzmenkov
6793cd7cca
More granular assertion in Arena.h 2020-04-18 00:36:07 +03:00
Артем Стрельцов
948efff076 Merge branch 'master' of github.com:yandex/ClickHouse into direct_queries 2020-04-17 23:11:10 +03:00
Артем Стрельцов
741775a12f fixed some remarks from review 2020-04-17 22:54:53 +03:00
Nikolai Kochetov
84faa9af26 Merge branch 'master' into shared-context-lifetime 2020-04-17 19:13:13 +03:00
Nikolai Kochetov
d51a9c551b Remove shared_ptr to SharedContext from Context. 2020-04-17 12:47:40 +03:00
alexey-milovidov
17e7d4d88a
Merge pull request #10307 from abyss7/arcadia-4
Changes for auto-sync with Arcadia
2020-04-17 05:08:34 +03:00
Alexander Kazakov
d5b3b2c7b6
Updated RWLockImpl: Fixed suboptimacy (readers queuing up) + minor tweaks to names and comments (#10303)
* Readers queue correction
* Comments, renamings and cosmetics
2020-04-16 21:56:21 +03:00
alexey-milovidov
3de1a36b33
Update ya.make 2020-04-16 18:55:39 +03:00
Ivan Lezhankin
e230632645 Changes required for auto-sync with Arcadia 2020-04-16 15:31:57 +03:00
alexey-milovidov
2a48b0ecd7
Merge pull request #10184 from xzkostyan/feature-zookeeper-ssl
Optional secured communication between ClickHouse and Zookeeper
2020-04-15 07:09:14 +03:00
Andrey Skobtsov
396c9e4279 Fixed styling v2 2020-04-14 19:23:33 +03:00
Andrey Skobtsov
f4f43ee8ab Replaced some warnings with infos as perf events measurements are optional 2020-04-14 16:58:32 +03:00
Andrey Skobtsov
578faa01a7 Handle CAP_SYS_ADMIN permission accordingly 2020-04-14 16:55:46 +03:00
Andrey Skobtsov
2f708fec03 Fixed compilation issues 2020-04-14 15:17:59 +03:00
Konstantin Lebedev
a7c5f622ea Add string_utils for tests/zookeeper_impl.cpp 2020-04-14 00:27:54 +03:00
Andrey Skobtsov
8650c19967 Fixed styling 2020-04-14 00:10:31 +03:00
Andrey Skobtsov
afaa7eca51 Merge branch 'master' into perf_events_metrics
# Conflicts:
#	dbms/src/Common/ProfileEvents.cpp
2020-04-13 23:59:48 +03:00
Alexander Tokmakov
5e6d4b9449 Merge branch 'master' into database_atomic 2020-04-12 16:35:44 +03:00
alexey-milovidov
f472535f54
Merge pull request #9968 from Enmk/SIMD_tokenization
Splitting string into Alpha-Num tokens with SIMD intrinsics.
2020-04-12 00:33:29 +03:00
Alexander Tokmakov
f0edb65e33 add test 2020-04-11 02:02:15 +03:00
Konstantin Lebedev
c9542b6601 Style fixes for communication between ClickHouse and Zookeeper over SSL 2020-04-11 01:09:14 +03:00
Alexander Tokmakov
033d7f9b32 Merge branch 'master' into database_atomic 2020-04-10 17:12:09 +03:00
Alexander Kazakov
497df3086f Merge branch 'master' into timed_rwlock
Change-Id: I620bfde2121ff013773b001d514b40b1e796a58b
2020-04-10 11:38:20 +03:00
Alexander Tokmakov
58067438cd add fallback for renameat2 2020-04-10 01:23:03 +03:00
Vxider
a8cd174fc4 merged with master 2020-04-09 22:34:02 +08:00
Konstantin Lebedev
b666f60af8 Optional secured communication between ClickHouse and Zookeeper 2020-04-09 01:40:54 +03:00
alexey-milovidov
80b73a209b
Merge pull request #10107 from ClickHouse/fix-globs-test
Fix unit test in debug build.
2020-04-08 22:46:44 +03:00
alexey-milovidov
de2fb3ea17
Merge pull request #10108 from ClickHouse/thread-fuzzer-disable-under-thread-memory-sanitizer
ThreadFuzzer: do not wrap pthread functions under thread and memory sanitizers
2020-04-08 22:46:07 +03:00
Alexander Tokmakov
dd1590830b Merge branch 'master' into database_atomic 2020-04-08 22:00:46 +03:00
alexey-milovidov
6d80ab1eed
Merge pull request #9811 from vitlibar/RBAC-8
RBAC-8
2020-04-08 05:47:55 +03:00
Alexey Milovidov
97c2d17e99 ThreadFuzzer: do not wrap pthread functions under thread and memory sanitizers 2020-04-08 05:32:33 +03:00
Alexey Milovidov
f8500cf5d5 Fix unit test 2020-04-08 04:09:01 +03:00
Alexander Tokmakov
135197aa75 fixes 2020-04-08 04:02:00 +03:00
alexey-milovidov
7212efbfbf
Merge pull request #10103 from ClickHouse/fix-zk-multi-async-flacky
Make the test "zk_multi_async" less flacky
2020-04-08 02:15:43 +03:00
Vitaly Baranov
e573549945 Rework access rights for table functions. 2020-04-07 23:31:59 +03:00
Alexey Milovidov
ccec944ff4 Fix flacky test, take 3 2020-04-07 23:21:43 +03:00
Olga Khvostikova
834e458f26 Fix behaviour of globs in filepath with leading zeros 2020-04-07 16:46:12 +03:00
Alexander Kazakov
621d26bcf7 Better timeout diagnostics message 2020-04-07 14:34:35 +03:00
Alexander Kazakov
78f97a7a59 Build fixes 2020-04-07 12:23:08 +03:00
Ivan
f6b31f344d
Add cross-compile build for FreeBSD (#9643)
* Add toolchain to Docker image
2020-04-07 11:33:49 +03:00
Vasily Nemkov
ef07c6d06f Merge remote-tracking branch 'upstream/master' into SIMD_tokenization 2020-04-07 11:25:52 +03:00
Alexander Kazakov
081187dd1f Unit test for RWLock is set to use timeout for avoiding deadlocks 2020-04-07 03:06:48 +03:00
Alexander Kazakov
b98bc9afef Reworked RWLockImpl::getLock() + phase-fairness
Timeout param added to getLock() method
2020-04-07 02:44:45 +03:00
Alexander Tokmakov
a2101c9b1c better code 2020-04-07 02:22:44 +03:00
Alexander Kazakov
2951ed4f1d Corrected Common.RWLockDeadlock test 2020-04-07 00:35:20 +03:00
Vasily Nemkov
3d471556fb Merge commit '73b0f8db8c327a1d63cc7ebcc56087a3f9866dae' into SIMD_tokenization 2020-04-06 20:05:02 +03:00
Alexander Tokmakov
08bae4668d Merge branch 'master' into database_atomic 2020-04-06 16:18:07 +03:00
Vxider
2fb9138505 merged with master 2020-04-06 17:36:44 +08:00
Alexey Milovidov
110eb599c1 Fix "check style" tool 2020-04-06 02:57:24 +03:00
Ivan Lezhankin
8a5a73e76d Merge branch 'master' into dbms2src 2020-04-03 18:20:05 +03:00
Ivan Lezhankin
06446b4f08 dbms/ → src/ 2020-04-03 18:14:31 +03:00