Commit Graph

106997 Commits

Author SHA1 Message Date
Robert Schulze
84b9ff450f
Fix terribly broken, fragile and potentially cyclic linking
Sorry for the clickbaity title. This is about static method
ConnectionTimeouts::getHTTPTimeouts(). It was be declared in header
IO/ConnectionTimeouts.h, and defined in header
IO/ConnectionTimeoutsContext.h (!). This is weird and caused issues with
linking on s390x (##45520). There was an attempt to fix some
inconsistencies (#45848) but neither did @Algunenano nor me at first
really understand why the definition is in the header.

Turns out that ConnectionTimeoutsContext.h is only #include'd from
source files which are part of the normal server build BUT NOT part of
the keeper standalone build (which must be enabled via CMake
-DBUILD_STANDALONE_KEEPER=1). This dependency was not documented and as
a result, some misguided workarounds were introduced earlier, e.g.
0341c6c54b

The deeper cause was that getHTTPTimeouts() is passed a "Context". This
class is part of the "dbms" libary which is deliberately not linked by
the standalone build of clickhouse-keeper. The context is only used to
read the settings and the "Settings" class is part of the
clickhouse_common library which is linked by clickhouse-keeper already.

To resolve this mess, this PR

- creates source file IO/ConnectionTimeouts.cpp and moves all
  ConnectionTimeouts definitions into it, including getHTTPTimeouts().

- breaks the wrong dependency by passing "Settings" instead of "Context"
  into getHTTPTimeouts().

- resolves the previous hacks
2023-02-05 20:49:34 +00:00
Han Fei
532b341de9
Merge pull request #45975 from ucasfl/_part
use LowCardnality for _part and _partition_id virtual column
2023-02-05 18:00:46 +01:00
Robert Schulze
0dae64fe54
Merge pull request #45258 from ClibMouse/openssl_encryption
Add encryption support to OpenSSL
2023-02-05 17:36:42 +01:00
bkuschel
1f3b1c697f
Add newline 2023-02-04 15:39:28 -05:00
bkuschel
dc995f7c67
Fix size,free ctx,formatting 2023-02-04 15:03:04 -05:00
Boris Kuschel
d9f3698a43
Fix copy/pasta 2023-02-04 14:59:47 -05:00
Boris Kuschel
1d4cf4fe69
Add encryption support with openssl 2023-02-04 14:59:34 -05:00
Alexey Milovidov
496cacf25e
Merge pull request #45985 from ClickHouse/fix-crash-in-regression
Fix crash in stochasticLinearRegression.
2023-02-04 03:01:46 +01:00
Alexey Milovidov
22bd0b6f69
Merge pull request #38983 from CurtizJ/randomize-mt-settings
Allow to randomize merge tree settings in tests
2023-02-04 02:59:52 +01:00
Mikhail f. Shiryaev
cd2e1cfada
Merge pull request #45568 from ClickHouse/keeper-systemd
Add systemd.service for clickhouse-keeper
2023-02-03 23:08:02 +01:00
Dan Roscigno
ed6c884083
Merge pull request #46023 from DanRoscigno/fix-headingsincomparison-docs
fix heading level on comparison page
2023-02-03 14:14:25 -05:00
DanRoscigno
8464357bca fix heading level 2023-02-03 13:57:47 -05:00
Alexander Tokmakov
fa620cc927
Merge pull request #45459 from FrankChen021/stack_trace_in_part_log
Save exception stack trace in part_log
2023-02-03 20:05:35 +03:00
Alexander Tokmakov
3f11948bb0
Merge branch 'master' into stack_trace_in_part_log 2023-02-03 20:05:00 +03:00
Alexander Tokmakov
7e6f7c79f2
Merge pull request #45457 from FrankChen021/exception_time
Add last_exception_time to replication_queue
2023-02-03 20:00:15 +03:00
Alexander Tokmakov
e21c29275a
Merge pull request #45937 from ClickHouse/stress_report_add_context2
Better context for stress tests failures
2023-02-03 18:45:30 +03:00
Alexander Tokmakov
352ccfb156
Merge branch 'master' into stress_report_add_context2 2023-02-03 18:44:53 +03:00
Han Fei
061204408a
Merge pull request #45952 from ucasfl/tuple
Fix tupleElement with Null arguments
2023-02-03 16:15:54 +01:00
Dan Roscigno
9f7d493850
Merge pull request #46015 from DanRoscigno/lwd
Lwd
2023-02-03 09:57:51 -05:00
Robert Schulze
85cbb9288c
Merge pull request #45456 from FrankChen021/uncaught_exception
Fix uncaught exception in HTTPHandler
2023-02-03 15:26:02 +01:00
DanRoscigno
c9244335ef move title to frontmatter 2023-02-03 09:21:30 -05:00
DanRoscigno
7889b632d6 add metadata 2023-02-03 09:16:33 -05:00
DanRoscigno
26a6c5a25b combine guide and reference for lightweight deletes 2023-02-03 09:13:48 -05:00
Nikita Mikhaylov
33877b5e00
Parallel replicas. Part [2] (#43772) 2023-02-03 14:34:18 +01:00
Antonio Andelic
d5117f2aa6
Define S3 client with bucket and endpoint resolution (#45783)
* Update aws

* Define S3 client with bucket and endpoint resolution

* Add defines for ErrorCodes

* Use S3Client everywhere

* Remove unused errorcode

* Add DROP S3 CLIENT CACHE query

* Add a comment

* Fix style

* Update aws

* Update reference files

* Add missing include

* Fix unit test

* Remove unneeded declarations

* Correctly use RetryStrategy

* Rename S3Client to Client

* Fix retry count

* fix clang-tidy warnings
2023-02-03 14:30:52 +01:00
Mikhail f. Shiryaev
c34a09f215
Merge pull request #46012 from ClickHouse/auto/v23.1.3.5-stable
Update version_date.tsv and changelogs after v23.1.3.5-stable
2023-02-03 14:25:35 +01:00
Anton Popov
cdbe145bc1
Merge pull request #45796 from CurtizJ/fix-leak-in-azure-sdk
Fix test `test_azure_blob_storage_zero_copy_replication ` (memory leak in azure sdk)
2023-02-03 14:16:19 +01:00
Vitaly Baranov
45d2d678ab
Merge pull request #45800 from vitlibar/rename-new-columns-in-system-backups
Rename new columns in system.backups
2023-02-03 14:00:16 +01:00
robot-clickhouse
a9ab22e45d Update version_date.tsv and changelogs after v23.1.3.5-stable 2023-02-03 13:00:13 +00:00
Alexey Milovidov
3e3df376c0
Merge pull request #45995 from CurtizJ/check-dynamic-columns
Check dynamic columns of part before its commit
2023-02-03 15:39:54 +03:00
Alexey Milovidov
c91b5c264f
Merge pull request #45940 from ClickHouse/fix-uring
Fix IO URing
2023-02-03 15:36:29 +03:00
Sema Checherinda
fe0b13e9f4
Merge pull request #45458 from FrankChen021/better_postpone_reason
Show the name of replica that is executing a merge in the postpone_reason
2023-02-03 13:15:10 +01:00
Nikolai Kochetov
9cabbd07cc
Merge branch 'master' into fix-crash-in-regression 2023-02-03 12:38:29 +01:00
Robert Schulze
1d65d6a5e9
Merge pull request #46008 from ClickHouse/rs/time-zone-randomization
Docs: Mention time zone randomization
2023-02-03 12:34:55 +01:00
Robert Schulze
d9d51934a9
Docs: Mention time zone randomization 2023-02-03 11:34:11 +00:00
Mikhail f. Shiryaev
dd64c8bacc
Add tests for installation from binary 2023-02-03 12:16:22 +01:00
Mikhail f. Shiryaev
981101a40a
Add arm64 installation tests 2023-02-03 12:16:22 +01:00
Mikhail f. Shiryaev
e41a78b67a
Improve local tests 2023-02-03 12:16:21 +01:00
Mikhail f. Shiryaev
7a7b16dd13
Do not use debconf/confmodule in tgz packages 2023-02-03 12:16:19 +01:00
Mikhail f. Shiryaev
a42d20e19d
Create "coordination" directory in keeper if does not exist 2023-02-03 12:16:19 +01:00
Mikhail f. Shiryaev
496701bd59
Add necessary postinst steps for clickhouse-keeper 2023-02-03 12:16:18 +01:00
Mikhail f. Shiryaev
360ea59ecf
Remove unused variables from clickhouse-server.postinstall 2023-02-03 12:16:18 +01:00
Mikhail f. Shiryaev
a18a4a4502
Use Path in download helper, do not redownload exist files 2023-02-03 12:16:17 +01:00
Mikhail f. Shiryaev
fc48867bed
Get rid of odd entity 2023-02-03 12:16:17 +01:00
Mikhail f. Shiryaev
dc00bce9cf
Add tests for packages' installation 2023-02-03 12:16:16 +01:00
Mikhail f. Shiryaev
548b89b7e0
Use systemd %-specifiers in clickhouse-server.service 2023-02-03 12:16:16 +01:00
Mikhail f. Shiryaev
26a292dafc
Add systemd service-file for clickhouse-keeper 2023-02-03 12:16:10 +01:00
Antonio Andelic
bb44a14a56
Merge pull request #46007 from ClickHouse/revert-45914-improve-into-date-from-uint16
Revert "Improve behaviour of conversion into Date for boundary value 65535"
2023-02-03 12:13:15 +01:00
Antonio Andelic
cb0e338d70
Revert "Improve behaviour of conversion into Date for boundary value 65535" 2023-02-03 12:10:39 +01:00
Kseniia Sumarokova
ef7acb9b66
Merge pull request #44404 from kssenii/storage-rabbitmq-fix-flush
RabbitMQ - fix writing many small blocks by flushing data only exactly by flush_interval_ms or by max_block_size
2023-02-03 11:50:12 +01:00