127098 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Azat Khuzhin	8556929f50	Fix mixing of send_timeout and receive_timeout ... I've noticed this in one of production setups, where lots of queries are executed with distributed_group_by_no_merge=2 (automatically vai optimize_skip_unused_shards optimization) and optimize_aggregation_in_order=1, with this two settings initiator may not read from some shards (i.e. X) for quite long period of time, because it reads from other shards (i.e. Y) and it does not need any data from X yet (due to it read everything in order), and this will lead to query timeout, so timeouts had been increased. Previously both timeouts had been tuned, but this leads to connection hungs in case of abnormal machine reboots. So it is better to tune only send_timeout (and this should be enough, since the only problem is the sender) and this will allow to see that the connection is broken on the initiator once it will read from this shard. but after changing only send_timeout, the query still timedout, and the reason is this place, which swaps this timeouts. It had been introduced in 134efcd, with a comment: NOTE: We use send_timeout for the receive timeout and vice versa (change arguments ordering in TimeoutSetter), because send_timeout is client-side setting which has opposite meaning on the server side. But it sounds odd to me, it may only make sense with the clickhouse-client, since any other driver does not implement any server settings. Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>	2023-10-26 19:36:12 +02:00
Konstantin Bogdanov	ecafc77e0f	Merge pull request #55521 from ClickHouse/fix-query-params-with-custom-http-handlers ... Fix Query Parameters not working with custom HTTP handlers	2023-10-26 18:34:37 +02:00
Alexander Tokmakov	fa963d60d0	Merge pull request #55641 from evillique/resubmit-cluster-groups ... Resubmit #54421	2023-10-26 15:53:53 +02:00
Alexander Tokmakov	463a728b09	Merge pull request #56023 from ClickHouse/fix_02438 ... Fix 02438_sync_replica_lightweight	2023-10-26 15:48:43 +02:00
robot-ch-test-poll4	73d6f0ddaf	Merge pull request #56040 from bezik/patch-3 ... Update index.md	2023-10-26 14:13:31 +02:00
robot-ch-test-poll	da42f2eb0f	Merge pull request #55887 from ucasfl/fix-union-distinct ... Fix normalize ASTSelectWithUnionQuery strip FORMAT of the query	2023-10-26 13:53:58 +02:00
Alexey Milovidov	9313b343e4	Merge pull request #55240 from aiven-sal/aiven-sal/client ... clickhouse-client: don't show "0 rows in set" if it is zero and if exception was thrown	2023-10-26 13:52:53 +02:00
Anton Popov	9e64f51ffa	Merge pull request #56020 from CurtizJ/minor-style-fixes ... Correct the implementation of function `jsonMergePatch`	2023-10-26 13:26:55 +02:00
helifu	4015176d27	A small fix (#55938)	2023-10-26 13:19:58 +02:00
robot-clickhouse-ci-1	f3e07b0fb3	Merge pull request #56042 from bezik/patch-4 ... Update distinctive-features.md	2023-10-26 13:08:12 +02:00
Alexey Milovidov	0794f1faa7	Merge pull request #55775 from kitaisreal/decimal-column-improve-get-permutation-revert-revert ... Improve ColumnDecimal, ColumnVector getPermutation performance using pdqsort with RadixSort fix	2023-10-26 12:36:57 +02:00
Alexey Milovidov	ffcf1f02cb	Merge pull request #55662 from amosbird/fix-55643 ... Add a test to avoid incorrect decimal sorting	2023-10-26 12:36:46 +02:00
AN	6487622d30	Update distinctive-features.md ... Minor Russian language-related fixes (term unifications, hyphens, punctuation etc.)	2023-10-26 13:00:45 +03:00
AN	ba418271c0	Update index.md ... Minor Russian language fixes (hyphens in compounds, term unification)	2023-10-26 12:51:34 +03:00
Raúl Marín	71dfdf5bfe	Merge pull request #56009 from Algunenano/stress_cont ... Stress tests: Try to wait until server is responsive after gdb detach	2023-10-26 11:37:49 +02:00
vdimir	12890eb70c	Merge pull request #55806 from canhld94/rocksdb_trivial_count ... Support trivial count for rocksdb and storage join	2023-10-26 11:22:38 +02:00
vdimir	1d5f75fd71	Merge pull request #53404 from ClickHouse/vdimir/check_table_improvements2 ... Improve CHECK TABLE system query, support checking part	2023-10-26 10:57:44 +02:00
robot-ch-test-poll4	23b7102a39	Merge pull request #55985 from bezik/patch-2 ... Update architecture.md	2023-10-26 10:11:32 +02:00
Alexey Milovidov	4351446373	Merge pull request #55910 from ClickHouse/remove-cpp-templates ... Remove C++ templates, because they are stupid	2023-10-26 09:29:07 +02:00
robot-ch-test-poll3	90c8efa23f	Merge pull request #55979 from kitaisreal/add-show-setting-query ... Add SHOW SETTING query	2023-10-26 09:09:25 +02:00
Anton Popov	95df08dee2	fix test	2023-10-25 23:55:39 +00:00
Robert Schulze	a6eb57a14c	Merge pull request #56006 from rschu1ze/no-scopedlock ... Convert unnecessary std::scoped_lock usage to std::lock_guard	2023-10-25 22:59:27 +02:00
Alexey Milovidov	bb5a60dc19	Merge pull request #55893 from ClickHouse/revert-partial-result-2 ... Revert "Revert "Revert "Add settings for real-time updates during query execution"""	2023-10-25 22:20:28 +02:00
Robert Schulze	425706d76e	Merge pull request #56014 from rschu1ze/protobuf-21.9 ... Bump protobuf to v21.9	2023-10-25 22:19:49 +02:00
Konstantin Bogdanov	1c38f387a5	Poke CI	2023-10-25 22:19:11 +02:00
Alexey Milovidov	b2114fe561	Address review suggestions	2023-10-25 22:08:57 +02:00
Nikolay Degterinsky	d5ee863594	Fix	2023-10-25 19:06:50 +00:00
Nikolay Degterinsky	95f58777e9	Fix style	2023-10-25 19:04:30 +00:00
Nikolay Degterinsky	97c99132e0	Simplify the implementation	2023-10-25 19:02:48 +00:00
Anton Popov	0ca1b006f3	fix build	2023-10-25 18:53:58 +00:00
Maksim Kita	78977f7d5c	ColumnDecimal updatePermutation fix	2023-10-25 21:48:13 +03:00
Maksim Kita	aa5fc05a55	Revert "Merge pull request #55682 from ClickHouse/revert-35961-decimal-column-improve-get-permutation" ... This reverts commit f6dee5fe3c, reversing changes made to f96bda1deb.	2023-10-25 21:48:13 +03:00
Maksim Kita	901294d352	Fixed code review issues	2023-10-25 21:41:26 +03:00
Dmitry Novik	e25ce7c5fb	Merge pull request #56007 from nellicus/patch-1 ... Fix toDayOfWeek return value description	2023-10-25 20:21:20 +02:00
Alexander Tokmakov	c0482cb537	Merge pull request #55944 from azat/rmt-retriable-exception-log ... Do not write retriable errors for Replicated mutate/merge into error log	2023-10-25 18:25:59 +02:00
Alexander Tokmakov	6e735662d9	fix	2023-10-25 18:24:01 +02:00
Konstantin Bogdanov	6aa90117ed	Poke CI	2023-10-25 17:51:57 +02:00
Maksim Kita	108df081b7	Add documentation	2023-10-25 18:49:00 +03:00
Maksim Kita	258a71a25d	Added tests	2023-10-25 18:49:00 +03:00
Maksim Kita	82d4d52b06	Add SHOW SETTING query	2023-10-25 18:49:00 +03:00
Anton Popov	3e6ecf1858	correct the implementation of function jsonMergePatch	2023-10-25 15:17:28 +00:00
Dmitry Novik	3973b24302	Update docs/en/sql-reference/functions/date-time-functions.md	2023-10-25 16:58:25 +02:00
Raúl Marín	62088772d2	Fuzzer: Use the known pid instead of reading the file ... The file might not exists yet	2023-10-25 16:12:18 +02:00
alesapin	0d68a52c06	Merge pull request #50181 from ClickHouse/repro_49887 ... Make exception about `ALTER TABLE ... DROP COLUMN|INDEX|PROJECTION` more clear	2023-10-25 15:57:17 +02:00
Konstantin Bogdanov	b0bbb4d804	Fix ASan failure	2023-10-25 15:54:10 +02:00
Sergei Trifonov	b78cab88cd	Merge pull request #55964 from azat/perf-tests/fix-rg ... Fix possible performance test error	2023-10-25 15:36:39 +02:00
Anton Popov	6ba59b8408	Merge pull request #54364 from Joeywzr/master ... Support jsonMerge function	2023-10-25 15:27:16 +02:00
flynn	229762e4c1	Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-union-distinct	2023-10-25 13:10:56 +00:00
jsc0218	8f8fbb59c1	Merge pull request #55975 from ClibMouse/client_connection_credentails_test ... S390x by default uses openssl. Update the function test to match the error message in case of s390x.	2023-10-25 09:09:17 -04:00
Robert Schulze	50c92dfe11	Update protobuf to v21.9	2023-10-25 11:56:29 +00:00