Commit Graph

12008 Commits

Author SHA1 Message Date
Maksim Kita
3b10043eb2 Fix style check 2021-03-26 18:42:32 +03:00
Maksim Kita
720e2e0501 Updated dictGetDescendants, dictGetChildren implementation 2021-03-26 18:42:32 +03:00
Maksim Kita
566541528d Update function naming 2021-03-26 18:42:32 +03:00
Maksim Kita
bbd180caf3 Added functions dictGetChildren, dictGetDescendants 2021-03-26 18:42:32 +03:00
Maksim Kita
9f2f0d1095 Refactored hierarchy dictionaries interface 2021-03-26 18:42:32 +03:00
Pavel Kruglov
2979feb23f Prevent busy waiting in hedged requests when async_socket_for_remote=0 2021-03-26 18:11:06 +03:00
Anton Popov
421d8eb180 fux build 2021-03-26 17:34:04 +03:00
alexey-milovidov
ac53d30e53
Merge pull request #22146 from azat/writers-uncaught-exceptions
Fix uncaught exception in InterserverIOHTTPHandler
2021-03-26 17:23:09 +03:00
Alexander Kuzmenkov
a455762933
Merge pull request #22117 from ucasFL/useless-code
remove useless code
2021-03-26 17:18:14 +03:00
alesapin
35d1443a9c Don't wait when table shutdown called 2021-03-26 15:54:08 +03:00
tavplubix
d9ec4090d2
Merge pull request #21936 from abyss7/html-form-fix
Fix issues with HTMLForm::MultipartReadBuffer and PeekableReadBuffer
2021-03-26 15:35:34 +03:00
alesapin
9bdeb436c2 Fix typo 2021-03-26 15:06:36 +03:00
alesapin
2db57f0f16 Followup fix 2021-03-26 14:18:31 +03:00
alesapin
331c5b6636 Fix startup one more time 2021-03-26 13:55:39 +03:00
alesapin
ba5c151037 Fix race condition on snapshots 2021-03-26 13:20:07 +03:00
tavplubix
ae62bee939
Merge pull request #21913 from ClickHouse/fix_context_ref
Fix possibly dangling reference to Context
2021-03-26 10:39:13 +03:00
tavplubix
fa930d49c4
Update gtest_peekable_read_buffer.cpp 2021-03-26 10:29:58 +03:00
PHO
26dc629366 Add a function isIPAddressContainedIn()
This function takes an IP address and a CIDR network prefix, and determines if the address is contained in the network. It supports both IPv4 and IPv6 addresses, and expects arguments to be strings.

ClickHouse doesn't support union types. We cannot use the native IPv4 and IPv6 types for this reason.
2021-03-26 12:11:35 +09:00
PHO
9ece398c35 Changed the return type of DB::getCIDRMaskIPv6()
It now returns std::array instead of uint8_t *. Also added DB::getCIDRMaskIPv4().
2021-03-26 12:11:34 +09:00
PHO
6606d8ac0b Correct comments about what parseIPv4() and parseIPv6() actually do
They were wrong as to what endian their results were in.
2021-03-26 12:11:34 +09:00
PHO
1868ca34b8 Fix build on GCC where std::isinf() cannot be called without the namespace prefix 2021-03-26 12:11:22 +09:00
alexey-milovidov
f1efa33571
Merge branch 'master' into client-fix-highlight-multiline-comment 2021-03-26 02:40:11 +03:00
alexey-milovidov
f4d014c022
Update connectionID.cpp 2021-03-26 02:38:49 +03:00
alexey-milovidov
0e42060523
Merge pull request #22114 from ucasFL/bar
Fix bar with invalid float value
2021-03-26 02:36:02 +03:00
Alexey Milovidov
e55f7e6333 Fix error 2021-03-26 02:21:59 +03:00
Alexey Milovidov
ad66c4a916 Fix error 2021-03-26 01:56:24 +03:00
Azat Khuzhin
b68517f69e Fix cutToFirstSignificantSubdomainCustom()/firstSignificantSubdomainCustom() for 3+level domains
Custom TLD lists (added in #17748), may contain domain of the 3-d level,
however builtin TLD lists does not have such records, so it is not
affected.

Note that this will significantly increase hashtable lookups.

Fixes: #17748
2021-03-26 00:00:16 +03:00
Azat Khuzhin
30cd1c6145 Fix typo in FirstSignificantSubdomainCustomLookup name 2021-03-26 00:00:16 +03:00
Azat Khuzhin
f1907acbcd Use finalize() over next() for nested writers
Refs: https://github.com/ClickHouse/ClickHouse/pull/21325#discussion_r585348309
2021-03-25 23:42:58 +03:00
Azat Khuzhin
50003e496a Use existing logger for logging from WriteBufferFromS3 dtor 2021-03-25 23:41:03 +03:00
Azat Khuzhin
e1de960025 Fix uncaught exception in InterserverIOHTTPHandler
There was one more uncaught exception case [1]:

    2021.03.19 18:11:00.845632 [ 17469 ] {} <Debug> InterserverIOHTTPHandler: Done processing query
    ...
    2021.03.19 18:11:31.698961 [ 80145 ] {} <Fatal> BaseDaemon: ########################################
    2021.03.19 18:11:31.699903 [ 80145 ] {} <Fatal> BaseDaemon: (version 21.4.1.6293 (official build), build id: 859E400E1C65C4702FE491420741DD8B58190002) (from thread 17469) (no query) Received signal Aborted (6)
    2021.03.19 18:11:32.614075 [ 80145 ] {} <Fatal> BaseDaemon: 8. ./obj-x86_64-linux-gnu/../contrib/libcxxabi/src/cxa_handlers.cpp:89: std::terminate() @ 0x21e9b3a2 in /usr/bin/clickhouse
    2021.03.19 18:11:43.831215 [ 80145 ] {} <Fatal> BaseDaemon: 10. ./obj-x86_64-linux-gnu/../src/Server/HTTP/WriteBufferFromHTTPServerResponse.cpp:201: ? @ 0x1be77038 in /usr/bin/clickhouse
    2021.03.19 18:11:44.743193 [ 80145 ] {} <Fatal> BaseDaemon: 11. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:892: std::__1::allocator<DB::WriteBufferFromHTTPServerResponse>::destroy(DB::WriteBufferFromHTTPServerResponse*) @ 0x1bddd7c9 in /usr/bin/clickhouse
    2021.03.19 18:11:45.283905 [ 80145 ] {} <Fatal> BaseDaemon: 12. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/__memory/allocator_traits.h:541: void std::__1::allocator_traits<std::__1::allocator<DB::WriteBufferFromHTTPServerResponse> >::__destroy<DB::WriteBufferFromHTTPServerResponse>(std::__1::integral_constant<bool, true>, std::__1::allocator<DB::WriteBufferFromHTTPServerResponse>&, DB::WriteBufferFromHTTPServerResponse*) @ 0x1bddd79d in /usr/bin/clickhouse
    2021.03.19 18:11:45.805233 [ 80145 ] {} <Fatal> BaseDaemon: 13. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/__memory/allocator_traits.h:487: void std::__1::allocator_traits<std::__1::allocator<DB::WriteBufferFromHTTPServerResponse> >::destroy<DB::WriteBufferFromHTTPServerResponse>(std::__1::allocator<DB::WriteBufferFromHTTPServerResponse>&, DB::WriteBufferFromHTTPServerResponse*) @ 0x1bddd76d in /usr/bin/clickhouse
    2021.03.19 18:11:46.351371 [ 80145 ] {} <Fatal> BaseDaemon: 14. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2611: std::__1::__shared_ptr_emplace<DB::WriteBufferFromHTTPServerResponse, std::__1::allocator<DB::WriteBufferFromHTTPServerResponse> >::__on_zero_shared() @ 0x1bddd525 in /usr/bin/clickhouse
    2021.03.19 18:11:46.579263 [ 80145 ] {} <Fatal> BaseDaemon: 15. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2476: std::__1::__shared_count::__release_shared() @ 0x119490ed in /usr/bin/clickhouse
    2021.03.19 18:11:46.790912 [ 80145 ] {} <Fatal> BaseDaemon: 16. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2517: std::__1::__shared_weak_count::__release_shared() @ 0x1194908f in /usr/bin/clickhouse
    2021.03.19 18:11:47.277990 [ 80145 ] {} <Fatal> BaseDaemon: 17. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:3213: std::__1::shared_ptr<DB::WriteBufferFromHTTPServerResponse>::~shared_ptr() @ 0x1bdd75fc in /usr/bin/clickhouse
    2021.03.19 18:11:47.649213 [ 80145 ] {} <Fatal> BaseDaemon: 18. ./obj-x86_64-linux-gnu/../src/Server/InterserverIOHTTPHandler.h:34: DB::InterserverIOHTTPHandler::Output::~Output() @ 0x1bdf6bd5 in /usr/bin/clickhouse
    2021.03.19 18:11:47.921556 [ 80145 ] {} <Fatal> BaseDaemon: 19. ./obj-x86_64-linux-gnu/../src/Server/InterserverIOHTTPHandler.cpp:154: DB::InterserverIOHTTPHandler::handleRequest(DB::HTTPServerRequest&, DB::HTTPServerResponse&) @ 0x1bdf653f in /usr/bin/clickhouse

  [1]: https://clickhouse-test-reports.s3.yandex.net/0/78c56b891383288cf3a893139e796fc87476412e/stress_test_(debug).html

Since in case of no errors during processing we should call finalize, to
ensure that it will not be called from dtor.

Fixes: #22046
Fixes: #22067
2021-03-25 23:41:03 +03:00
Azat Khuzhin
48fe30e5a2 Add missing logging for exception in InterserverIOHTTPHandler 2021-03-25 23:41:03 +03:00
Azat Khuzhin
8e445c5e55 Disable async_socket_for_remote/use_hedged_requests for buggy linux kernels
async_socket_for_remote/use_hedged_requests uses nested epolls, which
may not be reliable in 5.5+ [1], but it has been fixed in shortly in
5.7+ [2] or
5.6.13+.

  [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=339ddb53d373
  [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0c54a6a44bf3
2021-03-25 23:39:30 +03:00
Alexey Milovidov
a8ce138788 Speedup codec NONE 2021-03-25 23:08:47 +03:00
Alexander Kuzmenkov
33647ef3d5 fix build 2021-03-25 23:02:09 +03:00
Alexander Kuzmenkov
0675f9403c
Merge pull request #21895 from ClickHouse/aku/laglead
float RANGE OFFSET and lag/lead_in_frame
2021-03-25 23:00:22 +03:00
Alexander Kuzmenkov
7444eab536 Merge remote-tracking branch 'origin/aku/negate-stable' into HEAD 2021-03-25 21:40:02 +03:00
Alexander Kuzmenkov
9aa89161dc fix for decimals 2021-03-25 21:39:57 +03:00
Maksim Kita
bbe1960eea
Merge pull request #21573 from kitaisreal/updated-cache-dictionary-storage
Added specialized CacheDictionaryStorage
2021-03-25 21:29:01 +03:00
Alexey Milovidov
177a017c5c Minor modification #22115 2021-03-25 20:51:32 +03:00
Alexander Kuzmenkov
72b742258a
Update src/Parsers/ASTFunction.cpp 2021-03-25 19:20:36 +03:00
Alexander Kuzmenkov
4e96675a30
Update src/Parsers/ASTFunction.cpp 2021-03-25 19:18:57 +03:00
Alexander Kuzmenkov
8ea697b7df use camelCase 2021-03-25 18:49:45 +03:00
Alexander Kuzmenkov
48af3f5851 stable formatting for negate() 2021-03-25 18:38:43 +03:00
Peng Jian
fc1cd6f65e remove unnecessary code 2021-03-25 22:57:08 +08:00
vdimir
8f5c8f32df
Shrink totals block to 1 row for JOIN with TOTALS and arrayJoin 2021-03-25 17:32:36 +03:00
Kruglov Pavel
66b8431e71
Merge pull request #21429 from Avogar/secure-socket
Fix receive and send timeouts and non-blocking read in secure socket
2021-03-25 17:30:17 +03:00
Anton Popov
da2d0d2682 fix build 2021-03-25 17:18:29 +03:00
Peng Jian
2ede490152 The thread pool name should not longer than 15 chars 2021-03-25 21:57:47 +08:00
feng lv
55ba4ec15e Fix bar with invalid float value
fix
2021-03-25 13:28:07 +00:00
alexey-milovidov
f895bc895c
Merge pull request #22011 from ClickHouse/min_max_time_system_parts_datetime64
Expose DateTime64 minmax part index in system.parts and system.parts_columns
2021-03-25 16:02:33 +03:00
alexey-milovidov
52396acba1
Merge pull request #22064 from ClickHouse/fix-overflow-aes
Fix missing check in decrypt for AEAD mode
2021-03-25 16:01:44 +03:00
alexey-milovidov
cb6926629e
Merge pull request #22099 from ClickHouse/map-populate-series-ubsan
Fix UBSan report in mapPopulateSeries.
2021-03-25 16:00:21 +03:00
alexey-milovidov
37a4f3ab3a
Merge pull request #22063 from ClickHouse/tuple-null-in
Allow to search tuple of NULLs in a set
2021-03-25 15:59:41 +03:00
Anton Popov
6a15431be7 Merge remote-tracking branch 'upstream/master' into HEAD 2021-03-25 15:57:35 +03:00
Anton Popov
f58d470dd6
Merge pull request #21830 from foolchi/optimize_select_with_final
optimize select final with prewhere primary key
2021-03-25 15:32:13 +03:00
alesapin
4c28c25a75 Merge branch 'master' into jepsen_for_nukeeper 2021-03-25 14:34:00 +03:00
feng lv
b7622868fc remove useless code 2021-03-25 11:10:41 +00:00
Vitaly Baranov
f6f739eca5
Merge pull request #22027 from vitlibar/external-loader-small-simplification
Small simplification in ExternalLoader.
2021-03-25 13:43:31 +03:00
Vitaly Baranov
86a293d6c8
Merge pull request #22057 from vitlibar/update-simdjson
Update simdjson
2021-03-25 13:27:05 +03:00
Nikolai Kochetov
977ebe8b44
Merge pull request #22058 from azat/system.errors-trace
Convert system.errors.stack_trace from String into Array(UInt64)
2021-03-25 10:23:05 +03:00
alexey-milovidov
94dabbac60
Merge pull request #22001 from ClickHouse/timezone-of
Add function `timezoneOf` and fix inconsistencies
2021-03-24 23:15:22 +03:00
Alexey Milovidov
c325ed65e2 Fix UBSan report in mapPopulateSeries 2021-03-24 23:10:15 +03:00
alexey-milovidov
087be05dfd
Merge pull request #22062 from ClickHouse/datetime64-ubsan
Fix UBSan report in TransformDateTime64
2021-03-24 22:36:20 +03:00
Mike Kot
285af08949 Merge remote-tracking branch 'upstream/master' into feature/attach-partition-local 2021-03-24 22:34:20 +03:00
Mike Kot
9f25ee3719 Replaced removing checksums.txt with version
with the explicit data loading and verification.

If the function fails, the exception will re-throw upper,
cancelling the fetch in the handling of the replicated log entry,
but this event will also wake the PartCheckThread, which will
issue a re-fetch.
2021-03-24 22:30:16 +03:00
alexey-milovidov
ffa6585170
Merge pull request #21837 from Jokser/disk-cache-cleanup-directory-before-move
Cleanup destination directory during DiskCacheWrapper::moveFile()
2021-03-24 21:19:48 +03:00
Anton Popov
f967fa574c
Merge pull request #22036 from CurtizJ/merge_21760
Add test for #21760
2021-03-24 16:31:14 +03:00
vdimir
bc1b0aed85
Correctly handle table alias in PredicateRewriteVisitor 2021-03-24 15:48:29 +03:00
Alexander Kuzmenkov
02eee100a0 formatting fixes 2021-03-24 15:36:39 +03:00
alexey-milovidov
1fadf8bad1
Merge pull request #22078 from georgthegreat/patch-1
Flatten libcpuid PEERDIRs
2021-03-24 15:03:46 +03:00
Nikolai Kochetov
6ca8a66da2
Merge pull request #21550 from amosbird/shardpruningliteral
Shard pruning via literals
2021-03-24 13:59:34 +03:00
Slach
769162765c fix connectionID.cpp after fail https://clickhouse-test-reports.s3.yandex.net/22042/419e1555d66469aee90ffb991baad6b2b4f8b294/fast_test.html#fail1 2021-03-24 15:13:33 +05:00
Yuriy Chernyshov
e2760101c1
Update ya.make.in 2021-03-24 13:13:04 +03:00
Pavel Kovalenko
0c0ddefc75 Disk S3 possibility to migrate to restorable schema 2021-03-24 13:12:47 +03:00
Yuriy Chernyshov
c89861a2ac
Better 2021-03-24 13:11:52 +03:00
Pavel Kovalenko
9f9419cf14 Disk S3 possibility to migrate to restorable schema 2021-03-24 13:08:37 +03:00
Pavel Kovalenko
7e462a77a7 Disk S3 possibility to migrate to restorable schema 2021-03-24 13:07:01 +03:00
Pavel Kovalenko
e378c0bf8a Disk S3 possibility to migrate to restorable schema 2021-03-24 12:20:33 +03:00
fuqi
487d6bdcd9 add test case
fix order key check
2021-03-24 16:36:45 +08:00
Slach
7c580d8a01 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix_issue_22028 2021-03-24 09:35:05 +01:00
alesapin
9d8b21a04d Fix ephemeral node removal 2021-03-24 11:12:37 +03:00
Kruglov Pavel
a07dfe328f
Merge pull request #21836 from Jokser/write-buffer-s3-better-error-handling
Better error handling and logging in WriteBufferFromS3
2021-03-24 10:59:27 +03:00
Nikolai Kochetov
f164c2462f
Update Exception.cpp
Fix build
2021-03-24 09:41:57 +03:00
Azat Khuzhin
7c07b43597 Convert system.errors.stack_trace from String into Array(UInt64)
This should decrease overhead for the errors collecting.
2021-03-24 06:52:48 +03:00
Alexey Milovidov
37948ac80a Fix style 2021-03-24 04:12:52 +03:00
Alexey Milovidov
a6c1b30b3c Merge branch 'master' into timezone-of 2021-03-24 04:12:05 +03:00
Alexey Milovidov
5dc9223288 Fix Arcadia 2021-03-24 04:11:57 +03:00
Alexey Milovidov
3e74f56261 Fix missing check in decrypt for AEAD mode 2021-03-24 03:34:30 +03:00
Alexey Milovidov
eae268f2f0 Allow to search tuple of NULLs in a set 2021-03-24 03:15:48 +03:00
Alexey Milovidov
47b00ad11b Fix UBSan report in TransformDateTime64 2021-03-24 02:49:17 +03:00
Alexey Milovidov
4de5afed4e Whitespaces 2021-03-24 02:07:13 +03:00
alexey-milovidov
612d4fb073
Update IMergeTreeDataPart.cpp 2021-03-24 02:03:14 +03:00
Alexander Kuzmenkov
e0d1f6d80f fixes 2021-03-24 01:52:16 +03:00
Alexander Kuzmenkov
f2ef536dfb fix formatting 2021-03-24 01:40:27 +03:00
alexey-milovidov
18c9167ba1
Merge pull request #22009 from ClickHouse/intdiv-ubsan-3
Fix UBSan report in intDiv #21769
2021-03-23 23:53:24 +03:00
alexey-milovidov
150a2df9df
Merge pull request #22026 from kitaisreal/cast-to-enum-nullable-fix
Cast to enum nullable fix
2021-03-23 23:51:19 +03:00
Azat Khuzhin
912144307d Fix type of the ErrorCodes 2021-03-23 23:40:46 +03:00
Vitaly Baranov
1f4df07e08 Update used version of simdjson to 0.9.1 2021-03-23 20:58:30 +03:00
alexey-milovidov
c19045da25
Merge pull request #22010 from ClickHouse/fix-doc-metric
Fix documentation for CurrentMetrics
2021-03-23 20:54:18 +03:00
alexey-milovidov
ed0ad9ec17
Update version.cpp 2021-03-23 20:30:50 +03:00
Slach
c977348076 fix build after fails https://clickhouse-test-reports.s3.yandex.net/22042/0bc0af117eb6faa554d77323f1026dc971abb470/fast_test/runlog.out.log 2021-03-23 21:06:09 +05:00
Slach
0bc0af117e fix build after fails https://clickhouse-test-reports.s3.yandex.net/22042/6ce139dd800fb658ab915adaba6bbd0ca075ce7a/fast_test.html#fail1 2021-03-23 20:20:44 +05:00
tavplubix
48b89a0ace
Merge pull request #21998 from Avogar/hedged-test
Update tests for hedged requests
2021-03-23 18:18:49 +03:00
Maksim Kita
bde02c72f3 Fixed typos 2021-03-23 18:14:22 +03:00
Alexander Kuzmenkov
c9facd631c Merge remote-tracking branch 'origin/master' into HEAD 2021-03-23 17:40:13 +03:00
Alexander Kuzmenkov
0c70fe1a6d fix field get 2021-03-23 17:39:59 +03:00
Slach
6ce139dd80 fix https://github.com/ClickHouse/ClickHouse/issues/22028 2021-03-23 19:31:05 +05:00
Anton Popov
8a56d04714 Merge branch 'merge_tree_part_block_number' of git://github.com/ahrefs/ClickHouse into merge_21760 2021-03-23 16:47:14 +03:00
Alexander Kuzmenkov
97d5be20bb
Merge pull request #22003 from ClickHouse/aku/field-reinterpret
prevent accidental reinterpret_cast in Field::get<>
2021-03-23 15:57:26 +03:00
Anton Popov
2e1f293bd5
Merge pull request #21699 from CurtizJ/fix-map-field-conversion
Fix conversions for fields in function 'arrayElement' for type Map
2021-03-23 15:30:44 +03:00
Vitaly Baranov
46f4c60839 Small simplification in ExternalLoader. 2021-03-23 15:15:44 +03:00
Maksim Kita
890bd6f1e9 Fixed code review issues 2021-03-23 15:14:37 +03:00
vdimir
ea6b8486e9
Try to fix issue #20497 2021-03-23 15:07:51 +03:00
alesapin
0c525b4ec4 Add an ability to run from .deb and .tgz package 2021-03-23 15:07:21 +03:00
Vitaly Baranov
090e558da4
Merge pull request #21844 from Avogar/catboost-deadlock
Fix deadlock in first catboost model execution
2021-03-23 15:01:04 +03:00
Ivan Lezhankin
be76defcfa Remove check for absent checkpoint on rollback 2021-03-23 14:59:36 +03:00
Maksim Kita
75f5679bf0 Cast to enum nullable fix 2021-03-23 14:58:00 +03:00
Alexander Tokmakov
c938f4f2fe fix 2021-03-23 14:29:29 +03:00
vdimir
38a6dba3e3
Add option strict_increase to windowFunnel 2021-03-23 14:23:48 +03:00
alesapin
36898bdc4a
Merge pull request #21142 from Jokser/unfreeze-partitions
Add ALTER TABLE UNFREEZE command.
2021-03-23 14:05:38 +03:00
Pavel Kovalenko
a92cf30b67 Code review fixes. 2021-03-23 13:33:07 +03:00
Pavel Kovalenko
d55af1fa45 Merge branch 'write-buffer-s3-better-error-handling' of github.com:Jokser/ClickHouse into write-buffer-s3-better-error-handling 2021-03-23 13:02:57 +03:00
Pavel Kovalenko
393631a753 Merge remote-tracking branch 'origin/master' into write-buffer-s3-better-error-handling
# Conflicts:
#	src/IO/WriteBufferFromS3.cpp
2021-03-23 13:00:09 +03:00
Nikolai Kochetov
ed19864e5b
Update CollapsingSortedAlgorithm.cpp
Add comment.
2021-03-23 11:25:45 +03:00
Nikolai Kochetov
d7fc5e69f4
Update CollapsingSortedAlgorithm.h
Added comment.
2021-03-23 11:18:49 +03:00
Alexey Milovidov
8d0210b510 Expose DateTime64 minmax part index in system.parts and system.parts_columns #18244 2021-03-23 01:16:41 +03:00
Anton Popov
5de2b8512f fix destruction of aggregate states 2021-03-23 01:12:14 +03:00
Alexander Kuzmenkov
49f617d8ec return the type check 2021-03-23 01:07:04 +03:00
Alexey Milovidov
ce67afd9e3 Fix bad code #18244 2021-03-23 00:49:18 +03:00
Alexey Milovidov
d8088190f9 Fix documentation for CurrentMetrics 2021-03-23 00:44:25 +03:00
Alexey Milovidov
c94841bca5 Fix UBSan report in intDiv #21769 2021-03-23 00:38:25 +03:00
Pavel Kruglov
6278a7efac Fix build 2021-03-23 00:21:52 +03:00
Alexander Kuzmenkov
d40f781b9a Merge origin/master into tmp (using imerge) 2021-03-22 23:27:18 +03:00
Alexander Kuzmenkov
77a2f03d3b prevent accidental reinterpret_cast in Field::get<> 2021-03-22 23:23:44 +03:00
alexey-milovidov
231c7266ab
Merge pull request #21954 from ucasFL/s3-log
Fix misleading log in WriteBufferFromS3
2021-03-22 23:22:44 +03:00
alesapin
ef82333089 Merge branch 'master' into jepsen_for_nukeeper 2021-03-22 23:06:26 +03:00
Alexey Milovidov
84be58453b Add function timezoneOf and fix inconsistencies 2021-03-22 22:50:04 +03:00
Pavel Kruglov
dbc5018000 Update tests for hedged requests 2021-03-22 22:18:06 +03:00
Kruglov Pavel
a215bf7812
Restart CI 2021-03-22 22:12:42 +03:00
Alexander Kuzmenkov
b0284f20c3
Merge branch 'master' into aku/laglead 2021-03-22 21:16:27 +03:00
Ivan Lezhankin
6d4d669f96 Move checkpoint to sub-buffer only from internal memory 2021-03-22 20:20:42 +03:00
Alexander Kuzmenkov
2f5dbf57b6
Merge pull request #21839 from kssenii/add-postgres-connection-pool
Add connection pool for postgres engine
2021-03-22 19:49:51 +03:00
tavplubix
5dfd0045a6
Merge branch 'master' into distributed_ddl_improvements 2021-03-22 18:13:19 +03:00
Mike Kot
da67e06aa0 Added another test case to handle missing part data 2021-03-22 17:52:21 +03:00
Nikolai Kochetov
35ff8925df Fix crash. 2021-03-22 17:43:45 +03:00
Mike Kot
c55a73b752 Added the solution to handle the corruption case
When the part data (e.g. data.bin) is corrupted, but the checksums.txt
is present -- explicitly deleting the checksums.txt.

Removed the extra logging, changes some exceptions message.
2021-03-22 17:23:43 +03:00
Mike Kot
5789507e8b Investigating, why the checksums may match when they shouldn't. 2021-03-22 17:23:43 +03:00
Alexander Kuzmenkov
ac5fdda999
Merge pull request #21915 from ClickHouse/aku/window-mt-order
disable optimize_read_in_order for window functions
2021-03-22 17:21:00 +03:00
Alexander Tokmakov
fc3e11a068 fix 2021-03-22 17:09:38 +03:00
alesapin
4145033d00 Merge branch 'master' into try-fix-excessive-rows-for-collapsing-merge 2021-03-22 16:47:32 +03:00
Nikolai Kochetov
22444045f0 CollapsingSortedAlgorithm should not return more then index_granularity rows. 2021-03-22 16:18:14 +03:00
Maksim Kita
8be263062d
Merge pull request #21910 from kitaisreal/table-function-dictionary
Added table function dictionary
2021-03-22 16:08:56 +03:00
Maksim Kita
56840aba5a Fixed tests 2021-03-22 16:02:32 +03:00
Nikita Mikhaylov
330e74b665
Merge pull request #21890 from kitaisreal/polygon-dictionary-added-nullable-support
PolygonDictionary added nullable support
2021-03-22 14:49:28 +03:00
Maksim Kita
af25805a70
Merge pull request #21948 from kitaisreal/hashed-dictionary-clickhouse-source-preallocate-regression-fix
HashedDictionary clickhouse source preallocate regression fix
2021-03-22 14:11:19 +03:00
alesapin
043b3cc7b5 Fix startup when leadership changed 2021-03-22 13:45:22 +03:00
Kruglov Pavel
6ce7acb5a9
Merge pull request #21941 from azat/hedged-requests-fixes
Prevent hedged connections overlaps
2021-03-22 12:52:51 +03:00
tavplubix
0e5362a02c
Merge pull request #21903 from ClickHouse/tavplubix-patch-3
Show path to data directory of EmbeddedRocksDB
2021-03-22 12:46:53 +03:00
Nikolai Kochetov
730785f4c2
Merge pull request #21459 from ClickHouse/refactor-actions-dag
Refactor actions dag
2021-03-22 11:58:16 +03:00
alesapin
27b90007aa Merge branch 'master' into jepsen_for_nukeeper 2021-03-22 11:20:00 +03:00
feng lv
d40ffa96e2 Fix misleading log in WriteBufferFromS3 2021-03-22 05:49:41 +00:00
Maksim Kita
c5f918f198 CacheDictionaryStorage insert into default value fix 2021-03-21 19:26:06 +03:00
Maksim Kita
257e0455dd Fixed tests 2021-03-21 18:10:12 +03:00
Maksim Kita
249d4a1843 Fixed tests 2021-03-21 18:10:12 +03:00
Maksim Kita
df9223e13b PolygonDictionary added nullable support 2021-03-21 18:09:47 +03:00
Maksim Kita
fff110aa38 HashedDictionary clickhouse source preallocate regression fix 2021-03-21 17:52:33 +03:00
Azat Khuzhin
17eaddc3ab Prevent hedged connections overlaps
Some replicas may be in the establishing state, this means that hedged
connection is waiting for TablesStatusResponse, and if the connection
will not be canceled, then next user of the connection will get
TablesStatusResponse, while this is not the expected package, and you
will see:

    DB::Exception: Received from localhost:9000. DB::Exception: Received from ch-1:9000. DB::Exception: Unknown packet 9 from server ch-2:9000: While executing Remote. Stack trace:

Fix this by disconnecting connection to such replicas, note that this
should be fine in general, since they are "slow" anyway (you may wish
configure hedged requests settings to increase timeouts and similar).
2021-03-20 19:05:29 +03:00
Maksim Kita
849a980644 Updated ExternalDictionariesLoader interface with context parameter 2021-03-20 18:02:09 +03:00
pingyu
83b7ab1fb5 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into datasketches-cmake 2021-03-20 21:15:07 +08:00
kssenii
698b1b043c Fix typos check 2021-03-19 21:54:59 +00:00
kssenii
3b32c8fe9a Block on empty connection pool 2021-03-19 21:00:45 +00:00
Ivan Lezhankin
957c053f7e Fix segfault 2021-03-19 23:29:01 +03:00
Maksim Kita
95c87d4ded
Merge pull request #21884 from kitaisreal/system-dictionaries-updated
Improve system.dictionaries table
2021-03-19 22:49:49 +03:00
kssenii
e066feb81c Slightly better 2021-03-19 18:50:41 +00:00
Alexander Kuzmenkov
3166f0cbfc cleanup 2021-03-19 20:18:17 +03:00
kssenii
50743b19c4 Add one more test 2021-03-19 16:12:33 +00:00
kssenii
f374a71165 Fix 2021-03-19 16:07:53 +00:00
Alexander Kuzmenkov
590259a7a5 disable optimize_read_in_order for window functions 2021-03-19 17:29:09 +03:00
Vladimir
c8b5be636f
Merge pull request #21438 from arenadata/ADQM-170 2021-03-19 17:06:55 +03:00
Alexander Tokmakov
1845df25f3 fix possibly dangling reference to Context 2021-03-19 17:02:48 +03:00
Maksim Kita
c703ea137b
Merge pull request #21891 from kitaisreal/lru-cache-fix-exception-unsafe-element-insertion
LRUCache fix exception unsafe element insertion
2021-03-19 16:37:26 +03:00
Alexander Kuzmenkov
78c56b8913
Merge pull request #21886 from Avogar/hedged
Add profile event in hedged requests and change timeout from sec to ms.
2021-03-19 15:50:33 +03:00
Alexander Kuzmenkov
07c967b5c7
Merge pull request #21896 from ClickHouse/aku/tuple-element
fix fuzzer failure in tupleElement formatting
2021-03-19 15:49:45 +03:00
Maksim Kita
32831e37ba Added table function dictionary 2021-03-19 15:47:27 +03:00
Alexander Kuzmenkov
46e4134deb fix fuzzer failure in tupleElement formatting 2021-03-19 15:47:06 +03:00
Kruglov Pavel
0cb88fb20e
Restart tests 2021-03-19 15:00:21 +03:00
Maksim Kita
a53c90e509 Upated system.dictionaries table 2021-03-19 12:43:57 +03:00
Nikolai Kochetov
bc63d4244b
Merge pull request #21856 from ClickHouse/aggregator-no-more-keys-batch
Batch aggregation for overflow rows.
2021-03-19 11:52:55 +03:00
Maksim Kita
f340e71913
Merge pull request #21859 from kitaisreal/ddl-dictionary-current-database-name
DDL dictionary use current database name
2021-03-19 11:39:51 +03:00
kssenii
a0f717619c Remove initial filling 2021-03-19 08:33:04 +00:00
kssenii
9057aad798 Better version 2021-03-19 08:11:36 +00:00
alesapin
81c408cb7f Return meta and storage from snapshot 2021-03-19 11:08:43 +03:00
tavplubix
fc0b87c5c4
Update StorageEmbeddedRocksDB.h 2021-03-19 10:24:27 +03:00
Alexander Kuzmenkov
4bf2e94fa4 clang is too smart 2021-03-19 03:02:35 +03:00
Alexander Kuzmenkov
1beba597ca Merge remote-tracking branch 'origin/master' into HEAD 2021-03-19 02:11:08 +03:00
Alexander Kuzmenkov
6aa9039f7d float frames and lag/lead_in_frame 2021-03-19 02:05:43 +03:00
Kruglov Pavel
055242fe95
Style 2021-03-19 01:38:15 +03:00
Maksim Kita
31b7734407 LRUCache fix exception unsafe element insertion 2021-03-19 00:26:02 +03:00
alesapin
2654147113 Fix on fix 2021-03-19 00:14:43 +03:00
Anton Popov
6f7c8894e9 fix bugs in aggregation by primary key 2021-03-18 23:57:42 +03:00
alesapin
0137a6baac Add test founding bug 2021-03-18 23:55:11 +03:00
kssenii
f1ef87d966 Fix 2021-03-18 20:04:54 +00:00
Alexander Tokmakov
ce31d4608b fix tests 2021-03-18 22:13:21 +03:00
Pavel Kruglov
d380454044 Change read_data_timeout from sec to ms, add profile event for hedged requests and better process receiving packets 2021-03-18 20:16:17 +03:00
Alexander Kuzmenkov
c821c0c27a
Merge pull request #21761 from ClickHouse/aku/chunk-no-columns
fix incorrect number of rows for Chunks with no columns in PartialSor…
2021-03-18 17:58:09 +03:00
Alexander Kuzmenkov
f85b089292
Merge pull request #21466 from ClickHouse/aku/frame-formatting
add query formatting idempotence check to fuzzer
2021-03-18 17:57:11 +03:00
Maksim Kita
a65bfaeab3 Fixed tests 2021-03-18 17:03:22 +03:00
Nikolai Kochetov
07c5a7766c Fxi test. 2021-03-18 16:23:09 +03:00
Alexander Tokmakov
343b8c906d Merge branch 'master' into test_multiple_nodes 2021-03-18 16:01:04 +03:00
Alexander Tokmakov
fdae70df6c fix tests 2021-03-18 15:50:03 +03:00
Anton Popov
33aefa832b
Merge pull request #21818 from amosbird/datarace2
Fix arena data race in two level merge
2021-03-18 15:05:25 +03:00
Maksim Kita
c01171c626 Fixed tests 2021-03-18 14:58:43 +03:00
Nikolai Kochetov
f4cbecec27 Remove comment. 2021-03-18 14:37:45 +03:00
Nikolai Kochetov
c3c393a7aa Merge branch 'master' into refactor-actions-dag 2021-03-18 14:33:07 +03:00
Maksim Kita
0f95bcac0b DDL dictionary use current database name 2021-03-18 14:30:12 +03:00
Maksim Kita
18ed9c5c67 SSDCacheDictionary remove max_stored_keys option 2021-03-18 12:55:17 +03:00
Nikolai Kochetov
66d5968cbc Batch aggregation for overflow rows. 2021-03-18 12:31:14 +03:00
Nikolai Kochetov
c4dfd97709 Fix ActionsDAG::Index::insert 2021-03-18 10:59:48 +03:00
Pavel Kovalenko
7c0a1b9451 Cleanup destination directory during DiskCacheWrapper::moveFile() 2021-03-18 10:23:19 +03:00
kssenii
7847b78af9 Fix style, build 2021-03-17 20:49:56 +00:00
Maksim Kita
d5a1b50fd2 Updated naming 2021-03-17 22:06:46 +03:00
Maksim Kita
f140204279 Improved performance of SSDCache dictionary 2021-03-17 22:01:45 +03:00
Pavel Kruglov
bf888b7e5f Fix deadlock in first catboost model execution 2021-03-17 21:57:40 +03:00
Nikolai Kochetov
45fead9062 Fix typos 2021-03-17 21:42:42 +03:00
Nikolai Kochetov
9fdb0e667f Add comment. 2021-03-17 21:40:26 +03:00
Maksim Kita
bc22f4f6eb Updated implementation 2021-03-17 20:14:36 +03:00
Nikolai Kochetov
2c1539f641 Fix added input. 2021-03-17 20:08:30 +03:00
fuqi
cfa92f0045 fix code style 2021-03-18 00:25:43 +08:00
Nikolai Kochetov
3eba817a68 Add comments. 2021-03-17 19:08:46 +03:00
fuqi
b8edc12812 fix code style 2021-03-17 23:56:55 +08:00
Mike Kot
e309dd275a Trying to investigate the errors after attaching the part.
+ A new entry is added to the part_log.
2021-03-17 18:49:04 +03:00
Nikolai Kochetov
738cb1af62 Fix filter push down columns order. 2021-03-17 18:33:18 +03:00
Alexander Kuzmenkov
1cd9f28bd4 another way 2021-03-17 18:31:30 +03:00
kssenii
3903d59d30 Better 2021-03-17 14:34:04 +00:00
Pavel Kovalenko
e6711e936e Cleanup destination directory during DiskCacheWrapper::moveFile() 2021-03-17 17:33:13 +03:00
Alexander Tokmakov
91068b782b fix 2021-03-17 17:29:24 +03:00
Pavel Kovalenko
71b36a7029 Better error handling and logging in WriteBufferFromS3 2021-03-17 17:20:55 +03:00
fuqi
e116e8d5e8 fix bug 2021-03-17 22:19:10 +08:00
kssenii
ae64a24844 Add connection pool 2021-03-17 13:55:47 +00:00
Mike Kot
831b90f272 Replaced the iteration algorithm in part finder
Now, instead of iterating through the directories, we iterate though
directories of on of the table disks (which doesn't give us a
substantial boost but is a bit neater to read).

- Updated the system.replication_queue command types.
- Fixed the part ptr being empty (added the checksum loading and
initialization).
- Removed extra logging.
2021-03-17 16:55:26 +03:00
Mike Kot
2ccdb7ef5c Multiple small code and test updates
- Updated the docs to make everything clear.
- Multiple small logger fixes.
- Changed the attach_part command -- now it's after check for the
covering parts -- motivation is to do less work with the checksums
fetching.
- Better logging in the integration test.
2021-03-17 16:52:35 +03:00
Nikita Mikhaylov
2303f1788c
Merge pull request #21807 from 3ldar-nasyrov/master
DDLWorker.cpp: fixed exceeded amount of tries typo
2021-03-17 16:04:59 +03:00
Nikita Mikhaylov
f51b41b7a4
Merge pull request #21710 from kssenii/replica-priorities
Support replicas priority for postgres dictionary source
2021-03-17 16:02:00 +03:00
Kseniia Sumarokova
f8fc4281f2
Update PostgreSQLReplicaConnection.h 2021-03-17 15:56:47 +03:00
fuqi
9ab713c2e1 optimize select final with prewhere primary key 2021-03-17 18:57:58 +08:00
fuqi
5e20ea2c33 optimize select final with prewhere primary key 2021-03-17 18:49:24 +08:00
Pavel Kovalenko
5627ae9067 Make MergeTreeData::getPartitionMatcher const 2021-03-17 12:12:55 +03:00
Nikolai Kochetov
3a3f800f6e
Merge pull request #21579 from azat/dist-query-zero-shards-fix
Fix optimize_skip_unused_shards for zero shards case
2021-03-17 11:54:08 +03:00
Nikolai Kochetov
4f1f344d4d
Merge pull request #21529 from azat/system.errors-improvements
Add last_error_time/last_error_message/last_error_stacktrace/remote columns for system.errors
2021-03-17 11:51:29 +03:00
alexey-milovidov
d02726bcac
Merge pull request #9404 from Enmk/DateTime64_extended_range
Date time64 extended range
2021-03-17 11:06:03 +03:00
Amos Bird
0640bb4cba
Fix arena data race in two level merge 2021-03-17 14:33:57 +08:00
tavplubix
a093980767
Merge pull request #21711 from kssenii/non-default-schema
Support non-default table schema for postgres storage/table-function
2021-03-17 02:10:32 +03:00
Alexey Milovidov
9ca0566132 Minor modification 2021-03-17 02:08:33 +03:00
tavplubix
7ae5e51ee9
Update InterpreterAlterQuery.cpp 2021-03-17 01:50:37 +03:00
Alexander Tokmakov
69cbb99f2c fix 2021-03-17 01:01:48 +03:00
3ldar-nasyrov
37a17749ea
fixed exceeded amount of tries typo
'retires' -> 'retries'
2021-03-16 23:17:07 +03:00
Alexander Tokmakov
ff79be8af9 fix 2021-03-16 23:01:20 +03:00
Azat Khuzhin
9dee842b60 Distinguish remote and local error info 2021-03-16 22:31:49 +03:00
Azat Khuzhin
a337691b06 Fix modernize-use-bool-literals clang-tidy warning in StorageSystemErrors 2021-03-16 22:31:49 +03:00
Azat Khuzhin
cc87bcfb63 Fix errorCodeToName() for signed integers
- https://clickhouse-test-reports.s3.yandex.net/21529/2ce2772d35eb3d81628f4d294d5799e9f05333fd/functional_stateless_tests_(address).html#fail1
- https://clickhouse-test-reports.s3.yandex.net/21529/2ce2772d35eb3d81628f4d294d5799e9f05333fd/functional_stateless_tests_(ubsan).html#fail1
- https://clickhouse-test-reports.s3.yandex.net/21529/2ce2772d35eb3d81628f4d294d5799e9f05333fd/stress_test_(address).html#fail1
2021-03-16 22:31:49 +03:00
Azat Khuzhin
efdd04c958 Drop last_ prefix for ErrorCodes::ValuePair::error_time_ms 2021-03-16 22:31:49 +03:00
Azat Khuzhin
44c9dc753d Add system.errors.last_error_stacktrace column 2021-03-16 22:31:49 +03:00
Azat Khuzhin
775f8f7682 Add system.errors.last_error_message column 2021-03-16 22:31:49 +03:00
Azat Khuzhin
c8852331a2 Add system.errors.last_error_time column 2021-03-16 22:31:49 +03:00
Azat Khuzhin
0d01eaf94f Guard ErrorCodes with mutex over atomic 2021-03-16 22:31:49 +03:00
Azat Khuzhin
7f73ac2b7a Fix ErrorCodes::Value/ErrorCode types (sigh)
Note, that system.errors already uses correct types
2021-03-16 22:31:49 +03:00
Azat Khuzhin
259e5ba88e Separate accounting of remote exceptions in system.errors 2021-03-16 22:31:46 +03:00
Azat Khuzhin
b39f8cc6ac Move ErrorCodes::increment() into module part 2021-03-16 22:31:41 +03:00
Alexander Tokmakov
2d34bbb4b2 Merge branch 'master' into test_multiple_nodes 2021-03-16 21:29:26 +03:00
tavplubix
848bb59175
Merge pull request #21728 from ClickHouse/fix_alter_decimal
Fix alter modify for decimal columns when type size doesn't change
2021-03-16 20:01:35 +03:00
Alexander Kuzmenkov
e5bef75728 fix 2021-03-16 19:15:31 +03:00
Alexey Milovidov
637b683ae9 Fix clang-tidy 2021-03-16 18:35:14 +03:00
Ilya Golshtein
ab670a31dc AvroRowInputFormat::readPrefix inroduced 2021-03-16 17:40:59 +03:00
Anton Popov
6247cd5503 Merge remote-tracking branch 'upstream/master' into HEAD 2021-03-16 16:50:15 +03:00
Pavel Kovalenko
a43c85b105 Add test for freeze/unfreeze partition with old MergeTree syntax 2021-03-16 16:36:05 +03:00
Nikolai Kochetov
0ffea300ac
Merge pull request #21643 from azat/async_socket_for_remote-cancel-fix
Fix distributed requests cancellation with async_socket_for_remote=1
2021-03-16 15:51:49 +03:00
alesapin
077a2019b6 Found first real bug with jepsen 2021-03-16 15:36:54 +03:00
Nikita Mikhaylov
1d15ed34ce
Merge pull request #21737 from excitoon-favorites/reverts3connectionpools
Reverted S3 connection pools
2021-03-16 14:40:54 +03:00
Nikita Mikhaylov
2e13c767a0
Merge pull request #21149 from nikitamikhaylov/pp-for-csv-with-names
Support parallel parsing for *WithNames types
2021-03-16 14:38:03 +03:00
Nikita Mikhaylov
7d7a2bc724
Merge pull request #21630 from nikitamikhaylov/pf-local
Parallel formatting for clickhouse-local
2021-03-16 14:37:40 +03:00
kssenii
fb5c871140 Merge branch 'non-default-schema' of https://github.com/kssenii/ClickHouse into non-default-schema 2021-03-16 11:17:45 +00:00
kssenii
f8a99804c1 Add double quotes 2021-03-16 11:15:43 +00:00
Alexey Milovidov
ea049b2cc0 Merge branch 'master' into DateTime64_extended_range 2021-03-16 14:08:02 +03:00
Alexey Milovidov
eadf0248d0 Build fixes 2021-03-16 14:07:53 +03:00
alexey-milovidov
f52e29cfec
Merge pull request #21624 from vdimir/storage-s3-fail
Try to fix test_storage_s3: crash in WriteBufferFromS3
2021-03-16 13:38:48 +03:00
kssenii
4bdfc799f5 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into non-default-schema 2021-03-16 10:05:10 +00:00
Nikolai Kochetov
e8d7349c79
Merge branch 'master' into dist-query-zero-shards-fix 2021-03-16 12:00:08 +03:00
Pavel Kovalenko
39f3b17041 Merge remote-tracking branch 'origin/master' into unfreeze-partitions 2021-03-16 10:56:24 +03:00
alesapin
23a7c00ba4
Merge branch 'master' into fix_alter_decimal 2021-03-16 10:24:46 +03:00
alesapin
8fd3fbc5b3
Merge pull request #20387 from Avogar/optimize-on-insert
Don't create empty parts on INSERT
2021-03-16 10:20:34 +03:00
Amos Bird
f00e108410
Fix scalar subquery index analysis 2021-03-16 14:07:30 +08:00
Alexander Kuzmenkov
2328d56827 fix 2021-03-16 04:19:33 +03:00
Anton Popov
173d2ea1f4 Merge remote-tracking branch 'upstream/master' into HEAD 2021-03-16 02:50:14 +03:00
Anton Popov
ecd9220c77 minor fixes 2021-03-16 02:28:11 +03:00
Alexander Kuzmenkov
3c16ea0bc8 fix incorrect number of rows for Chunks with no columns in PartialSortingTransform 2021-03-16 01:59:12 +03:00
Maksim Kita
3d1c42827b Added FixedDeadlineHashMap 2021-03-16 01:59:04 +03:00
ip
1a356af579
StorageMergeTree: allocate temp part blocknumber in dest table 2021-03-15 17:03:34 -04:00
Alexey Milovidov
3f67f4f47b Saturation for DateTime 2021-03-15 23:40:33 +03:00
Alexey Milovidov
31d7f10a94 Remove bad code 2021-03-15 23:34:42 +03:00