Commit Graph

133235 Commits

Author SHA1 Message Date
serxa
8728ab768f Fix not started database shutdown deadlock 2024-01-23 19:01:57 +00:00
Robert Schulze
6e1465af10
Merge pull request #59120 from ClickHouse/revert-39507-allow_attach_more_granular_partition
Revert "Allow to attach partition from table with different partition expression when destination partition expression doesn't re-partition"
2024-01-23 15:30:09 +01:00
Robert Schulze
a1c83e2f51
Revert "Allow to attach partition from table with different partition expression when destination partition expression doesn't re-partition" 2024-01-23 15:26:04 +01:00
Anton Popov
4292ee7d51
Merge pull request #58886 from CurtizJ/better-read-buffers
Less error prone interface of read buffers
2024-01-23 14:59:27 +01:00
Kseniia Sumarokova
5e431ec23f
Merge pull request #59079 from ClickHouse/kssenii-patch-8
Fix stateless/run.sh
2024-01-23 14:49:47 +01:00
Antonio Andelic
74dd68afbc
Merge pull request #59102 from ClickHouse/keeper-startup-fix
Avoid election timeouts during startup in Keeper
2024-01-23 13:55:52 +01:00
Alexander Gololobov
9a0e5d0aac
Merge pull request #58914 from ClickHouse/ot_spans_in_insert
Opentelemetry spans to analyze CPU and S3 bottlenecks on inserts
2024-01-23 13:53:13 +01:00
Vitaly Baranov
8e2fceb9b0
Merge pull request #59041 from vitlibar/fix-test-02932_kill_query_sleep-2
Fix test 02932_kill_query_sleep when running with query cache
2024-01-23 13:19:01 +01:00
Kruglov Pavel
b8d2af9574
Merge pull request #59104 from ClickHouse/Avogar-patch-1
Add missing setting max_estimated_execution_time in  SettingsChangesHistory
2024-01-23 12:05:49 +01:00
Robert Schulze
f7a314e76d
Merge pull request #59109 from rschu1ze/follow-up-to-system-reload-async-metrics
Minor follow-up to #53710
2024-01-23 12:04:02 +01:00
Robert Schulze
9752079983
Cosmetics 2024-01-23 10:58:09 +00:00
Robert Schulze
e23e7e6b73
Merge pull request #53710 from rschu1ze/system-reload-asynchronous-metrics
Add statement `SYSTEM RELOAD ASYNCHRONOUS METRICS`
2024-01-23 11:56:25 +01:00
Kseniia Sumarokova
d94b95862f
Merge branch 'master' into kssenii-patch-8 2024-01-23 11:29:22 +01:00
Dmitry Novik
6962859e43
Merge pull request #59068 from ClickHouse/check-optimization-setting
Followup to 57853
2024-01-23 11:24:31 +01:00
Kseniia Sumarokova
f6ffbb4c0a
Merge pull request #59049 from ClickHouse/fix-data-race-in-factories
Fix data race on query_factories_info
2024-01-23 11:22:40 +01:00
Robert Schulze
e67076ea2b
Merge pull request #55201 from canhld94/column_level_compress_block
Column-level compression block sizes
2024-01-23 11:22:03 +01:00
Raúl Marín
7d2aef0571
Merge pull request #59078 from Algunenano/jit_increase
Increase max_bytes_before_external_group_by for 00165_jit_aggregate_functions
2024-01-23 10:52:13 +01:00
Kruglov Pavel
415589d4fc
Fix typo 2024-01-23 10:32:28 +01:00
Kruglov Pavel
35a3879c1f
Add missing setting max_estimated_execution_time in SettingsChangesHistory 2024-01-23 10:17:19 +01:00
Nikita Mikhaylov
bd7024ff9b
Merge pull request #59083 from ClickHouse/fix-startup-failure
Fix server shutdown due to exception while loading metadata
2024-01-23 09:48:38 +01:00
Antonio Andelic
9ce3f8a7aa
typo 2024-01-23 09:18:51 +01:00
Antonio Andelic
ff644831e2 Avoid election timeouts during startup 2024-01-23 08:02:30 +00:00
Robert Schulze
e392b8c4e6
Merge pull request #59100 from rschu1ze/int-alias-docs
Docs: Update integer and float aliases
2024-01-23 08:03:16 +01:00
Robert Schulze
8fc918b272
Fix style, pt. III 2024-01-23 06:23:34 +00:00
Robert Schulze
5a420cd9b1
Update docs 2024-01-23 06:18:07 +00:00
Robert Schulze
ebdad85c4f
Sort integer aliases 2024-01-23 06:11:47 +00:00
Robert Schulze
6f4c0925ab
Merge pull request #58954 from slvrtrn/mysql-add-signed-unsigned-aliases
MySQL compatibility: add SIGNED/UNSIGNED aliases for Int64/UInt64
2024-01-23 07:01:31 +01:00
Robert Schulze
e72b44a0bf
Fix style, pt. II 2024-01-23 05:58:24 +00:00
serxa
6db59de888 use LOGICAL_ERROR to see if it breaks 2024-01-23 05:54:25 +00:00
Duc Canh Le
72466557a8 update test
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-01-23 01:27:39 +00:00
serxa
7b99d9a176 wait for currently running jobs to finish #2 2024-01-22 23:50:53 +00:00
serxa
a1de16d660 wait for currently running jobs to finish 2024-01-22 23:46:54 +00:00
Nikita Taranov
09e24ed6c5
Merge pull request #58068 from zhongyuankai/limit_materialized_view_size
A limit on the number of materialized views attached to a table.
2024-01-22 22:50:56 +01:00
Max K
4932b1cad9
Merge branch 'master' into better-read-buffers 2024-01-22 21:52:55 +01:00
Arthur Passos
24b8bbe9fa
Allow to attach partition from table with different partition expression when destination partition expression doesn't re-partition (#39507)
* temp commit

* temp commit

* draft impl for feedback

* fix weird style changes

* fix weird style changes

* fix weird style changes

* fix weird style changes

* fix weird style changes

* aa

* aa

* Add integ tests and remove partition key restriction

* fix small incosistency in partition id

* style fix

* style fix

* style fix

* use existing DataPartStorageBuilder instead of new one

* Refactor part clone to make it more readable and maintainable

* Add MergeTreeDataPartCloner docs

* define ErrorCodes::BAD_ARGUMENTS

* Rebase

* camel case methods

* address some comments

* yet another rebase?

* Move from integ tests to stateless tests

* address more comments

* add finalize on min_max_idx files

* Add sync option to DistinctPartitionExpCloner

* just a temp test

* revert temp change

* Use echoOn to distinguish test queries

* remove comment

* fix build issue during rebase

* atempt to fix build after rebase

* finally fix build

* clear minmaxidx hyperrectangle before loading it

* Fix error on min_max files deletion where it was being assumed that partition expression contained all columns

* get it to the state it was previously

* add missing include

* getting functional?

* refactoring and renaming

* some more refactoring

* extern bad arguments

* try to fix style

* improvements and docs

* remove duplicate includes

* fix crash

* make tests more stable by ordering

* rebase once again..

* fix

* make ci happy?

* fix rebase issues

* docs

* rebase, but prolly needs to be improved

* refactor out from nasty inheritance to static methods

* fix style

* work around optional

* refactor & integrate some changes

* update column_type

* add tests by dencrane

* set utc

* fix ref file

* fix tests

* use MergeTree instead of SummingMergeTree

* mark MergeTreeDataPart::getBlock as const

* address a few comments

* compute module function name size at compile time

* simplify branching in getPartitionAstFieldsCount

* remove column_indexes argument

* merge getBlock with buildBlock

* add some const specifiers

* small adjustments

* remove no longer needed isNull check

* use std::min and max to update global min max idx

* add some assertions

* forward declare some symbols

* fix grammar

* forward decl

* try to fix build..

* remove IFunction forward decl

* Revert "use std::min and max to update global min max idx"

This reverts commit b2fe79dda7.

* Revert "remove no longer needed isNull check"

This reverts commit 129db2610f.

* Revert "Revert "remove no longer needed isNull check""

This reverts commit 9416087dd8.

* Revert "Revert "use std::min and max to update global min max idx""

This reverts commit 20246d4416.

* remove some comments

* partial use of MonotonicityCheckMatcher

* ranges

* remove KeyDescriptionMonotonicityChecker

* remove duplication of applyfunction

* move functions to anonymous namespace

* move functions to cpp

* Relax partition compatibility requirements by accepting subset, add tests from partitioned to unpartitioned

* updte reference file

* Support for partition by a, b, c to partition by a, b

* refactoring part 1

* refactoring part 2, use hyperrectangle, still not complete

* refactoring part 3, build hyperrectangle with intersection of source & destination min max columns

* Support attaching to table with partition expression of multiple expressions

* add tests

* rename method

* remove some code duplication

* draft impl for replicatedmergetree, need to dive deeper

* ship ref file

* fix impl for replicatedmergetree..

* forbid attach empty partition replicatedmergetree

* Add replicated merge tree integration tests

* add test missing files

* fix black

* do not check for monotonicity of empty partition

* add empty tests & fix replicated

* remove no longer needed buildBlockWithMinMaxINdexes

* remove column logic in buildHyperrectangle

* simplify implementation by using existing methods

* further simplify implementation

* move all MergeTreeDataPartClone private methods to .cpp file

* decrease decomposition

* use different namespaces

* reduce code duplication

* fix style

* address a few comments

* add chassert to assert arguments size on MonotonicityCheckVisitor

* remove deleteMinMaxFiles method

* remove useless checks from sanitycheck

* add tests for attach partition (not id)

* Remove sanityCheckASTPartition and bring back conditional getPartitionIDFromQuery

* remove empty block comment

* small fixes

* fix formatting

* add missing include

* remove duplicate iuncludes

* trigger ci

* reduce some code duplication

* use updated partition id on replicatedmergetree

* fix build

* fix build

* small refactor

* do not use insert increment on fetch part

* remove duplicate includes

* add one more integ test

* black

* black

* rely on partition exp instead of partition id on replicated part fetch to decide if it is a different partition exp

* add one more integ test

* add order by clause

* fix black

---------

Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
2024-01-22 21:00:04 +01:00
serxa
f1ab22d4c3 fix style 2024-01-22 19:54:50 +00:00
serxa
fad5aeede3 fix 2024-01-22 19:43:25 +00:00
serxa
1d6d1182fd Fix server shutdown due to exception while loading metadata 2024-01-22 19:38:26 +00:00
Kseniia Sumarokova
bfb822b775
Try fix style check 2024-01-22 20:32:47 +01:00
Max K
5804a65262
Merge pull request #59081 from ClickHouse/ci_hot_fix_reuse
CI: hot fix for reuse
2024-01-22 20:32:43 +01:00
Max Kainov
f1220c5637 CI: hot fix for reuse 2024-01-22 19:19:22 +00:00
Robert Schulze
d739a7230a
Fix style 2024-01-22 17:37:16 +00:00
Kseniia Sumarokova
a23d71b7bb
Update run.sh 2024-01-22 18:19:58 +01:00
Robert Schulze
c0868eedbd
Remove obsolete test 2024-01-22 17:19:10 +00:00
Robert Schulze
90a0ea36b3
Add statement 'SYSTEM RELOAD ASYNCHRONOUS METRICS' 2024-01-22 17:14:58 +00:00
Raúl Marín
74e012049b Adapt 00082_quantiles too 2024-01-22 18:03:59 +01:00
Raúl Marín
9069477871 Increase max_bytes_before_external_group_by for 00165_jit_aggregate_functions 2024-01-22 17:57:13 +01:00
Robert Schulze
748371d127
Refactor locking in AsynchronousMetrics 2024-01-22 16:51:02 +00:00
Robert Schulze
1262945df7
Cosmetics 2024-01-22 16:51:02 +00:00
slvrtrn
db56f11d50 Fix style check 2024-01-22 17:44:55 +01:00