Commit Graph

2347 Commits

Author SHA1 Message Date
Antonio Andelic
28e9508c4e Improve shared pool and add settings 2022-03-11 08:33:34 +00:00
HeenaBansal2009
3f031df225 Code refactoring 2022-03-10 22:22:51 -08:00
taiyang-li
2ae5129e2d modify play.tml 2022-03-11 12:13:46 +08:00
alesapin
0116c3bfeb Fix redundant change 2022-03-10 22:27:10 +01:00
alesapin
e53578910b Add ability to strip binaries in cmake 2022-03-10 22:23:28 +01:00
HeenaBansal2009
3ce9397246 Added Suggestions from Code review 2022-03-09 20:35:01 -08:00
mergify[bot]
78c8029aeb
Merge branch 'master' into stress-test 2022-03-09 16:22:45 +00:00
kssenii
5260822964 Merge master 2022-03-08 18:21:28 +01:00
kssenii
e231c3a3e0 Fix split build 2022-03-08 18:05:55 +01:00
Azat Khuzhin
a871036361
Fix parallel_reading_from_replicas with clickhouse-bechmark (#34751)
* Use INITIAL_QUERY for clickhouse-benchmark

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Fix parallel_reading_from_replicas with clickhouse-bechmark

Before it produces the following error:

    $ clickhouse-benchmark --stacktrace -i1 --query "select * from remote('127.1', default.data_mt) limit 10" --allow_experimental_parallel_reading_from_replicas=1 --max_parallel_replicas=3
    Loaded 1 queries.
    Logical error: 'Coordinator for parallel reading from replicas is not initialized'.
    Aborted (core dumped)

Since it uses the same code, i.e RemoteQueryExecutor ->
MultiplexedConnections, which enables coordinator if it was requested
from settings, but it should be done only for non-initial queries, i.e.
when server send connection to another server.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Fix 02226_parallel_reading_from_replicas_benchmark for older shellcheck

By shellcheck 0.8 does not complains, while on CI shellcheck 0.7.0 and
it does complains [1]:

    In 02226_parallel_reading_from_replicas_benchmark.sh line 17:
        --allow_experimental_parallel_reading_from_replicas=1
        ^-- SC2191: The = here is literal. To assign by index, use ( [index]=value ) with no spaces. To keep as literal, quote it.

    Did you mean:
        "--allow_experimental_parallel_reading_from_replicas=1"

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/34751/d883af711822faf294c876b017cbf745b1cda1b3/style_check__actions_/shellcheck_output.txt

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-03-08 16:42:29 +01:00
taiyang-li
b4174b0bef merge master and fix conflicts 2022-03-08 11:39:25 +08:00
Kseniia Sumarokova
cdb9a05229
Merge pull request #34605 from bigo-sg/add_metric_for_local
Add cpu/mem metric for clickhouse-local
2022-03-07 11:40:11 +01:00
mergify[bot]
977bd30e19
Merge branch 'master' into stress-test 2022-03-05 08:34:07 +00:00
taiyang-li
1b9987ceb1 fix mistake in check-style 2022-03-05 14:22:56 +08:00
alexey-milovidov
ee619dc68e
Merge pull request #35068 from ClickHouse/PlayUI_theme_fixes
Added 'theme' GET parameter to PlayUI + theme selection according to OS fixes
2022-03-05 02:59:27 +03:00
Nir Peled
9c024c9617 Changed the Play UI to select a theme by the following priority:
* 'theme' GET parameter
* 'theme' in localStorage
* According to OS preference (didn't work before)

Also, theme is only saved in localStorage if a user specifically clicked on one theme icon or the other.
2022-03-04 18:44:45 -05:00
alexey-milovidov
7da2c5f927
Update play.html 2022-03-05 02:04:49 +03:00
alesapin
c5a456802f Fix build 2022-03-04 19:39:11 +01:00
Kruglov Pavel
dbba752398
Merge branch 'master' into stress-test 2022-03-04 18:33:37 +03:00
alesapin
5416b567d5 Merge branch 'master' into standalone_keeper_build 2022-03-04 13:35:07 +01:00
alesapin
0eb7d28192 Building small keeper binary 2022-03-03 21:27:46 +01:00
mergify[bot]
c90d24e10b
Merge branch 'master' into random-settings 2022-03-03 13:07:12 +00:00
Vladimir C
eb68c21152
Merge pull request #34995 from vdimir/fix-aarch64 2022-03-03 12:18:28 +01:00
Vladimir C
ec3ed98dfe
Merge pull request #34947 from freedomDR/feature1 2022-03-03 12:14:01 +01:00
Maksim Kita
7d90afb3b0
Merge pull request #34988 from azat/safe-exit
Fix signal-unsafe TSan report in client
2022-03-03 09:21:26 +01:00
Azat Khuzhin
798da0c314 Introduce safeExit() helper (_exit() compatible with TSan)
v2: add missing defines.h header
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-03-02 22:17:17 +03:00
Maksim Kita
1f5837359e clang-tidy check performance-noexcept-move-constructor fix 2022-03-02 18:15:27 +00:00
avogar
d25d83580a Fix tests 2022-03-02 16:33:21 +00:00
vdimir
fc5e941f79
Add option to clickhouse-test to skip aarch64 build 2022-03-02 14:18:24 +00:00
freedomDR
43ac214dc5 get credentials from environment variables for clickhouse-client
include CLICKHOUSE_USER, CLICKHOUSE_PASSWORD
2022-03-02 00:54:51 +00:00
taiyang-li
b31440c77a Merge branch 'master' into add_metric_for_local 2022-03-01 12:29:36 +08:00
HeenaBansal2009
c14c60f1d3 Merge branch 'master' into Issue-33953 2022-02-28 11:12:54 -08:00
HeenaBansal2009
aa8494a808 Fix: System Reload Config Failure 2022-02-28 10:51:49 -08:00
mergify[bot]
8014cdf9d3
Merge branch 'master' into random-settings 2022-02-28 14:06:22 +00:00
kssenii
92d2cff045 Fix 2022-02-25 16:04:11 +01:00
vdimir
dfc990aed4
Fix using host/port from config for client 2022-02-21 12:08:23 +00:00
HeenaBansal2009
1b263f0c15 Added FT testcase 2022-02-18 12:58:46 -08:00
avogar
ba7f723961 Fix comments 2022-02-18 13:54:21 +00:00
HeenaBansal2009
d16cae53b4 Initial Commit for Plaintext password feature 2022-02-17 21:25:18 -08:00
Kruglov Pavel
e77319bf01
Merge branch 'master' into stress-test 2022-02-17 20:28:46 +03:00
avogar
1e797c1a8f Fix some tests 2022-02-16 15:10:02 +00:00
Kruglov Pavel
adf58ea1ce
Merge pull request #34490 from Avogar/fix-client
Refactor client fault tolerant connection
2022-02-16 12:39:46 +03:00
Kruglov Pavel
e8d855ef4c
Update description 2022-02-15 15:12:21 +03:00
taiyang-li
24bd47e556 finish dev 2022-02-15 20:11:13 +08:00
Sergei Trifonov
0f66743104 support determine available memory for FreeBSD 2022-02-15 13:59:00 +03:00
serxa
7ea3c003d5 fix style 2022-02-15 10:39:45 +00:00
Sergei Trifonov
a819cb7afe avoid unhandled exceptions on sanity checks at server startup 2022-02-15 12:56:21 +03:00
李扬
f52b67b939
Merge branch 'master' into rocksdb_metacache 2022-02-15 02:16:29 -06:00
alexey-milovidov
bc206ec423
Merge pull request #31182 from ClickHouse/memory-overcommit
Memory overcommit
2022-02-14 23:55:02 +03:00
Kseniia Sumarokova
382b8e0388
Merge pull request #34432 from ClickHouse/static-files-disk-uploader-create-symlinks
`static-files-disk-uploader`: add a mode to create symlinks
2022-02-14 18:10:53 +01:00
Anton Popov
2399f3e3bb
Merge pull request #34495 from Avogar/improve-local
Improve schema inference in clickhouse-local
2022-02-14 17:27:24 +03:00
Sergei Trifonov
3d66acc56b
Apply suggestions from code review
Co-authored-by: alesapin <alesapin@clickhouse.com>
2022-02-14 17:16:05 +03:00
alexey-milovidov
0250b28916
Merge pull request #34550 from kssenii/fix-test
Tiny fixes for client/local suggestions
2022-02-14 16:52:56 +03:00
Kruglov Pavel
2bf15d6b5b
Merge pull request #34352 from bigo-sg/clickhouse_local_format
Default input and output formats that can be overriden by --input-format and --output-format.
2022-02-14 14:09:59 +03:00
Sergei Trifonov
2b0b03276b add simple sanity checks for server startup 2022-02-13 19:58:38 +03:00
mergify[bot]
8a47ed2b3f
Merge branch 'master' into static-files-disk-uploader-create-symlinks 2022-02-13 06:12:39 +00:00
kssenii
39049251b7 Fix disable_suggestion argument for clickhouse-local 2022-02-12 20:26:01 +01:00
李扬
daa27d0bda
Merge branch 'master' into rocksdb_metacache 2022-02-12 07:50:12 -06:00
avogar
7d92d9d060 Fix tests 2022-02-10 18:37:27 +03:00
avogar
a69905d378 Fix 2022-02-10 18:23:52 +03:00
avogar
9bbbbdcdd6 Improve schema inference in clickhouse-local 2022-02-10 18:23:52 +03:00
Kruglov Pavel
767bcabd5b
Fix style 2022-02-10 14:21:41 +03:00
Kruglov Pavel
8947c5de11
Update description
Co-authored-by: Vladimir C <vdimir@clickhouse.com>
2022-02-10 14:07:21 +03:00
mergify[bot]
cb3e5f8538
Merge branch 'master' into memory-overcommit 2022-02-10 11:01:43 +00:00
avogar
75c56163a0 Refactor client fault tolerant connection 2022-02-10 12:43:08 +03:00
Dmitry Novik
d2e1f66c57 Fix test 2022-02-10 01:01:14 +00:00
Vitaly Baranov
1341b4b4de Rename QueryInfo's field result_compression -> transport_compression_type and change its type for better consistency.
Make the previous field obsolete.
2022-02-10 02:46:05 +07:00
Alexey Milovidov
742620209a static-files-disk-uploader: add mode to create symlinks 2022-02-09 03:50:50 +03:00
DF5HSE
e657219e01 Delete not used include 2022-02-08 12:40:44 +03:00
DF5HSE
c08bc7ad65 Merge branch 'master' of github.com:ClickHouse/ClickHouse into client-fault-tolerant-connection 2022-02-08 11:37:31 +03:00
taiyang-li
b6132d490f merge master and solve conflict 2022-02-08 15:24:59 +08:00
Maksim Kita
1c461e9ed1
Merge pull request #34349 from bigo-sg/format_parse_options
Add options for clickhouse-format.
2022-02-08 00:50:04 +01:00
DF5HSE
b035ad7843 Fix error with IPv6 in host param and impove HostPort reading from input stream 2022-02-08 02:03:39 +03:00
DF5HSE
3cb433762b Fix errors in build check 2022-02-08 02:03:39 +03:00
DF5HSE
3343a22788 Merge branch 'client-fault-tolerant-connection' of github.com:ManagedDatabases/ClickHouse into client-fault-tolerant-connection 2022-02-08 02:03:38 +03:00
Filippov Denis
226759b674 Update programs/client/Client.cpp
Fix `--host` parameter description

Co-authored-by: Kruglov Pavel <48961922+Avogar@users.noreply.github.com>
2022-02-08 02:03:38 +03:00
DF5HSE
18a777cc8b Add function which gets port from configuration 2022-02-08 02:03:37 +03:00
DF5HSE
a9ff296960 Fix codestyle 2022-02-08 02:03:36 +03:00
DF5HSE
69e535fcb2 Merge branch 'master' of github.com:ClickHouse/ClickHouse into client-fault-tolerant-connection 2022-02-08 02:03:36 +03:00
DF5HSE
e780c1292d Add tests, remove saving host in config 2022-02-08 02:03:35 +03:00
DF5HSE
19cf4e6dec round robin connection on fail 2022-02-08 02:03:25 +03:00
Kruglov Pavel
f63455b7a2
Merge pull request #34117 from Avogar/local
Small improvement in schema inference from stdin in local
2022-02-07 10:47:14 +03:00
taiyang-li
26f2a0ef51 move clickhouse-format code from settings to format.cpp 2022-02-07 13:34:13 +08:00
taiyang-li
0c47dd4ec2 format override input-format 2022-02-06 12:17:03 +08:00
taiyang-li
caed1898b0 add options for clickhouse-format 2022-02-06 11:22:05 +08:00
alexey-milovidov
665fdc9187
Merge pull request #31257 from FArthur-cmd/merge_15765
Merge #15765
2022-02-04 00:39:57 +03:00
FArthur-cmd
73f579d71c Comment dhParamsFile. It should be uncommented only if it has correct path 2022-02-03 13:31:52 +00:00
FArthur-cmd
f327e67232 correct config 2022-02-02 20:01:25 +00:00
Anton Popov
5bb1b3ce77 support async inserts in clickhouse-client for queries with inlined data 2022-02-02 20:59:37 +03:00
Azat Khuzhin
3b3635c6d5 Fix formatting error in logging messages
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-01 14:30:04 +03:00
Azat Khuzhin
bedf208cbd Use fmt::runtime() for LOG_* for non constexpr
Here is oneliner:

    $ gg 'LOG_\(DEBUG\|TRACE\|INFO\|TEST\|WARNING\|ERROR\|FATAL\)([^,]*, [a-zA-Z]' -- :*.cpp :*.h | cut -d: -f1 | sort -u | xargs -r sed -E -i 's#(LOG_[A-Z]*)\(([^,]*), ([A-Za-z][^,)]*)#\1(\2, fmt::runtime(\3)#'

Note, that I tried to do this with coccinelle (tool for semantic
patchin), but it cannot parse C++:

    $ cat fmt.cocci
    @@
    expression log;
    expression var;
    @@

    -LOG_DEBUG(log, var)
    +LOG_DEBUG(log, fmt::runtime(var))

I've also tried to use some macros/templates magic to do this implicitly
in logger_useful.h, but I failed to do so, and apparently it is not
possible for now.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

v2: manual fixes
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-01 14:30:03 +03:00
Amos Bird
ec7d367814
DiskLocal checker
Add DiskLocal checker so that ReplicatedMergeTree can recover data when some of its disks are broken.
2022-02-01 05:55:27 +08:00
FArthur-cmd
f20f2f6beb fix test 2022-01-31 13:39:39 +00:00
FArthur-cmd
7811f5d599 try uncomment config 2022-01-31 11:18:57 +00:00
李扬
6d50d36405
Merge branch 'master' into rocksdb_metacache 2022-01-28 22:00:31 -06:00
FArthur-cmd
cb4ad97d45 add test 2022-01-28 17:37:52 +00:00
avogar
8858b6bf86 Small improvement in schema inference from stdin in local 2022-01-28 19:17:35 +03:00
Kruglov Pavel
efa8775ea6
Merge pull request #33960 from Avogar/autodetect-format
Detect format and schema from stdin in clickhouse-local
2022-01-28 12:02:15 +03:00
taiyang-li
3de8bde7ce Merge remote-tracking branch 'origin/master' into rocksdb_metacache 2022-01-28 09:58:52 +08:00
Alexey Milovidov
ff31a2c9e0 Add symlinks to keeper 2022-01-27 01:23:18 +03:00