Commit Graph

6482 Commits

Author SHA1 Message Date
alesapin
60118b65d5 Better 2020-02-19 18:12:32 +03:00
alesapin
c4972b3799 Better 2020-02-19 18:07:02 +03:00
Pavel Kovalenko
d4fa60f52d Rename disk_name -> disk. 2020-02-19 17:50:39 +03:00
alesapin
6020f2fd4a Remove redundant function 2020-02-19 17:50:11 +03:00
alesapin
d5b4ddf6d8 Simplier alter modify logic 2020-02-19 17:49:59 +03:00
alesapin
28b2a03b08 First version 2020-02-19 17:49:45 +03:00
alesapin
7a9b96a8f9 Remove redundant function 2020-02-19 17:43:34 +03:00
alesapin
3f29ea0756 Simplier alter modify logic 2020-02-19 17:39:01 +03:00
CurtizJ
23592991e6 comments and refactoring 2020-02-19 17:07:36 +03:00
alesapin
3b4c27b0de Fix remove parts from mutations 2020-02-19 15:55:23 +03:00
alesapin
6f266c94ed Trying to simplify alter commands logic 2020-02-19 15:52:27 +03:00
alesapin
ad51369982 Fix remove of actual_part from mutations 2020-02-19 15:50:11 +03:00
alesapin
6eda5547a2 Revert redundant change 2020-02-19 15:00:45 +03:00
Pavel Kovalenko
d662c1e006 Merge branch 'master' into storage-stripe-log-s3 2020-02-19 13:24:23 +03:00
Nikolai Kochetov
4fa6c86114 Fix StorageHDFS. 2020-02-19 13:22:44 +03:00
Nikolai Kochetov
70a7ddc172 Fix StorageURL 2020-02-19 13:17:49 +03:00
alexey-milovidov
b063dbeaf2
Merge pull request #8598 from excitoon-favorites/passttlsoverhttp
Pass TTL rule info with block to other replicas
2020-02-19 12:09:25 +03:00
alexey-milovidov
c5d5c9c11e
Merge pull request #9192 from nvartolomei/nv/format-version-file-typo
Fix typo in file name when reporting version file duplicates
2020-02-19 11:59:22 +03:00
alexey-milovidov
1c66c2f383
Merge pull request #9201 from CurtizJ/fix-range-reader
Fix mistake introduced in #9050.
2020-02-19 11:58:21 +03:00
alesapin
c2d53438e1 Less flappy test and more comments 2020-02-19 11:45:09 +03:00
CurtizJ
dea444b69c fix mistake in MergeTreeDataSelectExecutor 2020-02-19 00:00:51 +03:00
alesapin
f4b2be7b32 Remove parts from mutations on replica start 2020-02-18 22:57:48 +03:00
Pavel Kovalenko
ff50a51757 Formatting issues. 2020-02-18 22:13:37 +03:00
CurtizJ
b0f7905567 better TTL calculations with mutations 2020-02-18 22:03:40 +03:00
alesapin
1f4b42a99f Fix bug in initialization 2020-02-18 20:31:49 +03:00
Nikolai Kochetov
69a38958b4 fix PVS warning. 2020-02-18 19:23:29 +03:00
Pavel Kovalenko
05ceef4ef8 Log family storages disk support via 'SETTINGS' clause. 2020-02-18 17:41:30 +03:00
Nikolai Kochetov
3f55e6a499 Processors support for StorageFromMergeTreeDataPart reading. 2020-02-18 17:24:33 +03:00
Nicolae Vartolomei
b612cbf7d8 Fix typo in file name when reporting version file duplicates 2020-02-18 11:44:16 +00:00
alesapin
b3fe0b51a1 Merge branch 'master' into alter_on_top_of_mutations 2020-02-18 14:32:12 +03:00
alesapin
db3ea6cca8 Better comments 2020-02-18 14:31:24 +03:00
CurtizJ
49c80c88ef Merge remote-tracking branch 'upstream/master' into alter-ttl 2020-02-18 10:58:07 +03:00
Nikolai Kochetov
e6a30feed0 Fix build. 2020-02-18 10:53:16 +03:00
Pavel Kovalenko
33443c4bea Merge branch 'master' into storage-stripe-log-s3
# Conflicts:
#	dbms/src/Compression/CompressedReadBufferFromFile.h
#	dbms/src/IO/ReadBufferFromFileBase.h
2020-02-18 00:29:09 +03:00
CurtizJ
2ff030be35 recalculate TTL expressions during mutations 2020-02-17 23:39:24 +03:00
Alexander Tokmakov
e6718e199e less Context::getTable() usages 2020-02-17 22:28:25 +03:00
alesapin
a084ee8edd Fix style 2020-02-17 21:09:04 +03:00
alesapin
38450ccb6e Slightly better code 2020-02-17 21:07:22 +03:00
Nikolai Kochetov
bdaeafffc1 Processors support for StorageLiveView reading. 2020-02-17 19:37:18 +03:00
Nikolai Kochetov
fbfaac6391 Processors support for StorageLiveView reading. 2020-02-17 19:35:23 +03:00
alesapin
382f6ab720 More comments and slightly better code 2020-02-17 19:33:05 +03:00
Nikolai Kochetov
34d7873524 Processors support for StorageKafka reading. 2020-02-17 19:08:22 +03:00
alesapin
6a02b99faf Slightly refactor merger mutator 2020-02-17 18:44:13 +03:00
Nikolai Kochetov
98b6ad4eff Processors support for StorageXDBC reading. 2020-02-17 18:33:16 +03:00
Nikolai Kochetov
dda0bcb9ba Processors support for StorageXDBC reading. 2020-02-17 18:32:27 +03:00
Nikolai Kochetov
728ece09f1 Processors support for StorageView reading. 2020-02-17 18:27:51 +03:00
Nikolai Kochetov
4cc3eaa9ce Processors support for StorageValues reading. 2020-02-17 18:07:42 +03:00
Nikolai Kochetov
5372942aef Processors support for StorageURL reading. 2020-02-17 18:01:03 +03:00
Nikolai Kochetov
df76f1fe56 Processors support for StorageTinyLog reading. 2020-02-17 17:45:10 +03:00
Ivan Lezhankin
102dad0ca0 Merge branch 'master' into arcadia 2020-02-17 17:37:10 +03:00
Ivan Lezhankin
39ea079034 More clean-up 2020-02-17 17:27:09 +03:00
Alexander Tokmakov
d710bd1812 better get... methods 2020-02-17 16:52:59 +03:00
alesapin
b59fd72f34 Remove comment 2020-02-17 16:48:59 +03:00
alesapin
55192a652f Less changes 2020-02-17 16:41:53 +03:00
alesapin
72ed29f1e8 Remove some garbage from code 2020-02-17 16:35:17 +03:00
alesapin
e531e0a0ab Add test with bad alter 2020-02-17 16:20:09 +03:00
alesapin
47c649f6c3 Fix all style warnings 2020-02-17 15:47:34 +03:00
Alexey Milovidov
809b409426 Read the code 2020-02-17 15:44:58 +03:00
alesapin
777dfc774d One more test 2020-02-17 15:42:53 +03:00
Nikolai Kochetov
34e32db810 Fix build. 2020-02-17 14:55:32 +03:00
Nikolai Kochetov
bbdac39d2d Fix build. 2020-02-17 14:50:53 +03:00
alesapin
0a5403185c Add test for parallel detach and fix some bugs. 2020-02-17 14:31:42 +03:00
Nikolai Kochetov
f4d5175a12 Fix build. 2020-02-17 14:26:09 +03:00
Pavel Kovalenko
f9965a7d29 Merge branch 'master' into storage-stripe-log-s3
# Conflicts:
#	dbms/tests/config/disks.xml
2020-02-17 13:46:06 +03:00
Nikolai Kochetov
4599fbd798 Added force_tree_shaped_pipeline flag to SelectQueryInfo. 2020-02-17 13:42:14 +03:00
Alexander Tokmakov
964b775c80 Merge branch 'master' into split_databases_from_context 2020-02-17 13:04:36 +03:00
Nikolai Kochetov
9b2d03f58c Fix StorageMerge. 2020-02-17 12:26:15 +03:00
alesapin
659fba4b97 Fix constraints 2020-02-17 11:57:59 +03:00
Alexey Milovidov
b88238dffc Added 9th reason why parts can appear to be non byte-identical after download 2020-02-17 08:16:48 +03:00
alexey-milovidov
41c883ace3
Merge pull request #8911 from millb/secure_password
Changed format for path in replicas
2020-02-16 07:17:12 +03:00
alexey-milovidov
6f51f089ec
Merge pull request #9138 from ClickHouse/system-replicas-add-zookeeper-exception-column
Add zookeeper_exception column to system.replicas table.
2020-02-16 06:14:22 +03:00
Alexey Milovidov
4ae404f794 Implement #9137 2020-02-15 03:13:00 +03:00
Alexey Milovidov
07479236d7 Implement #9137 2020-02-15 03:11:09 +03:00
alexey-milovidov
38c4f3ed84
Merge pull request #9131 from ClickHouse/better_temporary_live_view_syntax
Better CREATE syntax for temporary LIVE VIEW
2020-02-15 02:55:37 +03:00
alexey-milovidov
db1c67e3e3
Merge pull request #9100 from ClickHouse/issue-9094
Prevent abort on shutdown if the fs is readonly
2020-02-15 02:38:37 +03:00
CurtizJ
cb9936cbc4 better checking if we can use polymorphic parts 2020-02-15 00:33:02 +03:00
alesapin
88f46ac636 Add alters only for new mutations 2020-02-14 23:13:57 +03:00
Alexander Tokmakov
6889951396 better syntax for temporary LIVE VIEW 2020-02-14 21:20:20 +03:00
Nikolai Kochetov
1685c4d689 Fix build. 2020-02-14 20:50:27 +03:00
Nikolai Kochetov
52a63275ea Merge with master. 2020-02-14 20:47:39 +03:00
Pavel Kovalenko
06e203d004 StorageStripeLog S3 support. 2020-02-14 17:28:33 +03:00
alesapin
42d0e27bfa Fix tests and bugs 2020-02-14 16:17:50 +03:00
alesapin
39e79bb1a2 Remove header 2020-02-14 14:16:45 +03:00
alesapin
11f30dcc61 Remove more comments 2020-02-14 14:15:05 +03:00
Nikolai Kochetov
96b5ef8459 Processors support for StorageStripeLog reading. 2020-02-14 13:57:09 +03:00
alesapin
389292f579 Removed alter thread 2020-02-14 13:35:39 +03:00
alesapin
958e217499 Additional metadata 2020-02-14 13:34:54 +03:00
Nikolai Kochetov
0766e46bcd Fix StorageFile. 2020-02-14 13:22:05 +03:00
alesapin
527325ef46 Correct startup logic 2020-02-14 13:17:04 +03:00
CurtizJ
ddb3a55f67 Merge remote-tracking branch 'upstream/master' into polymorphic-parts 2020-02-14 13:15:16 +03:00
alesapin
d9ebec472b More simple 2020-02-14 12:24:00 +03:00
CurtizJ
7041e28077 fix segfault in MergeTreeRangeReader 2020-02-14 00:20:35 +03:00
alesapin
199c22c363 Better naming 2020-02-13 23:09:48 +03:00
alesapin
78d42142cf Better 2020-02-13 19:16:09 +03:00
alesapin
8c160c7905 Better 2020-02-13 17:48:38 +03:00
CurtizJ
6e1734f2d7 remove rarely used createPart overload 2020-02-13 17:42:48 +03:00
CurtizJ
64e1883c06 better replication with compact parts 2020-02-13 17:19:43 +03:00
Alexey Milovidov
b5c79201c3 Prevent abort on shutdown if the fs is readonly 2020-02-13 16:15:54 +03:00
alesapin
e1bc499ea8 Remove comments 2020-02-13 16:13:23 +03:00
alesapin
a6938cf5d9 Less verbose logging 2020-02-13 15:03:30 +03:00
alesapin
45ebf08925 Better 2020-02-13 14:38:04 +03:00
alesapin
e39b6dff54 Finally working code 2020-02-13 12:56:07 +03:00
Alexander Tokmakov
1d6afe9f39 Merge branch 'master' into split_databases_from_context 2020-02-12 21:18:32 +03:00
Alexander Tokmakov
b6039f8c50 remove tryGetExternalTable 2020-02-12 21:14:12 +03:00
Alexander Tokmakov
2e6796e7d7 move ViewDependencies to DatabaseCatalog 2020-02-12 19:54:26 +03:00
Mikhail Korotov
5bd74b464d Merge branch 'secure_password' of https://github.com/millb/ClickHouse into secure_password 2020-02-12 13:08:10 +03:00
millb
92fc1a9b2b fixed bugs 2020-02-12 13:06:09 +03:00
alesapin
526428ffe0 Better 2020-02-12 13:00:24 +03:00
Mikhail Korotov
01b03f9b1f Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into secure_password 2020-02-12 11:43:52 +03:00
CurtizJ
59c4f53fec fix polymorphic parts fetching 2020-02-12 02:29:34 +03:00
Alexander Kuzmenkov
413cb601dd
Merge pull request #8969 from filimonov/kafka_producer_with_key_and_timestamp
key and timestamp in Kafka producer
2020-02-11 22:03:37 +03:00
Ilya Yatsishin
5b4b04e13b
Merge pull request #9050 from CurtizJ/fix-range-reader
Fix order of ranges in MergeTreeDataSelectExecutor
2020-02-11 18:31:34 +03:00
alesapin
9e0d4b0bd4 Seems to work 2020-02-11 17:54:46 +03:00
CurtizJ
b26a8b5622 choose part type while selecting parts to merge 2020-02-11 16:41:26 +03:00
Mikhail Korotov
f8db74fca6 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into secure_password 2020-02-11 13:51:37 +03:00
CurtizJ
c72c38aea9 require strict part type in MergeTreeReaders 2020-02-10 23:30:49 +03:00
alesapin
260a4687f0 Something working 2020-02-10 19:55:09 +03:00
CurtizJ
90a121cc1e remove useless line 2020-02-10 19:34:47 +03:00
CurtizJ
852772364e replace std::vector to std::deque for MarkRanges 2020-02-10 19:04:24 +03:00
Artem Zuikov
bd6d9a427b
Some InterpreterSelectQuery refactoring (#9035)
move ExpressionActionsChain logic out of InterpreterSelectQuery
2020-02-10 18:50:12 +03:00
Alexander Tokmakov
869e20d207 move databases from Context to DatabaseCatalog 2020-02-10 17:49:44 +03:00
alesapin
2a866043aa some trash 2020-02-10 16:32:59 +03:00
tavplubix
4543177931 Merge pull request #9048 from ClickHouse/fix_mutation_order
Fix primary.idx corruption after delete mutation
2020-02-09 19:21:23 +03:00
alesapin
19de74d5bd Remove redundant lock 2020-02-09 11:52:42 +03:00
alesapin
2dca542d2e Correctly accuire lock 2020-02-09 11:42:15 +03:00
alesapin
5a96eaf0e8 Add missed locks for ReplicatedMergeTree alter 2020-02-08 16:39:44 +03:00
CurtizJ
b9fc9b4569 fix order of ranges in MergeTreeDataSelectExecutor 2020-02-08 00:07:18 +03:00
alesapin
f9d70e741f
Merge pull request #9047 from ClickHouse/fix_unit_tests
Fix unit tests
2020-02-07 21:30:09 +03:00
Nikita Mikhaylov
1324f3946e
Merge pull request #8988 from nvartolomei/nv/alter-mv-modify-query
Modify Materialized View query
2020-02-07 21:28:27 +03:00
alesapin
1ada6e663c Missed change 2020-02-07 16:56:57 +03:00
alesapin
dcfe6524e5 Fix unit tests 2020-02-07 12:51:48 +03:00
CurtizJ
2780250d05 better code near data part writer 2020-02-06 18:32:00 +03:00
Nicolae Vartolomei
0939a9460f Modify Materialized View query 2020-02-06 08:57:54 +00:00
alesapin
29a26a87b4 Merge pull request #9022 from ClickHouse/mutations_parts_to_do_fix
Fix mutations finalization task
2020-02-06 11:26:13 +03:00
zhang2014
784230b7a8 ISSUES-8971 fix non from 2020-02-06 08:30:14 +08:00
CurtizJ
db47ef923c fix prewhere 2020-02-05 19:42:27 +03:00
alesapin
1923930379 Fix mutations finalization task 2020-02-05 19:30:02 +03:00
zhang2014
16bb4e975d ISSUES-8971 support explain & view storage 2020-02-05 19:40:18 +08:00
alesapin
f8f615dfdb Debugging 2020-02-05 14:18:11 +03:00
zhang2014
b9443c98fe ISSUES-8971 fix view with predicate optimizer 2020-02-05 16:00:06 +08:00
Mikhail Filimonov
babd3ca34e Fixing test build, more review fixes 2020-02-05 08:05:55 +01:00
Mikhail Filimonov
8c736e6c9f After review fixes 2020-02-04 22:19:34 +01:00
CurtizJ
2f9f5dfc7a better initialization of MergedBlockOutputStream 2020-02-04 19:15:28 +03:00
CurtizJ
31c39c8137 fix mutations 2020-02-04 15:11:32 +03:00
Nikolai Kochetov
bc757f6b24 Processors support for StorageS3 reading. 2020-02-03 21:01:41 +03:00
alesapin
d8be70d709 Fix bug 2020-02-03 19:39:36 +03:00
CurtizJ
1785b27ae5 fix build 2020-02-03 19:37:00 +03:00
CurtizJ
a0635ed390 better marks reading 2020-02-03 19:02:54 +03:00
CurtizJ
257bb3b599 add comments near DataPart code 2020-02-03 15:08:40 +03:00
Nikolai Kochetov
a029e49438 Processors support for StorageNull reading. 2020-02-03 14:23:52 +03:00
Nikolai Kochetov
eae2ce194d Processors support for StorageNull reading. 2020-02-03 14:22:21 +03:00
CurtizJ
2d7ff400ed Merge remote-tracking branch 'upstream/master' into polymorphic-parts 2020-02-03 13:46:00 +03:00
Nikolai Kochetov
fde86203a7 Fix StorageJoin 2020-02-03 13:42:20 +03:00
Mikhail Korotov
bf3caa0373 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into secure_password 2020-02-03 13:08:20 +03:00
Mikhail Filimonov
24ff635435 draft implementation, wip 2020-02-03 11:02:52 +01:00
alesapin
5864cab472 Merge branch 'master' into alter_on_top_of_mutations 2020-02-03 12:09:19 +03:00
alexey-milovidov
c793f30873
Merge pull request #8954 from ClickHouse/os-thread-id
Use OS thread id everywhere instead of internal thread number.
2020-02-03 03:57:35 +03:00
alexey-milovidov
baf218b431
Merge pull request #8932 from 4ertus2/debt
Rename ANY INNER to SEMI JOIN for partial merge join
2020-02-03 01:53:52 +03:00
alexey-milovidov
bf4887a33d
Merge pull request #8822 from millb/Prohibition_secondary_index_with_old_format_merge_tree
Prohibition secondary index with old syntax merge tree
2020-02-03 00:04:04 +03:00
Alexey Milovidov
d11f3cb78f Changed thread_id to UInt64 to support more OS 2020-02-02 23:01:13 +03:00
chertus
d2e8b24970 better compatibility in EngineJoin 2020-02-02 19:12:48 +03:00
alesapin
0c37458b20 Add missed file 2020-02-02 11:45:09 +03:00
alexey-milovidov
55c5bdbace
Trigger CI 2020-02-02 05:49:36 +03:00
Alexey Milovidov
39b31907b5 Rename function #7477 2020-02-02 05:35:47 +03:00
Alexey Milovidov
f9eb4e79f6 Using OS tid everywhere #7477 2020-02-02 05:28:14 +03:00
alexey-milovidov
3a1e3f612e
Merge branch 'master' into idisk-seekable-readbuffer 2020-02-02 03:54:50 +03:00
alexey-milovidov
eeacc97d2f
Merge pull request #8852 from vitlibar/RBAC-4
RBAC-4
2020-02-02 03:35:31 +03:00
alesapin
46e31cd643 Some trash code 2020-02-01 23:33:36 +03:00
alesapin
bf883e5a91 Fix bug 2020-02-01 15:46:22 +03:00
alesapin
85d94194c8 Add additional check for metadata in zookeeper 2020-02-01 14:47:09 +03:00
alexey-milovidov
d20bae03fb
Merge pull request #8908 from azat/fixes
Tiny fixes
2020-01-31 23:22:30 +03:00
alesapin
75fe46523e Working sequential order 2020-01-31 22:30:33 +03:00
Vitaly Baranov
10c912dab2 Rewrite the User class to be controlled by AccessControlManager. 2020-01-31 20:27:32 +03:00
Vitaly Baranov
2aa58193c8 Check access rights via new interface. 2020-01-31 20:27:28 +03:00
Nikolai Kochetov
cef9db809f Processors support for StorageMySQL reading. 2020-01-31 19:46:27 +03:00
Nikolai Kochetov
dd888f59a7 Fix MemorySource. 2020-01-31 19:36:57 +03:00
Nikolai Kochetov
dbffabfd46 Processors support for StorageMerge reading. 2020-01-31 19:31:08 +03:00
Nikolai Kochetov
7bedce40ea Processors support for StorageMerge reading. 2020-01-31 19:29:40 +03:00
alexey-milovidov
c2c5b81b70
Merge pull request #8851 from excitoon-favorites/globss3
Added globs/wildcards for s3
2020-01-31 18:56:06 +03:00
alexey-milovidov
9eb01b16fd
Merge pull request #8913 from nvartolomei/nv/alter-mv-replace-v20.1
ALTER <materialized view name> MODIFY QUERY <select_query>
2020-01-31 18:44:32 +03:00
Nikolai Kochetov
dc96e6d1cf Processors support for StorageMemory reading. 2020-01-31 18:26:10 +03:00
Nikolai Kochetov
fc7839716f Processors support for StorageMaterializedView reading. 2020-01-31 18:16:06 +03:00
Nikolai Kochetov
046ff34525 Processors support for StorageLog reading. 2020-01-31 18:10:10 +03:00
Nikolai Kochetov
384e68d745 Processors support for StorageJoin reading. 2020-01-31 17:51:09 +03:00
Nikolai Kochetov
f9db37ebf7 Processors support for StorageInput reading. 2020-01-31 17:26:51 +03:00
Nikolai Kochetov
6870132713 Processors support for StorageHDFS reading. 2020-01-31 17:06:43 +03:00
Nikolai Kochetov
2d1f06a49f Processors support for StorageFile reading. 2020-01-31 16:12:11 +03:00
alesapin
01ff1c65e2 More flexible schema 2020-01-31 15:25:31 +03:00
Mikhail Korotov
14acdffb0e
Update DirectoryMonitor.cpp 2020-01-31 14:29:21 +03:00
Mikhail Korotov
5c5b76d2b0
Update DirectoryMonitor.cpp 2020-01-31 14:28:39 +03:00
millb
d05642575d fixed 2020-01-31 14:16:46 +03:00
millb
165afabdd2 second attempt 2020-01-31 12:22:30 +03:00
Nikolai Kochetov
0157de021a Processors support for StorageDistributed reading. 2020-01-31 11:54:57 +03:00
Nikolai Kochetov
240f1e3e96 Processors support for StorageDictionary. 2020-01-31 11:14:20 +03:00
Nikolai Kochetov
c5289212ca
Merge pull request #8902 from ClickHouse/storage-buffer-processors
Storage buffer processors
2020-01-31 10:46:16 +03:00
alexey-milovidov
d76d55335e
Merge pull request #8914 from bgiard/range_reader
Fix crash in corner case of MergeTreeRangeReader::ReadResult::shrink
2020-01-31 03:57:52 +03:00
alexey-milovidov
5d3c62cd52
Merge pull request #8917 from filimonov/kafka_fixes_part2
Kafka fixes part2
2020-01-31 03:55:46 +03:00
Mikhail Filimonov
a6e3265960 Kafka proper rebalances processing, controlled assignment, faster tests 2020-01-30 20:30:45 +01:00
Pavel Kovalenko
52db32fd5d Fixed reading from StorageLog table. 2020-01-30 22:30:42 +03:00
Pavel Kovalenko
9efda05839 StorageLog test with DiskLocal and DiskMemory. 2020-01-30 22:29:30 +03:00
alexey-milovidov
8f75797801
Merge pull request #8906 from zlobober/key_conditions
Extend KeyCondition interface so that it returns BoolMask.
2020-01-30 18:52:47 +03:00
Baudouin Giard
9216c5761c Fix crash in corner case of MergeTreeRangeReader::ReadResult::shrink
It looks like most times the original number of rows per granule is
pretty much consistent across all granules, except for the last one,
however there seems to be cases (Issue #7713) where that's not the case.

The only way I have to reproduce the crash involves using proprietary
data, and unfortunately I haven't been able to come up with a test case
that would highlight the problem - just like the person who opened issue
7713. I can't share my dataset.

Reading the code, it looks pretty obvious to me here - unless I'm
missing something, that the intention here is to copy the corresponding
granules to one another so it makes sense to index
rows_per_granule_original with the same variable as rows_per_granule.

Signed-off-by: Baudouin Giard <bgiard@bloomberg.net>
2020-01-30 15:40:48 +00:00
Nicolae Vartolomei
fd42d1ee87 ALTER <materialized view name> MODIFY QUERY <select_query>
Trying to resurrect https://github.com/ClickHouse/ClickHouse/pull/7533.
I'd like to get this PR in if we have an agreement on syntax and general
direction, after that I'll rebase actual alter functionality from above mentioned PR.
2020-01-30 14:12:49 +00:00
alesapin
d0e5243ad8 Send updates in entry 2020-01-30 15:54:52 +03:00
Nikolai Kochetov
3c4fe4f20e Fix StorageBuffer/ 2020-01-30 13:30:48 +03:00
alesapin
453be4c587 Removed changed node struct 2020-01-30 13:30:35 +03:00
Nikolai Kochetov
00546498b6 Fix StorageBuffer/ 2020-01-30 13:26:25 +03:00
Nikolai Kochetov
9eb97e6db2 Fix StorageBuffer/ 2020-01-30 13:22:59 +03:00
Vladimir Chebotarev
4b2eff8551 Added passing ttl info between replicas. 2020-01-30 13:21:40 +03:00
Nikolai Kochetov
5fd9db4370 Fix BufferSource. 2020-01-30 10:32:54 +03:00
Nikolai Kochetov
a5b016eb61 Fix BufferSource. 2020-01-30 10:28:49 +03:00
millb
f7ab01b746 Merge branch 'Prohibition_secondary_index_with_old_format_merge_tree' of https://github.com/millb/ClickHouse into Prohibition_secondary_index_with_old_format_merge_tree 2020-01-30 10:13:52 +03:00
millb
7e1a23d910 fixed 2020-01-30 10:13:09 +03:00
Vladimir Chebotarev
9706374066 Fixed error messages. 2020-01-30 09:17:55 +03:00
Azat Khuzhin
ca8d9ac7f8 Fix error message for force_optimize_skip_unused_shards 2020-01-30 09:01:54 +03:00
Maxim Akhmedov
fa16149e1a Fix style checks. 2020-01-30 02:36:39 +03:00
Maxim Akhmedov
2d3321e003 Extend KeyCondition interface so that it returns BoolMask. 2020-01-30 00:40:22 +03:00
Nikolai Kochetov
d1bc3513a2 Fix build. 2020-01-29 21:22:09 +03:00
Nikolai Kochetov
84a392402f Processors reading for StorageBuffer. 2020-01-29 21:14:40 +03:00
alesapin
0893f7d49c Mutate from alter metadata task 2020-01-29 20:28:39 +03:00
Nikolai Kochetov
57100fc962 Merge branch 'master' into storage-system-processors 2020-01-29 13:17:18 +03:00
Nikolai Kochetov
8ce6040306
Merge pull request #7796 from ClickHouse/processors-4.3
Processors and system.numbers
2020-01-29 13:11:13 +03:00
Azat Khuzhin
60d63081da Fix min_marks_for_seek for the data skipping indexes 2020-01-28 23:10:06 +03:00
alesapin
974e9a6b7a Broke things 2020-01-28 20:15:22 +03:00
Pavel Kovalenko
e0cd6b1073 Formatting issues. 2020-01-28 19:09:24 +03:00
Pavel Kovalenko
efeb9e92be StorageLog Gtest 2020-01-28 19:08:30 +03:00
Mikhail Filimonov
dc43728dea Test showing the problem with partial commit of polled batch + fix 2020-01-28 15:21:36 +01:00
alesapin
736711d21c Merge branch 'master' into alter_on_top_of_mutations 2020-01-28 17:10:34 +03:00
Mikhail Filimonov
5dafccf410 Test for flushing by time and by block size (+fix), one extra test for virual columns 2020-01-28 14:24:37 +01:00
Pavel Kovalenko
d4707ca911 Seek reworking. 2020-01-28 15:48:01 +03:00
alexey-milovidov
1f90d2f078
Merge pull request #8866 from achulkov2/issue-8865_unnamed_tuples_should_not_be_flattened
Issue 8865 unnamed tuples should not be flattened
2020-01-28 12:32:58 +03:00
alexey-milovidov
45dce57a8c
Merge pull request #8830 from zlobober/storage_properties
Explicitly specify storage features
2020-01-28 01:49:53 +03:00
achulkov2
b7c9075e53 Stop flattening unnamed nested tuples 2020-01-27 23:26:39 +03:00
Vladimir Chebotarev
533011a5f5 Minor review and style fixes. 2020-01-27 23:08:43 +03:00
Pavel Kovalenko
07755ec8f7 Merge branch 'master' into idisk-seekable-readbuffer
# Conflicts:
#	dbms/programs/server/config.xml
2020-01-27 21:45:53 +03:00
Pavel Kovalenko
abfacdaadc SeekableReadBuffer refactoring.
Store size and multiple references for S3 metadata file.
Log engine support for S3.
2020-01-27 21:44:30 +03:00
Maxim Akhmedov
2e9538f768 Another fix for tests. Better handling of MV. 2020-01-27 21:28:37 +03:00
Alexey Milovidov
390745cc81 Fixed the issue with too many open files when using StorageFile with globs 2020-01-27 21:26:58 +03:00
Alexey Milovidov
1ce32211cf Fixed the issue with too many open files when using StorageFile with globs 2020-01-27 21:25:54 +03:00
Alexey Milovidov
59ef3c8034 Fixed the issue with too many open files when using StorageFile with globs 2020-01-27 21:13:02 +03:00
Alexey Milovidov
a1f05d3a56 Fixed the issue with too many open files when using StorageFile with globs 2020-01-27 20:06:32 +03:00
Maxim Akhmedov
675d0f549f Add replication and deduplication properties. 2020-01-27 17:14:49 +03:00
Maxim Akhmedov
419f2c2c2b Fix segmentation fault. 2020-01-27 16:04:01 +03:00
Nikolai Kochetov
ef268d7016 Fix TablesBlockSource. 2020-01-27 16:00:18 +03:00
alexey-milovidov
4613615b4a
Merge pull request #8850 from excitoon-favorites/fixcolumns
Fixed `StorageInput::StorageInput` a little bit
2020-01-27 15:26:10 +03:00
CurtizJ
a5d9975e37 better checking if table has TTL 2020-01-27 14:53:50 +03:00
Vladimir Chebotarev
18804407aa Properly added _file and _path columns. 2020-01-27 13:22:49 +03:00
Vladimir Chebotarev
3d0d31f62a Fixed StorageInput::StorageInput a little bit. 2020-01-27 13:19:14 +03:00
Nikolai Kochetov
2c025a8bd1 Add progress. 2020-01-27 13:05:57 +03:00
Alexey Milovidov
5d52261266 Remove useless files 2020-01-26 18:25:58 +03:00
Vladimir Chebotarev
a7d05211c5 Added _file and _path columns. 2020-01-26 17:05:51 +03:00
Vladimir Chebotarev
61e80e4872 Attempt to add S3 globbing to StorageS3::read. 2020-01-26 16:12:15 +03:00
Vladimir Chebotarev
d2ccbcfb32 Attempt to add S3 globbing function. 2020-01-26 16:03:47 +03:00
alexey-milovidov
066b4e745c
Merge pull request #8402 from excitoon-favorites/atomicdelete
"Atomically" remove parts on destroy.
2020-01-26 04:08:13 +03:00
alexey-milovidov
2df93a6d21
Merge pull request #8756 from azat/distributed_storage_configuration
Multiple disks/volumes for storing data for send in Distributed engine
2020-01-26 02:19:28 +03:00
Maxim Akhmedov
382eed249f Fix style issue. 2020-01-26 00:33:32 +03:00
Vladimir Chebotarev
ca2d381743 Prettier removal of part data on destroy. 2020-01-26 00:27:46 +03:00
Vladimir Chebotarev
b35a6d1ce3 Got rid of ugly relative paths while deleting on destroy. 2020-01-26 00:27:46 +03:00
Vladimir Chebotarev
2d749630b7 Fixed temporary path for part being erased. 2020-01-26 00:27:46 +03:00
Vladimir Chebotarev
3f11569d94 "Atomically" remove parts on destroy. 2020-01-26 00:27:46 +03:00
Maxim Akhmedov
338bd3e919 Remove commented line. 2020-01-25 23:39:53 +03:00
Maxim Akhmedov
d6f72dc2ce Specify supported features for each storage engine, expose them via system.table_engines table, properly check feature support in storage factory. 2020-01-25 22:44:52 +03:00
Azat Khuzhin
e5a43d2751 Add ability to use multiple disks/volumes for Distributed engine
Now Distributed() has gain the 5-th argument -- policy name (for storing
data to send):

  CREATE TABLE foo (key Int) Engine=Distributed(test_shard_localhost, currentDatabase(), some_table, key%2, 'default');
2020-01-25 20:52:31 +03:00
alexey-milovidov
dc90d42e1e
Merge pull request #8305 from ClickHouse/Vxider-parallel-insert
Vxider parallel insert
2020-01-25 20:30:50 +03:00
alexey-milovidov
df4f0c7379
Merge pull request #8805 from azat/force_optimize_skip_unused_shards
force_optimize_skip_unused_shards setting to throw if skipping is not possible
2020-01-25 17:37:59 +03:00
Alexander Tokmakov
f9cfc6be3a fix LiveView dependencies 2020-01-25 01:51:23 +03:00
Nikolai Kochetov
302d6b55ca Fix build. 2020-01-24 21:33:47 +03:00
Nikolai Kochetov
7385d3f643 Processors for StorageSystemTables. 2020-01-24 21:25:21 +03:00
Nikolai Kochetov
d53aa80d83 Processors for StorageSystemStoragePolicies. 2020-01-24 21:17:02 +03:00
Azat Khuzhin
6939ffeabf force_optimize_skip_unused_shards setting to throw if skipping is not possible 2020-01-24 21:15:40 +03:00
Nikolai Kochetov
16106a03c6 Processors for StorageSystemReplicas. 2020-01-24 21:13:17 +03:00
Nikolai Kochetov
0e6362ef7f Processors for StorageSystemPartsBase. 2020-01-24 21:01:21 +03:00
Nikolai Kochetov
9a223a05a5 Processors for StorageSystemOne. 2020-01-24 20:57:27 +03:00
Nikolai Kochetov
ffa3b3c665 Processors for StorageSystemDisks and StorageSystemDetachedParts. 2020-01-24 20:49:14 +03:00
Mikhail Korotov
9e5a88ec89 Merge branch 'Prohibition_secondary_index_with_old_format_merge_tree' of https://github.com/millb/ClickHouse into Prohibition_secondary_index_with_old_format_merge_tree 2020-01-24 19:48:17 +03:00
millb
3299db778b changes applied 2020-01-24 19:47:05 +03:00
Nikolai Kochetov
c3d0c26659 Processors for SystemColumns. 2020-01-24 19:13:46 +03:00
Nikolai Kochetov
dc49635ed4 Processors for IStorageSystemOneBlock. 2020-01-24 18:42:31 +03:00
Nikolai Kochetov
61154da744 Processors for IStorageSystemOneBlock. 2020-01-24 18:32:17 +03:00
Nikolai Kochetov
cab636cb62 Merged with master. 2020-01-24 18:10:24 +03:00
CurtizJ
14f0b9e137 add query 'ALTER ... MATERIALIZE TTL' 2020-01-24 13:53:14 +03:00
Anton Popov
9fe94ca5f7
fix confusing logic (addition to #8800) 2020-01-24 13:47:19 +03:00
alexey-milovidov
de32863f73
Merge pull request #8791 from excitoon-favorites/fixdestructeddatapart
Fixed bug with `MergeTreeReadPool`
2020-01-24 06:37:18 +03:00
alexey-milovidov
105b61b2af
Merge pull request #8800 from CurtizJ/fix-alter-with-ttl
Fix alters if there is set TTL for table.
2020-01-24 06:30:45 +03:00
Nikolai Kochetov
4a4de82648 Merged with master 2020-01-23 18:44:26 +03:00
CurtizJ
b5d8baee71 fix alters if ttl is set 2020-01-23 16:04:06 +03:00
Vladimir Chebotarev
a362664cc1 Better handling of per_part_columns_lock. 2020-01-23 13:08:35 +03:00
Ivan
b80e3dcd46
Refactoring of replxx (#8748) 2020-01-23 11:18:19 +03:00
Pavel Kovalenko
dce424fe11 SeekableReadBuffer initial implementation. IDisk readFile should return SeekableBuffer. 2020-01-22 19:17:25 +03:00
CurtizJ
771e429d35 fix tests 2020-01-22 17:10:35 +03:00
Anton Popov
8183a79100
make all parts wide by default 2020-01-22 13:37:16 +03:00
Alexey Milovidov
5d33bedf80 Whitespace 2020-01-21 22:18:40 +03:00
alesapin
bef1eaeb98
Merge pull request #8753 from ClickHouse/fix_database_memory_wrong_data_path
Fix wrong data path in DatabaseMemory
2020-01-21 20:21:10 +03:00
CurtizJ
9275225527 Merge remote-tracking branch 'upstream/master' into polymorphic-parts 2020-01-21 17:21:52 +03:00
CurtizJ
6a29525fa3 add some comments 2020-01-21 14:56:01 +03:00
Alexander Tokmakov
cdfc17e9b1 check path in constructor 2020-01-21 14:11:11 +03:00
Nikolai Kochetov
c28e224e24
Merge pull request #8735 from ClickHouse/processors-5.12
Processors 5.12
2020-01-21 11:51:07 +03:00
Alexander Tokmakov
05c4405b65 fix 2020-01-20 23:08:47 +03:00
CurtizJ
d0731878c9 fix mutations 2020-01-20 22:00:11 +03:00
alesapin
47578b8dc1 Remove some garbage 2020-01-20 17:28:51 +03:00
Alexey Milovidov
09f3890b20 Merge branch 'master' into GrigoryPervakov-vfs-s3 2020-01-20 15:39:15 +03:00
alesapin
3716d4f7e3 Merge with master 2020-01-20 12:21:05 +03:00
Nikolai Kochetov
76171c7afc Do not add resize transform for SystemNumbers. 2020-01-20 10:24:28 +03:00
alexey-milovidov
c711ce500b
Merge pull request #8422 from excitoon-favorites/bettertestalterttl
Fixed `ALTER MODIFY TTL`
2020-01-19 04:53:11 +03:00
Alexey Milovidov
db1bb630e0 Fixed configuration of replxx 2020-01-19 03:23:35 +03:00
Alexey Milovidov
2d39e5ad8c Merging DiskS3 2020-01-19 02:18:23 +03:00
Alexey Milovidov
ae7b9a652b Merge branch 'vfs-s3' of https://github.com/GrigoryPervakov/ClickHouse into GrigoryPervakov-vfs-s3 2020-01-19 01:12:05 +03:00
alexey-milovidov
7583f8744a
Merge branch 'master' into bettertestalterttl 2020-01-19 01:03:25 +03:00
alexey-milovidov
52e8252653
Merge pull request #8650 from ClickHouse/remove_istorage_weak_ptr
Get rid of StorageWeakPtr
2020-01-18 20:28:53 +03:00
alexey-milovidov
3f3a9e69b0
Merge pull request #8672 from excitoon/patch-7
Fixed `MergeTreeData::areBackgroundMovesNeeded` according to move TTL feature
2020-01-18 20:20:00 +03:00
alexey-milovidov
85f395a8ee
Merge pull request #8680 from excitoon-favorites/criticalbugwithmove
Fixed a bug with double move which corrupt original part
2020-01-18 20:19:03 +03:00
Alexey Milovidov
f7efa5e2c7 Merge branch 'replxx' of https://github.com/abyss7/ClickHouse into abyss7-replxx 2020-01-18 17:00:59 +03:00
alesapin
be5fb9a517 Less comments 2020-01-17 23:55:31 +03:00
alesapin
fa5aa5fe6a Remove debug print 2020-01-17 22:09:22 +03:00
alesapin
795f36b110 Better defaults 2020-01-17 18:46:26 +03:00
alesapin
d2e9ed3898 Commented tons of debug prints 2020-01-17 17:48:56 +03:00
alesapin
750b9d9e55 Fix very strange bug 2020-01-17 17:39:18 +03:00
CurtizJ
b0906abb0d code cleanup 2020-01-17 16:56:37 +03:00
alesapin
58b9e73a7a Better working on files names 2020-01-17 16:54:22 +03:00
Vladimir Chebotarev
e7fb7d1288 Improved areBackgroundMovesNeeded() method. 2020-01-17 16:30:54 +03:00
Vladimir Chebotarev
0ba869a1ca Fixed MergeTreeData::areBackgroundMovesNeeded according to move TTL feature. 2020-01-17 16:24:44 +03:00
Vladimir Chebotarev
cb416b0bfd Minor review fixes. 2020-01-17 16:17:17 +03:00
Vladimir Chebotarev
4f1f9e7e42 Fixed concurrency problems in ALTER MODIFY TTL. 2020-01-17 16:17:17 +03:00
Vladimir Chebotarev
585e0453a6 Added clearing of old DELETE expression during ALTER MODIFY TTL. 2020-01-17 16:17:17 +03:00
Vladimir Chebotarev
17dfea217b Fixed errors with ALTER MODIFY TTL. 2020-01-17 16:17:17 +03:00
Pervakov Grigory
b0b3842b57 Add remove to IDisk interface, fix issues 2020-01-17 14:34:39 +03:00
Pervakov Grigory
70e50ecf10 Base implementation of IDisk interafce for S3 2020-01-17 14:34:39 +03:00
CurtizJ
2797873921 code cleanup 2020-01-16 19:19:03 +03:00
alesapin
d39f1a0fce Better nested handling 2020-01-16 17:18:09 +03:00
Vladimir Chebotarev
48855d9ba9 Added comment to cloned_part->renameTo(). 2020-01-16 14:52:43 +03:00
alexey-milovidov
f4dee9a76e
Merge pull request #8666 from ClickHouse/filimonov-typo-fix
typo fix
2020-01-16 13:24:00 +03:00
Vladimir Chebotarev
3e5a6aa83d Fixed a bug with double move which corrupt original part. 2020-01-16 10:11:55 +03:00
CurtizJ
7a549b2734 implement 'checkConsistency' method in compact parts 2020-01-15 22:16:56 +03:00
CurtizJ
3ff8f424ed remove almost useless columns sizes from compact parts 2020-01-15 21:24:10 +03:00
CurtizJ
b3bd306a5d improve performance of compact parts 2020-01-15 19:39:29 +03:00
CurtizJ
27750f0cd4 Merge remote-tracking branch 'upstream/master' into polymorphic-parts 2020-01-15 19:36:35 +03:00
alesapin
2a8873a9b7 Better 2020-01-15 19:18:11 +03:00
alesapin
92648955c4 Almost working drop 2020-01-15 16:47:00 +03:00
filimonov
681f5df66f
typo fix 2020-01-15 14:30:21 +01:00
alesapin
2abf4bbc95 Not working state 2020-01-15 16:00:08 +03:00
Alexander Tokmakov
5e2badd9b8 Merge branch 'master' into table_name_in_istorage 2020-01-15 14:55:20 +03:00
Olga Khvostikova
53ae368d9c
Add virtual columns to hdfs and file table functions (#8489)
* Add virtual column _path to hdfs and file table functions with test

* Fix const of headers

* Add column _file with tests

* Add docs

* Fix improper resolve conflicts

* Fix links in docs

* Better condition for virtual columns proccessing in StorageFile

* better condition for virtual columns processing in StorageHDFS
2020-01-15 10:52:45 +03:00
Nikita Mikhaylov
0e0dd80abf
Merge pull request #6168 from PerformanceVision/move_partition
Alter command for move a specific partition from MergeTree table
2020-01-14 22:32:10 +04:00
Alexander Tokmakov
9521b0ebe5 remove proxystorage 2020-01-14 20:10:19 +03:00
Alexander Tokmakov
ff1b7e1386 get rid of StorageWeakPtr 2020-01-14 19:54:25 +03:00
CurtizJ
ce914cbab8 refactor code near MergeTreeDataPart 2020-01-14 16:23:51 +03:00
alesapin
e7aa209bf3 Merge branch 'master' into alter_on_top_of_mutations 2020-01-14 11:26:27 +03:00
robot-clickhouse
e8e820cfd4 Auto version update to [20.2.1.1] [54432] 2020-01-13 22:21:08 +03:00
Nikolai Kochetov
bcc0cd8e47 Fix build. 2020-01-13 21:25:10 +03:00
CurtizJ
18eacfe721 ignore compact parts in MergeTreeWhereOptimizer 2020-01-13 21:12:53 +03:00