Commit Graph

53473 Commits

Author SHA1 Message Date
Nikita Mikhaylov
8fef0b71c4
Merge pull request #60350 from ClickHouse/revert-54901-pufit/views-sql-security
Revert "Add definers for views"
2024-02-23 15:15:36 +01:00
Igor Nikonov
90b1f8544a
Merge pull request #60227 from ClickHouse/fix-clone-ast-for-rename
Fix: IAST::clone() for RENAME
2024-02-23 14:48:14 +01:00
Alexander Tokmakov
32607cc796
Merge pull request #60159 from ClickHouse/fix_create_replica
Skip sanity checks on secondary CREATE query
2024-02-23 13:53:47 +01:00
Sergei Trifonov
2c766cf75f
Merge pull request #59507 from ClickHouse/alter-table-forget-partition
Add `FORGET PARTITION` query to remove old partition nodes from ZooKeeper
2024-02-23 12:55:08 +01:00
Raúl Marín
464b5e0e15
Revert "Add definers for views (#54901)"
This reverts commit 57306706b3.
2024-02-23 12:44:31 +01:00
Vitaly Baranov
db119eed49
Merge pull request #60002 from vitlibar/add-config-setting-remove-backup-files-after-failure
Add new config setting "backups.remove_backup_files_after_failure"
2024-02-23 12:42:55 +01:00
Kseniia Sumarokova
6a7fef13ba
Merge pull request #60282 from ClickHouse/s3queue-fix-bug-and-flaky-test
s3queue: fix bug (also fixes flaky test_storage_s3_queue/test.py::test_shards_distributed)
2024-02-23 11:57:34 +01:00
Robert Schulze
e325afa350
Merge pull request #59551 from jinjunzh/iaadeflate_upgrade_qpl_v1.4.0
Upgrade QPL to v1.4.0+Fix qpl_deflate codec bug for polling timeout
2024-02-23 11:24:06 +01:00
Raúl Marín
1a4b4d493f
Merge pull request #60228 from Algunenano/parallel_replicas_2
Treat 2+ in allow_experimental_parallel_reading_from_replicas as 2
2024-02-23 11:17:23 +01:00
Robert Schulze
38d4d1fb57
Merge remote-tracking branch 'ClickHouse/master' into iaadeflate_upgrade_qpl_v1.4.0 2024-02-23 10:01:01 +00:00
Antonio Andelic
7ea44f95e3
Merge pull request #60226 from ClickHouse/keeper-better-snapshot
Slightly better Keeper loading from snapshot
2024-02-23 08:49:15 +01:00
Igor Nikonov
8f3ca99cfc
Merge pull request #60252 from ClibMouse/bugfix/http-exception-codes
Fix http exception codes.
2024-02-22 19:17:51 +01:00
János Benjamin Antal
7cad0050c0
Disambiguate alter commands list (#59532)
* Add optional parentheses to TTL element and alter command

* Add some basic tests

* Extend tests with more test cases

* Add one more test case

* Add server setting to control new formatting behavior

* Automatic style fix

* Fix segfault in `clickhouse-format` related to new server setting

* Remove format_ttl_expressions_with_parentheses

* Fix unit test compilation failures

* Introduce global flag to control the new formatting behavior

* Revert "Fix segfault in `clickhouse-format` related to new server setting"

This reverts commit d7131a3145.

* Revert accidental changes

* Revert accidental include reorder

* Revert accidental changes

* Enable new format in client and local server

---------

Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
2024-02-22 19:17:15 +01:00
Alexander Tokmakov
e56748a92c
Merge pull request #60044 from ClickHouse/fix_undead_sessions
Ability to detect undead ZooKeeper sessions
2024-02-22 18:13:15 +01:00
Vitaly Baranov
b130726a0c
Merge branch 'master' into add-config-setting-remove-backup-files-after-failure 2024-02-22 18:09:12 +01:00
pufit
57306706b3
Add definers for views (#54901) 2024-02-22 17:47:50 +01:00
Alexander Tokmakov
97ed2c05b0 Merge branch 'master' into fix_undead_sessions 2024-02-22 14:36:36 +01:00
Nikolai Kochetov
c3f925da0a
Merge pull request #60164 from kitaisreal/copy-s3-file-gcp-fallback-to-buffer-copy
Copy S3 file GCP fallback to buffer copy
2024-02-22 12:53:15 +01:00
Nikolai Kochetov
0e6b55ad35
Merge pull request #60220 from kitaisreal/system-backups-system-backup-log-add-query-id-and-error-stacktrace
Tables system.backups and system.backup_log add query_id and error stacktrace
2024-02-22 12:43:52 +01:00
kssenii
222323f293 Fix 2024-02-22 12:38:13 +01:00
Kseniia Sumarokova
fb7924cdb1
Merge pull request #60233 from ClickHouse/hide-sensitive-info-in-s3-queue
Hide sensitive info for s3queue
2024-02-22 11:37:15 +01:00
Robert Schulze
ae597d86dd
Merge remote-tracking branch 'rschu1ze/master' into vector-dot-product 2024-02-22 10:16:28 +00:00
Robert Schulze
d638820478
Merge remote-tracking branch 'ClickHouse/master' into iaadeflate_upgrade_qpl_v1.4.0 2024-02-22 10:07:49 +00:00
Azat Khuzhin
a4f765cae7
Improve performance of SELECTs with active mutations (#59531)
* Configure keeper for perf tests

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Improve performance of SELECTs with active mutations

getAlterMutationCommandsForPart() can be a hot path for query execution
when there are pending mutations.

- LOG_TEST - it is not only check one bool, but actually a bunch of
  atomics as well.

- Return std::vector over std::map (map is not required there) - no
  changes in performance.

- Copy only RENAME_COLUMN (since only this mutation is required by
  AlterConversions).

And here are results:

run|result
-|-
SELECT w/o ALTER|queries: 1565, QPS: 355.259, RPS: 355.259
SELECT w/ ALTER unpatched|queries: 2099, QPS: 220.623, RPS: 220.623
SELECT w/ ALTER and w/o LOG_TEST|queries: 2730, QPS: 235.859, RPS: 235.859
SELECT w/ ALTER and w/o LOG_TEST and w/ RENAME_COLUMN only|queries: 2995, QPS: 290.982, RPS: 290.982

But there are still room for improvements, at least MergeTree engines
could implement getStorageSnapshotForQuery().

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Add AlterConversions::supportsMutationCommandType(), flatten vector<vector<MutationCommand>>

* Work around what appears to be a clang static analysis bug

---------

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Co-authored-by: Michael Kolupaev <michael.kolupaev@clickhouse.com>
2024-02-22 08:51:10 +00:00
Antonio Andelic
1b238d1180
Merge pull request #59460 from ClickHouse/keeper-logs-cache
Keeper log cache
2024-02-22 09:03:41 +01:00
kothiga
0bc7c0a558
Addressing feedback. 2024-02-21 17:01:16 -08:00
Alexander Tokmakov
64a80f1011
Fix default path when path is not specified in config (#59654)
* Update Server.cpp

* Update SentryWriter.cpp

* Update Keeper.cpp

* Update SentryWriter.cpp
2024-02-21 20:33:39 +01:00
Raúl Marín
453d4d30cf
Revert "Support resource request canceling" 2024-02-21 20:19:00 +01:00
Alexander Tokmakov
fcfea17657
Update gtest_storage_log.cpp 2024-02-21 20:16:14 +01:00
kothiga
692b31e467
Fix http exception codes. 2024-02-21 10:53:49 -08:00
Nikolai Kochetov
0e9d7f3540
Merge pull request #60037 from ClickHouse/fix-01656_test_query_log_factories_info-for-analyzer
Fix 01656_test_query_log_factories_info with analyzer.
2024-02-21 17:37:15 +01:00
Robert Schulze
3e9a05d1ad
Minor fixups 2024-02-21 16:24:22 +00:00
Robert Schulze
310aff9b6f
Merge remote-tracking branch 'ClickHouse/master' into iaadeflate_upgrade_qpl_v1.4.0 2024-02-21 16:22:32 +00:00
Antonio Andelic
0b58aa6ec3 better 2024-02-21 17:08:44 +01:00
kssenii
c05c3944d1 Hide sensitive info for s3queue 2024-02-21 16:49:53 +01:00
Sergei Trifonov
19e81c20ca
Merge pull request #59032 from ClickHouse/cpu-scheduler-and-cc
Support resource request canceling
2024-02-21 16:16:24 +01:00
serxa
69c5fae1bc review fixes 2024-02-21 15:11:50 +00:00
Maksim Kita
5ba371662f Backups delete suspicious file 2024-02-21 18:10:27 +03:00
Igor Nikonov
7411e81bec Fix style 2024-02-21 15:00:25 +00:00
serxa
8b7ef7c895 assert is not needed 2024-02-21 14:53:19 +00:00
Raúl Marín
b71bdbae1b Treat 2+ in allow_experimental_parallel_reading_from_replicas as 2 2024-02-21 15:33:37 +01:00
Igor Nikonov
a0105e94ba
Merge pull request #60077 from ClickHouse/cleanup-connection-pool-priority
Cleanup: less confusion between config priority and balancing priority in connection pools
2024-02-21 15:22:08 +01:00
serxa
1ac94813ed review fixes 2024-02-21 14:14:45 +00:00
Igor Nikonov
f4643b8341 Fix: RENAME AST clone
+ minor cleanup
2024-02-21 14:14:33 +00:00
serxa
f92ec2cd5d Merge branch 'master' into cpu-scheduler-and-cc 2024-02-21 14:05:37 +00:00
serxa
bf90da7057 Merge branch 'master' into cpu-scheduler-and-cc 2024-02-21 14:05:01 +00:00
Sergei Trifonov
6e3fddf4a3
Merge pull request #59313 from ClickHouse/abstract-concurrency-control
Split `ISlotControl` from `ConcurrencyControl`
2024-02-21 15:04:03 +01:00
Kruglov Pavel
10535132c3
Merge pull request #59385 from Avogar/fix-bad-types-check
Fix validating suspicious/experimental types in nested types
2024-02-21 14:38:01 +01:00
Antonio Andelic
033cbab8f3 Merge branch 'master' into keeper-better-snapshot 2024-02-21 14:01:37 +01:00
Vitaly Baranov
be43237cfc Use scheduleFromThreadPool() to simplify the code in BackupsWorker. 2024-02-21 13:00:45 +01:00