Commit Graph

63533 Commits

Author SHA1 Message Date
Azat Khuzhin
f1aebbe927 Check that totals correctly calculated in 01865_aggregator_overflow_row
Change aggregation function to uniqCombined() to check this.
2021-05-08 20:43:01 +03:00
Maksim Kita
7c948139fc
Merge pull request #23959 from divanorama/patch-1
Don't try GLIBC_COMPATIBILITY for i686 Linux
2021-05-08 19:24:41 +03:00
Maksim Kita
0a2ea38cc9
Merge pull request #23916 from azat/dict-found_rate
Measure found rate for dictionaries
2021-05-08 19:23:52 +03:00
Alexey Milovidov
ad88819ee4 Fix a bunch of warnings from PVS-Studio 2021-05-08 19:13:10 +03:00
Alexey Milovidov
f805f4aa4f Fix error found by PVS-Studio 2021-05-08 19:13:00 +03:00
Alexey Milovidov
3025f9e141 More fixes for PVS-Studio 2021-05-08 19:12:49 +03:00
Alexey Milovidov
e905883c75 More fixes for PVS-Studio 2021-05-08 19:12:31 +03:00
Alexey Milovidov
022667a190 Fix some PVS-Studio warnings 2021-05-08 19:12:19 +03:00
Alexey Milovidov
8d62c42eb9 A bunch of changes for PVS-Studio 2021-05-08 19:11:50 +03:00
Alexey Milovidov
bdc372cb9a Fix bad code (found by PVS-Studio) 2021-05-08 19:11:40 +03:00
Alexey Milovidov
8b9c058141 Fix bad code in Keeper (found by PVS-Studio) 2021-05-08 19:11:31 +03:00
Alexey Milovidov
241c7a94da Fix bad code in Keeper (found by PVS-Studio) 2021-05-08 19:11:08 +03:00
Alexey Milovidov
7ca0f46708 Add suppressions for PVS-Studio 2021-05-08 19:10:56 +03:00
Alexey Milovidov
78a2df5900 Fix low quality code in Qualtile (found by PVS-Studio) 2021-05-08 19:10:38 +03:00
Alexey Milovidov
125b2ab214 Suppressions for PVS-Studio 2021-05-08 19:10:23 +03:00
Alexey Milovidov
604daa9581 Fix a bunch of warnings from PVS-Studio 2021-05-08 19:09:17 +03:00
Maksim Kita
9b405b4c07 Fixed FunctionComparison for constants 2021-05-08 18:47:08 +03:00
Alexey Milovidov
f59c55abb5 Fix error found by PVS-Studio 2021-05-08 18:35:38 +03:00
Alexey Milovidov
45dea86395 More fixes for PVS-Studio 2021-05-08 18:35:09 +03:00
Alexander Kuzmenkov
308c4657ce support longer query ids in trace log for perf tests 2021-05-08 18:20:42 +03:00
Alexey Milovidov
2fbecf36ca More fixes for PVS-Studio 2021-05-08 18:20:40 +03:00
Azat Khuzhin
69e395bede Round floats in AggregatingTransform log messages 2021-05-08 18:01:57 +03:00
Azat Khuzhin
6b11319cdf Round floats in Aggregator log messages 2021-05-08 18:01:24 +03:00
Alexey Milovidov
3e8deef6fe Fix some PVS-Studio warnings 2021-05-08 17:54:08 +03:00
Azat Khuzhin
21f08a1aa9 Use 0 over nan for hit_rate in case of 0 queries to the cache dictionary 2021-05-08 17:51:22 +03:00
Azat Khuzhin
4cecc238d6 Fix SIGSEGV for external GROUP BY and overflow row
Overflow row is used for GROUP BY if all of the above is true:
- WITH TOTALS is requested
- max_rows_to_group_by > 0
- group_by_overflow_mode = any
- totals_mode != after_having_exclusive

And in case of overflow row and external GROUP BY, once the temporary
file dumps to disk it resets without_key data variant to nullptr, so any
subsequent dump to disk will cause SIGSEGV.

Fix this, by recreating without_key data variant after dumping to disk,
instead of reseting to nullptr.

And also add sanity check (LOGICAL_ERROR) to make error more
deterministic in case of such error.

Found with fuzzer [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/23929/e7027e052998540ee660d186727e20f9555b729d/fuzzer_ubsan/report.html#fail1
2021-05-08 17:48:24 +03:00
Alexey Milovidov
9e1a5f41fc A bunch of changes for PVS-Studio 2021-05-08 17:43:03 +03:00
Maksim Kita
1bb4988b1f Fixed FunctionsComparison constant result with non constant arguments 2021-05-08 17:39:35 +03:00
Maksim Kita
4cd097b983 Fixed config.xml 2021-05-08 17:39:35 +03:00
Maksim Kita
6dc0dcdfa4 Fixed code review issues 2021-05-08 17:39:35 +03:00
Maksim Kita
dd44d93f49 Fixed compile expressions 2021-05-08 17:39:35 +03:00
alexey-milovidov
b76503a4ea Update ActionsDAG.cpp 2021-05-08 17:39:35 +03:00
Maksim Kita
21d8684aaf Added CHJIT documentation 2021-05-08 17:39:35 +03:00
Maksim Kita
57d5f55d7f Added jit if test 2021-05-08 17:39:35 +03:00
Maksim Kita
050cb74ed0 Fix compiled if statement 2021-05-08 17:39:35 +03:00
Maksim Kita
8df4e866f3 Fixed clickhouse-client log 2021-05-08 17:39:35 +03:00
Maksim Kita
72d610be2e Updated CHJIT interface to be more thread safe 2021-05-08 17:39:35 +03:00
Maksim Kita
7778172a1f Fixed compilable function 2021-05-08 17:39:35 +03:00
Maksim Kita
4db7e49ccf Fixed Date, DateTime native type 2021-05-08 17:39:35 +03:00
Maksim Kita
16a07f61ae Refactored CompileDAG build algorithm 2021-05-08 17:39:35 +03:00
Maksim Kita
8828599380 Fixed style check 2021-05-08 17:39:35 +03:00
Maksim Kita
c79d7eae21 Refactored interfaces 2021-05-08 17:39:35 +03:00
Maksim Kita
24798ef07c Updated interfaces 2021-05-08 17:39:34 +03:00
Maksim Kita
d2eecfe593 Updated Nullable default implementation 2021-05-08 17:39:34 +03:00
Maksim Kita
8d6c282e0a Fixed test 2021-05-08 17:39:34 +03:00
Maksim Kita
af06f5b68b Fixed UUID test 2021-05-08 17:39:34 +03:00
Maksim Kita
97d87eb518 Fixed JITMemoryManager 2021-05-08 17:39:34 +03:00
Maksim Kita
e40aa26611 Fixed MSan 2021-05-08 17:39:34 +03:00
Maksim Kita
baf1978124 CHJIT updated thread safe interface 2021-05-08 17:39:34 +03:00
Maksim Kita
2b58357a77 Fixed tests 2021-05-08 17:39:34 +03:00