thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-24 08:32:02 +00:00
Code Issues Packages Projects Releases Wiki Activity
133,420 Commits 9,168 Branches 1,781 Tags 2.1 GiB
94770f8d8a
Commit Graph

133420 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
UnamedRus
94770f8d8a
Merge branch 'master' into topk-statistics-count-errors 2024-01-28 20:50:45 +03:00
Alexey Milovidov
45cb7094af
Merge pull request #59303 from ClickHouse/play-rendering-errors-json 
Play UI: improve rendering of errors from JSON formats
 2024-01-28 18:32:27 +01:00
Alexey Milovidov
31032104eb
Merge pull request #59306 from ClickHouse/no-debug-rust 
No debug symbols in Rust
 2024-01-28 18:20:11 +01:00
Alexey Milovidov
34ddf3db04
Merge pull request #59307 from p1rattttt/fix-rust 
Fix architecture name in select of Rust target
 2024-01-28 17:47:59 +01:00
Max Kainov
d36c92a219 CI: Add rust dir to build digest 2024-01-28 15:09:39 +00:00
Maksim Alekseev
b3b2b7a1e6 Fix architecture name in select of Rust target 2024-01-28 17:29:08 +03:00
Alexey Milovidov
27cd218483 No debug symbols in Rust 2024-01-28 15:10:57 +01:00
Alexey Milovidov
9dd6362ae7 Play UI: improve rendering of errors from JSON formats 2024-01-28 13:44:56 +01:00
Alexey Milovidov
29d54dab55
Merge pull request #59288 from azat/rmt/drop-update-zk 
Use fresh ZooKeeper client on DROP (to have higher chances on success)
 2024-01-28 13:16:21 +01:00
Alexey Milovidov
7a5dddf202
Merge pull request #59292 from ClickHouse/Fix_possible_seg_fault_check_engine 
Fix possible seg fault
 2024-01-28 13:14:15 +01:00
robot-ch-test-poll4
c0fc804797
Merge pull request #59289 from ClickHouse/melvynator-exp-rmv 
Update view.md
 2024-01-28 00:17:56 +01:00
robot-clickhouse
ac6d2c4f34
Merge pull request #59281 from ClickHouse/fix-doc-remove-ex-flag 
Update view.md
 2024-01-28 00:17:16 +01:00
Alexey Milovidov
c7289f69ed
Merge pull request #59287 from azat/tests/fix-perf 
Fix perf tests (after sumMap starts to filter out -0.)
 2024-01-27 22:56:32 +01:00
Smita Kulkarni
b7a6dbfbb9 Check engine to avoid possible seg fault 2024-01-27 18:22:37 +01:00
Peignon Melvyn
cf1df96cc1
Update view.md 
Improved documentation.
 2024-01-27 17:27:00 +01:00
Azat Khuzhin
d94547d338 Use fresh ZooKeeper client on DROP (to have higher chances on success) 
In case of DROP the client can be expired, and even though
StorageReplicatedMergeTree::drop() uses getZooKeeperIfTableShutDown(),
which creates new client if current is expired, it is not enough, since
current_zookeeper (cached client) will be used implicitly from
dropAllData().

This had been found by stress tests, that leads to DROP query hang [1].

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/59255/94eb33ef27a9ab7c4a99af40772ea287e67efcbf/stress_test__tsan_.html

<details>

<summary>stacktrace</summary>

    2024.01.26 17:41:41.138577 [ 3319 ] {} <Error> DatabaseCatalog: Cannot drop table test_vzfk1xoc.alter_table1 (455a674c-161d-44d8-abc2-fd205bad1116). Will retry later.: Code: 999. Coordination::Exception: Session expired. (KEEPER_EXCEPTION), Stack trace (when copying this message, always include the lines below):

    0. ./contrib/llvm-project/libcxx/include/exception:134: Poco::Exception::Exception(String const&, int) @ 0x000000001e06a5e3 in /usr/bin/clickhouse
    1. ./build_docker/./src/Common/Exception.cpp:96: DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000000f697c74 in /usr/bin/clickhouse
    2. ./src/Common/Exception.h:0: Coordination::Exception::Exception<char const (&) [16]>(char const (&) [16], Coordination::Error) @ 0x000000001adc298b in /usr/bin/clickhouse
    3. ./src/Common/ZooKeeper/IKeeper.h:0: Coordination::ZooKeeper::pushRequest(Coordination::ZooKeeper::RequestInfo&&) @ 0x000000001adfb418 in /usr/bin/clickhouse
    4. ./build_docker/./src/Common/ZooKeeper/ZooKeeperImpl.cpp:1343: Coordination::ZooKeeper::get(String const&, std::function<void (Coordination::GetResponse const&)>, std::shared_ptr<std::function<void (Coordination::WatchResponse const&)>>) @ 0x000000001adfd8e5 in /usr/bin/clickhouse
    5. ./contrib/llvm-project/libcxx/include/__functional/function.h:818: ? @ 0x000000001ad890bd in /usr/bin/clickhouse
    6. ./contrib/llvm-project/libcxx/include/__functional/function.h:818: ? @ 0x000000001ad88a36 in /usr/bin/clickhouse
    7. ./build_docker/./src/Common/ZooKeeper/ZooKeeper.cpp:580: zkutil::ZooKeeper::tryGetWatch(String const&, String&, Coordination::Stat*, std::function<void (Coordination::WatchResponse const&)>, Coordination::Error*) @ 0x000000001ad898bf in /usr/bin/clickhouse
    8. ./build_docker/./src/Common/ZooKeeper/ZooKeeper.cpp:570: zkutil::ZooKeeper::tryGet(String const&, String&, Coordination::Stat*, std::shared_ptr<Poco::Event> const&, Coordination::Error*) @ 0x000000001ad89554 in /usr/bin/clickhouse
    9. ./build_docker/./src/Common/ZooKeeper/ZooKeeperWithFaultInjection.cpp:0: DB::ZooKeeperWithFaultInjection::tryGet(String const&, String&, Coordination::Stat*, std::shared_ptr<Poco::Event> const&, Coordination::Error*) @ 0x000000001ae110dc in /usr/bin/clickhouse
    10. ./contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:701: DB::StorageReplicatedMergeTree::unlockSharedDataByID(String, String const&, DB::MergeTreePartInfo const&, String const&, String const&, std::shared_ptr<DB::ZooKeeperWithFaultInjection> const&, DB::MergeTreeSettings const&, std::shared_ptr<Poco::Logger>, String const&, StrongTypedef<unsigned int, DB::MergeTreeDataFormatVersionTag>) @ 0x000000001975527e in /usr/bin/clickhouse
    11. ./build_docker/./src/Storages/StorageReplicatedMergeTree.cpp:0: DB::StorageReplicatedMergeTree::removeSharedDetachedPart(std::shared_ptr<DB::IDisk>, String const&, String const&, String const&, String const&, String const&, std::shared_ptr<DB::Context const> const&, std::shared_ptr<zkutil::ZooKeeper> const&) @ 0x000000001976c980 in /usr/bin/clickhouse
    12. ./build_docker/./src/Storages/StorageReplicatedMergeTree.cpp:10171: DB::StorageReplicatedMergeTree::removeDetachedPart(std::shared_ptr<DB::IDisk>, String const&, String const&) @ 0x000000001976bdc6 in /usr/bin/clickhouse
    13. ./build_docker/./src/Storages/MergeTree/MergeTreeData.cpp:2798: DB::MergeTreeData::dropAllData() @ 0x0000000019c643c8 in /usr/bin/clickhouse
    14. ./build_docker/./src/Storages/StorageReplicatedMergeTree.cpp:1117: DB::StorageReplicatedMergeTree::drop() @ 0x0000000019664e0a in /usr/bin/clickhouse
    15. ./build_docker/./src/Interpreters/DatabaseCatalog.cpp:0: DB::DatabaseCatalog::dropTableFinally(DB::DatabaseCatalog::TableMarkedAsDropped const&) @ 0x0000000017bf1fac in /usr/bin/clickhouse
    16. ./build_docker/./src/Interpreters/DatabaseCatalog.cpp:0: DB::DatabaseCatalog::dropTableDataTask() @ 0x0000000017bf175e in /usr/bin/clickhouse
    17. ./contrib/llvm-project/libcxx/include/__functional/function.h:717: ? @ 0x0000000017bf94c2 in /usr/bin/clickhouse
    18. ./contrib/llvm-project/libcxx/include/__functional/function.h:0: ? @ 0x00000000170bd0b8 in /usr/bin/clickhouse
    19. ./contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:701: DB::BackgroundSchedulePool::threadFunction() @ 0x00000000170c06ce in /usr/bin/clickhouse
    20. ./build_docker/./src/Core/BackgroundSchedulePool.cpp:0: void std::__function::__policy_invoker<void ()>::__call_impl<std::__function::__default_alloc_func<ThreadFromGlobalPoolImpl<false>::ThreadFromGlobalPoolImpl<DB::BackgroundSchedulePool::BackgroundSchedulePool(unsigned long, StrongTypedef<unsigned long, CurrentMetrics::MetricTag>, StrongTypedef<unsigned long, CurrentMetrics::MetricTag>, char const*)::$_0>(DB::BackgroundSchedulePool::BackgroundSchedulePool(unsigned long, StrongTypedef<unsigned long, CurrentMetrics::MetricTag>, StrongTypedef<unsigned long, CurrentMetrics::MetricTag>, char const*)::$_0&&)::'lambda'(), void ()>>(std::__function::__policy_storage const*) @ 0x00000000170c0feb in /usr/bin/clickhouse
    21. ./base/base/../base/wide_integer_impl.h:809: ThreadPoolImpl<std::thread>::worker(std::__list_iterator<std::thread, void*>) @ 0x000000000f7c6a2f in /usr/bin/clickhouse
    22. ./contrib/llvm-project/libcxx/include/__memory/unique_ptr.h:302: void* std::__thread_proxy[abi:v15000]<std::tuple<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, void ThreadPoolImpl<std::thread>::scheduleImpl<void>(std::function<void ()>, Priority, std::optional<unsigned long>, bool)::'lambda0'()>>(void*) @ 0x000000000f7cc8f2 in /usr/bin/clickhouse
    23. ? @ 0x000000000733904f in /usr/bin/clickhouse
    24. ? @ 0x00007f28b2319ac3
    25. ? @ 0x00007f28b23ab850

</details>

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-27 16:04:18 +01:00
Alexey Milovidov
661d4a827b
Merge pull request #59272 from azat/osx-rust 
Enable Rust on OSX ARM64
 2024-01-27 14:29:32 +01:00
Azat Khuzhin
44e42052b1 Fix perf tests after sumMap starts to filter out -0. 
Before perf tests was relying on the following:

    SELECT sumMap(['foo', 'bar'], [-0., -0.])

    ┌─sumMap(['foo', 'bar'], [-0., -0.])─┐
    │ (['bar','foo'],[-0,-0])            │
    └────────────────────────────────────┘

While it got changed, and now:

    ┌─sumMap(['foo', 'bar'], [-0., -0.])─┐
    │ ([],[])                            │
    └────────────────────────────────────┘

But it works for nan:

    SELECT sumMap(['foo', 'bar'], [nan, nan])

    ┌─sumMap(['foo', 'bar'], [nan, nan])─┐
    │ (['bar','foo'],[nan,nan])          │
    └────────────────────────────────────┘

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-27 13:14:07 +01:00
Kruglov Pavel
875efc54b8
Merge pull request #59283 from ClickHouse/Avogar-patch-2 
Add missing setting optimize_injective_functions_in_group_by to SettingsChangesHistory
 2024-01-27 00:12:10 +01:00
Kruglov Pavel
1e61521dcc
Add missing setting optimize_injective_functions_in_group_by to SettingsChangesHistory 2024-01-26 23:33:04 +01:00
Peignon Melvyn
4273ae4f4f
Update view.md 2024-01-26 21:27:20 +01:00
robot-ch-test-poll2
930ce11ae4
Merge pull request #59261 from artbeglaryan/patch-3 
Fixed typo in documentation
 2024-01-26 22:41:04 +04:00
Azat Khuzhin
50f0a34ecb Enable Rust on OSX 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 17:20:00 +01:00
Dmitry Novik
6c5057c4f2
Merge pull request #58919 from ClickHouse/analyzer-inj-func-elemination 
Analyzer: Support GROUP BY injective function elimination
 2024-01-26 16:45:09 +01:00
Artur Beglaryan
1624ecd7e6
Fixed typo in documentation 
Added missed parameter in xml dictionary config
 2024-01-26 15:02:28 +00:00
Mikhail f. Shiryaev
4286634876
Merge pull request #59256 from azat/tests/fasttest 
Fix fasttest by pinning pip dependencies
 2024-01-26 16:00:32 +01:00
Azat Khuzhin
92d96c4d02 Fix fasttest by pinning pip dependencies 
After image update it prints the following warning:

    /ClickHouse/tests/queries/0_stateless/01558_ttest_scipy.python:5: DeprecationWarning:
    Pyarrow will become a required dependency of pandas in the next major release of pandas (pandas 3.0),
    (to allow more performant data types, such as the Arrow string type, and better interoperability with other libraries)
    but was not found to be installed on your system.
    If this would cause problems for you,
    please provide us feedback at https://github.com/pandas-dev/pandas/issues/54466

Pyarrow can be added as well, but according to the comment in the issue
it bloats the image size 170%, so let's simply downgrade it for now and
see how that issue will be resolved (or the warning could be suppressed
of course).

And pin other dependencies as well to avoid further failures.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-26 15:08:22 +01:00
Nikolai Kochetov
75edbdd39c
Merge pull request #59147 from ClickHouse/vdimir/fix_agg_nothing_2 
Fix AggregateFunctionNothing result type issues introducing it with different names
 2024-01-26 14:33:38 +01:00
Yarik Briukhovetskyi
0cbadc9b52
Merge pull request #59190 from yariks5s/fix_to_string_nullable_timezone 
Fix crash with nullable timezone for `toString`
 2024-01-26 13:33:12 +01:00
Nikolai Kochetov
10d4f1fd87
Merge pull request #59228 from kitaisreal/actions-dag-build-filter-actions-refactoring 
Actions dag build filter actions refactoring
 2024-01-26 11:34:19 +01:00
Sergei Trifonov
4fb511bfb3
Merge pull request #59137 from ClickHouse/fix-async-loader-shutdown-deadlock 
Fix not started database shutdown deadlock
 2024-01-26 11:21:13 +01:00
Max K
94b599d126
Merge pull request #59252 from ClickHouse/ci_fix_nightly_job 
CI: fix ci configuration for nightly job
 2024-01-26 10:59:00 +01:00
Max Kainov
2b75836ad2 CI: fix ci configuration for nightly job 2024-01-26 09:33:04 +00:00
Vitaly Baranov
3fbdf48b53
Merge pull request #59244 from vitlibar/disable-copy-constructor-for-multi-version 
Disable copy constructor for MultiVersion
 2024-01-26 09:29:43 +01:00
pufit
92e63bf45c
Load server configs in clickhouse local (#59231) 
Load server configs in clickhouse local
 2024-01-25 23:13:31 -05:00
Vitaly Baranov
a7b1fe9fa2 Disable copy constructor for MultiVersion. 2024-01-25 23:53:54 +01:00
Alexey Milovidov
aedffeaab0
Merge pull request #58959 from Algunenano/fix_sum_map 
Fix sumMapFiltered with NaN values
 2024-01-25 23:50:28 +01:00
Sema Checherinda
a69a0aea0e
Merge pull request #59066 from ClickHouse/chesema-remove-flaky-test 
remove flaky test
 2024-01-25 21:39:46 +01:00
Nikita Taranov
368ef60c77
Merge pull request #59093 from ClickHouse/nickitat-patch-18 
Add `[[nodiscard]]` to a couple of methods
 2024-01-25 17:03:05 +01:00
Maksim Kita
5bb734a4bb ActionsDAG buildFilterActionsDAG refactoring 2024-01-25 18:24:14 +03:00
Kseniia Sumarokova
70514e3d14
Merge pull request #57615 from ClickHouse/filecache-small-optimization 
fs cache: small optimization
 2024-01-25 15:50:09 +01:00
Yarik Briukhovetskyi
da1cf46b14
Fix fuzzer 2024-01-25 15:47:32 +01:00
Nikolai Kochetov
3fd6b4d1ac
Merge pull request #58831 from kitaisreal/table-create-drop-logger-memory-leak-fix 
Table CREATE DROP Poco::Logger memory leak fix
 2024-01-25 15:13:20 +01:00
yariks5s
1620c069b7 Merge branch 'fix_to_string_nullable_timezone' of github.com:yariks5s/ClickHouse into fix_to_string_nullable_timezone 2024-01-25 12:02:49 +00:00
yariks5s
c277148ee1 enhanced tests, fix 2024-01-25 12:01:51 +00:00
Maksim Kita
485a46f610 Fixed tests 2024-01-25 14:31:49 +03:00
Maksim Kita
109337e91e Updated implementation 2024-01-25 14:31:49 +03:00
Maksim Kita
2a327107b6 Updated implementation 2024-01-25 14:31:49 +03:00
Maksim Kita
6f698b40ae Poco update Logger to allow create shared LoggerPtr 2024-01-25 14:31:18 +03:00
Maksim Kita
bd8bbdaeb3 Poco update RefCountedObject with std::atomic 2024-01-25 14:31:18 +03:00