Commit Graph

94685 Commits

Author SHA1 Message Date
Vladimir C
96776d3028
Trim trailing whitespaces in SettingsFields.h 2022-08-11 13:15:28 +02:00
Vladimir C
261ccc35cf
Rename SettingAutoWrapper, add comment to readBinary
Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
Co-authored-by: Maksim Kita <maksim@clickhouse.com>
2022-08-11 12:18:44 +02:00
vdimir
21ace403ab
Add test setting_value_auto 2022-08-09 17:14:03 +00:00
vdimir
ae1db8386b
Change type of insert_quorum to UInt64WithAuto 2022-08-09 17:14:02 +00:00
vdimir
3189c40e6d
Implement SettingField with auto is a wrapper 2022-08-09 17:14:02 +00:00
vdimir
7c85b62e4e
Add setting type number with 'auto' 2022-08-09 12:52:25 +00:00
Alexander Tokmakov
5d507c593b
Merge pull request #40005 from ClickHouse/revert-39617-ci-self-extracting-s3-deployment
Revert "copy self-extracting to output"
2022-08-08 20:15:56 +03:00
Alexander Tokmakov
3bc583c22b
Revert "copy self-extracting to output" 2022-08-08 20:13:40 +03:00
Alexander Tokmakov
664b4355bf
Merge pull request #39941 from azat/tests-rwlock-fix
tests: fix 02352_rwlock flakiness
2022-08-08 19:24:08 +03:00
Robert Schulze
4c3153b2ba
Merge pull request #39988 from ClickHouse/document-disable-self-extracting-binary
Mention how the build can be speed up by disabling self-extraction
2022-08-08 16:57:40 +02:00
Robert Schulze
5a434577f6
Mention how the build can be speed up by disabling self-extraction 2022-08-08 13:01:32 +00:00
Alexander Tokmakov
2a62910fb5
Merge pull request #39985 from ClickHouse/tavplubix-patch-3
Disable 02380_insert_mv_race.sh with Ordinary
2022-08-08 15:55:05 +03:00
Alexander Tokmakov
0ba6751849
Update 02380_insert_mv_race.sh 2022-08-08 15:53:37 +03:00
Vladimir C
6bd4821656
Merge pull request #39575 from vdimir/join_pushdown_column_not_found
Fix column not found for push down with join
2022-08-08 14:04:42 +02:00
Yakov Olkhovskiy
8fe8208133
Merge pull request #39967 from ClickHouse/ci-mergeable-add
Add Stateful tests (release), Stateless tests (release) to Mergeable Check
2022-08-08 07:58:20 -04:00
Robert Schulze
ad0d060dc1
Merge pull request #39904 from ClickHouse/library-bridge-refactoring
Prepare library-bridge for catboost integration
2022-08-08 12:15:01 +02:00
Kseniia Sumarokova
d1b436597f
Merge pull request #39940 from azat/file-log-fix
Create metadata directory on CREATE for FileLog engine
2022-08-08 11:39:17 +02:00
Alexey Milovidov
0921548a37
Merge pull request #39527 from pkit/pkit/fix_nats_tls
fix nats-io TLS support
2022-08-08 08:28:14 +03:00
Alexey Milovidov
cb7f072fe8
Merge pull request #39617 from ClickHouse/ci-self-extracting-s3-deployment
copy self-extracting to output
2022-08-08 08:19:15 +03:00
Alexey Milovidov
5a82119fd0
Merge pull request #39962 from ClickHouse/play-ui-row-numbers-selection-hysteresis
Play UI: add row numbers; add cell selection on click; add hysteresis for table cells.
2022-08-08 08:08:34 +03:00
Alexey Milovidov
738c94a9e0
Merge pull request #39961 from ClickHouse/play-ui-ipad
Fix a few usability issues in Play UI
2022-08-08 08:07:43 +03:00
Yakov Olkhovskiy
40463e9c47 add Stateful tests (release), Stateless tests (release) to Mergeable Check 2022-08-08 00:20:09 -04:00
Alexey Milovidov
64a1b0f2b8 Play UI: row numbers; cell selection; hysteresis 2022-08-08 04:25:03 +02:00
Alexey Milovidov
653b86d1e6 Play UI: row numbers; cell selection; hysteresis 2022-08-08 04:16:50 +02:00
Alexey Milovidov
2ba87b1b81
Merge pull request #39963 from ClickHouse/revert-39633-filter-vbmi2
Revert "ColumnVector: optimize filter with AVX512VBMI2 compress store"
2022-08-08 05:04:26 +03:00
Alexey Milovidov
5524706b78
Revert "ColumnVector: optimize filter with AVX512VBMI2 compress store" 2022-08-08 05:03:15 +03:00
Alexey Milovidov
5ab1eca788
Merge pull request #39959 from ClickHouse/remove-old-code-2
Remove old code from the website (part 2)
2022-08-08 05:01:12 +03:00
Alexey Milovidov
2d83635643 Play UI: row numbers; cell selection; hysteresis 2022-08-08 03:57:02 +02:00
Alexey Milovidov
d914ddc766 Fix Play UI 2022-08-08 02:36:50 +02:00
Alexey Milovidov
8883c1d08c
Merge pull request #39939 from azat/stress-oom
tests/stress: add dmesg output (to see OOM details)
2022-08-08 03:07:37 +03:00
Alexey Milovidov
73f4643afa
Merge pull request #39839 from ClickHouse/Avogar-patch-1
Update settings changes history
2022-08-08 02:48:09 +03:00
Alexey Milovidov
bee4112538 Update README 2022-08-08 01:10:48 +02:00
Alexey Milovidov
47b0d05c71 Removed useless code from the website 2022-08-08 01:06:47 +02:00
Alexey Milovidov
d413c40c41 Remove old code from the website (part 2) 2022-08-08 00:37:36 +02:00
Alexey Milovidov
8f14f77572
Merge pull request #39947 from ClickHouse/remove-old-code
Remove old code from the website
2022-08-08 01:37:03 +03:00
Igor Nikonov
5268eacc9d
Merge pull request #39955 from ClickHouse/distinct-reduce-trace-level
Remove debug trace from DistinctStep
2022-08-07 23:47:11 +02:00
Maksim Kita
83977dfead
Merge pull request #39869 from pkit/pkit/func_settings_format
fix incorrect format for functions with settings
2022-08-07 16:30:49 +02:00
Igor Nikonov
254d14b1d3 Remove debug trace from DistinctStep
+ this information can be seen later via EXPLAIN PLAN
2022-08-07 13:12:11 +00:00
Yakov Olkhovskiy
19d74d7871
Merge branch 'master' into ci-self-extracting-s3-deployment 2022-08-07 07:24:22 -04:00
Yakov Olkhovskiy
29622746ea
Merge pull request #39936 from ClickHouse/cmake-fix-self-extracting-split
Don't create self-extracting clickhouse for split build
2022-08-07 07:23:24 -04:00
Azat Khuzhin
a1981f21a1
Merge branch 'master' into stress-oom 2022-08-07 10:42:04 +02:00
Alexey Milovidov
22ab9cfed3 Remove old code 2022-08-07 01:11:57 +02:00
Igor Nikonov
b4f5d9ca10
Merge pull request #39740 from ClickHouse/ordinary_distinct_small_refact
Simple refactoring: ordinary DISTINCT implementation
2022-08-07 01:05:23 +02:00
Azat Khuzhin
64aa8c7cde
Merge branch 'master' into stress-oom 2022-08-06 20:47:09 +02:00
Azat Khuzhin
8b08d56473 tests: fix 02352_rwlock flakiness
It is possible that the next after INSERT query will be executed only
when INSERT finished, it is unlikely, but it happened few times on CI
[1]:

    2022.08.05 19:32:13.964046 [ 1565 ] {insert-qjnxxoaebk} <Debug> executeQuery: (from [::1]:57512) (comment: 02352_rwlock.sh) INSERT INTO test_7ybr6x_ordinary.data_02352 SELECT sleepEachRow(1) FROM numbers(20) GROUP BY number (stage: Complete)
    ...
    2022.08.05 19:32:14.945738 [ 1594 ] {245b7446-58da-452b-9669-55dad643bc34} <Debug> executeQuery: (from [::1]:57516) (comment: 02352_rwlock.sh) select count() from system.processes where query_id = 'insert-qjnxxoaebk' (stage: Complete)
    ...
    2022.08.05 19:32:33.997257 [ 1565 ] {insert-qjnxxoaebk} <Debug> TCPHandler: Processed in 20.056755494 sec.
    ...
    2022.08.05 19:32:34.614789 [ 908 ] {3be7ade3-6461-4906-8767-7cc11f83a0b8} <Debug> executeQuery: (from [::1]:57522) (comment: 02352_rwlock.sh) select count() from system.processes where query_id = 'drop-zoyhjyewja' (stage: Complete)
    ...
    2022.08.05 19:32:34.674039 [ 1175 ] {drop-zoyhjyewja} <Debug> executeQuery: (from [::1]:57528) (comment: 02352_rwlock.sh) DROP TABLE test_7ybr6x_ordinary.data_02352 SYNC (stage: Complete)
    ...

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/39826/8e545958495937c6c6e61951601a6470119d0813/stateless_tests__debug__[1/3].html

And to avoid flakiness in this case, add a retry loop and no-parallel
tag.

Refs: #38864
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-08-06 20:34:04 +03:00
Constantine Peresypkin
766d816df6 fix incorrect format for functions with settings
when support for settings was added in #39681
the formating was not altered to support settings

now it's supported
2022-08-06 17:08:32 +02:00
Azat Khuzhin
d0189e8f66 Create metadata directory on CREATE for FileLog engine
This will allow to distinguish really corrupted data, since right now if
you will CREATE/DETACH/ATTACH such engine you will have the following
error [1]:

    2022.08.05 20:02:20.726398 [ 696405 ] {} <Error> StorageFileLog (file_log): Metadata files of table file_log are lost.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/39926/72961328f68b1ec05300d6dc4411a87618a2f46b/stress_test__debug_.html

Likely that previously it was not created to avoid creating empty
directories, however this should be a problem I guess.

Refs: #25969 (@ucasfl)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-08-06 13:54:49 +03:00
Alexander Gololobov
f52b6748db
Merge pull request #39900 from ClickHouse/wait_for_mutation_race
Fix the race between waitMutation and updating local queue from ZK
2022-08-06 12:09:16 +02:00
Azat Khuzhin
3772415588 tests/stress: add dmesg output (to see OOM details)
max_server_memory_usage already set to 75%, so OOM should not happens,
the reason is that because RSS does not match with memory tracker
statistics:

    2022.08.05 12:36:57.869896 [ 82524 ] {} <Trace> AsynchronousMetrics: MemoryTracking: was 64.69 GiB, peak 65.26 GiB, will set to 62.80 GiB (RSS), difference: -1.89 GiB
    ...
    2022.08.05 12:37:00.213440 [ 82334 ] {} <Error> void DB::MergeTreeBackgroundExecutor<DB::MergeMutateRuntimeQueue>::routine(DB::TaskRuntimeDataPtr) [Queue = DB::MergeMutateRuntimeQueue]: Code: 241. DB::Exception: Memory limit (total) exceeded: would use 64.68 GiB (attempt to allocate chunk of 1298794 bytes), maximum: 51.44 GiB. OvercommitTracker decision: Memory overcommit isn't used. Waiting time or orvercommit denominator are set to zero.. (MEMORY_LIMIT_EXCEEDED), Stack trace (when copying this message, always include the lines below):

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-08-06 12:34:38 +03:00
Yakov Olkhovskiy
b1f45fa787 Don't create self-extracting clickhouse for split build 2022-08-05 21:48:40 -04:00