Commit Graph

54132 Commits

Author SHA1 Message Date
Kruglov Pavel
2e4de1f5e8
Merge pull request #60419 from Avogar/fix-ub-setting
Fix undefined-behavior in case of too big max_execution_time setting
2024-02-28 13:32:39 +01:00
Raúl Marín
3920120260
Merge pull request #60453 from Algunenano/fix_preimagepass
Fix OptimizeDateOrDateTimeConverterWithPreimageVisitor with null arguments
2024-02-28 13:15:04 +01:00
Zhiguo Zhou
ae06e34ea9 Auto-vectorize DB::andFilters
DB::MergeTreeRangeReader::ReadResult::optimize adds the current
filter to the final one either via DB::combineFilters when both
filters have different sizes or otherwise via DB::andFilters, which
performs the logical AND operation (&&) to two UInt8 columns.

To vectorize DB::andFilters automatically, this commit performs NOT
operation to the operands twice so that the non-zeros are converted
to bool value of true (0x01) and the zeros to false (0x00), and via
this change the logical AND (&&) could be safely replaced with the
bitwise AND (&), which could be recognized and optimized by the
compiler.
2024-02-28 20:08:24 +08:00
Ilya Yatsishin
6473023ad5
Merge pull request #60359 from Avogar/fix-ipv6-hashing
Fix use-of-uninitialized-value and invalid result in hashing functions with IPv6
2024-02-28 15:32:57 +04:00
Robert Schulze
613e426484
Some fixups 2024-02-28 11:14:53 +00:00
vdimir
973c2536ff
fix 02911_support_alias_column_in_indices 2024-02-28 10:44:09 +00:00
Smita Kulkarni
a46d7c9191 Updated docs and addressed comments 2024-02-28 11:25:35 +01:00
Vitaly Baranov
926295f763
Merge pull request #60040 from vitlibar/use-multiple-threads-while-reading-metadata-for-restore
Use multiple threads while reading the metadata of tables to restore
2024-02-28 11:07:15 +01:00
Antonio Andelic
c4ae61f6e6 Correctly check prefetch buffer 2024-02-28 09:58:47 +01:00
Antonio Andelic
f7abe7601e Abort on invalid snapshots 2024-02-28 08:54:54 +01:00
pufit
330a206470
Add definers for views (Attempt 2) (#60439) 2024-02-27 19:00:17 -05:00
Nikita Taranov
90c9ae1b22
Merge pull request #59448 from nickitat/insert_with_max_insert_threads_into_remote_tables
More parallel insert-select pipeline
2024-02-28 00:54:16 +01:00
Anton Popov
3cdd3495fd
Merge pull request #60435 from CurtizJ/return-back-58140
Revert "Revert "Add table function `mergeTreeIndex`""
2024-02-28 00:52:44 +01:00
Alexey Milovidov
8cf619bc03 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-inconsistent-formatting 2024-02-28 00:30:44 +01:00
Alexey Milovidov
acbcffea13 Fix error 2024-02-27 23:33:16 +01:00
Alexey Milovidov
142a857281 Merge branch 'bugfix/kql-distributed-tables' of github.com:ClibMouse/ClickHouse into ClibMouse-bugfix/kql-distributed-tables 2024-02-27 23:31:25 +01:00
Alexey Milovidov
9ea7ff231b
Merge pull request #60448 from ClickHouse/clang-19
Update to clang-19
2024-02-27 23:38:08 +03:00
Alexey Milovidov
2ab722214c Merge branch 'hlee-ftsearch-test' of github.com:HarryLeeIBM/ClickHouse into HarryLeeIBM-hlee-ftsearch-test 2024-02-27 20:29:46 +01:00
Blargian
abbe596a2d Fix style check 2024-02-27 19:57:25 +01:00
Blargian
426a68ca23 Fix style check 2024-02-27 19:43:00 +01:00
Pervakov Grigorii
d3b82ab7c1 Support sql created named collections in Kafka Storage for librdkafka settings 2024-02-27 18:36:36 +00:00
Blargian
8b8dcf01b6 Add toMillisecond 2024-02-27 19:32:38 +01:00
Smita Kulkarni
ca05557659 Fix typo 2024-02-27 19:16:36 +01:00
Smita Kulkarni
414c8da128 Fix build 2024-02-27 18:09:21 +01:00
Vitaly Baranov
0df2a645cd Rename after_each_task_callback. 2024-02-27 17:41:09 +01:00
Alexey Milovidov
0f3c9963d1 Merge branch 'master' of github.com:ClickHouse/ClickHouse into revert-60216-revert-59697-check-stack-size-in-parser 2024-02-27 17:30:32 +01:00
Raúl Marín
f8ff15a023
Merge pull request #60429 from Algunenano/fix_unlimited_keeper
Fix unrestricted reads from keeper
2024-02-27 17:28:15 +01:00
Antonio Andelic
f6d35cf4b1 Merge branch 'master' into keeper-snapshot-detached 2024-02-27 16:44:06 +01:00
Raúl Marín
52b14c3f0a Merge remote-tracking branch 'blessed/master' into argmin_optimization 2024-02-27 16:40:59 +01:00
Antonio Andelic
5530ad5d90 Merge branch 'master' into keeper-disk-move-fix 2024-02-27 16:38:58 +01:00
Antonio Andelic
32daeced94 Abort on failure to read from snapshot 2024-02-27 16:38:25 +01:00
Robert Schulze
e185805c1c
Minor: Replace boost::algorithm::ends_with() by std::string::ends_with() 2024-02-27 15:28:02 +00:00
Robert Schulze
466cf93ee2
Merge pull request #60450 from rschu1ze/starts_with
Minor: Replace `boost::algorithm::starts_with()` by `std::string::starts_with()`
2024-02-27 16:21:02 +01:00
Raúl Marín
0a243c3c57 Fix 2024-02-27 16:17:48 +01:00
Raúl Marín
f0354ee07f Fix optimization with nullable arguments 2024-02-27 16:15:21 +01:00
Robert Schulze
0f6bec7842
Merge pull request #59291 from azat/dist/config-settings
Support specifying settings for Distributed engine in config (like for MergeTree)
2024-02-27 16:10:51 +01:00
Raúl Marín
2a44eeff90
Merge pull request #60211 from jlmadurga/ulid_short_circuit
Ulid short circuit
2024-02-27 16:04:15 +01:00
Raúl Marín
e81c2ede2a Add setting to control preimage optimization 2024-02-27 15:58:42 +01:00
Alexey Milovidov
7c6e28708b
Merge pull request #60370 from ClickHouse/remove-alter-live-view
Remove ALTER LIVE VIEW
2024-02-27 17:45:59 +03:00
Dmitry Novik
6ad10629ff
Fix crash 2024-02-27 15:37:53 +01:00
Alexey Milovidov
ecbae90743 Remove unused file 2024-02-27 15:36:39 +01:00
Dmitry Novik
4318cf8253
Merge pull request #60339 from ClickHouse/fix-analyzer-executable
Fix - analyzer related - "executable" function subquery arguments.
2024-02-27 15:27:35 +01:00
Nikita Mikhaylov
8719a601fa
Merge pull request #60436 from nickitat/revert_56864
Revert "Merge pull request #56864 from ClickHouse/broken-projections-better-handling"
2024-02-27 15:25:15 +01:00
Antonio Andelic
2c8759442d Move broken Keeper snapshots to detached folder 2024-02-27 15:16:10 +01:00
Robert Schulze
262c7b4ecb
Move enable_order_by_all out of the experimental section 2024-02-27 14:05:50 +00:00
Alexey Milovidov
568127ae98 Update to clang-19 2024-02-27 14:39:20 +01:00
Alexey Milovidov
c192a448d0 Update to clang-19 2024-02-27 14:37:21 +01:00
Yarik Briukhovetskyi
7c6a5f4513
Merge pull request #59598 from yariks5s/group_array_intersect
New aggregate function groupArrayIntersect
2024-02-27 14:30:49 +01:00
Raúl Marín
753056eed7
Merge branch 'master' into parallel_replicas_cte_2 2024-02-27 14:06:02 +01:00
Raúl Marín
f71f833c61 Fix terrible formatting 2024-02-27 13:38:50 +01:00
Nikolai Kochetov
63b4457991
Merge pull request #60360 from ClickHouse/follow-up-60082
Follow up #60082
2024-02-27 12:50:25 +01:00
Raúl Marín
c1c4a8c02a Merge remote-tracking branch 'blessed/master' into argmin_optimization 2024-02-27 12:49:18 +01:00
Raúl Marín
c9dd6fe8d5
Set max_parallel_replicas to 1 when disabling 2024-02-27 12:35:14 +01:00
Robert Schulze
62c12cbfca
Replace boost::algorithm::starts_with() by std::string::starts_with() 2024-02-27 10:42:47 +00:00
Smita Kulkarni
ae309e6ea9 Updated to set proper prefix for azure blob storage disk 2024-02-27 11:12:19 +01:00
Antonio Andelic
89789f855e Merge branch 'master' into keeper-disk-move-fix 2024-02-27 09:54:16 +01:00
Antonio Andelic
178c60a8e5 Fix removing from source disk 2024-02-27 09:53:49 +01:00
rogeryk
aa31f0c613 Fix style 2024-02-27 09:17:01 +08:00
Alexey Milovidov
6ac96bdcf1 Fix inconsistent formatting of CREATE TABLE ... COLLATE 2024-02-27 00:40:39 +01:00
Nikita Taranov
854f1b064b Revert "Merge pull request #56864 from ClickHouse/broken-projections-better-handling"
This reverts commit caaafbcedb, reversing
changes made to d45b248f96.
2024-02-27 00:13:28 +01:00
Anton Popov
d683977fe9 Revert "Revert "Add table function mergeTreeIndex""
This reverts commit 1e4199d704.
2024-02-26 22:47:39 +00:00
Alexey Milovidov
04fe5dc55c Merge branch 'master' into fix-inconsistent-formatting 2024-02-26 23:46:24 +01:00
Alexey Milovidov
0b90076a36
Revert "Revert "Check stack size in Parser"" 2024-02-27 01:34:50 +03:00
Alexey Milovidov
b5dbda261b Use shrinkToFit anyway 2024-02-26 23:31:33 +01:00
Alexey Milovidov
c29d9a8af6 Merge branch 'master' into less-memory-usage-primary-key-2 2024-02-26 23:30:47 +01:00
Alexey Milovidov
fbfc4afb46
Merge branch 'master' into redirect-handlers 2024-02-27 01:27:38 +03:00
Robert Schulze
ac7a3cd18d
Merge remote-tracking branch 'rschu1ze/master' into mysql-friday-evening-fix 2024-02-26 22:00:45 +00:00
Robert Schulze
4794dc28f0
Merge remote-tracking branch 'ClickHouse/master' into dist/config-settings 2024-02-26 21:57:33 +00:00
Kirill Nikiforov
8b314a3ac8
Implement system.dns_cache table and dns_cache_max_size server setting (#60257)
* system.dns_cache table WIP

* system.dns_cache table

* rollback unexpected contrib changes

* rollback unexpected changes

* add docs

* code style fixes

* optimize dns cache exporting

* stateful test for system.dns_cache table

* stateful test for system.dns_cache table

* cr fixes

* stateful test for system.dns_cache table

* stateful test for system.dns_cache table

* implement system.dns_cache table

* system.dns_cache test

* system.dns_cache fix docs

* system.dns_cache prettify

* dns_cache_max_size settings

* fix system.dns_cache test

* Update dns_cache.md

* fix doc

Co-authored-by: pufit <pufit@clickhouse.com>

---------

Co-authored-by: pufit <pufit@clickhouse.com>
2024-02-26 15:48:02 -05:00
Alexey Milovidov
9dff4e8331
Merge pull request #58533 from zvonand/zvonand-volume-priority
Allow to define `volume_priority` in `storage_configuration`
2024-02-26 22:57:10 +03:00
Raúl Marín
8a161bdc0a Fix unrestricted reads from keeper 2024-02-26 19:38:00 +01:00
Alexander Tokmakov
1e4199d704
Revert "Add table function mergeTreeIndex" 2024-02-26 19:37:06 +01:00
Alexey Milovidov
ad99bb95a3
Merge pull request #60388 from ClickHouse/remove-useless-method-2
Remove unused method
2024-02-26 21:05:37 +03:00
Alexey Milovidov
bbf9561a65
Merge pull request #60389 from ClickHouse/allow-remap-web-ui-handlers
Allow to map UI handlers to different paths
2024-02-26 21:03:59 +03:00
Alexey Milovidov
a3f1411679 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-inconsistent-formatting 2024-02-26 19:01:11 +01:00
Alexey Milovidov
6c6376de0a
Fix compatibility 2024-02-26 12:58:02 -05:00
Alexey Milovidov
3613464d46
Fix the code 2024-02-26 12:58:02 -05:00
Austin Kothig
f5ba7fde9f
Only set dialect if KQL or PRQL. 2024-02-26 12:58:01 -05:00
kothiga
70248639e8
Include PRQL. Added functional test that tests both KQL and PRQL. 2024-02-26 12:58:01 -05:00
kothiga
90a18326a5
Fix KQL distributed tables queries. 2024-02-26 12:58:01 -05:00
Amos Bird
41388a7a53 Fix
(cherry picked from commit 1d22dd8f0d809f1cc6593d4164098f1b5463cc77)
2024-02-26 17:52:19 +00:00
Alexey Milovidov
bad7ee271c Merge branch 'redirect-handlers' of github.com:ClickHouse/ClickHouse into redirect-handlers 2024-02-26 17:27:48 +01:00
Alexey Milovidov
0469bdb639 Fix tidy 2024-02-26 17:27:29 +01:00
vdimir
9f1a0734a1
review fix 2024-02-26 16:15:14 +00:00
vdimir
5a9026f39b
Analyzer: compute ALIAS columns right after reading 2024-02-26 16:15:05 +00:00
Raúl Marín
eb0af49fd0 Merge remote-tracking branch 'blessed/master' into max_threads_sanity 2024-02-26 16:33:43 +01:00
Nikolai Kochetov
ce7cde64ec Small fix 2024-02-26 15:33:25 +00:00
Anton Popov
814cd53918
Merge pull request #58140 from CurtizJ/storage-merge-tree-index
Add table function `mergeTreeIndex`
2024-02-26 16:31:56 +01:00
Dmitry Novik
b5b7e02fd9
Merge branch 'master' into fix-analyzer-executable 2024-02-26 16:21:53 +01:00
Nikolai Kochetov
ed78c18eda Add a setting query_plan_optimize_prewhere. Use AST-based PREWHERE optimization when it is disabled. 2024-02-26 15:19:27 +00:00
Nikolai Kochetov
2b9889fb84
Merge pull request #60082 from amosbird/non-trivial-count-optimization
Refactor prewhere and primary key optimization
2024-02-26 16:17:24 +01:00
Dmitry Novik
32c63cc57a Fix style 2024-02-26 15:02:06 +00:00
avogar
3c881b63d6 Merge branch 'master' of github.com:ClickHouse/ClickHouse into validate-nested-types-under-a-setting 2024-02-26 14:45:57 +00:00
avogar
73bbc08384 Fix undefined-behavior in case of too big max_execution_time setting 2024-02-26 14:40:51 +00:00
Robert Schulze
048f7ec3e9
Merge pull request #59516 from rschu1ze/cgroup-observing-memory-tracker
Update memory tracker periodically with cgroup memory usage
2024-02-26 15:27:19 +01:00
Dmitry Novik
96dff28a96 Update comment 2024-02-26 14:17:05 +00:00
Nikolai Kochetov
ef8dab52c6
Merge pull request #57767 from jsc0218/DictShortCircuit
Dict Short Circuit
2024-02-26 15:16:15 +01:00
Dmitry Novik
848d4009e6 Rewrite implementation 2024-02-26 14:14:30 +00:00
Raúl Marín
f885423a4a Cleanup and more tests 2024-02-26 15:09:05 +01:00
Juan Madurga
556b9897d0 update FunctionULIDStringToDateTime for short circuit 2024-02-26 15:01:17 +01:00
vdimir
d62b8a5d4a
Throw BAD_ARGUMENTS for hashed_dict with shards and update_field 2024-02-26 14:01:08 +00:00
Raúl Marín
2fa04bb37c Merge remote-tracking branch 'blessed/master' into parallel_replicas_cte_2 2024-02-26 14:31:20 +01:00
avogar
024a5c90f1 Fix tests, add new setting to changes history 2024-02-26 12:48:40 +00:00
Kruglov Pavel
1a9ee8c318
Merge pull request #60372 from HowePa/single_arg_merge
Support single-argument version for the merge table function
2024-02-26 13:43:04 +01:00
Yong Wang
795c1a98dc
Fix segmentation fault in KQL parser when the input query exceeds the max_query_size (#59626)
* Fix_kql_issue_found_by_wingfuzz

This commit fix the issues:
 https://github.com/ClickHouse/ClickHouse/issues/59036
 https://github.com/ClickHouse/ClickHouse/issues/59037

both issues are same reason, the input query exceed the max_query_size,
so the condition isEnd() of token is not meet and cause the assertion failure

* fix_kql_issue_found_by_wingfuzz: use isValid instead of TokenType::EndOfStream

* fix_kql_issue_found_by_wingfuzz: make functional test result consist

* fix_kql_issue_found_by_wingfuzz: update test case for makeseries

* fix_kql_issue_found_by_wingfuzz: disable makeseries

* fix_kql_issue_found_by_wingfuzz:
 use isvalid() function to replace isEnd() function of TokenIterator to check the end of stream

* fix_kql_issue_found_by_wingfuzz: add test case for max_query_size

* fix_kql_issue_found_by_wingfuzz: fix AST structure

* fix_kql_issue_found_by_wingfuzz: make sure the max query size test is in the dialect of kusto

* fix_kql_issue_found_by_wingfuzz : restore max query size after test

* fix_kql_issue_found_by_wingfuzz : fix typo

---------

Co-authored-by: János Benjamin Antal <benjamin.antal@clickhouse.com>
2024-02-26 13:31:47 +01:00
rogeryk
7a92f542b4 Add setting output_format_pretty_single_large_number_tip_threshold 2024-02-26 20:19:53 +08:00
Yarik Briukhovetskyi
e04a89349d
Merge branch 'ClickHouse:master' into group_array_intersect 2024-02-26 12:29:22 +01:00
Yarik Briukhovetskyi
7d413bef18
Merge branch 'ClickHouse:master' into fix_datetime64_scale_conversion 2024-02-26 12:28:36 +01:00
Robert Schulze
1e40b63cb1
Merge remote-tracking branch 'ClickHouse/master' into dist/config-settings 2024-02-26 11:15:51 +00:00
Robert Schulze
b11c266704
Update setting changes history 2024-02-26 10:58:25 +00:00
Raúl Marín
f84209be2f Merge remote-tracking branch 'blessed/master' into max_threads_sanity 2024-02-26 11:56:29 +01:00
Robert Schulze
5c967c44de
Merge pull request #60248 from ClickHouse/revert-59450-order-by-all-ambiguities
Revert "Replace `ORDER BY ALL` by `ORDER BY *`"
2024-02-26 10:23:41 +01:00
Robert Schulze
13dd5ce427
Update settings history 2024-02-26 09:18:00 +00:00
alesapin
d4b151764f
Update src/Common/CgroupsMemoryUsageObserver.cpp 2024-02-26 09:58:11 +01:00
alesapin
f6554d0d4e
Update src/Common/CgroupsMemoryUsageObserver.cpp 2024-02-26 09:57:59 +01:00
Andrey Zvonov
b4e582f47b
Merge branch 'ClickHouse:master' into zvonand-volume-priority 2024-02-26 09:54:29 +01:00
Antonio Andelic
ffe1872e23
Merge pull request #60203 from ClickHouse/limit_libarchive_format
Limit libarchive format to what we use
2024-02-26 09:25:19 +01:00
Antonio Andelic
5b01c4feb3
Revert "Fix: IAST::clone() for RENAME" 2024-02-26 08:47:05 +01:00
HowePa
5fffe2508c update error message 2024-02-26 10:01:24 +08:00
Alexey Milovidov
979cd2937b Fix inconsistent formatting of SET param_... 2024-02-26 02:11:51 +01:00
Alexey Milovidov
e5cb594944 Fix inconsistent formatting of GRANT CURRENT GRANTS 2024-02-26 01:54:52 +01:00
Alexey Milovidov
4b854399f4
Update src/Parsers/ASTSystemQuery.cpp
Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>
2024-02-26 03:44:35 +03:00
Alexey Milovidov
3f8f641dff Fix inconsistent formatting of GRANT CURRENT GRANTS 2024-02-26 01:43:37 +01:00
Alexey Milovidov
34e85959c1
Update HTTPServerResponse.cpp 2024-02-26 03:34:35 +03:00
Alexey Milovidov
bf75d2878b Merge branch 'master' into fix-inconsistent-formatting 2024-02-26 00:09:02 +01:00
Alexey Milovidov
10e59c2e01 Remove ALTER LIVE VIEW 2024-02-26 00:01:34 +01:00
Alexey Milovidov
4ae5d78f54 Merge branch 'master' into remove-alter-live-view 2024-02-26 00:00:28 +01:00
Alexey Milovidov
9f4041e3f7 Add support for HTTP redirects 2024-02-25 23:45:09 +01:00
Alexey Milovidov
2756160aea Allow to map UI handlers to different paths 2024-02-25 23:04:39 +01:00
Alexey Milovidov
d097da1223 Remove unused method 2024-02-25 22:40:03 +01:00
Amos Bird
3167dfd992
Fix another issue 2024-02-26 02:32:01 +08:00
Amos Bird
38427fff35
Better name 2024-02-26 02:32:00 +08:00
Amos Bird
d577d1e4e2
Fix something 2024-02-26 02:32:00 +08:00
Nikolai Kochetov
2197f2fc73
Try to cleanup a bit. 2024-02-26 02:32:00 +08:00
Amos Bird
534da3f40f
Fix more tests 2024-02-26 02:31:59 +08:00
Amos Bird
5551a9073b
Better 2024-02-26 02:31:59 +08:00
Amos Bird
6a2eb7297d
Fix 2024-02-26 02:31:59 +08:00
Amos Bird
207d36d7c1
Make it work 2024-02-26 02:31:58 +08:00
Amos Bird
12914d2268
Fix 2024-02-26 02:31:58 +08:00
Amos Bird
6137914604
Fix most tests 2024-02-26 02:31:58 +08:00
Amos Bird
b40a412086
Fix 2024-02-26 02:31:57 +08:00
Amos Bird
8a1e23dcc4
Fix more tests 2024-02-26 02:31:57 +08:00
Amos Bird
7435568a0d
Fix tests 2024-02-26 02:31:57 +08:00
Amos Bird
c5e073320c
Unify prewhere optimization 2024-02-26 02:31:56 +08:00
Amos Bird
49352732cc
Fix more tests 2024-02-26 02:31:56 +08:00
Amos Bird
2b214aebd8
Fix tests 2024-02-26 02:31:56 +08:00
Amos Bird
ffab16595e
Fix more tests 2024-02-26 02:31:55 +08:00
Amos Bird
cb36bd2377
Fix some tests 2024-02-26 02:31:55 +08:00
Amos Bird
07a0adceb9
Only use query_info.filter_actions_dag for key analysis 2024-02-26 02:31:55 +08:00
Amos Bird
001596ea0e
Check if query_info can be removed when building filter dag. 2024-02-26 02:31:54 +08:00
Alexey Milovidov
648e6ec5a6
Merge pull request #60373 from azat/tests/detect-io_uring
Detect io_uring in tests
2024-02-25 15:16:43 +03:00
rogeryk
85a15cd855 Fix style 2024-02-25 17:23:43 +08:00
rogeryk
6d529036ef Improve pretty format if a block consists of a single numeric value and exceeds one million. 2024-02-25 16:13:35 +08:00
Nikita Taranov
49f42eb09d
Merge branch 'master' into fix_head_bucket_after_update 2024-02-24 23:44:10 +01:00
Azat Khuzhin
a70a100db0 Support io_uring for StorageFile
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-24 19:36:58 +01:00
HowePa
17f60b54cb single arg merge table func 2024-02-24 08:02:13 +08:00
Alexey Milovidov
2eb4d25126 Remove ALTER LIVE VIEW 2024-02-23 22:56:18 +01:00
avogar
8fa75a21c5 Don't allow suspicious variant types by default, add notes in documentation 2024-02-23 20:48:38 +00:00
Vitaly Baranov
f944faec6f Fix using table_id in StorageKeeperMap. 2024-02-23 20:27:19 +01:00
Vitaly Baranov
f238999095 Use multiple threads while reading the metadata of tables to restore. 2024-02-23 20:27:19 +01:00
avogar
39ad054e94 Merge branch 'master' of github.com:ClickHouse/ClickHouse into variant-improvements 2024-02-23 18:59:34 +00:00
Robert Schulze
b9f5a2f620
Enable prefer_column_name_to_alias in MySQL Handler, default enable two MySQL settings 2024-02-23 17:42:54 +00:00
Raúl Marín
d507884a1d Force reanalysis if parallel replicas changed 2024-02-23 17:59:25 +01:00
vdimir
0b2267cfe5
add name to logs in HashedDictionary 2024-02-23 16:28:58 +00:00
Dmitry Novik
600d020379 Merge remote-tracking branch 'origin/master' into optimize_aggregators_of_group_by_keys 2024-02-23 16:07:28 +00:00
Andrey Zvonov
a85a6d65bd
Merge branch 'ClickHouse:master' into zvonand-volume-priority 2024-02-23 16:04:52 +01:00
Alexey Milovidov
209a151e00 Merge branch 'master' into less-memory-usage-primary-key-2 2024-02-23 16:02:29 +01:00
Alexey Milovidov
35f379ee64 Fix trash formatting 2024-02-23 15:55:29 +01:00
Alexey Milovidov
da2ae34c1d Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-inconsistent-formatting 2024-02-23 15:55:03 +01:00
avogar
0b012a56ba Fix use-of-uninitialized-value in hashing functions with IPv6 2024-02-23 14:49:55 +00:00
Alexey Milovidov
10ba0801be Fix inconsistent formatting of SYSTEM SYNC REPLICA LIGHTWEIGHT 2024-02-23 15:45:08 +01:00
Nikolai Kochetov
f0a45970fa
Merge pull request #60358 from 4JustMe4/missed-include
Add missed #include <mutex>
2024-02-23 15:31:21 +01:00
Alexander Tokmakov
ef3b19167f
Merge pull request #58036 from MikhailBurdukov/backoff_for_failed_mutations
Backoff policy for failed mutation.
2024-02-23 15:27:41 +01:00
Nikolai Kochetov
83841c23d3
Merge pull request #60230 from ClickHouse/fix-analyzer-secrets
Fix analyzer - hide arguments for secret functions
2024-02-23 15:26:49 +01:00
mikhnenko
e6aaa278a2 Add missed #include <mutex> 2024-02-23 17:23:11 +03:00
Alexey Milovidov
396402a9b6 Fix inconsistent formatting of operator function and nulls action 2024-02-23 15:22:21 +01:00
Nikita Mikhaylov
8fef0b71c4
Merge pull request #60350 from ClickHouse/revert-54901-pufit/views-sql-security
Revert "Add definers for views"
2024-02-23 15:15:36 +01:00
Alexey Milovidov
75c5b1a2c6 Fix inconsistent formatting of window functions 2024-02-23 15:06:03 +01:00
Alexey Milovidov
9e32d0f5b2 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-inconsistent-formatting 2024-02-23 15:05:46 +01:00
Igor Nikonov
90b1f8544a
Merge pull request #60227 from ClickHouse/fix-clone-ast-for-rename
Fix: IAST::clone() for RENAME
2024-02-23 14:48:14 +01:00
avogar
da8d8fee47 Validate experimental and suspicious types inside nested types under a setting to reflect it in compatibility setting 2024-02-23 13:45:03 +00:00
Raúl Marín
edd5a64890 Better checks 2024-02-23 14:22:05 +01:00
Alexey Milovidov
4487be7a91 Merge branch 'master' into fix-inconsistent-formatting 2024-02-23 14:07:55 +01:00
Alexander Tokmakov
32607cc796
Merge pull request #60159 from ClickHouse/fix_create_replica
Skip sanity checks on secondary CREATE query
2024-02-23 13:53:47 +01:00
Sergei Trifonov
2c766cf75f
Merge pull request #59507 from ClickHouse/alter-table-forget-partition
Add `FORGET PARTITION` query to remove old partition nodes from ZooKeeper
2024-02-23 12:55:08 +01:00
Raúl Marín
464b5e0e15
Revert "Add definers for views (#54901)"
This reverts commit 57306706b3.
2024-02-23 12:44:31 +01:00
Vitaly Baranov
db119eed49
Merge pull request #60002 from vitlibar/add-config-setting-remove-backup-files-after-failure
Add new config setting "backups.remove_backup_files_after_failure"
2024-02-23 12:42:55 +01:00
Raúl Marín
a431608dd4 Add sanity check for some settings 2024-02-23 12:32:17 +01:00
Yarik Briukhovetskyi
ec2c717910
Merge branch 'ClickHouse:master' into fix_datetime64_scale_conversion 2024-02-23 12:24:14 +01:00
zhongyuankai
055efec1a0
minor 2024-02-23 19:03:41 +08:00
Kseniia Sumarokova
6a7fef13ba
Merge pull request #60282 from ClickHouse/s3queue-fix-bug-and-flaky-test
s3queue: fix bug (also fixes flaky test_storage_s3_queue/test.py::test_shards_distributed)
2024-02-23 11:57:34 +01:00
zhongyuankai
68239075b7
Query cache does not record the number of queries by default 2024-02-23 18:33:24 +08:00
Robert Schulze
e325afa350
Merge pull request #59551 from jinjunzh/iaadeflate_upgrade_qpl_v1.4.0
Upgrade QPL to v1.4.0+Fix qpl_deflate codec bug for polling timeout
2024-02-23 11:24:06 +01:00
Raúl Marín
1a4b4d493f
Merge pull request #60228 from Algunenano/parallel_replicas_2
Treat 2+ in allow_experimental_parallel_reading_from_replicas as 2
2024-02-23 11:17:23 +01:00
Robert Schulze
38d4d1fb57
Merge remote-tracking branch 'ClickHouse/master' into iaadeflate_upgrade_qpl_v1.4.0 2024-02-23 10:01:01 +00:00
Antonio Andelic
7ea44f95e3
Merge pull request #60226 from ClickHouse/keeper-better-snapshot
Slightly better Keeper loading from snapshot
2024-02-23 08:49:15 +01:00
Yakov Olkhovskiy
ef44da04fd third argument should be skipped too 2024-02-22 23:59:29 +00:00
Igor Nikonov
8f3ca99cfc
Merge pull request #60252 from ClibMouse/bugfix/http-exception-codes
Fix http exception codes.
2024-02-22 19:17:51 +01:00
János Benjamin Antal
7cad0050c0
Disambiguate alter commands list (#59532)
* Add optional parentheses to TTL element and alter command

* Add some basic tests

* Extend tests with more test cases

* Add one more test case

* Add server setting to control new formatting behavior

* Automatic style fix

* Fix segfault in `clickhouse-format` related to new server setting

* Remove format_ttl_expressions_with_parentheses

* Fix unit test compilation failures

* Introduce global flag to control the new formatting behavior

* Revert "Fix segfault in `clickhouse-format` related to new server setting"

This reverts commit d7131a3145.

* Revert accidental changes

* Revert accidental include reorder

* Revert accidental changes

* Enable new format in client and local server

---------

Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
2024-02-22 19:17:15 +01:00
Alexander Tokmakov
e56748a92c
Merge pull request #60044 from ClickHouse/fix_undead_sessions
Ability to detect undead ZooKeeper sessions
2024-02-22 18:13:15 +01:00
Vitaly Baranov
b130726a0c
Merge branch 'master' into add-config-setting-remove-backup-files-after-failure 2024-02-22 18:09:12 +01:00
pufit
57306706b3
Add definers for views (#54901) 2024-02-22 17:47:50 +01:00
avogar
acf2fe3529 Fix permute for ColumnVariant 2024-02-22 16:29:00 +00:00
vdimir
4a7ad15a9a
Log dictionary name during loading 2024-02-22 14:58:01 +00:00
Azat Khuzhin
0cb6f205d7 Fix actions execution during preliminary filtering (PK, partition pruning)
Previously preliminary filtering works incorrectly if input columns had
been used multiple times, because:
- position initialized only for the first user
- column had been moved, so the second user will get nullptr

And this was the case when it had been required multiple times.

Consider the following example:

    select * from data final prewhere indexHint(_partition_id = 'all') or indexHint(_partition_id = 'all')

Actions for this PREWHERE is the following:

    (lldb) p actions.__ptr_->dumpActions()
    (std::string) $1 = "input:
    _partition_id LowCardinality(String)
    _partition_id LowCardinality(String)

    actions:
    INPUT : 0 -> _partition_id LowCardinality(String) : 0
    COLUMN Const(String) -> 'all' String : 1
    COLUMN Const(String) -> 'UInt8'_String String : 2
    INPUT : 1 -> _partition_id LowCardinality(String) : 3
    COLUMN Const(String) -> 'all' String : 4
    COLUMN Const(String) -> 'UInt8'_String String : 5
    FUNCTION equals(_partition_id :: 0, 'all' :: 1) -> equals(_partition_id, 'all') LowCardinality(UInt8) : 6
    FUNCTION equals(_partition_id :: 3, 'all' :: 4) -> equals(_partition_id, 'all') LowCardinality(UInt8) : 1
    FUNCTION _CAST(equals(_partition_id, 'all') :: 6, 'UInt8'_String :: 2) -> _CAST(equals(_partition_id, 'all'), 'UInt8'_String) UInt8 : 4
    FUNCTION _CAST(equals(_partition_id, 'all') :: 1, 'UInt8'_String :: 5) -> _CAST(equals(_partition_id, 'all'), 'UInt8'_String) UInt8 : 2
    FUNCTION or(_CAST(equals(_partition_id, 'all'), 'UInt8'_String) :: 4, _CAST(equals(_partition_id, 'all'), 'UInt8'_String) :: 2) -> or(indexHint(), indexHint())"...

It has _partition_id column in input multiple times.

So fix this by adding a flag (`allow_duplicates_in_input`), if set,
columns will be fully initialized.

v2: fix "Position out of bound in Block::erase()"
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-22 15:01:57 +01:00
Azat Khuzhin
be2ec93a3f Remove commented code in ExpressionActions::execute()
This information will be added to the exception anyway.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-22 15:01:57 +01:00
Alexander Tokmakov
97ed2c05b0 Merge branch 'master' into fix_undead_sessions 2024-02-22 14:36:36 +01:00
Nikita Taranov
b44e4c6d78
Merge branch 'master' into fix_head_bucket_after_update 2024-02-22 14:32:00 +01:00
Yarik Briukhovetskyi
ab634a308d
Merge branch 'ClickHouse:master' into fix_datetime64_scale_conversion 2024-02-22 13:22:04 +01:00
Nikolai Kochetov
c3f925da0a
Merge pull request #60164 from kitaisreal/copy-s3-file-gcp-fallback-to-buffer-copy
Copy S3 file GCP fallback to buffer copy
2024-02-22 12:53:15 +01:00
Nikolai Kochetov
0e6b55ad35
Merge pull request #60220 from kitaisreal/system-backups-system-backup-log-add-query-id-and-error-stacktrace
Tables system.backups and system.backup_log add query_id and error stacktrace
2024-02-22 12:43:52 +01:00
kssenii
222323f293 Fix 2024-02-22 12:38:13 +01:00
Blargian
7175eec931 add toMilliseconds implementation, update docs and reference file of test 2024-02-22 12:32:29 +01:00
Kseniia Sumarokova
fb7924cdb1
Merge pull request #60233 from ClickHouse/hide-sensitive-info-in-s3-queue
Hide sensitive info for s3queue
2024-02-22 11:37:15 +01:00
Robert Schulze
ae597d86dd
Merge remote-tracking branch 'rschu1ze/master' into vector-dot-product 2024-02-22 10:16:28 +00:00
Robert Schulze
d2cb434be9
Merge remote-tracking branch 'ClickHouse/master' into revert-59450-order-by-all-ambiguities 2024-02-22 10:12:14 +00:00
Robert Schulze
d638820478
Merge remote-tracking branch 'ClickHouse/master' into iaadeflate_upgrade_qpl_v1.4.0 2024-02-22 10:07:49 +00:00
Smita Kulkarni
0eefab131d Updated pos check 2024-02-22 11:05:33 +01:00
Smita Kulkarni
f1d5892d50 Fix style check 2024-02-22 10:06:33 +01:00
Azat Khuzhin
a4f765cae7
Improve performance of SELECTs with active mutations (#59531)
* Configure keeper for perf tests

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Improve performance of SELECTs with active mutations

getAlterMutationCommandsForPart() can be a hot path for query execution
when there are pending mutations.

- LOG_TEST - it is not only check one bool, but actually a bunch of
  atomics as well.

- Return std::vector over std::map (map is not required there) - no
  changes in performance.

- Copy only RENAME_COLUMN (since only this mutation is required by
  AlterConversions).

And here are results:

run|result
-|-
SELECT w/o ALTER|queries: 1565, QPS: 355.259, RPS: 355.259
SELECT w/ ALTER unpatched|queries: 2099, QPS: 220.623, RPS: 220.623
SELECT w/ ALTER and w/o LOG_TEST|queries: 2730, QPS: 235.859, RPS: 235.859
SELECT w/ ALTER and w/o LOG_TEST and w/ RENAME_COLUMN only|queries: 2995, QPS: 290.982, RPS: 290.982

But there are still room for improvements, at least MergeTree engines
could implement getStorageSnapshotForQuery().

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Add AlterConversions::supportsMutationCommandType(), flatten vector<vector<MutationCommand>>

* Work around what appears to be a clang static analysis bug

---------

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Co-authored-by: Michael Kolupaev <michael.kolupaev@clickhouse.com>
2024-02-22 08:51:10 +00:00
Antonio Andelic
1b238d1180
Merge pull request #59460 from ClickHouse/keeper-logs-cache
Keeper log cache
2024-02-22 09:03:41 +01:00
lgbo-ustc
501e05fda1 fixed: improber filter setting 2024-02-22 09:22:28 +08:00
kothiga
0bc7c0a558
Addressing feedback. 2024-02-21 17:01:16 -08:00
Alexey Milovidov
5b086744f2 Crash 2024-02-21 21:39:58 +01:00
Robert Schulze
7930c2a993
Better! 2024-02-21 20:31:49 +00:00
Alexander Tokmakov
c5ab1893d7 Merge branch 'master' into modify-engine 2024-02-21 20:37:58 +01:00
Alexey Milovidov
2d9fbaa859 Merge with master 2024-02-21 20:37:48 +01:00
Alexander Tokmakov
64a80f1011
Fix default path when path is not specified in config (#59654)
* Update Server.cpp

* Update SentryWriter.cpp

* Update Keeper.cpp

* Update SentryWriter.cpp
2024-02-21 20:33:39 +01:00
Raúl Marín
453d4d30cf
Revert "Support resource request canceling" 2024-02-21 20:19:00 +01:00
Alexander Tokmakov
fcfea17657
Update gtest_storage_log.cpp 2024-02-21 20:16:14 +01:00
Smita Kulkarni
29b7bf64d4 Fix issues with endpoint and prefix 2024-02-21 20:04:12 +01:00
kothiga
692b31e467
Fix http exception codes. 2024-02-21 10:53:49 -08:00
Alexey Milovidov
5076dd6266 Fix inconsistent formatting of lambda functions 2024-02-21 19:19:17 +01:00
Robert Schulze
52afa46e23
Revert "Replace ORDER BY ALL by ORDER BY *" 2024-02-21 19:05:20 +01:00
Nikita Mikhaylov
8d47e5ad14 Merge branch 'master' of github.com:ClickHouse/ClickHouse into shabroo/master 2024-02-21 17:56:02 +00:00
Alexey Milovidov
659d30774d Fix MODIFY REFRESH formatting 2024-02-21 18:37:46 +01:00
Alexey Milovidov
23afd322c9 Fix CREATE SETTINGS PROFILE 2024-02-21 18:25:21 +01:00
Alexey Milovidov
f726cb4800 Fix CREATE USER query 2024-02-21 17:56:36 +01:00
Nikolai Kochetov
0e9d7f3540
Merge pull request #60037 from ClickHouse/fix-01656_test_query_log_factories_info-for-analyzer
Fix 01656_test_query_log_factories_info with analyzer.
2024-02-21 17:37:15 +01:00
Alexey Milovidov
716d986238 Fix shit in CREATE INDEX 2024-02-21 17:29:15 +01:00
Robert Schulze
3e9a05d1ad
Minor fixups 2024-02-21 16:24:22 +00:00
Robert Schulze
310aff9b6f
Merge remote-tracking branch 'ClickHouse/master' into iaadeflate_upgrade_qpl_v1.4.0 2024-02-21 16:22:32 +00:00
Antonio Andelic
0b58aa6ec3 better 2024-02-21 17:08:44 +01:00
kssenii
c05c3944d1 Hide sensitive info for s3queue 2024-02-21 16:49:53 +01:00
Sergei Trifonov
19e81c20ca
Merge pull request #59032 from ClickHouse/cpu-scheduler-and-cc
Support resource request canceling
2024-02-21 16:16:24 +01:00
serxa
69c5fae1bc review fixes 2024-02-21 15:11:50 +00:00
Maksim Kita
5ba371662f Backups delete suspicious file 2024-02-21 18:10:27 +03:00
yariks5s
a69243e104 Merge branch 'group_array_intersect' of github.com:yariks5s/ClickHouse into group_array_intersect 2024-02-21 15:05:31 +00:00
yariks5s
434ca081bd fix fuzzer 2024-02-21 15:05:22 +00:00
Igor Nikonov
7411e81bec Fix style 2024-02-21 15:00:25 +00:00