thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-02 12:32:04 +00:00
Code Issues Packages Projects Releases Wiki Activity
105,517 Commits 9,194 Branches 1,782 Tags 2.2 GiB
96bb99f864
Commit Graph

35838 Commits

Author SHA1 Message Date
taiyang-li
09c1cecb01 fix build error 2023-01-10 10:56:13 +08:00
Alexey Milovidov
df4e60b47e
Merge pull request #45053 from ClickHouse/client-fix-data-race 
Fix (benign) data race in clickhouse-client
 2023-01-10 05:18:41 +03:00
Alexey Milovidov
3b086d1990
Merge pull request #45039 from ClickHouse/fix-coordination-unit-tests 
Small fixes for Coordination unit tests
 2023-01-10 05:12:37 +03:00
Alexey Milovidov
dcae391210
Merge pull request #45061 from kitaisreal/range-hashed-dictionary-update-field-primary-key-fix 
RangeHashedDictionary update field primary key fix
 2023-01-10 05:11:12 +03:00
Alexey Milovidov
db5aa58370
Merge pull request #45064 from kitaisreal/analyzer-function-in-crash-fix 
Analyzer function IN crash fix
 2023-01-10 05:10:20 +03:00
Alexey Milovidov
3963eeae16
Merge pull request #45058 from nickitat/fix_grouping_sets_with_memory_efficient_aggr 
Disable memory efficient merging for distributed aggregation when grouping sets are present
 2023-01-10 05:08:55 +03:00
Alexey Milovidov
1229a20fb3
Merge pull request #45047 from ClickHouse/fix-buffer-overflow 
Fix buffer overflow in parser
 2023-01-10 05:06:03 +03:00
Yakov Olkhovskiy
2559c49810 make only IPv4 as numeric, fix hash functions for IPv6, add more hash functions to test 2023-01-10 02:03:06 +00:00
Alexey Milovidov
d6748f9fae
Merge pull request #45065 from ClickHouse/fix-low-cardinality-in-nested-lambda-capture 
Fix Cannot capture column for nested lambda with LowCardinality
 2023-01-10 04:50:46 +03:00
Alexey Milovidov
c1ae35958d
Merge pull request #45067 from kitaisreal/jit-compilation-float-to-bool-conversion-fix 
JIT compilation float to bool conversion fix
 2023-01-10 04:45:00 +03:00
serxa
6f31c5094d Merge branch 'cancellable-mutex' of github.com:ClickHouse/ClickHouse into cancellable-mutex 2023-01-10 01:27:11 +00:00
serxa
0f80ad6e06 make style-check happy 2023-01-10 01:26:59 +00:00
Sergei Trifonov
b4961a6253
Merge branch 'master' into cancellable-mutex 2023-01-10 02:20:42 +01:00
Alexander Gololobov
4a6ceb8a66
Merge pull request #44959 from liangliangpan/liangliangpan-patch-fix-alter-ttl-error 
fix alter table ttl error  when wide part has light weight delete mask
 2023-01-10 01:17:08 +01:00
Yakov Olkhovskiy
4f32f3b8cb
Merge pull request #44484 from bigo-sg/arrow_struct_field 
Optimization for reading struct fields in parquet/orc files
 2023-01-09 15:36:26 -05:00
Nikolai Kochetov
3e430b1b6e Add comments. Remove unused flag from Context. 2023-01-09 19:52:11 +00:00
serxa
ae56ac1b56 add TSA support 2023-01-09 16:46:07 +00:00
Maksim Kita
4236bc32ee Analyzer duplicate alias crash fix 2023-01-09 16:38:18 +01:00
Maksim Kita
0ba597240e JIT compilation float to bool conversion fix 2023-01-09 16:35:06 +01:00
serxa
534db794c1 more review fixes 2023-01-09 15:05:41 +00:00
serxa
88c3c2946b review fixes + split into files 2023-01-09 14:58:44 +00:00
Alexander Gololobov
742887ce53
Merge pull request #44718 from ClickHouse/lwd_mutation_always_sync 
Make lightweight deletes always synchronous
 2023-01-09 15:58:02 +01:00
Nikolai Kochetov
86324e231c Fix Cannot capture column for nested lambda with LowCardinality 2023-01-09 14:57:09 +00:00
Maksim Kita
f96cdc7e47 Analyzer function IN crash fix 2023-01-09 15:35:14 +01:00
Alexander Gololobov
321c987a51
Merge branch 'master' into liangliangpan-patch-fix-alter-ttl-error 2023-01-09 15:17:12 +01:00
Antonio Andelic
22679ddf11
Add comment 2023-01-09 14:26:20 +01:00
Anton Popov
1e5d6e44a5 fix deadlock at shutdown 2023-01-09 13:07:46 +00:00
Maksim Kita
83a8d3ed25 RangeHashedDictionary update field primary key fix 2023-01-09 13:52:15 +01:00
taiyang-li
a8da7b4c20 change as request 2023-01-09 20:39:46 +08:00
taiyang-li
4bc2c61406 change as request 2023-01-09 20:37:16 +08:00
Antonio Andelic
a39f437306
Typo fix 2023-01-09 13:34:48 +01:00
Kseniia Sumarokova
b22b51213f
Merge pull request #44868 from kssenii/improve-async-buffer-from-remote 
Small perf improvement for async buffer from remote
 2023-01-09 13:31:15 +01:00
Nikita Taranov
006fdd32d4
Apply preallocation optimisation more carefully (#44455) 
* impl

* add perf test

* fix

* review fixes
 2023-01-09 13:30:48 +01:00
Nikita Mikhaylov
857799fbca
Parallel distributed insert select with s3Cluster [3] (#44955) 
* Revert "Revert "Resurrect parallel distributed insert select with s3Cluster (#41535)""

This reverts commit b8d9066004.

* Fix build

* Better

* Fix test

* Automatic style fix

Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
 2023-01-09 13:30:32 +01:00
Kseniia Sumarokova
9ae5ad202a
Merge pull request #44707 from xiedeyantu/s3-add-config 
S3 support upload object using storage class INTELLIGENT_TIERING
 2023-01-09 13:28:53 +01:00
Maksim Kita
5809c6a325 Analyzer ARRAY JOIN crash fix 2023-01-09 13:16:10 +01:00
Nikita Taranov
82963e4227 impl 2023-01-09 12:12:55 +00:00
Antonio Andelic
27b2bae640 make it better 2023-01-09 12:01:22 +00:00
Antonio Andelic
a4f35d5da9 Merge branch 'master' into fix-coordination-unit-tests 2023-01-09 12:00:55 +00:00
Kseniia Sumarokova
119501f1d9
Merge pull request #44698 from Avogar/parquet-bool 
Support Bool type in Arrow/Parquet/ORC
 2023-01-09 12:56:28 +01:00
kssenii
7764fd9ac9 Fix possible cannot-read-all-data 2023-01-09 12:47:55 +01:00
taiyang-li
64bbdee824 fix stule 2023-01-09 19:36:51 +08:00
Alexander Gololobov
ebb17c6a76 More generic fix 2023-01-09 12:06:58 +01:00
Vladimir C
75e9a45341
Merge pull request #44716 from ClickHouse/vdimir/merge_engine_nullable 2023-01-09 11:38:04 +01:00
taiyang-li
20c7c0b1ef change as request 2023-01-09 18:21:31 +08:00
lgbo-ustc
b639bcabc0 some fixes 2023-01-09 18:13:00 +08:00
lgbo-ustc
f127b3a60a update ArrowFieldIndexUtil 2023-01-09 18:13:00 +08:00
lgbo-ustc
a3bdfddc9d support nested table 2023-01-09 18:13:00 +08:00
lgbo-ustc
4f3f781b85 fixed test case 2023-01-09 18:13:00 +08:00
lgbo-ustc
755f03db4e fixed 2023-01-09 18:13:00 +08:00
lgbo-ustc
f6850d96cb fixed missing columns 2023-01-09 18:13:00 +08:00
lgbo-ustc
4cf6beee27 fixed 2023-01-09 18:13:00 +08:00
lgbo-ustc
81e2832133 fixed 2023-01-09 18:13:00 +08:00
lgbo-ustc
77cea49cec fixed including header failure 2023-01-09 18:13:00 +08:00
lgbo-ustc
8f8f6f966b Optimization for reading struct fields in parquet/orc files 2023-01-09 18:13:00 +08:00
Roman Vasin
2995c6d866 Merge branch 'master' of github.com:ClickHouse/ClickHouse into ADQM-634 2023-01-09 08:26:45 +00:00
Sergei Trifonov
a4470dd1b2
Update src/Common/Threading.cpp 
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
 2023-01-09 09:01:44 +01:00
Alexey Milovidov
1f45845e70 Fix (benign) data race in clickhouse-client 2023-01-09 08:49:21 +01:00
Yakov Olkhovskiy
45780644bc fix convert field for IPv4 and IPv6 - as represented by number 2023-01-09 07:27:17 +00:00
Alexey Milovidov
eea5a2c521
Merge branch 'master' into fix-buffer-overflow 2023-01-09 09:15:29 +03:00
Alexey Milovidov
0d39d26a34 Don't fix parallel formatting 2023-01-09 06:15:20 +01:00
Alexey Milovidov
61ff2417e9 Remove some headers 2023-01-09 04:23:10 +01:00
Alexey Milovidov
673472cbdc Fix error 2023-01-09 04:22:13 +01:00
Alexey Milovidov
d331f0ce82 Fix buffer overflow in parser 2023-01-09 03:31:12 +01:00
Alexey Milovidov
0d8d6eca67 Non significant changes 2023-01-09 01:51:05 +01:00
Alexey Milovidov
797dfdd42e Non significant changes 2023-01-09 01:50:19 +01:00
Alexey Milovidov
3430df2f8c Non significant changes 2023-01-09 01:48:57 +01:00
Yakov Olkhovskiy
6ec1592a9f fix hash functions for IPv4 2023-01-08 20:58:09 +00:00
Antonio Andelic
4fcbe14435 Small fixes for Coordination unit tests 2023-01-08 13:44:32 +00:00
Alexey Milovidov
13a045dce4 Fix bad code: postfix increment, multiple effects in one statement 2023-01-08 02:55:02 +01:00
Alexey Milovidov
56d8c4730e Fix function range 2023-01-08 02:50:28 +01:00
Yakov Olkhovskiy
d77178194f fix cutIPv6 function and IPv4 hashing 2023-01-07 21:48:02 +00:00
Sergei Trifonov
a3b81778cd
Merge branch 'master' into cancellable-mutex 2023-01-07 19:34:19 +01:00
Anton Popov
1f32ffedf8
Merge pull request #43221 from ClickHouse/refactoring-ip-types 
Replace domain IP types (IPv4, IPv6) with native
 2023-01-07 12:01:21 +01:00
Alexey Milovidov
9fcd111724
Merge pull request #45003 from amosbird/issue_44979 
Fix minmax_count_projection with _partition_value
 2023-01-07 03:36:56 +03:00
serxa
705c8f01af fix tests 2023-01-07 00:31:53 +00:00
Sergei Trifonov
c65573dd7e
Merge branch 'master' into cancellable-mutex 2023-01-06 23:52:35 +01:00
serxa
00b2c96ce8 fix special builds 2023-01-06 22:48:19 +00:00
Amos Bird
200d40c53d
Fix minmax_count_projection with _partition_value 
Check if virtual column `_partition_value` can be used when building
minmax_count_projection block.
 2023-01-07 05:38:28 +08:00
avogar
ee72799121 Fix tests, make better 2023-01-06 20:46:43 +00:00
Nikolai Kochetov
9c5a8a598a
Merge pull request #44983 from ClickHouse/check-what-if-disable-some-check-in-storage-merge 
Check what if disable some checks in storage Merge.
 2023-01-06 19:45:46 +01:00
kssenii
81070907a2 Better time watch 2023-01-06 18:44:48 +01:00
Dmitry Novik
9d44c7a737
Merge pull request #44541 from ClickHouse/cleanup-resolved-function 
Followup #43761
 2023-01-06 18:09:32 +01:00
Nikolai Kochetov
cadaf35db6
Merge pull request #44987 from ClickHouse/better-check-for-not-existing-input-in-actions-dag 
Fix check for not existing input in ActionsDAG
 2023-01-06 18:02:38 +01:00
Nikolai Kochetov
398ae6a216 Fix style. 2023-01-06 15:33:19 +00:00
Nikolai Kochetov
58c7547f51 Removed check and added a test. 2023-01-06 15:04:00 +00:00
Nikolai Kochetov
72eb74dd67 Fix check for not existing input in ActionsDAG 2023-01-06 14:50:28 +00:00
alesapin
da83e97b4c Fix startup issue 2023-01-06 15:36:53 +01:00
Anton Popov
b25f875674
Merge pull request #44875 from ClickHouse/fix-another-one-cannot-read-all-data-for-lc-dict-error 
Fix right offset for reading LowCardinality dictionary from remote fs
 2023-01-06 15:24:36 +01:00
Ilya Yatsishin
4bedd2ca59
fix style 2023-01-06 15:16:44 +01:00
Han Fei
a4427a05c2 fix build 2023-01-06 14:30:00 +01:00
Nikolai Kochetov
a0dad93a38 Check whatt if disable some checks in storage Merge. 2023-01-06 13:26:15 +00:00
alesapin
b20f07b2cc Merge branch 'master' into fix_rare_race 2023-01-06 14:20:08 +01:00
Kseniia Sumarokova
573d3283b0
Merge pull request #44327 from kssenii/use-new-named-collections-code-2 
Replace old named collections code with new (from #43147) part 2
 2023-01-06 13:06:26 +01:00
Anton Popov
fcdbc8123d better loading of outdated parts 2023-01-06 11:59:54 +00:00
Nikolai Kochetov
bb74db22b3
Merge pull request #44920 from ClickHouse/select-respect-required-columns-order 
Respect requested columns order for select.
 2023-01-06 12:54:18 +01:00
Han Fei
cac7f65b40 fix build 2023-01-06 11:49:34 +01:00
Bharat Nallan Chakravarthy
750ce1eb48 review fixes first round 2023-01-05 22:47:58 -08:00
Alexey Milovidov
b88be9df8c
Merge pull request #44956 from ClickHouse/fix_read_result_consistency_check_on_exception 
Do not check read result consistency when unwinding
 2023-01-06 06:22:42 +03:00
Mingliang Pan
c98e52e9ee
fix alter table ttl error when this table has light weight delete mask file (_row_exists.bin) 
After  applying light weight delete to MergeTree table,  a delete mask file (_row_exists.bin) will appears in the wide part directory.  Then we execute "ALTER TABLE xxxxxx  MODIFY TTL xxxx" to this table, clickhouse will report error in log message:   "NOT_FOUND_COLUMN_IN_BLOCK, Not found column _row_exists  in block".   
The root cause of this bug is that:  in MutationsInterpreter::prepare(), when constructing the select columns,  it does not include the system columns, but only physic columns (not include _row_exists.bin).  however the output block of the execute pipeline contains _row_exists column, then error occurs.

this bug is severe, because mutate TTL will continuously to execute, never end. the only workaround is to truncate the whole table.

the fix is to return all columns including row_exists when executing alter table TTL query
 2023-01-06 10:58:34 +08:00
Alexey Milovidov
1b1a13a9ee
Merge pull request #44957 from vitlibar/increase-log-level-of-tables-dependency-graph 
Up the log level of tables dependencies graphs
 2023-01-06 05:46:39 +03:00
Alexey Milovidov
c1f6555b32
Merge pull request #44755 from ClickHouse/44736_Fix_logical_error_for_qualified_asterisk 
Fix for qualified asterisks with alias table name and column transformer
 2023-01-06 03:28:22 +03:00
Alexey Milovidov
663cc5fcc1
Merge pull request #44886 from eherrerosj/patch-1 
fix-typo
 2023-01-06 03:23:42 +03:00
Alexey Milovidov
a205b41c56
Merge pull request #44947 from Algunenano/background_pool_size_logical 
Change error code on invalid background_pool_size config
 2023-01-06 03:19:40 +03:00
Vitaly Baranov
8a5a2f5b3d Up the log level of tables dependencies graphs. 2023-01-06 00:46:49 +01:00
Alexander Gololobov
1b31b8bb91 Do not check read result consistency when unwinding 2023-01-06 00:26:08 +01:00
avogar
7fcdb08ec6 Detect header in CSV/TSV/CustomSeparated files automatically 2023-01-05 22:57:25 +00:00
Igor Nikonov
a67afdff6a Fix: insert delay calculation 2023-01-05 22:43:41 +00:00
Robert Schulze
9f8b0bf149
Merge pull request #44948 from ClickHouse/fix-TraceCollector-fix 
Fix exception fix in TraceCollector dtor
 2023-01-05 23:16:40 +01:00
Han Fei
744084375c fix build 2023-01-05 22:27:45 +01:00
serxa
d217136ede review fixes 2023-01-05 20:41:36 +00:00
Kseniia Sumarokova
a2a9c7dec5
Update TableFunctionURL.cpp 2023-01-05 21:35:52 +01:00
Alexander Gololobov
102dd8bd45
Merge branch 'master' into lwd_mutation_always_sync 2023-01-05 21:20:14 +01:00
Yakov Olkhovskiy
1be48f706b
Merge pull request #43706 from ClibMouse/s390x_crc32 
s390x weakhash32 support
 2023-01-05 14:45:20 -05:00
Dmitry Novik
ebead611b6
Merge branch 'master' into cleanup-resolved-function 2023-01-05 19:27:08 +01:00
Robert Schulze
9ef7dac0b5
Fix exception fix in TraceCollector dtor 
Cf. #44758

Function try blocks in ctors/dtors implicitly rethrow, making them
more or less useless.

https://www.onlinegdb.com/pCKQA0wTIN (click RUN)

https://stackoverflow.com/questions/5612486/when-is-a-function-try-block-useful/5612508#5612508

Fortunately, this seems the only place like that in the codebase.
 2023-01-05 18:27:07 +00:00
Raúl Marín
b0715ec5eb Change error code on invalid background_pool_size config 2023-01-05 18:47:02 +01:00
Nikolai Kochetov
078f4d947a
Merge pull request #44916 from ClickHouse/fast-fix-incorrect-insert-delay 
Fast fix: force upper bound for time to delay INSERT
 2023-01-05 18:05:03 +01:00
Nikolai Kochetov
f629425f96
Merge pull request #44447 from ClickHouse/42637_Disallow_arrayJoin_in_mutations 
Disallow arrayjoin in mutations
 2023-01-05 18:00:16 +01:00
Han Fei
ae5ee8194b fix check style 2023-01-05 17:52:05 +01:00
Han Fei
f2a9eea995 write docs and optimize regex compile 2023-01-05 17:38:01 +01:00
Nikolai Kochetov
1bbf8c84a4
Update InterpreterSelectWithUnionQuery.cpp 2023-01-05 17:29:16 +01:00
Anton Popov
4447afb14d
Revert "If user only need virtual columns, we don't need to initialize ReadBufferFromS3" 2023-01-05 16:38:20 +01:00
Antonio Andelic
9b3314a931 Fix deadlock in Changelog flush 2023-01-05 14:51:05 +00:00
Sergei Trifonov
3f87e6cd77
Update src/Common/Threading.h 
Co-authored-by: Igor Nikonov <954088+devcrafter@users.noreply.github.com>
 2023-01-05 15:27:51 +01:00
Sergei Trifonov
985dff1dbf
Update src/Common/tests/gtest_threading.cpp 
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
 2023-01-05 15:27:32 +01:00
Sergei Trifonov
c507d7ecef
Update src/Common/tests/gtest_threading.cpp 
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
 2023-01-05 15:27:21 +01:00
Anton Popov
ed00399eb6 Merge remote-tracking branch 'upstream/master' into HEAD 2023-01-05 14:12:02 +00:00
Nikolai Kochetov
9fd56e100a Add a comment. 2023-01-05 13:20:47 +00:00
Igor Nikonov
2a105d1862 Fix stupid mistake - max() -> min() 2023-01-05 12:38:27 +00:00
Igor Nikonov
db46267a95 Fast fix: force upper bound for time to delay INSERT 2023-01-05 12:38:27 +00:00
Ilya Yatsishin
0a60fe6e60
Merge pull request #44895 from Algunenano/ignore_label_issues_on_hwmon 
Ignore hwmon sensors on label read issues
 2023-01-05 12:43:37 +01:00
Robert Schulze
1974e1bf8c
Merge pull request #44479 from ClickHouse/more-robust-astselectquery-formatimpl 
More robust ASTSelectQuery::formatImpl()
 2023-01-05 12:27:40 +01:00
kssenii
fcb042d80c Fix cland tidy 2023-01-05 12:04:07 +01:00
Azat Khuzhin
f5b44cbe0d Optimize and fix metrics for Distributed async INSERT 
In #43406 metrics was broken for a clean start, since they where not
initialized from disk, but metrics for broken files was never
initialized from disk.

Fix this and rework how DirectoryMonitor works with file system:
- do not iterate over directory before each send, do this only once on
  init, after the map of files will be updated from the INSERT
- call fs::create_directories() from the ctor for "broken" folder to
  avoid excessive calls
- cache "broken" paths

This patch also fixes possible issue when current_batch can be processed
multiple times (second time will be an exception), since if there is
existing current_batch.txt after processing it you should remove it
instantly.

Plus this patch implicitly fixes issues with logging, that logs
incorrect number of files in case of error (see #44907 for details).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-01-05 11:07:40 +01:00
Ilya Yatsishin
e4d4a2d8ab
Merge pull request #44897 from kssenii/rabbitmq-leak 
Try fix rabbitmq potential leak
 2023-01-05 10:56:56 +01:00
Antonio Andelic
136436958b
Merge pull request #44908 from ClickHouse/fix-keeper-snapshot-on-exit 
Avoid Keeper crash on shutdown (fix `test_keeper_snapshot_on_exit`)
 2023-01-05 08:59:58 +01:00
Nikolay Degterinsky
673ba769e5 Merge remote-tracking branch 'upstream/master' into make_system_replicas_parallel 2023-01-05 02:36:07 +00:00
serxa
abf63d0c33 cleanup 2023-01-05 00:26:28 +00:00
serxa
c4e896f73a cleanup 2023-01-05 00:23:10 +00:00
Sergei Trifonov
5d5cf7d5b0
Merge branch 'master' into cancellable-mutex 2023-01-05 00:50:38 +01:00
serxa
f706cf8903 fix style 2023-01-04 23:49:29 +00:00
serxa
e9e3414ae1 remove debug print 2023-01-04 23:04:04 +00:00
serxa
3ea04f0429 fix typos 2023-01-04 22:59:29 +00:00
serxa
baf6297f1d add fast and cancellable shared_mutex alternatives 2023-01-04 21:50:57 +00:00
Robert Schulze
a4322b3057
Merge pull request #44894 from ClickHouse/upgrade-googletest 
Upgrade googletest to latest HEAD
 2023-01-04 21:49:56 +01:00
Nikolai Kochetov
533911b28b Respect requested columns order for select. 2023-01-04 19:59:15 +00:00
Yakov Olkhovskiy
dadd96ba6f
Merge pull request #44135 from ClickHouse/feature-protocol-proxy 
Improve support for PROXYv1 protocol.
 2023-01-04 14:06:17 -05:00
Azat Khuzhin
d06ac2d468 Fix logging message in MergeTreeDataMergerMutator (about merged parts) 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-01-04 19:07:01 +01:00
kssenii
2e758f983f Add logging, remove closing connection in destructor 2023-01-04 18:08:55 +01:00
chen
741dbb5a75
Update StorageS3Settings.h 2023-01-05 00:41:58 +08:00
xiedeyantu
2f59b1d002 better 2023-01-05 00:27:07 +08:00
Yakov Olkhovskiy
7a5a36cbed
Merge branch 'master' into refactoring-ip-types 2023-01-04 11:11:06 -05:00
Dmitry Novik
712de132d9 Fix special build 2023-01-04 16:05:05 +00:00
Dmitry Novik
8f21eb543c Fix argument evaluation order 2023-01-04 16:00:47 +00:00
Antonio Andelic
7c2cdfa65a Don't throw exception if queue is finished 2023-01-04 15:46:38 +00:00
alesapin
92255e5d4b
Merge pull request #43020 from vitlibar/update-aws-c-submodules 
Update aws-c* submodules
 2023-01-04 16:25:22 +01:00
avogar
1f3d75cbf2 Better 2023-01-04 14:58:17 +00:00
alesapin
2a5b4067e4 Review fixes 2023-01-04 15:15:14 +01:00
alesapin
2cd7247619 Merge branch 'master' into fix_rare_race 2023-01-04 15:06:20 +01:00
alesapin
8ddda46d1b
Update src/Storages/StorageReplicatedMergeTree.cpp 
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
 2023-01-04 14:59:46 +01:00
Kruglov Pavel
7062054d60
Merge branch 'master' into schema-inference-uint 2023-01-04 14:50:01 +01:00
Kruglov Pavel
b9bdf62bf3
Merge branch 'master' into parquet-bool 2023-01-04 14:49:41 +01:00
Nikita Mikhaylov
e9c7555365
Use TablesDependencyGraph in DatabaseReplicated recovery process (#44697) 2023-01-04 14:49:39 +01:00
Kruglov Pavel
59263f3ae1
Merge pull request #44501 from Avogar/validate-types 
Validate data types according to settings.
 2023-01-04 14:48:09 +01:00
Kruglov Pavel
90ae405033
Merge pull request #44876 from Avogar/fix-perf-tests 
Revert some changes from #42777 to fix performance tests
 2023-01-04 14:27:17 +01:00
Kruglov Pavel
0c7d39ac7f
Merge pull request #44832 from ucasfl/row-number 
Fix output_format_pretty_row_numbers does not preserve the counter across the blocks
 2023-01-04 14:15:47 +01:00
kssenii
283388cfa6 Simplify loop, add comment 2023-01-04 13:47:15 +01:00
Maksim Kita
2482acc600
Merge pull request #44881 from azat/concurrent-bounded-queue-fix 
Fix ConcurrentBoundedQueue::emplace() return value in case of finished queue
 2023-01-04 15:44:54 +03:00
kssenii
0fe4d0732d Better 2023-01-04 13:17:40 +01:00
kssenii
ae7a5a6554 Better comment 2023-01-04 13:07:56 +01:00
kssenii
cebfddc3ad Better closing of the loop 2023-01-04 13:00:37 +01:00
Enrique Herreros
169580da69 typo 2023-01-04 12:45:39 +01:00
Han Fei
65ef7b4adc fix build 2023-01-04 12:45:12 +01:00
alesapin
c09f83654d
Merge pull request #44533 from ClickHouse/40951_Allow_macro_substitution_in_endpoint 
Allow macro substitution in endpoint of disks
 2023-01-04 12:29:57 +01:00
alesapin
d5e41dbb0b
Update src/Disks/ObjectStorages/Web/registerDiskWebServer.cpp 2023-01-04 12:29:28 +01:00
Raúl Marín
05ce5eec06 Ignore hwmon sensors on label read issues 2023-01-04 12:05:13 +01:00
Robert Schulze
23196ceffd
Upgrade googletest to their lastest main state 2023-01-04 10:44:39 +00:00
Smita Kulkarni
4f0b0236e3 Removed flag from ExpressionAnalyzer and added a check in MutationsInterpreter::addStreamsForLaterStages - 42637 Disallow arrayJoin in mutations 2023-01-04 09:56:44 +01:00
Smita Kulkarni
0e743254df Removed no-parallel tag from test and removed an exception from StorageView - 40907 Parameterized views as table functions 2023-01-04 08:19:15 +01:00
SmitaRKulkarni
bfea112804
Merge branch 'master' into 44736_Fix_logical_error_for_qualified_asterisk 2023-01-04 07:46:04 +01:00
Nikolay Degterinsky
aa41e9b775
Merge pull request #44857 from evillique/fix-msan-build 
Try to fix MSan build
 2023-01-04 04:31:28 +01:00
Alexey Milovidov
a804d9a643
Merge pull request #44856 from ClickHouse/fix-distinct-zero-size-key-44831 
Fix: sorted DISTINCT with empty string
 2023-01-04 05:16:00 +03:00
Alexey Milovidov
fb68fc1bee
Merge pull request #44870 from ClickHouse/fix_flaky_test 
Fix flaky test and several typos
 2023-01-04 05:14:14 +03:00
Alexey Milovidov
3a027d285f
Merge pull request #44828 from ClickHouse/remove-two-lines-of-code 
What if I will remove two lines of code?
 2023-01-04 04:50:52 +03:00
Kruglov Pavel
826d11bfb1
Merge branch 'master' into validate-types 2023-01-04 01:22:12 +01:00
Kruglov Pavel
9056925c7d
Merge pull request #44874 from Algunenano/time_fix 
Do not throw DB::Exception when folders do not exist
 2023-01-04 01:17:57 +01:00
Han Fei
00e717d7ce some improvement 2023-01-03 21:41:51 +01:00
Kruglov Pavel
4e261ab230
Fix JSONCompactEachRow 2023-01-03 21:16:38 +01:00
Nikolay Degterinsky
fc54ee5faf Add comment about the reason for a separate file 2023-01-03 19:43:25 +00:00
Dmitry Novik
1dd32c8336 Validate function arguments in query tree 2023-01-03 19:39:46 +00:00
Azat Khuzhin
a2f17d2d91 Fix ConcurrentBoundedQueue::emplace() return value in case of finished queue 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-01-03 20:36:12 +01:00
Kruglov Pavel
314d95fd71
Fix special build 2023-01-03 20:34:30 +01:00
Alexey Milovidov
cb8e7c8059
Merge pull request #44824 from ClickHouse/stress-test-less-oom 
Less OOM in stress test
 2023-01-03 22:12:34 +03:00
avogar
28eb2dbd4c Revert some changes from #42777 2023-01-03 18:53:03 +00:00
Robert Schulze
27f5aad49e
What happens if I remove 156 lines of code? 2023-01-03 18:51:16 +00:00
Nikolai Kochetov
c51f5e6fac Fix typo. 2023-01-03 18:41:37 +00:00
Robert Schulze
cfb6feffde
What happens if I remove these 139 lines of code? 2023-01-03 18:35:31 +00:00
Nikolai Kochetov
c8ed885bae
Merge pull request #44760 from ClickHouse/fix-crash-in-totals-structure 
Apply type conversions for totals and extrems in RemoteQueryExecutor.
 2023-01-03 19:28:31 +01:00
Nikolai Kochetov
da26f62a9b Fix right offset for reading LowCardinality dictionary from remote fs in case if right mark was in the middle of compressed block. 2023-01-03 18:19:51 +00:00
Dmitry Novik
15f20cb4e8 Fix column comparison 2023-01-03 18:13:31 +00:00
Dmitry Novik
11fa29d243 Get rid of recursion 2023-01-03 17:59:04 +00:00
Dmitry Novik
a84318af5f
Merge branch 'master' into cleanup-resolved-function 2023-01-03 17:52:29 +01:00
Dmitry Novik
6386e83953 Fixes after review 2023-01-03 16:50:06 +00:00
Alexey Milovidov
bdd3ef8920
Merge pull request #44830 from ClickHouse/fix-monotonicity-fuzz-2 
Fix fuzzer report
 2023-01-03 19:42:58 +03:00
Raúl Marín
0785bf6b29 Do not throw DB::Exception when folders do not exist 2023-01-03 17:05:54 +01:00
kssenii
9368a3dc7d Remove redundant 2023-01-03 16:47:42 +01:00
kssenii
67509aa2d5 Merge remote-tracking branch 'upstream/master' into use-new-named-collections-code-2 2023-01-03 16:41:30 +01:00
alesapin
6c8dbcc040 Fix flaky test 01459_manual_write_to_replicas_quorum_detach_attach and several typos 2023-01-03 16:27:51 +01:00
kssenii
bda8f0d410 Better async buffer from remote 2023-01-03 15:27:37 +01:00
SmitaRKulkarni
16fca48f5b
Disable functions in readonly for inserts (#44290) 
Implementation:
* Added a new parameter to ITableFunction::execute to check if query is insert query.
* Used the new parameter in InterpreterInsertQuery::getTable function when calling ITableFunction::execute .
Testing:
* Added test case for INSERT in 02473_functions_in_readonly_mode.sh.

Co-authored-by: Nikita Mikhaylov <mikhaylovnikitka@gmail.com>
 2023-01-03 15:25:04 +01:00
Nikolai Kochetov
f421b4bf13
Merge branch 'master' into fix-crash-in-totals-structure 2023-01-03 14:24:22 +01:00
Nikolai Kochetov
6b1a697b12
Merge pull request #44850 from ClickHouse/respect-context-in-projection-optimization 
Save context created from projection analysis.
 2023-01-03 13:30:51 +01:00
Smita Kulkarni
8a5fd7f96d Added comments and addressed review comments - Allow macro substitution in endpoint 2023-01-03 11:44:26 +01:00
Smita Kulkarni
1f89db78a5 Added is_create_parameterized_view flag in ActionsVisitor, added functions for column manipulation for parameterized view in StorageView, updated tests to fix flaky test issues and addressed small review comments- 40907 Parameterized views as table functions 2023-01-03 11:00:39 +01:00
Robert Schulze
421473e974
Merge pull request #44421 from ClickHouse/revert-of-revert-of-age-function 
Revert revert of age function
 2023-01-03 10:02:18 +01:00
Antonio Andelic
e0b8fd528d
Merge pull request #44842 from ClickHouse/fix-data-race-storage-s3 
Fix data race in StorageS3
 2023-01-03 09:20:08 +01:00
Nikolay Degterinsky
c4431e9931 Fix MSan build 2023-01-03 02:21:26 +00:00
Alexey Milovidov
fcefaa602f Fix error 2023-01-03 01:24:56 +01:00
Alexey Milovidov
fa16abe05e Fix error 2023-01-03 01:23:57 +01:00
Igor Nikonov
b7062c182a Fix: sorted DISTINCT with empty string 2023-01-03 00:23:05 +00:00
Han Fei
7d7de3833b
Merge pull request #44651 from hanfei1991/hanfei/fix-async-insert-cleanup 
fix bug that async blocks cleanup not work
 2023-01-02 21:58:27 +01:00
Dmitry Novik
929300a721
Update MergeTreeData.cpp 2023-01-02 21:18:16 +01:00
Dmitry Novik
04fb410a40
Merge branch 'master' into parallel_parts_cleanup_with_zero_copy 2023-01-02 20:48:39 +01:00
SmitaRKulkarni
16dd6ca02f
Merge branch 'master' into 40951_Allow_macro_substitution_in_endpoint 2023-01-02 20:34:24 +01:00
Alexey Milovidov
b975b22f8b
Merge branch 'master' into stress-test-less-oom 2023-01-02 22:32:41 +03:00
Dmitry Novik
09d9ac6c8e Simplify code 2023-01-02 19:09:45 +00:00
Dmitry Novik
c646048af9
Merge pull request #44461 from ClickHouse/parts-removal-limit 
Add part removal limit for one CleanupThread iteration
 2023-01-02 20:04:19 +01:00
Alexey Milovidov
e855d3519a
Merge branch 'master' into refactoring-ip-types 2023-01-02 21:58:53 +03:00
Dmitry Novik
0a42d698ac Fixes after review 2023-01-02 18:49:29 +00:00
Dmitry Novik
0ecf6164ac Add tests 2023-01-02 18:10:43 +00:00
Dmitry Novik
6e8191367c Fixup 2023-01-02 18:10:43 +00:00
Dmitry Novik
6ae0ffe8d2 Implement optimize_redundant_functions_in_order_by 2023-01-02 18:10:43 +00:00
Nikolai Kochetov
d2630f8321 Add test. 2023-01-02 18:01:53 +00:00
Nikolai Kochetov
09325ff17e Store context created from projection analysis. 2023-01-02 17:00:48 +00:00
alesapin
39331e07d5 Improve logging 2023-01-02 17:05:08 +01:00
alesapin
6fc63878b4 Fix rare race which can lead to queue hang 2023-01-02 16:57:25 +01:00
Kruglov Pavel
f6deea1365
Try fix build 2023-01-02 16:51:11 +01:00
Nikita Taranov
563b27f648
Provide monotonicity info for toUnixTimestamp64* (#44116) 
* impl

* fix
 2023-01-02 16:34:06 +01:00
Kruglov Pavel
4a7c399076
Merge branch 'master' into parquet-bool 2023-01-02 16:33:42 +01:00
avogar
73fecae5ff Fix comments 2023-01-02 15:31:07 +00:00
Kruglov Pavel
ebbd47012e
Merge pull request #44657 from ClickHouse/Avogar-patch-1 
Enable input_format_json_read_objects_as_strings by default
 2023-01-02 16:14:33 +01:00
Kruglov Pavel
0a43976977
Merge branch 'master' into validate-types 2023-01-02 16:10:14 +01:00
Kruglov Pavel
1c2dc05d6e
Merge pull request #44446 from Avogar/arrow-nullables 
Respect setting settings.schema_inference_make_columns_nullable in Parquet/ORC/Arrow formats
 2023-01-02 16:05:57 +01:00
Kruglov Pavel
966f57ef68
Merge pull request #42777 from Avogar/improve-streaming-engines 
Refactor and Improve streaming engines Kafka/RabbitMQ/NATS and data formats
 2023-01-02 15:59:06 +01:00
Antonio Andelic
e07d820156 Fix race on total_size 2023-01-02 14:28:27 +00:00
Azat Khuzhin
b9125bb351
Introduce groupArrayLast() (useful to store last X values) (#44521) 
* Cleanup DataTypeCustomSimpleAggregateFunction::checkSupportedFunctions()

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Remove unused GroupArrayGeneralListImpl

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Introduce groupArrayLast() (useful to store last X values)

Also do some refactoring to make code cleaner:
- rename insert() to insertWithSampler() (since it is used only for
  groupArraySample())
- split merge methods into Last/RNG/...

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-01-02 15:20:21 +01:00
Robert Schulze
24a3085251
Merge pull request #44527 from mrcrypster/patch-3 
Fixed minor errors in functions docs
 2023-01-02 15:05:59 +01:00
Robert Schulze
545576fe01
Merge pull request #43818 from bigo-sg/improve_from_unixtime 
Add new functions to format datetime in joda datetime style
 2023-01-02 13:41:50 +01:00
flynn
7780fae9db fix 2023-01-02 12:38:51 +00:00