Commit Graph

88073 Commits

Author SHA1 Message Date
Robert Schulze
9f1116b385
Enable clang-tidy bugprone-no-escape
Official docs:

  Finds pointers with the noescape attribute that are captured by an
  asynchronously-executed block. The block arguments in dispatch_async()
  and dispatch_after() are guaranteed to escape, so it is an error if a
  pointer with the noescape attribute is captured by one of these
  blocks.
2022-05-08 19:30:55 +02:00
Robert Schulze
ee72bd832d
Enable clang-tidy bugprone-misplaced-widening-cast
Official docs:

  This check will warn when there is a cast of a calculation result to a
  bigger type. If the intention of the cast is to avoid loss of
  precision then the cast is misplaced, and there can be loss of
  precision. Otherwise the cast is ineffective.
2022-05-08 19:20:44 +02:00
Robert Schulze
a5ee67885d
Enable clang-tidy bugprone-forwarding-reference-overload
Official docs:

  The check looks for perfect forwarding constructors that can hide copy
  or move constructors. If a non const lvalue reference is passed to the
  constructor, the forwarding reference parameter will be a better match
  than the const reference parameter of the copy constructor, so the
  perfect forwarding constructor will be called, which can be confusing.
2022-05-08 19:20:14 +02:00
Robert Schulze
543fd7e1e0
Enable clang-tidy bugprone-dynamic-static-initializers
Official docs:

  Finds instances of static variables that are dynamically initialized in
  header files. This can pose problems in certain multithreaded contexts.
2022-05-08 19:19:36 +02:00
Robert Schulze
20513df733
Enable clang-tidy readability-qualified-auto
Official docs:

Adds pointer qualifications to auto-typed variables that are deduced to
pointers. This makes it obvious if a auto typed variable is a pointer.
This check will transform auto to auto * when the type is deduced to be
a pointer.
2022-05-08 19:17:15 +02:00
Robert Schulze
627cc1ccfa
Enable clang-tidy misc-static-assert
Official docs:

  Replaces assert() with static_assert() if the condition is evaluable
  at compile time. The condition of static_assert() is evaluated at
  compile time which is safer and more efficient.
2022-05-08 19:16:41 +02:00
Robert Schulze
7d3913f350
Enable clang-tidy bugprone-assert-side-effect
Official docs:

  Finds assert() with side effect. The condition of assert() is
  evaluated only in debug builds so a condition with side effect can
  cause different behavior in debug / release builds.
2022-05-08 19:15:55 +02:00
Robert Schulze
9c51657821
Enable clang-tidy modernize-replace-auto-ptr
Official docs:

  This check replaces the uses of the deprecated class std::auto_ptr by
  std::unique_ptr (introduced in C++11). The transfer of ownership, done
  by the copy-constructor and the assignment operator, is changed to
  match std::unique_ptr usage by using explicit calls to std::move().
2022-05-08 19:15:21 +02:00
Robert Schulze
7036bc4e99
Enable clang-tidy modernize-unary-static-assert
Official docs:

  The check diagnoses any static_assert declaration with an empty string
  literal and provides a fix-it to replace the declaration with a
  single-argument static_assert declaration.
2022-05-08 19:14:39 +02:00
Robert Schulze
7d1ac7fa7f
Enable clang-tidies clang-analyzer-core.DynamicTypePropagation and clang-analyzer-core.uninitialized.CapturedBlockVariable
Official docs:

  - Generate dynamic type information
  - Check for blocks that capture uninitialized values
2022-05-08 19:13:40 +02:00
Robert Schulze
f2b1748c48
Enable clang-tidy bugprone-suspicious-semicolon
Official docs:

  Finds most instances of stray semicolons that unexpectedly alter the
  meaning of the code.
2022-05-08 19:13:37 +02:00
Robert Schulze
61cbcbf073
Enable clang-tidy readability-misleading-indentation
Official docs:

  Correct indentation helps to understand code. Mismatch of the
  syntactical structure and the indentation of the code may hide serious
  problems.
2022-05-08 19:12:01 +02:00
Robert Schulze
3d3977bad3
Enable clang-tidy cert-err60-cpp
Official docs:

  This check flags all throw expressions where the exception object is
  not nothrow copy constructible.
2022-05-06 00:36:26 +02:00
Robert Schulze
17d93b039a
Merge pull request #36911 from ClickHouse/invert-clangtidy
Invert .clang-tidy
2022-05-05 22:22:18 +02:00
Kseniia Sumarokova
300b8bbce6
Merge pull request #36916 from kssenii/fix-profile-events-in-cached-buffer
Fix profile events in fs cached buffer
2022-05-05 19:23:24 +02:00
Kseniia Sumarokova
224ab38b65
Merge pull request #36801 from ClickHouse/parallel-url-threads
Use mutex per worker in ParallelReadBuffer
2022-05-05 16:36:55 +02:00
Yakov Olkhovskiy
75fc471cfc
Merge pull request #36542 from vdimir/literal_drop_const_issue36279
ASTLiteral clone only value
2022-05-05 09:39:00 -04:00
Vitaly Baranov
dd51265218
Merge pull request #36864 from vitlibar/backup-improvements-4
Backup improvements
2022-05-05 15:37:51 +02:00
Alexey Milovidov
e5e7166515
Merge pull request #36918 from ClickHouse/fix-hardware-benchmark
Benchmark was not loaded properly
2022-05-05 16:26:53 +03:00
Anton Popov
fa1feb238e
Merge pull request #36853 from qoega/add-other-time-microsecons
Add Other Query Time Microseconds Profile Event
2022-05-05 13:58:13 +02:00
Kruglov Pavel
c6e26f6128
Merge pull request #36434 from Avogar/fix-s3-cluster
Fix bug in s3Cluster schema inference
2022-05-05 13:08:49 +02:00
Robert Schulze
8b2f715b72
Further fixup of Linux-specific failures 2022-05-05 12:44:08 +02:00
Nikita Mikhaylov
27fd255be6
Do not throw exception if obsolete setting appeared in top level config (#36917) 2022-05-05 11:50:41 +02:00
Alexander Gololobov
7e3a805ae3
Merge pull request #36572 from ClickHouse/fix-trash-s3-metrics
Everything related to S3 metrics was not good
2022-05-05 11:44:02 +02:00
Robert Schulze
3a7588d109
Fixup clang-tidy 2022-05-05 10:48:02 +02:00
Alexey Milovidov
d0d4fde5ed Benchmark was not loaded properly 2022-05-05 02:25:53 +02:00
Alexey Milovidov
02291d1464
Update CHANGELOG.md 2022-05-05 01:52:45 +03:00
Robert Schulze
4fff7a3d93
Invert .clang-tidy
Instead of disabling all checks + specifying which are enabled
(whitelist), enable all checks + specify which checks are disabled
(blacklist). The same set of checks executes as before.

Motivation:

a) Given the goal to (generally) enable as many checks as possible, a
   blacklist produces a smaller and easier to maintain .clang-tidy file.

b) Many new checks introduced with LLVM 12/13/14 were forgotten to turn
   on. A blacklist makes sure that future compiler upgrades enable new
   checks by default.
2022-05-05 00:31:48 +02:00
alesapin
b76406fc8f
Merge pull request #36910 from ClickHouse/add_test
Fix bug in keeper which could lead to corrupted compressed logs
2022-05-04 23:44:45 +02:00
alesapin
aba78e5ed0
Merge pull request #36859 from ClickHouse/revert-36858-revert-35637-memory-overcommit-free
Revert "Revert "Memory overcommit: continue query execution if memory is available""
2022-05-04 23:43:00 +02:00
kssenii
808ab75d74 Fix 2022-05-04 23:17:31 +02:00
Alexander Tokmakov
e30365a531
Merge pull request #36872 from ClickHouse/fix_exception_message
Add extra info when sending exception
2022-05-04 23:24:47 +03:00
Maksim Kita
26afc5264d
Merge pull request #36908 from kitaisreal/docs-user-defined-executable-functions-config-setting-fix
Docs user defined executable functions config setting fix
2022-05-04 20:58:23 +02:00
Mikhail f. Shiryaev
0b3aac5660
Merge pull request #34797 from ClickHouse/performance-fails
Fail performance comparison on errors in the report
2022-05-04 20:45:32 +02:00
Yakov Olkhovskiy
9c1a06703a
Merge pull request #36564 from awakeljw/fork_chmaster2
Fix CAST Object to Object with Nullable subcolumns
2022-05-04 14:40:43 -04:00
Kruglov Pavel
77e55c344c
Merge pull request #36667 from Avogar/mysqldump-format
Add MySQLDump input format
2022-05-04 19:49:48 +02:00
Kruglov Pavel
c0812239ea
Merge pull request #36845 from azat/tests-02260_alter_compact_part_drop_nested_column
tests: disable 02260_alter_compact_part_drop_nested_column for <=22.4
2022-05-04 19:45:42 +02:00
Robert Schulze
c48d9a4174
Merge pull request #36844 from rschu1ze/shared_ptr_helper3
Remove inherited create() method + disallow copying of storages
2022-05-04 19:16:30 +02:00
alesapin
bc50ddc37a Fix typos in text 2022-05-04 18:43:50 +02:00
alesapin
63f15368ff Remove unused header 2022-05-04 18:30:23 +02:00
alesapin
c09825919b Better comments 2022-05-04 18:24:28 +02:00
alesapin
c6556da5fc Fix bug which can lead to corrupted logs in compressed format 2022-05-04 18:08:00 +02:00
mergify[bot]
e0fa563092
Merge branch 'master' into fix_exception_message 2022-05-04 15:56:03 +00:00
Maksim Kita
459aa8ffd9 Documentation setting user_defined_executable_functions_config fix 2022-05-04 17:24:20 +02:00
Kruglov Pavel
97a1a2d665
Fix style 2022-05-04 17:16:02 +02:00
Kruglov Pavel
ffec3655fe
Fix special build 2022-05-04 17:14:15 +02:00
Mikhail f. Shiryaev
37533eb14b
Improve comment FIXME for errors report 2022-05-04 16:56:43 +02:00
Kseniia Sumarokova
b84b745997
Merge pull request #36900 from kssenii/fix-stress
quick tmp fix for stress test
2022-05-04 16:31:03 +02:00
Robert Schulze
e583099158
Fix build, pt. V 2022-05-04 15:50:52 +02:00
Robert Schulze
78cdb3ec64
Merge pull request #36862 from rschu1ze/new-clangtidies
Activated a bunch of LLVM 12/13/14 clang-tidy warnings
2022-05-04 15:26:57 +02:00