Commit Graph

147072 Commits

Author SHA1 Message Date
Pablo Marcos
a06f2aca76 Fix previous commit 2024-07-15 15:03:39 +00:00
Pablo Marcos
7fdf3a0c2d Normalize tag name to meet ClickHouse convention instead of boost 2024-07-15 14:43:59 +00:00
Pablo Marcos
65a61e1c95 Update documentation 2024-07-15 14:41:07 +00:00
Pablo Marcos
10945fe108 Add documentation for system.query_log_metric 2024-07-15 14:23:20 +00:00
Pablo Marcos
076bd9ce6e Add a 11ms concurrent query 2024-07-15 13:25:58 +00:00
Pablo Marcos
720be2a002 Make getting iterators more user friendly 2024-07-15 10:22:27 +00:00
Pablo Marcos
e995387b8a Fix check-style 2024-07-15 09:45:41 +00:00
Pablo Marcos
6024894cec Fix regex to match only specific tables
Previously was matching system.query_log_metric because
system.query_log is contained within.
2024-07-15 09:45:41 +00:00
Pablo Marcos
79ad4d3f73 Update test to make it more stable
Let's use 5s instead of 3s to have less possibilities of ending
up with just 1 diff value for 1000ms interval.

Also, let's remove the logging traces used to debug.
2024-07-15 09:45:41 +00:00
Pablo Marcos
d9abfa0bcb Use boost::multi_index_container instead of std::set
This way we avoid having to create a new container within
stepFunction, since the multi-index set allows us to modify
the values while having several indexes without worrying
about the underneath structure(s).
2024-07-15 09:45:41 +00:00
Pablo Marcos
46f597e3bd Add lots of debugging traces to figure out what's happening 2024-07-15 09:45:41 +00:00
Pablo Marcos
0557ef1730 Fix exception text with proper range 2024-07-15 09:45:41 +00:00
Pablo Marcos
29510163eb Add test and simplify logic 2024-07-15 09:45:41 +00:00
Pablo Marcos
7eb4a0123c Add per-query tracking with different intervals 2024-07-15 09:45:41 +00:00
Pablo Marcos
ca874e67ab Use the proper data structure for queries 2024-07-15 09:45:41 +00:00
Pablo Marcos
8ed2bfcdcf Add naïve implementation of per-query metric 2024-07-15 09:45:41 +00:00
Pablo Marcos
6047000f96 Collect system.query_log_metric at periodic times 2024-07-15 09:45:41 +00:00
Pablo Marcos
018c8d10d3 Move QueryLogMetric to be a periodic log 2024-07-15 09:45:41 +00:00
Pablo Marcos
112db1f05f Update query_log_metric using the progress callback 2024-07-15 09:45:41 +00:00
Pablo Marcos
9b36d0b61c Add system.query_log_metric table 2024-07-15 09:45:41 +00:00
Raúl Marín
e4f348acc7
Merge pull request #66404 from Algunenano/mergetree_private
Untangle setting headers
2024-07-15 08:49:05 +00:00
Max K
a8a04f9e22
Merge pull request #66512 from ClickHouse/ci_fix_builds_2_skip_in_prs
CI: Fix for skipping Builds_2 in PRs' CI
2024-07-15 08:29:19 +00:00
Max K
f311612e91 check filter_out_not_affected_jobs in unit test 2024-07-15 09:59:23 +02:00
Max K
7ef89f169b CI: Fix for skipping Builds_2 in PRs' CI 2024-07-15 09:26:07 +02:00
Robert Schulze
7276ad2888
Merge pull request #66163 from Blargian/docs_partitionID
Add alias `partitionID` for function `partitionId` and add documentation
2024-07-15 06:58:24 +00:00
Robert Schulze
cd719bf8fc
Make the alias case-sensitive 2024-07-15 08:57:11 +02:00
Antonio Andelic
7d62a19f4c
Merge pull request #66439 from azat/jemalloc-clock-assertion
[RFC] Fix jemalloc assertion due to non-monotonic CLOCK_MONOTONIC_COARSE
2024-07-15 06:45:29 +00:00
Alexey Milovidov
89f8c577e4 Do not fix anything 2024-07-15 05:34:14 +02:00
Yakov Olkhovskiy
77396d00d9
Merge pull request #65267 from wudidapaopao/fix_unexpected_cte_projection_name
Fix unexpected projection name when query with CTE
2024-07-15 02:14:42 +00:00
Alexey Milovidov
697f4eae97
Merge pull request #66480 from Blargian/patch-5
Update installation options page
2024-07-14 19:48:55 +00:00
Alexey Milovidov
0e671f72d9
Merge pull request #63643 from ClickHouse/everything-should-work-with-analyzer
Everything should work with Analyzer
2024-07-14 21:52:59 +02:00
Alexey Milovidov
deead28fee
Merge pull request #66499 from ClickHouse/add-one-more-revision-to-ignore
Add one more revision to ignore
2024-07-14 19:26:17 +00:00
Alexey Milovidov
1c24085d5b
Merge pull request #66483 from Blargian/patch-6
Update developer-instruction.md
2024-07-14 18:58:49 +00:00
Alexey Milovidov
fd44c533cf Add one more revision to ignore 2024-07-14 20:57:02 +02:00
Alexey Milovidov
6f3d5704d8
Merge pull request #66489 from rschu1ze/openssl-tsan-follow-up
OpenSSL: Minor follow-up to #66064
2024-07-14 18:54:07 +00:00
alesapin
6a322b5357
Merge pull request #66249 from nauu/rename-to-avoid-ambiguity
Rename FilesystemCacheFailToReserveSpaceBecauseOfLockContention to FilesystemCacheFailToReserveSpaceBecauseOfCacheResize
2024-07-14 14:04:17 +00:00
Nikita Mikhaylov
451e99dcbc
Merge pull request #66482 from ClickHouse/add-test-37557
Add a test for #37557
2024-07-14 13:29:14 +00:00
Robert Schulze
3c39c4f514
Merge remote-tracking branch 'ClickHouse/master' into docs_partitionID 2024-07-14 12:40:05 +00:00
Max K
c889205d52
Merge pull request #66490 from ClickHouse/ci_fix_job_filter_prs
CI: Fix for job filtering in PRs
2024-07-14 12:37:00 +00:00
Max K
9dabf205e6 CI: Fix for await to always await for builds 2024-07-14 14:01:10 +02:00
Max K
f374cdfe69 CI: Fix for job filtering in PRs 2024-07-14 13:53:20 +02:00
Robert Schulze
ad86e3060a
OpenSSL: Follow-up to #66064
More commits were added to the upstream fix after #66064 has been merged
in ClickHouse. This PR adds these commits to keep things in-sync.
2024-07-14 11:48:13 +00:00
Max K
cff67cc0ee
Merge pull request #66488 from ClickHouse/ci_gh_retry
CI: Add retry for GH set_status_comment call
2024-07-14 11:06:24 +00:00
Robert Schulze
0b7ff4c3ee
Merge pull request #63186 from cucumber95/change_date
Add `changeDate*` functions
2024-07-14 10:46:56 +00:00
Max K
379706d2d5 fix for job filtering 2024-07-14 12:08:53 +02:00
Max K
80c8511004 CI: Add retry for GH set_comment_status call 2024-07-14 11:39:31 +02:00
Azat Khuzhin
669ce7cd40 Enable jemalloc heap profiler by default for debug builds as well
Since the issue with jemalloc assertion is clear, let's revert that
workaround

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-07-14 08:21:13 +02:00
Azat Khuzhin
22611781b0 Fix jemalloc assertion due to non-monotonic CLOCK_MONOTONIC_COARSE
Recently one tricky assertion of jemalloc had been discovered [1]:

    Failed assertion: "nstime_compare(&decay->epoch, new_time) <= 0"

  [1]: https://github.com/ClickHouse/ClickHouse/issues/66193

And as it turns out it is really possible for CLOCK_MONOTONIC_COARSE to
go backwards, in a nutshell it can be done with ADJ_FREQUENCY, you can
find example here [2]. And I can't trigger this issue for non-coarse
clocks.

  [2]: https://gist.github.com/azat/7ea7f50ed75591b1af2d675a240ea94c?permalink_comment_id=5119222#gistcomment-5119222

But, jemalloc do not call clock_gettime() that frequently (I've verified
it), so it can use non-coarse version - CLOCK_MONOTONIC

I've also measured the latency of CLOCK_MONOTONIC and
CLOCK_MONOTONIC_COARSE, and it is 20ns vs 4ns per call [3], so make this
change affect performance you need really frequently calls of
clock_gettime.

  [3]: https://gist.github.com/azat/622fa1f9a5d8e7d546ee9d294501961d?permalink_comment_id=5119245#gistcomment-5119245

Interesting, that this bug started to appears only after jemalloc heap
profiler had been enabled by default [4], no clue why (I would believe
more in a more frequent calls to clock_adjtime(ADJ_FREQUENCY), but I
can't verify this)

  [4]: https://github.com/ClickHouse/ClickHouse/pull/65702

To be continued...

Fixes: https://github.com/ClickHouse/ClickHouse/issues/66193
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-07-14 08:21:13 +02:00
Shaun Struwig
5daac46d8c
Merge branch 'ClickHouse:master' into docs_partitionID 2024-07-14 05:34:01 +02:00
Alexey Milovidov
045a7f4b8f Merge branch 'master' of github.com:ClickHouse/ClickHouse into add-test-37557 2024-07-14 01:10:39 +02:00