Commit Graph

318 Commits

Author SHA1 Message Date
Robert Schulze
81e943c7f8
More spelling fixes 2023-02-10 11:20:48 +00:00
Robert Schulze
06e1293909
Fix duplicate includes in poco 2023-02-10 10:50:18 +00:00
Robert Schulze
8144c28c3b
Fix spelling 2023-02-10 10:49:55 +00:00
Robert Schulze
d44c6dd1b3
Merge pull request #46133 from ClickHouse/rs/fix-warnings-in-poco
Stricter warnings + fix whitespaces in poco
2023-02-10 11:46:33 +01:00
Alexander Tokmakov
8101b044fa
Merge pull request #46091 from azat/sanity-assertions
Sanity assertions for closing file descriptors
2023-02-09 01:02:03 +03:00
serxa
8f87dd9957 add Yasm exception for spell checker 2023-02-08 18:23:15 +00:00
Robert Schulze
537a697f65
Fix whitespaces 2023-02-08 11:36:52 +00:00
Robert Schulze
b79ead9c84
Move poco to base/poco/ (#46075)
* Replicate poco into base/poco/

* De-register poco submodule

* Build poco from ClickHouse

* Exclude poco from stylecheck

* Exclude poco from whitespace check

* Exclude poco from typo check

* Remove x bit from sources/headers (the style check complained)

* Exclude poco from duplicate include check

* Fix fasttest

* Remove contrib/poco-cmake/*

* Simplify poco build descriptions

* Remove poco stuff not used by ClickHouse

* Glob poco sources

* Exclude poco from clang-tidy
2023-02-08 12:04:11 +01:00
Azat Khuzhin
0ab351c82e Add close() return value check in check-style
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-06 20:20:15 +01:00
Robert Schulze
b5f5018b10
Fix spelling 2023-01-31 11:55:45 +00:00
FArthur-cmd
3d8e8a84f6 ignore laion as it is dataset's name 2023-01-24 18:41:07 +03:00
Robert Schulze
099e30ef2a
Merge remote-tracking branch 'origin/master' into query-result-cache 2023-01-16 08:04:49 +00:00
Mikhail f. Shiryaev
807e84da98
Delete unused website directory 2023-01-11 16:31:27 +01:00
Robert Schulze
0c3b034887
Merge remote-tracking branch 'origin/master' into query-result-cache 2023-01-10 09:02:41 +00:00
Alexey Milovidov
17c797a405 Enable the check that was commented 2023-01-07 21:42:49 +01:00
Robert Schulze
45dbcf88e5
Merge remote-tracking branch 'origin/master' into query-result-cache 2023-01-06 20:42:48 +00:00
Alexey Milovidov
428404a9f0
Merge pull request #44838 from ClickHouse/check-submodules-escape
Escape submodules in style-check
2023-01-02 17:43:13 +03:00
Mikhail f. Shiryaev
ae93af32a0
Escape submodules in style-check 2023-01-02 14:23:53 +01:00
Azat Khuzhin
26718ccddf check-style: check base for std::cerr/cout too
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-01-02 11:42:59 +01:00
Robert Schulze
e9e04166d9
Merge remote-tracking branch 'origin/master' into query-result-cache 2023-01-02 08:20:27 +00:00
Dan Roscigno
bc456feb4b
Merge pull request #44708 from Avogar/schema-inference-docs
Add detailed documentation about schema inference
2022-12-30 11:19:09 -05:00
avogar
872d5a5699 Fix style 2022-12-29 20:45:10 +00:00
Azat Khuzhin
e719fd218d Add excludes for std::cout usage in LineReader
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 14:23:51 +01:00
Mikhail f. Shiryaev
b5a791ddbc
Merge pull request #44386 from ClickHouse/check-submodules
Add check for submodules sanity
2022-12-19 17:51:56 +01:00
Mikhail f. Shiryaev
815ba5b48f
Add check for submodules sanity 2022-12-19 17:36:03 +01:00
Mikhail f. Shiryaev
3c7cfc297c
Merge pull request #44377 from DanRoscigno/edit-dictionary
add runnable to ignore list
2022-12-19 16:47:03 +01:00
DanRoscigno
ca9f27b68c add runnable to ignore list 2022-12-19 08:36:18 -05:00
Robert Schulze
b93c56323c
Merge remote-tracking branch 'origin/master' into query-result-cache 2022-12-19 09:18:36 +00:00
Robert Schulze
56d9882b43
Fix spell check 2022-12-16 11:24:26 +00:00
Robert Schulze
3a0bd18b62
Typos 2022-12-15 13:06:24 +00:00
Dan Roscigno
59e93bc9c6
Merge branch 'master' into improve_build 2022-12-09 12:40:46 -05:00
Mikhail f. Shiryaev
a0bde8a974
Order the dictionary 2022-12-09 15:29:24 +01:00
Mikhail f. Shiryaev
5fddc411d3
Add retriable and ReplicatedMergeTree 2022-12-09 15:29:02 +01:00
Sema Checherinda
06d6b87bae
Merge pull request #44059 from ClickHouse/nvartolomei-nv/fix-mutate-fetch
Merging #36877
2022-12-09 11:16:57 +01:00
DanRoscigno
d3e5116e24 add changelogs 2022-12-08 18:15:19 -05:00
Alexey Milovidov
2bfe74e863 Add style check 2022-12-08 23:14:22 +01:00
Mikhail f. Shiryaev
9cb2aa1c46
Add python mypy check to CI 2022-11-29 16:50:22 +01:00
Nikita Taranov
8ed5cfc265
Memory bound merging for distributed aggregation in order (#40879)
* impl

* fix style

* make executeQueryWithParallelReplicas similar to executeQuery

* impl for parallel replicas

* cleaner code for remote sorting properties

* update test

* fix

* handle when nodes of old versions participate

* small fixes

* temporary enable for testing

* fix after merge

* Revert "temporary enable for testing"

This reverts commit cce7f8884c.

* review fixes

* add bc test

* Update src/Core/Settings.h
2022-11-28 00:41:31 +01:00
Kruglov Pavel
98d6b96c82
Merge pull request #42033 from mark-polokhov/BSONEachRow
Add BSONEachRow input/output format
2022-11-22 14:45:21 +01:00
Kruglov Pavel
6b3276a741
Fix style 2022-11-15 14:47:29 +01:00
kssenii
616da1f695 Review fixed, style check fix 2022-11-11 16:50:02 +01:00
avogar
cd36caf013 Fix style 2022-11-10 20:37:24 +00:00
Dan Roscigno
61c3de2ec5
Merge branch 'master' into improve_build 2022-10-26 16:23:48 -04:00
Dan Roscigno
c6d6873234
Update aspell-dict.txt 2022-10-24 09:12:15 -04:00
Azat Khuzhin
0c62e09a6e
check-style: fix ErrorCodes check
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-17 10:32:33 +00:00
Azat Khuzhin
631b8e1abb
check-style: fix pattern of allowed chars for ErrorCodes checks
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-14 11:42:52 +00:00
vdimir
ad255206f4
Exclude comments from style-check defined extern 2022-10-14 11:42:18 +00:00
Alexander Tokmakov
4175f8cde6 abort instead of __builtin_unreachable in debug builds 2022-10-07 21:49:08 +02:00
DanRoscigno
700deb152f add toolchain to ignore 2022-10-06 14:47:12 -04:00
Dan Roscigno
ef62f32dd0
Update codespell-ignore-words.list 2022-10-06 14:42:42 -04:00
Anton Popov
a4dee04f7e
fix style check 2022-10-04 15:01:29 +02:00
Kruglov Pavel
060adfbe93
Merge branch 'master' into new-json-formats 2022-09-12 19:37:46 +02:00
avogar
ad68b7be0f Better 2022-09-09 15:01:45 +00:00
Alexey Milovidov
74023efa66
Update aspell-dict.txt 2022-09-04 05:29:37 +03:00
Alexey Milovidov
1ae24b3e65 Update spelling dictionary 2022-09-04 04:07:10 +02:00
Antonio Andelic
e64436fef3 Fix typos with new codespell 2022-09-02 08:54:48 +00:00
Azat Khuzhin
35f5e56159 Update aspell-dict to fix doc check
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-08-29 00:27:19 +02:00
vdimir
f0c13b0531
Add CurrentMetrics::Value to check-style 2022-08-25 09:31:22 +00:00
Alexander Tokmakov
c9bb91c31f
Merge pull request #40232 from ClickHouse/fix_a_bug_with_symlinks_detection
Fix a bug with symlinks detection
2022-08-15 20:28:30 +03:00
Alexander Tokmakov
6f5a7c3bf7 fix a bug with symlinks detection 2022-08-15 12:30:47 +02:00
Kseniia Sumarokova
a6cfc7bc3b
Merge pull request #34651 from alexX512/master
New caching strategies
2022-08-12 17:23:37 +02:00
alexX512
8adf9f2448 fix compile error 2022-08-07 19:59:39 +00:00
alexX512
77def20394 Fix typos in some js code and ignore some typos 2022-08-07 19:59:39 +00:00
Kruglov Pavel
7bbc6c7292
Update aspell-dict.txt 2022-08-01 13:00:44 +02:00
Mikhail f. Shiryaev
f60dcc30fb
Push automatic fix for black format for PRs 2022-07-21 17:01:42 +02:00
Alexey Milovidov
87ebf51cdc Fix style 2022-07-11 22:26:50 +02:00
Azat Khuzhin
53d019a94b check-style: improve ZooKeeper path check for Replicated.*MergeTree tables
- detech all Replicated.*MergeTree tables
- allow default_path_test/uuid in zookeeper path
- improve pattern for filtering tests

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-08 13:19:24 +03:00
Robert Schulze
ee19c218f3
Teach ClickHouse's spellcheck "ClickHouse's" 2022-07-05 14:24:18 +02:00
Kruglov Pavel
4080f055b6
Merge pull request #38477 from Avogar/sql-insert-format
Add SQLInsert output format
2022-07-04 15:06:33 +02:00
Mikhail f. Shiryaev
7a58a8c19b
Merge pull request #38647 from ClickHouse/clickhouse-diagnostics
Clickhouse diagnostics
2022-07-04 12:14:33 +02:00
Mikhail f. Shiryaev
446ead1af4
Fix typos issues it clickhouse-diagnostics 2022-07-04 10:59:39 +02:00
Azat Khuzhin
e4b81e6de9 Add exp_internal for expect tests
This is to catch possible issues like 01565_reconnect_after_client_error in [1].

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/38417/e33f236d502fe9f7906392f4ceffaee44e3c4ce4/stateless_tests__thread__actions__[3/3].html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-02 17:08:06 +03:00
avogar
3b4ecc93bc Fix test and style 2022-06-28 10:48:20 +00:00
Robert Schulze
2c828338f4
Replace hyperscan by vectorscan
This commit migrates ClickHouse to Vectorscan. The first 10 min of
[0] explain the reasons for it.

(*) Addresses (but does not resolve) #38046

(*) Config parameter names (e.g. "max_hyperscan_regexp_length") are
    preserved for compatibility. Likewise, error codes (e.g.
    "ErrorCodes::HYPERSCAN_CANNOT_SCAN_TEXT") and function/class names (e.g.
    "HyperscanDeleter") are preserved as vectorscan aims to be a drop-in
    replacement.

[0] https://www.youtube.com/watch?v=KlZWmmflW6M
2022-06-24 10:47:52 +02:00
Alexey Milovidov
457f49a43e Add a word into spelling dictionary 2022-06-19 05:58:45 +02:00
Alexey Milovidov
d9e558720f Fix typos 2022-06-16 11:38:54 +02:00
vdimir
dc772335ee
Doc typos, dict 2022-06-08 14:31:01 +02:00
vdimir
226fcbdac7
Better check-doc-aspell 2022-06-08 14:28:45 +02:00
vdimir
27ebad89c5
Add doc_spell_output.txt to process_style_check_result.py 2022-06-08 14:28:44 +02:00
vdimir
e820291a02
Fix utils/check-style/check-typos 2022-06-08 14:28:44 +02:00
vdimir
94bddec0bc
More typos checked and fixed 2022-06-08 14:28:41 +02:00
vdimir
251403407f
Update spell check 2022-06-08 14:26:02 +02:00
vdimir
13f03ddb65
Update docspell check 2022-06-08 14:26:02 +02:00
vdimir
abce81058e
Add doc aspell 2022-06-08 14:25:56 +02:00
Alexey Milovidov
eef6a5ec96
Revert "Remove resursive submodules" 2022-06-02 09:41:12 +03:00
Alexey Milovidov
19b8e1324a Forbid recursive submodules 2022-05-28 04:05:10 +02:00
Antonio Andelic
2ca5b7812d Ignore reusable workflow error 2022-05-27 14:15:34 +00:00
Amos Bird
20f63a6fa4
Fix style check 2022-04-29 15:32:53 +08:00
Alexey Milovidov
40357637ec Remove Arcadia 2022-04-16 00:33:32 +02:00
Kruglov Pavel
666ef3586c
Fix typos check 2022-03-29 16:42:01 +02:00
Mikhail f. Shiryaev
31fa28a4c2
Improve black check: show diff in the output 2022-03-28 13:52:35 +02:00
Mikhail f. Shiryaev
5fea6d24fa
Add black formatting check 2022-03-22 17:38:48 +01:00
Mikhail f. Shiryaev
4309236e17
Adjust check-workflows to exit-on-errors 2022-03-22 17:38:46 +01:00
taiyang-li
1b9987ceb1 fix mistake in check-style 2022-03-05 14:22:56 +08:00
Mikhail f. Shiryaev
a7325bbe32
Fix check-workflows in style check, iterate over checks 2022-02-03 18:36:01 +01:00
Azat Khuzhin
7111f411df check-style: ignore comments for currentDatabase() check
Inaccurate, but should OK for check-style scripts.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-01-25 13:16:45 +03:00
Azat Khuzhin
5c8d02724c check-style: add a note about find_path/find_library check
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-01-21 10:11:23 +03:00
Azat Khuzhin
7dcc037296 check-style: add a check that there is no system-wide library in use 2022-01-20 10:02:02 +03:00
alesapin
5257b413d4
Merge pull request #33612 from ClickHouse/workflow-linting
Add actionlint configuration and fix all issues
2022-01-14 11:41:48 +03:00
Mikhail f. Shiryaev
49fa1a1cd3
Add linter and checker for workflow files 2022-01-13 21:40:21 +01:00
taiyang-li
1e102bc1b2 merge master 2022-01-01 09:01:06 +08:00
taiyang-li
9036b18c2f merge master 2021-12-27 15:12:48 +08:00
Azat Khuzhin
6d9d7df9d6 check-style: check for event_time/event_date = today() queries 2021-12-26 16:25:15 +03:00
Azat Khuzhin
78f66c6d72 check-style: remove absolete filters
Follow-up for: eaba6a7f59
2021-12-26 16:13:03 +03:00
avogar
602578deab Update bool serialization/deserialization for Values format 2021-12-24 13:20:58 +03:00
lgbo-ustc
2cebda874d remove debug modification 2021-12-20 11:50:38 +08:00
taiyang-li
2f4e7e1d4e merge master 2021-12-02 19:48:21 +08:00
Azat Khuzhin
b59e0c65ea Fix style-check for ProfileEvents checking 2021-12-01 10:26:00 +03:00
lgbo-ustc
1014ca8c58 make two loops in clearing cached files into one 2021-11-30 17:57:58 +08:00
Alexey Milovidov
ba74a268a4 Forbid files that differ only by character case 2021-11-26 01:27:56 +03:00
Azat Khuzhin
fbe80cd080 Improve style check for ProfileEvents and CurrentMetrics 2021-11-10 21:15:27 +03:00
Azat Khuzhin
e2cdd49dba check-style: remove Parser/New (antrl had been removed) 2021-11-10 21:15:27 +03:00
Azat Khuzhin
fa50dd885c Run pylint for ci scripts 2021-10-27 10:03:23 +03:00
alesapin
6d8853698b Merge branch 'master' into trying_actions 2021-10-19 17:45:37 +03:00
alesapin
1df70af14e Fix style check one more time: 2021-09-30 16:08:12 +03:00
alesapin
2aa852388f Fix style check 2021-09-30 15:34:44 +03:00
kssenii
410b17b4a1 Fix 2021-09-30 06:35:35 +00:00
Azat Khuzhin
e709ead11a Add std::cerr/std::cout style check 2021-09-28 10:28:28 +03:00
Alexey Milovidov
cd7f9d981c Remove ya.make 2021-09-25 04:22:54 +03:00
alexey-milovidov
2990cdfc6d
Update check-style 2021-08-27 23:59:56 +03:00
kssenii
3f7259f955 Check error codes in style-check, update test 2021-08-27 16:26:26 +03:00
Azat Khuzhin
673f3b4d8d check-style: refactor database column filter check 2021-08-09 09:50:50 +03:00
Azat Khuzhin
ba97ffb909 Add system.mutations for database filter check 2021-08-09 09:50:50 +03:00
Azat Khuzhin
2bfdf0d5a1 check-style: check system.projection_parts for database filter 2021-08-08 19:31:57 +03:00
Azat Khuzhin
3cda5960ec check-style: allow currentDatabase() for ReplicatedMergeTree definition too 2021-08-05 10:11:37 +03:00
Azat Khuzhin
09fa82c244 check-style: fix {database} macro pattern 2021-08-05 09:58:21 +03:00
Azat Khuzhin
507eae9aed check-style: skip *.gen for ReplicatedMergeTree check 2021-08-05 09:51:59 +03:00
Azat Khuzhin
a783b05755 check-style: improve check for ReplicatedMergeTree 2021-08-05 09:50:25 +03:00
Azat Khuzhin
6c61d3731e check-style: cover *.j2 too 2021-08-05 09:50:09 +03:00
Azat Khuzhin
617cdd5d4d check-style: add a check for ReplicatedMergeTree in *.sql 2021-08-05 09:49:48 +03:00
Azat Khuzhin
03e28e1cdf check-style: database filter for system.{tables,parts,parts_columns,columns} 2021-05-22 14:07:21 +03:00
Azat Khuzhin
1ad78a39ed check-style: improve current_database check 2021-05-22 14:07:21 +03:00
Alexey Milovidov
63a287ebee Remove garbage from CMakeLists (2) 2021-04-25 02:01:48 +03:00
Alexey Milovidov
4ff812db7f Maybe better support for paths with whitespaces 2021-04-24 22:47:52 +03:00
Azat Khuzhin
6c2622d451 Add style check for ReplicatedMergeTree path 2021-03-16 07:22:32 +03:00
Azat Khuzhin
b9cb8fdbad Exclude contrib for yamllint check 2021-02-21 10:45:05 +03:00
Azat Khuzhin
2db3a6af49 Add yamllint into style check 2021-02-20 23:25:21 +03:00
Anton Popov
47c610be14
Merge pull request #19726 from CurtizJ/style-check
Allow to run all style checks in one file
2021-02-08 16:24:49 +03:00
Azat Khuzhin
7d9c892e60 check-style: fix "fatal: not a git repository: /place/sandbox-data/tasks/0/2/882869720/ClickHouse/.git/modules/contrib/AMQP-CPP" error
check-style uses "git status" to see changed ya.make files.

However it seems that that the sources was cloned some ancient git
version, likely <2.8, since there was a bug, that has been fixed in 2.8
[1]:

    " * A partial rewrite of "git submodule" in the 2.7 timeframe changed
        the way the gitdir: pointer in the submodules point at the real
        repository location to use absolute paths by accident.  This has
        been corrected."

  [1]: cf11a67975/Documentation/RelNotes/2.8.3.txt (L33-L36)
2021-01-30 00:29:21 +03:00
Azat Khuzhin
480c75bacf check-style: pass path to rc file for pylint 2021-01-29 23:11:53 +03:00
Anton Popov
9c2130cc17 allow to run style check from other directories 2021-01-28 03:13:30 +03:00
Anton Popov
6c7ecc1aa0 allow to run all style checks in one file 2021-01-28 02:47:47 +03:00
Alexander Kuzmenkov
331e8211db
Merge pull request #19675 from azat/tests-query_log-current_database
Require current_database filter for tests with query_log/query_thread_log
2021-01-27 18:00:33 +03:00
Azat Khuzhin
9c5d83d6bc Check that tests with query_log/query_thread_log includes current_database filter 2021-01-27 00:18:32 +03:00
Azat Khuzhin
93d375f67a Check clickhouse-test with pylint during style check 2021-01-27 00:14:23 +03:00
Alexander Tokmakov
14e842c197 print stderr of failed subprocess 2021-01-22 17:27:23 +03:00
Alexey Milovidov
aa2e89611d Remove sumburConsistentHash function 2020-12-31 02:22:04 +03:00
Yatsishin Ilya
011d2b4631 disable couple checks for now 2020-12-29 17:57:12 +03:00
Yatsishin Ilya
5869123a86 no empty line for check-duplicate-includes 2020-12-29 17:57:12 +03:00
Yatsishin Ilya
a25fa1996b fix style checks 2020-12-29 17:57:12 +03:00