Commit Graph

256 Commits

Author SHA1 Message Date
Alexey Zatelepin
29b34365e6 Merge branch 'master' into alter-order-by
Conflicts:
	dbms/src/Interpreters/ExpressionAnalyzer.cpp
	dbms/src/Storages/MergeTree/MergeTreeData.cpp
	dbms/src/Storages/MergeTree/MergeTreeDataSelectExecutor.cpp
2018-11-13 16:27:19 +03:00
Alexey Zatelepin
96d7eee785 fix use-after-free in ZooKeeperNodeCache [#CLICKHOUSE-3859] 2018-11-13 16:13:46 +03:00
Alexey Zatelepin
ce1ead5b88 allow arbitrary callbacks in ZooKeeperNodeChange [#CLICKHOUSE-3859] 2018-11-13 16:13:29 +03:00
Alexey Zatelepin
a0a9aad777 Stat data in ZooKeeperNodeCache [#CLICKHOUSE-3859] 2018-11-13 16:13:23 +03:00
proller
a996326efe Fix identation 2018-11-07 15:55:56 +03:00
proller
f86d1a7034 CONTRIB-254 Arcadia fixes (#3475)
* Macos: set ENABLE_EMBEDDED_COMPILER=0 by default (because contrib/llvm temporary broken under macos)

* \n

* arcadia fix

* fix arcadia link

* wip

* wip

* wip

* fix

* wip

* wip

* fix

* try use users from server dir

* Revert "try use users from server dir"

This reverts commit 79b2c6fd9c.

* Fix logging

* fix

* Update ZooKeeperImpl.h
2018-11-01 20:07:20 +03:00
proller
ec11bef633
Build fixes (#3181) 2018-09-28 17:53:20 +03:00
Alexey Milovidov
17b8e20922 Failover for hosts with missing DNS records while connecting to ZooKeeper #3201 2018-09-24 22:09:12 +03:00
Alexey Milovidov
8218cf3a5f ZooKeeper: retry with different node in case when ZK server closed connection in response for our handshake [#CLICKHOUSE-3987] 2018-09-17 18:49:08 +03:00
Alexey Milovidov
fc27be314b Avoid temporary nullptr references [#CLICKHOUSE-2] 2018-09-02 06:00:04 +03:00
Alexey Milovidov
f7107f12b4 Merge branch 'master' into extra-warnings 2018-09-02 03:13:36 +03:00
Alexey Milovidov
ed6b5fe9eb Documentation for ProfileEvents (more) #3010 2018-09-02 03:05:09 +03:00
alexey-milovidov
a05cdfbb45
Merge branch 'master' into extra-warnings 2018-08-31 03:03:44 +03:00
alexey-milovidov
9ff0edc203
Merge pull request #2971 from urykhy/zk-operation-timeout
Make ZK operation timeout configurable
2018-08-28 14:23:09 +03:00
Yury Stankevich
f3024d2fba Make ZK operation timeout configurable 2018-08-27 20:26:19 +03:00
Alexey Milovidov
e5a2dd8624 Merge branch 'master' into extra-warnings 2018-08-27 19:19:04 +03:00
proller
3acce3bff9 Build fix (#2944)
* Build fix

* Better sample build scripts

* zlib apple fix

* fix

* fix

* better so version

* SPLIT_SHARED -> LINK_MODE

* clean
2018-08-27 17:39:20 +03:00
Alexey Milovidov
eb165a0616 Tweak error code in ZooKeeper library for correct expectations from the calling code [#CLICKHOUSE-3916] 2018-08-27 15:19:29 +03:00
Alexey Milovidov
f7796df158 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:26:55 +03:00
Alexey Milovidov
5f21f1ba7d Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:25:45 +03:00
Alexey Milovidov
a1a70d4a65 Enabling -Wzero-as-null-pointer-constant [#CLICKHOUSE-2] 2018-08-26 04:56:34 +03:00
Alexey Milovidov
625f3fea08 Enabling -Wunused-exception-parameter [#CLICKHOUSE-2] 2018-08-26 04:36:41 +03:00
Alexey Milovidov
44e848856e Enabling -Wunused-exception-parameter [#CLICKHOUSE-2] 2018-08-26 04:33:20 +03:00
Alexey Milovidov
d4ef5d05f2 Enabling -Winconsistent-missing-destructor-override [#CLICKHOUSE-2] 2018-08-26 04:26:25 +03:00
Alexey Milovidov
c193d15ef2 Merge branch 'master' into generalize-zookeeper 2018-08-26 03:32:15 +03:00
Alexey Milovidov
8cc3501c04 Attempt to generalize ZooKeeper interface [#CLICKHOUSE-2] 2018-08-25 05:00:36 +03:00
Alexey Milovidov
3475ef5304 Attempt to generalize ZooKeeper interface [#CLICKHOUSE-2] 2018-08-25 04:58:14 +03:00
Alexey Milovidov
4d343a441c Attempt to generalize ZooKeeper interface [#CLICKHOUSE-2] 2018-08-25 04:14:02 +03:00
Alexey Milovidov
2530561086 ZooKeeperImpl: allow to distinguish cases when request was definitely not been processed #2939 2018-08-25 01:50:20 +03:00
Alexey Milovidov
6043ea02de Style #2913 2018-08-24 08:25:00 +03:00
Alexey Zatelepin
b6aa7542d0 add BackgroundSchedulePool::TaskInfo::activateAndSchedule() method
Almost always it (and not activate()) is precisely what is needed.
2018-08-22 16:43:27 +03:00
Alexey Milovidov
3b39f6a4c3 Split ZooKeeperExceptions to three different metrics #2316 2018-08-21 04:27:22 +03:00
proller
159cdbbb3e Try fix build (link order) 2018-08-20 18:34:37 +03:00
Alexey Milovidov
36db216abf Preparation for extra warnings [#CLICKHOUSE-2] 2018-08-10 07:02:56 +03:00
Alexey Milovidov
215ec2be98 Tiny improvement [#CLICKHOUSE-3820] 2018-07-13 20:27:58 +03:00
Alexey Milovidov
c315200e64 Fixed rare error in ZooKeeper library: callback never called in case when network error happens after reading response header but before response body was read - that will lead to deadlock and readonly table [#CLICKHOUSE-3820] 2018-07-13 00:31:38 +03:00
Alexey Milovidov
f80081ca03 Fixed chroot prefix in information about exception for ZooKeeper multi transaction (variant 2) [#MDBSUPPORT-204] 2018-07-10 19:14:27 +03:00
Alexey Milovidov
a26a0f5331 Better exception message for KeeperMiltiException [#MDBSUPPORT-204] 2018-07-10 16:47:14 +03:00
Alexey Milovidov
8e0ae12b4e Miscellaneous [#CLICKHOUSE-2] 2018-07-10 16:43:01 +03:00
Alexey Milovidov
7707b5a209 Improvement [#CLICKHOUSE-3810] 2018-07-08 02:53:49 +03:00
Alexey Zatelepin
7ce74d1730 ZooKeeper client: before the fix we waited 2x longer than necessary before the timeout 2018-06-22 18:30:29 +03:00
alexey-milovidov
f123fce023
Merge pull request #2505 from yandex/use-zookeeper-session-timeout-from-server
Use zookeeper session timeout from zookeeper server.
2018-06-13 22:36:37 +03:00
Nikolai Kochetov
cedf7a309e Use zookeeper session timeout from zookeeper server. 2018-06-13 22:24:54 +03:00
Alexey Milovidov
0bc678474e Merge branch 'feature/support_truncate' of https://github.com/zhang2014/ClickHouse into zhang2014-feature/support_truncate 2018-06-09 17:24:50 +03:00
Alexey Milovidov
f5adbceed2 Non significant changes according to clang's -Weverything, part 3 [#CLICKHOUSE-2] 2018-06-03 23:39:06 +03:00
Alexey Zatelepin
af06ca5d3c Merge branch 'master' into replicated-mergetree-mutations 2018-06-01 16:21:14 +03:00
Alexey Milovidov
3cb68784ad Miscellaneous [#CLICKHOUSE-3753] 2018-05-31 22:30:08 +03:00
Alexey Milovidov
515bd29df7 Better name [#CLICKHOUSE-3753] 2018-05-31 22:28:30 +03:00
Alexey Milovidov
5dbd5b6d68 Fixed error in ZK library [#CLICKHOUSE-3753] 2018-05-31 22:26:21 +03:00
Alexey Zatelepin
c9bb986330 Merge branch 'master' into replicated-mergetree-mutations
Conflicts:
	dbms/src/Storages/MergeTree/AbandonableLockInZooKeeper.h
	dbms/src/Storages/MergeTree/ReplicatedMergeTreePartCheckThread.cpp
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeQueue.cpp
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeQueue.h
	dbms/src/Storages/StorageReplicatedMergeTree.cpp
2018-05-31 18:52:42 +03:00
Alexey Zatelepin
d89221c458 easier init and deactivation of BackgroundSchedulePool tasks 2018-05-31 16:18:52 +03:00
proller
0cd644f5ec Fix test (no zookeeper detection) 2018-05-29 15:48:36 +03:00
Alexey Zatelepin
f6c72f8e56 Merge branch 'master' into replicated-mergetree-mutations
Conflicts:
	dbms/src/Common/ActionBlocker.h
	dbms/src/Storages/MergeTree/ActiveDataPartSet.cpp
	dbms/src/Storages/MergeTree/ActiveDataPartSet.h
	dbms/src/Storages/MergeTree/MergeTreeData.h
	dbms/src/Storages/MergeTree/MergeTreeDataPart.cpp
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeAlterThread.cpp
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeLogEntry.cpp
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeLogEntry.h
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeQueue.cpp
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeQueue.h
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeRestartingThread.cpp
	dbms/src/Storages/StorageMergeTree.cpp
	dbms/src/Storages/StorageReplicatedMergeTree.cpp
	dbms/src/Storages/StorageReplicatedMergeTree.h
2018-05-28 18:37:30 +03:00
Alexey Zatelepin
4ca3bf65f3 test getting abandonable lock in all partitions [#CLICKHOUSE-3747] 2018-05-25 23:05:10 +03:00
zhang2014
fa865636ce ISSUES-2259 add comment & move delete database metadata implementation 2018-05-21 11:38:46 +08:00
zhang2014
6613e56784 ISSUES-2259 support truncate syntax 2018-05-21 11:38:46 +08:00
alexey-milovidov
517318334a
Merge pull request #1722 from silviucpp/background-schedule-pool-fix
Background schedule pool fixed
2018-05-19 19:00:43 +03:00
Vitaliy Lyudvichenko
e8b94b89e9 Removed dbg output, fixed test. [#CLICKHOUSE-2] 2018-05-14 17:14:58 +03:00
Alexey Milovidov
089ef3277f Removed useless code [#CLICKHOUSE-2] 2018-05-07 19:30:47 +03:00
Vitaliy Lyudvichenko
63cc34d3f6 Fixed incorrect failed OP detection in ZooKeeper. [#CLICKHOUSE-2] 2018-05-03 16:34:19 +03:00
Vitaliy Lyudvichenko
e152f223c9 Fix nodes leak in case of session expiration. [#CLICKHOUSE-2] 2018-04-26 22:46:45 +03:00
Silviu Caragea
1dd5a704fc Merge remote-tracking branch 'origin/master' into background-schedule-pool-fix
# Conflicts:
#	dbms/src/Common/ZooKeeper/LeaderElection.h
#	dbms/src/Storages/MergeTree/ReplicatedMergeTreeAlterThread.cpp
#	dbms/src/Storages/MergeTree/ReplicatedMergeTreeCleanupThread.cpp
#	dbms/src/Storages/MergeTree/ReplicatedMergeTreePartCheckThread.cpp
#	dbms/src/Storages/StorageReplicatedMergeTree.cpp
2018-04-24 20:11:59 +03:00
Vitaliy Lyudvichenko
a29a99b7d3 Add test for ZooKeeperImpl with watch and chroot. [#CLICKHOUSE-2] 2018-04-19 22:40:42 +03:00
Alexey Milovidov
9a05dd6161 ZooKeeperImpl: fixed error with watches and chroot [#CLICKHOUSE-2] 2018-04-19 22:21:37 +03:00
Alexey Milovidov
12e33cfd85 Exit from threads when ZooKeeper session is expired (non significant change) [#CLICKHOUSE-2] 2018-04-19 21:16:18 +03:00
Silviu Caragea
32dd4554da Merge remote-tracking branch 'github/master' into background-schedule-pool-fix
# Conflicts:
#	dbms/src/Storages/StorageReplicatedMergeTree.cpp
2018-04-19 09:29:49 +03:00
Alexey Milovidov
2392f87dca ZooKeeper: Fixed error [#CLICKHOUSE-2] 2018-04-10 19:48:43 +03:00
Silviu Caragea
f1b8d4bc39 Merge remote-tracking branch 'github/master' into background-schedule-pool-fix 2018-04-10 16:27:17 +03:00
Silviu Caragea
c547c5a7b0 Merge remote-tracking branch 'origin/background-schedule-pool-fix'
# Conflicts:
#	dbms/src/Common/ZooKeeper/LeaderElection.h
#	dbms/src/Common/ZooKeeper/ZooKeeper.cpp
#	dbms/src/Storages/MergeTree/ReplicatedMergeTreeAlterThread.cpp
#	dbms/src/Storages/MergeTree/ReplicatedMergeTreeCleanupThread.cpp
#	dbms/src/Storages/MergeTree/ReplicatedMergeTreeCleanupThread.h
#	dbms/src/Storages/MergeTree/ReplicatedMergeTreePartCheckThread.cpp
#	dbms/src/Storages/MergeTree/ReplicatedMergeTreeRestartingThread.cpp
#	dbms/src/Storages/StorageReplicatedMergeTree.cpp
2018-04-10 16:20:14 +03:00
Alexey Milovidov
79e319a7b6 ZooKeeper: fixed error [#CLICKHOUSE-2] 2018-04-08 07:45:59 +03:00
Alexey Milovidov
86317fe0f9 ZooKeeper: Fixed error [#CLICKHOUSE-2] 2018-04-08 07:25:13 +03:00
alexey-milovidov
84726e17e8
Merge pull request #2185 from yandex/fix-leader-election-race
Fix races in leader election.
2018-04-07 00:18:26 +03:00
Alexey Milovidov
708dc5ef82 ZooKeeper: fixed error [#CLICKHOUSE-2] 2018-04-06 22:54:18 +03:00
Alexey Zatelepin
3a8ca70d1f fix races in leader election [#CLICKHOUSE-3533] 2018-04-06 19:10:23 +03:00
Alexey Milovidov
9bbd8a968e ZooKeeper: clarifications [#CLICKHOUSE-2] 2018-04-06 09:22:59 +03:00
Alexey Milovidov
0771874695 ZooKeeper: Fixed error when exception is thrown while session expiration and not all callbacks are called [#CLICKHOUSE-2] 2018-04-06 09:19:53 +03:00
Alexey Milovidov
775daa0fe9 Little better [#CLICKHOUSE-2] 2018-04-06 08:49:03 +03:00
Alexey Milovidov
3884146d92 Little better [#CLICKHOUSE-2] 2018-04-06 08:44:17 +03:00
Alexey Milovidov
d9b54a6aae Updated comment [#CLICKHOUSE-2] 2018-04-05 23:47:06 +03:00
Alexey Milovidov
a2ce515a84 ZooKeeper: Fixed potential issue [#CLICKHOUSE-2] 2018-04-05 19:42:54 +03:00
Alexey Milovidov
d3408d45a8 ZooKeeper: fixed error [#CLICKHOUSE-2] 2018-04-05 07:31:04 +03:00
Alexey Milovidov
e00e81c3e9 ZooKeeper: fixed error [#CLICKHOUSE-2] 2018-04-05 07:06:23 +03:00
Alexey Milovidov
403a2c62a2 Miscellaneous [#CLICKHOUSE-2] 2018-04-05 05:56:11 +03:00
Alexey Milovidov
d5c5a34049 Miscellaneous [#CLICKHOUSE-2] 2018-04-05 05:55:21 +03:00
Alexey Milovidov
0dbc8aa1a5 ZooKeeper: added comment [#CLICKHOUSE-2] 2018-04-05 03:53:27 +03:00
Alexey Milovidov
cde5d315f1 ZooKeeper: added comment [#CLICKHOUSE-2] 2018-04-05 03:46:26 +03:00
Alexey Milovidov
0c519c763b ZooKeeper: added comment [#CLICKHOUSE-2] 2018-04-05 03:44:58 +03:00
Alexey Milovidov
b8df381a97 ZooKeeper: changed operation timeout to 10s because some users run ZooKeeper on servers with HDD and high background load [#CLICKHOUSE-2] 2018-04-05 03:02:09 +03:00
Alexey Milovidov
8faea5437a ZooKeeper: Better metrics about active sessions [#CLICKHOUSE-2] 2018-04-05 02:59:37 +03:00
Alexey Milovidov
e4fe1ef4b3 ZooKeeper: Better connection loop [#CLICKHOUSE-2] 2018-04-05 02:43:11 +03:00
Alexey Milovidov
5a525605be ZooKeeper: thread names [#CLICKHOUSE-2] 2018-04-05 02:36:58 +03:00
Alexey Milovidov
ddc4e1e388 ZooKeeper: Better connection loop [#CLICKHOUSE-2] 2018-04-05 02:33:21 +03:00
Alexey Milovidov
e203457d55 Fixed metric ZooKeeperWaitMicroseconds [#CLICKHOUSE-2] 2018-04-04 05:07:12 +03:00
Alexey Milovidov
ba7a0ebf86 Better exception messages [#CLICKHOUSE-2] 2018-04-04 00:40:58 +03:00
Alexey Milovidov
c387b73f70 ZooKeeper: miscellaneous [#CLICKHOUSE-2] 2018-04-04 00:18:46 +03:00
Alexey Milovidov
b0eca318cf ZooKeeper: more instrumentation [#CLICKHOUSE-2] 2018-04-04 00:14:10 +03:00
Alexey Milovidov
8029a9b579 ZooKeeper: more instrumentation [#CLICKHOUSE-2] 2018-04-04 00:11:54 +03:00
Alexey Milovidov
788d8e740d ZooKeeper: more instrumentation [#CLICKHOUSE-2] 2018-04-04 00:07:22 +03:00
Alexey Milovidov
944748e7da Modifications after removing libzookeeper [#CLICKHOUSE-2] 2018-04-03 22:54:35 +03:00
Alexey Milovidov
f5652b4477 Modifications after removing libzookeeper; initialize ZooKeeper session lazily [#CLICKHOUSE-2] 2018-04-03 22:43:33 +03:00