Commit Graph

108467 Commits

Author SHA1 Message Date
Jus
7bedfee7ea
add info for Kafka engine
add info for Kafka engine
2023-02-16 20:53:40 +04:00
Azat Khuzhin
c1d1d95236 Update tests references after PREWHERE changes
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-16 17:21:53 +01:00
Azat Khuzhin
beff5ac795 Fix PREWHERE for Merge with different default types
In case of underlying table has an ALIAS for this column, while in Merge
table it is not marked as an alias, there will NOT_FOUND_COLUMN_IN_BLOCK
error.

Further more, when underlying tables has different default type for the
column, i.e. one has ALIAS and another has real column, then you will
also get NOT_FOUND_COLUMN_IN_BLOCK, because Merge engine should take
care of this.

Also this patch reworks how PREWHERE is handled for Merge table, and now
if you use PREWHERE on the column that has the same type and default
type (ALIAS, ...) then it will be possible, and only if the type
differs, it will be prohibited and throw ILLEGAL_PREWHERE error.

And last, but not least, also respect this restrictions for
optimize_move_to_prewhere.

v2: introduce IStorage::supportedPrewhereColumns()
v3: Remove excessive condition for PREWHERE in StorageMerge::read()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-16 17:21:53 +01:00
kssenii
75d62ee24a Remove support of feature which does not work reliably 2023-02-16 16:41:31 +01:00
Dmitry Novik
c95df21324 Review fixes 2023-02-16 15:38:25 +00:00
Kruglov Pavel
0ed6ddd7ab
Try fix flaky test test_parallel_distributed_insert_select_with_schema_inference 2023-02-16 16:28:47 +01:00
SmitaRKulkarni
f3f459fe34
Merge branch 'master' into 45185_Inner_join_with_where 2023-02-16 16:20:20 +01:00
Smita Kulkarni
6763a9d1ff Updated to not clear on_expression from table_join as its used by future analyze runs 2023-02-16 16:15:18 +01:00
Alexander Tokmakov
cc4932aa35 disable flaky test with cassandra dictionaries 2023-02-16 15:11:34 +01:00
flynn
eae73a1511 fix 2023-02-16 13:42:19 +00:00
Alexander Tokmakov
9feb448a5e fix a race condition 2023-02-16 14:41:18 +01:00
robot-clickhouse
a96d6af17e Automatic style fix 2023-02-16 13:37:40 +00:00
Vladimir C
3f424301cd
Merge pull request #45484 from azat/clickhouse-test-bin-fix 2023-02-16 14:31:11 +01:00
Azat Khuzhin
2dbcfdbe15 Allow to override host for client connection credentials
Introduce new `--connection` option, by default as a connection name
`--host` will be used.

And using --connection you also can specify --host and it will be
overwritten.

Follow-up for: #45715
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-16 14:26:24 +01:00
Alexander Tokmakov
86d177e0ee fix flaky test 2023-02-16 14:19:55 +01:00
Alexander Gololobov
d0f402fa5b
Merge pull request #46391 from ClickHouse/debug-docker
Easy debugging of clickhouse-server in Docker
2023-02-16 14:09:43 +01:00
youennL-cs
6526c2a8ab
[RFC] Replacing merge tree new engine (#41005)
* Add new engine to ReplacingMergeTree corresponding to the ReplacingCollapsingMergeTree

* Add new test for the new ReplacingMergeTree engine

* Limit sign value to -1/1

* Add new engine to ReplacingMergeTree corresponding to the ReplacingCollapsingMergeTree

* Add new test for the new ReplacingMergeTree engine

* Limit sign value to -1/1

* Replace sign column(Int8) by is_deleted(UInt8)

* Add new engine to ReplacingMergeTree corresponding to the ReplacingCollapsingMergeTree

* Add new test for the new ReplacingMergeTree engine

* Limit sign value to -1/1

* Replace sign column(Int8) by is_deleted(UInt8)

* Add new engine to ReplacingMergeTree corresponding to the ReplacingCollapsingMergeTree

* Add new test for the new ReplacingMergeTree engine

* Limit sign value to -1/1

* Replace sign column(Int8) by is_deleted(UInt8)

* Add keyword 'CLEANUP' when OPTIMIZE

* Cleanup uniquely when it's a replacingMergeTree

* Propagate CLEANUP information and change from 'with_cleanup' to 'cleanup'

* Cleanup data flagged as 'is_deleted'

* Fix merge when optimize and add a test

* Fix OPTIMIZE and INSERT + add tests

* New fix for cleanup at the merge

* Cleanup debug logs

* Add the SETTINGS option 'clean_deleted_rows' that can be 'never' or 'always'

* Fix regression bug; Now REplicatedMergeTree can be called as before without 'is_deleted'

* Add Replicated tests

* Disable tag 'long' for our test and cleanup some white spaces

* Update tests

* Fix tests and remove additional useless whitespace

* Fix replica test

* Style clean && add condition check for is_deleted values

* clean_deleted_rows settings is nom an enum

* Add valid default value to the clean_deleted_rows settings

* Update cleanup checkers to use the enum and fix typos in the test

* Fix submodule contrib/AMQP-CPP pointer

* Add missing messages in test reference and remove a print with non derterministic order

* fix replica test reference

* Fix edge case

* Fix a typo for the spell checker

* Fix reference

* Fix a condition to raise an error if is_deleted differ from 0/1 and cleanup

* Change tests file name and update number

* This should fix the ReplacingMergeTree parameter set

* Fix replicated parameters

* Disable allow_deprecated_syntax_for_merge_tree for our new column

* Fix a test

* Remove non deterministic order print in the test

* Test on replicas

* Remove a condition, when checking optional parameters, that should not be sueful since we disabled the deprected_syntaxe

* Revert "Remove a condition, when checking optional parameters, that should not be useful since we disabled the deprected_syntaxe"

This reverts commit b65d64c05e.

* Fix replica management and limit the number of argument to two maximum, due to the possiblity of deprecated table create/attach failing otherwise

* Test a fix for replicated log information error

* Try to add sync to have consistent results

* Change path of replicas that should cause one issue and add few prints in case it's not that

* Get cleanup info on replicas only if information found

* Fix style issues

* Try to avoid replication error 'cannot select parts...' and and replica read/write field order

* Cleanup according to PR reviews
 and add tests on error raised.

* Update src/Storages/MergeTree/registerStorageMergeTree.cpp

Co-authored-by: Alexander Tokmakov <tavplubix@gmail.com>

* Select ... FINAL don't show rows with is_deleted = true

* Update and fix SELECT ... FINAL merge parameter

* Remove is_deleted rows only on the version inserted when merge

* Fix (master) updates issues

* Revert changes that should not be commited

* Add changes according to review

* Revert changes that should not be commited - part 2

---------

Co-authored-by: Alexander Tokmakov <tavplubix@gmail.com>
2023-02-16 16:03:16 +03:00
Mikhail f. Shiryaev
cb5e5b27f2
Merge pull request #46450 from ClickHouse/dont-fetch-submodules
Do not fetch submodules in release.py
2023-02-16 14:00:38 +01:00
alesapin
d08b2753e4
Merge pull request #46367 from ClickHouse/reduce-keeper-build-time
Do not build libclickhouse-keeper-lib.a for standalone keeper
2023-02-16 13:56:27 +01:00
flynn
7f4c23ec8a fix 2023-02-16 12:48:22 +00:00
kssenii
0954a57a6a Enable back 2023-02-16 13:27:58 +01:00
Alexander Gololobov
2145a29cb6
Merge pull request #46461 from cmsxbc/fix-systemd-service
Fix systemd service  file wrong inline comment
2023-02-16 13:02:19 +01:00
cmsxbc
1ad9e217e5 chore: remove starting blank 2023-02-16 19:24:46 +08:00
SuperDJY
7de008a58a Fix systemd service file wrong inline comment
There is no inline comment in systemd unit file.
2023-02-16 19:24:46 +08:00
Maksim Kita
05baf271f0 Analyzer fix table functions with invalid arguments analysis 2023-02-16 12:17:04 +01:00
Maksim Kita
57b5d9852f Fixed build 2023-02-16 12:17:03 +01:00
Maksim Kita
b72ea982b0 Remove unnecessary includes of InterpreterSelectQuery header 2023-02-16 12:17:03 +01:00
Maksim Kita
4ddf1b0f48 Planner filter push down optimization fix 2023-02-16 12:17:03 +01:00
Maksim Kita
6b2adc1ec2 Analyzer storage Merge fixes 2023-02-16 12:17:03 +01:00
Maksim Kita
b1ab2af7ad Analyzer support storage Merge 2023-02-16 12:17:03 +01:00
Maksim Kita
469ad2c51b Fixed build 2023-02-16 12:17:03 +01:00
Maksim Kita
80af0666ea Analyzer support Materialized View 2023-02-16 12:17:03 +01:00
Maksim Kita
be9406ec0e Fixed tests 2023-02-16 12:17:03 +01:00
Maksim Kita
b2cc71f413 Fixed tests 2023-02-16 12:17:03 +01:00
Maksim Kita
c29f3c0f99 Analyzer fix GROUP BY columns validation 2023-02-16 12:17:03 +01:00
Maksim Kita
84065fb13f Analyzer added distributed table functions support 2023-02-16 12:17:03 +01:00
Maksim Kita
9b7cd64093 Analyzer join_use_nulls fix 2023-02-16 12:17:03 +01:00
Maksim Kita
0cba5848ac Fixed tests 2023-02-16 12:17:03 +01:00
Maksim Kita
c0e513efeb Fixed style check 2023-02-16 12:17:03 +01:00
Maksim Kita
afb3eb3c31 Planner JOIN planning fix 2023-02-16 12:17:03 +01:00
Maksim Kita
a090a8449d Analyzer distributed read fix 2023-02-16 12:17:03 +01:00
Maksim Kita
3a624e6bef Analyzer ColumnNode AST conversion fix 2023-02-16 12:17:03 +01:00
Maksim Kita
f21486c95b Analyzer validate that there are no window functions in GROUP BY 2023-02-16 12:17:03 +01:00
Maksim Kita
af38660cf5 Analyzer support ARRAY JOIN with Nested 2023-02-16 12:17:03 +01:00
Maksim Kita
077555bd5d Analyzer support build pushing to views chain 2023-02-16 12:17:03 +01:00
Maksim Kita
f73c49b082 Fixed style check 2023-02-16 12:17:03 +01:00
Maksim Kita
f8442b2a8d Analyzer support LiveView 2023-02-16 12:17:03 +01:00
Maksim Kita
5cc56eb108 Analyzer better support for single_join_prefer_left_table setting 2023-02-16 12:17:03 +01:00
Maksim Kita
7e58e23d3a Analyzer subquery resolve fix 2023-02-16 12:17:03 +01:00
Maksim Kita
70eb41c6a8 Analyzer add single_join_prefer_left_table setting 2023-02-16 12:17:03 +01:00