Commit Graph

5210 Commits

Author SHA1 Message Date
Azat Khuzhin
a96067987e Mark joinGet() as non deterministic (so as dictGet)
joinGet() should not be considered as deterministic function, since
shards could have different data in tables.

Also since now there is allow_nondeterministic_mutations, it could be
used as a workaround for this backward incompatible change.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-13 08:12:53 +02:00
Robert Schulze
b9c185af44
Merge pull request #49678 from azat/build/llvm-16
Switch to LLVM/clang 16 (16.0.3)
2023-05-12 13:47:36 +02:00
Anton Popov
3351ef7398
Merge pull request #49789 from CurtizJ/fix-array-map-tuple
Fix `arrayMap` with array of tuples with single argument
2023-05-12 13:27:40 +02:00
Robert Schulze
922420420c
Merge pull request #49300 from ClickHouse/rs/functdocs
Introduce more fields for in-source function documentation
2023-05-12 11:36:04 +02:00
Robert Schulze
d15f19912f
Merge pull request #49198 from ClibMouse/s390x_reinterpretas_fix
Fix reinterpretAs*() on big endian machines
2023-05-12 10:33:50 +02:00
Alexey Milovidov
76f7f5750d
Merge pull request #49799 from rschu1ze/demange
Typo: demange.cpp --> demangle.cpp
2023-05-12 02:01:49 +03:00
Robert Schulze
8ca804d40e
Typo: demange.cpp --> demangle.cpp 2023-05-11 21:32:12 +00:00
Suzy Wang
70db49cdeb
Merge branch 'master' into s390x_reinterpretas_fix 2023-05-11 14:41:57 -04:00
Anton Popov
84aa97b738 fix arrayMap with array of tuples with single argument 2023-05-11 14:52:01 +00:00
Azat Khuzhin
00fdfa115f Suppress MSan warning in NgramDistanceImpl::unrollLowering()
NgramDistanceImpl::unrollLowering() relies on the fact that PODArray has
padding and it is OK to access more items.

Here is an MSan report:

    ==656==WARNING: MemorySanitizer: use-of-uninitialized-value
        0 0x557fd825485f in DB::NgramDistanceImpl<4ul, char8_t, false, true, false>::vectorConstant(DB::PODArray<char8_t, 4096ul, Allocator<false, false>, 63ul, 64ul> const&, DB::PODArray<unsigned long, 4096ul, Allocator<false, false>, 63ul, 64ul> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, DB::PODArray<float, 4096ul, Allocator<false, false>, 63ul, 64ul>&) (/usr/bin/clickhouse+0x124d885f) (BuildId: 76773125d8739591c75d4f4d263a2ffe7ca96855)
        1 0x557fd824eb83 in DB::FunctionsStringSimilarity<DB::NgramDistanceImpl<4ul, char8_t, false, true, false>, DB::NameNgramSearchCaseInsensitive>::executeImpl(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName>> const&, std::__1::shared_ptr<DB::IDataType const> const&, unsigned long) const (/usr/bin/clickhouse+0x124d2b83) (BuildId: 76773125d8739591c75d4f4d263a2ffe7ca96855)
        2 0x557fd50023b7 in DB::FunctionToExecutableFunctionAdaptor::executeImpl() const (/usr/bin/clickhouse+0xf2863b7) (BuildId: 76773125d8739591c75d4f4d263a2ffe7ca96855)

      Uninitialized value was stored to memory at
        0 0x557fd4f8da5a in __msan_memcpy (/usr/bin/clickhouse+0xf211a5a) (BuildId: 76773125d8739591c75d4f4d263a2ffe7ca96855)
        1 0x557fd8253803 in DB::NgramDistanceImpl<4ul, char8_t, false, true, false>::vectorConstant(DB::PODArray<char8_t, 4096ul, Allocator<false, false>, 63ul, 64ul> const&, DB::PODArray<unsigned long, 4096ul, Allocator<false, false>, 63ul, 64ul> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, DB::PODArray<float, 4096ul, Allocator<false, false>, 63ul, 64ul>&) (/usr/bin/clickhouse+0x124d7803) (BuildId: 76773125d8739591c75d4f4d263a2ffe7ca96855)
        2 0x557fd824eb83 in DB::FunctionsStringSimilarity<DB::NgramDistanceImpl<4ul, char8_t, false, true, false>, DB::NameNgramSearchCaseInsensitive>::executeImpl(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName>> const&, std::__1::shared_ptr<DB::IDataType const> const&, unsigned long) const (/usr/bin/clickhouse+0x124d2b83) (BuildId: 76773125d8739591c75d4f4d263a2ffe7ca96855)
        3 0x557fd50023b7 in DB::FunctionToExecutableFunctionAdaptor::executeImpl() const (/usr/bin/clickhouse+0xf2863b7) (BuildId: 76773125d8739591c75d4f4d263a2ffe7ca96855)

      Uninitialized value was stored to memory at
        0 0x557fd4f8da5a in __msan_memcpy (/usr/bin/clickhouse+0xf211a5a) (BuildId: 76773125d8739591c75d4f4d263a2ffe7ca96855)
        1 0x5580061699f5 in detail::memcpySmallAllowReadWriteOverflow15Impl(char*, char const*, long) build_docker/./src/Common/memcpySmall.h:42:13
        2 0x5580061699f5 in memcpySmallAllowReadWriteOverflow15(void*, void const*, unsigned long) build_docker/./src/Common/memcpySmall.h:57:5
        3 0x5580061699f5 in DB::ColumnString::replicate(DB::PODArray<unsigned long, 4096ul, Allocator<false, false>, 63ul, 64ul> const&) const build_docker/./src/Columns/ColumnString.cpp:462:13
        4 0x558005d3fae4 in DB::ColumnConst::convertToFullColumn() const build_docker/./src/Columns/ColumnConst.cpp:48:18

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-11 16:30:17 +02:00
Robert Schulze
c2a4d89b6f
Fix style 2023-05-11 09:29:05 +00:00
Suzy Wang
d267c914c3
Merge branch 'master' into s390x_reinterpretas_fix 2023-05-10 16:08:50 -04:00
Suzy Wang
24b6ff47ac fix format and some more fix for fixedstring 2023-05-10 13:06:30 -07:00
Robert Schulze
9795d5403f
Merge branch 'master' into rs/msan-randomStringUTF8 2023-05-10 20:16:49 +02:00
Robert Schulze
374dbd9c39
Fix msan issue in randomStringUTF8(<uneven number>) 2023-05-10 17:49:23 +00:00
Suzy Wang
1b21f13605 ip encoding fix 2023-05-09 13:57:22 -07:00
Suzy Wang
ce471a2e8b Updated code as suggested 2023-05-09 13:31:54 -07:00
Robert Schulze
d8d2b0af76
Merge pull request #49466 from ucasfl/str_to_map
add alias str_to_map and mapFromString for extractKeyValuePairs
2023-05-08 10:11:06 +02:00
robot-clickhouse-ci-2
6c02b6b327
Merge pull request #49627 from ClickHouse/rs/obsolete-ccache-knob
CMake: Remove legacy switch for ccache
2023-05-08 00:16:09 +02:00
Robert Schulze
f4eabd967d
Merge pull request #49603 from ClickHouse/rs/makedate-mysql
Implement a MySQL-compatible variant of makeDate()
2023-05-07 21:51:03 +02:00
Robert Schulze
e275da1d31
Remove deprecated logic for ccache 2023-05-07 15:41:56 +00:00
Robert Schulze
b995795971
Fix style 2023-05-07 13:27:57 +00:00
Robert Schulze
aa09b6154b
Various cleanups 2023-05-07 13:06:35 +00:00
Alexey Milovidov
72e1f751bb Fix error in #48300 2023-05-07 04:16:18 +02:00
Robert Schulze
c893302a08
Implement a MySQL-compatible variant of makeDate()
Fixes #49143
2023-05-06 20:11:36 +00:00
Robert Schulze
2986c28761
Small fixes 2023-05-06 18:12:10 +00:00
Robert Schulze
3dfc0bd265
Merge pull request #49413 from azat/build/headers
Slightly reduce inter-header dependencies
2023-05-05 23:37:58 +02:00
Robert Schulze
45c28e1221
Introduce more fields for in-source function documentation 2023-05-05 21:30:21 +00:00
flynn
236a0d9da0 add alias str_to_map and mapFromString for extractKeyValuePairs 2023-05-03 15:46:17 +00:00
Alexander Tokmakov
e399903030
Merge pull request #48548 from ClickHouse/clusters_is_active_column
Add some columns to system.clusters
2023-05-03 17:42:40 +03:00
Alexander Tokmakov
1ec3040d0c
Merge pull request #49420 from ClickHouse/fix_00002
Fix some bad error messages
2023-05-03 13:33:53 +03:00
Azat Khuzhin
2b21b83979 Reduce inter-header dependencies
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-02 21:15:18 +02:00
Alexander Tokmakov
495325f664 fix some bad error messages, suppress others 2023-05-02 17:55:42 +02:00
Shane Andrade
a60ee304b3
Merge branch 'master' into date-trunc-return-date-time 2023-04-28 09:16:40 -07:00
Alexey Milovidov
6dcfdbfaf2
Merge branch 'master' into clusters_is_active_column 2023-04-28 16:16:25 +03:00
Anton Popov
bbdfb9dcd2
Merge pull request #48300 from aiven-sal/aiven-sal/case2
Allow NULLs in CASE and transform
2023-04-28 14:58:47 +02:00
Alexey Milovidov
fd3c588c68
Merge pull request #49200 from CurtizJ/better-map-concat
Allow using function `concat` with `Map` type
2023-04-27 16:40:42 +03:00
Alexey Milovidov
ed97e46d41
Merge pull request #49221 from Algunenano/conversion_typos
Fix some typos in conversion functions
2023-04-27 03:00:40 +03:00
Robert Schulze
ca62b3d177
Merge pull request #49183 from ClickHouse/rs/doc-makedate
Document makeDateTime() and its variants
2023-04-26 22:45:24 +02:00
Raúl Marín
7bdc5fa88f Fix some typos in conversion functions 2023-04-26 20:45:11 +02:00
Robert Schulze
76e80497ed
Fix replace[Regexp]{One,All}() with const haystacks 2023-04-26 18:18:11 +00:00
Anton Popov
871f9265cc allow using function 'concat' with Map type 2023-04-26 14:39:59 +00:00
Suzy Wang
6035f79bf6 fix reinterpretAs queries on s390x 2023-04-26 07:30:30 -07:00
Robert Schulze
ad15749b4e
Document makeDateTime() and its variants
Follow-up to #35628
2023-04-26 12:22:05 +00:00
Kseniia Sumarokova
b8f7abf507
Merge pull request #48768 from bigo-sg/improve_json_path
Improve jsonpath support in json functions
2023-04-26 12:50:54 +02:00
Salvatore Mesoraca
70a8d7ef08
Prevent types too large for UInt64 from being used 2023-04-26 10:46:35 +02:00
Salvatore Mesoraca
e2d4e08c3b
Fix more issues with Decimals
These issues were already present in the original code
2023-04-26 10:46:34 +02:00
Salvatore Mesoraca
5bbe0d472e
Rename variables with misleading names 2023-04-26 10:46:34 +02:00
Salvatore Mesoraca
5f589e20a3
Add missing check for argument type 2023-04-26 10:46:34 +02:00
Salvatore Mesoraca
d65f98ea25
Fix warning 2023-04-26 10:46:34 +02:00