Commit Graph

14839 Commits

Author SHA1 Message Date
alesapin
d68338a792
Merge pull request #24979 from nvartolomei/nv/parts-uuid-move-shard-acl
Part movement between shards ACL
2021-06-15 17:19:10 +03:00
alesapin
ca4628d31c
Merge pull request #25197 from ClickHouse/disable-paln-optimizations-for-mutations
Do not optimize query plan for mutations.
2021-06-15 17:15:36 +03:00
Nikolai Kochetov
481b87b37a Remove some code from keyCondition. 2021-06-15 16:47:37 +03:00
Kostiantyn Storozhuk
d96478c9ff Integration test added and small fixes 2021-06-15 21:45:30 +08:00
Pavel Kruglov
48cd8f2207 Fix build 2021-06-15 16:15:27 +03:00
Pavel Kruglov
692150b578 Fix tests 2021-06-15 16:15:27 +03:00
Pavel Kruglov
931e05ab04 Minor refactoring 2021-06-15 16:15:27 +03:00
Pavel Kruglov
a4ef60e230 Remove Impl including from .h file 2021-06-15 16:15:27 +03:00
Pavel Kruglov
eb86721d14 Fix style, output strings as binary instead of utf8 2021-06-15 16:15:27 +03:00
Pavel Kruglov
787c800064 Fix build, tests, style 2021-06-15 16:15:27 +03:00
Pavel Kruglov
b120841b57 Small changes 2021-06-15 16:15:27 +03:00
Pavel Kruglov
a4decd0848 Support Map type, fix and add tests 2021-06-15 16:15:27 +03:00
Pavel Kruglov
c8b37977da Fix bugs, support dictionary for Arrow format 2021-06-15 16:15:27 +03:00
Pavel Kruglov
540c494492 Fix selecting indexes in ORC and Parquet formats 2021-06-15 16:15:27 +03:00
Kruglov Pavel
d74c5ef62d Minor change 2021-06-15 16:15:27 +03:00
Pavel Kruglov
235e3e2f5b Support structs in Arrow/Parquet/ORC 2021-06-15 16:15:27 +03:00
Nikita Mikhaylov
a52bba91b7
Merge pull request #16401 from abyss7/ast-table-identifier-2
ASTTableIdentifier part #2: Introduce ASTTableIdentifier
2021-06-15 13:51:30 +03:00
Amos Bird
8bf897b9c6
Add some comment 2021-06-15 18:37:22 +08:00
Amos Bird
aaac231c6a
Record expanded aliases for RBAC 2021-06-15 18:28:13 +08:00
Nikolai Kochetov
36e8c82161 Add comment. 2021-06-15 12:59:02 +03:00
Amos Bird
6795209ae4
Reuse local variable 2021-06-15 17:54:28 +08:00
Amos Bird
e3ae2f6e7a
Rewrite more alias columns 2021-06-15 17:54:28 +08:00
Nikolai Kochetov
b6fc471270 Fix invalid header for (LowCardinality IN (tuple)). 2021-06-15 12:52:34 +03:00
tavplubix
e2ecc51a1f
Merge pull request #25087 from ClickHouse/srmt_remove_copypaste
Remove copypaste from StorageReplicatedMergeTree
2021-06-15 12:43:55 +03:00
vdimir
05115dcd32
Merge branch 'master' into issue-23351 2021-06-15 12:06:42 +03:00
Amos Bird
4c573b36fe
Fix joinGetOrNull with not-nullable columns 2021-06-15 16:34:53 +08:00
Maksim Kita
a32d9cdbcd Added compileFunction preudocode documentation 2021-06-15 10:56:08 +03:00
Maksim Kita
e9bfcd20e6 ExpressionJIT fix loop 2021-06-15 10:56:08 +03:00
Alexey Milovidov
0f9eb979aa Remove code and fix #20549 2021-06-15 06:54:24 +03:00
Alexey Milovidov
e3653e70da Update prompt in client when reconnecting 2021-06-15 04:43:35 +03:00
bharatnc
d073161455 h3ToGeo - try fix msan fuzzer errors 2021-06-14 17:13:53 -07:00
Alexey Milovidov
4e982a3ae6 Merge branch 'master' into minor-changes-3 2021-06-15 00:45:45 +03:00
alexey-milovidov
2370c8b3a1
Merge pull request #25260 from ClickHouse/fix-topk-memory-tracking
Fix memory tracking of aggregate function `topK`
2021-06-15 00:41:12 +03:00
bharatnc
cabd4144da h3ToGeo - fixes to code 2021-06-14 11:38:38 -07:00
bharatnc
99ae863055 h3ToGeo - few fixes 2021-06-14 11:38:38 -07:00
bharatnc
e96f23d46b H3 - add function h3ToGeo 2021-06-14 11:38:38 -07:00
alexey-milovidov
e5f49477a6
Merge pull request #25264 from ClickHouse/copy-paste-some-code
Copy-paste some code
2021-06-14 21:25:15 +03:00
alexey-milovidov
b03ca2acab
Merge pull request #25267 from matwey/missed_include_optional
Add missed #include <optional>
2021-06-14 21:23:50 +03:00
Matwey V. Kornilov
e8e7682a7d Add missed #include <optional>
std::optional<SearchParams> is used for user_dn_detection;

Signed-off-by: Matwey V. Kornilov <matwey.kornilov@gmail.com>
2021-06-14 12:43:16 +03:00
Azat Khuzhin
92765a3595 Fix clang-tidy warnings in VersionNumber (use Int64 over long) 2021-06-14 10:42:50 +03:00
Azat Khuzhin
40abdaf24a Drop unnecessary qualified namespace 2021-06-14 10:38:26 +03:00
Azat Khuzhin
b5a2fad993 More generic VersionNumber 2021-06-14 10:38:26 +03:00
Azat Khuzhin
055e9d87f0 Use VersionNumber for detecting renameat2() 2021-06-14 10:38:26 +03:00
Azat Khuzhin
1b5ca07ff4 Convert VersionNumber::fromString() to constructor 2021-06-14 10:38:26 +03:00
Azat Khuzhin
ba05bf3977 Use LOGICAL_ERROR instead of introducing BAD_VERSION
But note, that tests with EXPECT_EXIT() does not work with --gtest_filter:

a) only this test is included into unit_tests_dbms

   $ src/unit_tests_dbms --gtest_filter=VersionNumber*
   Running main() from ../contrib/googletest/googletest/src/gtest_main.cc
   Note: Google Test filter = VersionNumber*
   [==========] Running 2 tests from 1 test suite.
   [----------] Global test environment set-up.
   [----------] 2 tests from VersionNumber
   [ RUN      ] VersionNumber.VersionNumber
   [       OK ] VersionNumber.VersionNumber (0 ms)
   [ RUN      ] VersionNumber.fromString
   Segmentation fault (core dumped)

   (gdb) bt
   0  0x00007fffda323d22 in raise () from /usr/lib/libc.so.6
   1  0x00007fffda30d862 in abort () from /usr/lib/libc.so.6
   2  0x00007fffdbe686f5 in DB::handle_error_code (msg=..., code=49, remote=false, trace=...) at Exception.cpp:49
   3  0x00007fffdbe68846 in DB::Exception::Exception (this=0x7fffd5c5a240, msg=..., code=49, remote_=false) at Exception.cpp:60
   4  0x00007fffe26b2cb3 in DB::Exception::Exception<unsigned long> (this=0x7fffd5c5a240, code=49, fmt=..., args=@0x7fffffffc7e8: 4) at Exception.h:40
   5  0x00007fffdbf4d201 in DB::VersionNumber::VersionNumber (this=0x7fffffffcc20, vec=...) at VersionNumber.cpp:17
   6  0x00007fffdbf4d650 in DB::VersionNumber::fromString (version=..., strict=true) at VersionNumber.cpp:57
   7  0x00005555555db53d in VersionNumber_fromString_Test::TestBody (this=0x7fffd5c12330) at gtest_version_number.cpp:24

b) regular build

   $ src/unit_tests_dbms --gtest_filter=VersionNumber*
   Running main() from ../contrib/googletest/googletest/src/gtest_main.cc
   Note: Google Test filter = VersionNumber*
   [==========] Running 2 tests from 1 test suite.
   [----------] Global test environment set-up.
   [----------] 2 tests from VersionNumber
   [ RUN      ] VersionNumber.VersionNumber
   [       OK ] VersionNumber.VersionNumber (0 ms)
   [ RUN      ] VersionNumber.fromString
   [       OK ] VersionNumber.fromString (495 ms)
   [----------] 2 tests from VersionNumber (495 ms total)

   [----------] Global test environment tear-down
   Segmentation fault (core dumped)

   (gdb) bt
   0  testing::TestInfo::should_run (this=0xe0) at gtest.h:760
   1  0x00007ffff7f6edd5 in testing::TestSuite::ShouldRunTest (test_info=0xe0) at gtest.h:1009
   2  0x00007ffff7f6ebb2 in testing::internal::CountIf<std::__1::vector<testing::TestInfo*, std::__1::allocator<testing::TestInfo*> >, bool (*)(testing::TestInfo const*)> (c=..., predicate=0x7ffff7f6edc0 <testing::TestSuite::ShouldRunTest(testing::TestInfo const*)>)
      at gtest-internal-inl.h:294
   3  0x00007ffff7f41ae5 in testing::TestSuite::test_to_run_count (this=0x7fffd5028500) at gtest.cc:2919
   4  0x00007ffff7f41719 in testing::internal::SumOverTestSuiteList (case_list=..., method=(int (testing::TestSuite::*)(const testing::TestSuite * const)) 0x7ffff7f41ac0 <testing::TestSuite::test_to_run_count() const>) at gtest.cc:377
   5  0x00007ffff7f41ab9 in testing::internal::UnitTestImpl::test_to_run_count (this=0x7fffd5d5c000) at gtest.cc:1012
   6  0x00007ffff7f4b59d in testing::UnitTest::test_to_run_count (this=0x7ffff7fbcb80 <testing::UnitTest::GetInstance()::instance>) at gtest.cc:5059
   7  0x00007ffff7f4c4ed in testing::internal::PrettyUnitTestResultPrinter::OnTestIterationEnd (this=0x7fffd5ca4a68, unit_test=...) at gtest.cc:3589
   8  0x00007ffff7f4daf9 in testing::internal::TestEventRepeater::OnTestIterationEnd (this=0x7fffd5c83770, unit_test=..., iteration=0) at gtest.cc:3852
   9  0x00007ffff7f57570 in testing::internal::UnitTestImpl::RunAllTests (this=0x7fffd5d5c000) at gtest.cc:5737
   10 0x00007ffff7fa3a84 in testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> (object=0x7fffd5d5c000,
      method=(bool (testing::internal::UnitTestImpl::*)(testing::internal::UnitTestImpl * const)) 0x7ffff7f56f20 <testing::internal::UnitTestImpl::RunAllTests()>, location=0x7ffff7f11d9b "auxiliary test code (environments or event listeners)") at gtest.cc:2589
   11 0x00007ffff7f71788 in testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> (object=0x7fffd5d5c000,
      method=(bool (testing::internal::UnitTestImpl::*)(testing::internal::UnitTestImpl * const)) 0x7ffff7f56f20 <testing::internal::UnitTestImpl::RunAllTests()>, location=0x7ffff7f11d9b "auxiliary test code (environments or event listeners)") at gtest.cc:2625
   12 0x00007ffff7f56ea3 in testing::UnitTest::Run (this=0x7ffff7fbcb80 <testing::UnitTest::GetInstance()::instance>) at gtest.cc:5291
2021-06-14 10:38:26 +03:00
Azat Khuzhin
5cc03535bf Set -Wno-covered-switch-default for unit_tests_dbms
Otherwise code that uses EXPECT_EXIT() fails with -Werror

v2: adjust only unit_tests_dbms, not googltest via
contrib/CMakeListst.txt itself.
2021-06-14 10:38:26 +03:00
Azat Khuzhin
c08daa3ca5 Detect linux version at runtime (for worked nested epoll)
The #22109 adds the check but at compilation time, which is pointless,
move the check into runtime.

Remember nested epoll is required for
async_socket_for_remote/use_hedged_requests, otherwise remote queries
may stuck.
2021-06-14 10:38:26 +03:00
Alexey Milovidov
b4a9244978 Fix style 2021-06-14 07:46:22 +03:00
Alexey Milovidov
f49463d1e5 Fix clang-tidy 2021-06-14 07:28:17 +03:00
alexey-milovidov
34d12063f8
Merge pull request #23349 from azat/dist-respect-insert_allow_materialized_columns
Respect insert_allow_materialized_columns for INSERT into Distributed()
2021-06-14 07:23:00 +03:00
Alexey Milovidov
447d7bb8cd Minor changes 2021-06-14 07:13:35 +03:00
Alexey Milovidov
cae9b25074 Minor change 2021-06-14 06:05:27 +03:00
Alexey Milovidov
2211ba53d4 Copy paste some code 2021-06-14 05:48:10 +03:00
Alexey Milovidov
dbff1edcd3 Fix memory tracking of aggregate function topK 2021-06-14 05:26:05 +03:00
alexey-milovidov
77721734ed
Merge pull request #21267 from filimonov/kafka-failover
Kafka failover issue fix
2021-06-14 01:42:42 +03:00
alexey-milovidov
99cfa9f463
Merge pull request #25248 from matwey/missed_include_condition_variable
Add missed #include <condition_variable>
2021-06-13 22:55:10 +03:00
Ivan
d5bd761db9
Typo
Co-authored-by: Nikita Mikhaylov <mikhaylovnikitka@gmail.com>
2021-06-13 22:27:54 +03:00
Matwey V. Kornilov
797b29d082 Add missed #include <condition_variable>
std::condition_variable is used for wait_table_finally_dropped

Signed-off-by: Matwey V. Kornilov <matwey.kornilov@gmail.com>
2021-06-13 22:14:05 +03:00
Alexey Milovidov
93b907931d Fix the annoying ya.make. 2021-06-13 21:21:44 +03:00
Maksim Kita
ca785c5a6f Add function toJSONString to ya.make 2021-06-13 18:17:07 +03:00
Maksim Kita
43a0c730ba
Merge pull request #25203 from kitaisreal/dictionaries-attribute-support-default-nullable-type
Dictionaries attribute support default nullable type
2021-06-13 11:46:53 +03:00
Maksim Kita
084bcb389c Fixed tests 2021-06-12 23:44:59 +03:00
alexey-milovidov
2377a802bc
Merge pull request #25196 from kitaisreal/added-executable-pool-documentation
Added ExecutablePool documentation
2021-06-12 18:01:46 +03:00
Pavel Kovalenko
47252e07f3 Remove trailing whitespaces 2021-06-12 15:57:14 +03:00
Pavel Kovalenko
0c82d45dea Missed initialize in ReadBufferFromS3 2021-06-12 14:35:34 +03:00
Maksim Kita
2a016f52e9 Added tests 2021-06-12 13:53:03 +03:00
vdimir
26c59961ae
Minor style changes in StorageMaterializedView::read, StorageMerge::createSources 2021-06-12 12:27:05 +03:00
mergify[bot]
9cfedd9c64
Merge branch 'master' into progress-bar 2021-06-12 01:15:23 +00:00
mergify[bot]
ab2a1a410f
Merge branch 'master' into test-key-condition-mon 2021-06-12 00:32:38 +00:00
alexey-milovidov
05d1af153c
Merge branch 'master' into rename-const-context-ptr 2021-06-12 03:25:09 +03:00
alexey-milovidov
768b8fed75
Merge branch 'master' into mv-dist-join-fix 2021-06-12 03:19:09 +03:00
alexey-milovidov
abe206f4fc
Merge pull request #25037 from nvartolomei/nv/queue-entry-wait-dead-code
Update waitForTableReplicaToProcessLogEntry comments
2021-06-12 03:11:13 +03:00
alexey-milovidov
99f108d704
Merge pull request #25162 from kitaisreal/rewrite-function-to-subcolumn-visitor-add-into-ya-make
RewriteFunctionToSubcolumnVisitor add into ya.make
2021-06-12 02:58:53 +03:00
alexey-milovidov
30f0124e77
Merge branch 'master' into always-detach-parts-with-wrong-partition-id 2021-06-12 02:55:55 +03:00
alexey-milovidov
320f253912
Merge pull request #25022 from amosbird/initialquerystarttimefix
Add initial_query_start_time to query log
2021-06-12 02:41:24 +03:00
alexey-milovidov
a5380d6b46
Merge pull request #25218 from MaxWk/enable-s3-in-osx
enable s3 in osx
2021-06-12 02:38:19 +03:00
alexey-milovidov
971c79611b
Merge branch 'master' into patch-5 2021-06-12 02:36:13 +03:00
alexey-milovidov
eb7b491da9
Merge pull request #24900 from Enmk/bloom_filter_hasAny
Added support of hasAny function to bloom_filter index.
2021-06-12 00:58:25 +03:00
Ivan Lezhankin
a237229998 Another ANTLR fix 2021-06-12 00:15:38 +03:00
tavplubix
2a6b4a64f4
Merge pull request #25200 from vdimir/join-opts-stress-test
Add join related options to stress test
2021-06-12 00:03:41 +03:00
Ivan Lezhankin
e6b9ab6261 Fix false-positive issue from clang-tidy 2021-06-11 21:05:45 +03:00
Vasily Nemkov
2ac288c303 index is not used if types in hasAny are unsuported
updated tests
2021-06-11 18:29:52 +03:00
Ivan Lezhankin
f7979292d6 Merge branch 'ast-table-identifier-2' of github.com:abyss7/ClickHouse into ast-table-identifier-2 2021-06-11 18:29:04 +03:00
Ivan Lezhankin
4773c79300 Fix ANTLR grammar 2021-06-11 18:27:32 +03:00
Amos Bird
49db4dbe6a
Update comment 2021-06-11 23:24:38 +08:00
万康
3a404fcc1b fix build error 2021-06-11 23:21:18 +08:00
mergify[bot]
60c094e785
Merge branch 'master' into disk-s3-read-error-fix 2021-06-11 15:00:43 +00:00
tavplubix
182c10826c
Update TableJoin.h 2021-06-11 17:47:30 +03:00
Amos Bird
7d9a1106b8
Add initial_query_start_time to query log 2021-06-11 22:24:53 +08:00
Alexander Tokmakov
73ff1728ae rename flag to more generic name 2021-06-11 15:41:48 +03:00
Storozhuk Kostiantyn
b2ddc98958
Update InterpretersMySQLDDLQuery.cpp 2021-06-11 14:34:03 +03:00
Kostiantyn Storozhuk
3dc718ff36 style fixes 2021-06-11 19:29:12 +08:00
Maksim Kita
30c78c0a23 Fix arcadia 2021-06-11 14:26:33 +03:00
vdimir
c3aec8ae57
Fix random indentation to trigger ci 2021-06-11 14:03:53 +03:00
Maksim Kita
0bd199eb50 Dictionaries attribute support default nullable type 2021-06-11 13:35:50 +03:00
Anton Popov
58005a30a8
Merge pull request #25164 from amosbird/tojsonstring
Add toJSONString function
2021-06-11 13:18:21 +03:00
Nikolai Kochetov
52f60692c8 Do not optimize query plan for mutations. 2021-06-11 11:48:12 +03:00
Storozhuk Kostiantyn
6c9f701636
Wip my sql column comments support (#1)
Implemented MySQL engine column comments support
2021-06-11 11:43:36 +03:00
Nikolai Kochetov
79c69ea316 Fix build. 2021-06-11 11:29:39 +03:00
Maksim Kita
12982da130 Added ExecutablePool documentation 2021-06-11 11:28:49 +03:00
Maksim Kita
e549b29bff
Merge pull request #25161 from kitaisreal/dictionary-sources-add-update-lag-option
Dictionary sources add update lag option
2021-06-11 10:58:46 +03:00
tavplubix
e99662c68e
Merge pull request #25169 from nikitamikhaylov/csv-with-names-bug
Fix insert a subset of columns using CSVWithNames
2021-06-11 10:42:48 +03:00
Kseniia Sumarokova
9cb9aca6b8
Update StoragePostgreSQL.cpp 2021-06-11 09:44:36 +03:00
alexey-milovidov
7616216f10
Merge pull request #25015 from ClickHouse/fix-wrong-code-in-aggregate-functions
Remove a chunk of wrong code and look what will happen
2021-06-11 00:36:35 +03:00
Maksim Kita
c6d75ae2e4 Fixed tests 2021-06-10 23:34:27 +03:00
Maksim Kita
362595fe64 Fix tests 2021-06-10 22:32:09 +03:00
Maksim Kita
d5dfd83983 Fixed build issues 2021-06-10 22:32:09 +03:00
Maksim Kita
8a4d405b26 Fix serialization for Nullable type 2021-06-10 22:32:09 +03:00
Maksim Kita
e6222f8022 Fixed CacheDictionary tests 2021-06-10 22:32:09 +03:00
Maksim Kita
021e5f838a Fixed tests 2021-06-10 22:32:09 +03:00
Maksim Kita
eabeb3076f Added tests 2021-06-10 22:32:09 +03:00
Maksim Kita
45b8dc772b Dictionaries support array type 2021-06-10 22:32:09 +03:00
Alexey Milovidov
7a6df49964 Fix clang-tidy 2021-06-10 22:14:24 +03:00
kssenii
8cbd9ec733 Fixes 2021-06-10 16:23:04 +00:00
Vasily Nemkov
55064e49a7 Fixed the test
Previous test version wasn't causing bug on unfixed code, this new one does.
2021-06-10 19:09:43 +03:00
Nikolai Kochetov
fea19c2037
Merge pull request #25163 from amosbird/projection-fix10
Disable projection when final is used in select query
2021-06-10 18:44:29 +03:00
Vladimir
ba198c48ea
Merge pull request #24898 from excitoon/patch-8 2021-06-10 18:34:17 +03:00
Vasily Nemkov
0ab28360c9 Added support of hasAny function to bloom_filter index.
Also fixed bug discovered by AST fuzzer.
2021-06-10 18:22:04 +03:00
Nikita Mikhaylov
395e0d6756 done 2021-06-10 13:57:19 +00:00
Ivan
a7fa4e641c
Merge branch 'master' into ast-table-identifier-2 2021-06-10 16:43:22 +03:00
Nikolai Kochetov
6222fcffe0 Never remove parts on start at all. Always move. 2021-06-10 15:47:55 +03:00
Nikolai Kochetov
aa90309abf Never remove parts on start at all. Always move. 2021-06-10 15:46:03 +03:00
Nikolai Kochetov
2936fdd16c Always detach parts with wrong partition id. 2021-06-10 15:04:36 +03:00
Amos Bird
65fe9dd461
Better serialization code 2021-06-10 19:14:20 +08:00
Nikolai Kochetov
847dfb9914 Merge remote-tracking branch 'origin' into always-detach-parts-with-wrong-partition-id 2021-06-10 12:37:46 +03:00
Nikolai Kochetov
d52b87d47d Always detach proken parts with wrong partition id. 2021-06-10 12:37:33 +03:00
Maksim Kita
98b420b128 Fixed PostgreSQLDictionarySource build 2021-06-10 12:34:19 +03:00
Amos Bird
94bfe539ac
toJSONString 2021-06-10 17:23:20 +08:00
Amos Bird
4e358b28f1
Disable projection with final is used 2021-06-10 17:11:17 +08:00
Maksim Kita
005946945f RewriteFunctionToSubcolumnVisitor add into ya.make 2021-06-10 11:41:16 +03:00
Maksim Kita
7515e2db4f Dictionary sources add update lag option 2021-06-10 11:34:57 +03:00
Nikolai Kochetov
4185c5954f
Merge pull request #25152 from ClickHouse/move-code-in-more-local-place
Move code to more appropriate place
2021-06-10 11:08:27 +03:00
Alexey Milovidov
bcf4d5c29d Fix clang-tidy 2021-06-10 05:23:44 +03:00
alexey-milovidov
50b149607b
Merge pull request #25103 from azat/topLevelDomain-fix-for-IDN
Fix topLevelDomain() for IDN hosts
2021-06-10 03:02:48 +03:00
Alexey Milovidov
6c5b2b827c Move code to more appropriate place 2021-06-10 02:58:51 +03:00
alexey-milovidov
3ff7b5af3a
Merge pull request #24763 from azat/config-processor-xml-default
Process config w/o extensions as XML format
2021-06-10 02:48:40 +03:00
alexey-milovidov
0636f40349
Merge pull request #25127 from ClickHouse/fix-partition-hash-for-uuid
Revert old UUID hash used for partition ID.
2021-06-10 02:31:01 +03:00
Alexey Milovidov
6925105ba4 Give up 2021-06-10 02:18:50 +03:00
Alexey Milovidov
39abf41b4d Fix clang-tidy 2021-06-10 02:16:01 +03:00
alexey-milovidov
a699a77c36
Merge pull request #25145 from georgthegreat/zstd-include
Use zstd/include in ya.make
2021-06-10 01:41:43 +03:00
Alexander Kuzmenkov
c0e6aa97a6
Merge pull request #24734 from ClickHouse/aku/frame-expressions
support expressions in window frame
2021-06-10 00:25:32 +03:00
Maksim Kita
6e49062ab8
Merge pull request #24754 from azat/insert_distributed_sync-fix
Respect max_distributed_connections for insert_distributed_sync
2021-06-09 23:32:35 +03:00
Yuriy Chernyshov
c0cb5387f4 Use zstd/include in ya.make 2021-06-09 23:02:39 +03:00
Nikolai Kochetov
8dc7ba4eff Fix spelling 2021-06-09 19:42:19 +03:00
Nikolai Kochetov
a163453e74
Merge pull request #25082 from ClickHouse/fix-24011
Fix crash in explain syntax and cross join.
2021-06-09 19:40:23 +03:00
Nikolai Kochetov
9548f198fe Fix build. 2021-06-09 19:11:04 +03:00
Mikhail Filimonov
3627ab7cbe
Fix kafka failover issue (#21118).
Distringuish lack of assignment vs lack of partitions. Bit better / clearer logging.
2021-06-09 16:02:56 +02:00
Nikolai Kochetov
12791431da Revert old UUID hash used for partition ID. 2021-06-09 16:51:40 +03:00
Alexander Tokmakov
cef22688ff make code less ugly 2021-06-09 15:36:47 +03:00
Alexey Milovidov
b9a0817672 Fix clang-tidy 2021-06-09 14:07:21 +03:00
Alexey Milovidov
e1dd694830 Review fixes 2021-06-09 14:05:36 +03:00
Nikolai Kochetov
9e0f3e5e9e Avoid using empty table name in identifier. 2021-06-09 13:13:13 +03:00
Nikita Mikhaylov
82b8d45cd7
Merge pull request #23518 from nikitamikhaylov/copier-stuck
Bugfixes and improvements of `clickhouse-copier`
2021-06-09 11:36:42 +03:00
Anton Popov
bb6f0dfbb8
Merge pull request #24406 from CurtizJ/rewrite-functions-to-subcolumns
Optimize some functions to subcolumns
2021-06-09 11:07:09 +03:00
mergify[bot]
3a47feedb0
Merge branch 'master' into progress-bar 2021-06-09 08:04:48 +00:00
Azat Khuzhin
e0c1780370 Fix topLevelDomain() for IDN hosts 2021-06-09 10:59:56 +03:00
Azat Khuzhin
38ac83dff9 Update comments for getURLHost() 2021-06-09 10:59:10 +03:00
mergify[bot]
bfbc787b08
Merge branch 'master' into disk-s3-read-error-fix 2021-06-09 06:56:19 +00:00
alexey-milovidov
76ff91f847
Merge pull request #25072 from ClickHouse/increase_schedule_pool
Increase background schedule pool default size
2021-06-09 05:32:05 +03:00
Alexey Milovidov
e43105dac1 Fix wrong code in SerializationAggregateFunction 2021-06-09 02:40:29 +03:00
Azat Khuzhin
18e8f0eb5e Add ability to push down LIMIT for distributed queries
This way the remote nodes will not need to send all the rows, so this
will decrease network io and also this will make queries w/
optimize_aggregation_in_order=1/LIMIT X and w/o ORDER BY faster since it
initiator will not need to read all the rows, only first X (but note
that for this you need to your data to be sharded correctly or you may
get inaccurate results).

Note, that having lots of processing stages will increase the complexity
of interpreter (it is already not that clean and simple right now).

Although using separate QueryProcessingStage looks pretty natural.

Another option is to make WithMergeableStateAfterAggregation always, but
in this case you will not be able to disable only this optimization,
i.e. if there will be some issue with it.

v2: fix OFFSET
v3: convert 01814_distributed_push_down_limit test to .sh and add retries
v4: add test with OFFSET
v5: add new query stage into the bash completion
v6/tests: use LIMIT O,L syntax over LIMIT L OFFSET O since it is broken in ANTLR parser
          https://clickhouse-test-reports.s3.yandex.net/23027/a18a06399b7aeacba7c50b5d1e981ada5df19745/functional_stateless_tests_(antlr_debug).html#fail1
v7/tests: set use_hedged_requests to 0, to avoid excessive log entries on retries
          https://clickhouse-test-reports.s3.yandex.net/23027/a18a06399b7aeacba7c50b5d1e981ada5df19745/functional_stateless_tests_flaky_check_(address).html#fail1
2021-06-09 02:29:50 +03:00
Anton Popov
eb1a33827a
Merge pull request #25080 from Avogar/fix-map-contains
Fix bug function mapContains
2021-06-09 01:25:57 +03:00
alesapin
185fb83587
Merge pull request #25059 from ClickHouse/fix_loop_aliases
Ban loop aliases in table definitions
2021-06-08 23:36:54 +03:00
Alexander Tokmakov
3ade38df82 remove copypaste 2021-06-08 22:17:45 +03:00
Maksim Kita
8e88e682c1
Merge pull request #25066 from kitaisreal/aggregate-function-any-heavy-data-use-fixed-size-type
AggregateFunctionAnyHeavyData use fixed size type
2021-06-08 21:59:19 +03:00
alexey-milovidov
e25d9843d1
Merge pull request #25025 from azat/parallel-kill-mutation
Distinguish KILL MUTATION for different tables.
2021-06-08 21:40:53 +03:00
alexey-milovidov
c1d233cabc
Update ASTIdentifier.cpp 2021-06-08 20:40:33 +03:00
alexey-milovidov
736b56ce33
Update ASTIdentifier.cpp 2021-06-08 20:39:42 +03:00
kssenii
0521851afa Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into postgres-fixes-schema 2021-06-08 17:20:23 +00:00
Nikolai Kochetov
5cc005710a
Update ASTIdentifier.cpp 2021-06-08 18:23:42 +03:00
Nikolai Kochetov
194dd91f0c Fix crash in explain syntax and cross join. 2021-06-08 16:54:48 +03:00
Nikolai Kochetov
a73f1b9ebe Fix crash in explain syntax and cross join. 2021-06-08 16:51:17 +03:00
Nikolai Kochetov
6197d20c18
Update KeyCondition.cpp 2021-06-08 15:48:14 +03:00
Pavel Kruglov
7dcbf7dbcd Fix bug function mapContains 2021-06-08 15:27:51 +03:00
Vladimir
fb987cf2c7
Fix space in ReadBufferFromFileDecorator.cpp 2021-06-08 15:00:28 +03:00
alesapin
5736eaf8fd Increase background schedule pool default size 2021-06-08 13:55:14 +03:00
alesapin
11a1606c15 Less strict 2021-06-08 12:54:00 +03:00
Nikolai Kochetov
ab2529d4f0
Merge pull request #25055 from amosbird/projection-fix9
Fix using aggregate projection when group by without key
2021-06-08 12:15:25 +03:00
Azat Khuzhin
1062d0ec91 Distinguish KILL MUTATION for different tables.
Before this patch KILL MUTATION marks mutation as canceled just by name
(and part numbers) so if you have multiple tables with the same part
name, then killing mutation for one table, will mark it as killed for
another too.

Fix this by comparing StorageID too (it is better to use StorageID over
database/table to avoid ambiguity by using UUIDs for comparing).

Here is a failure of the 01414_freeze_does_not_prevent_alters on CI [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/24069/9fb69dcf98c71a939d200cad3c8491bf43a44622/functional_stateless_tests_(ubsan).html#fail1
2021-06-08 10:51:22 +03:00
Azat Khuzhin
33b0429dd1 Add StorageID::operator==() 2021-06-08 10:51:22 +03:00
Azat Khuzhin
d5a8a1a8a1 Mark StorageID::operator bool() as explicit
This will avoid bugs, like comparing StorageID w/o operator== via cast
to bool.
2021-06-08 10:51:22 +03:00
Maksim Kita
efc8ecf982 AggregateFunctionAnyHeavyData use fixed size type 2021-06-08 10:29:18 +03:00
Azat Khuzhin
2109980284 Respect max_distributed_connections for insert_distributed_sync
Otherwise for huge clusters and sync insert it may run out of
max_thread_pool_size (default 10K).
2021-06-08 09:11:44 +03:00
alexey-milovidov
deeaa98af5
Merge pull request #24069 from azat/log-ignore-errors
[RFC] Suppress exceptions from logger code
2021-06-08 03:59:06 +03:00
mergify[bot]
b1deed7659
Merge branch 'master' into config-processor-xml-default 2021-06-08 00:54:17 +00:00
Alexey Milovidov
14ef6f4039 Review fixes 2021-06-08 03:11:36 +03:00
Alexey Milovidov
d6513b22cb Merge remote-tracking branch 'origin/master' into fix-wrong-code-in-aggregate-functions 2021-06-08 03:08:03 +03:00
alesapin
5284f192ee Ban loop aliases in table definitions 2021-06-07 23:59:38 +03:00
Nikolai Kochetov
c4832fd3c0 Added test. 2021-06-07 21:24:32 +03:00
Ivan
579250168f
Merge branch 'master' into ast-table-identifier-2 2021-06-07 20:30:39 +03:00
Amos Bird
840895509e
Fix using aggregate projection when group by without key 2021-06-07 22:44:42 +08:00
Ivan Lezhankin
0e9ce8c23a Fix Disks/ya.make 2021-06-07 17:22:24 +03:00
Ivan Lezhankin
7aa08a04b5 Fix unit-tests again 2021-06-07 16:52:47 +03:00
Nikolai Kochetov
0d2a839ca4 Fix tests. 2021-06-07 16:41:40 +03:00
Pavel Kovalenko
6ba40c475a Code cleanup + comments. 2021-06-07 13:49:34 +03:00
Nicolae Vartolomei
19f64b3f25 Update waitForTableReplicaToProcessLogEntry comments 2021-06-07 11:01:57 +01:00
mergify[bot]
b8dcce68b5
Merge branch 'master' into rename-const-context-ptr 2021-06-07 09:46:24 +00:00
Nikolai Kochetov
0043434d5c
Merge pull request #24894 from amosbird/notinpartitionprune
Allow not in be used in partition pruning
2021-06-07 12:42:48 +03:00
alesapin
2ea9d998e8
Merge pull request #24960 from nvartolomei/nv/queue-entry-wait-dead-code
Delete support for waiting on queue- entries, is this dead code?
2021-06-07 12:40:34 +03:00
Nikolai Kochetov
cbd46280eb
Update Set.cpp 2021-06-07 12:36:34 +03:00
Maksim Kita
719b419104
Merge pull request #25031 from kitaisreal/fix-disks-ya-make
Disks fix ya.make
2021-06-07 12:01:39 +03:00
alesapin
170c49db69
Merge pull request #24961 from ClickHouse/more_general_check_in_queue
Trying to fix 'Tagging already tagged part'
2021-06-07 11:52:05 +03:00
Kruglov Pavel
ee683ea90e
Merge pull request #24729 from vdimir/segment-lenght-sum-fixes
Minor fixes in AggregateFunctionSegmentLengthSumData
2021-06-07 11:01:29 +03:00
Maksim Kita
16b3355ac1 Disks fix ya.make 2021-06-07 10:05:05 +03:00
Vladimir Chebotarev
ad816fde7b
Fix. 2021-06-07 09:56:15 +03:00
Vladimir Chebotarev
e21f76b137
Fixed unit tests accoording to the fix. 2021-06-07 09:54:05 +03:00
Vladimir Chebotarev
8c33e53e80
Review fixes. 2021-06-07 09:41:49 +03:00
Azat Khuzhin
8ec874dc33 Add writeRetry helper 2021-06-07 09:38:15 +03:00
Alexey Milovidov
e275fc9c29 Fix trash 2021-06-07 03:15:11 +03:00
Alexey Milovidov
406285dad1 Regenerate ya.make 2021-06-07 01:31:08 +03:00
Alexey Milovidov
710bf3c9c4 Add missing file 2021-06-07 01:30:27 +03:00
Alexey Milovidov
885ce194e0 Making fundamentals correct 2021-06-07 00:49:55 +03:00
mergify[bot]
f84ac23951
Merge branch 'master' into compression-codecs-refactoring 2021-06-06 18:02:39 +00:00
alexey-milovidov
295dc6b517
Revert "Add initial_query_start_time to query log" 2021-06-06 20:57:04 +03:00
Alexey Milovidov
84ced3ace0 Deliberately break the rules 2021-06-06 19:43:15 +03:00
Alexey Milovidov
6a652ef4f6 Remove a chunk of wrong code and look what will happen 2021-06-06 19:28:54 +03:00
dankondr
9e83275d28 Make string arrays constexpr 2021-06-06 17:52:08 +03:00
alexey-milovidov
81a12404c7
Merge pull request #24940 from azat/settings-limit-offset-fix
Fix limit/offset settings for distributed queries (ignore on the remote nodes)
2021-06-06 17:39:15 +03:00
alexey-milovidov
c3baba2287
Merge pull request #24930 from amosbird/distributedfix
Allow shard pruning with IN literal
2021-06-06 17:36:47 +03:00
alexey-milovidov
f59f444ac6
Merge pull request #24957 from ClickHouse/fix_endless_wait
Fix endless wait in replica clone
2021-06-06 16:50:08 +03:00
alexey-milovidov
db384a163c
Merge pull request #24388 from amosbird/initialquerystarttime
Add initial_query_start_time to query log
2021-06-06 16:15:37 +03:00
Alexey Milovidov
8d85145725 Remove experimental compression codecs 2021-06-06 02:26:52 +03:00
Alexey Milovidov
17962459f5 Merge branch 'master' into issue-16775 2021-06-06 02:18:28 +03:00
Maksim Kita
a7ca1f5999 DictionaryLoader unnecessary dictionary configuration creation fix 2021-06-05 23:37:24 +03:00
Vitaly Baranov
c015ec7be9 Fix serialization of splitted nested messages in Protobuf format. 2021-06-05 14:20:39 +03:00
Nicolae Vartolomei
af311c8642 Add acl for move partition between shards
We can not easily verify permissions on destination shard

and instead we require a custom grant that can be given to

superadmins.
2021-06-05 10:41:30 +01:00
mergify[bot]
d8ed474062
Merge branch 'master' into copier-stuck 2021-06-05 01:40:23 +00:00
Nikolai Kochetov
397f6133e0 Refactor canConstantBeWrappedByMonotonicFunctions function. 2021-06-04 20:56:56 +03:00
Nicolae Vartolomei
4d91dfda7e Replace if over an enum with a switch to make it hard to miss new cases 2021-06-04 17:57:17 +01:00
mergify[bot]
d68d5e0ef1
Merge branch 'master' into rename-const-context-ptr 2021-06-04 14:41:41 +00:00
Nikita Mikhaylov
af32228e9f
Merge pull request #24523 from Algunenano/i24461
Fix crash when chaining uniqStates
2021-06-04 17:26:34 +03:00
Amos Bird
fd336411ee
Allow shard pruning with IN literal 2021-06-04 21:16:15 +08:00
Amos Bird
78fca8f8fa
Fix possible race condition when getting cluster 2021-06-04 21:09:59 +08:00
alesapin
1e69128443 Trying to fix 'Tagging already tagged part' 2021-06-04 14:49:00 +03:00
Nikita Mikhaylov
f1733a93e5
Merge pull request #24857 from kssenii/postgresql_protocol
Fix NULL values in postgresql protocol
2021-06-04 14:43:47 +03:00
Nicolae Vartolomei
a9d108fc5f Delete support for waiting on queue- entries, is this dead code? 2021-06-04 12:43:46 +01:00
Nikita Mikhaylov
cf8782faf3
Merge pull request #24311 from nikitamikhaylov/merging-s3-backoff
Merging #23461
2021-06-04 14:41:21 +03:00
kssenii
00e76ca372 Checking tests 2021-06-04 11:34:51 +00:00
Nikolai Kochetov
1850f411cc
Merge pull request #24874 from amosbird/rowpolicyfix1
Try reusing built sets during multi-pass analysis
2021-06-04 13:22:25 +03:00
alesapin
4127bbbb9c Remove compatibility code with 18.12 2021-06-04 13:20:15 +03:00
alesapin
4a3fd34a9d Fix typo 2021-06-04 11:33:07 +03:00
alesapin
f9c2f6925d Don't try if source replica was dropped 2021-06-04 11:32:33 +03:00
alesapin
1a421260b3 Fix endless wait in replica clone 2021-06-04 11:22:24 +03:00
Vitaly Baranov
d715395751
Merge pull request #24480 from BoloniniD/yaml-fuzz
Add fuzzing tests for YAMLParser
2021-06-04 10:21:09 +03:00
vdimir
bfb2b4838d
Remove not working DateTime64 support from AggregateFunctionIntervalLengthSum 2021-06-04 09:12:59 +03:00
vdimir
fbd8640911
Update AggregateFunctionIntervalLengthSum: exception messages, add support DateTime64 2021-06-04 09:09:06 +03:00
vdimir
494ee6eb41
Rename segmentLengthSum -> intervalLengthSum 2021-06-04 09:09:05 +03:00
vdimir
d8ba6167e9
Minor fixes in AggregateFunctionSegmentLengthSumData 2021-06-04 09:09:05 +03:00
Nikita Mikhaylov
bc62457142 Merge branch 'master' of github.com:ClickHouse/ClickHouse into copier-stuck 2021-06-03 23:59:00 +00:00
Nikita Mikhaylov
8076848d62
Update ReadBufferFromS3.cpp 2021-06-04 02:46:21 +03:00