thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-16 19:32:07 +00:00
Code Issues Packages Projects Releases Wiki Activity
73,565 Commits 9,319 Branches 1,783 Tags 2.1 GiB
ac9af1ca38
Commit Graph

18255 Commits

Author SHA1 Message Date
vdimir
aea2b952fd
Merge EmbeddedRocksDBBlockInputStream and EmbeddedRocksDBSource 2021-09-27 16:16:34 +03:00
Maksim Kita
a6a19c6267
Merge pull request #29405 from kitaisreal/added-setting-use-skip-indexes 
Added setting use_skip_indexes
 2021-09-27 16:06:54 +03:00
Kseniia Sumarokova
beda6bee2e
Merge pull request #29276 from kssenii/hdfs-fix-assertion 
Fix !hasPendingData() failed assertion in hdfs read buffer
 2021-09-27 15:47:17 +03:00
feng lv
814f6d5068 fix 2021-09-27 12:09:01 +00:00
alesapin
a73064679d Compress keeper snapshots with default ZSTD codec 2021-09-27 14:54:04 +03:00
Nikita Mikhaylov
3741b8a17e
Merge pull request #29337 from amosbird/projection-fix18 
Fix projection merges and mutations.
 2021-09-27 13:45:13 +03:00
vdimir
8fe17dd3d1
Revert "Rename EmbeddedRocksDBBlockInputStream -> EmbeddedRocksDBSource" 
This reverts commit 3ab217031e50a0b4d19fb24d72088e353cdfa510.
 2021-09-27 12:49:14 +03:00
vdimir
dc7393e810
Rename EmbeddedRocksDBBlockInputStream -> EmbeddedRocksDBSource 2021-09-27 12:49:13 +03:00
vdimir
222ab78931
Convert EmbeddedRocksDBBlockInputStream to ISource 2021-09-27 12:49:13 +03:00
Vladimir C
70dc43a72d
Merge pull request #29388 from aiven/kmichel-fix-replicated-storage-reload 2021-09-27 12:41:24 +03:00
Maksim Kita
d0f53cfc31 Added setting use_skip_indexes 2021-09-27 12:17:00 +03:00
Maksim Kita
92c484f0d3
Merge pull request #29252 from Enmk/fix_some_functions_exception_messages 
Better exception messages for some String-related functions
 2021-09-27 11:50:42 +03:00
feng lv
30428ad1b0 fix 2021-09-27 08:44:48 +00:00
Nikolai Kochetov
78a7665f43 Merge branch 'master' into rewrite-pushing-to-views 2021-09-27 10:56:50 +03:00
Nikolai Kochetov
09232788c0 Fix GRPC tests. 2021-09-27 10:55:33 +03:00
feng lv
56be3fab00 fix 2021-09-27 07:17:16 +00:00
Azat Khuzhin
c495297e65 Remove unused reset_timeout/access_timeout from AsynchronousInsertQueue 2021-09-27 10:02:27 +03:00
Vasily Nemkov
544cccb2fb
Forward-declared LOGICAL_ERROR to make style check happy 2021-09-27 09:43:13 +03:00
feng lv
1eb96c2fce fix 2021-09-27 04:39:50 +00:00
feng lv
c8062ad397 fix 2021-09-27 04:25:59 +00:00
alexey-milovidov
5a7f30171a
Merge pull request #29355 from ClickHouse/remove-trash-db-regexp 
Fix assert in table function `merge` with database regexp
 2021-09-27 05:50:13 +03:00
feng lv
69985ac4ae fix 2021-09-27 02:27:24 +00:00
alexey-milovidov
319e0c1f91
Merge pull request #29229 from azat/send-UNKNOWN_DATABASE-to-client 
Send UNKNOWN_DATABASE to the client (via TCP)
 2021-09-27 02:46:01 +03:00
Alexey Milovidov
1227a383e3 Merge branch 'remove-trash-db-regexp' of github.com:yandex/ClickHouse into remove-trash-db-regexp 2021-09-27 02:17:19 +03:00
Alexey Milovidov
16f0f0af7f Merge remote-tracking branch 'origin/master' into remove-trash-db-regexp 2021-09-27 02:12:13 +03:00
alexey-milovidov
1c1e2e6b28
Merge pull request #29289 from vdimir/issue-29227-rocksdb-truncate 
Fix race in StorageSystemRocksDB
 2021-09-27 01:55:07 +03:00
Azat Khuzhin
b3d1bfc67a Send UNKNOWN_DATABASE to the client (via TCP) 
Before this patch:

    $ clickhouse-client --database foo -q 'select 1'
    Code: 32. DB::Exception: Attempt to read after eof: while receiving packet from localhost:9000. (ATTEMPT_TO_READ_AFTER_EOF)

After:

    $ clickhouse-client --database foo -q 'select 1'
    Received exception from server (version 21.11.1):
    Code: 81. DB::Exception: Received from localhost:9000. DB::Exception: Database foo doesn't exist. (UNKNOWN_DATABASE)
    (query: select 1)

Fixes: #26864 (cc @vitlibar)
 2021-09-26 23:45:29 +03:00
Kevin Michel
13db65f47c
Fix ReplicatedAccessStorage shutdown without startup 
If ReplicatedAccessStorage startup was not executing or if it
failed before completing (for instance when ZooKeeper was not configured),
its destructor would call shutdown and try to join a missing thread.
 2021-09-26 19:50:29 +02:00
alexey-milovidov
aa48698613
Merge pull request #29368 from bharatnc/ncb/fix-name-h3isResClassIII 
Fix H3 function name (h3ResIsClassIII to h3IsResClassIII)
 2021-09-26 20:36:36 +03:00
feng lv
da2c8f23cc Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into filelog-engine 2021-09-26 15:00:37 +00:00
Nikolai Kochetov
efbd8e4911 Remove ExceptionHandlingSink. 2021-09-26 17:54:59 +03:00
feng lv
6c4b0f2d37 drop table immediately 
fix style

update
 2021-09-26 14:13:12 +00:00
feng lv
30527879b9 fix style 2021-09-26 12:19:19 +00:00
feng lv
7af96b12b1 add meta file 
fix and update tests
 2021-09-26 11:28:46 +00:00
Vasily Nemkov
2c6b9aa174 Better exception messages for some String-related functions 2021-09-26 08:18:37 +03:00
Vasily Nemkov
121dfe26b6
Fixed resetting nullptr field 2021-09-26 08:13:58 +03:00
bharatnc
0e9af142df Fix one more comment 2021-09-25 18:21:47 -07:00
bharatnc
23b6ac82a7 Fix comments in AggregateFunctionFactory 2021-09-25 18:21:06 -07:00
alexey-milovidov
07eef92c16
Merge pull request #29364 from azat/benchmark-fix-query_id 
Pass through initial query_id for clickhouse-benchmark
 2021-09-26 03:27:27 +03:00
mergify[bot]
15e5204a7c
Merge branch 'master' into issue-29227-rocksdb-truncate 2021-09-26 00:10:30 +00:00
Kseniia Sumarokova
a7809d3d63
Merge pull request #29365 from kssenii/fix-mysql 
Fix integration test
 2021-09-26 00:52:10 +03:00
bharatnc
59dfc87113 Merge remote-tracking branch 'upstream/master' into ncb/fix-name-h3isResClassIII 2021-09-25 10:19:00 -07:00
bharatnc
2deb9643af Rename h3ResIsClassIII -> h3IsResClassIII 2021-09-25 10:12:32 -07:00
alexey-milovidov
08e395bbcd
Merge pull request #29342 from ClickHouse/fix-typo-in-comment 
Fix typo in comment
 2021-09-25 19:44:59 +03:00
alexey-milovidov
85fc160eb4
Merge pull request #29346 from ClickHouse/remove-ya-make 
Remove ya.make
 2021-09-25 19:43:40 +03:00
alexey-milovidov
87d9506bb0
Merge pull request #29348 from ClickHouse/remove-nth-value 
Remove window function 'nth_value'
 2021-09-25 19:43:02 +03:00
alexey-milovidov
9dac348893
Update StorageMerge.cpp 2021-09-25 19:41:50 +03:00
Azat Khuzhin
fb584715e1 Pass through initial query_id for clickhouse-benchmark 2021-09-25 18:05:55 +03:00
kssenii
30b92d24f1 Fix 2021-09-25 14:46:03 +00:00
Nikolai Kochetov
ef425310ff Try use empty sink 2021-09-25 11:36:52 +03:00
Kseniia Sumarokova
b262070eba
Merge pull request #29340 from ClickHouse/fix-msan-disk-web 
Fix trivial mistake in DiskWebServer
 2021-09-25 11:05:29 +03:00
Amos Bird
34017c942e
More fixes 2021-09-25 13:38:56 +08:00
Alexey Milovidov
fe44be522e Fix assert in table function merge with database regexp 2021-09-25 05:48:24 +03:00
Alexey Milovidov
06fc466438 Remove window function 'nth_value' 2021-09-25 04:39:38 +03:00
Alexey Milovidov
cd7f9d981c Remove ya.make 2021-09-25 04:22:54 +03:00
Anton Popov
7628273df4
Merge pull request #29266 from CurtizJ/normalize-asts 
Normalize ASTs in ColumnsDescription
 2021-09-25 04:01:54 +03:00
alexey-milovidov
62d606bb76
Update DiskWebServer.h 2021-09-25 02:58:12 +03:00
Alexey Milovidov
686989f4f1 Remove some uglyness 2021-09-25 02:34:50 +03:00
Alexey Milovidov
566797807f Remove assorted trash 2021-09-25 02:32:03 +03:00
Alexey Milovidov
a2c2b3a866 Whitespaces 2021-09-25 02:12:26 +03:00
Alexey Milovidov
3284b2c8de Fix typo in comment 2021-09-25 02:10:10 +03:00
Maksim Kita
63aef6ff95
Merge pull request #29335 from kitaisreal/function-h3-get-faces-optimization 
Function h3GetFaces optimization
 2021-09-25 01:54:17 +03:00
Maksim Kita
830eae6d1f
Merge pull request #29310 from kitaisreal/parser-number-binary-literal-update 
Parser number binary literal update
 2021-09-25 01:35:22 +03:00
Alexey Milovidov
4a44bcaced Fix trivial mistake in DiskWebServer 2021-09-25 01:33:40 +03:00
feng lv
0009cab962 add virtual columns 2021-09-24 16:44:22 +00:00
Amos Bird
23d3d894e6
Fix projection merges and mutations. 2021-09-24 22:45:50 +08:00
alesapin
3614fb9e37
Merge pull request #29223 from ClickHouse/compressed_logs 
Compressed logs for keeper
 2021-09-24 16:03:26 +03:00
Vladimir C
908ae1dc12
Merge pull request #29075 from vdimir/quantile-overflow 2021-09-24 15:03:15 +03:00
Nikolai Kochetov
193f566568 Fix exception message. 2021-09-24 14:54:39 +03:00
Anton Popov
62dea79b78 better formatting 2021-09-24 14:41:49 +03:00
Maksim Kita
5af3f617f4 Fixed tests 2021-09-24 14:19:46 +03:00
Anton Popov
4017b1eb89
Update src/Storages/ColumnsDescription.cpp 
Co-authored-by: Vladimir C <vdimir@clickhouse.com>
 2021-09-24 14:08:33 +03:00
Maksim Kita
edeaa6d6d8 Function h3GetFaces optimization 2021-09-24 14:06:36 +03:00
Nikolai Kochetov
9d3e8fb9c3 Tiny fix. 2021-09-24 13:41:52 +03:00
Nikolai Kochetov
cc53ba283d Try fix other tests. 2021-09-24 13:23:28 +03:00
Alexander Tokmakov
165765659d fix assertion in DDLDependencyVisitor 2021-09-24 13:22:22 +03:00
Vasily Nemkov
1d20014d5d Fixed clang12 build and updated tests 2021-09-24 13:11:00 +03:00
vdimir
db5477e634
Fix style in QuantileTDigest.h 2021-09-24 13:08:46 +03:00
vdimir
58a756da9e
Handle overflow in quantileTDigest 2021-09-24 13:08:45 +03:00
Vladimir C
604dc8861d
Apply suggestions from code review 
Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
 2021-09-24 13:07:24 +03:00
Nikolai Kochetov
e617aeb7a5
Merge pull request #29139 from amosbird/projection-fix17 
Disable projections when ARRAY JOIN is used.
 2021-09-24 11:15:23 +03:00
feng lv
9456c67486 fix 
fix test

fix

fix

fix

exception handle
 2021-09-24 02:59:47 +00:00
bharatnc
52289fa41e Merge remote-tracking branch 'upstream/master' into ncb/complete-h3-inspection-funcs 2021-09-23 14:51:13 -07:00
Maksim Kita
5047e1a452 Parser number binary literal update 2021-09-24 00:35:41 +03:00
Maksim Kita
1ebb49d939 Revert parse number binary literal 2021-09-24 00:23:15 +03:00
bharatnc
de65461158 Merge remote-tracking branch 'upstream/master' into ncb/complete-h3-inspection-funcs 2021-09-23 13:44:36 -07:00
bharatnc
b13edbfee8 Cast dst_data to ColumnUInt8 2021-09-23 12:37:12 -07:00
Vladimir Chebotarev
0343106692
Fixed logging level for message in S3Common.cpp. 2021-09-23 21:47:31 +03:00
bharatnc
53a2ebead5 Use const auto * and & 2021-09-23 11:01:38 -07:00
Maksim Kita
193fbf5db0 Parser number binary literal 2021-09-23 21:00:16 +03:00
Amos Bird
983ee004c7
Add empty key description builder. 2021-09-24 01:35:41 +08:00
bharatnc
f02d81be24 Merge remote-tracking branch 'upstream/master' into ncb/complete-h3-inspection-funcs 2021-09-23 08:59:39 -07:00
bharatnc
494c59d2c0 Add more review fixes for h3GetFaces 2021-09-23 08:58:53 -07:00
vdimir
9ca9a66a70
Fix race in StorageSystemRocksDB truncate 2021-09-23 17:03:33 +03:00
alesapin
eb3a651bab Fix bug found on review 2021-09-23 16:55:50 +03:00
vdimir
81a051e3ee
Use dynamic_pointer_cast instead of dynamic_cast in StorageSystemRocksDB 2021-09-23 16:40:10 +03:00
Anton Popov
0390035963 fix unit test 2021-09-23 16:11:31 +03:00
Maksim Kita
23f865c722
Merge pull request #29282 from azat/fix-connection-timeout 
Fix connection timeouts (send_timeout/receive_timeout)
 2021-09-23 15:30:53 +03:00
Kruglov Pavel
55553026ee
Merge pull request #29206 from azat/strict-external-queries 
Add ability to disable converting expressions to local filter for external queries
 2021-09-23 13:22:12 +03:00
Nikolai Kochetov
998d29ebc7 Merge branch 'master' into rewrite-pushing-to-views 2021-09-23 13:10:27 +03:00
Nikolai Kochetov
562ce8c7c2 Fix virtuals. 2021-09-23 13:01:52 +03:00
Kruglov Pavel
6461391387
Merge pull request #29077 from Avogar/fix-msgpack 
Improve MsgPack input/output format
 2021-09-23 12:46:36 +03:00
Maksim Kita
3d79812427 Merge branch 'master' into full-text-bloom-filter-index-map-data-type 2021-09-23 12:38:03 +03:00
Maksim Kita
0341b99c69
Merge pull request #29280 from kitaisreal/full-text-bloom-filter-added-support-for-array-data-type 
FullText bloom filter index added support for Array data type
 2021-09-23 12:34:06 +03:00
Maksim Kita
313f967204 UserDefinedExecutableFunction fix debug message 2021-09-23 12:14:21 +03:00
Maksim Kita
d9e265df2c Fixed debug message 2021-09-23 12:13:01 +03:00
Maksim Kita
d59986f224
Merge pull request #29278 from kitaisreal/bloom-filter-map-added-support-for-has-function 
Bloom filter map added support for has function
 2021-09-23 12:03:56 +03:00
kssenii
6c1312760f Remove debug 2021-09-23 07:52:52 +00:00
Kseniia Sumarokova
f7ff14b407
Merge pull request #28577 from kssenii/named-collections 
Predefined connections and other parameters for external data sources
 2021-09-23 10:25:23 +03:00
kssenii
d71b6ad657 Fix 2021-09-23 07:21:08 +00:00
Azat Khuzhin
015695b3bf Fix connection timeouts (send_timeout/receive_timeout) 
Query is not executed within sendQuery() function.

INSERT query consist from multiple parts:
- sendQuery()
- write()/writePrepared() -- send Data blocks
- writeSuffix() -- send empty Data block and receive EndOfStream
(see RemoteBlockOutputStream for more info)
So as you can see it is not executed completely from the sendQuery() function.

SELECT query (and others) also send Data blocks to the client after.

And what this means that temporary timeout (via TimeoutSetter) is not
enough, since next query can use timeout from the previous query.

Usually you do not see it, because:
- You don't use custom send_timeout/receive_timeout
- SELECT is fast enough

However it is not the case with INSERT, especially with
insert_distributed_sync=1, since
DistributedBlockOutputStream::writeSuffix() may stack because remote
server still INSERT'ing the data (i.e. creating znodes in zookeeper for
ReplicatedMergeTree, syncing blocks, and similar) that was issued from
DistributedBlockOutputStream::write(), and it will lead to the following
exception:

    Code: 209, e.displayText() = DB::NetException: Timeout exceeded while reading from socket (127.1:9000): while receiving packet from ch-47-drt.dpa.semrush.net:9000: Insertion status:
    Wrote X blocks and Y rows on shard Z replica 0, 127.1:9000 (average 0 ms per block, the slowest block N ms)
    0. DB::Exception::Exception()
    1. DB::ReadBufferFromPocoSocket::nextImpl()
    2. void DB::readVarUIntImpl<false>(unsigned long&, DB::ReadBuffer&)
    3. DB::Connection::receivePacket()
    4. DB::RemoteBlockOutputStream::writeSuffix()
    ...
 2021-09-23 09:03:13 +03:00
bharatnc
727182c3a4 Add review fixes 2021-09-22 22:50:33 -07:00
Maksim Kita
ebbefd49c3 FullText bloom filter index added support for Array data type 2021-09-23 02:06:54 +03:00
Vasily Nemkov
cb1ca9b33e Implemented modifying table comments with ALTER TABLE t MODIFY COMMENT 'value' 2021-09-23 01:14:00 +03:00
Maksim Kita
d5a7e92b97 Bloom filter map added support for has function 2021-09-23 01:10:14 +03:00
Maksim Kita
1bf375e2b7
Merge pull request #29254 from kitaisreal/map-bloom-filter-index-updated 
Updated bloom filter index for map type to work with mapKeys, mapValues functions
 2021-09-23 00:31:14 +03:00
Maksim Kita
2920e124f3
Merge pull request #29267 from kitaisreal/function-has-support-map-type 
Function has support map type
 2021-09-23 00:26:58 +03:00
Nikita Mikhaylov
32aa2ca939
Merge pull request #29257 from nikitamikhaylov/race-merge-task 
Fix segfault in fast test
 2021-09-23 00:12:31 +03:00
mergify[bot]
d69fc35dd9
Merge branch 'master' into compressed_logs 2021-09-22 19:43:16 +00:00
Nikolai Kochetov
4f802d1cea Fix test_executable_table_function 2021-09-22 22:31:12 +03:00
hhell
fc166570d8
Fix typo in an error message 
Related: https://github.com/ClickHouse/ClickHouse/issues/20551
 2021-09-22 21:33:15 +03:00
Maksim Kita
7eca0a1486
Merge pull request #29258 from vdimir/fuse-quantileBFloat16Weighted 
Add NameQuantileBFloat16Weighted to GatherFunctionQuantileVisitor
 2021-09-22 20:38:55 +03:00
Maksim Kita
93208fca4b Bloom filter for map data type dded support for IN, mapContains functions 2021-09-22 20:25:10 +03:00
Kseniia Sumarokova
b41a446e8b
Delete getEngineConnectionArguments.h 2021-09-22 19:52:55 +03:00
Maksim Kita
c73808615b Function has support map type 2021-09-22 19:08:08 +03:00
Anton Popov
8943389d03 normalize ASTs in ColumnsDescription 2021-09-22 18:55:20 +03:00
Kruglov Pavel
b46e4db70e
Fix PVS check 2.0 2021-09-22 18:22:34 +03:00
kssenii
a84fc77b52 Fixes 2021-09-22 18:10:25 +03:00
tavplubix
ba82781e11
Merge pull request #29061 from ClickHouse/remove_some_trash 
Fix `system.distributed_ddl_queue`
 2021-09-22 16:58:29 +03:00
mergify[bot]
c5ef025b64
Merge branch 'master' into fix-msgpack 2021-09-22 13:33:05 +00:00
Nikolai Kochetov
eed4e8c754 Fix progress for insert select. 2021-09-22 16:29:58 +03:00
vdimir
eb1053d931
Add NameQuantileBFloat16Weighted to GatherFunctionQuantileVisitor 2021-09-22 15:53:39 +03:00
mergify[bot]
a3f62af09c
Merge branch 'master' into race-merge-task 2021-09-22 12:42:45 +00:00
Nikita Mikhaylov
558c74e826 Done 2021-09-22 11:52:47 +00:00
Nikolai Kochetov
81bf13a247 Refactor pushing to views. 2021-09-22 13:57:00 +03:00
Kruglov Pavel
7545bff76c
Minor update 2021-09-22 13:47:03 +03:00
alesapin
258ce2436a
Merge pull request #29237 from CurtizJ/better-logging 
Better diagnostic in ReplicatedMergeTree
 2021-09-22 13:45:10 +03:00
alesapin
f980a414ee Better tests and ability to work without compression 2021-09-22 13:38:06 +03:00
mergify[bot]
627a4fea96
Merge branch 'master' into fix-msgpack 2021-09-22 10:14:18 +00:00
Pavel Kruglov
9ed82fb44a Fix PVS check 2021-09-22 13:13:05 +03:00
Maksim Kita
92fd6b376f Updated bloom filter index for map type to work with mapKeys function 2021-09-22 12:45:48 +03:00
Kseniia Sumarokova
192c5397cc
Merge pull request #29211 from kssenii/better-retries-2 
Fix retries for disk web
 2021-09-22 12:37:25 +03:00
alesapin
3a11cc59b0 Rename back 2021-09-22 12:16:56 +03:00
kssenii
b51840a205 Merge branch 'master' of github.com:ClickHouse/ClickHouse into named-collections 2021-09-22 11:45:22 +03:00
Nikolai Kochetov
d018cb7adf Fry fix executor again. 2021-09-22 11:30:02 +03:00
alesapin
043ef03d42 revert method name 2021-09-22 10:30:15 +03:00
feng lv
f637f4f2d1 remove unused variable 
update test

update
 2021-09-22 07:24:18 +00:00
Nikolai Kochetov
2c7239da66 Fix executor. 2021-09-22 09:49:59 +03:00
bharatnc
bdd9a4a352 Fix style check 2021-09-21 23:40:56 -07:00
万康
7201b2476e fix spell error 2021-09-22 13:26:05 +08:00