Commit Graph

18255 Commits

Author SHA1 Message Date
Nikolai Kochetov
562ce8c7c2 Fix virtuals. 2021-09-23 13:01:52 +03:00
Kruglov Pavel
6461391387
Merge pull request #29077 from Avogar/fix-msgpack
Improve MsgPack input/output format
2021-09-23 12:46:36 +03:00
Maksim Kita
3d79812427 Merge branch 'master' into full-text-bloom-filter-index-map-data-type 2021-09-23 12:38:03 +03:00
Maksim Kita
0341b99c69
Merge pull request #29280 from kitaisreal/full-text-bloom-filter-added-support-for-array-data-type
FullText bloom filter index added support for Array data type
2021-09-23 12:34:06 +03:00
Maksim Kita
313f967204 UserDefinedExecutableFunction fix debug message 2021-09-23 12:14:21 +03:00
Maksim Kita
d9e265df2c Fixed debug message 2021-09-23 12:13:01 +03:00
Maksim Kita
d59986f224
Merge pull request #29278 from kitaisreal/bloom-filter-map-added-support-for-has-function
Bloom filter map added support for has function
2021-09-23 12:03:56 +03:00
kssenii
6c1312760f Remove debug 2021-09-23 07:52:52 +00:00
Kseniia Sumarokova
f7ff14b407
Merge pull request #28577 from kssenii/named-collections
Predefined connections and other parameters for external data sources
2021-09-23 10:25:23 +03:00
kssenii
d71b6ad657 Fix 2021-09-23 07:21:08 +00:00
Azat Khuzhin
015695b3bf Fix connection timeouts (send_timeout/receive_timeout)
Query is not executed within sendQuery() function.

INSERT query consist from multiple parts:
- sendQuery()
- write()/writePrepared() -- send Data blocks
- writeSuffix() -- send empty Data block and receive EndOfStream
(see RemoteBlockOutputStream for more info)
So as you can see it is not executed completely from the sendQuery() function.

SELECT query (and others) also send Data blocks to the client after.

And what this means that temporary timeout (via TimeoutSetter) is not
enough, since next query can use timeout from the previous query.

Usually you do not see it, because:
- You don't use custom send_timeout/receive_timeout
- SELECT is fast enough

However it is not the case with INSERT, especially with
insert_distributed_sync=1, since
DistributedBlockOutputStream::writeSuffix() may stack because remote
server still INSERT'ing the data (i.e. creating znodes in zookeeper for
ReplicatedMergeTree, syncing blocks, and similar) that was issued from
DistributedBlockOutputStream::write(), and it will lead to the following
exception:

    Code: 209, e.displayText() = DB::NetException: Timeout exceeded while reading from socket (127.1:9000): while receiving packet from ch-47-drt.dpa.semrush.net:9000: Insertion status:
    Wrote X blocks and Y rows on shard Z replica 0, 127.1:9000 (average 0 ms per block, the slowest block N ms)
    0. DB::Exception::Exception()
    1. DB::ReadBufferFromPocoSocket::nextImpl()
    2. void DB::readVarUIntImpl<false>(unsigned long&, DB::ReadBuffer&)
    3. DB::Connection::receivePacket()
    4. DB::RemoteBlockOutputStream::writeSuffix()
    ...
2021-09-23 09:03:13 +03:00
bharatnc
727182c3a4 Add review fixes 2021-09-22 22:50:33 -07:00
Maksim Kita
ebbefd49c3 FullText bloom filter index added support for Array data type 2021-09-23 02:06:54 +03:00
Vasily Nemkov
cb1ca9b33e Implemented modifying table comments with ALTER TABLE t MODIFY COMMENT 'value' 2021-09-23 01:14:00 +03:00
Maksim Kita
d5a7e92b97 Bloom filter map added support for has function 2021-09-23 01:10:14 +03:00
Maksim Kita
1bf375e2b7
Merge pull request #29254 from kitaisreal/map-bloom-filter-index-updated
Updated bloom filter index for map type to work with mapKeys, mapValues functions
2021-09-23 00:31:14 +03:00
Maksim Kita
2920e124f3
Merge pull request #29267 from kitaisreal/function-has-support-map-type
Function has support map type
2021-09-23 00:26:58 +03:00
Nikita Mikhaylov
32aa2ca939
Merge pull request #29257 from nikitamikhaylov/race-merge-task
Fix segfault in fast test
2021-09-23 00:12:31 +03:00
mergify[bot]
d69fc35dd9
Merge branch 'master' into compressed_logs 2021-09-22 19:43:16 +00:00
Nikolai Kochetov
4f802d1cea Fix test_executable_table_function 2021-09-22 22:31:12 +03:00
hhell
fc166570d8
Fix typo in an error message
Related: https://github.com/ClickHouse/ClickHouse/issues/20551
2021-09-22 21:33:15 +03:00
Maksim Kita
7eca0a1486
Merge pull request #29258 from vdimir/fuse-quantileBFloat16Weighted
Add NameQuantileBFloat16Weighted to GatherFunctionQuantileVisitor
2021-09-22 20:38:55 +03:00
Maksim Kita
93208fca4b Bloom filter for map data type dded support for IN, mapContains functions 2021-09-22 20:25:10 +03:00
Kseniia Sumarokova
b41a446e8b
Delete getEngineConnectionArguments.h 2021-09-22 19:52:55 +03:00
Maksim Kita
c73808615b Function has support map type 2021-09-22 19:08:08 +03:00
Anton Popov
8943389d03 normalize ASTs in ColumnsDescription 2021-09-22 18:55:20 +03:00
Kruglov Pavel
b46e4db70e
Fix PVS check 2.0 2021-09-22 18:22:34 +03:00
kssenii
a84fc77b52 Fixes 2021-09-22 18:10:25 +03:00
tavplubix
ba82781e11
Merge pull request #29061 from ClickHouse/remove_some_trash
Fix `system.distributed_ddl_queue`
2021-09-22 16:58:29 +03:00
mergify[bot]
c5ef025b64
Merge branch 'master' into fix-msgpack 2021-09-22 13:33:05 +00:00
Nikolai Kochetov
eed4e8c754 Fix progress for insert select. 2021-09-22 16:29:58 +03:00
vdimir
eb1053d931
Add NameQuantileBFloat16Weighted to GatherFunctionQuantileVisitor 2021-09-22 15:53:39 +03:00
mergify[bot]
a3f62af09c
Merge branch 'master' into race-merge-task 2021-09-22 12:42:45 +00:00
Nikita Mikhaylov
558c74e826 Done 2021-09-22 11:52:47 +00:00
Nikolai Kochetov
81bf13a247 Refactor pushing to views. 2021-09-22 13:57:00 +03:00
Kruglov Pavel
7545bff76c
Minor update 2021-09-22 13:47:03 +03:00
alesapin
258ce2436a
Merge pull request #29237 from CurtizJ/better-logging
Better diagnostic in ReplicatedMergeTree
2021-09-22 13:45:10 +03:00
alesapin
f980a414ee Better tests and ability to work without compression 2021-09-22 13:38:06 +03:00
mergify[bot]
627a4fea96
Merge branch 'master' into fix-msgpack 2021-09-22 10:14:18 +00:00
Pavel Kruglov
9ed82fb44a Fix PVS check 2021-09-22 13:13:05 +03:00
Maksim Kita
92fd6b376f Updated bloom filter index for map type to work with mapKeys function 2021-09-22 12:45:48 +03:00
Kseniia Sumarokova
192c5397cc
Merge pull request #29211 from kssenii/better-retries-2
Fix retries for disk web
2021-09-22 12:37:25 +03:00
alesapin
3a11cc59b0 Rename back 2021-09-22 12:16:56 +03:00
kssenii
b51840a205 Merge branch 'master' of github.com:ClickHouse/ClickHouse into named-collections 2021-09-22 11:45:22 +03:00
Nikolai Kochetov
d018cb7adf Fry fix executor again. 2021-09-22 11:30:02 +03:00
alesapin
043ef03d42 revert method name 2021-09-22 10:30:15 +03:00
feng lv
f637f4f2d1 remove unused variable
update test

update
2021-09-22 07:24:18 +00:00
Nikolai Kochetov
2c7239da66 Fix executor. 2021-09-22 09:49:59 +03:00
bharatnc
bdd9a4a352 Fix style check 2021-09-21 23:40:56 -07:00
万康
7201b2476e fix spell error 2021-09-22 13:26:05 +08:00
feng lv
dfdf756b6a Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into filelog-engine 2021-09-22 02:51:51 +00:00
feng lv
cd6f8078b5 refactor some code 2021-09-22 02:07:59 +00:00
bharatnc
8336847be6 Merge remote-tracking branch 'upstream/master' into ncb/complete-h3-inspection-funcs 2021-09-21 17:43:47 -07:00
bharatnc
208dfc998a H3 - fix logic to return icosahedron faces 2021-09-21 17:39:59 -07:00
bharatnc
8203c5462a Fix a small comment 2021-09-21 16:45:29 -07:00
bharatnc
32baa1ddae Fix getH3Faces logic 2021-09-21 14:08:09 -07:00
alexey-milovidov
3203fa4c34
Merge pull request #28914 from ClickHouse/exp-smooth
Add aggregate function for exponential smoothing
2021-09-21 23:52:44 +03:00
alesapin
334a7ab8db Change default extension to zst 2021-09-21 23:43:44 +03:00
alexey-milovidov
c6dd891471
Merge pull request #29180 from azat/socket-timeout-to-message
Add socket timeout values into SOCKET_TIMEOUT exception
2021-09-21 23:41:30 +03:00
alesapin
eec44929f1 Fix clang tidy 2021-09-21 23:40:14 +03:00
Anton Popov
0fbfac056d better diagnostic in ReplicatedMergeTree 2021-09-21 22:42:03 +03:00
Maksim Kita
84e37c2d87 Fixed tests 2021-09-21 21:28:52 +03:00
Alexey Milovidov
1f74a98baf Merge branch 'master' of github.com:yandex/ClickHouse 2021-09-21 21:05:48 +03:00
Alexey Milovidov
087d0683c9 Updates to YAMLParser and FileChecker 2021-09-21 21:05:08 +03:00
Maksim Kita
19d70158fe
Merge pull request #29215 from ClickHouse/bloom-filter-index-map-data-type
Merging #28634
2021-09-21 20:31:14 +03:00
tavplubix
e54bd40102
Merge pull request #29216 from ClickHouse/fix_29122
Fix terminate on uncaught exception
2021-09-21 20:12:51 +03:00
Nikolai Kochetov
912393a7ed Fix pvs check. 2021-09-21 19:55:32 +03:00
feng lv
e3fa2e3634 fix
fix

update tests

update tests
2021-09-21 16:53:24 +00:00
Nikolai Kochetov
db6f1e198c Add cancell callback to completed executor. 2021-09-21 19:37:32 +03:00
alesapin
5a8c801635 Remove unused variable 2021-09-21 18:50:21 +03:00
alesapin
ac7579f187 Compressed logs for keeper 2021-09-21 17:29:05 +03:00
Maksim Kita
6dadc521fb MergeTreeIndexFullText updated for data type map 2021-09-21 16:55:48 +03:00
凌涛
e3e3b84f63 fix tests 2021-09-21 16:55:48 +03:00
凌涛
9461d6dbf2 modify code style 2021-09-21 16:55:47 +03:00
凌涛
e84f1000fb optimze code to make sure only map function will be processed 2021-09-21 16:55:47 +03:00
凌涛
a3e657778a bloom filter skipping index support Map with key of String type 2021-09-21 16:55:07 +03:00
凌涛
8f87d44958 bloom filter skipping index support Map with key of String type 2021-09-21 16:55:07 +03:00
Nikita Mikhaylov
7878d848ab
Merge pull request #29207 from bharatnc/ncb/run-ya-make
Update outdated ya.make files
2021-09-21 16:07:56 +03:00
Maksim Kita
15c9315ea1 MergeTreeIndexConditionBloomFilter updated for Map data type 2021-09-21 15:07:59 +03:00
Kseniia Sumarokova
17b1dd4bc6
Merge branch 'master' into better-retries-2 2021-09-21 13:55:53 +03:00
Anton Popov
ea4fd19e28
Merge pull request #29087 from CurtizJ/asyn-inserts-follow-up
Minor enhancements in async inserts
2021-09-21 13:38:52 +03:00
Nikolai Kochetov
02e5e662fd Refactor a little bit. 2021-09-21 13:35:41 +03:00
kssenii
975033e6e3 Fix 2021-09-21 09:44:54 +00:00
Vladimir C
bc7c41efff
Merge pull request #26657 from hexiaoting/fuse_quantile 2021-09-21 12:33:07 +03:00
Vladimir C
9abd8aea6d
Merge pull request #29123 from depressed-pho/csv-custom-null 2021-09-21 11:35:21 +03:00
Alexander Tokmakov
7e346ec6ec fix terminate on uncaught exception 2021-09-21 11:04:22 +03:00
Nikolai Kochetov
0308f14bea Fix another one test. 2021-09-21 11:01:00 +03:00
fuwhu
8962672e59 add bloom filter skip index for map data type. 2021-09-21 10:59:16 +03:00
Azat Khuzhin
23b3085c8b Add more tests for external_table_strict_query 2021-09-21 10:53:22 +03:00
Nikolai Kochetov
12a4c74af0 Fix more tests again 2021-09-21 09:57:55 +03:00
bharatnc
b4e86e98db Fix typo 2021-09-20 22:57:43 -07:00
tavplubix
5f4c665c76
Merge pull request #29201 from ClickHouse/follow_up_to_28373
Follow up to #28373
2021-09-21 08:26:15 +03:00
bharatnc
49e6023d65 H3 - add func H3GetFaces 2021-09-20 19:20:02 -07:00
bharatnc
536f3a52d9 H3 - Add func H3IsPentagon 2021-09-20 18:50:45 -07:00
bharatnc
8a8ff94b99 Update ya.make file 2021-09-20 18:32:26 -07:00
bharatnc
51e45050c1 Update outdated ya.make files
This runs the `utils/generate-ya-make/generate-ya-make.sh` script to
update the ya.make files that are not updated.

I wonder why they were not updated and how it was missed.
2021-09-20 18:28:07 -07:00
bharatnc
1766702a60 H3 - add func ResIsClassIII 2021-09-20 18:18:10 -07:00
Azat Khuzhin
9c20519f33 Add ability to disable converting expressions to local filter for external queries
Sometimes it is undesirable to remove any expressions from WHERE, since
this may lead to reading the whole table, and this is pretty heavy job
for MySQL and PostgreSQL (even if you read only one column).

So external_table_strict_query had been introduced to prohibit this and
fail the query instead.
2021-09-21 02:41:07 +03:00
Maksim Kita
1932d29ed1
Merge pull request #29199 from kitaisreal/parser-system-query-fix
ParserSystemQuery fix
2021-09-21 02:23:51 +03:00
Maksim Kita
ad2052e8e5 Added comments 2021-09-21 02:23:34 +03:00
Nikolai Kochetov
4e7d5191e3 Fix more tests 2021-09-20 22:07:33 +03:00
Maksim Kita
494ec4aecc Fixed tests 2021-09-20 21:33:25 +03:00
Nikolai Kochetov
d391e3419e Fixing build. 2021-09-20 20:54:01 +03:00
Anton Popov
83e45adad6 Merge remote-tracking branch 'upstream/master' into HEAD 2021-09-20 20:04:50 +03:00
Anton Popov
55cf857aba
Merge pull request #28707 from azat/max_suspicious_broken_parts_bytes
Implement max_suspicious_broken_parts_bytes
2021-09-20 19:55:07 +03:00
Alexander Tokmakov
4087de5439 follow up to 28373 2021-09-20 19:44:00 +03:00
Nikolai Kochetov
a790d391c0 Merge branch 'master' into rewrite-pushing-to-views 2021-09-20 19:43:15 +03:00
Nikolai Kochetov
c7533d58ee Add debug output. 2021-09-20 19:09:39 +03:00
Maksim Kita
56e40e1ff4 ParserSystemQuery fix 2021-09-20 18:15:23 +03:00
Nikolai Kochetov
211bf07e68 Another try to fix crash. 2021-09-20 18:10:21 +03:00
tavplubix
8adfb9b593
Stop ThreadFuzzer before hung check (#29167)
* stop ThreadFuzzer before hung check

* fix

* fix
2021-09-20 17:23:10 +03:00
Nikolai Kochetov
00dba6e745 Fix crash in kill 2021-09-20 16:08:52 +03:00
tavplubix
66bc619c3e
Merge pull request #28983 from ClickHouse/func_zookeeper_session_uptime
Add function zookeeperSessionUptime(), fix some flaky tests
2021-09-20 14:47:49 +03:00
tavplubix
922cf7ee20
Merge pull request #28373 from ClickHouse/tables_topsort
Resolve table dependencies on metadata loading
2021-09-20 14:46:47 +03:00
alesapin
a249dcc5f5
Merge pull request #28301 from kssenii/materialized-postgresql
MaterializedPostgreSQL: allow dynamically adding/deleting tables, altering settings
2021-09-20 14:16:29 +03:00
alesapin
f983381e45
Merge pull request #29030 from nicelulu/fix-keeper-converter
keeper-converter add the last logfile that is less than the zxid.
2021-09-20 13:49:07 +03:00
Nikolai Kochetov
729e530fe7 Try fix crash. 2021-09-20 13:36:01 +03:00
Nikolai Kochetov
4eba3fcc8a Fix even more tests. 2021-09-20 12:48:53 +03:00
alexey-milovidov
5f5b96aa57
Merge pull request #28982 from vdimir/issue-28660-pmj-fuzz
Add additional checkTypesOfKeys to JoiningTransform::transformHeader
2021-09-20 12:30:00 +03:00
Maksim Kita
c2088678ed
Merge pull request #28803 from kitaisreal/executable-user-defined-functions
Executable user defined functions
2021-09-20 12:11:15 +03:00
Nikolai Kochetov
9398c22aae Fix more tests. 2021-09-20 12:05:34 +03:00
vdimir
091ce151bf
Avoid cycles in optimizeFuseQuantileFunctions 2021-09-20 11:39:29 +03:00
Azat Khuzhin
e5f66fd103 Add socket timeout values into SOCKET_TIMEOUT exception 2021-09-20 09:51:42 +03:00
Kseniia Sumarokova
2a8f355326
Merge pull request #29179 from kssenii/better-retries
Better retries for disk web
2021-09-20 08:25:49 +03:00
kssenii
12b90da5de Better retries 2021-09-19 20:50:50 +00:00
Nikolai Kochetov
2b7d71d3a2 Fix some other tests. 2021-09-19 23:15:10 +03:00
Alexey Milovidov
894f4908fa Add comments 2021-09-19 22:26:16 +03:00
Nikolai Kochetov
c1f0ba1f92 Fix some tests. 2021-09-19 21:53:36 +03:00
Alexey Milovidov
edb4c58ecc Fix build 2021-09-19 21:13:00 +03:00
Alexey Milovidov
322b67a533 Clarifications 2021-09-19 20:58:10 +03:00
Alexey Milovidov
04c5574ce6 Add comments 2021-09-19 20:51:35 +03:00
Alexey Milovidov
7d24e110e4 Make something with more sense 2021-09-19 20:23:06 +03:00
Nikolai Kochetov
53e946ec25 Fix executors. 2021-09-19 19:18:38 +03:00
Alexey Milovidov
b444d224b0 Merge branch 'master' into exp-smooth 2021-09-19 17:58:57 +03:00
Anton Popov
e3e6258b95
Merge pull request #29163 from CurtizJ/small-refactoring
Slightly better code near reading of subcolumns
2021-09-19 16:14:52 +03:00
Anton Popov
db50a1027e
Merge pull request #29132 from Avogar/fix-avro
Fix segfault in Avro with LowCardinality(Nullable)
2021-09-19 16:13:11 +03:00
Anton Popov
f50098a059
fix style check 2021-09-19 00:13:00 +03:00
Anton Popov
1c80a95b36 slightly better code near reading of subcolumns 2021-09-18 22:34:54 +03:00
alexey-milovidov
20d8523a2e
Merge pull request #28888 from azat/mysql-in-fix
Fix queries to external databases (i.e. MySQL) with multiple columns in IN ( i.e. `(k,v) IN ((1, 2))` )
2021-09-18 15:53:40 +03:00
alexey-milovidov
e16e8fa286
Update ExpressionElementParsers.cpp 2021-09-18 15:47:57 +03:00
alexey-milovidov
3eed1f06ea
Merge pull request #28952 from fuzzERot/h3-functions
Implementation of h3ToGeoBoundary
2021-09-18 14:27:11 +03:00
feng lv
4fbc7c3f31 remove unused code 2021-09-18 03:01:25 +00:00
Amos Bird
6b3cd34cff
Disable projections when ARRAY JOIN is used. 2021-09-18 08:15:59 +08:00
tavplubix
749b91347d
Update PostgreSQLDictionarySource.cpp 2021-09-17 22:39:54 +03:00
Alexander Tokmakov
3bca886174 remove some trash 2021-09-17 22:29:10 +03:00
Azat Khuzhin
b108c5e1b0 Implement max_suspicious_broken_parts_bytes
Usually broken parts are found from just created parts, which are
usually small enough, so it make sense to have a limit in bytes for
broken parts.

Default value was set to 1G.
2021-09-17 22:06:32 +03:00
Nikolai Kochetov
a8443bef4d Fix build. 2021-09-17 20:52:26 +03:00
Maksim Kita
784a4a33e0 Fixed tests 2021-09-17 18:43:00 +03:00
Maksim Kita
85a4d4bb50 Added user defined executable functions to system.functions 2021-09-17 18:43:00 +03:00
Maksim Kita
ca395e9678 Fixed tests 2021-09-17 18:43:00 +03:00
Maksim Kita
ca3fc352d6 Fixed tests 2021-09-17 18:43:00 +03:00
Maksim Kita
581f051f37 Fixed build 2021-09-17 18:43:00 +03:00
Maksim Kita
769fab62e3 UserDefinedExecutableFunction added send_chunk_header option 2021-09-17 18:43:00 +03:00
Maksim Kita
3852954b49 Fixed build 2021-09-17 18:43:00 +03:00
Maksim Kita
bb3bc6722a UserDefinedExecutableFunction added support for process pool 2021-09-17 18:43:00 +03:00
Maksim Kita
93ecbf3ae4 Added tests 2021-09-17 18:42:59 +03:00
Maksim Kita
de20e04dfd Added executable user defined functions 2021-09-17 18:42:59 +03:00
feng lv
5f97cad9a4 fix 2021-09-17 15:32:01 +00:00
alesapin
4adc4e9152
Merge pull request #28817 from ClickHouse/fix_part_checker
Fix rare replicas diverge
2021-09-17 18:06:27 +03:00
Pavel Kruglov
aba86b010b Update docs, tests and add some fixes 2021-09-17 17:32:23 +03:00
Vladimir Chebotarev
db516e8c91
Removed sub-optimal mutation notifications in StorageMergeTree when merges are still going (#27552)
* Removed redundand mutation notifications in `StorageMergeTree` when merges are still going.
2021-09-17 16:19:36 +03:00
Pavel Kruglov
7bf13c4891 Remove extra space 2021-09-17 16:13:15 +03:00
Pavel Kruglov
48a3a2f75c Fix segfault in Avro with LowCardinality(Nullable) 2021-09-17 16:11:44 +03:00
Maksim Kita
14e4d49601
Merge pull request #29063 from ClickHouse/read-integer-overflow-bug-fix
Merging #27963
2021-09-17 16:06:58 +03:00
Nikolai Kochetov
618d4d863e Restore InterpreterInsertQuery 2021-09-17 15:59:40 +03:00
Nikolai Kochetov
a8c3b02598 Merge branch 'master' into rewrite-pushing-to-views 2021-09-17 15:38:11 +03:00
Nikolai Kochetov
6e0ac024a2 Maybe fix some build. 2021-09-17 15:05:54 +03:00
Vladimir C
333fd323f5
Merge pull request #29062 from Avogar/orc-fixes 2021-09-17 14:48:19 +03:00
Vladimir C
4eaf2969e2
Merge pull request #28332 from OodounaikingoO/master 2021-09-17 14:46:20 +03:00
Nikolai Kochetov
58bb5fe462 Fix some tests. 2021-09-17 14:40:03 +03:00
anneji
258159e13d add default database for alter table 2021-09-17 17:30:17 +08:00
Maksim Kita
73368aa351 Fixed tests 2021-09-17 12:17:19 +03:00
PHO
3c4b1ea9c5 New setting: output_format_csv_null_representation
This is the same as output_format_tsv_null_representation but is for CSV output.
2021-09-17 17:58:23 +09:00
alesapin
d0b5485773
Merge pull request #29071 from nicelulu/fix_deserializeCheckVersionTxn
Fix deserializeCheckVersionTxn version.
2021-09-17 10:40:02 +03:00
mergify[bot]
c23f1fc160
Merge branch 'master' into fix_part_checker 2021-09-17 07:23:12 +00:00
PHO
5a4985fe27 Do not initialize std::pair with a std::tuple<T1, T2>
GCC/libstdc++ does not allow this and emits a compilation error. The standard does not say they are supposed to be interchangeable.
2021-09-17 11:12:05 +09:00
Nikita Mikhaylov
c52b8ec083
Introduced MergeTask and MutateTask (#25165)
Introduced MergeTask and MutateTask
2021-09-17 00:19:58 +03:00
Kseniia Sumarokova
e9d44d0848
Merge pull request #28797 from kssenii/rabbit-fix
Rewrite StorageRabbitMQ a little
2021-09-16 23:58:51 +03:00
Azat Khuzhin
60013cff1a Do not call finalize() for HTTP buffer multiple times
Before only non-compressed was flushed, and so after compressed will
write to non-compressed and this will trigger multiple finalize() for
raw buffer, fix this, but adding Output::finalize() that take care of
all buffers.

This should fix CI failure [1] and also not only CI failures but also an
assert() that had been added in the previous commit.

    2021-09-05 15:08:43 00429_long_http_bufferization:                                          [ FAIL ] 6.68 sec. - return code 1
    2021-09-05 15:08:43 cmp: EOF on /tmp/clickhouse-test/0_stateless/test_e4xs61/res3 after byte 1048576, in line 4127
    2021-09-05 15:08:43 , result:

    The problem was with the following query:

        curl -q -sS 'http://localhost:8123/?database=default&log_comment=/src/ch/clickhouse/tests/queries/0_stateless/00429_long_http_bufferization.sh&max_block_size=500000&compress=1&buffer_size=1048576&wait_end_of_query=1' -d 'SELECT greatest(toUInt8(1), toUInt8(intHash64(number))) FROM system.numbers LIMIT 1500000 FORMAT RowBinary' | clickhouse-compressor --decompress | less

    It returns less rows.

  [1]: https://clickhouse-test-reports.s3.yandex.net/28604/1f34fd9a9eaff19fde0199f78b45656ab74f0590/functional_stateless_tests_(release).html#fail1
2021-09-16 22:36:09 +03:00
Azat Khuzhin
9bb9d5952b Catch write-after-finalize bugs in WriteBufferFromHTTPServerResponse 2021-09-16 22:35:51 +03:00
Azat Khuzhin
7b741c28e4 Do not try to write HTTP response after exception
CI reports [1]:

    [ 25285 ] {} <Trace> DynamicQueryHandler: Request URI: /?database=test_27&log_comment=/usr/share/clickhouse-test/queries/0_stateless/00429_long_http_bufferization.sh&max_block_size=500000&compress=1&buffer_size=1500000&wait_end_of_query=1
    ...
    [ 25285 ] {ee96eb9c-44cc-4b76-9f30-3cc545a5506f} <Debug> executeQuery: (from [::1]:41578) (comment: /usr/share/clickhouse-test/queries/0_stateless/00429_long_http_bufferization.sh) SELECT greatest(toUInt8(1), toUInt8(intHash64(number))) FROM system.numbers LIMIT 1048576 FORMAT RowBinary
    [ 25285 ] {ee96eb9c-44cc-4b76-9f30-3cc545a5506f} <Information> executeQuery: Read 1500000 rows, 11.44 MiB in 63.924507821 sec., 23465 rows/sec., 183.32 KiB/sec.
    [ 25285 ] {ee96eb9c-44cc-4b76-9f30-3cc545a5506f} <Debug> DynamicQueryHandler: Done processing query
    ...
    [ 455 ] {} <Fatal> BaseDaemon: Code: 24. DB::Exception: Cannot write to ostream at offset 2097152. (CANNOT_WRITE_TO_OSTREAM), Stack trace (when copying this message, always include the lines below):
    [ 455 ] {} <Fatal> BaseDaemon:
    [ 455 ] {} <Fatal> BaseDaemon: 0. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/exception:0: Poco::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0x18fa949b in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 1. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:59: DB::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, bool) @ 0x99f38dc in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 2. ./obj-x86_64-linux-gnu/../src/IO/WriteBufferFromOStream.cpp:0: DB::WriteBufferFromOStream::nextImpl() @ 0x9adf185 in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 3. ./obj-x86_64-linux-gnu/../src/IO/BufferBase.h:39: DB::WriteBufferFromHTTPServerResponse::nextImpl() @ 0x15b71ec0 in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 4. ./obj-x86_64-linux-gnu/../src/IO/WriteBuffer.h:0: DB::WriteBuffer::write(char const*, unsigned long) @ 0x99be96a in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 5. ./obj-x86_64-linux-gnu/../src/Compression/CompressedWriteBuffer.cpp:36: DB::CompressedWriteBuffer::nextImpl() @ 0x1436ca4d in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 6. ./obj-x86_64-linux-gnu/../src/IO/BufferBase.h:39: DB::CompressedWriteBuffer::~CompressedWriteBuffer() @ 0x1436cd8f in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 7. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2615: std::__1::__shared_ptr_emplace<DB::CompressedWriteBuffer, std::__1::allocator<DB::CompressedWriteBuffer> >::__on_zero_shared() @ 0x15a88ee8 in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 8. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2518: DB::HTTPHandler::handleRequest(DB::HTTPServerRequest&, DB::HTTPServerResponse&) @ 0x15b0566b in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 9. ./obj-x86_64-linux-gnu/../src/Server/HTTP/HTTPServerConnection.cpp:0: DB::HTTPServerConnection::run() @ 0x15b6ba61 in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 10. ./obj-x86_64-linux-gnu/../contrib/poco/Net/src/TCPServerConnection.cpp:57: Poco::Net::TCPServerConnection::start() @ 0x18ec71a3 in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 11. ./obj-x86_64-linux-gnu/../contrib/poco/Net/src/TCPServerDispatcher.cpp:114: Poco::Net::TCPServerDispatcher::run() @ 0x18ec7930 in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 12. ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/include/Poco/ScopedLock.h:36: Poco::PooledThread::run() @ 0x1903e042 in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 13. ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Thread.cpp:56: Poco::(anonymous namespace)::RunnableHolder::run() @ 0x1903c4d0 in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 14. ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/include/Poco/SharedPtr.h:277: Poco::ThreadImpl::runnableEntry(void*) @ 0x1903ac48 in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 15. __tsan_thread_start_func @ 0x990a76d in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 16. start_thread @ 0x9609 in /usr/lib/x86_64-linux-gnu/libpthread-2.31.so
    [ 455 ] {} <Fatal> BaseDaemon: 17. clone @ 0x122293 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    [ 455 ] {} <Fatal> BaseDaemon:  (version 21.10.1.7997)
    [ 25878 ] {} <Fatal> BaseDaemon: ########################################
    [ 25878 ] {} <Fatal> BaseDaemon: (version 21.10.1.7997, build id: DB9812D7EA89EB06D2C7243F5C8BD293AA9BA37D) (from thread 25285) (query_id: ee96eb9c-44cc-4b76-9f30-3cc545a5506f) Received signal Aborted (6)
    [ 25878 ] {} <Fatal> BaseDaemon:
    [ 25878 ] {} <Fatal> BaseDaemon: Stack trace: 0x7efe2a35818b 0x7efe2a337859 0x990ff6e 0x13fa707d 0x1bb17614 0x1bb17507 0x999c97b 0x1436cf11 0x15a88ee8 0x15b0566b 0x15b6ba61 0x18ec71a3 0x18ec7930 0x1903e042 0x1903c4d0 0x1903ac48 0x990a76d 0x7efe2a50d609 0x7efe2a434293
    [ 25878 ] {} <Fatal> BaseDaemon: 5. raise @ 0x4618b in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    [ 25878 ] {} <Fatal> BaseDaemon: 6. abort @ 0x25859 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    [ 450 ] {} <Fatal> Application: Child process was terminated by signal 6.

  [1]: https://clickhouse-test-reports.s3.yandex.net/28604/d6e86dab2754dbea3ed19d9ae72276e7d161aef1/stress_test_(thread).html#fail1
2021-09-16 22:35:51 +03:00
Azat Khuzhin
230f29ac4e Always flush buffer while handling HTTP queries
This will avoid possible std::terminate, like in [1]:

  [1]: https://github.com/ClickHouse/ClickHouse/pull/24023#issuecomment-842979875
2021-09-16 22:35:50 +03:00
Azat Khuzhin
47ad10061b Reduce scope for HTTPHandler::trySendExceptionToClient() 2021-09-16 22:35:50 +03:00
Anton Popov
99175f7acc minor enhancements in async inserts 2021-09-16 20:55:34 +03:00
Nikolai Kochetov
341553febd Fix build. 2021-09-16 20:40:42 +03:00
mergify[bot]
e0376e1e77
Merge branch 'master' into fix_deserializeCheckVersionTxn 2021-09-16 16:18:11 +00:00
alesapin
2d9fa85c0a
Merge pull request #28889 from azat/fix-mutation-wait
Fix waiting for mutation with mutations_sync=2
2021-09-16 19:10:56 +03:00
alesapin
606ab6d3e4 Typo fix 2021-09-16 18:40:25 +03:00
alesapin
8930a0d2bd More precise initialization 2021-09-16 18:39:11 +03:00
Anton Popov
77a995381b
Merge pull request #28975 from ClickHouse/check-what-if-do-not-add-const-agg-keys-with-having
Don not add const group by key for query with only having.
2021-09-16 18:33:53 +03:00
alesapin
b4cbc86164 Fix bug 2021-09-16 17:59:55 +03:00
Kruglov Pavel
50c0045e27
Remove unused header 2021-09-16 17:13:07 +03:00
Pavel Kruglov
96dba14213 Improve MsgPack input/output format 2021-09-16 17:05:07 +03:00
kssenii
7b068317c1 Fix build 2021-09-16 13:55:18 +00:00
vdimir
661a54827b
Do not throw LOGICAL_ERROR from fuse quantile for illegal params 2021-09-16 16:06:02 +03:00
Pavel Kruglov
2b67d54d58 tmp 2021-09-16 14:25:45 +03:00
kssenii
432ca1ed93 Fix tests 2021-09-16 10:46:43 +00:00
zhangxiao871
1faa98a48a Fix deserializeCheckVersionTxn version. 2021-09-16 18:34:13 +08:00
Kruglov Pavel
1b0da15291
Use detachColumns
Co-authored-by: Vladimir C <vdimir@yandex-team.ru>
2021-09-16 12:22:39 +03:00
tavplubix
23f54658a6
Update serverConstants.cpp 2021-09-16 12:15:22 +03:00
kssenii
1650c92407 Better 2021-09-16 11:38:26 +03:00
Anton Popov
dfbb1ffec0
Merge pull request #27537 from CurtizJ/merging-20557
Merging #20557 (Asynchronous inserts)
2021-09-16 03:08:34 +03:00
Nikita Mikhaylov
6bf5b4cf2d
Merge pull request #28953 from vitlibar/allow-change-server-side-compression-from-client
gRPC: Allow change server-side compression from client.
2021-09-16 00:55:06 +03:00
Maksim Kita
49f04700cc Fixed style 2021-09-16 00:29:29 +03:00
mergify[bot]
d4ac1fdba0
Merge branch 'master' into h3-functions 2021-09-15 21:24:31 +00:00
alexey-milovidov
10a314dd46
Update h3ToGeoBoundary.cpp 2021-09-16 00:24:12 +03:00
Alexander Tokmakov
d0c3b87d84 improvements 2021-09-16 00:17:54 +03:00
Maksim Kita
7a72a765c2 Added tests 2021-09-16 00:01:01 +03:00
mergify[bot]
a8e9450d91
Merge branch 'master' into exp-smooth 2021-09-15 20:55:32 +00:00
Maksim Kita
7c748b6140
Merge pull request #27963 from zhanglistar/overflow_bugfix
Overflow bugfix
2021-09-15 23:31:43 +03:00
Nikolai Kochetov
e616732743 Small refactoring. 2021-09-15 22:35:48 +03:00
Pavel Kruglov
2e9858172e Allow to input and output LowCardinality columns in ORC format 2021-09-15 22:04:36 +03:00
kssenii
221c09589c Review fixes 2021-09-15 21:11:49 +03:00
Alexander Tokmakov
5c605189ac Merge branch 'master' into func_zookeeper_session_uptime 2021-09-15 21:10:06 +03:00
kssenii
489a92c067 Review fixes 2021-09-15 18:36:49 +03:00
Vitaly Stoyan
9bbdd39efc initial commit 2021-09-15 18:07:18 +03:00
Anton Popov
f6191b98e7 Merge remote-tracking branch 'upstream/master' into HEAD 2021-09-15 17:47:22 +03:00
Anton Popov
8970dcdaf5 fix throwing exception for multiple clients in async inserts 2021-09-15 17:19:28 +03:00
feng lv
dc318000e4 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into filelog-engine 2021-09-15 14:12:49 +00:00
Kruglov Pavel
8d1bf1b675
Merge pull request #29008 from vdimir/issue-26980-join-id-alias
Do not replaceAliasColumnsInQuery for JOIN OR/USING sections
2021-09-15 16:27:46 +03:00
Nikita Mikhaylov
2684d06b51
Merge pull request #27135 from FArthur-cmd/compressed_output_formats_3473
compress INTO OUTFILE with parameter compress
2021-09-15 16:25:13 +03:00
Kruglov Pavel
8a67c3cf44
Merge pull request #28636 from amosbird/nullable-index-fix
Fix nullable/lowcardinality primary key with constant conversion
2021-09-15 15:56:19 +03:00
vdimir
cd7fb8132d
Split GatherFunctionQuantileVisitor to h/cpp, fix fuzzed bugs 2021-09-15 15:15:42 +03:00
chenjian
f99c2da4d8 fix build and style error 2021-09-15 18:03:41 +08:00
kssenii
84c8757049 Merge branch 'master' of github.com:ClickHouse/ClickHouse into named-collections 2021-09-15 12:28:31 +03:00
kssenii
710c8d12dd Merge branch 'master' of github.com:ClickHouse/ClickHouse into materialized-postgresql 2021-09-15 12:28:09 +03:00
Kseniia Sumarokova
fbc048b2bf
Merge branch 'master' into rabbit-fix 2021-09-15 12:11:57 +03:00
kssenii
32c9f76ddc Some fixes 2021-09-15 09:09:24 +00:00
Maksim Kita
69e59f34da
Merge pull request #29014 from vdimir/issue-29007-dict-join-strictness
Check left join strictness in tryInitDictJoin
2021-09-15 11:11:30 +03:00
mergify[bot]
9b499ed762
Merge branch 'master' into fix_part_checker 2021-09-15 07:39:09 +00:00
Anton Popov
9646edf3dc fix possible race in AsynchronousInsertQueue 2021-09-15 02:54:10 +03:00
Anton Popov
6c50615bdf
Merge pull request #28905 from CurtizJ/describe-with-subcolumns
Allow to include subcolumns in `DESCRIBE`  query
2021-09-15 02:42:24 +03:00
Anton Popov
fc17936c12 Merge remote-tracking branch 'upstream/master' into HEAD 2021-09-14 23:02:30 +03:00
mergify[bot]
0cbd4eda60
Merge branch 'master' into fix_part_checker 2021-09-14 19:44:11 +00:00
Vitaly Stoyan
a416fd52d8 initial commit 2021-09-14 21:22:18 +03:00
Nikolai Kochetov
b997214620 Rename QueryPipeline to QueryPipelineBuilder. 2021-09-14 20:48:18 +03:00
zhangxiao871
c86832b1d7 fix deserialize log order. 2021-09-15 01:19:19 +08:00
zhangxiao871
ba33fbbf1d add the last logfile that is less than the zxid. 2021-09-15 01:14:14 +08:00
Nikolai Kochetov
7fc830ae2b Rename QueryPipeline to QueryPipelineBuilder. 2021-09-14 19:28:41 +03:00
mergify[bot]
fa903ac255
Merge branch 'master' into describe-with-subcolumns 2021-09-14 14:43:29 +00:00
Nikolai Kochetov
6a32a949e6 Fix read_rows for live view. 2021-09-14 17:22:26 +03:00
alesapin
5a755d1e7c
Merge pull request #29009 from ClickHouse/improve_error_message
Better error message on concurrent alters
2021-09-14 17:21:26 +03:00
mergify[bot]
4993c7c527
Merge branch 'master' into fix_part_checker 2021-09-14 14:13:52 +00:00
Nikolai Kochetov
0e267c50b4 Merge branch 'master' into rewrite-pushing-to-views 2021-09-14 16:13:54 +03:00
vdimir
a3304a87a4
Rename optimize_syntax_fuse_aggregate -> optimize_syntax_fuse_functions 2021-09-14 15:27:12 +03:00
vdimir
a1463d5719
Merge remote-tracking branch 'origin/master' into fuse_quantile 2021-09-14 15:23:06 +03:00
vdimir
5a1aeeb044
Use optimize_syntax_fuse_aggregate instead of optimize_fuse_sum_count_avg and optimize_fuse_quantile 2021-09-14 15:21:16 +03:00
vdimir
a3db56f056
Revert "fuse multi setting options into one when Optimize"
This reverts commit bbd7799375.
2021-09-14 15:12:21 +03:00
vdimir
2aef13e802
Update error messages for logical errors in HashJoin 2021-09-14 15:05:09 +03:00
vdimir
32e8c11cab
Check left join strictness in tryInitDictJoin 2021-09-14 15:04:45 +03:00