Commit Graph

18255 Commits

Author SHA1 Message Date
Maksim Kita
ca3fc352d6 Fixed tests 2021-09-17 18:43:00 +03:00
Maksim Kita
581f051f37 Fixed build 2021-09-17 18:43:00 +03:00
Maksim Kita
769fab62e3 UserDefinedExecutableFunction added send_chunk_header option 2021-09-17 18:43:00 +03:00
Maksim Kita
3852954b49 Fixed build 2021-09-17 18:43:00 +03:00
Maksim Kita
bb3bc6722a UserDefinedExecutableFunction added support for process pool 2021-09-17 18:43:00 +03:00
Maksim Kita
93ecbf3ae4 Added tests 2021-09-17 18:42:59 +03:00
Maksim Kita
de20e04dfd Added executable user defined functions 2021-09-17 18:42:59 +03:00
feng lv
5f97cad9a4 fix 2021-09-17 15:32:01 +00:00
alesapin
4adc4e9152
Merge pull request #28817 from ClickHouse/fix_part_checker
Fix rare replicas diverge
2021-09-17 18:06:27 +03:00
Pavel Kruglov
aba86b010b Update docs, tests and add some fixes 2021-09-17 17:32:23 +03:00
Vladimir Chebotarev
db516e8c91
Removed sub-optimal mutation notifications in StorageMergeTree when merges are still going (#27552)
* Removed redundand mutation notifications in `StorageMergeTree` when merges are still going.
2021-09-17 16:19:36 +03:00
Pavel Kruglov
7bf13c4891 Remove extra space 2021-09-17 16:13:15 +03:00
Pavel Kruglov
48a3a2f75c Fix segfault in Avro with LowCardinality(Nullable) 2021-09-17 16:11:44 +03:00
Maksim Kita
14e4d49601
Merge pull request #29063 from ClickHouse/read-integer-overflow-bug-fix
Merging #27963
2021-09-17 16:06:58 +03:00
Nikolai Kochetov
618d4d863e Restore InterpreterInsertQuery 2021-09-17 15:59:40 +03:00
Nikolai Kochetov
a8c3b02598 Merge branch 'master' into rewrite-pushing-to-views 2021-09-17 15:38:11 +03:00
Nikolai Kochetov
6e0ac024a2 Maybe fix some build. 2021-09-17 15:05:54 +03:00
Vladimir C
333fd323f5
Merge pull request #29062 from Avogar/orc-fixes 2021-09-17 14:48:19 +03:00
Vladimir C
4eaf2969e2
Merge pull request #28332 from OodounaikingoO/master 2021-09-17 14:46:20 +03:00
Nikolai Kochetov
58bb5fe462 Fix some tests. 2021-09-17 14:40:03 +03:00
anneji
258159e13d add default database for alter table 2021-09-17 17:30:17 +08:00
Maksim Kita
73368aa351 Fixed tests 2021-09-17 12:17:19 +03:00
PHO
3c4b1ea9c5 New setting: output_format_csv_null_representation
This is the same as output_format_tsv_null_representation but is for CSV output.
2021-09-17 17:58:23 +09:00
alesapin
d0b5485773
Merge pull request #29071 from nicelulu/fix_deserializeCheckVersionTxn
Fix deserializeCheckVersionTxn version.
2021-09-17 10:40:02 +03:00
mergify[bot]
c23f1fc160
Merge branch 'master' into fix_part_checker 2021-09-17 07:23:12 +00:00
PHO
5a4985fe27 Do not initialize std::pair with a std::tuple<T1, T2>
GCC/libstdc++ does not allow this and emits a compilation error. The standard does not say they are supposed to be interchangeable.
2021-09-17 11:12:05 +09:00
Nikita Mikhaylov
c52b8ec083
Introduced MergeTask and MutateTask (#25165)
Introduced MergeTask and MutateTask
2021-09-17 00:19:58 +03:00
Kseniia Sumarokova
e9d44d0848
Merge pull request #28797 from kssenii/rabbit-fix
Rewrite StorageRabbitMQ a little
2021-09-16 23:58:51 +03:00
Azat Khuzhin
60013cff1a Do not call finalize() for HTTP buffer multiple times
Before only non-compressed was flushed, and so after compressed will
write to non-compressed and this will trigger multiple finalize() for
raw buffer, fix this, but adding Output::finalize() that take care of
all buffers.

This should fix CI failure [1] and also not only CI failures but also an
assert() that had been added in the previous commit.

    2021-09-05 15:08:43 00429_long_http_bufferization:                                          [ FAIL ] 6.68 sec. - return code 1
    2021-09-05 15:08:43 cmp: EOF on /tmp/clickhouse-test/0_stateless/test_e4xs61/res3 after byte 1048576, in line 4127
    2021-09-05 15:08:43 , result:

    The problem was with the following query:

        curl -q -sS 'http://localhost:8123/?database=default&log_comment=/src/ch/clickhouse/tests/queries/0_stateless/00429_long_http_bufferization.sh&max_block_size=500000&compress=1&buffer_size=1048576&wait_end_of_query=1' -d 'SELECT greatest(toUInt8(1), toUInt8(intHash64(number))) FROM system.numbers LIMIT 1500000 FORMAT RowBinary' | clickhouse-compressor --decompress | less

    It returns less rows.

  [1]: https://clickhouse-test-reports.s3.yandex.net/28604/1f34fd9a9eaff19fde0199f78b45656ab74f0590/functional_stateless_tests_(release).html#fail1
2021-09-16 22:36:09 +03:00
Azat Khuzhin
9bb9d5952b Catch write-after-finalize bugs in WriteBufferFromHTTPServerResponse 2021-09-16 22:35:51 +03:00
Azat Khuzhin
7b741c28e4 Do not try to write HTTP response after exception
CI reports [1]:

    [ 25285 ] {} <Trace> DynamicQueryHandler: Request URI: /?database=test_27&log_comment=/usr/share/clickhouse-test/queries/0_stateless/00429_long_http_bufferization.sh&max_block_size=500000&compress=1&buffer_size=1500000&wait_end_of_query=1
    ...
    [ 25285 ] {ee96eb9c-44cc-4b76-9f30-3cc545a5506f} <Debug> executeQuery: (from [::1]:41578) (comment: /usr/share/clickhouse-test/queries/0_stateless/00429_long_http_bufferization.sh) SELECT greatest(toUInt8(1), toUInt8(intHash64(number))) FROM system.numbers LIMIT 1048576 FORMAT RowBinary
    [ 25285 ] {ee96eb9c-44cc-4b76-9f30-3cc545a5506f} <Information> executeQuery: Read 1500000 rows, 11.44 MiB in 63.924507821 sec., 23465 rows/sec., 183.32 KiB/sec.
    [ 25285 ] {ee96eb9c-44cc-4b76-9f30-3cc545a5506f} <Debug> DynamicQueryHandler: Done processing query
    ...
    [ 455 ] {} <Fatal> BaseDaemon: Code: 24. DB::Exception: Cannot write to ostream at offset 2097152. (CANNOT_WRITE_TO_OSTREAM), Stack trace (when copying this message, always include the lines below):
    [ 455 ] {} <Fatal> BaseDaemon:
    [ 455 ] {} <Fatal> BaseDaemon: 0. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/exception:0: Poco::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0x18fa949b in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 1. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:59: DB::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, bool) @ 0x99f38dc in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 2. ./obj-x86_64-linux-gnu/../src/IO/WriteBufferFromOStream.cpp:0: DB::WriteBufferFromOStream::nextImpl() @ 0x9adf185 in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 3. ./obj-x86_64-linux-gnu/../src/IO/BufferBase.h:39: DB::WriteBufferFromHTTPServerResponse::nextImpl() @ 0x15b71ec0 in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 4. ./obj-x86_64-linux-gnu/../src/IO/WriteBuffer.h:0: DB::WriteBuffer::write(char const*, unsigned long) @ 0x99be96a in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 5. ./obj-x86_64-linux-gnu/../src/Compression/CompressedWriteBuffer.cpp:36: DB::CompressedWriteBuffer::nextImpl() @ 0x1436ca4d in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 6. ./obj-x86_64-linux-gnu/../src/IO/BufferBase.h:39: DB::CompressedWriteBuffer::~CompressedWriteBuffer() @ 0x1436cd8f in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 7. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2615: std::__1::__shared_ptr_emplace<DB::CompressedWriteBuffer, std::__1::allocator<DB::CompressedWriteBuffer> >::__on_zero_shared() @ 0x15a88ee8 in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 8. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2518: DB::HTTPHandler::handleRequest(DB::HTTPServerRequest&, DB::HTTPServerResponse&) @ 0x15b0566b in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 9. ./obj-x86_64-linux-gnu/../src/Server/HTTP/HTTPServerConnection.cpp:0: DB::HTTPServerConnection::run() @ 0x15b6ba61 in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 10. ./obj-x86_64-linux-gnu/../contrib/poco/Net/src/TCPServerConnection.cpp:57: Poco::Net::TCPServerConnection::start() @ 0x18ec71a3 in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 11. ./obj-x86_64-linux-gnu/../contrib/poco/Net/src/TCPServerDispatcher.cpp:114: Poco::Net::TCPServerDispatcher::run() @ 0x18ec7930 in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 12. ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/include/Poco/ScopedLock.h:36: Poco::PooledThread::run() @ 0x1903e042 in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 13. ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Thread.cpp:56: Poco::(anonymous namespace)::RunnableHolder::run() @ 0x1903c4d0 in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 14. ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/include/Poco/SharedPtr.h:277: Poco::ThreadImpl::runnableEntry(void*) @ 0x1903ac48 in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 15. __tsan_thread_start_func @ 0x990a76d in /usr/bin/clickhouse
    [ 455 ] {} <Fatal> BaseDaemon: 16. start_thread @ 0x9609 in /usr/lib/x86_64-linux-gnu/libpthread-2.31.so
    [ 455 ] {} <Fatal> BaseDaemon: 17. clone @ 0x122293 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    [ 455 ] {} <Fatal> BaseDaemon:  (version 21.10.1.7997)
    [ 25878 ] {} <Fatal> BaseDaemon: ########################################
    [ 25878 ] {} <Fatal> BaseDaemon: (version 21.10.1.7997, build id: DB9812D7EA89EB06D2C7243F5C8BD293AA9BA37D) (from thread 25285) (query_id: ee96eb9c-44cc-4b76-9f30-3cc545a5506f) Received signal Aborted (6)
    [ 25878 ] {} <Fatal> BaseDaemon:
    [ 25878 ] {} <Fatal> BaseDaemon: Stack trace: 0x7efe2a35818b 0x7efe2a337859 0x990ff6e 0x13fa707d 0x1bb17614 0x1bb17507 0x999c97b 0x1436cf11 0x15a88ee8 0x15b0566b 0x15b6ba61 0x18ec71a3 0x18ec7930 0x1903e042 0x1903c4d0 0x1903ac48 0x990a76d 0x7efe2a50d609 0x7efe2a434293
    [ 25878 ] {} <Fatal> BaseDaemon: 5. raise @ 0x4618b in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    [ 25878 ] {} <Fatal> BaseDaemon: 6. abort @ 0x25859 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    [ 450 ] {} <Fatal> Application: Child process was terminated by signal 6.

  [1]: https://clickhouse-test-reports.s3.yandex.net/28604/d6e86dab2754dbea3ed19d9ae72276e7d161aef1/stress_test_(thread).html#fail1
2021-09-16 22:35:51 +03:00
Azat Khuzhin
230f29ac4e Always flush buffer while handling HTTP queries
This will avoid possible std::terminate, like in [1]:

  [1]: https://github.com/ClickHouse/ClickHouse/pull/24023#issuecomment-842979875
2021-09-16 22:35:50 +03:00
Azat Khuzhin
47ad10061b Reduce scope for HTTPHandler::trySendExceptionToClient() 2021-09-16 22:35:50 +03:00
Anton Popov
99175f7acc minor enhancements in async inserts 2021-09-16 20:55:34 +03:00
Nikolai Kochetov
341553febd Fix build. 2021-09-16 20:40:42 +03:00
mergify[bot]
e0376e1e77
Merge branch 'master' into fix_deserializeCheckVersionTxn 2021-09-16 16:18:11 +00:00
alesapin
2d9fa85c0a
Merge pull request #28889 from azat/fix-mutation-wait
Fix waiting for mutation with mutations_sync=2
2021-09-16 19:10:56 +03:00
alesapin
606ab6d3e4 Typo fix 2021-09-16 18:40:25 +03:00
alesapin
8930a0d2bd More precise initialization 2021-09-16 18:39:11 +03:00
Anton Popov
77a995381b
Merge pull request #28975 from ClickHouse/check-what-if-do-not-add-const-agg-keys-with-having
Don not add const group by key for query with only having.
2021-09-16 18:33:53 +03:00
alesapin
b4cbc86164 Fix bug 2021-09-16 17:59:55 +03:00
Kruglov Pavel
50c0045e27
Remove unused header 2021-09-16 17:13:07 +03:00
Pavel Kruglov
96dba14213 Improve MsgPack input/output format 2021-09-16 17:05:07 +03:00
kssenii
7b068317c1 Fix build 2021-09-16 13:55:18 +00:00
vdimir
661a54827b
Do not throw LOGICAL_ERROR from fuse quantile for illegal params 2021-09-16 16:06:02 +03:00
Pavel Kruglov
2b67d54d58 tmp 2021-09-16 14:25:45 +03:00
kssenii
432ca1ed93 Fix tests 2021-09-16 10:46:43 +00:00
zhangxiao871
1faa98a48a Fix deserializeCheckVersionTxn version. 2021-09-16 18:34:13 +08:00
Kruglov Pavel
1b0da15291
Use detachColumns
Co-authored-by: Vladimir C <vdimir@yandex-team.ru>
2021-09-16 12:22:39 +03:00
tavplubix
23f54658a6
Update serverConstants.cpp 2021-09-16 12:15:22 +03:00
kssenii
1650c92407 Better 2021-09-16 11:38:26 +03:00
Anton Popov
dfbb1ffec0
Merge pull request #27537 from CurtizJ/merging-20557
Merging #20557 (Asynchronous inserts)
2021-09-16 03:08:34 +03:00
Nikita Mikhaylov
6bf5b4cf2d
Merge pull request #28953 from vitlibar/allow-change-server-side-compression-from-client
gRPC: Allow change server-side compression from client.
2021-09-16 00:55:06 +03:00
Maksim Kita
49f04700cc Fixed style 2021-09-16 00:29:29 +03:00
mergify[bot]
d4ac1fdba0
Merge branch 'master' into h3-functions 2021-09-15 21:24:31 +00:00
alexey-milovidov
10a314dd46
Update h3ToGeoBoundary.cpp 2021-09-16 00:24:12 +03:00
Alexander Tokmakov
d0c3b87d84 improvements 2021-09-16 00:17:54 +03:00
Maksim Kita
7a72a765c2 Added tests 2021-09-16 00:01:01 +03:00
mergify[bot]
a8e9450d91
Merge branch 'master' into exp-smooth 2021-09-15 20:55:32 +00:00
Maksim Kita
7c748b6140
Merge pull request #27963 from zhanglistar/overflow_bugfix
Overflow bugfix
2021-09-15 23:31:43 +03:00
Nikolai Kochetov
e616732743 Small refactoring. 2021-09-15 22:35:48 +03:00
Pavel Kruglov
2e9858172e Allow to input and output LowCardinality columns in ORC format 2021-09-15 22:04:36 +03:00
kssenii
221c09589c Review fixes 2021-09-15 21:11:49 +03:00
Alexander Tokmakov
5c605189ac Merge branch 'master' into func_zookeeper_session_uptime 2021-09-15 21:10:06 +03:00
kssenii
489a92c067 Review fixes 2021-09-15 18:36:49 +03:00
Vitaly Stoyan
9bbdd39efc initial commit 2021-09-15 18:07:18 +03:00
Anton Popov
f6191b98e7 Merge remote-tracking branch 'upstream/master' into HEAD 2021-09-15 17:47:22 +03:00
Anton Popov
8970dcdaf5 fix throwing exception for multiple clients in async inserts 2021-09-15 17:19:28 +03:00
feng lv
dc318000e4 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into filelog-engine 2021-09-15 14:12:49 +00:00
Kruglov Pavel
8d1bf1b675
Merge pull request #29008 from vdimir/issue-26980-join-id-alias
Do not replaceAliasColumnsInQuery for JOIN OR/USING sections
2021-09-15 16:27:46 +03:00
Nikita Mikhaylov
2684d06b51
Merge pull request #27135 from FArthur-cmd/compressed_output_formats_3473
compress INTO OUTFILE with parameter compress
2021-09-15 16:25:13 +03:00
Kruglov Pavel
8a67c3cf44
Merge pull request #28636 from amosbird/nullable-index-fix
Fix nullable/lowcardinality primary key with constant conversion
2021-09-15 15:56:19 +03:00
vdimir
cd7fb8132d
Split GatherFunctionQuantileVisitor to h/cpp, fix fuzzed bugs 2021-09-15 15:15:42 +03:00
chenjian
f99c2da4d8 fix build and style error 2021-09-15 18:03:41 +08:00
kssenii
84c8757049 Merge branch 'master' of github.com:ClickHouse/ClickHouse into named-collections 2021-09-15 12:28:31 +03:00
kssenii
710c8d12dd Merge branch 'master' of github.com:ClickHouse/ClickHouse into materialized-postgresql 2021-09-15 12:28:09 +03:00
Kseniia Sumarokova
fbc048b2bf
Merge branch 'master' into rabbit-fix 2021-09-15 12:11:57 +03:00
kssenii
32c9f76ddc Some fixes 2021-09-15 09:09:24 +00:00
Maksim Kita
69e59f34da
Merge pull request #29014 from vdimir/issue-29007-dict-join-strictness
Check left join strictness in tryInitDictJoin
2021-09-15 11:11:30 +03:00
mergify[bot]
9b499ed762
Merge branch 'master' into fix_part_checker 2021-09-15 07:39:09 +00:00
Anton Popov
9646edf3dc fix possible race in AsynchronousInsertQueue 2021-09-15 02:54:10 +03:00
Anton Popov
6c50615bdf
Merge pull request #28905 from CurtizJ/describe-with-subcolumns
Allow to include subcolumns in `DESCRIBE`  query
2021-09-15 02:42:24 +03:00
Anton Popov
fc17936c12 Merge remote-tracking branch 'upstream/master' into HEAD 2021-09-14 23:02:30 +03:00
mergify[bot]
0cbd4eda60
Merge branch 'master' into fix_part_checker 2021-09-14 19:44:11 +00:00
Vitaly Stoyan
a416fd52d8 initial commit 2021-09-14 21:22:18 +03:00
Nikolai Kochetov
b997214620 Rename QueryPipeline to QueryPipelineBuilder. 2021-09-14 20:48:18 +03:00
zhangxiao871
c86832b1d7 fix deserialize log order. 2021-09-15 01:19:19 +08:00
zhangxiao871
ba33fbbf1d add the last logfile that is less than the zxid. 2021-09-15 01:14:14 +08:00
Nikolai Kochetov
7fc830ae2b Rename QueryPipeline to QueryPipelineBuilder. 2021-09-14 19:28:41 +03:00
mergify[bot]
fa903ac255
Merge branch 'master' into describe-with-subcolumns 2021-09-14 14:43:29 +00:00
Nikolai Kochetov
6a32a949e6 Fix read_rows for live view. 2021-09-14 17:22:26 +03:00
alesapin
5a755d1e7c
Merge pull request #29009 from ClickHouse/improve_error_message
Better error message on concurrent alters
2021-09-14 17:21:26 +03:00
mergify[bot]
4993c7c527
Merge branch 'master' into fix_part_checker 2021-09-14 14:13:52 +00:00
Nikolai Kochetov
0e267c50b4 Merge branch 'master' into rewrite-pushing-to-views 2021-09-14 16:13:54 +03:00
vdimir
a3304a87a4
Rename optimize_syntax_fuse_aggregate -> optimize_syntax_fuse_functions 2021-09-14 15:27:12 +03:00
vdimir
a1463d5719
Merge remote-tracking branch 'origin/master' into fuse_quantile 2021-09-14 15:23:06 +03:00
vdimir
5a1aeeb044
Use optimize_syntax_fuse_aggregate instead of optimize_fuse_sum_count_avg and optimize_fuse_quantile 2021-09-14 15:21:16 +03:00
vdimir
a3db56f056
Revert "fuse multi setting options into one when Optimize"
This reverts commit bbd7799375.
2021-09-14 15:12:21 +03:00
vdimir
2aef13e802
Update error messages for logical errors in HashJoin 2021-09-14 15:05:09 +03:00
vdimir
32e8c11cab
Check left join strictness in tryInitDictJoin 2021-09-14 15:04:45 +03:00
Nikita Mikhaylov
58f2504a56 Update ya.make 2021-09-14 12:00:32 +00:00
alesapin
797df22418 Fix build 2021-09-14 14:45:33 +03:00
Anton Popov
4403847744
Merge pull request #28325 from nicelulu/issues_27763
Bit shift operations for FixedString and String data types.
2021-09-14 14:45:29 +03:00
vdimir
3d2d994c5d
Skip JOIN OR/USING sections in replaceAliasColumnsInQuery 2021-09-14 14:13:19 +03:00
alesapin
76b8d9d85f Better error message on concurrent alters 2021-09-14 13:57:05 +03:00
Nikolai Kochetov
6847610ed3
Merge pull request #28997 from ClickHouse/fix-num-threads-in-global-in-subquery
Fix num threads in global in subquery
2021-09-14 13:53:54 +03:00
hexiaoting
bbd7799375 fuse multi setting options into one when Optimize 2021-09-14 18:51:13 +08:00
vdimir
a7f770ecb7
Do not replaceAliasColumnsInQuery for JOIN OR/USING sections 2021-09-14 13:08:20 +03:00
alesapin
9441378b39 Add logs to queue because I cannot understand anything without them 2021-09-14 12:04:11 +03:00
vdimir
1fdbb9509f
Add additional checkTypesOfKeys to JoiningTransform::transformHeader 2021-09-14 11:03:22 +03:00
feng lv
c58e232385 fix conflict 2021-09-14 06:41:57 +00:00
Kseniia Sumarokova
d3e604e14b
Merge pull request #28603 from kssenii/fix-web-disk-2
Some fixes for static files disk
2021-09-14 08:24:24 +03:00
feng lv
19ed9c6dbc fix 2021-09-14 04:50:18 +00:00
小路
9416c5e74d
Remove outdated comment. 2021-09-14 11:22:34 +08:00
feng lv
94ba18e050 fix 2021-09-14 03:15:05 +00:00
Alexander Tokmakov
f5c38fe027 fix 2021-09-14 00:39:50 +03:00
Alexander Tokmakov
2ec9b6fe3b fix 2021-09-13 22:36:55 +03:00
alesapin
abe314feec
Merge pull request #28962 from azat/create-settings
Apply settings from CREATE AS SELECT queries
2021-09-13 22:14:21 +03:00
Alexander Tokmakov
df56e99b87 fixes after review 2021-09-13 22:11:16 +03:00
Nikolai Kochetov
68bf657c29 Fix the number of threads used in GLOBAL IN. 2021-09-13 20:53:09 +03:00
Anton Popov
2b49f42bca
fix build 2021-09-13 20:37:35 +03:00
Anton Popov
671f98506a
fix build 2021-09-13 20:34:36 +03:00
Anton Popov
7ec5c73c9b
Merge branch 'master' into issues_27763 2021-09-13 20:33:29 +03:00
Kseniia Sumarokova
ef6ba90be1
Update DiskWebServer.h 2021-09-13 20:00:18 +03:00
Nikolai Kochetov
95b00f8fd4 Fix some live view tests. 2021-09-13 19:23:56 +03:00
feng lv
cfa92a0c1e fix
fix
2021-09-13 15:09:02 +00:00
mergify[bot]
4cf11417a4
Merge branch 'master' into compressed_output_formats_3473 2021-09-13 14:12:56 +00:00
Alexander Tokmakov
8ac19caca9 Merge branch 'master' into tables_topsort 2021-09-13 16:58:39 +03:00
mergify[bot]
c54434084f
Merge branch 'master' into fix_part_checker 2021-09-13 13:19:34 +00:00
Alexander Tokmakov
ee8cb93004 add function zookeeperSessionUptime() 2021-09-13 15:19:37 +03:00
alesapin
1d05fab295
Merge pull request #28864 from ClickHouse/fix_replace_range_drop_part_reordering
Fix reordering of REPLACE_RANGE and DROP PART
2021-09-13 15:11:29 +03:00
Nikolai Kochetov
b37168e86f Fix asan. 2021-09-13 14:27:15 +03:00
Nikolai Kochetov
f4b47ca194 Don not add const group by key for query with only having. 2021-09-13 13:35:36 +03:00
mergify[bot]
d731bf6c4d
Merge branch 'master' into compressed_output_formats_3473 2021-09-13 09:14:35 +00:00
Nikita Mikhaylov
4b3c0a95d1
Merge pull request #28046 from syominsergey/fix-build-clang-13-2
[WIP] Improve support for build with clang-13
2021-09-13 12:11:38 +03:00
Filatenkov Artur
c23fe5baf6
Improve codec for encr 19896 (#27476)
* change syntax of encrypted command

* commit all encrypted changes

* correct encryption

* correct config for test

* add tests and correct code style and typos

* correct test

* fix unbundled build

* add log warning messages

* improve code according to review comments

* correct nonce

* correct errors found by fuzzing

* improve codec AES_128_GCM_SIV. Add AES_256_GCM_SIV. Add sections for last in tests. Improve documentation

* Update CompressionCodecEncrypted.h

* Update 01683_codec_encrypted.sql

* correct compression factory after changes in master

* correct behavior with wrong key in data

* correct fuzzer

* add connection for fuzzer with fix for compression_encrypted

* refactor code

* add load from config with throwing errors on server start

* fix typos and check style

* Update Server.cpp

* correct loading and reading

* refactor code. fix uninitialized value

* refactor code

* move defines from server to cpp file

* correct build

* remove repeated code

* correct namespace

* fix code style
2021-09-13 11:25:36 +03:00
alesapin
fa8b698b7e Merge branch 'fix_part_checker' of github.com:ClickHouse/ClickHouse into fix_part_checker 2021-09-13 11:00:41 +03:00
alesapin
ab41384f63 Move queue initialization to restarting thread 2021-09-13 11:00:07 +03:00
Maksim Kita
e9d7dfeeb1
Merge pull request #28863 from kitaisreal/column-default-dict-get-identifier-fix
Column default dictGet identifier fix
2021-09-13 10:56:39 +03:00
alexey-milovidov
b73f71fc06
Merge pull request #28906 from Algunenano/sum_fp
Improve the performance of SUM of nullable floating point numbers
2021-09-13 10:55:51 +03:00
alesapin
91e10adca5 Merge branch 'master' into fix_part_checker 2021-09-13 10:19:04 +03:00
Azat Khuzhin
dad02452c8 Apply settings from CREATE AS SELECT queries 2021-09-13 10:10:00 +03:00
alexey-milovidov
1add234900
Update registerAggregateFunctions.cpp 2021-09-13 08:46:12 +03:00
kssenii
9ec6a9b4c9 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-web-disk-2 2021-09-13 08:32:34 +03:00
feng lv
9d9ba56808 add test
remove unneeded code
2021-09-13 04:51:54 +00:00
alexey-milovidov
ad997cf51e
Merge branch 'master' into exp-smooth 2021-09-13 07:29:49 +03:00
alexey-milovidov
4f073a436b
Update h3ToGeoBoundary.cpp 2021-09-13 07:22:52 +03:00
feng lv
bd1990a67c fix test and restrict path 2021-09-13 03:44:12 +00:00
Vitaly Baranov
81b8062f3c
Merge pull request #28683 from vitlibar/allow-macros-in-rabbitmq-settings
Expand macros in RabbitMQ settings
2021-09-13 03:21:18 +03:00
Vitaly Baranov
113ddceabb gRPC: Allow change server-side compression from client. 2021-09-13 01:07:28 +03:00
kssenii
147e413346 Add retries with backoff, better exceptions 2021-09-13 00:04:05 +03:00
fuzzERot
dba428c443 Implementation of h3ToGeoBoundary 2021-09-12 23:47:51 +03:00
Nikolay Degterinsky
b02c807346
Merge pull request #27481 from nicelulu/add_sparkbar
Add sparkbar aggregate function.
2021-09-12 21:29:24 +03:00
feng lv
aa99516380 fix
fix
2021-09-12 16:43:34 +00:00
Sergei Semin
1034ab87f2 fix -Wreserved-macro-identifier in int_hashes_perf.cpp 2021-09-12 19:36:59 +03:00
Sergei Semin
12e24a23d3
Merge branch 'master' into fix-build-clang-13-2 2021-09-12 19:30:55 +03:00
kssenii
0978c8baab Fix tests 2021-09-12 16:55:37 +03:00
Vitaly Baranov
51dbedafd9 Expand macros in RabbitMQ settings. 2021-09-12 16:42:03 +03:00
alexey-milovidov
dd1c08717c Update ExponentiallySmoothedCounter.h 2021-09-12 16:00:53 +03:00
alexey-milovidov
aa5c42b7db
Merge pull request #28773 from azat/nth_value-ubsan-fix
Fix signed integer overflow for nth_value() window function
2021-09-12 15:57:19 +03:00
alexey-milovidov
60f76d9254
Merge pull request #28759 from nikitamikhaylov/enable-gcc-11
Switch CI to GCC-11
2021-09-12 15:56:57 +03:00
alexey-milovidov
cdcfdbec7e
Merge pull request #28873 from CurtizJ/fix-subcolumns-compact-parts
Fix reading of subcolumns from compact parts
2021-09-12 15:54:07 +03:00
alexey-milovidov
f066edc43c
Merge pull request #28910 from ClickHouse/fix-trash-optimization
Fix bad optimization of ORDER BY in subquery if it contains WITH FILL
2021-09-12 15:27:53 +03:00
alexey-milovidov
ea13a8b562
Merge pull request #28659 from myrrc/improvement/tostring_to_magic_enum
Improving CH type system with concepts
2021-09-12 15:26:29 +03:00
Mike Kot
1f6fb3f6ea Fix gtest, add Decimal aliases, Typelist solution for bin arithm 2021-09-12 14:26:07 +02:00
Raúl Marín
893faa8425 Unroll the loop manually 2021-09-12 13:24:25 +02:00
kssenii
4e5958d721 Merge branch 'master' of github.com:ClickHouse/ClickHouse into rabbit-fix 2021-09-12 13:56:09 +03:00
Alexey Milovidov
9ea1d443ba Add exponentialMovingSum aggregate function 2021-09-12 12:26:13 +03:00
Sergei Semin
c5d6518bb9 fix special build (more) 2021-09-12 10:23:19 +03:00
Sergei Semin
4bf2d64427 fix special build another try 2021-09-12 09:12:14 +03:00
Alexey Milovidov
0e59b20dca Fix comment 2021-09-12 09:11:23 +03:00
Alexey Milovidov
14d34c4cba Fix comment 2021-09-12 09:10:31 +03:00
Alexey Milovidov
6802010c9f Fix comment 2021-09-12 09:09:57 +03:00
alexey-milovidov
1616a0e230
Merge pull request #28887 from Avogar/fix-short-circuit
Fix bug with LowCardinality in short-curcuit function evaluation
2021-09-12 09:06:02 +03:00
alexey-milovidov
294f4c897b
Merge pull request #28904 from azat/higher-order-array-func-consts-fix
Fix higher-order array functions (arrayCompact/arrayDifference/arrayCumSumNonNegative) with consts
2021-09-12 09:04:47 +03:00
Alexey Milovidov
53f4d10d8c Add missing file 2021-09-12 08:28:57 +03:00
Alexey Milovidov
0745631bf7 Add aggregate function for exp smoothing 2021-09-12 08:26:07 +03:00
mergify[bot]
e52f5fdfce
Merge branch 'master' into fix-web-disk-2 2021-09-12 01:21:40 +00:00
Alexey Milovidov
e3611cccce Fix yet another issue 2021-09-12 02:55:53 +03:00
Sergei Semin
f74350c148 fix special build 2021-09-12 02:49:31 +03:00
Alexey Milovidov
8935a70f60 Fix another misoptimization 2021-09-12 01:41:37 +03:00
Alexey Milovidov
d85588210d Fix bad optimization of ORDER BY in subquery if it contains WITH FILL 2021-09-12 01:24:20 +03:00
Alexey Milovidov
526c7253d0 Fix wrong optimization 2021-09-12 01:15:37 +03:00
Kseniia Sumarokova
6cc4ad97c3
Update WriteBufferToRabbitMQProducer.h 2021-09-12 00:35:18 +03:00
Anton Popov
02a7edf902 allow to include subccolumns in describe query 2021-09-12 00:07:33 +03:00
Raúl Marín
9fb8eeaea3 Use project types 2021-09-11 22:54:30 +02:00
Anton Popov
a4153e5629
Merge pull request #28853 from ClickHouse/fix_logical_race_on_dictionaries_loading
Fix logical race on dictionaries loading
2021-09-11 23:41:30 +03:00
Raúl Marín
940e075941 Remove notNull changes 2021-09-11 22:36:22 +02:00
Azat Khuzhin
c7e5cd7cda Fix arrayCumSumNonNegative() for consts 2021-09-11 22:39:30 +03:00
Azat Khuzhin
6403cbee46 Fix arrayDifference() for consts 2021-09-11 22:39:30 +03:00
Azat Khuzhin
3c75844a79 Fix SIGSEGV for arrayCompact() with consts
arrayCompact() implements useDefaultImplementationForConstants() but it
is a no-op for FunctionArrayMapped, fix this.

CI report [1]:

  [1]: https://clickhouse-test-reports.s3.yandex.net/28890/baac2e561cfb05bc174f0bd25571e607d19c7463/fuzzer_asan/report.html#fail1
2021-09-11 22:39:20 +03:00
Raúl Marín
46eb305eec T != Value 2021-09-11 20:46:16 +02:00
kssenii
453bd27c0a Review fixes 2021-09-11 20:40:18 +03:00
Mike Kot
3401b32e37 Adapted usage of is_decimal concept 2021-09-11 19:35:12 +02:00
kssenii
ff602c1fdd Fix build check 2021-09-11 19:29:23 +03:00
mergify[bot]
267e56df8c
Merge branch 'master' into fix-web-disk-2 2021-09-11 15:45:43 +00:00
mergify[bot]
97fbdec71c
Merge branch 'master' into fix-build-clang-13-2 2021-09-11 15:03:52 +00:00
Raúl Marín
a13b6f2a09 WIP: Speed up sum(floating point) 2021-09-11 15:37:52 +02:00
alexey-milovidov
648d561242
Merge pull request #28828 from azat/nested-combinators
Relax nested function for If-combinator check (but forbid nested identical combinators)
2021-09-11 15:53:19 +03:00
Azat Khuzhin
2f1a58f4b0 Fix waiting for mutation with mutations_sync=2
CI: https://clickhouse-test-reports.s3.yandex.net/28827/c6b9816d45e3e8255eb1aee9b9059dfe7397fdab/functional_stateless_tests_(thread).html#fail1
2021-09-11 15:23:00 +03:00
Azat Khuzhin
f40ab891eb Support tuple with zero/one arguments in transformQueryForExternalDatabase() 2021-09-11 14:15:27 +03:00
Azat Khuzhin
e4e584a3de Do not transform (k,v) IN ((K, V)) -> (k, v) IN (K, V) during parsing
Before this patch the query `(k,v) IN ((1, 2))` was transformed `(k,v)
IN (1,2)` by ClickHouse, and this produce the following error while
sending such query to MySQL:

    DB::Exception: mysqlxx::BadQuery: Operand should contain 2 column(s)

(There is a workaround though, add another value for IN section, i.e.
`(k,v) IN ((1,2),(0,0))`, but this is icky)

v0: (k,v) IN ((1,2)) -> (k,v) IN tuple((1,2))
    But these is not supported by transformQueryForExternalDatabase()

v1: (k,v) IN ((1,2)) -> (k,v) IN ((1,2))
    But now you will get an error for the following query:

        SELECT ('foo', 'bar') IN (('foo', 'bar'))

    Now you will get:

        Logical error: 'Trying to get name of not a column: ExpressionList'.

    (from two places, first is DB::ActionsMatcher::visit, easy to fix by
     inherit ASTExpressionList from ASTWithAlias, but the second is
     evaluteConstantExpression(), which  requires additional support for
     these case while creating a set in DB::createBlockForSet())

v2: (k,v) IN ((1,2)) -> (k,v) IN tuple((1,2))
    So instead I prefer these, and add support for this case in
    transformQueryForExternalDatabase() in the next patch.
2021-09-11 14:15:27 +03:00
Azat Khuzhin
0c2f612a86 gtest_transform_query_for_external_database: add test with multiple columns in IN 2021-09-11 14:15:27 +03:00
Azat Khuzhin
ef161f10f7 gtest_transform_query_for_external_database: print input query 2021-09-11 14:15:27 +03:00
Pavel Kruglov
9c756fc4b2 Fix bug with LowCardinality in short-curcuit function evaluation 2021-09-11 12:56:25 +03:00
Maksim Kita
48e8e24552
Merge pull request #28882 from ClickHouse/async-metric-skip-some-exceptions
Skip "no data" exception when reading thermal sensors
2021-09-11 11:36:23 +03:00
Alexey Milovidov
7e084304fb Skip "no data" exception when reading thermal sensors 2021-09-11 10:03:06 +03:00
Azat Khuzhin
ff17de531c Join MaterializedMySQLSyncThread only if it is joinable
It is possible to trigger
MaterializedMySQLSyncThread::stopSynchronization() from the same thread
in case of some exception at startup, when some interpreter holds the
storage refcnt, and later MaterializedMySQLSyncThread will try to join
itself from the main thread.

Here is a stack trace for example:

<details>

    4  0x000000000f7ae45c in Poco::Event::wait (this=0x7f1b90c38170) at ../contrib/poco/Foundation/include/Poco/Event.h:97
    5  ThreadFromGlobalPool::join (this=0x7f1b90c23120) at ../src/Common/ThreadPool.h:210
    6  DB::MaterializeMySQLSyncThread::stopSynchronization (this=0x7f1b8024ca68) at ../src/Databases/MySQL/MaterializeMySQLSyncThread.cpp:229
    7  DB::MaterializeMySQLSyncThread::~MaterializeMySQLSyncThread (this=0x7f1b8024ca68) at ../src/Databases/MySQL/MaterializeMySQLSyncThread.cpp:85
    8  0x000000000f816dc8 in DB::DatabaseMaterializeMySQL<DB::DatabaseAtomic>::~DatabaseMaterializeMySQL (this=0x7f1b8024c918) at ../src/Databases/MySQL/DatabaseMaterializeMySQL.h:21
    11 std::__1::shared_ptr<DB::IDatabase>::~shared_ptr (this=<optimized out>) at ../contrib/libcxx/include/memory:3212
    12 0x000000000f8726a6 in DB::InterpreterCreateQuery::createTable (this=<optimized out>, create=...) at ../src/Interpreters/InterpreterCreateQuery.cpp:952
    13 0x000000000f87735c in DB::InterpreterCreateQuery::execute (this=0x7f1aeef59860) at ../src/Interpreters/InterpreterCreateQuery.cpp:1225
    14 0x000000000fe22253 in DB::executeQueryImpl (begin=<optimized out>, end=<optimized out>, context=..., internal=true, stage=DB::QueryProcessingStage::Complete, has_query_tail=<optimized out>, istr=<optimized out>) at ../src/Interpreters/executeQuery.cpp:574
    15 0x000000000fe208e3 in DB::executeQuery (query=..., context=..., internal=<optimized out>, stage=DB::QueryProcessingStage::FetchColumns, may_have_embedded_data=<optimized out>) at ../src/Interpreters/executeQuery.cpp:933
    16 0x000000000faafcde in DB::MySQLInterpreter::InterpreterMySQLDDLQuery<DB::MySQLInterpreter::InterpreterCreateImpl>::execute (this=<optimized out>) at ../src/Interpreters/MySQL/InterpretersMySQLDDLQuery.h:75
    17 0x000000000faade78 in DB::InterpreterExternalDDLQuery::execute (this=<optimized out>) at ../src/Interpreters/InterpreterExternalDDLQuery.cpp:64
    18 0x000000000fe22253 in DB::executeQueryImpl (begin=<optimized out>, end=<optimized out>, context=..., internal=true, stage=DB::QueryProcessingStage::Complete, has_query_tail=<optimized out>, istr=<optimized out>) at ../src/Interpreters/executeQuery.cpp:574
    19 0x000000000fe208e3 in DB::executeQuery (query=..., context=..., internal=<optimized out>, stage=DB::QueryProcessingStage::FetchColumns, may_have_embedded_data=<optimized out>) at ../src/Interpreters/executeQuery.cpp:933
    20 0x000000000f7ba406 in DB::tryToExecuteQuery (query_to_execute=..., query_context=..., database=..., comment=...) at ../src/Databases/MySQL/MaterializeMySQLSyncThread.cpp:69
    21 0x000000000f7d4b88 in DB::dumpDataForTables() (connection=..., query_prefix=..., database_name=..., mysql_database_name=..., context=..., is_cancelled=..., need_dumping_tables=...) at ../src/Databases/MySQL/MaterializeMySQLSyncThread.cpp:326
    22 DB::MaterializeMySQLSyncThread::prepareSynchronized(DB::MaterializeMetadata&)::$_1::operator()() const (this=<optimized out>) at ../src/Databases/MySQL/MaterializeMySQLSyncThread.cpp:391
    29 DB::commitMetadata() (function=..., persistent_tmp_path=..., persistent_path=...) at ../src/Databases/MySQL/MaterializeMetadata.cpp:197
    30 0x000000000f80a000 in DB::MaterializeMetadata::transaction(DB::MySQLReplication::Position const&, std::__1::function<void ()> const&) (this=0x7f1b6375c3d8, position=..., fun=...) at ../src/Databases/MySQL/MaterializeMetadata.cpp:230
    31 0x000000000f7b2231 in DB::MaterializeMySQLSyncThread::prepareSynchronized (this=0x7f1b8024ca68, metadata=...) at ../src/Databases/MySQL/MaterializeMySQLSyncThread.cpp:388
    32 0x000000000f7b169c in DB::MaterializeMySQLSyncThread::synchronization (this=0x7f1b8024ca68) at ../src/Databases/MySQL/MaterializeMySQLSyncThread.cpp:180
    33 0x000000000f7d4074 in DB::MaterializeMySQLSyncThread::startSynchronization()::$_0::operator()() const (this=<optimized out>) at ../src/Databases/MySQL/MaterializeMySQLSyncThread.cpp:236

</details>
2021-09-11 09:27:12 +03:00
alexey-milovidov
28911a959f
Merge pull request #28431 from azat/thread-pool-joinable
[RFC] Do not allow ThreadFromGlobalPool::join() from the spawned/occupated thread
2021-09-11 05:44:56 +03:00
Mike Kot
bce011cb33 Replacing IsDecimalNumber 2021-09-11 00:40:18 +02:00
Mike Kot
c4385a2c40 Simplifying exception messages 2021-09-11 00:40:18 +02:00
Azat Khuzhin
017dc9fa2a Remove unused ILLEGAL_AGGREGATION from AggregateFunctionIf 2021-09-11 00:48:17 +03:00
Azat Khuzhin
a764d46f62 Eliminate int64_t > INT64_MAX checks (found by PVS)
https://clickhouse-test-reports.s3.yandex.net/28773/b38311538979c0ffe27f6c8c5732b4afc18c4d35/pvs_check.html#fail1
2021-09-10 23:31:41 +03:00
Azat Khuzhin
56ac032413 Use the same error for leadInFrame()/lagInFrame() as in nth_value() 2021-09-10 23:27:36 +03:00
Azat Khuzhin
c362e7c541 Introduce IAggregateFunctionCombinator::supportsNesting() 2021-09-10 22:41:38 +03:00
Azat Khuzhin
d8bf2f81ec Allow Array/OrNull combinators regardless nesting 2021-09-10 22:35:25 +03:00
Azat Khuzhin
1e7714d56d Forbid nested identical (only) combinators
Nested identical combinators (i.e. uniqCombinedIfIf) is not
supported (since they even don't work -- silently).

But non-identical does supported and works, for example
uniqCombinedIfMergeIf, it is useful in case when the underlying
storage stores AggregateFunction(uniqCombinedIf) and in SELECT you
need to filter aggregation result based on another column for
example.
2021-09-10 21:03:24 +03:00
Azat Khuzhin
60df1e8800 Relax nested function for If-combinator check
Second If combinator can be useful to add condition based on another
column, when Merge combinator is applied for example (i.e.
uniqCombinedIfMergeIf(state_of_merge_that_is_stored_in_table, event_date = today())).
2021-09-10 21:03:24 +03:00
Azat Khuzhin
b383115389 Allow values up to INT64_MAX for nth_value/lagInFrame/leadInFrame 2021-09-10 21:02:06 +03:00
Azat Khuzhin
62a29420bd Fix signed integer overflow for nth_value() window function
CI report [1]:

    ../src/Processors/Transforms/WindowTransform.cpp:1699:54: runtime error: signed integer overflow: -9223372036854775808 - 1 cannot be represented in type 'long' Received signal -3 Received signal Unknown signal (-3)

In query:

    SELECT
        number,
        nth_value(number, 2147483648) OVER w,
        anyOrNull(number) OVER (ORDER BY -2147483648 - intDiv(number, 1024) DESC NULLS FIRST, number DESC ROWS BETWEEN 65535 FOLLOWING AND UNBOUNDED FOLLOWING),
        nth_value(number, 65537) OVER w AS firstValue,
        nth_value(number, -9223372036854775808) OVER w AS secondValue,
        nth_value(number, 1048576) OVER w AS thirdValue
    FROM numbers(1)
    WINDOW w AS (ORDER BY number DESC)
    ORDER BY number DESC

  [1]: https://clickhouse-test-reports.s3.yandex.net/28532/7623af5513e12aa8dfa1bee963caffe00185c31a/fuzzer_ubsan/report.html#fail1
2021-09-10 21:02:04 +03:00
Anton Popov
8999a83320 add comment 2021-09-10 20:22:28 +03:00
feng lv
810d180ce2 fix 2021-09-10 17:21:03 +00:00
Anton Popov
a63887413c fix reading of subcolumns from compact parts 2021-09-10 20:19:18 +03:00
Filatenkov Artur
acccb24ffd
Update getSourceFromFromASTInsertQuery.cpp 2021-09-10 19:59:17 +03:00
Filatenkov Artur
67df28bee0
Update ParserInsertQuery.cpp 2021-09-10 19:58:15 +03:00
Filatenkov Artur
e17353750c
Update src/Processors/Transforms/getSourceFromFromASTInsertQuery.cpp
Co-authored-by: Nikita Mikhaylov <mikhaylovnikitka@gmail.com>
2021-09-10 18:02:15 +03:00
Nikolai Kochetov
05f533d462 Fix style. 2021-09-10 17:54:42 +03:00
Nikolai Kochetov
3a9d88fbc9 Fix more tests. 2021-09-10 17:52:24 +03:00
Maksim Kita
a87ffdff92 Column default dictGet identifier fix 2021-09-10 17:41:09 +03:00
Anton Popov
0bb74f8eaf
Merge pull request #28762 from CurtizJ/fix-nested-1
Fix usage of nested columns with non-array columns with the same prefix [2]
2021-09-10 17:34:43 +03:00
Alexander Tokmakov
518f542c3e fix reordering of REPLACE_RANGE and DROP PART 2021-09-10 17:32:45 +03:00
Artur
a7c43c3e2d add compression key-word and some tests 2021-09-10 13:59:22 +00:00
Nikolai Kochetov
e6938127a6 Fix some resouces. 2021-09-10 15:38:30 +03:00
alesapin
d1dea0e95f
Update src/Storages/MergeTree/ReplicatedMergeTreePartCheckThread.cpp
Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
2021-09-10 15:32:24 +03:00
mergify[bot]
e3b3439535
Merge branch 'master' into fix-build-clang-13-2 2021-09-10 12:05:54 +00:00
Anton Popov
e9a4871b65 fix write buffer usage 2021-09-10 14:56:45 +03:00
Maksim Kita
43102e8427
Merge pull request #28833 from kitaisreal/executable-added-option-send-chunk-header
Executable added option send_chunk_header
2021-09-10 14:44:34 +03:00
Nikolai Kochetov
285cfb7fd5 Fix build and style. 2021-09-10 14:42:52 +03:00
kssenii
ba1534f1df Fix checks 2021-09-10 14:16:01 +03:00
kssenii
939032b0eb Slightly better 2021-09-10 13:41:41 +03:00
Anton Popov
5cff615eca Merge remote-tracking branch 'upstream/master' into HEAD 2021-09-10 13:40:48 +03:00
kssenii
f26f64993a Rewrite StorageRabbitMQ a bit 2021-09-10 13:35:24 +03:00
Anton Popov
29f327fa60 fix data race in async inserts 2021-09-10 13:24:09 +03:00
mergify[bot]
95be9c3571
Merge branch 'master' into add_sparkbar 2021-09-10 10:19:27 +00:00
Nikolai Kochetov
083b422e87 Try to fix build. 2021-09-10 13:18:04 +03:00
Alexander Tokmakov
3f8fb1e562 Merge branch 'master' into tables_topsort 2021-09-10 13:16:41 +03:00
Alexander Tokmakov
d82a794e8c fix logical race on dictionaries loading 2021-09-10 12:54:22 +03:00
Maksim Kita
0b37de02e0 Fixed tests 2021-09-10 12:47:12 +03:00
Maksim Kita
2e535cf6fd
Merge pull request #28835 from kitaisreal/shell-command-source-fix-logging
ShellCommandSource fix logging
2021-09-10 12:27:19 +03:00
Nikolai Kochetov
bc7c70f93f Try to fix build. 2021-09-10 12:03:45 +03:00
mergify[bot]
937eeb9fed
Merge branch 'master' into enable-gcc-11 2021-09-09 22:44:10 +00:00
Maksim Kita
21d33c3c2e ShellCommandSource fix logging 2021-09-10 01:28:22 +03:00
Maksim Kita
b1edf77904 Executable added option send_chunk_header 2021-09-10 01:04:52 +03:00
Maksim Kita
25a27978e6
Merge pull request #28818 from ClickHouse/remove_incorrect_code
Remove incorrect code and check what will happen
2021-09-10 00:49:36 +03:00
Maksim Kita
31766575e0
Merge pull request #28820 from azat/llvm-shared
Fix shared build with ENABLE_EMBEDDED_COMPILER
2021-09-10 00:49:18 +03:00
Maksim Kita
bdbf0c1967
Merge pull request #28821 from azat/compile-short-circuit-eval
Fix expressions compilation with short circuit evaluation
2021-09-10 00:49:00 +03:00
alexey-milovidov
2236a5df98
Merge pull request #28085 from myrrc/improvement/merge-tree-part-opt-parse
optional<> semantics for parsing MergeTreePartInfo and DetachedPartInfo
2021-09-10 00:04:03 +03:00
Sergei Semin
b9bdaf0e7b fix problem with MemoryTracker 2021-09-09 23:51:47 +03:00
Sergei Semin
f92e720d18 fix gtest_bit_io.cpp 2021-09-09 23:51:47 +03:00
Sergei Semin
212182a87c solve problem with TargetSpecific.h 2021-09-09 23:51:47 +03:00
Sergei Semin
14de0c0b0f solve problem with FunctionsCodingIP.cpp 2021-09-09 23:51:47 +03:00
Sergei Semin
68e39519b4 add necessary constructors in ZooKeeperResponse 2021-09-09 23:51:47 +03:00
Sergei Semin
c01bf59805 ignore diagnostic -Wreserved-identifier in ArrowBufferedStreams.cpp 2021-09-09 23:51:47 +03:00
Sergei Semin
74f6ac8976 remove variable total_rows_in_lonely_parts that set but not used 2021-09-09 23:51:47 +03:00
Sergei Semin
f6b613bc6b ignore diagnostic -Wreserved-identifier in CompressionCodecGorilla.cpp and CompressionCodecDoubleDelta.cpp 2021-09-09 23:51:47 +03:00
Sergei Semin
39929e52bd add ignore of -Wreserved-identifier into LineReader.cpp, ThreadFuzzer.cpp, ReadBufferFromFileDescriptor.cpp 2021-09-09 23:51:47 +03:00
Azat Khuzhin
63e14fc389 Fix expressions compilation with short circuit evaluation
Before this patch, you may get the following error:

    Column Function is not a contiguous block of memory

Since under short circuit evaluation you may get Function not the
result.
2021-09-09 22:43:11 +03:00
Azat Khuzhin
c24a3bb67d FIx formatting for getCompilableDAG() 2021-09-09 22:42:51 +03:00
Azat Khuzhin
c89bb46a20 Fix shared build with ENABLE_EMBEDDED_COMPILER 2021-09-09 22:41:26 +03:00
Maksim Kita
734c80431c
Merge pull request #28137 from amosbird/reloadsymbolcache
Reload stacktrace cache when symbol is reloaded.
2021-09-09 22:20:11 +03:00
tavplubix
e419614d32 remove incorrect code 2021-09-09 21:31:15 +03:00
Nikolai Kochetov
f569a3e3f7 Merge branch 'master' into rewrite-pushing-to-views 2021-09-09 20:30:23 +03:00
Nikolai Kochetov
50562da6df More refactoring. 2021-09-09 20:08:49 +03:00
Anton Popov
8cb02a4b27 add some comments 2021-09-09 19:10:53 +03:00
alesapin
59edf6b5f6 Better logic on part checker 2021-09-09 18:19:12 +03:00
Nikita Mikhaylov
513d40feb2 Fix build 2021-09-09 14:59:25 +00:00
Anton Popov
abebce2f18 fix kafka 2021-09-09 17:48:01 +03:00
Nikolai Kochetov
47b96add9a Refactor some code. 2021-09-09 16:59:15 +03:00
Nikolai Kochetov
5c220d62b3 Update SinkToStorage.cpp 2021-09-09 15:46:06 +03:00
kssenii
0c013ed91b Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-web-disk-2 2021-09-09 15:26:36 +03:00
kssenii
904cf74159 Merge branch 'master' of github.com:ClickHouse/ClickHouse into materialized-postgresql 2021-09-09 15:26:20 +03:00
kssenii
00be148fce Merge branch 'master' of github.com:ClickHouse/ClickHouse into named-collections 2021-09-09 15:26:09 +03:00
kssenii
c23e17d369 Fix 2021-09-09 15:25:44 +03:00
Nikolai Kochetov
13eb93a9c0
Merge pull request #28700 from amosbird/projection-fix16
Fix crash on exception with projection aggregate
2021-09-09 15:24:05 +03:00
Anton Popov
8e5b3b2f6c Merge remote-tracking branch 'upstream/master' into HEAD 2021-09-09 15:12:34 +03:00
kssenii
24010689e6 Fix possible throw from shutdown 2021-09-09 15:08:18 +03:00
Nikolai Kochetov
abfb1d20ea
Merge pull request #25734 from vdimir/join-arrayjoin-type-cast
Move join type inference to ExpressionAnalyzer from syntax stage + small refactor
2021-09-09 14:38:43 +03:00
Nikolai Kochetov
aea1871755 Fix some more tests. 2021-09-09 14:16:03 +03:00
Anton Popov
2ccdb6c22d fix clang-tidy 2021-09-09 12:40:26 +03:00
tavplubix
341a6c51d6
Merging #24866 (#28691)
* Add StorageSystemISTables.cpp/.h

* Another attempt

* Columns and Views

* Add information schema db and fix information schema 'tables' table

* fix build

* remove copy-paste, add views to system tables

* add test

* fix

* fix_tests

Co-authored-by: Damir Petrov <petrovdamir2235@gmail.com>
Co-authored-by: Damir Petrov <0442a403@verstehen.sas.yp-c.yandex.net>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-09-09 12:37:51 +03:00
kssenii
e9721804b6 Fix tests 2021-09-09 12:34:47 +03:00
robot-clickhouse
fc4f119417 Auto version update to [21.11.1.1] [54456] 2021-09-09 12:03:29 +03:00
alexey-milovidov
b781701793
Merge pull request #28532 from azat/getThreadName-cache
Cache thread name to avoid prctl(PR_GET_NAME) for query_log/text_log
2021-09-09 11:35:34 +03:00
Nikita Mikhaylov
4db5062d6b
Merge pull request #28374 from nikitamikhaylov/global-merge-executor
Introduced global executor for background MergeTree-related operations
2021-09-09 11:30:21 +03:00
Nikita Mikhaylov
ba18ba1d5c Increase stack size 2021-09-09 08:28:59 +00:00
alesapin
407c0bbb56
Merge pull request #28734 from ClickHouse/fix_race_on_mutation_pointer
Fix race on mutation_pointer update
2021-09-09 10:36:09 +03:00
kssenii
72505db3bd Fix checks 2021-09-09 10:10:34 +03:00
kssenii
f26da04cdf Fix checks 2021-09-09 09:53:58 +03:00
Amos Bird
91293c7449
Fix crash on exception with projection aggregate 2021-09-09 10:43:56 +08:00
mergify[bot]
7623af5513
Merge branch 'master' into getThreadName-cache 2021-09-08 23:28:42 +00:00
mergify[bot]
c02953b59a
Merge branch 'master' into reloadsymbolcache 2021-09-08 23:25:53 +00:00
kssenii
bed2688dad Review fixes 2021-09-09 01:25:08 +03:00
Nikita Mikhaylov
f12504b002 Fix stupid race 2021-09-08 20:30:54 +00:00
kssenii
797f858bc6 Merge branch 'master' of github.com:ClickHouse/ClickHouse into materialized-postgresql 2021-09-08 22:52:48 +03:00
kssenii
1101ee7808 Update example 2021-09-08 22:43:46 +03:00
kssenii
7345ad8e09 Add no throw 2021-09-08 22:40:26 +03:00
kssenii
41bc68e82e Tests, url table function 2021-09-08 22:28:22 +03:00
alexey-milovidov
8588e4d9bb
Merge pull request #28708 from azat/detach_not_byte_identical_parts
Implement detach_not_byte_identical_parts
2021-09-08 22:12:52 +03:00
Anton Popov
9816014f6c fix nested and scalar columns with dot, which is missed in part 2021-09-08 21:42:34 +03:00
Nikolai Kochetov
7a5846c5f7 Comment debug output. 2021-09-08 21:30:54 +03:00
Nikolai Kochetov
999a4fe831 Fix other tests. 2021-09-08 21:29:38 +03:00
kssenii
6108a4139c Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-web-disk-2 2021-09-08 20:54:07 +03:00
kssenii
ab6937ee45 Merge branch 'master' of github.com:ClickHouse/ClickHouse into named-collections 2021-09-08 20:43:37 +03:00
Nikita Mikhaylov
dcf7cb4a5c Done 2021-09-08 17:33:40 +00:00
kssenii
7141b5d041 Get rid of regexp 2021-09-08 20:22:24 +03:00
Nikita Mikhaylov
1416b1ccba
Update MergeTreeBackgroundExecutor.cpp 2021-09-08 20:21:25 +03:00
Nikita Mikhaylov
dae9a01b4b Fix build 2021-09-08 16:13:32 +00:00
Filatenkov Artur
cdb1a0504f
Merge branch 'master' into compressed_output_formats_3473 2021-09-08 18:46:48 +03:00
Anton Popov
1f41f4541f change timeouts in async insert to milliseconds 2021-09-08 18:30:04 +03:00
Anton Popov
f864c4252a support adding defaults in async inserts 2021-09-08 17:08:57 +03:00
mergify[bot]
64fb384656
Merge branch 'master' into global-merge-executor 2021-09-08 13:15:38 +00:00
Nikita Mikhaylov
3b7fa06540 Review fixes 2021-09-08 12:42:03 +00:00
alesapin
f8a6dfb0c4 Fix race on mutation_pointer update 2021-09-08 14:37:16 +03:00
mergify[bot]
9f0c50335f
Merge branch 'master' into tables_topsort 2021-09-08 10:55:11 +00:00
Anton Popov
5d33baab5f
Merge pull request #28658 from CurtizJ/fix-or-to-in
Fix optimization of disjunctions chain in distributed queries
2021-09-08 13:26:45 +03:00
Nikita Mikhaylov
ed37a22c37 Delete debug print 2021-09-08 09:35:18 +00:00
alesapin
3b9dae8718
Merge pull request #28616 from ClickHouse/qoega-try-llvm-12
Merging #20495
2021-09-08 11:43:46 +03:00
Nikolai Kochetov
0a1c3d701f
Merge pull request #28717 from DimasKovas/fix_arcadia_build_2021_09_08
Regenerate ya.make
2021-09-08 11:13:32 +03:00
Vladimir C
70fbc85768
Merge pull request #28686 from ljcui/distributed_coredump
Fix coredump in creating distributed table
2021-09-08 10:52:56 +03:00
Dmitrii Kovalkov
5e133a3cc6 Run generate-ya-make.sh 2021-09-08 07:58:22 +03:00
Nikita Mikhaylov
6062dd0021 Better 2021-09-08 00:21:21 +00:00
Nikita Mikhaylov
7c9b1a7db4
Merge pull request #28679 from ianton-ru/MDB-14168
Reduce default settings for S3 multipart upload part size
2021-09-08 01:14:18 +03:00
Maksim Kita
1966ffc040
Merge pull request #28685 from orloffv/patch-1
Add Settings.Names, Settings.Values aliases for system.processes table
2021-09-08 01:01:56 +03:00
Azat Khuzhin
fe3c53040a Cache thread name to avoid prctl(PR_GET_NAME) for query_log/text_log 2021-09-08 00:57:14 +03:00
Azat Khuzhin
db0767a194 Implement detach_not_byte_identical_parts
Maybe useful for further analysis of non byte-identical parts.
2021-09-07 23:29:57 +03:00
Vitaly Baranov
59148fa453
Merge pull request #22415 from Enmk/governance/session_log
Governance/session log
2021-09-07 22:09:32 +03:00
mergify[bot]
771ae92c8e
Merge branch 'master' into global-merge-executor 2021-09-07 14:52:33 +00:00
Nikita Mikhaylov
231f64cf37 Fix unit test 2021-09-07 13:51:30 +00:00
Nikita Mikhaylov
9b38248e64 Remove scheduler thread 2021-09-07 13:13:23 +00:00
alesapin
d9ca1e29c3 Increase stack size for coroutines 2021-09-07 15:56:32 +03:00
Nikita Mikhaylov
8a0765c60d Review fixes (partially) 2021-09-07 12:45:39 +00:00
Nikita Mikhaylov
ff59105f28
Merge pull request #28663 from bharatnc/ncb/fix-rect-args
fix getNumberOfArguments() for s2Rect functions
2021-09-07 14:30:45 +03:00
kssenii
3deb9a0ecb s3, url, http headers 2021-09-07 14:17:25 +03:00
Vitaly
69604eab3f
Add Settings.Names, Settings.Values aliases for system.processes table 2021-09-07 14:05:55 +03:00
ZhiYong Wang
978dd19fa2 Fix coredump in creating distributed table 2021-09-07 19:05:26 +08:00
chenjian
7fe506dc5b add feature/optimize-bitmapAnd 2021-09-07 10:46:13 +00:00
mergify[bot]
e9fbdec13a
Merge branch 'master' into improvement/merge-tree-part-opt-parse 2021-09-07 09:52:24 +00:00
Anton Ivashkin
5ff99314b1 Reduce default settings for S3 multipart upload part size 2021-09-07 12:51:00 +03:00
Maksim Kita
7a4a0b0ede
Merge pull request #28474 from azat/mysql-connection_no_block
Introduce connection_wait_timeout for MySQL engine.
2021-09-07 12:28:02 +03:00
Dmitry Novik
99dc685146
Merge pull request #28315 from amosbird/indexfix
Fix NOT-IN index optimization when not all key columns are used.
2021-09-07 11:58:30 +03:00
Vitaly Baranov
70c6623036
Merge branch 'master' into governance/session_log 2021-09-07 10:12:54 +03:00
Kseniia Sumarokova
8e8b15edd7
Merge pull request #28665 from kssenii/revert
Revert  #28082
2021-09-07 09:43:02 +03:00
Vitaly Baranov
bcc31f1f3e Remove unnecessary changes. 2021-09-07 01:37:28 +03:00
Nikita Mikhaylov
cfe2207be3 Better 2021-09-06 22:07:41 +00:00
bharatnc
503b7a59f0 fix getNumberOfArguments() for s2Rect functions
This fixes the value returned by the getNumberOfArguments() by the
s2RectAdd and the s2RectContains functions. Only 3 arguments are
used by these functions and not 4:

- low s2Point of rectangle
- high s2Point of rectangle
- given s2Point

The given s2Point is used to groow the size of the bounding rectangle to
include the given S2Point in case of the s2RectAdd function. In case
of s2RectContains, the function determines if the bounded rectangle
contains the given point.

PS: I wonder if it's more apt to call rectAdd as rectGrow since
it's used to grow the size of a given rectangle.
2021-09-06 14:19:18 -07:00
Nikolai Kochetov
f34cb097d8 Fix some tests. 2021-09-06 23:13:06 +03:00
Kseniia Sumarokova
9e496910a0
Merge pull request #28614 from kssenii/materialized-postgresql-2
MaterializedPostgreSQL: add solution to survive postgres primary failover
2021-09-06 22:31:15 +03:00
kssenii
7bea8200d8 Revert "Merge pull request #28082 from zhongyuankai/add-system-of-table_views"
This reverts commit e5bcfba89e, reversing
changes made to d77f243651.
2021-09-06 19:20:33 +00:00
Nikita Mikhaylov
74c0b61e53 Better 2021-09-06 18:33:31 +00:00
zhangxiao871
0b6ab61633 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into yandex-master 2021-09-07 01:22:02 +08:00
zhangxiao871
fe3e786cf2 add bitShiftLeft for FixedString and String integer. 2021-09-07 01:20:12 +08:00
Nikita Mikhaylov
324ab97f50 Fix gcc build 2021-09-06 16:44:46 +00:00
Nikita Mikhaylov
29a18d8d10 Try to fix unbundled 2021-09-06 15:58:08 +00:00
Nikita Mikhaylov
7c39f84a5e Merge upstream/master into global-merge-executor (using imerge) 2021-09-06 15:37:18 +00:00
Mike Kot
8e9aacadd1 Initial: replacing hardcoded toString for enums with magic_enum 2021-09-06 16:24:03 +02:00
Nikita Mikhaylov
17d65b3d7b Allow allocations 2021-09-06 14:04:37 +00:00
Anton Popov
47f46e388d fix optimization of disjunctions chain 2021-09-06 16:54:26 +03:00
alesapin
2a851546c7
Merge pull request #28648 from ClickHouse/add_missed_level_to_text_log
Add missed log level into TextLog
2021-09-06 16:16:25 +03:00
Nikita Mikhaylov
ea0fbf81af Renaming 2021-09-06 12:01:16 +00:00
Nikita Mikhaylov
0249015515 added priority queue 2021-09-06 11:37:51 +00:00
alesapin
9db10a7164 Fix typo: 2021-09-06 14:34:17 +03:00
alesapin
fcfe77cb57 Fix allocation in buffer 2021-09-06 13:35:37 +03:00
alesapin
209b748fca Add missed level 2021-09-06 13:11:19 +03:00
Nikolai Kochetov
a8cad572df
Merge pull request #28561 from FArthur-cmd/remove_recursion_in_zstd
remove recursion in ZstdInflatingReadBuffer
2021-09-06 13:03:52 +03:00
Nikolai Kochetov
2178ed21df
Merge pull request #28560 from amosbird/projection-fix15
Fix wrong header of minmax_count projection
2021-09-06 13:00:44 +03:00
mergify[bot]
8eba5f29a1
Merge branch 'master' into improvement/merge-tree-part-opt-parse 2021-09-06 09:53:46 +00:00
tavplubix
4780008805
Merge pull request #28533 from azat/MaterializeMySQL-drop-fix
Fix UUID overlap in DROP TABLE for internal DDL from MaterializeMySQL
2021-09-06 12:34:13 +03:00
alesapin
5c75b93fe8 Revert one warning 2021-09-06 12:17:31 +03:00
alesapin
d1e91a7860 Revert "Revert "Fix tidy""
This reverts commit 2e5e017d6d.
2021-09-06 12:16:52 +03:00
Dmitrii Kovalkov
181bf0dbd6 Fix arcadia build 2021-09-06 11:11:45 +03:00
alesapin
2e5e017d6d Revert "Fix tidy"
This reverts commit 73ef1233ef.
2021-09-06 10:52:20 +03:00
alesapin
7b2d4a3ace
Merge pull request #28559 from ClickHouse/add_test_logs_level
Test log level for CI
2021-09-06 10:49:59 +03:00
alesapin
d6244bcd7b Merge branch 'master' into qoega-try-llvm-12 2021-09-06 10:25:26 +03:00
alesapin
73ef1233ef Fix tidy
Fix tidy one more time
2021-09-06 10:22:21 +03:00
Amos Bird
8fac97692a
Fix nullable primary key with constant conversion 2021-09-06 15:11:37 +08:00
kssenii
7b8101f289 Minor change 2021-09-06 09:57:05 +03:00
Amos Bird
18a7adf0fa
Fix NOT-IN index optimization when not all keys are used. 2021-09-06 12:21:03 +08:00
Azat Khuzhin
e7ed98fa58 Do not allow ThreadFromGlobalPool::join() from the spawned/occupated thread
v2: wrap with shared_ptr
    https://clickhouse-test-reports.s3.yandex.net/28431/f7b3a3e952038923b1347b3d461061326d0ffc27/functional_stateless_tests_(address).html#fail1
2021-09-05 21:59:49 +03:00
zhangxiao871
8c30f09a00 Fix PVS check. 2021-09-05 22:08:24 +08:00
feng lv
a22a0d6c68 fix style 2021-09-05 13:47:20 +00:00
feng lv
580b047d96 fix 2021-09-05 13:45:08 +00:00
feng lv
b97faf8b25 fix style 2021-09-05 12:12:04 +00:00
feng lv
dfea640c67 fix 2021-09-05 11:41:13 +00:00
Maksim Kita
f8e491d648
Merge pull request #28629 from ucasfl/fix
fix minor typo
2021-09-05 12:38:14 +03:00
Maksim Kita
337875199a
Merge pull request #28615 from kitaisreal/function-dict-get-small-fix
Function dictGet small fix
2021-09-05 12:37:03 +03:00
feng lv
3c166df8ea fix minor typo 2021-09-05 07:25:52 +00:00
feng lv
09bc3d723a refactor some code 2021-09-05 06:32:32 +00:00
zhangxiao871
e73719ab80 Fix FixedString type ConstConst. 2021-09-05 13:21:06 +08:00
kssenii
76e49334fa Minor fixes 2021-09-05 01:59:44 +03:00
kssenii
d0113743c9 Merge branch 'master' of github.com:ClickHouse/ClickHouse into materialized-postgresql 2021-09-05 01:07:31 +03:00