Commit Graph

68540 Commits

Author SHA1 Message Date
Sema Checherinda
673276ad45 fix view_level 2024-12-11 15:42:19 +01:00
János Benjamin Antal
52190355aa Do not modify original tree when flattening logical expressions 2024-12-11 14:22:13 +00:00
János Benjamin Antal
272e88d479 Use reference instead of non-nullable pointer 2024-12-11 14:21:43 +00:00
János Benjamin Antal
0fc5fe8468 Address minor review comments 2024-12-11 14:21:00 +00:00
Nikita Taranov
2bc96dc2da
Merge pull request #72993 from ClickHouse/fix_parallel_hash_with_additional_filter
Fix `parallel_hash` join with additional filters in `ON` clause
2024-12-11 14:20:14 +00:00
Nikita Taranov
fe55995e04 fix 2024-12-11 15:01:47 +01:00
Nikita Mikhaylov
34ee0f2364
Merge pull request #71870 from cwurm/patch-6
Format Settings: Better date_time_overflow_behavior
2024-12-11 13:50:24 +00:00
vdimir
bdefff4e3e
Lower PREWHERE log level 2024-12-11 13:27:25 +00:00
Nikita Taranov
f4d4ef9dbf impl 2024-12-11 14:24:55 +01:00
Raúl Marín
8e4bd548e4
Merge pull request #73081 from azat/mm-fix-accounting
Fix possible overestimate memory tracking
2024-12-11 13:11:11 +00:00
Raúl Marín
fb7cd9fa8b
Update src/Common/ThreadStatus.cpp 2024-12-11 14:09:56 +01:00
divanik
6a526a9d6f Resolve conflicts 2024-12-11 12:39:01 +00:00
Igor Nikonov
48a61c986b Merge remote-tracking branch 'origin/master' into pr-3-way-joins 2024-12-11 12:29:40 +00:00
Raúl Marín
ca2813bacf
Merge pull request #72969 from Algunenano/shared_mutex_other_os
Use absl::Mutex instead of std::shared_mutex on non-Linux OSs
2024-12-11 12:12:05 +00:00
kssenii
4737618960 Fix 2024-12-11 12:20:56 +01:00
Pavel Kruglov
06b1ef2c2d
Merge pull request #72989 from Avogar/dynamic-in-to-type-functions
Support Dynamic in functions toFloat64/touInt32/etc
2024-12-11 11:07:34 +00:00
Pavel Kruglov
33b8948a5c
Merge pull request #73043 from Avogar/fix-json-parsing-format-settings
Use default format settings during JSON parsing to avoid broken deserialization
2024-12-11 11:07:11 +00:00
Pavel Kruglov
66eecb112f
Merge pull request #73082 from Avogar/fix-tuple-duplicate-json-key
Check for duplicate JSON keys during Tuple parsing
2024-12-11 10:57:42 +00:00
Nikita Mikhaylov
88f7b53d8c
Merge pull request #72426 from ClickHouse/move-utils-to-programs
Moved utils to programs
2024-12-11 00:18:43 +00:00
Igor Nikonov
020e7822a4 Merge remote-tracking branch 'origin/master' into pr-3-way-joins 2024-12-10 22:03:23 +00:00
Alexander Gololobov
bb1604d48c
Merge pull request #73049 from ClickHouse/preallocate_log_queue_buffer
Preallocate log queue buffer after flush to reduce number or (re)allocations when pushing new entires
2024-12-10 21:11:07 +00:00
Sema Checherinda
352e47ae64
Merge pull request #73080 from ClickHouse/chesema-rm-comments-2
remove commented code
2024-12-10 21:05:04 +00:00
Vitaly Baranov
e7df52d8a0
Merge pull request #72682 from vitlibar/add-retries-to-creating-replicated-table
Add retries to creating a replicated table
2024-12-10 21:04:36 +00:00
Igor Nikonov
457bb20d28 Better comment 2024-12-10 19:35:48 +00:00
avogar
1024bb9df5 Add comments 2024-12-10 19:19:09 +00:00
avogar
227346e7ae Rename method 2024-12-10 19:16:30 +00:00
avogar
7dc0811ffd Improve formatting of identifiers with JSON subcolumns 2024-12-10 19:15:57 +00:00
kssenii
a5c5088f0c Merge remote-tracking branch 'origin/divanik/fix_bug_iceberg_json_equality_check' into rest-catalog 2024-12-10 19:53:56 +01:00
Azat Khuzhin
9072d1bd42 Fix possible overestimate memory tracking
Before this patch the untracked_memory was dumped before reseting the
current_thread which could lead to leaking some of untracked_memory in
`ThreadStatus::detachFromGroup` [1].

In particular I found that the local_data (which is 136 bytes) can be
"leaked" that way.

  [1]: 8999fdd95e/src/Interpreters/ThreadStatusExt.cpp (L292-L306)

This pops up on one of clusters where I noticed that the difference
between MemoryTracking and MemoryResident keeps growing over the time.
the difference grows ~200KiB per second - 16.5GiB per day.

That cluster has tons MVs triggered from Buffer/Distributed (i.e. now
query context), and this is indeed is the reason for leaking local_data,
since in this case there is no thread group in the query, and it is
created explicitly in `InterpreterInsertQuery::buildChain` [1].

  [1]: 20ccb638ba/src/Interpreters/InterpreterInsertQuery.cpp (L321)

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-12-10 19:50:01 +01:00
kssenii
c2cf17c2dd Merge remote-tracking branch 'origin/master' into rest-catalog 2024-12-10 19:35:55 +01:00
kssenii
83ea4857ea Remove redundant 2024-12-10 19:26:10 +01:00
Kseniia Sumarokova
0235eed489
Merge pull request #73001 from ClickHouse/divanik/fix_bug_iceberg_json_equality_check
Make less strict assert when checking iceberg schema consistency
2024-12-10 18:24:29 +00:00
Igor Nikonov
64de1fb68f Mark the setting as obsolete 2024-12-10 18:21:23 +00:00
avogar
1d6c3629c6 Check for duplicate JSON keys during Tuple parsing 2024-12-10 16:52:07 +00:00
divanik
26004ee5ef Merge branch 'master' of github.com:ClickHouse/ClickHouse into divanik/iceberg_metadata_big_refactoring 2024-12-10 16:50:59 +00:00
mkalfon
12d5f081d2 Reducing the log level of appeared replica part message 2024-12-10 17:48:06 +01:00
Sema Checherinda
1ae7a683d7 remove commented code 2024-12-10 17:30:56 +01:00
Alexander Gololobov
61d5c75343 Preallocate log queue buffer after flush 2024-12-10 16:58:09 +01:00
Sema Checherinda
4932f599ea fix style 2024-12-10 16:43:56 +01:00
Sema Checherinda
ea17c5d133 fix headers 2024-12-10 16:26:38 +01:00
Raúl Marín
173c409d3e Fix crash in transactions with unsupported storage 2024-12-10 16:24:53 +01:00
Sema Checherinda
0f57753013 fix bahaviour with materialized_views_ignore_errors 2024-12-10 16:24:46 +01:00
Nikita Taranov
06901e1c6a better 2024-12-10 16:22:04 +01:00
Dmitry Novik
b44c891ea9
Merge branch 'master' into optimize-join-performance-by-extracting-common-exprs 2024-12-10 15:49:16 +01:00
Dmitry Novik
9f21ecaee5
Update src/Analyzer/Passes/LogicalExpressionOptimizerPass.cpp 2024-12-10 15:47:37 +01:00
Dmitry Novik
a0c591fb14
Update src/Analyzer/Passes/LogicalExpressionOptimizerPass.cpp 2024-12-10 15:47:13 +01:00
Raúl Marín
b8196de664 Remove no longer needed guard 2024-12-10 15:43:22 +01:00
Nikita Taranov
6d5e97d9d9 fix 2024-12-10 15:30:05 +01:00
avogar
b718b2ea88 Use default format settings during JSON parsing to avoid broken deserialization 2024-12-10 14:27:58 +00:00
Raúl Marín
8999fdd95e
Merge pull request #73010 from ClickHouse/revert-70598-more_jits
Revert "Enable JIT compilation for more expressions"
2024-12-10 14:24:49 +00:00
avogar
a755cbc987 Apply suggestion 2024-12-10 13:50:06 +00:00
Igor Nikonov
1dc6232132 Fix style check 2024-12-10 13:35:07 +00:00
Pavel Kruglov
8f0baa593b
Merge pull request #72108 from Avogar/format-inference-load
Add inferred format name to create query in File/S3/URL/HDFS/Azure engines
2024-12-10 13:14:58 +00:00
Pavel Kruglov
bba8f7e807
Merge pull request #72285 from Avogar/read-column-once-compact-subcolumns
Bring back optimization for reading subcolumns of single column in Compact parts
2024-12-10 13:08:50 +00:00
Igor Nikonov
fef67a5576 Remove parallel_replicas_single_task_marks_count_multiplier 2024-12-10 13:08:16 +00:00
avogar
427446ea96 Fix typo 2024-12-10 13:06:09 +00:00
Nikita Taranov
5ff265eea0
Merge pull request #72895 from ClickHouse/more_insistent_compress_in_memory_eng_2
Resubmit More insistent compression in StorageMemory
2024-12-10 12:55:12 +00:00
divanik
088152febd Style check 2024-12-10 12:33:36 +00:00
Igor Nikonov
af13166972 Clean up 2024-12-10 12:06:26 +00:00
Raúl Marín
efdcb59c84 Fix fast build 2024-12-10 12:54:23 +01:00
Igor Nikonov
270d8a3eaf Merge remote-tracking branch 'origin/master' into pr-3-way-joins 2024-12-10 11:25:25 +00:00
Raúl Marín
fb02bec3dc
Revert "Enable JIT compilation for more expressions" 2024-12-10 12:22:51 +01:00
divanik
05ca6d83a1 Style fix 2024-12-10 11:16:52 +00:00
divanik
72cc064547 Fix bug 2024-12-10 11:07:48 +00:00
Kseniia Sumarokova
85f86196c4
Merge pull request #72990 from jsc0218/BetterPGArrayEmptyHint
Better PG Empty Array Prompt
2024-12-10 10:51:52 +00:00
divanik
57d446ebfd Fix bug 2024-12-10 10:44:22 +00:00
divanik
05d8584966 Fix chassert 2024-12-10 10:34:36 +00:00
divanik
aa043940c7 Resolve issues 2024-12-10 10:07:14 +00:00
Nikita Taranov
201f021db1 allow with parallel_hash 2024-12-09 23:05:06 +01:00
Robert Schulze
c56ece0780
Revert "Add total_bytes_with_inactive to system.tables" 2024-12-09 22:55:34 +01:00
Nikita Taranov
05cfa49c06 stash 2024-12-09 22:42:58 +01:00
Nikita Mikhaylov
dc7bc42223 Moved some of utils to programs 2024-12-09 21:35:31 +00:00
avogar
5158fba5bb Support equal comparison for JSON column 2024-12-09 20:06:37 +00:00
jsc0218
04d59c7a7c fix 2024-12-09 19:44:59 +00:00
Igor Nikonov
bf66a07b1e Merge remote-tracking branch 'origin/master' into pr-3-way-joins 2024-12-09 19:31:04 +00:00
Igor Nikonov
d8f1f6f266 Disable FULL JOINs in n-way joins for parallel replicas 2024-12-09 19:30:18 +00:00
kssenii
43e6678212 Review fixes, fix test 2024-12-09 19:18:10 +01:00
avogar
d58dba38f7 Remove old code 2024-12-09 18:08:06 +00:00
avogar
18e8af493c Support Dynamic in functions toFloat64/touInt32/etc 2024-12-09 18:07:20 +00:00
kssenii
5e51114a6a Fix bad conflict resolution 2024-12-09 18:34:42 +01:00
Kseniia Sumarokova
d9fad57bde
Merge pull request #72947 from ClickHouse/kssenii-patch-13
Fix potential crash
2024-12-09 16:40:07 +00:00
Kseniia Sumarokova
63603cc6d7
Merge pull request #72810 from ClickHouse/disable-metadata-deletion-in-s3-queue
Better deletion of metadata in s3queue
2024-12-09 16:35:48 +00:00
divanik
27fcf30eb0 Fix clang tidy issue 2024-12-09 16:31:11 +00:00
Raúl Marín
831487fb6b Build 2024-12-09 16:51:34 +01:00
Raúl Marín
e8f9f981c2 Use absl::Mutex instead of std::shared_mutex on non-Linux OSs 2024-12-09 16:32:16 +01:00
Vitaly Baranov
8b0d29241e
Merge pull request #72834 from ClickHouse/fix-segfault-in-cascade-write-buffer
Fix segfault in CascadeWriteBuffer::getResultBuffers()
2024-12-09 15:30:06 +00:00
avogar
6da4d19fe0 Fix tests 2024-12-09 15:26:40 +00:00
Vitaly Baranov
f485723959
Merge pull request #72778 from vitlibar/use-http-header-limits-to-parse-s3-responses
Add S3 request settings http_max_fields, http_max_field_name_size, http_max_field_value_size for parsing S3 API responses
2024-12-09 15:24:25 +00:00
Igor Nikonov
0d6f9b457b Merge remote-tracking branch 'origin/master' into pr-3-way-joins 2024-12-09 14:20:40 +00:00
Nikita Taranov
646d44e30d fix comment 2024-12-09 15:14:58 +01:00
divanik
5ff54b0308 Fix ifdefs issue 2024-12-09 13:38:06 +00:00
divanik
d4bab00fcc Add data files cache 2024-12-09 13:07:15 +00:00
kssenii
bed4eaaafa Fix style check 2024-12-09 14:04:48 +01:00
divanik
0a1065ffec Merge branch 'master' of github.com:ClickHouse/ClickHouse into divanik/iceberg_metadata_big_refactoring 2024-12-09 12:38:08 +00:00
divanik
bfb1197991 Fix style check 2024-12-09 12:37:00 +00:00
divanik
adaf1b3098 Correct style 2024-12-09 12:23:21 +00:00
Kseniia Sumarokova
1475ccca26
Update MergeTreeData.cpp 2024-12-09 13:13:56 +01:00
divanik
01ddf27e0f Fix style check 2024-12-09 12:13:46 +00:00
divanik
bc93760c5a Deal with includes 2024-12-09 12:04:31 +00:00
kssenii
9256d370c8 Resolve conflicts 2024-12-09 12:48:12 +01:00