thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-21 09:10:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
58,548 Commits 8,936 Branches 1,766 Tags 2 GiB
af90658369
Commit Graph

58548 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
alexey-milovidov
af90658369
Merge pull request #21432 from azat/flaky-distributed-tests 
Fix flaky tests with distributed queries
 2021-03-06 02:04:07 +03:00
alexey-milovidov
5a100e246c
Merge pull request #21455 from den-crane/tests/issue_21413 
test for #21413
 2021-03-06 01:56:15 +03:00
alexey-milovidov
35b304bdb1
Merge pull request #21393 from ClickHouse/dict-name-dot 
Add a test for #15469
 2021-03-06 01:47:17 +03:00
alexey-milovidov
39bfcf220d
Merge pull request #21452 from ClickHouse/filimonov-patch-1 
avoid race in librdkafka
 2021-03-06 00:57:30 +03:00
tavplubix
9f04683923
Merge pull request #21461 from ClickHouse/just_another_fix_for_ddl_worker 
Just another fix for DDLWorker
 2021-03-05 19:44:59 +03:00
gyuton
627cde7c64
DOCSUP-6387: Updated the toIPv6 and IPv6StringToNum functions (#20577) 
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
Co-authored-by: George <gyuton@yandex-team.ru>
 2021-03-05 17:50:43 +03:00
Kruglov Pavel
5597da968c
Merge pull request #21441 from DIAOZHAFENG/patch-1 
Update in.md
 2021-03-05 16:55:35 +03:00
tavplubix
35a770a7f6
add comment 2021-03-05 15:50:10 +03:00
Nikolai Kochetov
5f6c8eb1d0
Merge pull request #21447 from ClickHouse/try-fix-perftests 
Try fix perftests.
 2021-03-05 12:48:28 +03:00
alesapin
9a9d5a74ba
Merge pull request #21439 from ClickHouse/fix_nukeeper_default_path 
Use path as default prefix for coordination logs
 2021-03-05 10:11:44 +03:00
alexey-milovidov
777731562d
Merge pull request #21458 from amosbird/trivialfix 
Tiny fix
 2021-03-05 05:21:52 +03:00
Alexander Kuzmenkov
81dc94bca7
Merge pull request #19836 from sevirov/sevirov-DOCSUP-4707-edit_translate_russian_date_time 
DOCSUP-4707: Edit and translate to Russian
 2021-03-05 05:11:26 +03:00
Alexey Milovidov
dce79d928f Merge branch 'dict-name-dot' of github.com:yandex/ClickHouse into dict-name-dot 2021-03-05 05:07:36 +03:00
Alexey Milovidov
c3110a611e Skip Arcadia 2021-03-05 05:06:49 +03:00
Alexey Milovidov
0f52c62ab0 Merge branch 'master' into dict-name-dot 2021-03-05 05:06:25 +03:00
Alexander Tokmakov
614e0d9ba0 just another fix for ddl worker 2021-03-05 04:17:51 +03:00
alexey-milovidov
643b065849
Update datetime.md 2021-03-05 02:55:12 +03:00
alexey-milovidov
1985364c8f
Update datetime.md 2021-03-05 02:35:54 +03:00
Nikita Mikhaylov
37d4c69d3a
Merge pull request #21433 from azat/parsing-exception-message-fix 
Fix ParsingException::displayText()
 2021-03-05 01:59:06 +03:00
Denis Zhuravlev
c0eefb644e test for #21413 2021-03-04 16:58:12 -04:00
Azat Khuzhin
205ebc7cff Tune idle_connection_timeout to avoid reconnects 
There may be 1 hour between two different distributed queries in tests
(see [1] and [2]), if this will happen then the connection may be closed
already due to idle_connection_timeout.

  [1]: https://clickhouse-test-reports.s3.yandex.net/21432/572d5862961ffda88125679e3a5ea684c316b223/functional_stateless_tests_(debug).html#fail1
  [2]: https://clickhouse-test-reports.s3.yandex.net/21432/572d5862961ffda88125679e3a5ea684c316b223/functional_stateless_tests_(antlr_debug).html#fail1

Let's tune it to avoid such issues and override other settings in tests.

Another option is to execute SYSTEM RELOAD CONFIG before each test...
 2021-03-04 22:48:09 +03:00
Azat Khuzhin
7794ac66d4 Fix flaky tests with distributed queries 
There was few attempts to fix this [1] and [2], but it still pops up
sometimes, for example here [3].

  [1]: 009f57fc2f / #11211
  [2]: cdb6bed8b9 / #14198
  [3]: https://clickhouse-test-reports.s3.yandex.net/21318/38be9ff43ac4c46ce6e803fc125d910bde1d4c71/functional_stateless_tests_(release,_databasereplicated).html#fail1

Let's use more generic approach, and do not hide any errors (and see
does increasing timeout will be enough).
 2021-03-04 22:48:04 +03:00
tavplubix
9244bc43ee
Merge pull request #21021 from zhang2014/fix/materialize_mysql_integration_test 
Try fix MaterializeMySQL integration test
 2021-03-04 22:22:20 +03:00
Dmitriy
fbc4791db7 Add the links 
Добавил ссылки на продукты, убрал кавычки со стандарта.
 2021-03-04 20:13:22 +03:00
Amos Bird
de94f33b05
Tiny fix 2021-03-05 00:21:52 +08:00
Denis Zhuravlev
102a0b2c5d test for #21413 2021-03-04 10:46:01 -04:00
Kseniia Sumarokova
08cb02c872
Merge pull request #21416 from excitoon-favorites/caseinsensitivecompression 
Case-insensitive compression methods for table functions
 2021-03-04 17:37:28 +03:00
filimonov
bd8c3eb117
avoid race in librdkafka 
see https://github.com/edenhill/librdkafka/issues/3279
 2021-03-04 15:01:10 +01:00
Maksim Kita
1eb1f3028c FunctionsExternalDictionaries safe case to ColumnTuple 2021-03-04 16:55:05 +03:00
alesapin
39de525c74 Simplify config 2021-03-04 16:49:22 +03:00
Ivan
218542589a
Merge pull request #19673 from azat/distributed-bytes_to_throw_insert 
Add ability to throttle INSERT into Distributed
 2021-03-04 13:28:23 +03:00
Nikolai Kochetov
a195e783d2 Try fix perftests. 2021-03-04 13:25:49 +03:00
DIAOZHAFENG
35aaac84b8
Update in.md 2021-03-04 16:58:09 +08:00
DIAOZHAFENG
587014217c
Update in.md 
update untranslated line
 2021-03-04 16:47:59 +08:00
Nikolai Kochetov
b985e33294
Merge pull request #21434 from azat/dist-query-SIGSEGV-on-exception-fix 
Fix SIGSEGV for distributed queries on failures
 2021-03-04 11:32:17 +03:00
alesapin
d28463d70b Use path as default prefix for coordination logs 2021-03-04 11:29:24 +03:00
olgarev
134eaa55e5
DOCSUP-6258: FAQ edit and translate (#21109) 
Co-authored-by: ana-uvarova <ana-uvarova@yandex-team.ru>
Co-authored-by: AnaUvarova <64017504+AnaUvarova@users.noreply.github.com>
Co-authored-by: vdimir <vdimir@yandex-team.ru>
Co-authored-by: Olga Revyakina <revolg@yandex-team.ru>
Co-authored-by: Anna <42538400+adevyatova@users.noreply.github.com>
 2021-03-04 10:50:14 +03:00
Azat Khuzhin
e858dae187 Fix SIGSEGV for distributed queries on failures 
Since after pull(), cancel() will be called, and this will lead to
SIGSEGV, since there is no exception, but has_exception was not reseted
in pull()
 2021-03-04 00:42:49 +03:00
Azat Khuzhin
e7948819f9 Fix ParsingException::displayText() 
Before it was silently try-catched for messages with additional {}, and
it is very easy to trigger, i.e.:

    SELECT toDateTime(format('{}-{}-01 00:00:00', '2021', '1'))

Will print:

    Code: 41. DB::Exception: Received from localhost:9000. DB::Exception: Cannot parse datetime 2021-1-01 00:00:00{}: Cannot parse DateTime from String: while executing 'FUNCTION toDateTime(format('{}-{}-01 00:00:00', '2021', '1') :: 3) -> toDateTime(format('{}-{}-01 00:00:00', '2021', '1')) DateTime : 2'.
 2021-03-03 23:44:51 +03:00
Azat Khuzhin
79ed35876e DirectoryMonitor: Remove const qualifier and lots of mutable qualifiers 2021-03-03 23:30:24 +03:00
Azat Khuzhin
45ee650e26 Distributed: check for bytes_to_throw/delay_insert only before INSERT 
Before it was checked for each block.
 2021-03-03 23:30:24 +03:00
Azat Khuzhin
a57c646467 Fix 01293_system_distribution_queue flakiness 2021-03-03 23:30:24 +03:00
Azat Khuzhin
9a4f469a38 Fix 00753_distributed_system_columns_and_system_tables flakiness 2021-03-03 23:30:24 +03:00
Azat Khuzhin
6965ac26c3 Distributed: Add ability to delay/throttle INSERT until pending data will be reduced 
Add two new settings for the Distributed engine:
- bytes_to_delay_insert
- max_delay_to_insert

If at the beginning of INSERT there will be too much pending data, more
then bytes_to_delay_insert, then the INSERT will wait until it will be
shrinked, and not more then max_delay_to_insert seconds.

If after this there will be still too much pending, it will throw an
exception.

Also new profile events were added (by analogy to the MergeTree):
- DistributedDelayedInserts (although you can use system.errors instead
  of this, but still)
- DistributedRejectedInserts
- DistributedDelayedInsertsMilliseconds
 2021-03-03 23:30:23 +03:00
Azat Khuzhin
15f7459cae Distributed/DirectoryMonitor: protect metric_pending_files with metrics_lock 
Since there is local value, that is not atomic, anyway we already have
lock for metrics, so it is fine.
 2021-03-03 23:30:03 +03:00
Azat Khuzhin
cabe4ca1bb tests: split 00753_system_columns_and_system_tables (to disable Distributed part for arcadia) 2021-03-03 23:30:03 +03:00
Azat Khuzhin
3102835d56 tests: Use total_bytes>0 for Distributed engine in 00753_system_columns_and_system_tables 2021-03-03 23:30:03 +03:00
Azat Khuzhin
70049db143 CurrentMetrics/Increment: Introduce add() 2021-03-03 23:30:03 +03:00
Azat Khuzhin
017c054a35 Distributed/DirectoryMonitor: Use std::lock_guard over std::unique_lock 
It is more natural, since we do not need lazy locking.
 2021-03-03 23:30:03 +03:00
Azat Khuzhin
fcf49a4914 Distributed: Calculate counters for async INSERT at INSERT time 
Previous patch fixes the inaccuracy, but it's done using iterating over
directory on each request (to system.distribution_queue or to check
bytes_to_throw_insert), and like previous patch alredy stated, it may
have pretty huge overhead (especially when you have lots of distributed
files pending).

This patch remove that recalculation (but it will still be done, and
if there is different, there will be a log message), and replace it with
proper account at INSERT time (and after file has been sent, or marked
as broken).
 2021-03-03 23:30:03 +03:00