Commit Graph

13623 Commits

Author SHA1 Message Date
Alexander Tokmakov
970ad94851 Merge branch 'master' into fix_intersecting_parts 2021-05-14 13:17:02 +03:00
alesapin
f8ddf511c5 Merge branch 'master' into standalone_keeper 2021-05-14 13:05:55 +03:00
Nikolai Kochetov
782f02b1dc Review fixes. 2021-05-14 13:01:27 +03:00
Nikolai Kochetov
a1e9202b93 Review fixes. 2021-05-14 12:30:32 +03:00
Maksim Kita
7eee500ef9
Merge pull request #24068 from azat/preserve-dict-for-shutdown
Preserve dictionaries until storage shutdown
2021-05-14 11:48:40 +03:00
alesapin
d4c6a5a05e Better logging 2021-05-14 11:38:53 +03:00
alesapin
67e4393769 If table was not active set readonly mode 2021-05-14 11:32:41 +03:00
Ilya Yatsishin
e345b8b868
Merge pull request #24077 from abel-cheng/feature/splitByRegexp
add function splitByRegexp
2021-05-14 10:43:08 +03:00
Ilya Yatsishin
19fb0d2033
Merge pull request #24091 from Enmk/now64_timezone_fix
Fixed now64(): added second optional argument for timezone.
2021-05-14 10:36:40 +03:00
Maksim Kita
b0bad25dd3
Merge pull request #24111 from kitaisreal/hash-table-performance
Added hash table benchmarks
2021-05-14 10:29:12 +03:00
kssenii
55c573f920 Fix 2021-05-14 07:11:32 +00:00
hexiaoting
396f60f292 Fix bug for explain pipeline 2021-05-14 14:43:51 +08:00
Pavel Kruglov
46a7cc5f1d Remove include_indices 2021-05-14 00:52:29 +03:00
Maksim Kita
1f9c9eda45 Added hash table benchmarks 2021-05-13 23:40:47 +03:00
Azat Khuzhin
aeb2c5d88a Preserve dictionaries until storage shutdown
v2: Context::loadEmbeddedDictionaries()
v3: Context::loadDictionaries()
2021-05-13 22:03:00 +03:00
Pavel Kruglov
bbe470a670 Remove fillArrowArray from .h file 2021-05-13 21:15:55 +03:00
Nikolai Kochetov
bc4ccdece6 Fix tests. 2021-05-13 21:07:47 +03:00
Vasily Nemkov
1330ef7567 Fixed converting const DateTime to DateTime64 in WHERE 2021-05-13 20:16:00 +03:00
Vasily Nemkov
22e304f88c
Fixed clang-tidy style check 2021-05-13 20:15:24 +03:00
Pavel Kruglov
25ceb1df65 Final fixes 2021-05-13 20:00:13 +03:00
alexey-milovidov
d340e33e2b
Merge pull request #23844 from excitoon-favorites/s3morecorrectclient
Better handling of HTTP errors in `PocoHTTPClient`
2021-05-13 19:21:09 +03:00
tavplubix
780b7cc8e1
Merge pull request #23863 from Algunenano/mutation_logs
Reduce the amount of logs that StorageMergeTree::selectPartsToMutate outputs in busy systems.
2021-05-13 19:02:23 +03:00
Alexander Tokmakov
eaffe6848b fix 2021-05-13 17:24:07 +03:00
Alexander Tokmakov
2da12f0b59 fix intersection of drop range and merge 2021-05-13 17:04:36 +03:00
Vasily Nemkov
3119660406 Fixed now64(): added second optional argument for timezone. 2021-05-13 16:51:32 +03:00
Nikolai Kochetov
d78be51fb4 Calculate header for ActionsDAG 2021-05-13 16:38:18 +03:00
alesapin
3abc891107
Merge pull request #24037 from amosbird/dh
Run check_*_compiler_flag earlier
2021-05-13 15:32:23 +03:00
mergify[bot]
1b181606e8
Merge branch 'master' into arrow_array 2021-05-13 12:23:48 +00:00
Pavel Kruglov
ff6e4bf91a Remove debug output 2021-05-13 15:21:39 +03:00
Alexander Tokmakov
e114c7eb8b fix virtual parts in REPLACE_RANGE 2021-05-13 14:29:59 +03:00
Vladimir
454b77c654
Update SplitByRegexpImpl 2021-05-13 13:27:29 +03:00
Kseniia Sumarokova
135bed27f5
Merge pull request #23196 from Amesaru/progress_bar_for_LocalServer
Progress bar for local server
2021-05-13 13:13:53 +03:00
kssenii
7115045317 Tiny changes 2021-05-13 09:39:57 +00:00
Pavel Kruglov
ec214bb04c Try fix tests again 2021-05-13 12:23:59 +03:00
Maksim Kita
f3ee14d24a
Merge pull request #24066 from azat/buffer-total-lock-contention
Do not acquire lock for total_bytes/total_rows for Buffer engine
2021-05-13 11:15:06 +03:00
alesapin
bfa23d7e02 Merge branch 'master' into standalone_keeper 2021-05-13 11:03:07 +03:00
alesapin
c484cb4f37
Merge pull request #24073 from ClickHouse/fix_snapshot_race
Fix concurrent snapshot read/write
2021-05-13 10:47:41 +03:00
kssenii
0cb0bd48f7 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into rabbitmq-fixes 2021-05-13 06:36:51 +00:00
Vladimir Chebotarev
a3f7992442 Fixed typo. 2021-05-13 08:46:16 +03:00
Vladimir Chebotarev
b738e25f5b Better handling of HTTP errors in PocoHTTPClient. 2021-05-13 08:46:16 +03:00
Alexander Kuzmenkov
220f5b512e
try even smaller value 2021-05-13 06:15:44 +03:00
abel-wang
51c1d7c7ba split into characters when split by '' & add docs 2021-05-13 11:15:38 +08:00
abel-wang
99b9fe6c33 add function splitByRegexp 2021-05-13 10:37:09 +08:00
feng lv
c6f8ab9826 fix 2021-05-13 02:05:53 +00:00
alexey-milovidov
020cececc4
Merge pull request #24051 from georgthegreat/thread-local-arc
Enable thread_local in Arcadia build
2021-05-13 01:34:22 +03:00
Maksim Kita
5e1e968ef8
Merge pull request #24064 from davenger/uuid_build_fix
Generate ya.make for missing UUID.cpp
2021-05-13 00:41:13 +03:00
Azat Khuzhin
074b57fe82 Do not acquire lock for total_bytes/total_rows for Buffer engine
When Buffer() is under preassure, acquiring per-layer lock may take
significant time. And so the following query may take significant amount of time:

    SELECT total_bytes, total_rows FROM system.tables WHERE engine='Buffer'
2021-05-12 23:38:00 +03:00
Azat Khuzhin
26a1277609 Fix typo for IStorage::totalRows() comment 2021-05-12 23:38:00 +03:00
alesapin
f2a8b5b2c6 Fix concurrent snapshot read/write 2021-05-12 23:28:01 +03:00
Alexander Kuzmenkov
833f48751a
Merge pull request #24048 from ClickHouse/aku/insert-select-bytes
for trivial INSERT SELECT, adjust block size in bytes as well
2021-05-12 22:33:35 +03:00
Pavel Kruglov
86f061976e Some fixes 2021-05-12 22:02:56 +03:00
Amesaru
a95028bb43 UpdateProgress fix 2021-05-12 21:25:16 +03:00
Alexander Gololobov
748d1b6e9c Generate ya.make for missing UUID.cpp 2021-05-12 20:32:29 +03:00
Amesaru
e21899c854 Merge remote-tracking branch 'origin/progress_bar_for_LocalServer' into progress_bar_for_LocalServer 2021-05-12 19:26:42 +03:00
Amesaru
40cced96f4 UpdateProgress static 2021-05-12 19:25:12 +03:00
Nikolai Kochetov
690410009c Restor is_temporary flag for fetched part. 2021-05-12 19:17:01 +03:00
Pavel Kruglov
8ed6ad7c55 Refactor, support all types in array, add nested arrays support, more tests 2021-05-12 19:06:08 +03:00
alesapin
9f5f29f0aa Remove accident changes 2021-05-12 17:16:45 +03:00
alesapin
43ee9f0a3a Check for directory owner 2021-05-12 17:05:44 +03:00
alesapin
41eadf9127 Something working 2021-05-12 16:04:34 +03:00
Alexander Kuzmenkov
f6cb9f95df lower two-level aggregation threshold for uniq test to avoid jitter 2021-05-12 16:01:48 +03:00
kssenii
8eb9e72f66 Fix bug 2021-05-12 12:33:04 +00:00
Anton Popov
46ce4b7a88
Merge pull request #24016 from MaxWk/order-by-with-fill-datetime64
support for order by fill with DateTime64
2021-05-12 14:44:36 +03:00
Yuriy Chernyshov
5a2bd0b6ba Enable thread_local in Arcadia build 2021-05-12 13:33:38 +03:00
Alexander Kuzmenkov
2536247754
Update src/Interpreters/InterpreterInsertQuery.cpp 2021-05-12 12:42:21 +03:00
Alexander Kuzmenkov
70d4ee3cde for trivial INSERT SELECT, adjust block size in bytes as well 2021-05-12 12:40:39 +03:00
alesapin
ed3f89a7be
Merge pull request #23980 from kssenii/add-postgres-schema
Add missing table schema for postgres dictionary
2021-05-12 10:50:49 +03:00
alesapin
d5462df2f9
Merge pull request #24017 from ClickHouse/fix_bug_with_snapshots_read
Better error codes in Keeper when no leader alive
2021-05-12 10:15:58 +03:00
Maksim Kita
ffdc2b22a5
Merge pull request #24022 from amosbird/fixalias
Make `prefer_column_name_to_alias` setting more standard
2021-05-12 09:54:04 +03:00
Nikolai Kochetov
a1ba67e029
Merge pull request #20202 from amosbird/projection
Projections
2021-05-12 09:38:07 +03:00
Amos Bird
d22ab2028f
Run check_*_compiler_flag earlier 2021-05-12 12:14:25 +08:00
万康
aa43d3cff9 fix tests and code style 2021-05-12 11:44:45 +08:00
alexey-milovidov
41012b5ba4
Merge pull request #23793 from fuwhu/feature/fix-session-expired-when-selecting-system-tables
fix session expired while executing Tables
2021-05-12 01:18:36 +03:00
alexey-milovidov
d422e0199b
Merge pull request #24019 from Avogar/rename-uniq-theta
Rename uniqThetaSketch to uniqTheta
2021-05-12 01:17:18 +03:00
Maksim Kita
2b833f4bce
Merge pull request #24021 from kitaisreal/fix-arena-with-free-lists-test
Fix ArenaWithFreeLists test
2021-05-11 22:00:45 +03:00
Amos Bird
62153e7030
Fix 2021-05-12 02:30:16 +08:00
Maksim Kita
d33f4750e1 Fix ArenaWithFreeLists test 2021-05-11 21:22:50 +03:00
Vladimir
124766f3ac
Merge pull request #24013 from vdimir/issue-24010
Finalize CompressedWriteBuffer in TemporaryFileStream
2021-05-11 21:19:12 +03:00
Maksim Kita
72d46beca0
Merge pull request #23979 from azat/dict-preallocate
Reimplement preallocate for hashed/sparse_hashed dictionaries
2021-05-11 20:15:46 +03:00
feng lv
9035e3a643 fix test and conflict 2021-05-11 16:22:24 +00:00
Egor Savin
e51e13db61
Merge branch 'master' into progress_bar_for_LocalServer 2021-05-11 18:36:06 +03:00
Pavel Kruglov
704bbe0aeb Raname uniqThetaSketch to uniqTheta 2021-05-11 17:39:35 +03:00
Amesaru
fa8e904987 WriteProgress fix 2021-05-11 17:24:04 +03:00
Amesaru
6dd475cc76 Convert ProgressBar into a struct 2021-05-11 17:14:57 +03:00
Nikolai Kochetov
817bc1377c Fix part check for projections. 2021-05-11 17:07:19 +03:00
alesapin
591abbaded Better error codes in Keeper while no leader alive 2021-05-11 16:54:36 +03:00
万康
36fc6432ce support for order by fill with DateTime64 2021-05-11 21:03:32 +08:00
alesapin
46e136b5c4
Merge branch 'master' into nv/parts-uuid-move-shard 2021-05-11 15:36:40 +03:00
Fuwang Hu
a312dd414c
Merge branch 'master' into feature/fix-session-expired-when-selecting-system-tables 2021-05-11 20:04:36 +08:00
Nikolai Kochetov
a7d717d767 Remove unused code. 2021-05-11 14:59:56 +03:00
fuwhu
bf0b0e2edc disable select_sequential_consistency when getting total rows and bytes in TablesBlockSource::generate 2021-05-11 19:49:48 +08:00
Nikolai Kochetov
89f16014b8 fix fetch for projection. 2021-05-11 14:44:59 +03:00
Amos Bird
074c2ead9c
Fix 2021-05-11 18:22:23 +08:00
Amos Bird
5e9fab6d10
Comment debug info out 2021-05-11 18:12:29 +08:00
Amos Bird
5836e2e277
Fix issues in normal projection 2021-05-11 18:12:29 +08:00
Amos Bird
dfa5629071
Remove projection type ast 2021-05-11 18:12:29 +08:00
Amos Bird
51d685bb9c
Even more fixes 2021-05-11 18:12:29 +08:00
Amos Bird
ddd4256a15
More fixes 2021-05-11 18:12:28 +08:00
Amos Bird
718c284437
Fix more tests 2021-05-11 18:12:28 +08:00
Amos Bird
ba17acbd63
Fix tests 2021-05-11 18:12:28 +08:00
Amos Bird
a3fd0b6f2e
Fix tests 2021-05-11 18:12:28 +08:00
Amos Bird
42f161b1dc
Fix more 2021-05-11 18:12:28 +08:00
Amos Bird
012eb56e3b
fix ya make (projection only) 2021-05-11 18:12:28 +08:00
Amos Bird
ef918aeaff
Rebase and fix 2021-05-11 18:12:28 +08:00
Amos Bird
9c069ebdbf
support prewhere, row_filter, read_in_order and decent projection selection
TODO set index analysis in projection
2021-05-11 18:12:27 +08:00
Amos Bird
f7f949c1f9
Fix aggregation keys order 2021-05-11 18:12:27 +08:00
Amos Bird
e1e560765c
Fix missing columns 2021-05-11 18:12:27 +08:00
Amos Bird
35961c0c5d
Use ActionsDAG to rewrite projection queries 2021-05-11 18:12:27 +08:00
Nikolai Kochetov
bf95b684a7
Remove copy constructor from ProjectionDescription 2021-05-11 18:12:27 +08:00
Nikolai Kochetov
29d7038e30
Add ProjectionDescription::Type enum. Remove some checks. 2021-05-11 18:12:27 +08:00
Amos Bird
ebaf42a448
Reformat and fix some tests 2021-05-11 18:12:27 +08:00
Nikolai Kochetov
c2396c5144
Disable read-in-order optimization in case of projections. 2021-05-11 18:12:26 +08:00
Nikolai Kochetov
672cfedd13
Disable normal projection by the number of granules. 2021-05-11 18:12:26 +08:00
Nikolai Kochetov
95431168c2
Try to enable normal projections. 2021-05-11 18:12:26 +08:00
Amos Bird
483bd165e7
Check if pipeline is simple and add more comments 2021-05-11 18:12:26 +08:00
Nikolai Kochetov
427f444ba4
Fix prewhere. 2021-05-11 18:12:26 +08:00
Nikolai Kochetov
3d36fb57eb
Cleanup code. 2021-05-11 18:12:26 +08:00
Nikolai Kochetov
3296c9292f
Try to merge projectons faster. 2021-05-11 18:12:26 +08:00
Amos Bird
cd6414639e
add metadata_snapshot to getQueryProcessingStage 2021-05-11 18:12:26 +08:00
Amos Bird
264cff6415
Projections
TODO (suggested by Nikolai)

1. Build query plan fro current query (inside storage::read) up to WithMergableState
2. Check, that plan is simple enough: Aggregating - Expression - Filter - ReadFromStorage (or simplier)
3. Check, that filter is the same as filter in projection, and also expression calculates the same aggregation keys as in projection
4. Return WithMergableState if projection applies

3 will be easier to do with ActionsDAG, cause it sees all functions, and dependencies are direct (but it is possible with ExpressionActions also)

Also need to figure out how prewhere works for projections, and
row_filter_policies.

wip
2021-05-11 18:12:23 +08:00
vdimir
adb5fe2f30
Finalize CompressedWriteBuffer in TemporaryFileStream 2021-05-11 12:23:35 +03:00
Maksim Kita
fdaffe869d
Merge pull request #24007 from ClickHouse/fix-bad-code-2
Fix bad code
2021-05-11 12:03:53 +03:00
Kruglov Pavel
fb038c1985
Merge pull request #23894 from pingyu/datasketches-uniq-again
Add uniqThetaSketch again
2021-05-11 11:24:43 +03:00
Kruglov Pavel
49e7ed6e60
Merge pull request #23673 from amosbird/partitionvalue
Add _partition_value virtual column
2021-05-11 11:23:00 +03:00
alexey-milovidov
066d02dd2f
Merge pull request #23631 from ClickHouse/normalize-bigint
Make big integers production ready.
2021-05-11 11:07:52 +03:00
Alexander Kuzmenkov
6b6caba9cf
Merge pull request #23726 from ClickHouse/aku/fuzzer-typo
fix a typo in query formatting check in fuzzer
2021-05-11 05:44:49 +03:00
Alexey Milovidov
eb8a4ffe4b Fix bad code 2021-05-11 02:43:58 +03:00
Alexey Milovidov
b2ca5cd98b Merge branch 'master' into normalize-bigint 2021-05-11 02:05:40 +03:00
alexey-milovidov
6d0bd4f7d2
Merge pull request #23969 from ClickHouse/aku/long-trace-id
support longer query ids in trace log for perf tests
2021-05-10 23:35:40 +03:00
alexey-milovidov
59448eb319
Merge pull request #24004 from kitaisreal/compile-dag-fix-sip-hash
CompileDAG fix Sip hash
2021-05-10 23:33:28 +03:00
Alexey Milovidov
b9b3e4b60a Fix style and wording in #23946 2021-05-10 23:32:30 +03:00
Maksim Kita
4a22924ed5
Merge pull request #23946 from FArthur-cmd/8912-fix-dict-http-source
Add support for HTTP compression in dictionary source.
2021-05-10 22:52:07 +03:00
Maksim Kita
a4d7e190ac CompileDAG fix Sip hash 2021-05-10 22:47:07 +03:00
Alexey Milovidov
94592f0d54 Whitespaces 2021-05-10 21:16:06 +03:00
alexey-milovidov
066acc71b6
Merge pull request #8482 from ClickHouse/enable-compile-expressions
Enable "compile_expressions" by default
2021-05-10 21:09:18 +03:00
Alexander Tokmakov
eef899ae63 better code, add test 2021-05-10 21:03:37 +03:00
mergify[bot]
f5e77d7200
Merge branch 'master' into aku/fuzzer-typo 2021-05-10 17:54:19 +00:00
alexey-milovidov
0400070924
Merge pull request #23822 from excitoon-favorites/equalsignins3path
Better handling of URI's in `PocoHTTPClient`
2021-05-10 20:25:18 +03:00
alexey-milovidov
5397b1d0c3
Update PocoHTTPClient.cpp 2021-05-10 20:22:09 +03:00
alexey-milovidov
5685738d08
Update PocoHTTPClient.cpp 2021-05-10 20:20:05 +03:00
Maksim Kita
9d90b586ff
Merge pull request #23990 from kitaisreal/dictionaries-dict-get-or-null-handle-empty-rows-execute
Function dictGetOrNull handle empty rows execute
2021-05-10 20:05:26 +03:00
alexey-milovidov
ab33b80edc
Merge pull request #23962 from azat/external-group-by-overflow-row-fix
Fix SIGSEGV for external GROUP BY and overflow row
2021-05-10 20:02:05 +03:00
chou.fan
8990120eb7 add array nullable datatype support in ArrowColumnToCHColumn and fix select from array datatype misplaced bug 2021-05-10 14:17:52 +01:00
Maksim Kita
71b994b417 CompileDAG updated SipHash 2021-05-10 15:56:55 +03:00
万康
308b964ca4 enable DateTime64 to be version column 2021-05-10 20:30:52 +08:00
Vladimir
d02d14fa00
Merge pull request #23846 from excitoon-favorites/s3regions 2021-05-10 12:14:08 +03:00
Maksim Kita
e72c139bf6 Fixed code review issues 2021-05-10 11:09:32 +03:00
Maksim Kita
3d005537cf Function dictGetOrNull handle empty rows execute 2021-05-10 11:08:26 +03:00
Maksim Kita
f2a2f85f63
Merge pull request #23981 from ucasFL/type
use LowCardinality for AsynchronousMetricLog name column
2021-05-10 10:58:58 +03:00
Azat Khuzhin
920378a12a Fix google-default-arguments in IDictionarySource with loadAllWithSizeHint() 2021-05-10 07:41:49 +03:00
Azat Khuzhin
808d1a0215 Reimplement preallocate for hashed/sparse_hashed dictionaries
It was initially implemented in #15454, but was reverted in #21948 (due
to higher memory usage).

This implementation differs from the initial, since now there is
separate attribute to enable preallocation, before it was done
automatically, but this has problems with duplicates in the source.

Plus this implementation does not uses dynamic_cast, instead it extends
IDictionarySource interface.
2021-05-10 07:41:48 +03:00
Azat Khuzhin
efcde4c84f Decrease log level in IPAddressDictionary for duplicated records
After RELOAD DICTIONARY had been changed to capture the logs (by
attaching query's thread group) the 01852_dictionary_found_rate_long
fails because of this warning.
But it does not looks like it should be a warning, so change to trace.
2021-05-10 07:41:48 +03:00
Maksim Kita
8bc511eaa0 Fix LLVMExecutableFunction called with const arguments 2021-05-10 01:02:54 +03:00
Alexey Milovidov
18b7e38994 Remove redundant template 2021-05-10 00:26:34 +03:00
Alexey Milovidov
11ba22b43f UUID in dictionaries 2021-05-10 00:02:08 +03:00
Alexey Milovidov
f4db7b63b4 Fix error 2021-05-09 23:13:19 +03:00
FArthur-cmd
cf4dc8a395 refactor style 2021-05-09 22:02:37 +03:00
FArthur-cmd
6363a5dd96 use path to define compression type 2021-05-09 21:58:08 +03:00
alexey-milovidov
1ea637d996
Merge pull request #23970 from ClickHouse/pvs-studio-fixes-6
PVS-Studio fixes, part 6
2021-05-09 21:45:19 +03:00
Alexey Milovidov
1fece08673 Fix gcc build 2021-05-09 20:19:07 +03:00
Alexey Milovidov
02fd1d4bc3 Fix clang-tidy 2021-05-09 20:02:37 +03:00
Alexey Milovidov
ab94a559da Fix clang-tidy 2021-05-09 20:02:22 +03:00
feng lv
683af72cc8 use LowCardinality for AsynchronousMetricLog name column 2021-05-09 16:25:28 +00:00
Alexey Milovidov
ce4bf58029 Merge with master 2021-05-09 19:01:38 +03:00
Alexey Milovidov
9753ddc8a0 Merge branch 'master' of github.com:yandex/ClickHouse into normalize-bigint 2021-05-09 18:54:29 +03:00
kssenii
d6582f5fe5 Table schema for dict 2021-05-09 15:42:54 +00:00
Alexey Milovidov
6d55812df5 Add TODO 2021-05-09 18:05:20 +03:00
Alexey Milovidov
5618352512 Fix clang-tidy 2021-05-09 17:48:36 +03:00
Alexey Milovidov
28c4ef29b1 Fix clang-tidy 2021-05-09 17:48:11 +03:00
Azat Khuzhin
4c47d91c94 Attach background thread for dictionary reload to the reload query 2021-05-09 14:30:31 +03:00
FArthur-cmd
bd519075b7 adding checking url in HTTPSource 2021-05-09 14:27:11 +03:00
Azat Khuzhin
80f4059deb Drop unused getDictionaryConfigurationFromAST.h 2021-05-09 14:25:45 +03:00
Maksim Kita
e517436ba4
Merge pull request #23961 from kitaisreal/array-difference-decimal-math-overflow
Function arrayDifference decimal math overflow
2021-05-09 14:04:35 +03:00
Alexey Milovidov
fa678fc7a6 utils/generate-ya-make/generate-ya-make.sh 2021-05-09 03:28:33 +03:00
Alexey Milovidov
f476a5c5d7 utils/generate-ya-make/generate-ya-make.sh 2021-05-09 03:28:10 +03:00
Alexey Milovidov
9ccf7f4864 Maybe fix error 2021-05-09 01:55:05 +03:00
Alexey Milovidov
2be03d2e57 Maybe fix error 2021-05-09 01:54:46 +03:00
Alexey Milovidov
903c306e04 Fix some PVS-Studio warnings 2021-05-09 01:10:10 +03:00
Alexey Milovidov
ab9b116310 Fix some PVS-Studio warnings 2021-05-09 01:09:16 +03:00
Alexey Milovidov
ce9eda6a87 Fix warnings by PVS-Studio 2021-05-08 23:57:08 +03:00
Alexey Milovidov
e23a0d8f7e Fix warnings by PVS-Studio 2021-05-08 23:57:08 +03:00
Alexey Milovidov
367f7fe6c9 Fix warnings by PVS-Studio 2021-05-08 23:57:08 +03:00
Alexey Milovidov
58de177ed3 Fix warnings by PVS-Studio 2021-05-08 23:56:17 +03:00
Alexey Milovidov
513c6891db Fix warnings by PVS-Studio 2021-05-08 23:54:49 +03:00
Alexey Milovidov
037d06bb2a Fix warnings by PVS-Studio 2021-05-08 23:50:12 +03:00
Alexey Milovidov
f6be177540 Add TODO 2021-05-08 23:07:19 +03:00
Alexey Milovidov
e81eadab59 Support UUID and UInt256 in aggregate functions 2021-05-08 23:07:04 +03:00
Alexey Milovidov
3b767b4a64 Fix strange code 2021-05-08 22:41:14 +03:00
Alexey Milovidov
c412820e9c Fix warnings by PVS-Studio 2021-05-08 22:40:57 +03:00
Alexey Milovidov
9ad4157dbb Fix strange code 2021-05-08 22:40:23 +03:00
Maksim Kita
0b67f593e0
Merge pull request #23963 from azat/dict-hit_rate-nan
Use 0 over nan for hit_rate in case of 0 queries to the cache dictionary
2021-05-08 22:38:21 +03:00
Maksim Kita
99c25feafe
Merge pull request #23965 from azat/aggregator-logs
Round floats in Aggregator log messages
2021-05-08 22:38:02 +03:00
Alexey Milovidov
8a804f1e35 Fix warnings by PVS-Studio 2021-05-08 22:30:58 +03:00
Alexey Milovidov
d057bcf42c Fix error (amend) 2021-05-08 22:28:55 +03:00
Alexey Milovidov
883c826d3f Minor code modification 2021-05-08 22:17:46 +03:00
Alexey Milovidov
fa5205b4c7 Get rid of ugly notation 2021-05-08 22:05:08 +03:00
Alexey Milovidov
49160ae1ba Big integers and UUID in dictionaries 2021-05-08 22:01:59 +03:00
Alexey Milovidov
49c0e18e45 Fix build 2021-05-08 21:46:41 +03:00
Alexey Milovidov
2d3647c5b0 Merge branch 'master' into normalize-bigint 2021-05-08 21:22:32 +03:00
Alexey Milovidov
c9fb8ca026 Fix deprecated header 2021-05-08 21:19:45 +03:00
Alexey Milovidov
ac9b43f103 Fix error 2021-05-08 21:16:46 +03:00
Alexey Milovidov
2b4f4e08c3 Fix error 2021-05-08 21:16:25 +03:00
Alexey Milovidov
aa25ffa9e3 Fix error 2021-05-08 21:15:23 +03:00
Alexey Milovidov
52bea2630b Fix error 2021-05-08 21:15:00 +03:00
Alexey Milovidov
8e8160be28 Fix error 2021-05-08 21:11:47 +03:00
Alexey Milovidov
b96087025e Fix error 2021-05-08 21:11:31 +03:00
Maksim Kita
2a630b68a4 Fixed FunctionComparison with special edge case 2021-05-08 21:04:21 +03:00
Maksim Kita
0a2ea38cc9
Merge pull request #23916 from azat/dict-found_rate
Measure found rate for dictionaries
2021-05-08 19:23:52 +03:00
Alexey Milovidov
ad88819ee4 Fix a bunch of warnings from PVS-Studio 2021-05-08 19:13:10 +03:00
Alexey Milovidov
f805f4aa4f Fix error found by PVS-Studio 2021-05-08 19:13:00 +03:00
Alexey Milovidov
3025f9e141 More fixes for PVS-Studio 2021-05-08 19:12:49 +03:00
Alexey Milovidov
e905883c75 More fixes for PVS-Studio 2021-05-08 19:12:31 +03:00
Alexey Milovidov
022667a190 Fix some PVS-Studio warnings 2021-05-08 19:12:19 +03:00
Alexey Milovidov
8d62c42eb9 A bunch of changes for PVS-Studio 2021-05-08 19:11:50 +03:00
Alexey Milovidov
bdc372cb9a Fix bad code (found by PVS-Studio) 2021-05-08 19:11:40 +03:00
Alexey Milovidov
8b9c058141 Fix bad code in Keeper (found by PVS-Studio) 2021-05-08 19:11:31 +03:00
Alexey Milovidov
241c7a94da Fix bad code in Keeper (found by PVS-Studio) 2021-05-08 19:11:08 +03:00
Alexey Milovidov
7ca0f46708 Add suppressions for PVS-Studio 2021-05-08 19:10:56 +03:00
Alexey Milovidov
78a2df5900 Fix low quality code in Qualtile (found by PVS-Studio) 2021-05-08 19:10:38 +03:00
Alexey Milovidov
125b2ab214 Suppressions for PVS-Studio 2021-05-08 19:10:23 +03:00
Alexey Milovidov
604daa9581 Fix a bunch of warnings from PVS-Studio 2021-05-08 19:09:17 +03:00
Maksim Kita
9b405b4c07 Fixed FunctionComparison for constants 2021-05-08 18:47:08 +03:00
Alexey Milovidov
f59c55abb5 Fix error found by PVS-Studio 2021-05-08 18:35:38 +03:00
Alexey Milovidov
45dea86395 More fixes for PVS-Studio 2021-05-08 18:35:09 +03:00
Alexander Kuzmenkov
308c4657ce support longer query ids in trace log for perf tests 2021-05-08 18:20:42 +03:00
Alexey Milovidov
2fbecf36ca More fixes for PVS-Studio 2021-05-08 18:20:40 +03:00
Azat Khuzhin
69e395bede Round floats in AggregatingTransform log messages 2021-05-08 18:01:57 +03:00
Azat Khuzhin
6b11319cdf Round floats in Aggregator log messages 2021-05-08 18:01:24 +03:00
Alexey Milovidov
3e8deef6fe Fix some PVS-Studio warnings 2021-05-08 17:54:08 +03:00
Azat Khuzhin
21f08a1aa9 Use 0 over nan for hit_rate in case of 0 queries to the cache dictionary 2021-05-08 17:51:22 +03:00
Azat Khuzhin
4cecc238d6 Fix SIGSEGV for external GROUP BY and overflow row
Overflow row is used for GROUP BY if all of the above is true:
- WITH TOTALS is requested
- max_rows_to_group_by > 0
- group_by_overflow_mode = any
- totals_mode != after_having_exclusive

And in case of overflow row and external GROUP BY, once the temporary
file dumps to disk it resets without_key data variant to nullptr, so any
subsequent dump to disk will cause SIGSEGV.

Fix this, by recreating without_key data variant after dumping to disk,
instead of reseting to nullptr.

And also add sanity check (LOGICAL_ERROR) to make error more
deterministic in case of such error.

Found with fuzzer [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/23929/e7027e052998540ee660d186727e20f9555b729d/fuzzer_ubsan/report.html#fail1
2021-05-08 17:48:24 +03:00
Alexey Milovidov
9e1a5f41fc A bunch of changes for PVS-Studio 2021-05-08 17:43:03 +03:00
Maksim Kita
1bb4988b1f Fixed FunctionsComparison constant result with non constant arguments 2021-05-08 17:39:35 +03:00
Maksim Kita
6dc0dcdfa4 Fixed code review issues 2021-05-08 17:39:35 +03:00
Maksim Kita
dd44d93f49 Fixed compile expressions 2021-05-08 17:39:35 +03:00
alexey-milovidov
b76503a4ea Update ActionsDAG.cpp 2021-05-08 17:39:35 +03:00
Maksim Kita
21d8684aaf Added CHJIT documentation 2021-05-08 17:39:35 +03:00
Maksim Kita
050cb74ed0 Fix compiled if statement 2021-05-08 17:39:35 +03:00
Maksim Kita
8df4e866f3 Fixed clickhouse-client log 2021-05-08 17:39:35 +03:00
Maksim Kita
72d610be2e Updated CHJIT interface to be more thread safe 2021-05-08 17:39:35 +03:00
Maksim Kita
7778172a1f Fixed compilable function 2021-05-08 17:39:35 +03:00
Maksim Kita
4db7e49ccf Fixed Date, DateTime native type 2021-05-08 17:39:35 +03:00
Maksim Kita
16a07f61ae Refactored CompileDAG build algorithm 2021-05-08 17:39:35 +03:00
Maksim Kita
8828599380 Fixed style check 2021-05-08 17:39:35 +03:00
Maksim Kita
c79d7eae21 Refactored interfaces 2021-05-08 17:39:35 +03:00
Maksim Kita
24798ef07c Updated interfaces 2021-05-08 17:39:34 +03:00
Maksim Kita
d2eecfe593 Updated Nullable default implementation 2021-05-08 17:39:34 +03:00
Maksim Kita
8d6c282e0a Fixed test 2021-05-08 17:39:34 +03:00
Maksim Kita
af06f5b68b Fixed UUID test 2021-05-08 17:39:34 +03:00
Maksim Kita
97d87eb518 Fixed JITMemoryManager 2021-05-08 17:39:34 +03:00