Azat Khuzhin
278101fc0c
Add a comment for taskstruct netlink interface rounding to KiB
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-25 08:49:17 +03:00
Azat Khuzhin
d161b798a8
Strict taskstats parser
...
This will unhide possible issues (since sometimes statistics is
inaccurate).
Also before this patch TASKSTATS_TYPE_AGGR_TGID had been handled, while
it not correct to take into account, but it was not requested anyway.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
(cherry picked from commit bfa65b651a
2022-04-25 07:56:54 +03:00
Azat Khuzhin
6df54611a9
Log which taskstats provider is in use
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
v2: add missing __builtin_unreachable() for gcc built [1]
[1]: https://s3.amazonaws.com/clickhouse-builds/36351/99e72a960325cc1fb3cd3d6a1b56cf2b1cc2d733/binary_gcc/build_log.log
(cherry picked from commit 2be022cb56
2022-04-25 07:56:54 +03:00
mergify[bot]
705d5af3a0
Merge branch 'master' into to_start_of_five_minutes
2022-04-24 22:24:24 +00:00
Alexey Milovidov
74bb6349c2
Revert "Strict taskstats parser"
2022-04-25 01:15:08 +03:00
Amos Bird
a25bb50096
Refactor many exception messages
...
1. Always use fmt variant
2. Remove redundant period at the end of message
3. Remove useless parenthesis
2022-04-24 19:44:00 +08:00
taiyang-li
6716aa9d95
Merge remote-tracking branch 'ck/master' into fix_ranger_generator
2022-04-24 11:31:19 +08:00
Alexey Milovidov
8af3159916
Merge pull request #36351 from azat/netlink-strict
...
Strict taskstats parser
2022-04-24 05:14:06 +03:00
Alexey Milovidov
d08da0f63c
Everything related to S3 metrics was a trash
2022-04-24 03:46:35 +02:00
Alexey Milovidov
6de4f2bbff
Everything related to S3 metrics was a trash
2022-04-24 03:42:18 +02:00
zombee0
c02de61086
fixed the cow_compositions.cpp clone inner column when there is no need
...
Signed-off-by: zombee0 <flylucas_10@163.com>
2022-04-23 18:42:04 +08:00
alesapin
7380a71333
Merge pull request #31833 from ClickHouse/musl-check
...
Build clickhouse-keeper with Musl
2022-04-22 22:41:16 +02:00
Nikita Mikhaylov
36bdee0499
Deleted settings
2022-04-22 13:56:16 +00:00
Kseniia Sumarokova
33bb48106f
Merge pull request #36314 from CurtizJ/print-bad-filenames
...
Show names of erroneous files in case of parsing errors while executing table functions
2022-04-22 13:24:55 +02:00
taiyang-li
3751c69aaa
fix code style
2022-04-22 15:38:19 +08:00
taiyang-li
6bcf24ae36
add test for range generator
2022-04-22 12:33:16 +08:00
Memo
956d525840
fix conflict
2022-04-22 11:22:50 +08:00
Memo
39aadf0975
replaced toStartOfFiveMinute to toStartOfFiveMinutes
2022-04-22 10:49:59 +08:00
Maksim Kita
57444fc7d3
Merge pull request #36444 from rschu1ze/clang-tidy-fixes
...
Clang tidy fixes
2022-04-21 16:11:27 +02:00
mergify[bot]
1ba1cad5cf
Merge branch 'master' into improve-globs
2022-04-21 11:52:13 +00:00
taiyang-li
adb1288e10
fix bug of range generator
2022-04-21 11:33:15 +08:00
Azat Khuzhin
2be022cb56
Log which taskstats provider is in use
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
v2: add missing __builtin_unreachable() for gcc built [1]
[1]: https://s3.amazonaws.com/clickhouse-builds/36351/99e72a960325cc1fb3cd3d6a1b56cf2b1cc2d733/binary_gcc/build_log.log
2022-04-20 21:39:26 +03:00
Azat Khuzhin
bfa65b651a
Strict taskstats parser
...
This will unhide possible issues (since sometimes statistics is
inaccurate).
Also before this patch TASKSTATS_TYPE_AGGR_TGID had been handled, while
it not correct to take into account, but it was not requested anyway.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-20 21:39:25 +03:00
Kruglov Pavel
813e228fcc
Merge branch 'master' into improve-globs
2022-04-20 16:31:47 +02:00
Anton Popov
d4df38a0e6
fix tests
2022-04-20 14:13:04 +00:00
KinderRiven
137a1a3392
fix bug for local cache
2022-04-20 20:22:33 +08:00
KinderRiven
59d56b6391
resubmit
2022-04-20 20:10:31 +08:00
KinderRiven
910c4a6660
fix bug for local cache
2022-04-20 19:49:04 +08:00
KinderRiven
b91f18033c
fix bug for local cache
2022-04-20 19:43:07 +08:00
mergify[bot]
0df5fda6ed
Merge branch 'master' into musl-check
2022-04-20 09:28:40 +00:00
tavplubix
2c54381520
Merge pull request #36200 from ClickHouse/fix_create_as_replicated_default_args
...
Fix CREATE AS for ReplicatedMergeTree with default arguments
2022-04-20 12:01:13 +03:00
Robert Schulze
b24ca8de52
Fix various clang-tidy warnings
...
When I tried to add cool new clang-tidy 14 warnings, I noticed that the
current clang-tidy settings already produce a ton of warnings. This
commit addresses many of these. Almost all of them were non-critical,
i.e. C vs. C++ style casts.
2022-04-20 10:29:05 +02:00
Robert Schulze
b6d7367538
Merge remote-tracking branch 'origin/master' into erase_if3
...
Conflicts:
- Interpreters/ActionsDAG.cpp
2022-04-20 10:02:59 +02:00
Anton Popov
bee4ca9b62
add more tests for error diagnostics in files
2022-04-19 15:56:34 +00:00
Alexey Milovidov
93229133e2
Return two changes
2022-04-19 17:44:27 +02:00
Alexey Milovidov
79be0aa75b
Remove Arcadia
2022-04-19 17:44:27 +02:00
Alexey Milovidov
3c1e05eb53
Remove Arcadia
2022-04-19 17:44:27 +02:00
Alexey Milovidov
7629016f66
Fix clang-tidy-14 (part 1)
2022-04-19 17:44:27 +02:00
Alexey Milovidov
b6c06268eb
Simplification #36313
2022-04-19 17:44:27 +02:00
Alexey Milovidov
767b2eecff
Remove trash
2022-04-19 17:44:27 +02:00
Alexey Milovidov
fb9545e0b4
Remove trash
2022-04-19 17:44:27 +02:00
Alexey Milovidov
611ea86d60
Remove abbreviation
2022-04-19 17:44:26 +02:00
Alexey Milovidov
c46715db82
Remove abbreviation
2022-04-19 17:44:26 +02:00
Anton Popov
3e361c9759
Merge remote-tracking branch 'upstream/master' into HEAD
2022-04-19 14:18:04 +00:00
Robert Schulze
118e94523c
Activate clang-tidy warning "readability-container-contains"
...
This check suggests replacing <Container>.count() by
<Container>.contains() which is more speaking and in case of
multimaps/multisets also faster.
2022-04-18 23:53:11 +02:00
Alexey Milovidov
f6ab2bd523
Merge pull request #36312 from ClickHouse/remove-arcadia
...
Remove remaining parts of Arcadia
2022-04-18 07:02:54 +03:00
Alexey Milovidov
36595e4206
Merge pull request #36320 from ClickHouse/fix-clang-tidy-14
...
Fix clang-tidy-14 (part 1)
2022-04-18 07:02:10 +03:00
Alexey Milovidov
48fd09c7db
Merge pull request #36310 from ClickHouse/cpuid-remove-trash
...
Remove trash from CPUID
2022-04-18 07:01:23 +03:00
Alexey Milovidov
543e5d7242
Merge branch 'master' into musl-check
2022-04-18 02:40:13 +02:00
Alexey Milovidov
c7bca13a03
Remove abbreviation
2022-04-18 01:03:58 +02:00
Alexey Milovidov
242919eddd
Remove abbreviation
2022-04-18 01:02:49 +02:00
Alexey Milovidov
a64765bc6f
Allow custom default ORDER BY for system logs
2022-04-17 21:56:36 +02:00
Alexey Milovidov
27afc08d8f
Merge branch 'master' into cpuid-remove-trash
2022-04-17 16:30:30 +02:00
Alexey Milovidov
7de4f2b6c1
Merge branch 'master' into remove-arcadia
2022-04-17 16:30:09 +02:00
Robert Schulze
1e1df8e101
Replace remove-erase idiom by C++20 erase()/erase_if()
...
- makes the code less verbose while being as efficient
2022-04-17 12:04:47 +02:00
Alexey Milovidov
294efeccfe
Fix clang-tidy-14 (part 1)
2022-04-16 04:54:04 +02:00
Alexey Milovidov
33ffdcaa4f
Return two changes
2022-04-16 02:18:22 +02:00
Anton Popov
2de6668b3f
show names of erroneous files
2022-04-16 00:10:47 +00:00
Alexey Milovidov
69b91c5410
Simplification #36313
2022-04-16 02:08:06 +02:00
Alexey Milovidov
40357637ec
Remove Arcadia
2022-04-16 00:33:32 +02:00
Alexey Milovidov
cbeeb7ec4f
Remove Arcadia
2022-04-16 00:20:47 +02:00
Alexey Milovidov
364f10aff5
Remove trash
2022-04-15 22:56:51 +02:00
Alexey Milovidov
58fc4e033a
Remove trash
2022-04-15 22:54:08 +02:00
alesapin
40e5ba21a4
Update src/Common/FileSegment.cpp
2022-04-15 11:55:05 +02:00
kssenii
3e42a1711d
Fix
2022-04-14 13:50:13 +02:00
Kseniia Sumarokova
4d667301cc
Merge pull request #36135 from kssenii/cache-fix
...
Fix after #35475
2022-04-14 11:11:13 +02:00
Antonio Andelic
4be7cc757d
Merge pull request #36125 from ClickHouse/memory-tracking-overloads
...
Add new/delete overloads with align
2022-04-14 08:16:51 +02:00
avogar
1c065f8c7a
Some refactoring around schema inference with globs
2022-04-13 17:02:48 +00:00
tavplubix
6a165787a6
Merge pull request #36115 from ClickHouse/thread-pool-reset-thread-name
...
Reset thread name in thread pool
2022-04-13 19:10:04 +03:00
Maksim Kita
ca89af89a1
Merge pull request #36088 from israelg99/fix_executable
...
Fix CH silently failing when it cannot execute a file
2022-04-13 16:53:00 +02:00
Alexander Tokmakov
40fea2b833
do not unfold {uuid} macro
2022-04-13 16:51:59 +02:00
mergify[bot]
2c5d6d132e
Merge branch 'master' into cache-fix
2022-04-13 13:32:56 +00:00
mergify[bot]
4fb66013fe
Merge branch 'master' into memory-tracking-overloads
2022-04-13 12:40:49 +00:00
tavplubix
43de4827d7
Merge pull request #36074 from ClickHouse/zookeeper_log_thread_query_id
...
Add thread_id and query_id to zookeeper_log
2022-04-13 15:34:04 +03:00
Alexey Milovidov
ab80b94f45
Update ThreadPool.cpp
2022-04-13 15:18:49 +03:00
Kseniia Sumarokova
07cfa980ac
Update FileCache.h
2022-04-13 12:08:25 +02:00
Kseniia Sumarokova
44ecfd925b
Update FileSegment.cpp
2022-04-13 11:35:46 +02:00
Kseniia Sumarokova
053892777f
Update FileSegment.cpp
2022-04-13 11:35:12 +02:00
Kseniia Sumarokova
a611566266
Update FileCache.h
2022-04-13 11:33:15 +02:00
Antonio Andelic
835f752a1a
Add maybe_unused for align arguments
2022-04-13 06:19:59 +00:00
alesapin
f011864386
Build clickhouse-keeper with musl
2022-04-12 18:48:16 +02:00
mergify[bot]
d5b2355944
Merge branch 'master' into memory-overcommit-free
2022-04-12 16:00:12 +00:00
Dmitry Novik
d9d2bf310d
Fix test
2022-04-12 15:58:34 +00:00
Julian Gilyadov
a4f56f3330
Throw exception when file cant be executed instead of displaying success
2022-04-12 17:52:44 +02:00
Antonio Andelic
1b4cebcfb6
Add new/delete overloads
2022-04-12 14:11:10 +00:00
Dmitry Novik
63de3c9746
Add comment with explanation
2022-04-12 13:00:06 +00:00
Dmitry Novik
188e1a87bd
Check if enough memory is actually freed within timeout
2022-04-12 12:52:35 +00:00
Kseniia Sumarokova
50b5684d00
Update FileSegment.cpp
2022-04-12 11:59:58 +02:00
Dmitry Novik
9c20a492c8
Add unit tests
2022-04-12 09:46:26 +00:00
Kseniia Sumarokova
a77a228ab8
Update FileSegment.cpp
2022-04-12 09:37:03 +02:00
kssenii
d2ccf876c6
Fix
2022-04-11 17:51:49 +02:00
Raúl Marín
83c814f658
OSX fixes
2022-04-11 15:25:20 +02:00
Raúl Marín
6e346a7fc3
Support atomic replace under OSX
2022-04-11 14:32:55 +02:00
Alexander Tokmakov
802f62a80e
fix
2022-04-11 09:42:00 +02:00
Alexey Milovidov
f0fad98a73
Reset thread name in thread pool
2022-04-11 01:03:24 +02:00
Alexander Tokmakov
50a32a74b7
add thread_id and query_id to zookeeper_log
2022-04-08 17:10:08 +02:00
Alexander Tokmakov
49c35f3261
Merge branch 'master' into mvcc_prototype
2022-04-08 13:34:40 +02:00
alesapin
8ec802bc62
Merge pull request #35475 from kssenii/remote-fs-cache-improvements
...
Allow to write remote fs cache on all write operations. Add `system.remote_filesystem_cache` table. Add `drop remote filesystem cache (<path>)` query. Add `system.remote_data_paths` table.
2022-04-08 12:06:26 +02:00
kssenii
0b7af1f26c
Fix checks
2022-04-08 01:58:55 +02:00
kssenii
5dce2f18b5
Better
2022-04-07 18:48:35 +02:00
Alexander Tokmakov
7f54e7b422
Merge branch 'master' into mvcc_prototype
2022-04-07 15:14:06 +02:00
Alexander Tokmakov
8290ffa88d
Merge branch 'master' into mvcc_prototype
2022-04-07 13:50:42 +02:00
tavplubix
6e9c028bbb
Merge pull request #35956 from Algunenano/limit_dns_retries
...
DNS cache: Add option to drop elements after several consecutive failures
2022-04-07 13:20:36 +03:00
Nikolai Kochetov
3e1b3f14c0
Merge pull request #34355 from azat/processors-profiling
...
Profiling on Processors level
2022-04-07 12:13:14 +02:00
alesapin
d21ed546a4
Merge pull request #35967 from ClickHouse/keeper-polishing
...
Small code changes in ZooKeeper client/Keeper code
2022-04-07 12:11:10 +02:00
mergify[bot]
585cff1e95
Merge branch 'master' into limit_dns_retries
2022-04-06 18:23:17 +00:00
tavplubix
58db8cd9b3
Merge pull request #35946 from ClickHouse/faster_replicated_ddl
...
Make some replicated DDL queries faster
2022-04-06 19:25:25 +03:00
Kseniia Sumarokova
a383d9ee6a
Merge pull request #35916 from filimonov/kafka_metrics
...
Add some metrics to engine Kafka
2022-04-06 11:58:17 +02:00
Raúl Marín
060f5118f0
Improvements based on PR review
2022-04-06 10:48:12 +02:00
Mikhail Filimonov
3412be9d4d
Change KafkaDirectReads to KafkaConsumersInUse
2022-04-05 20:25:05 +02:00
Raúl Marín
39cc3baf5f
Keep the previous exception code
2022-04-05 16:37:53 +02:00
Antonio Andelic
d296eeee2d
Small changes for Keeper
2022-04-05 13:56:28 +00:00
Alexander Tokmakov
d9e3e9b69f
Merge branch 'master' into faster_replicated_ddl
2022-04-05 14:38:38 +02:00
Alexander Tokmakov
1fe50ad201
Merge branch 'master' into mvcc_prototype
2022-04-05 14:38:02 +02:00
Maksim Kita
c3c284e6e6
Merge pull request #35917 from kitaisreal/executable-user-defined-function-fix
...
Executable user defined functions prevent executing during analysis
2022-04-05 14:05:52 +02:00
Raúl Marín
8a05cf3927
DNS cache: Add option to drop elements after several consecutive failures
2022-04-05 13:00:27 +02:00
Maksim Kita
6e1d837439
Fixed style check
2022-04-05 11:24:33 +02:00
Alexander Tokmakov
da00beaf7f
Merge branch 'master' into mvcc_prototype
2022-04-05 11:14:42 +02:00
Maksim Kita
b160ffd726
Merge pull request #35723 from ClickHouse/array-has-all-sse-avx2-optimizations
...
Merging #27653
2022-04-05 11:09:14 +02:00
Alexander Tokmakov
4e9ec5dc2f
make some replicated DDL faster
2022-04-05 00:51:48 +02:00
larryluogit
808d9afd0f
Fix optin.cplusplus.UninitializedObject issue ( #35626 )
...
* Fix optin.cplusplus.UninitializedObject issue
* Enable optin.cplusplus.UninitializedObject
2022-04-04 23:47:14 +03:00
Mikhail Filimonov
53c7376e37
Add some metrics to engine Kafka
2022-04-04 20:25:53 +02:00
Maksim Kita
2a8e479277
ExecutableUserDefinedFunction prevent function execution during query analysis
2022-04-04 15:56:01 +02:00
Alexander Tokmakov
a2167f12b8
Merge branch 'master' into mvcc_prototype
2022-04-04 14:24:23 +02:00
Maksim Kita
47528de78b
Fix build
2022-04-04 14:07:05 +02:00
Azat Khuzhin
14538f6456
Add system.processors_profile_log
...
This is the system table that will contain Processors level profiling.
v2: one entry per Processor, not 3 (PortFull/NeedData/work())
v3: us over ms
v4: Enable processors_profile_log table by default
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-04 13:19:41 +03:00
kssenii
36c583d0de
Better version of cache on insert
2022-04-04 10:58:59 +02:00
Antonio Andelic
a926bc19ea
Address PR comments
2022-04-04 07:24:42 +00:00
Antonio Andelic
d96b682a55
Refactor
2022-04-04 07:24:42 +00:00
taiyang-li
d6247338de
fix failed stateless tests
2022-04-04 07:24:42 +00:00
taiyang-li
eda299b48b
fix building
2022-04-04 07:24:42 +00:00
taiyang-li
4547ed370a
add hints for column description
2022-04-04 07:24:42 +00:00
Alexey Milovidov
d9e5ca2119
Merge pull request #34394 from holadepo/last_day
...
Add toLastDayOfMonth function
2022-04-04 07:02:08 +03:00
Alexey Milovidov
5a47958744
Merge pull request #35736 from CurtizJ/quota-written-bytes
...
Add quota for written bytes
2022-04-03 05:26:49 +03:00
Anton Popov
687942ce70
more strict quota for written bytes
2022-04-01 15:02:49 +00:00
kssenii
6c8e073a61
Merge master
2022-04-01 16:48:29 +02:00
tcoyvwac
cb698c4cc1
Replace throw in debug mode in destructor
...
FileSegmentsHolder:
- Replaced throw in destructor with assert for all #ifdef modes.
2022-04-01 15:42:34 +02:00
Alexander Tokmakov
6591d1ceb7
Merge branch 'master' into mvcc_prototype
2022-04-01 15:38:46 +02:00
alesapin
f2c6387a8d
Merge pull request #35381 from kssenii/remote-filesystem-cache-fixes
...
Cache fixes for high concurrency on corner cases
2022-04-01 10:48:31 +02:00
filimonov
24d72a18d0
Update getNumberOfPhysicalCPUCores.cpp
...
In Kubernetes shares are calculated from resources.requests.cpu, quota & period - from limits.
When you configure only requests without limits - the container still can use all the cores. So you see all the cores the system has.
(because of requests the pod just can't be scheduled on the node which have less cpus)
So the effective CPU count is all the available cores if you don't have limits, or calculated from quota & period if you have the limits.
2022-03-31 17:21:54 +02:00
mergify[bot]
3183b61c74
Merge branch 'master' into mvcc_prototype
2022-03-31 12:27:09 +00:00
Alexander Tokmakov
5a50ad9de3
Merge branch 'master' into mvcc_prototype
2022-03-31 11:35:04 +02:00
alesapin
2365bbf0d3
Merge pull request #34566 from ClickHouse/startup-sanity-checks
...
add simple sanity checks for server startup
2022-03-31 11:33:59 +02:00
alesapin
81ce991494
Merge branch 'master' into startup-sanity-checks
2022-03-31 00:08:43 +02:00
Nikita Taranov
30f2a942c5
Predict size of hash table for GROUP BY ( #33439 )
...
* use AggregationMethod ctor with reserve
* add new settings
* add HashTablesStatistics
* support queries with limit
* support distributed and with external aggregation
* add new profile events
* add some tests
* add perf test
* export cache stats through AsynchronousMetrics
* rm redundant trace
* fix style
* fix 02122_parallel_formatting test
* review fixes
* fix 02122_parallel_formatting test
* apply also to two-level HTs
* try simpler strategy
* increase max_size_to_preallocate_for_aggregation for experiment
* fixes
* Revert "increase max_size_to_preallocate_for_aggregation for experiment"
This reverts commit 6cf6f75704
2022-03-30 22:47:51 +02:00
kssenii
0fc92fe2aa
Get rid of all "remote" mentions
2022-03-30 17:15:29 +02:00
kssenii
b30948dd53
Relax test
2022-03-30 17:12:23 +02:00
Vladimir C
31c367d3cd
Merge pull request #35651 from amosbird/columntransformerrename
2022-03-30 12:37:30 +02:00
Antonio Andelic
03a09dc914
Merge pull request #35571 from ClickHouse/parallel-s3-downloading
...
Parallel S3 downloading
2022-03-30 08:14:49 +02:00
kssenii
ce9131f905
Fix unit test
2022-03-29 19:57:55 +02:00
