Commit Graph

74638 Commits

Author SHA1 Message Date
gyuton
b55a9cc6d4
Apply suggestions from code review
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
2021-10-22 17:47:36 +03:00
gyuton
59ee426d48 small improvement 2021-10-20 02:00:54 +03:00
gyuton
1d76fc9636 Small fix 2021-10-20 01:59:27 +03:00
gyuton
c1d24037a4 Initial draft 2021-10-20 01:42:05 +03:00
Nikita Mikhaylov
d1138a8a25
Merge pull request #29691 from azat/fix-merge-mutate-memory-tracking
Fix memory tracking for merges and mutations
2021-10-15 13:53:52 +03:00
Maksim Kita
97fa53d6b2
Merge pull request #27961 from amosbird/indexcache
Dedicated Mark/Uncompressed cache for skip indices
2021-10-15 13:31:44 +03:00
Maksim Kita
7beaeb8b13
Merge branch 'master' into indexcache 2021-10-15 12:59:09 +03:00
Ivan Blinkov
20798ac9f1
Merge pull request #30221 from Tentoshka/patch-1
Translation external-dicts-dict-sources.md
2021-10-15 12:57:08 +03:00
Maksim Kita
27fdeef4b6
Merge pull request #29650 from kitaisreal/add-default-database-visitor-support-dict-get
AddDefaultDatabaseVisitor support dictGet
2021-10-15 12:28:58 +03:00
Maksim Kita
8d9f593a61
Merge pull request #30217 from azat/fix-clang-tidy-json
Fix clang-tidy warnings in FunctionsJSON code
2021-10-15 12:27:24 +03:00
Nikolay Degterinsky
6b9a1ab60b
Merge pull request #30222 from PaVeL-Ekt/patch-2
Fixed a typo in the string-functions.md
2021-10-15 12:10:24 +03:00
Pavel
49e9ea40ac
Update string-functions.md 2021-10-15 14:02:57 +05:00
Tentoshka
0d635cf34e
Translation external-dicts-dict-sources.md
Translation of untranslated texts
2021-10-15 15:55:03 +07:00
Nikolai Kochetov
769be69f15
Merge pull request #30029 from karnevil13/karnevil-DOCSUP-14788
DOCSUP-14788: Edit and translate to Russian
2021-10-15 11:38:43 +03:00
Kseniia Sumarokova
0e228a2369
Merge pull request #30189 from azat/fix-INSERT-SELECT-MATERIALIZED
Fix INSERT SELECT incorrectly fills MATERIALIZED column based of Nullable column
2021-10-15 10:48:23 +03:00
Azat Khuzhin
07adc847db Fix clang-tidy warnings in FunctionsJSON code 2021-10-15 10:11:03 +03:00
Maksim Kita
8db2c844d3 Fixed test 2021-10-15 02:07:52 +03:00
Azat Khuzhin
2a7a1d8df5 Avoid losing any allocations context from merges/mutations 2021-10-15 01:43:28 +03:00
Azat Khuzhin
8a209a78d7 Set query_id for mutations/merges
This will allow to distinguish allocations in trace_log.
2021-10-15 01:43:28 +03:00
Azat Khuzhin
3477ab52a7 Add StorageID::getShortName() 2021-10-15 01:43:28 +03:00
Azat Khuzhin
8cc45bea7b Avoid accounting memory from another mutation/merge
Before this path it was possible that one merge/mutation may account
memory from another, due to ThreadStatus::untracked_memory.

And this cause flakiness of 01200_mutations_memory_consumption.
2021-10-15 01:43:28 +03:00
Azat Khuzhin
fd38cbb0df Fix memory tracking for merges and mutations (by destroying earlier)
It fixes only some tiny allocations, and so it should not affect any
huge mutations/merges.

And plus, this should not be a real fix, since peak_memory_usage is
obtained before even destrying this objects, and destroing objects will
unlikely update peak memory usage (although it is possible).

v0: do this in dtors
v2: do this earlier
2021-10-15 01:43:27 +03:00
Azat Khuzhin
e4b39ca99c Remove unused Block member from MutateTask
v0: Fix excessive memory usage in MutateTask
    This is relevant only for 01200_mutations_memory_consumption test, since
    this is just a block.
v2: just remove unused Block member, since other part had been fixed in #29768
2021-10-15 01:43:27 +03:00
Azat Khuzhin
ae980fcd62 Move 01200_mutations_memory_consumption out from bugs 2021-10-15 01:43:27 +03:00
Azat Khuzhin
5d5f94f456 Mark 01200_mutations_memory_consumption as long and allow run in fasttest 2021-10-15 01:43:27 +03:00
Azat Khuzhin
a063097fdf Fix INSERT SELECT incorrectly fills MATERIALIZED column based of Nullable column
Required columns of the default expression should not be converted to NULL,
since this map value to default and MATERIALIZED values will not work.

Consider the following structure:
- A Nullable(Int64)
- X Int64 materialized coalesce(A, -1)

With recursive_null_as_default=true you will get:

    _CAST(coalesce(A, -1), 'Int64') AS X, NULL AS A

And this will ignore default expression.

Fixes: #23524 (Cc: @kssenii)
Fixes: #29729 (Cc: @tavplubix)
Backport: 21.7+
2021-10-15 01:36:09 +03:00
alexey-milovidov
bc1662b9fe
Merge pull request #29946 from azat/log-fix-data-race
Fix data-race between LogSink::writeMarks() and LogSource in StorageLog
2021-10-15 01:30:58 +03:00
alexey-milovidov
8d694cbcdc
Merge pull request #29959 from azat/log-data-race-file-checker-fix
Fix possible data-race between FileChecker and StorageLog/StorageStripeLog
2021-10-15 01:30:23 +03:00
alexey-milovidov
9a57fbc9e8
Merge pull request #30150 from azat/test_MemoryTracking-flap
Make test_MemoryTracking::test_http not flaky
2021-10-15 01:28:59 +03:00
karnevil13
8ec43b7c70 fixed type-conversion-functions en-ru 2021-10-15 00:56:21 +03:00
Maksim Kita
5b5ba5fbc8
Merge pull request #30179 from kitaisreal/clickhouse-local-support-sql-user-defined-functions
Support SQL user defined functions for clickhouse-local
2021-10-14 23:14:18 +03:00
Maksim Kita
a51ab78c68 Fixed style check 2021-10-14 23:13:41 +03:00
Maksim Kita
888c619472
Merge pull request #30145 from kitaisreal/functions-json-avoid-copying-object-element-during-iteration
FunctionsJSON avoid copying object element during iteration
2021-10-14 23:11:16 +03:00
Maksim Kita
5568461acf FunctionsJSON move to cpp file 2021-10-14 23:10:53 +03:00
Maksim Kita
913a8f3640 Fixed style check 2021-10-14 22:15:21 +03:00
Maksim Kita
83879415b4 Fixed tests 2021-10-14 22:12:06 +03:00
Nikolai Kochetov
6b251ddd97
Merge pull request #30193 from ClickHouse/try-to-fix-01288_shard_max_network_bandwidth
Smaller smoothing window in throttler.
2021-10-14 22:10:37 +03:00
Nikolai Kochetov
e9cab3aaad Smaller smoothing window in throttler. 2021-10-14 21:20:19 +03:00
Azat Khuzhin
d030e08d05 Make test_MemoryTracking::test_http not flaky
By comparing only megabytes in the memory changes, instead of bytes as
before, since it may be tricky at least due to max_untracked_memory and
how thread pool handle it.

It should be safe, since originally it was written in #16121 which fixes
issue #15932, which has ~4MB consumption of memory per request.
2021-10-14 21:06:39 +03:00
Azat Khuzhin
56ab0e31e6 Add description for test_MemoryTracking 2021-10-14 21:06:22 +03:00
Maksim Kita
04e07ed86d FunctionsJSON avoid copying object element during iteration 2021-10-14 16:37:52 +03:00
Maksim Kita
c1f04452de AddDefaultDatabaseVisitor support dictGet 2021-10-14 16:31:32 +03:00
tavplubix
746964af88
Merge pull request #30084 from vitlibar/fix-external-loader-without-extra-mutex
Fix ExternalLoader without additional mutex.
2021-10-14 16:18:17 +03:00
Maksim Kita
fbaa9e7be4 Support SQL user defined functions for clickhouse-local 2021-10-14 16:15:39 +03:00
Denny Crane
ddf6ca716c
Doc. fix optimize_skip_unused_shards description (#30114)
* fix optimize_skip_unused_shards description

* Update settings.md
2021-10-14 15:47:43 +03:00
Maksim Kita
4ed28d8e52
Merge pull request #29981 from kitaisreal/added-function-tokens
Added function tokens
2021-10-14 15:36:06 +03:00
Anton Popov
6c1da023f7
Merge pull request #30142 from kitaisreal/polygon-dictionary-support-read
Polygon dictionary support read
2021-10-14 15:03:10 +03:00
Anton Popov
5802037f1e
Merge pull request #29916 from ucasfl/format-alter
Format improvement of AlterQuery
2021-10-14 14:30:08 +03:00
Denny Crane
6a0ee3d23e
test for rename atomic hanging (#30080)
* test for rename atomic hanging

* test for rename atomic hanging

* Update 02096_rename_atomic_hang.sql

* Update 02096_rename_atomic_hang.sql

Co-authored-by: tavplubix <tavplubix@gmail.com>
2021-10-14 13:31:34 +03:00
Maksim Kita
8ed4e73705
Merge pull request #30000 from ClickHouse/profile-snapshot
Make read of Counters snapshot non-atomic
2021-10-14 13:22:44 +03:00