Commit Graph

73271 Commits

Author SHA1 Message Date
WangZengrui
bd2c016cf3 fix bug 2021-10-17 00:33:57 +08:00
WangZengrui
1541593b2f add notes 2021-10-16 23:28:29 +08:00
WangZengrui
6752be4c4e fix bug and add test 2021-10-16 23:11:45 +08:00
WangZengrui
8a94e26bec init 2021-10-16 18:51:42 +08:00
alesapin
ec26768dce Temporary remove 01200_mutations_memory_consumption 2021-09-28 10:49:06 +03:00
ClickHouse Admin
59a861c8e0
Merge pull request #29466 from ClickHouse/clickhouse-admin-patch-1
[github] we're switching to CLA based on Apache CLA
2021-09-28 10:39:58 +03:00
ClickHouse Admin
a5ad6f7f90
[github] we're switching to CLA based on Apache CLA
CLA signing is automated with CLA Assistant.
2021-09-28 10:38:53 +03:00
tavplubix
15e80ead3f
Merge pull request #29445 from ClickHouse/tavplubix-patch-3
Fix flaky test 01158_zookeeper_log_long
2021-09-27 23:50:48 +03:00
alexey-milovidov
32fe846bcb
Merge pull request #28664 from ka1bi4/romanzhukov-DOCSUP-14103-OpenSky-UKProperty
DOCSUP-14103: Edit and translate to Russian (OpenSky dataset and UK Property Price Paid data)
2021-09-27 22:38:24 +03:00
alexey-milovidov
2902f52e1b
Merge pull request #29392 from den-crane/test/issue_23634
test for #23634 ( nullable PK and negate cond )
2021-09-27 22:20:42 +03:00
Maksim Kita
d4e19190ea
Merge pull request #29443 from kitaisreal/dictionary-view-different-databases-added-test
Dictionary view different database added test
2021-09-27 22:04:05 +03:00
Maksim Kita
7861c26eaf
Merge pull request #29431 from kitaisreal/map-bloom-filter-index-map-values-equals-support
Map bloom filter index mapValues equals function support
2021-09-27 22:03:53 +03:00
Maksim Kita
342756fe00
Merge pull request #29432 from kitaisreal/dictionary-array-nested-map-added-test
Dictionary Array nested Map added test
2021-09-27 21:55:28 +03:00
Nikolai Kochetov
236d71ea94
Merge pull request #28582 from ClickHouse/rewrite-pushing-to-views
Rewrite PushingToViews
2021-09-27 21:19:11 +03:00
tavplubix
23d899fb60
Update 01158_zookeeper_log_long.sql 2021-09-27 19:54:59 +03:00
Maksim Kita
17f1a3910b Fixed test 2021-09-27 19:20:58 +03:00
Maksim Kita
2b8931523f Dictionary view different database added test 2021-09-27 19:19:38 +03:00
tavplubix
e9749b0027
Merge pull request #29323 from ClickHouse/fix_assertion_ddl_dependency
Fix assertion in DDLDependencyVisitor
2021-09-27 18:06:32 +03:00
alesapin
ddd80c8e72
Merge pull request #29264 from Enmk/governance/table_comment_update
Implemented modifying table comments with `ALTER TABLE t MODIFY COMMENT 'value'`
2021-09-27 18:02:14 +03:00
Maksim Kita
bd499e5b7d Dictionary Array nested Map added test 2021-09-27 17:44:34 +03:00
Maksim Kita
cd9c796e6f Map bloom filter index mapValues equals function support 2021-09-27 17:23:56 +03:00
Maksim Kita
a6a19c6267
Merge pull request #29405 from kitaisreal/added-setting-use-skip-indexes
Added setting use_skip_indexes
2021-09-27 16:06:54 +03:00
Maksim Kita
8ce21a70bb Fixed docs 2021-09-27 16:06:35 +03:00
Kseniia Sumarokova
beda6bee2e
Merge pull request #29276 from kssenii/hdfs-fix-assertion
Fix !hasPendingData() failed assertion in hdfs read buffer
2021-09-27 15:47:17 +03:00
Nikita Mikhaylov
3741b8a17e
Merge pull request #29337 from amosbird/projection-fix18
Fix projection merges and mutations.
2021-09-27 13:45:13 +03:00
Vladimir C
70dc43a72d
Merge pull request #29388 from aiven/kmichel-fix-replicated-storage-reload 2021-09-27 12:41:24 +03:00
Maksim Kita
d0f53cfc31 Added setting use_skip_indexes 2021-09-27 12:17:00 +03:00
Maksim Kita
92c484f0d3
Merge pull request #29252 from Enmk/fix_some_functions_exception_messages
Better exception messages for some String-related functions
2021-09-27 11:50:42 +03:00
tavplubix
1c9778603f
Update clickhouse-test 2021-09-27 11:43:00 +03:00
Maksim Kita
f7aed5aab8
Merge pull request #29393 from azat/rocksdb-fix-data-race
rocksdb: fix race condition during multiple DB opening
2021-09-27 11:32:59 +03:00
Nikolai Kochetov
78a7665f43 Merge branch 'master' into rewrite-pushing-to-views 2021-09-27 10:56:50 +03:00
Nikolai Kochetov
09232788c0 Fix GRPC tests. 2021-09-27 10:55:33 +03:00
Nikolai Kochetov
841ef13dee
Merge pull request #29338 from ClickHouse/less-sleeps-in-integratin-tests
Less sleeps in integration tests.
2021-09-27 10:35:31 +03:00
Vasily Nemkov
544cccb2fb
Forward-declared LOGICAL_ERROR to make style check happy 2021-09-27 09:43:13 +03:00
alexey-milovidov
5a7f30171a
Merge pull request #29355 from ClickHouse/remove-trash-db-regexp
Fix assert in table function `merge` with database regexp
2021-09-27 05:50:13 +03:00
alexey-milovidov
3609d4adad
Merge pull request #29164 from azat/test_send_crash_reports-fix
test_send_crash_reports: suppress Fatal messages check (due to explicit SIGSEGV)
2021-09-27 03:54:10 +03:00
alexey-milovidov
319e0c1f91
Merge pull request #29229 from azat/send-UNKNOWN_DATABASE-to-client
Send UNKNOWN_DATABASE to the client (via TCP)
2021-09-27 02:46:01 +03:00
Alexey Milovidov
1227a383e3 Merge branch 'remove-trash-db-regexp' of github.com:yandex/ClickHouse into remove-trash-db-regexp 2021-09-27 02:17:19 +03:00
Alexey Milovidov
8493b014cd Improve test 2021-09-27 02:16:58 +03:00
Alexey Milovidov
16f0f0af7f Merge remote-tracking branch 'origin/master' into remove-trash-db-regexp 2021-09-27 02:12:13 +03:00
alexey-milovidov
1c1e2e6b28
Merge pull request #29289 from vdimir/issue-29227-rocksdb-truncate
Fix race in StorageSystemRocksDB
2021-09-27 01:55:07 +03:00
Azat Khuzhin
b3d1bfc67a Send UNKNOWN_DATABASE to the client (via TCP)
Before this patch:

    $ clickhouse-client --database foo -q 'select 1'
    Code: 32. DB::Exception: Attempt to read after eof: while receiving packet from localhost:9000. (ATTEMPT_TO_READ_AFTER_EOF)

After:

    $ clickhouse-client --database foo -q 'select 1'
    Received exception from server (version 21.11.1):
    Code: 81. DB::Exception: Received from localhost:9000. DB::Exception: Database foo doesn't exist. (UNKNOWN_DATABASE)
    (query: select 1)

Fixes: #26864 (cc @vitlibar)
2021-09-26 23:45:29 +03:00
Azat Khuzhin
42af45b2ba rocksdb: fix race condition during multiple DB opening
This should fix the following SIGSEGV, that was found on CI [1]:

    <Fatal> BaseDaemon: Address: NULL pointer. Access: read. Unknown si_code.
    <Fatal> BaseDaemon: 4.4. inlined from ../contrib/rocksdb/utilities/object_registry.cc:19: rocksdb::ObjectLibrary::FindEntry() const
    ...
    <Fatal> BaseDaemon: 7.3. inlined from ../contrib/rocksdb/options/cf_options.cc:678: rocksdb::$_7::operator()()

  [1]: https://clickhouse-test-reports.s3.yandex.net/29341/2b2bec3679df7965af908ce3f1e8e17e39bd12fe/integration_tests_flaky_check_(asan).html#fail1

And also I checked manually with TSan binary, and here is a data race
reported by TSan:

    WARNING: ThreadSanitizer: data race (pid=3356)
      Read of size 8 at 0x7b0c0008cca8 by thread T40:
        2 rocksdb::ObjectLibrary::FindEntry() const obj-x86_64-linux-gnu/../contrib/rocksdb/utilities/object_registry.cc:18:27 (clickhouse-tsan+0x1b839a6c)
        ...
        6 rocksdb::$_7::operator()() const obj-x86_64-linux-gnu/../contrib/rocksdb/options/cf_options.cc:676:32 (clickhouse-tsan+0x1b6bfa63)
        ...
        28 rocksdb::GetColumnFamilyOptionsFromMap() obj-x86_64-linux-gnu/../contrib/rocksdb/options/options_helper.cc:727:10 (clickhouse-tsan+0x1b6fffd2)
        29 DB::StorageEmbeddedRocksDB::initDb() obj-x86_64-linux-gnu/../src/Storages/RocksDB/StorageEmbeddedRocksDB.cpp:359:26 (clickhouse-tsan+0x14195e31)
        ...

      Previous write of size 8 at 0x7b0c0008cca8 by thread T41:
        ...
        9 rocksdb::ObjectLibrary::AddEntry() obj-x86_64-linux-gnu/../contrib/rocksdb/utilities/object_registry.cc:31:19 (clickhouse-tsan+0x1b8392fc)
        ...
        11 rocksdb::RegisterTableFactories()::$_0::operator()() const obj-x86_64-linux-gnu/../contrib/rocksdb/table/table_factory.cc:23:14 (clickhouse-tsan+0x1b7ea94c)
        ...
        43 rocksdb::GetColumnFamilyOptionsFromMap() obj-x86_64-linux-gnu/../contrib/rocksdb/options/options_helper.cc:727:10 (clickhouse-tsan+0x1b6fffd2)
        44 DB::StorageEmbeddedRocksDB::initDb() obj-x86_64-linux-gnu/../src/Storages/RocksDB/StorageEmbeddedRocksDB.cpp:359:26 (clickhouse-tsan+0x14195e31)

Refs: https://github.com/ClickHouse-Extras/rocksdb/pull/13
Fixes: #29341
2021-09-26 23:41:43 +03:00
Denis Zhuravlev
e06115d77f test for #23634 2021-09-26 17:24:05 -03:00
Kevin Michel
13db65f47c
Fix ReplicatedAccessStorage shutdown without startup
If ReplicatedAccessStorage startup was not executing or if it
failed before completing (for instance when ZooKeeper was not configured),
its destructor would call shutdown and try to join a missing thread.
2021-09-26 19:50:29 +02:00
alexey-milovidov
aa48698613
Merge pull request #29368 from bharatnc/ncb/fix-name-h3isResClassIII
Fix H3 function name (h3ResIsClassIII to h3IsResClassIII)
2021-09-26 20:36:36 +03:00
alexey-milovidov
5474ce01f1
Merge pull request #29380 from bharatnc/ncb/agg-func-fix-comment
Fix comments in AggregateFunctionFactory
2021-09-26 20:27:09 +03:00
alexey-milovidov
1f3117f1a2
Merge pull request #29387 from sdil/patch-1
Add GraphCDN in adopter list
2021-09-26 20:17:35 +03:00
Nikolai Kochetov
3c9e6a04bf A little bit better 2021-09-26 18:06:32 +03:00
Nikolai Kochetov
efbd8e4911 Remove ExceptionHandlingSink. 2021-09-26 17:54:59 +03:00