Commit Graph

11663 Commits

Author SHA1 Message Date
Maksim Kita
bde02c72f3 Fixed typos 2021-03-23 18:14:22 +03:00
Alexander Kuzmenkov
c9facd631c Merge remote-tracking branch 'origin/master' into HEAD 2021-03-23 17:40:13 +03:00
Alexander Kuzmenkov
0c70fe1a6d fix field get 2021-03-23 17:39:59 +03:00
Anton Popov
8a56d04714 Merge branch 'merge_tree_part_block_number' of git://github.com/ahrefs/ClickHouse into merge_21760 2021-03-23 16:47:14 +03:00
Alexander Kuzmenkov
97d5be20bb
Merge pull request #22003 from ClickHouse/aku/field-reinterpret
prevent accidental reinterpret_cast in Field::get<>
2021-03-23 15:57:26 +03:00
Anton Popov
2e1f293bd5
Merge pull request #21699 from CurtizJ/fix-map-field-conversion
Fix conversions for fields in function 'arrayElement' for type Map
2021-03-23 15:30:44 +03:00
Vitaly Baranov
46f4c60839 Small simplification in ExternalLoader. 2021-03-23 15:15:44 +03:00
Maksim Kita
890bd6f1e9 Fixed code review issues 2021-03-23 15:14:37 +03:00
alesapin
0c525b4ec4 Add an ability to run from .deb and .tgz package 2021-03-23 15:07:21 +03:00
Vitaly Baranov
090e558da4
Merge pull request #21844 from Avogar/catboost-deadlock
Fix deadlock in first catboost model execution
2021-03-23 15:01:04 +03:00
Ivan Lezhankin
be76defcfa Remove check for absent checkpoint on rollback 2021-03-23 14:59:36 +03:00
Maksim Kita
75f5679bf0 Cast to enum nullable fix 2021-03-23 14:58:00 +03:00
Alexander Tokmakov
c938f4f2fe fix 2021-03-23 14:29:29 +03:00
alesapin
36898bdc4a
Merge pull request #21142 from Jokser/unfreeze-partitions
Add ALTER TABLE UNFREEZE command.
2021-03-23 14:05:38 +03:00
Pavel Kovalenko
a92cf30b67 Code review fixes. 2021-03-23 13:33:07 +03:00
Pavel Kovalenko
d55af1fa45 Merge branch 'write-buffer-s3-better-error-handling' of github.com:Jokser/ClickHouse into write-buffer-s3-better-error-handling 2021-03-23 13:02:57 +03:00
Pavel Kovalenko
393631a753 Merge remote-tracking branch 'origin/master' into write-buffer-s3-better-error-handling
# Conflicts:
#	src/IO/WriteBufferFromS3.cpp
2021-03-23 13:00:09 +03:00
Alexey Milovidov
8d0210b510 Expose DateTime64 minmax part index in system.parts and system.parts_columns #18244 2021-03-23 01:16:41 +03:00
Alexander Kuzmenkov
49f617d8ec return the type check 2021-03-23 01:07:04 +03:00
Alexey Milovidov
ce67afd9e3 Fix bad code #18244 2021-03-23 00:49:18 +03:00
Alexey Milovidov
d8088190f9 Fix documentation for CurrentMetrics 2021-03-23 00:44:25 +03:00
Alexey Milovidov
c94841bca5 Fix UBSan report in intDiv #21769 2021-03-23 00:38:25 +03:00
Pavel Kruglov
6278a7efac Fix build 2021-03-23 00:21:52 +03:00
Alexander Kuzmenkov
d40f781b9a Merge origin/master into tmp (using imerge) 2021-03-22 23:27:18 +03:00
Alexander Kuzmenkov
77a2f03d3b prevent accidental reinterpret_cast in Field::get<> 2021-03-22 23:23:44 +03:00
alexey-milovidov
231c7266ab
Merge pull request #21954 from ucasFL/s3-log
Fix misleading log in WriteBufferFromS3
2021-03-22 23:22:44 +03:00
alesapin
ef82333089 Merge branch 'master' into jepsen_for_nukeeper 2021-03-22 23:06:26 +03:00
Alexey Milovidov
84be58453b Add function timezoneOf and fix inconsistencies 2021-03-22 22:50:04 +03:00
Pavel Kruglov
dbc5018000 Update tests for hedged requests 2021-03-22 22:18:06 +03:00
Kruglov Pavel
a215bf7812
Restart CI 2021-03-22 22:12:42 +03:00
Alexander Kuzmenkov
b0284f20c3
Merge branch 'master' into aku/laglead 2021-03-22 21:16:27 +03:00
Ivan Lezhankin
6d4d669f96 Move checkpoint to sub-buffer only from internal memory 2021-03-22 20:20:42 +03:00
Alexander Kuzmenkov
2f5dbf57b6
Merge pull request #21839 from kssenii/add-postgres-connection-pool
Add connection pool for postgres engine
2021-03-22 19:49:51 +03:00
Alexander Kuzmenkov
ac5fdda999
Merge pull request #21915 from ClickHouse/aku/window-mt-order
disable optimize_read_in_order for window functions
2021-03-22 17:21:00 +03:00
Alexander Tokmakov
fc3e11a068 fix 2021-03-22 17:09:38 +03:00
Maksim Kita
8be263062d
Merge pull request #21910 from kitaisreal/table-function-dictionary
Added table function dictionary
2021-03-22 16:08:56 +03:00
Maksim Kita
56840aba5a Fixed tests 2021-03-22 16:02:32 +03:00
Nikita Mikhaylov
330e74b665
Merge pull request #21890 from kitaisreal/polygon-dictionary-added-nullable-support
PolygonDictionary added nullable support
2021-03-22 14:49:28 +03:00
Maksim Kita
af25805a70
Merge pull request #21948 from kitaisreal/hashed-dictionary-clickhouse-source-preallocate-regression-fix
HashedDictionary clickhouse source preallocate regression fix
2021-03-22 14:11:19 +03:00
alesapin
043b3cc7b5 Fix startup when leadership changed 2021-03-22 13:45:22 +03:00
Kruglov Pavel
6ce7acb5a9
Merge pull request #21941 from azat/hedged-requests-fixes
Prevent hedged connections overlaps
2021-03-22 12:52:51 +03:00
tavplubix
0e5362a02c
Merge pull request #21903 from ClickHouse/tavplubix-patch-3
Show path to data directory of EmbeddedRocksDB
2021-03-22 12:46:53 +03:00
Nikolai Kochetov
730785f4c2
Merge pull request #21459 from ClickHouse/refactor-actions-dag
Refactor actions dag
2021-03-22 11:58:16 +03:00
alesapin
27b90007aa Merge branch 'master' into jepsen_for_nukeeper 2021-03-22 11:20:00 +03:00
feng lv
d40ffa96e2 Fix misleading log in WriteBufferFromS3 2021-03-22 05:49:41 +00:00
Maksim Kita
c5f918f198 CacheDictionaryStorage insert into default value fix 2021-03-21 19:26:06 +03:00
Maksim Kita
257e0455dd Fixed tests 2021-03-21 18:10:12 +03:00
Maksim Kita
249d4a1843 Fixed tests 2021-03-21 18:10:12 +03:00
Maksim Kita
df9223e13b PolygonDictionary added nullable support 2021-03-21 18:09:47 +03:00
Maksim Kita
fff110aa38 HashedDictionary clickhouse source preallocate regression fix 2021-03-21 17:52:33 +03:00
Azat Khuzhin
17eaddc3ab Prevent hedged connections overlaps
Some replicas may be in the establishing state, this means that hedged
connection is waiting for TablesStatusResponse, and if the connection
will not be canceled, then next user of the connection will get
TablesStatusResponse, while this is not the expected package, and you
will see:

    DB::Exception: Received from localhost:9000. DB::Exception: Received from ch-1:9000. DB::Exception: Unknown packet 9 from server ch-2:9000: While executing Remote. Stack trace:

Fix this by disconnecting connection to such replicas, note that this
should be fine in general, since they are "slow" anyway (you may wish
configure hedged requests settings to increase timeouts and similar).
2021-03-20 19:05:29 +03:00
Maksim Kita
849a980644 Updated ExternalDictionariesLoader interface with context parameter 2021-03-20 18:02:09 +03:00
kssenii
698b1b043c Fix typos check 2021-03-19 21:54:59 +00:00
kssenii
3b32c8fe9a Block on empty connection pool 2021-03-19 21:00:45 +00:00
Ivan Lezhankin
957c053f7e Fix segfault 2021-03-19 23:29:01 +03:00
Maksim Kita
95c87d4ded
Merge pull request #21884 from kitaisreal/system-dictionaries-updated
Improve system.dictionaries table
2021-03-19 22:49:49 +03:00
kssenii
e066feb81c Slightly better 2021-03-19 18:50:41 +00:00
Alexander Kuzmenkov
3166f0cbfc cleanup 2021-03-19 20:18:17 +03:00
kssenii
50743b19c4 Add one more test 2021-03-19 16:12:33 +00:00
kssenii
f374a71165 Fix 2021-03-19 16:07:53 +00:00
Alexander Kuzmenkov
590259a7a5 disable optimize_read_in_order for window functions 2021-03-19 17:29:09 +03:00
Vladimir
c8b5be636f
Merge pull request #21438 from arenadata/ADQM-170 2021-03-19 17:06:55 +03:00
Alexander Tokmakov
1845df25f3 fix possibly dangling reference to Context 2021-03-19 17:02:48 +03:00
Maksim Kita
c703ea137b
Merge pull request #21891 from kitaisreal/lru-cache-fix-exception-unsafe-element-insertion
LRUCache fix exception unsafe element insertion
2021-03-19 16:37:26 +03:00
Alexander Kuzmenkov
78c56b8913
Merge pull request #21886 from Avogar/hedged
Add profile event in hedged requests and change timeout from sec to ms.
2021-03-19 15:50:33 +03:00
Alexander Kuzmenkov
07c967b5c7
Merge pull request #21896 from ClickHouse/aku/tuple-element
fix fuzzer failure in tupleElement formatting
2021-03-19 15:49:45 +03:00
Maksim Kita
32831e37ba Added table function dictionary 2021-03-19 15:47:27 +03:00
Alexander Kuzmenkov
46e4134deb fix fuzzer failure in tupleElement formatting 2021-03-19 15:47:06 +03:00
Kruglov Pavel
0cb88fb20e
Restart tests 2021-03-19 15:00:21 +03:00
Maksim Kita
a53c90e509 Upated system.dictionaries table 2021-03-19 12:43:57 +03:00
Nikolai Kochetov
bc63d4244b
Merge pull request #21856 from ClickHouse/aggregator-no-more-keys-batch
Batch aggregation for overflow rows.
2021-03-19 11:52:55 +03:00
Maksim Kita
f340e71913
Merge pull request #21859 from kitaisreal/ddl-dictionary-current-database-name
DDL dictionary use current database name
2021-03-19 11:39:51 +03:00
kssenii
a0f717619c Remove initial filling 2021-03-19 08:33:04 +00:00
kssenii
9057aad798 Better version 2021-03-19 08:11:36 +00:00
alesapin
81c408cb7f Return meta and storage from snapshot 2021-03-19 11:08:43 +03:00
tavplubix
fc0b87c5c4
Update StorageEmbeddedRocksDB.h 2021-03-19 10:24:27 +03:00
Alexander Kuzmenkov
4bf2e94fa4 clang is too smart 2021-03-19 03:02:35 +03:00
Alexander Kuzmenkov
1beba597ca Merge remote-tracking branch 'origin/master' into HEAD 2021-03-19 02:11:08 +03:00
Alexander Kuzmenkov
6aa9039f7d float frames and lag/lead_in_frame 2021-03-19 02:05:43 +03:00
Kruglov Pavel
055242fe95
Style 2021-03-19 01:38:15 +03:00
Maksim Kita
31b7734407 LRUCache fix exception unsafe element insertion 2021-03-19 00:26:02 +03:00
alesapin
2654147113 Fix on fix 2021-03-19 00:14:43 +03:00
alesapin
0137a6baac Add test founding bug 2021-03-18 23:55:11 +03:00
kssenii
f1ef87d966 Fix 2021-03-18 20:04:54 +00:00
Pavel Kruglov
d380454044 Change read_data_timeout from sec to ms, add profile event for hedged requests and better process receiving packets 2021-03-18 20:16:17 +03:00
Alexander Kuzmenkov
c821c0c27a
Merge pull request #21761 from ClickHouse/aku/chunk-no-columns
fix incorrect number of rows for Chunks with no columns in PartialSor…
2021-03-18 17:58:09 +03:00
Alexander Kuzmenkov
f85b089292
Merge pull request #21466 from ClickHouse/aku/frame-formatting
add query formatting idempotence check to fuzzer
2021-03-18 17:57:11 +03:00
Maksim Kita
a65bfaeab3 Fixed tests 2021-03-18 17:03:22 +03:00
Nikolai Kochetov
07c5a7766c Fxi test. 2021-03-18 16:23:09 +03:00
Anton Popov
33aefa832b
Merge pull request #21818 from amosbird/datarace2
Fix arena data race in two level merge
2021-03-18 15:05:25 +03:00
Maksim Kita
c01171c626 Fixed tests 2021-03-18 14:58:43 +03:00
Nikolai Kochetov
f4cbecec27 Remove comment. 2021-03-18 14:37:45 +03:00
Nikolai Kochetov
c3c393a7aa Merge branch 'master' into refactor-actions-dag 2021-03-18 14:33:07 +03:00
Maksim Kita
0f95bcac0b DDL dictionary use current database name 2021-03-18 14:30:12 +03:00
Maksim Kita
18ed9c5c67 SSDCacheDictionary remove max_stored_keys option 2021-03-18 12:55:17 +03:00
Nikolai Kochetov
66d5968cbc Batch aggregation for overflow rows. 2021-03-18 12:31:14 +03:00
Nikolai Kochetov
c4dfd97709 Fix ActionsDAG::Index::insert 2021-03-18 10:59:48 +03:00
Pavel Kovalenko
7c0a1b9451 Cleanup destination directory during DiskCacheWrapper::moveFile() 2021-03-18 10:23:19 +03:00
kssenii
7847b78af9 Fix style, build 2021-03-17 20:49:56 +00:00
Maksim Kita
d5a1b50fd2 Updated naming 2021-03-17 22:06:46 +03:00
Maksim Kita
f140204279 Improved performance of SSDCache dictionary 2021-03-17 22:01:45 +03:00
Pavel Kruglov
bf888b7e5f Fix deadlock in first catboost model execution 2021-03-17 21:57:40 +03:00
Nikolai Kochetov
45fead9062 Fix typos 2021-03-17 21:42:42 +03:00
Nikolai Kochetov
9fdb0e667f Add comment. 2021-03-17 21:40:26 +03:00
Maksim Kita
bc22f4f6eb Updated implementation 2021-03-17 20:14:36 +03:00
Nikolai Kochetov
2c1539f641 Fix added input. 2021-03-17 20:08:30 +03:00
fuqi
cfa92f0045 fix code style 2021-03-18 00:25:43 +08:00
Nikolai Kochetov
3eba817a68 Add comments. 2021-03-17 19:08:46 +03:00
fuqi
b8edc12812 fix code style 2021-03-17 23:56:55 +08:00
Nikolai Kochetov
738cb1af62 Fix filter push down columns order. 2021-03-17 18:33:18 +03:00
Alexander Kuzmenkov
1cd9f28bd4 another way 2021-03-17 18:31:30 +03:00
kssenii
3903d59d30 Better 2021-03-17 14:34:04 +00:00
Pavel Kovalenko
e6711e936e Cleanup destination directory during DiskCacheWrapper::moveFile() 2021-03-17 17:33:13 +03:00
Pavel Kovalenko
71b36a7029 Better error handling and logging in WriteBufferFromS3 2021-03-17 17:20:55 +03:00
fuqi
e116e8d5e8 fix bug 2021-03-17 22:19:10 +08:00
kssenii
ae64a24844 Add connection pool 2021-03-17 13:55:47 +00:00
Nikita Mikhaylov
2303f1788c
Merge pull request #21807 from 3ldar-nasyrov/master
DDLWorker.cpp: fixed exceeded amount of tries typo
2021-03-17 16:04:59 +03:00
Nikita Mikhaylov
f51b41b7a4
Merge pull request #21710 from kssenii/replica-priorities
Support replicas priority for postgres dictionary source
2021-03-17 16:02:00 +03:00
Kseniia Sumarokova
f8fc4281f2
Update PostgreSQLReplicaConnection.h 2021-03-17 15:56:47 +03:00
fuqi
9ab713c2e1 optimize select final with prewhere primary key 2021-03-17 18:57:58 +08:00
fuqi
5e20ea2c33 optimize select final with prewhere primary key 2021-03-17 18:49:24 +08:00
Pavel Kovalenko
5627ae9067 Make MergeTreeData::getPartitionMatcher const 2021-03-17 12:12:55 +03:00
Nikolai Kochetov
3a3f800f6e
Merge pull request #21579 from azat/dist-query-zero-shards-fix
Fix optimize_skip_unused_shards for zero shards case
2021-03-17 11:54:08 +03:00
Nikolai Kochetov
4f1f344d4d
Merge pull request #21529 from azat/system.errors-improvements
Add last_error_time/last_error_message/last_error_stacktrace/remote columns for system.errors
2021-03-17 11:51:29 +03:00
alexey-milovidov
d02726bcac
Merge pull request #9404 from Enmk/DateTime64_extended_range
Date time64 extended range
2021-03-17 11:06:03 +03:00
Amos Bird
0640bb4cba
Fix arena data race in two level merge 2021-03-17 14:33:57 +08:00
tavplubix
a093980767
Merge pull request #21711 from kssenii/non-default-schema
Support non-default table schema for postgres storage/table-function
2021-03-17 02:10:32 +03:00
Alexey Milovidov
9ca0566132 Minor modification 2021-03-17 02:08:33 +03:00
3ldar-nasyrov
37a17749ea
fixed exceeded amount of tries typo
'retires' -> 'retries'
2021-03-16 23:17:07 +03:00
Azat Khuzhin
9dee842b60 Distinguish remote and local error info 2021-03-16 22:31:49 +03:00
Azat Khuzhin
a337691b06 Fix modernize-use-bool-literals clang-tidy warning in StorageSystemErrors 2021-03-16 22:31:49 +03:00
Azat Khuzhin
cc87bcfb63 Fix errorCodeToName() for signed integers
- https://clickhouse-test-reports.s3.yandex.net/21529/2ce2772d35eb3d81628f4d294d5799e9f05333fd/functional_stateless_tests_(address).html#fail1
- https://clickhouse-test-reports.s3.yandex.net/21529/2ce2772d35eb3d81628f4d294d5799e9f05333fd/functional_stateless_tests_(ubsan).html#fail1
- https://clickhouse-test-reports.s3.yandex.net/21529/2ce2772d35eb3d81628f4d294d5799e9f05333fd/stress_test_(address).html#fail1
2021-03-16 22:31:49 +03:00
Azat Khuzhin
efdd04c958 Drop last_ prefix for ErrorCodes::ValuePair::error_time_ms 2021-03-16 22:31:49 +03:00
Azat Khuzhin
44c9dc753d Add system.errors.last_error_stacktrace column 2021-03-16 22:31:49 +03:00
Azat Khuzhin
775f8f7682 Add system.errors.last_error_message column 2021-03-16 22:31:49 +03:00
Azat Khuzhin
c8852331a2 Add system.errors.last_error_time column 2021-03-16 22:31:49 +03:00
Azat Khuzhin
0d01eaf94f Guard ErrorCodes with mutex over atomic 2021-03-16 22:31:49 +03:00
Azat Khuzhin
7f73ac2b7a Fix ErrorCodes::Value/ErrorCode types (sigh)
Note, that system.errors already uses correct types
2021-03-16 22:31:49 +03:00
Azat Khuzhin
259e5ba88e Separate accounting of remote exceptions in system.errors 2021-03-16 22:31:46 +03:00
Azat Khuzhin
b39f8cc6ac Move ErrorCodes::increment() into module part 2021-03-16 22:31:41 +03:00
tavplubix
848bb59175
Merge pull request #21728 from ClickHouse/fix_alter_decimal
Fix alter modify for decimal columns when type size doesn't change
2021-03-16 20:01:35 +03:00
Alexander Kuzmenkov
e5bef75728 fix 2021-03-16 19:15:31 +03:00
Alexey Milovidov
637b683ae9 Fix clang-tidy 2021-03-16 18:35:14 +03:00
Ilya Golshtein
ab670a31dc AvroRowInputFormat::readPrefix inroduced 2021-03-16 17:40:59 +03:00
Pavel Kovalenko
a43c85b105 Add test for freeze/unfreeze partition with old MergeTree syntax 2021-03-16 16:36:05 +03:00
Nikolai Kochetov
0ffea300ac
Merge pull request #21643 from azat/async_socket_for_remote-cancel-fix
Fix distributed requests cancellation with async_socket_for_remote=1
2021-03-16 15:51:49 +03:00
alesapin
077a2019b6 Found first real bug with jepsen 2021-03-16 15:36:54 +03:00
Nikita Mikhaylov
1d15ed34ce
Merge pull request #21737 from excitoon-favorites/reverts3connectionpools
Reverted S3 connection pools
2021-03-16 14:40:54 +03:00
Nikita Mikhaylov
2e13c767a0
Merge pull request #21149 from nikitamikhaylov/pp-for-csv-with-names
Support parallel parsing for *WithNames types
2021-03-16 14:38:03 +03:00
Nikita Mikhaylov
7d7a2bc724
Merge pull request #21630 from nikitamikhaylov/pf-local
Parallel formatting for clickhouse-local
2021-03-16 14:37:40 +03:00