alexey-milovidov
f90a328568
Merge pull request #22109 from azat/nested-epoll-wait
...
Disable async_socket_for_remote/use_hedged_requests for buggy linux kernels
2021-03-29 05:29:10 +03:00
alexey-milovidov
c762fa2f75
Merge pull request #22129 from vdimir/issue-19303
...
Shrink totals block to 1 row for JOIN with TOTALS and arrayJoin
2021-03-29 05:26:17 +03:00
alexey-milovidov
c81d807dbc
Update JoiningTransform.cpp
2021-03-29 05:25:58 +03:00
alexey-milovidov
3bc170e5ec
Merge pull request #22122 from fastio/fix_thread_pool_name_exception
...
The thread pool name should be not longer than 15 chars
2021-03-29 05:24:55 +03:00
alexey-milovidov
7ab2890c4d
Merge pull request #22206 from ClickHouse/mmap-cache
...
Add cache for mmap IO
2021-03-29 05:17:55 +03:00
alexey-milovidov
7225293540
Merge pull request #22225 from kitaisreal/compressed-cache-buffer-fix-cache-usage
...
CachedCompressedReadBuffer fix cache usage
2021-03-29 05:15:25 +03:00
alexey-milovidov
c08289517a
Merge pull request #21766 from amosbird/indexfix
...
Fix scalar subquery index analysis
2021-03-29 02:03:27 +03:00
Alexey Milovidov
a0a3380d91
Remove useless headers
2021-03-28 22:46:45 +03:00
Maksim Kita
459d00f999
Fixed tests
2021-03-28 22:42:34 +03:00
Alexey Milovidov
2a8ac01cdb
Rename as suggested by Kita
2021-03-28 22:24:28 +03:00
Alexey Milovidov
15b41fd110
Review fix
2021-03-28 22:15:13 +03:00
Maksim Kita
608d37deed
CachedCompressedReadBuffer fix cache usage
2021-03-28 21:32:38 +03:00
Alexey Milovidov
6f9f7d118d
Fixes
2021-03-28 04:27:26 +03:00
Alexey Milovidov
50f712e198
Integrate mmap cache to the infrastructure
2021-03-28 04:10:30 +03:00
Alexey Milovidov
bdb69b8f08
Slightly better
2021-03-28 02:11:46 +03:00
Alexey Milovidov
cbf5913109
Review fixes
2021-03-28 01:57:59 +03:00
Alexey Milovidov
b3750b670f
Merge remote-tracking branch 'origin/master' into mmap-cache
2021-03-28 01:57:11 +03:00
alexey-milovidov
d07a40c675
Merge pull request #22145 from ClickHouse/speedup-none
...
Speedup codec NONE
2021-03-28 01:56:00 +03:00
alesapin
ced6d8e6bd
Merge pull request #21677 from ClickHouse/jepsen_for_nukeeper
...
Jepsen for nukeeper
2021-03-27 10:18:42 +03:00
alesapin
3b119355d2
Merge pull request #22118 from ClickHouse/try_to_fix992
...
Trying to fix my favorite test
2021-03-27 10:17:14 +03:00
Alexey Milovidov
c7d2671f32
Merge branch 'speedup-none' into mmap-cache
2021-03-27 02:42:44 +03:00
Alexey Milovidov
0e3571478d
Code review changes
2021-03-27 02:42:22 +03:00
Alexey Milovidov
bcdf3dce36
Add cache for mmapped files
2021-03-27 02:22:51 +03:00
Alexey Milovidov
1d9e23f925
Fix error
2021-03-27 01:28:57 +03:00
Alexey Milovidov
7aac5e1849
Preparation
2021-03-26 23:51:46 +03:00
Alexey Milovidov
ff891c5002
Preparation
2021-03-26 23:46:04 +03:00
alexey-milovidov
607d36dd9d
Merge pull request #22147 from azat/writers-fixes
...
Use finalize() over next() for nested writers
2021-03-26 22:05:18 +03:00
Alexander Kuzmenkov
3dea1c8c01
Merge pull request #21946 from azat/tld-fixes
...
Fix cutToFirstSignificantSubdomainCustom()/firstSignificantSubdomainCustom() for 3+level domains
2021-03-26 21:19:09 +03:00
alexey-milovidov
ac53d30e53
Merge pull request #22146 from azat/writers-uncaught-exceptions
...
Fix uncaught exception in InterserverIOHTTPHandler
2021-03-26 17:23:09 +03:00
Alexander Kuzmenkov
a455762933
Merge pull request #22117 from ucasFL/useless-code
...
remove useless code
2021-03-26 17:18:14 +03:00
alesapin
35d1443a9c
Don't wait when table shutdown called
2021-03-26 15:54:08 +03:00
tavplubix
d9ec4090d2
Merge pull request #21936 from abyss7/html-form-fix
...
Fix issues with HTMLForm::MultipartReadBuffer and PeekableReadBuffer
2021-03-26 15:35:34 +03:00
alesapin
9bdeb436c2
Fix typo
2021-03-26 15:06:36 +03:00
alesapin
2db57f0f16
Followup fix
2021-03-26 14:18:31 +03:00
alesapin
331c5b6636
Fix startup one more time
2021-03-26 13:55:39 +03:00
alesapin
ba5c151037
Fix race condition on snapshots
2021-03-26 13:20:07 +03:00
tavplubix
ae62bee939
Merge pull request #21913 from ClickHouse/fix_context_ref
...
Fix possibly dangling reference to Context
2021-03-26 10:39:13 +03:00
tavplubix
fa930d49c4
Update gtest_peekable_read_buffer.cpp
2021-03-26 10:29:58 +03:00
alexey-milovidov
f1efa33571
Merge branch 'master' into client-fix-highlight-multiline-comment
2021-03-26 02:40:11 +03:00
alexey-milovidov
0e42060523
Merge pull request #22114 from ucasFL/bar
...
Fix bar with invalid float value
2021-03-26 02:36:02 +03:00
Alexey Milovidov
e55f7e6333
Fix error
2021-03-26 02:21:59 +03:00
Alexey Milovidov
ad66c4a916
Fix error
2021-03-26 01:56:24 +03:00
Azat Khuzhin
b68517f69e
Fix cutToFirstSignificantSubdomainCustom()/firstSignificantSubdomainCustom() for 3+level domains
...
Custom TLD lists (added in #17748 ), may contain domain of the 3-d level,
however builtin TLD lists does not have such records, so it is not
affected.
Note that this will significantly increase hashtable lookups.
Fixes : #17748
2021-03-26 00:00:16 +03:00
Azat Khuzhin
30cd1c6145
Fix typo in FirstSignificantSubdomainCustomLookup name
2021-03-26 00:00:16 +03:00
Azat Khuzhin
f1907acbcd
Use finalize() over next() for nested writers
...
Refs: https://github.com/ClickHouse/ClickHouse/pull/21325#discussion_r585348309
2021-03-25 23:42:58 +03:00
Azat Khuzhin
50003e496a
Use existing logger for logging from WriteBufferFromS3 dtor
2021-03-25 23:41:03 +03:00
Azat Khuzhin
e1de960025
Fix uncaught exception in InterserverIOHTTPHandler
...
There was one more uncaught exception case [1]:
2021.03.19 18:11:00.845632 [ 17469 ] {} <Debug> InterserverIOHTTPHandler: Done processing query
...
2021.03.19 18:11:31.698961 [ 80145 ] {} <Fatal> BaseDaemon: ########################################
2021.03.19 18:11:31.699903 [ 80145 ] {} <Fatal> BaseDaemon: (version 21.4.1.6293 (official build), build id: 859E400E1C65C4702FE491420741DD8B58190002) (from thread 17469) (no query) Received signal Aborted (6)
2021.03.19 18:11:32.614075 [ 80145 ] {} <Fatal> BaseDaemon: 8. ./obj-x86_64-linux-gnu/../contrib/libcxxabi/src/cxa_handlers.cpp:89: std::terminate() @ 0x21e9b3a2 in /usr/bin/clickhouse
2021.03.19 18:11:43.831215 [ 80145 ] {} <Fatal> BaseDaemon: 10. ./obj-x86_64-linux-gnu/../src/Server/HTTP/WriteBufferFromHTTPServerResponse.cpp:201: ? @ 0x1be77038 in /usr/bin/clickhouse
2021.03.19 18:11:44.743193 [ 80145 ] {} <Fatal> BaseDaemon: 11. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:892: std::__1::allocator<DB::WriteBufferFromHTTPServerResponse>::destroy(DB::WriteBufferFromHTTPServerResponse*) @ 0x1bddd7c9 in /usr/bin/clickhouse
2021.03.19 18:11:45.283905 [ 80145 ] {} <Fatal> BaseDaemon: 12. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/__memory/allocator_traits.h:541: void std::__1::allocator_traits<std::__1::allocator<DB::WriteBufferFromHTTPServerResponse> >::__destroy<DB::WriteBufferFromHTTPServerResponse>(std::__1::integral_constant<bool, true>, std::__1::allocator<DB::WriteBufferFromHTTPServerResponse>&, DB::WriteBufferFromHTTPServerResponse*) @ 0x1bddd79d in /usr/bin/clickhouse
2021.03.19 18:11:45.805233 [ 80145 ] {} <Fatal> BaseDaemon: 13. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/__memory/allocator_traits.h:487: void std::__1::allocator_traits<std::__1::allocator<DB::WriteBufferFromHTTPServerResponse> >::destroy<DB::WriteBufferFromHTTPServerResponse>(std::__1::allocator<DB::WriteBufferFromHTTPServerResponse>&, DB::WriteBufferFromHTTPServerResponse*) @ 0x1bddd76d in /usr/bin/clickhouse
2021.03.19 18:11:46.351371 [ 80145 ] {} <Fatal> BaseDaemon: 14. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2611: std::__1::__shared_ptr_emplace<DB::WriteBufferFromHTTPServerResponse, std::__1::allocator<DB::WriteBufferFromHTTPServerResponse> >::__on_zero_shared() @ 0x1bddd525 in /usr/bin/clickhouse
2021.03.19 18:11:46.579263 [ 80145 ] {} <Fatal> BaseDaemon: 15. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2476: std::__1::__shared_count::__release_shared() @ 0x119490ed in /usr/bin/clickhouse
2021.03.19 18:11:46.790912 [ 80145 ] {} <Fatal> BaseDaemon: 16. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2517: std::__1::__shared_weak_count::__release_shared() @ 0x1194908f in /usr/bin/clickhouse
2021.03.19 18:11:47.277990 [ 80145 ] {} <Fatal> BaseDaemon: 17. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:3213: std::__1::shared_ptr<DB::WriteBufferFromHTTPServerResponse>::~shared_ptr() @ 0x1bdd75fc in /usr/bin/clickhouse
2021.03.19 18:11:47.649213 [ 80145 ] {} <Fatal> BaseDaemon: 18. ./obj-x86_64-linux-gnu/../src/Server/InterserverIOHTTPHandler.h:34: DB::InterserverIOHTTPHandler::Output::~Output() @ 0x1bdf6bd5 in /usr/bin/clickhouse
2021.03.19 18:11:47.921556 [ 80145 ] {} <Fatal> BaseDaemon: 19. ./obj-x86_64-linux-gnu/../src/Server/InterserverIOHTTPHandler.cpp:154: DB::InterserverIOHTTPHandler::handleRequest(DB::HTTPServerRequest&, DB::HTTPServerResponse&) @ 0x1bdf653f in /usr/bin/clickhouse
[1]: https://clickhouse-test-reports.s3.yandex.net/0/78c56b891383288cf3a893139e796fc87476412e/stress_test_(debug).html
Since in case of no errors during processing we should call finalize, to
ensure that it will not be called from dtor.
Fixes : #22046
Fixes : #22067
2021-03-25 23:41:03 +03:00
Azat Khuzhin
48fe30e5a2
Add missing logging for exception in InterserverIOHTTPHandler
2021-03-25 23:41:03 +03:00
Azat Khuzhin
8e445c5e55
Disable async_socket_for_remote/use_hedged_requests for buggy linux kernels
...
async_socket_for_remote/use_hedged_requests uses nested epolls, which
may not be reliable in 5.5+ [1], but it has been fixed in shortly in
5.7+ [2] or
5.6.13+.
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=339ddb53d373
[2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0c54a6a44bf3
2021-03-25 23:39:30 +03:00
Alexey Milovidov
a8ce138788
Speedup codec NONE
2021-03-25 23:08:47 +03:00