Commit Graph

116409 Commits

Author SHA1 Message Date
johanngan
be8e048799 Revert invalid RegExpTreeDictionary optimization
This reverts the following commits:
- e77dd81036
- e8527e720b

Additionally, functional tests are added.

When scanning complex regexp nodes sequentially with RE2, the old code
has an optimization to break out of the loop early upon finding a leaf
node that matches. This is an invalid optimization because there's no
guarantee that it's actually a VALID match, because its parents might
NOT have matched. Semantically, a user would expect this match to be
discarded and for the search to continue. Instead, since we skipped
matching after the first false positive, subsequent nodes that would
have matched are missing from the output value. This affects both
dictGet and dictGetAll.

It's difficult to distinguish a true positive from a false positive
while looping through complex_regexp_nodes because we would have to scan
all the parents of a matching node to confirm a true positive. Trying to
do this might actually end up being slower than just scanning every
complex regexp node, because complex_regexp_nodes is only a subset of
all the tree nodes; we may end up duplicating work with scanning
that Vectorscan has already done, depending on whether the parent nodes
are "simple" or "complex". So instead of trying to fix this
optimization, just remove it entirely.
2023-06-06 16:28:44 -05:00
Kruglov Pavel
5af1819143
Merge pull request #50586 from Avogar/better-avro-decimal
Better support for avro decimals
2023-06-06 19:40:59 +02:00
Raúl Marín
473743b49f
Disable pure parallel replicas if trivial count optimization is possible (#50594) 2023-06-06 18:38:32 +02:00
alesapin
36d298ceef
Fix commit for DiskObjectStorage (#50599) 2023-06-06 14:45:58 +02:00
Nikita Mikhaylov
e87348010d
Rework loading and removing of data parts for MergeTree tables. (#49474)
Co-authored-by: Sergei Trifonov <sergei@clickhouse.com>
2023-06-06 14:42:56 +02:00
Kseniia Sumarokova
175515b9ec
Merge pull request #50583 from kssenii/fix-logical-error-in-try-reserve-2
Fix logical error in stress test (Not enough space to add ...)
2023-06-06 12:14:46 +02:00
Sema Checherinda
990652119e
Merge pull request #50361 from nickitat/fail_perf_on_too_many_slow
Fail perf tests when too many queries slowed down
2023-06-06 11:33:04 +02:00
Robert Schulze
2e16b497f5
Merge pull request #50519 from ClibMouse/feature/uuid-serialization
Implement endianness-independent serialization for UUID
2023-06-06 09:18:19 +02:00
robot-clickhouse-ci-1
4cf5a13e5b
Merge pull request #50160 from ClickHouse/prio-runners
Refactor lambdas, prepare to prio runners
2023-06-06 07:29:28 +02:00
Michael Kolupaev
9f80900d6f Changes related to an internal feature 2023-06-05 18:20:38 -07:00
Nikolay Degterinsky
b1947b2c93
Merge pull request #50435 from evillique/sigquit-handler
Add signal handler for SIGQUIT
2023-06-06 03:13:56 +02:00
Sergei Trifonov
a1b961ee19
Merge pull request #50492 from ClickHouse/50422-add-systemuser_processes-system-table
Add `system.user_processes` table
2023-06-05 21:23:00 +02:00
ltrk2
35439a8b06 Use reverse iterator for little-endian version 2023-06-05 10:47:52 -07:00
robot-ch-test-poll2
5d0522cfa6
Merge pull request #50597 from DanRoscigno/master
add video to inverted indices docs
2023-06-05 18:23:09 +02:00
Nikolay Degterinsky
fca09ae9b9
Merge branch 'master' into sigquit-handler 2023-06-05 17:55:15 +02:00
DanRoscigno
654aee209f add video 2023-06-05 11:55:04 -04:00
Kseniia Sumarokova
0832cb2d7a
Update Metadata.h 2023-06-05 17:51:12 +02:00
robot-ch-test-poll
e1889ffb3a
Merge pull request #50529 from kitaisreal/function-if-constant-folding
Function if constant folding
2023-06-05 17:29:29 +02:00
Han Fei
f136945ea4
Merge pull request #50255 from johanngan/regexptree-arrays
Add dictGetAll function to collect multiple matches in RegExpTreeDictionary
2023-06-05 17:20:24 +02:00
ltrk2
3938309374 Implement review comments 2023-06-05 08:18:03 -07:00
Kseniia Sumarokova
2b3db1d33c
Update Metadata.cpp 2023-06-05 17:05:06 +02:00
avogar
aa20935cb9 Better 2023-06-05 12:45:14 +00:00
avogar
55345d5a25 Fix exception message 2023-06-05 12:43:38 +00:00
avogar
4f0adf5f61 Better support for avro decimals 2023-06-05 12:40:54 +00:00
János Benjamin Antal
c3d6e4c915 Fix docs 2023-06-05 12:36:19 +00:00
János Benjamin Antal
5cb2d8b4e2 Update failing tests 2023-06-05 12:32:25 +00:00
János Benjamin Antal
28eb9562b8 Remove the usage of SHOW USER PROCESSES from tests 2023-06-05 12:29:11 +00:00
János Benjamin Antal
90e9df9109 Revert "Add SHOW USER PROCESSES query"
This reverts commit d28b4181e9.
2023-06-05 12:27:46 +00:00
János Benjamin Antal
1713dbe631 Grant select on system tables to test user 2023-06-05 12:07:05 +00:00
robot-ch-test-poll4
13fc7c6c55
Merge pull request #50581 from ismailakpolat/patch-1
Update rabbitmq.md
2023-06-05 13:42:05 +02:00
Kruglov Pavel
59f27014f7
Merge pull request #50474 from valentinalexeev/patch-1
Additional error information when JSON is too large
2023-06-05 13:31:21 +02:00
Dmitry Novik
8e51a15606
Merge pull request #50234 from azat/fix-nested-dist-cte
Fix nested distributed SELECT in WITH clause
2023-06-05 13:18:50 +02:00
kssenii
58932b81cc Merge remote-tracking branch 'upstream/master' into fix-logical-error-in-try-reserve-2 2023-06-05 13:07:12 +02:00
kssenii
f3a8517a44 Fix 2023-06-05 13:07:07 +02:00
alesapin
5e8ecf8f22
Merge pull request #50548 from ClickHouse/move_async_iterator_to_object_storage
Add async iteration to object storage
2023-06-05 12:30:28 +02:00
János Benjamin Antal
e140cad10c Clean up includes 2023-06-05 10:18:36 +00:00
János Benjamin Antal
256f713d6b Add docs for system.user_processes 2023-06-05 10:18:25 +00:00
János Benjamin Antal
a224c8936c Fix minor issues in documentation 2023-06-05 10:18:07 +00:00
ismailakpolat
3082029406
Update rabbitmq.md
Duplicate parameter name in definition
2023-06-05 13:03:17 +03:00
János Benjamin Antal
4225cab2e8 Rewrite bugprone shell script command 2023-06-05 08:34:25 +00:00
vdimir
2989cd1d35
Merge pull request #50484 from DanRoscigno/docs-direct-join 2023-06-05 10:16:07 +02:00
Alexey Milovidov
afdf7eaed7
Merge pull request #50558 from ClickHouse/remove-flaky-test
Remove flaky test
2023-06-05 11:14:03 +03:00
Alexey Milovidov
fb4e950f9f
Merge pull request #50546 from auxten/patch-1
Resize BufferFromVector underlying vector only pos_offset == vector.size()
2023-06-05 11:12:57 +03:00
Alexey Milovidov
5d26b0cf7c
Merge pull request #50550 from cmsxbc/misc-darwin-build
skip extracting darwin toolchain in builder when unncessary
2023-06-05 11:11:34 +03:00
Alexey Milovidov
477446fd53
Merge pull request #50574 from azat/revert-50539-skim-msan
Revert "Disable skim (Rust library) under memory sanitizer"
2023-06-05 11:10:55 +03:00
Maksim Kita
c860db0fb7 Fixed tests 2023-06-05 10:32:46 +03:00
Azat Khuzhin
f1058d2d9d Revert "Disable skim (Rust library) under memory sanitizer" 2023-06-05 09:08:01 +02:00
Nikolay Degterinsky
802df208a6
Merge branch 'master' into sigquit-handler 2023-06-05 08:19:04 +02:00
johanngan
5e1c93c9c8 Add dictGetAll to spell-check dictionary 2023-06-04 23:46:04 -05:00
johanngan
8d4206df66 Review comments: Use constexpr-if in more places
Also add a comment about the apparent lack of type checking on the limit
column.
2023-06-04 23:46:04 -05:00