Commit Graph

19299 Commits

Author SHA1 Message Date
Veloman Yunkan
3e96f32833 Fixed the bug introduced by PR#3144
The pre-existing optimization in the function
JSONEachRowRowInputStream::readColumnName() (that was extracted
during the refactoring step of PR#3144) imposed a restriction
on its usage - reading from the input stream might invalidate the return
value of that function, and this is what happenned in readJSONObject()
after the call to skipColonDelimiter().

One way of fixing the problem while preserving the original optimization
intact would be to defer the call to skipColonDelimiter() until the
variable name_ref was fully consumed, however that would result in worse
code (skipColonDelimiter() would need to be called in three different
places where it doesn't really belong).

Therefore I preferred to slightly weaken the optimization by always
copying the key name into the current_column_name data member.
2018-09-26 11:27:04 +00:00
chertus
69dd660919 fix crash on decimal division by zero [issue-3221] 2018-09-26 14:25:50 +03:00
decaseal
963988ddf2
Update firstSignificantSubdomain function
Add "biz" domain to list of "insignificant" second-level domains
2018-09-26 12:39:04 +03:00
Marek Vavruša
cbbcb6d9df Formats/CapnProtoRowInputStream: support Nested and Tuple, fix alignment issues
This updated contrib/capnproto to a newer version that fixes problems with
unaligned access to message frames.

It also adds support for parsing Struct types as Tuple (named or unnamed),
and Nested array types.

The `struct X { a @0 :UInt64; b @1 :Text }` in Cap'nProto is equivalent to
`x Tuple(a UInt64, b String)` in ClickHouse.

Arrays of Struct types such as `y List(X)` are equivalent to `y Nested(a UInt64, b String)`.
2018-09-25 22:51:35 -07:00
Marek Vavruša
ea32434888 Storages/Kafka: fixed deadlocks, moved to background pool
This fixes two deadlocks in Kafka engine found previously:
* When exception is thrown before starting reading, consumer
  was never returned to the storage. Now it is claimed only
  when actually starting reading.
* Fixed lockup on deinitialization when consumer only unsubscribed,
  but didn't close, and the endine then timeouted when waiting for
  consumer destruction.

This also moves the stream thread to background worker pool.
The reason for that is that it will compete with other tasks for
time, so it will form a backpressure on insertion when the system
is busy.
2018-09-25 22:51:07 -07:00
alexey-milovidov
b326b95592
Merge pull request #3205 from yandex/order-by-remerge
Added remerge step to process ORDER BY with LIMIT when memory usage is high
2018-09-26 06:32:03 +03:00
Alexey Milovidov
33e4865240 Adjusted test #3205 2018-09-26 05:33:29 +03:00
Alexey Milovidov
57822ad592 Improvement #3205 2018-09-26 04:30:07 +03:00
Alexey Milovidov
042536177d Merge branch 'master' into order-by-remerge 2018-09-26 04:24:35 +03:00
alexey-milovidov
7f885b0d31
Merge pull request #3213 from yandex/every_function_in_own_file_5
Every function in its own file, part 5
2018-09-26 04:23:32 +03:00
Alexey Milovidov
b11a84b895 Merge branch 'master' of github.com:yandex/ClickHouse into every_function_in_own_file_5 2018-09-26 03:36:20 +03:00
Alexey Milovidov
0e7caa05fa Every function in its own file, part 5 [#CLICKHOUSE-2] 2018-09-26 03:32:38 +03:00
Alexey Milovidov
27b7654abc Every function in its own file, part 5 [#CLICKHOUSE-2] 2018-09-26 03:31:40 +03:00
alexey-milovidov
ee2363dc73
Merge pull request #3211 from 4ertus2/decimal
fix decimal to int, int to decimal convertion [issue-3177]
2018-09-26 00:25:22 +03:00
alexey-milovidov
0dd4bb43a3
Update string_search_functions.md 2018-09-25 21:19:15 +03:00
alexey-milovidov
c449319a3b
Update string_search_functions.md 2018-09-25 21:18:50 +03:00
chertus
96ceca6c05 fix decimal to int, int to decimal convertion [issue-3177] 2018-09-25 19:03:50 +03:00
Nikolai Kochetov
d526859011 Added cache for low cardinality function result. [#CLICKHOUSE-3904] 2018-09-25 16:48:52 +03:00
zhang2014
b887ec8e98 ISSUES-3145 support qualified asterisk 2018-09-25 10:42:51 +08:00
alexey-milovidov
002331be1b
Merge pull request #3204 from CurtizJ/CLICKHOUSE-3527
Better code in #3101.
2018-09-25 00:28:11 +03:00
Alexey Milovidov
5cc8e802d5 Added test #3205 2018-09-25 00:02:40 +03:00
Alexey Milovidov
9fbde09725 Memory tracker: added watermark logging #3205 2018-09-24 23:57:10 +03:00
Alexey Milovidov
81e2fe14e5 Better messages #3205 2018-09-24 23:30:02 +03:00
Alexey Milovidov
8e7c6598e8 Added remerge step to process ORDER BY with LIMIT when memory usage is high #3179 2018-09-24 23:07:30 +03:00
Alexey Milovidov
17b8e20922 Failover for hosts with missing DNS records while connecting to ZooKeeper #3201 2018-09-24 22:09:12 +03:00
CurtizJ
d0ed96aa04 better code 2018-09-24 22:08:11 +03:00
Alexey Milovidov
5c386ea3cd Always write query_id field in log #3203 2018-09-24 21:44:40 +03:00
Alexey Milovidov
73f68b5ee4 Miscellaneous [#CLICKHOUSE-2] 2018-09-24 21:44:09 +03:00
Alexey Milovidov
5f6328646a utils/check-style/check-style -n #3101 2018-09-24 21:02:25 +03:00
alexey-milovidov
b6c7d71a03
Merge pull request #3101 from CurtizJ/CLICKHOUSE-3527
CLICKHOUSE-3527 Fix race while parallel ddl queries
2018-09-24 20:59:57 +03:00
robot-clickhouse
ca465cd20b Auto version update to [18.14.0] [54409] 2018-09-24 20:52:21 +03:00
zhang2014
f3dcc2ef41 ISSUES-3145 support qualified asterisk 2018-09-24 23:28:18 +08:00
chertus
f09970ff70 add test for inner join [CLICKHOUSE-4001] 2018-09-24 16:55:26 +03:00
alexey-milovidov
4185351c8d
Merge pull request #3197 from yandex/fix_odbc_table_function
Fix odbc table function
2018-09-23 18:48:02 +03:00
alesapin
7c47644f7b Reuse base class function 2018-09-23 12:16:16 +03:00
Alexey Milovidov
bb654ff307 Fixed trash #3195 2018-09-22 21:12:14 +03:00
Alexey Milovidov
b972742f9a Fixed bad code; updated docs #3195 2018-09-22 21:07:27 +03:00
Alexey Milovidov
a8ad6dda22 Better build script #3195 2018-09-22 19:13:13 +03:00
alexey-milovidov
76cb9ff873
Update Context.cpp 2018-09-22 18:22:54 +03:00
Alexey Milovidov
c538c1745c Updated README #3195 2018-09-22 18:12:48 +03:00
Alexey Milovidov
9cd7be8228 Mysqlclient, ssl, unixodbc are not needed for build anymore #3195 2018-09-22 18:08:59 +03:00
alexey-milovidov
2dc29f5e4c
Merge pull request #3195 from yvlasenko/docker_opt
Docker sugar + permissions fix
2018-09-22 18:07:18 +03:00
alesapin
2aee8a5814 Fix odbc table function 2018-09-22 17:58:03 +03:00
Yurii Vlasenko
470b9fe772 revert CH ver 2018-09-22 01:05:12 +03:00
Yurii Vlasenko
850d58c33b docker sugar 2018-09-22 01:00:57 +03:00
alexey-milovidov
65f7c390f0
Merge pull request #3159 from zhang2014/fix/ISSUES-3134
ISSUES-3134 fix merge and distributed engine query stage
2018-09-22 00:09:06 +03:00
alexey-milovidov
433e8cce26
Merge pull request #3194 from yandex/fix-replica-cyclic-fetch
Fix cyclical failed fetches when merges don't produce identical result
2018-09-21 23:05:40 +03:00
alexey-milovidov
babc145f5f
Merge pull request #3188 from yandex/fix_segfault_3151
Add isState for array function combinator
2018-09-21 22:30:15 +03:00
alexey-milovidov
d09b0e6f40
Merge pull request #3190 from cekc/patch-1
fix typo in BaseDaemon doc
2018-09-21 22:29:25 +03:00
Alexey Zatelepin
9ee53caee0 add test [#CLICKHOUSE-2837] 2018-09-21 19:45:57 +03:00