thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-25 09:02:00 +00:00
Code Issues Packages Projects Releases Wiki Activity
65,486 Commits 9,170 Branches 1,781 Tags 2.1 GiB
c65ae8ac31
Commit Graph

65486 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Azat Khuzhin
c65ae8ac31 Do not check writeRetry errors in OwnSplitChannel 
Should fix PVS warning:

  "There are identical sub-expressions '!writeRetry(2, "\n")' to the left and to the right of the '||' operator."
 2021-06-07 09:40:29 +03:00
Azat Khuzhin
38c7056ecc Rewrite 01594_too_low_memory_limits 
After #24483 had been merged the only place where the allocation may
fail is the insert into PODArray in DB::OwnSplitChannel::log, but this
MR ignores the errors in this function, so to check new behaviour
separate server is required.
 2021-06-07 09:38:15 +03:00
Azat Khuzhin
ac1ff225a3 Revert "Cleanup 01594_too_low_memory_limits (by using clientError)" 
--testmode can't be used since this disables logging while the
failed allocation comes from:

    2021.06.04 09:54:49.576479 [ 31070 ] {} <Error> ServerErrorHandler: Code: 241, e.displayText() = DB::Exception: Memory limit (for query) exceeded: would use 2.01 MiB (attempt to allocate chunk of 4096 bytes), maximum: 1.00 B, Stack trace (when copying this message, always include the lines below):

    0. /src/ch/clickhouse/.cmake/../contrib/libcxx/include/exception:133: std::exception::capture() @ 0xe2d88 in /src/ch/clickhouse/.cmake/programs/server/libclickhouse-server-libd.so
    1. /src/ch/clickhouse/.cmake/../contrib/libcxx/include/exception:111: std::exception::exception() @ 0x1e9b92 in /src/ch/clickhouse/.cmake/contrib/poco-cmake/Foundation/lib_poco_foundationd.so
    2. /src/ch/clickhouse/.cmake/../contrib/poco/Foundation/src/Exception.cpp:28: Poco::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0x1dd943 in /src/ch/clickhouse/.cmake/contrib/poco-cmake/Foundation/lib_poco_foundationd.so
    3. /src/ch/clickhouse/.cmake/../src/Common/Exception.cpp:59: DB::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, bool) @ 0x2aaffd in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    4. /src/ch/clickhouse/.cmake/../src/Common/Exception.h:40: DB::Exception::Exception<char const*, char const*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, long&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*&&, char const*&&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&&, long&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&&) @ 0x2ebef0 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    5. /src/ch/clickhouse/.cmake/../src/Common/MemoryTracker.cpp:226: MemoryTracker::allocImpl(long, bool) @ 0x2eac82 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    6. /src/ch/clickhouse/.cmake/../src/Common/MemoryTracker.cpp:0: MemoryTracker::allocImpl(long, bool) @ 0x2eae3e in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    7. /src/ch/clickhouse/.cmake/../src/Common/CurrentMemoryTracker.cpp:47: CurrentMemoryTracker::(anonymous namespace)::allocImpl(long, bool) @ 0x27b621 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    8. /src/ch/clickhouse/.cmake/../src/Common/CurrentMemoryTracker.cpp:61: CurrentMemoryTracker::alloc(long) @ 0x27b541 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    9. /src/ch/clickhouse/.cmake/../src/Common/Allocator.h:96: Allocator<false, false>::alloc(unsigned long, unsigned long) @ 0x274b71 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    10. /src/ch/clickhouse/.cmake/../src/Common/PODArray.h:120: void DB::PODArrayBase<4ul, 4096ul, Allocator<false, false>, 15ul, 16ul>::alloc<>(unsigned long) @ 0x305af3 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    11. /src/ch/clickhouse/.cmake/../src/Common/PODArray.h:146: void DB::PODArrayBase<4ul, 4096ul, Allocator<false, false>, 15ul, 16ul>::realloc<>(unsigned long) @ 0x305cbb in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    12. /src/ch/clickhouse/.cmake/../src/Common/PODArray.h:182: void DB::PODArrayBase<4ul, 4096ul, Allocator<false, false>, 15ul, 16ul>::reserveForNextSize<>() @ 0x306010 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    13. /src/ch/clickhouse/.cmake/../src/Common/PODArray.h:0: void DB::PODArray<unsigned int, 4096ul, Allocator<false, false>, 15ul, 16ul>::push_back<unsigned int>(unsigned int&&) @ 0x5423a6a in /src/ch/clickhouse/.cmake/src/AggregateFunctions/libclickhouse_aggregate_functionsd.so
    14. /src/ch/clickhouse/.cmake/../src/Columns/ColumnVector.h:280: DB::ColumnVector<unsigned int>::insert(DB::Field const&) @ 0x3c6422 in /src/ch/clickhouse/.cmake/src/libclickhouse_columnsd.so
    15. /src/ch/clickhouse/.cmake/../base/loggers/OwnSplitChannel.cpp:60: DB::OwnSplitChannel::logSplit(Poco::Message const&) @ 0xa2833 in /src/ch/clickhouse/.cmake/base/loggers/libloggersd.so
    16. /src/ch/clickhouse/.cmake/../base/loggers/OwnSplitChannel.cpp:35: DB::OwnSplitChannel::log(Poco::Message const&) @ 0xa2588 in /src/ch/clickhouse/.cmake/base/loggers/libloggersd.so

This reverts commit 0cecc754709cc774c90269a1dc8653eac8725341.
 2021-06-07 09:38:15 +03:00
Azat Khuzhin
3d9218dbfa Use writeRetry in case of exception during writing to the log 2021-06-07 09:38:15 +03:00
Azat Khuzhin
8ec874dc33 Add writeRetry helper 2021-06-07 09:38:15 +03:00
Azat Khuzhin
b9c869871b Block memory tracking during catching exceptions in OwnSplitChannel 2021-06-07 09:38:15 +03:00
Azat Khuzhin
d5767da5fd Cleanup 01594_too_low_memory_limits (by using clientError) 2021-06-07 09:38:15 +03:00
Azat Khuzhin
0d34cb655c Disable 01594_too_low_memory_limits under sanitizers 2021-06-07 09:38:15 +03:00
Azat Khuzhin
89a4d886bf Suppress exceptions from logger code 
Some code does not expect from the logger code to throw, and this can
lead to the problems like:
- marking distributed batch as broken (in
  StorageDistributedDirectoryMonitor)
- some MergeTree code may also be affected.

So instead of throwing the exception, it will be logged to the stderr
(if it is possible).
 2021-06-07 09:38:15 +03:00
alexey-milovidov
be66ecacef
Merge pull request #24918 from cn-ds/patch-1 
Improve documentation about <remote_url_allow_hosts>
 2021-06-07 03:01:17 +03:00
alexey-milovidov
cc5755b1a4
Merge pull request #25002 from ClickHouse/compression-codecs-refactoring 
Compression codecs refactoring
 2021-06-07 02:54:24 +03:00
alexey-milovidov
d54aaca718
Merge pull request #25007 from ClickHouse/fix-integration-test-s3 
Maybe Minio starts for too long in tests
 2021-06-07 02:53:28 +03:00
alexey-milovidov
8f7ffcd47c
Merge pull request #25012 from ClickHouse/fix-bad-test-2 
Fix bad test
 2021-06-07 01:37:47 +03:00
mergify[bot]
f84ac23951
Merge branch 'master' into compression-codecs-refactoring 2021-06-06 18:02:39 +00:00
mergify[bot]
da637c08b2
Merge branch 'master' into fix-bad-test-2 2021-06-06 18:02:37 +00:00
mergify[bot]
e9d01d7e4f
Merge branch 'master' into fix-integration-test-s3 2021-06-06 18:02:34 +00:00
alexey-milovidov
d9ad03aec1
Merge pull request #25021 from ClickHouse/revert-24388-initialquerystarttime 
Revert "Add initial_query_start_time to query log"
 2021-06-06 20:57:13 +03:00
alexey-milovidov
295dc6b517
Revert "Add initial_query_start_time to query log" 2021-06-06 20:57:04 +03:00
alexey-milovidov
81a12404c7
Merge pull request #24940 from azat/settings-limit-offset-fix 
Fix limit/offset settings for distributed queries (ignore on the remote nodes)
 2021-06-06 17:39:15 +03:00
alexey-milovidov
c3baba2287
Merge pull request #24930 from amosbird/distributedfix 
Allow shard pruning with IN literal
 2021-06-06 17:36:47 +03:00
alexey-milovidov
f59f444ac6
Merge pull request #24957 from ClickHouse/fix_endless_wait 
Fix endless wait in replica clone
 2021-06-06 16:50:08 +03:00
Alexey Milovidov
9f1b7afd7c Fix bad test 2021-06-06 16:38:53 +03:00
alexey-milovidov
db384a163c
Merge pull request #24388 from amosbird/initialquerystarttime 
Add initial_query_start_time to query log
 2021-06-06 16:15:37 +03:00
alexey-milovidov
8b99fa049e
Merge pull request #24967 from filimonov/fix_port_in_kafka_test 
Fix the test after #20393
 2021-06-06 15:11:49 +03:00
alexey-milovidov
a5ca7ce354
Merge pull request #24999 from azat/clickhouse-test-log-comment-fix 
clickhouse-test: fix log_comment for .sql tests
 2021-06-06 12:52:32 +03:00
Alexey Milovidov
b146524fdb Maybe Minio starts for too long in tests 2021-06-06 12:38:49 +03:00
Maksim Kita
aaaf28d7ef
Merge pull request #25001 from kitaisreal/dictionaries-loader-dictionary-configuration-creation-fix 
DictionaryLoader unnecessary dictionary configuration creation fix
 2021-06-06 10:43:20 +03:00
Alexey Milovidov
8d85145725 Remove experimental compression codecs 2021-06-06 02:26:52 +03:00
Alexey Milovidov
31f02b3780 Remove unused code 2021-06-06 02:21:42 +03:00
Alexey Milovidov
17962459f5 Merge branch 'master' into issue-16775 2021-06-06 02:18:28 +03:00
Maksim Kita
a7ca1f5999 DictionaryLoader unnecessary dictionary configuration creation fix 2021-06-05 23:37:24 +03:00
Ilya Yatsishin
f2eed22ebd
Merge pull request #24954 from ClickHouse/fix_integration_test 2021-06-05 20:18:33 +03:00
Ilya Yatsishin
3092ec7c7e
Merge pull request #24959 from qoega/no-more-subprocess-call 2021-06-05 19:41:52 +03:00
Azat Khuzhin
95630a5c9d clickhouse-test: fix log_comment for .sql tests 
Broken in: #23486
 2021-06-05 12:59:58 +03:00
Vladimir
fa4f145693
Merge pull request #24970 from presto53/master 2021-06-05 12:31:36 +03:00
robot-clickhouse
49280940ee Update version_date.tsv after release 21.6.3.14 2021-06-05 03:03:36 +03:00
alexey-milovidov
33a2f458fc
Merge pull request #24989 from ClickHouse/changelog-21.6 
Add changelog for 21.6
 2021-06-05 02:37:24 +03:00
Alexey Milovidov
967b531a16 Add changelog for 21.6 2021-06-05 02:09:57 +03:00
tavplubix
945071e1c3
Merge pull request #24968 from ClickHouse/tavplubix-patch-2 
Try fix `test_consistent_parts_after_clone_replica`
 2021-06-05 01:15:23 +03:00
alexey-milovidov
3a00058df6
Merge pull request #24987 from ClickHouse/rename-simple-backport 
Cleanup changelog script
 2021-06-05 01:14:01 +03:00
Alexey Milovidov
2255ea7f51 Add README 2021-06-05 01:13:29 +03:00
Alexey Milovidov
23363a54fa Add README 2021-06-05 01:12:38 +03:00
Alexey Milovidov
17530a6e75 Add progress log 2021-06-05 01:10:08 +03:00
Alexey Milovidov
fc8a8ae241 Rename a directory with changelog script 2021-06-05 01:06:12 +03:00
Alexey Milovidov
86c216971a Merge branch 'master' into rename-simple-backport 2021-06-05 01:03:16 +03:00
alexey-milovidov
bb02eefed1
Merge pull request #24861 from MyroTk/tfs_bigints_snapshots 
Testflows Extended Precision Data Type testing - Adding snapshots for output comparison.
 2021-06-04 23:27:24 +03:00
presto53
c362e35196
Update s3.md 2021-06-04 17:41:59 +03:00
presto53
53a21b44ea
Merge pull request #1 from presto53/presto53-fix-s3-doc-usage-typo 
Fix typo in usage example in s3.md
 2021-06-04 17:37:08 +03:00
presto53
e9bd18ebfb
Update s3.md 2021-06-04 17:35:15 +03:00
Nikita Mikhaylov
af32228e9f
Merge pull request #24523 from Algunenano/i24461 
Fix crash when chaining uniqStates
 2021-06-04 17:26:34 +03:00