Commit Graph

140429 Commits

Author SHA1 Message Date
Azat Khuzhin
cf1451ecde Fix possible CHECKSUM_DOESNT_MATCH during replicated fetches
Previously HTTP server does not tries to send exception if something had
been written to the client already, but after rewriting to "zero-copy"
HTTP implementation (back in #19516) this got broken, and you can get
pretty "dangerous" at least at first glance errors, like:
- Malformed chunked encoding
- or most likely to CHECKSUM_DOESNT_MATCH error

This is not crucial because it will never pass checksum checks, but
still icky. So let's fix it.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-28 07:34:08 +02:00
Azat Khuzhin
478ba92ddd Improve error message on checksum mismatch during fetches
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-28 07:34:07 +02:00
Azat Khuzhin
43dcc012f4 Add a test for fetches failures
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-28 07:34:07 +02:00
Azat Khuzhin
d278866d52 Add copy_data_failpoint failpoint
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-28 07:34:07 +02:00
alesapin
5139ef7b91
Merge pull request #63077 from ClickHouse/fix_stateful_azure
Fix stateful tests
2024-04-27 22:37:46 +00:00
Alexey Milovidov
f7b6a1149a
Merge pull request #61357 from canhld94/fix_count
Fix parser error when using COUNT(*) with FILTER clause
2024-04-27 21:53:47 +00:00
Alexey Milovidov
d9fa3fdceb
Merge pull request #63069 from azat/tests/integration-old-analyzer
Fix integration tests with old analyzer (and fix some leftovers of enabling it)
2024-04-27 21:43:07 +00:00
Alexey Milovidov
753dd30a40
Merge pull request #63070 from azat/tests/dist-inter-server-backward
Get back test for old inter-server mode (DBMS_MIN_REVISION_WITH_INTERSERVER_SECRET non-v2)
2024-04-27 21:42:11 +00:00
alesapin
c7a6af3c4a Fix stateful 2024-04-27 21:47:48 +02:00
Nikita Taranov
c14fb847da
Merge pull request #62047 from azat/dist/fix-IN-rewrite
Fix optimize_skip_unused_shards_rewrite_in for composite sharding key
2024-04-27 18:39:34 +00:00
alesapin
9c3d40749b
Merge pull request #62565 from ClickHouse/ci_add_azure_tests
CI: Add tests with Azure storage
2024-04-27 15:13:42 +00:00
alesapin
8a2ca8513d Temporary remove azure from template 2024-04-27 16:58:21 +02:00
Alexey Milovidov
f6d443c927
Merge pull request #62041 from azat/clickhouse-test-no-reference-fix
Fix clickhouse-test in case of missing .reference file
2024-04-27 14:55:54 +00:00
Alexey Milovidov
58792a1935
Merge pull request #60302 from azat/INSERT-receive-timeout
Change back how receive_timeout is handled for INSERTs
2024-04-27 14:55:28 +00:00
Alexey Milovidov
49ffacc9cd
Merge pull request #63071 from ClickHouse/alexey-milovidov-patch-8
Make a statement about HDFS
2024-04-27 14:13:26 +00:00
Alexey Milovidov
06d21ab028
Merge pull request #62420 from ClickHouse/too-many-parts-in-move-partition
Add back-pressure for `MOVE PARTITION TO TABLE` as for `INSERT`s
2024-04-27 14:07:10 +00:00
Alexey Milovidov
5a7e7a9f2f Merge branch 'master' into too-many-parts-in-move-partition 2024-04-27 16:02:02 +02:00
Alexey Milovidov
a75a9e37be
Merge pull request #62534 from ClickHouse/Azure_write_buffer_parallel_upload
Support parallel write buffer for AzureBlobStorage
2024-04-27 13:59:55 +00:00
Alexey Milovidov
a985721129
Merge pull request #63033 from Algunenano/i42769
Add test for #42769
2024-04-27 13:49:44 +00:00
Azat Khuzhin
98df6b88a0 tests: forbid allow_experimental_analyzer if tag was specified
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-27 15:49:09 +02:00
Alexey Milovidov
b1f4171f5a
Merge pull request #63039 from azat/tsan-suppressions-fix
Fix suppressions for librdkafka data-race for statistics code
2024-04-27 13:48:44 +00:00
Alexey Milovidov
da2b9f2cbb
Merge pull request #63040 from vitlibar/fix-unhandled-exception-in-restorer-from-backup-destructor
Fix unhandled exception in ~RestorerFromBackup
2024-04-27 13:47:38 +00:00
Alexey Milovidov
d8adbf0de2
Merge pull request #63048 from vitlibar/unfork-and-update-curl
Unfork and update curl to 8.7.1
2024-04-27 13:45:17 +00:00
Alexey Milovidov
054e63134c
Update hdfs.md 2024-04-27 15:32:23 +02:00
Azat Khuzhin
5facb1d099 Get back test for old inter-server mode (DBMS_MIN_REVISION_WITH_INTERSERVER_SECRET non-v2)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-27 15:29:14 +02:00
alesapin
bfa9026cf4 Merge branch 'ci_add_azure_tests' of github.com:ClickHouse/ClickHouse into ci_add_azure_tests 2024-04-27 14:11:25 +02:00
alesapin
ba949f2a38 Add for master only 2024-04-27 12:36:17 +02:00
alesapin
78e6d62ed3
Merge branch 'master' into ci_add_azure_tests 2024-04-27 12:33:42 +02:00
alesapin
b4e3880c6b Test work without azurite 2024-04-27 12:30:28 +02:00
Azat Khuzhin
52091916dc Fix leftovers of enabling new analyzer
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-27 11:19:03 +02:00
Azat Khuzhin
03d52e7e49 Better handling of old analyzer check in intergraion tests runner
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-27 10:32:27 +02:00
Azat Khuzhin
85ea46de77 Fix integration tests with old analyzer
This reverts commit 67d39a22ac.
2024-04-27 10:29:13 +02:00
Azat Khuzhin
eb4c095077 Fix suppressions for rd_avg_calc()/rd_avg_rollover() (due to static qualifier)
The problem is that TSan still fails [1] is that ignorelist does not
work for static functions without asterisk:

    // test.cpp
    #include <thread>

    bool flag = false;

    // avoid mangling
    extern "C" {

    static void set_flag_impl()
    {
        flag = true;
    }

    void set_flag()
    {
        set_flag_impl();
    }
    void set_flag_if()
    {
        if (flag)
            flag = false;
    }

    }

    int main()
    {
        std::thread t1([]{ set_flag(); });
        std::thread t2([]{ set_flag_if(); });

        t1.join();
        t2.join();

        return 0;
    }

    // ignorelist
    [thread]
    fun:set_flag_impl

    $ clang++ -g -fno-omit-frame-pointer -fsanitize=thread -fsanitize-ignorelist=ignorelist -o test test.cpp && ./test
    SUMMARY: ThreadSanitizer: data race /tmp/test-tsan-ignorelist/test.cpp:19:9 in set_flag_if
    $ sed -i 's/set_flag_impl/*set_flag_impl*/' ignorelist
    $ clang++ -g -fno-omit-frame-pointer -fsanitize=thread -fsanitize-ignorelist=ignorelist -o test test.cpp && ./test
    OK

But, note that ignorelist is tricky, and will not work for
functions with __always_inline__ attribute for example.

P.S. set_flag_impl also has brackets in the output (i.e.
set_flag_impl()), while ther eis brackets for rd_avg_calc on CI [1].

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/63039/84bebc534ba7cf6e9dbfc1d91e8350939a84f87c/integration_tests__tsan__[6_6]//home/ubuntu/actions-runner/_work/_temp/test/output_dir/integration_run_parallel4_0.log

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-27 09:51:59 +02:00
Konstantin Bogdanov
64de52397e
Merge pull request #62978 from ClickHouse/fix-grpc-ipv6-crash
gRPC: fix crash on IPv6 peer connection
2024-04-27 06:22:41 +00:00
Alexey Milovidov
8cc67f7c95
Merge pull request #62973 from yariks5s/reduce_help_messages
Reduce verbosity of `clickhouse client --help`
2024-04-27 03:43:33 +00:00
Alexey Milovidov
52f58f2fff
Merge pull request #63035 from aalexfvk/fix_flaky_test_03000_traverse_shadow_system_data_paths
Fix flaky test 03000_traverse_shadow_system_data_paths
2024-04-27 01:04:30 +00:00
Yarik Briukhovetskyi
ebad7062a8
un-flaky the test 2024-04-26 20:31:26 +02:00
Nikita Mikhaylov
ed7e4291ab
Merge pull request #62937 from ClickHouse/docs-remove-replicated-experimental-tag
Remove experimental tag from Replicated database engine
2024-04-26 17:56:06 +00:00
Alexander Tokmakov
87537c1303
Merge pull request #63000 from ClickHouse/tavplubix-patch-14
Remove incorrect assertion from DatabaseReplicated
2024-04-26 17:48:56 +00:00
Alexander Tokmakov
7fb78aa4d4
Merge pull request #60856 from azat/alter-select-throughtput-v2
[RFC] Reduce overhead of the mutations for SELECTs (v2)
2024-04-26 17:46:57 +00:00
Nikita Mikhaylov
8ed884d364
Merge pull request #62851 from slvrtrn/update-http-interface-role-docs
[Docs] Add ClickHouse version to the role query parameter docs
2024-04-26 17:43:16 +00:00
Konstantin Bogdanov
6d805d094c
Fix harder 2024-04-26 19:37:14 +02:00
Nikita Taranov
2dadb164c4
Merge pull request #62853 from nickitat/fix_gcd
Fix GCD codec
2024-04-26 17:26:00 +00:00
alesapin
8b050b2548 Merge branch 'ci_add_azure_tests' of github.com:ClickHouse/ClickHouse into ci_add_azure_tests 2024-04-26 19:18:18 +02:00
alesapin
349147b5b5 One more time 2024-04-26 19:16:27 +02:00
Vitaly Baranov
860c642535 fix-curl-cmake 2024-04-26 18:58:20 +02:00
Vitaly Baranov
d49fcda09e Unfork and update curl to 8.7.1 2024-04-26 18:58:13 +02:00
Nikita Mikhaylov
ec787a68e8
Merge pull request #60153 from azat/access-controls-enable-by-default
Enable all access control improvements by default (even without config.xml)
2024-04-26 16:09:30 +00:00
Konstantin Bogdanov
4c607147ba
Fix 2024-04-26 17:38:02 +02:00
Max K
ab29a5f428
Merge pull request #63045 from ClickHouse/ci_one_more_fix_for_ft_in_mq
CI: fix job config for MQ
2024-04-26 15:24:38 +00:00