Konstantin Bogdanov
c35c20a481
Make clang-tidy happy
2024-09-19 12:51:42 +02:00
Raúl Marín
f3df7bd171
Hide Settings implementation
2024-09-18 15:48:02 +02:00
Nikita Taranov
ffaf97a390
Merge pull request #68424 from ClickHouse/adaptive_parallel_replicas
...
Adaptive mark_segment_size for parallel replicas
2024-09-17 13:52:42 +00:00
Antonio Andelic
9f932fb453
Merge branch 'master' into keeper-better-ssl-support
2024-09-17 10:52:35 +02:00
Konstantin Bogdanov
a329150eef
Merge pull request #69601 from ClickHouse/fix-tsan-writebufferfromhttpserverresponse
...
Try to fix data race in `WriteBufferFromHTTPServerResponse`
2024-09-17 00:23:17 +00:00
Konstantin Bogdanov
6a26c5cf8e
Fix
2024-09-16 20:54:02 +02:00
serxa
d86ad992f1
Merge branch 'master' into fix-use-concurrency-control
2024-09-16 15:05:14 +00:00
Antonio Andelic
492461271b
Merge branch 'master' into keeper-better-ssl-support
2024-09-13 14:44:12 +02:00
Antonio Andelic
3c47f3df4b
Support more advanced SSL options for Keeper internal communication
2024-09-13 14:23:01 +02:00
Arthur Passos
2c165096cd
Merge branch 'master' into multi_auth_methods
2024-09-13 05:18:11 -03:00
Nikita Taranov
7b2810bea2
Merge branch 'master' into adaptive_parallel_replicas
2024-09-12 16:51:15 +01:00
Nikita Taranov
16f93ea1b3
revive separate protocol versioning for PRs
2024-09-12 15:40:51 +01:00
Sergei Trifonov
90645d7c0e
Merge branch 'master' into fix-use-concurrency-control
2024-09-11 18:48:11 +02:00
Alex Katsman
22ceaa0066
Use another error code for external data in buffer
...
Use CANNOT_DECOMPRESS error code for the compressed external data in
CompressedReadBufferBase for checksum validation and decompression.
2024-09-11 14:59:31 +00:00
Igor Nikonov
f5d49f8e10
Merge branch 'master' into adaptive_parallel_replicas
2024-09-06 23:08:30 +02:00
Arthur Passos
d9a4964cd9
Merge branch 'master' into multi_auth_methods
2024-09-03 15:01:59 -03:00
Constantine Peresypkin
ca514c6556
fix: Content-Encoding was not sent on progress
...
fixes : #64802
2024-09-03 02:13:23 +02:00
Sergei Trifonov
897e2def34
Merge branch 'master' into fix-use-concurrency-control
2024-08-29 12:42:37 +02:00
Alexey Milovidov
60592a3596
Add a setting
2024-08-19 01:39:42 +02:00
Nikita Taranov
8a0f41da7a
Merge branch 'master' into adaptive_parallel_replicas
2024-08-18 17:55:29 +02:00
Nikita Taranov
628a4300ba
fix
2024-08-18 16:53:00 +01:00
Arthur Passos
accade2390
Merge branch 'master' into multi_auth_methods
2024-08-17 10:26:11 -03:00
Yakov Olkhovskiy
f4280203a0
Merge pull request #63781 from ClickHouse/ft-chunked-protocol
...
Add chunked wrapper to native protocol
2024-08-14 10:35:20 +00:00
Yakov Olkhovskiy
93a922f169
merge master
2024-08-13 03:28:25 +00:00
Arthur Passos
64d50d6e5b
Merge branch 'master' into multi_auth_methods
2024-08-12 15:42:37 -03:00
Nikita Taranov
b757522fc4
fix build
2024-08-09 14:20:57 +01:00
Nikita Taranov
ffa1371dde
Merge branch 'master' into keep_alive_max_reqs
2024-08-09 12:24:45 +01:00
Anton Popov
7c409c7884
Merge pull request #66084 from morning-color/rows_before_group_by_counter
...
Add rows_before_aggregation_at_least statistic
2024-08-09 10:36:22 +00:00
Alexey Milovidov
63d7697115
Merge pull request #67177 from ClickHouse/vdimir/connection_reset_by_peer_spam_log
...
Do not spam logs with messages related to connection reset by peer
2024-08-08 17:42:22 +00:00
Nikita Mikhaylov
4c289aa2dc
Merge pull request #64183 from vitlibar/ts-engine
...
Add new TimeSeries table engine to handle Prometheus protocols
2024-08-08 12:03:12 +00:00
vdimir
c8c4ca88d0
Merge branch 'master' into vdimir/connection_reset_by_peer_spam_log
2024-08-08 12:12:45 +02:00
morning-color
211999fde6
Merge branch 'master' into rows_before_group_by_counter
2024-08-08 15:49:24 +08:00
Nikita Mikhaylov
f37e0c7fc6
Merge branch 'master' of github.com:ClickHouse/ClickHouse into ts-engine
2024-08-07 21:01:13 +00:00
Yakov Olkhovskiy
7706bc853d
Merge branch 'master' into fix-race-tcphandler
2024-08-07 18:13:20 +00:00
Alexander Tokmakov
a523125411
Merge pull request #66410 from ClickHouse/reject_poco
...
Add logs and metrics about rejected connections in Poco
2024-08-07 16:40:59 +00:00
Nikita Taranov
5ae5cd35b5
update
2024-08-06 21:50:31 +01:00
Nikita Taranov
053285dc1c
Merge branch 'master' into keep_alive_max_reqs
2024-08-06 20:55:48 +01:00
Alexander Tokmakov
77103aa729
Merge branch 'master' into reject_poco
2024-08-06 19:52:05 +02:00
Sema Checherinda
0eb6a41f57
Merge branch 'master' into chesema-processor-onCancel
2024-08-06 16:36:28 +02:00
Vitaly Baranov
9f1753bb4f
Corrections after review.
2024-08-04 22:01:54 +02:00
Vitaly Baranov
e85dfa9e85
Fix exception handling in PrometheusRequestHandler.
2024-08-03 16:20:23 +02:00
Vitaly Baranov
eacbadf560
Support prometheus remote read protocol.
2024-08-03 16:20:23 +02:00
Vitaly Baranov
24103c733d
Support prometheus remote write protocol.
2024-08-03 16:20:23 +02:00
Vitaly Baranov
7d88995f42
Provide alternative way to setup configuration for exposing metrics using new section <prometheus.handlers> in configuration.
2024-08-03 16:20:23 +02:00
Vitaly Baranov
03b9305956
Send exception from PrometheusRequestHandler back to client. Set thread name.
2024-08-03 16:20:23 +02:00
Vitaly Baranov
03ebab2ca5
Refactor factory of PrometheusRequestHandler to make extending it easier.
2024-08-03 16:20:23 +02:00
vdimir
71a3fd36ed
Merge branch 'master' into vdimir/connection_reset_by_peer_spam_log
2024-08-01 14:19:54 +02:00
serxa
184c156e09
Merge branch 'master' into fix-use-concurrency-control
2024-07-31 17:21:55 +00:00
Yakov Olkhovskiy
646b7e53d7
add timeout reset
2024-07-31 17:06:30 +00:00
serxa
384e2ff399
Merge branch 'master' into fix-use-concurrency-control
2024-07-31 07:25:16 +00:00
Yakov Olkhovskiy
bd83ba88b0
add comments
2024-07-30 18:48:34 +00:00
Sema Checherinda
a5598be1d2
Merge branch 'master' into chesema-processor-onCancel
2024-07-30 19:25:04 +02:00
Arthur Passos
fa6564dbe3
Merge branch 'master' into multi_auth_methods
2024-07-30 10:32:13 -03:00
vdimir
22b170c920
Merge branch 'master' into vdimir/connection_reset_by_peer_spam_log
2024-07-30 11:40:33 +02:00
Yakov Olkhovskiy
c1f45f632b
merge master
2024-07-30 05:12:43 +00:00
Yakov Olkhovskiy
18327bdf9c
move timeout reset to after pipeline reset
2024-07-29 22:17:02 +00:00
Raúl Marín
4fab47aa54
Merge remote-tracking branch 'blessed/master' into getSettingsCopy
2024-07-29 11:31:43 +02:00
Yakov Olkhovskiy
08229390df
protect socket timeouts
2024-07-29 06:17:35 +00:00
vdimir
73e71e7b7a
log
2024-07-26 10:49:53 +00:00
vdimir
3cbb3dc55f
Do not spam logs with messages related to connection reset by peer
2024-07-26 08:41:44 +00:00
Nikita Fomichev
e1f89f41f7
Merge pull request #67027 from ClickHouse/fix-flaky-integration-tests
...
Integration tests: fix flaky tests `test_backup_restore_on_cluster/test_concurrency.py` & `test_manipulate_statistics/test.py`
2024-07-25 07:50:17 +00:00
Nikita Taranov
408c5bbbd1
Merge pull request #66905 from ClickHouse/fix_deadlock_on_cancel
...
Fix possible deadlock on query cancel with parallel replicas
2024-07-24 16:00:33 +00:00
Nikita Fomichev
09cb2d822a
Change description for setting: throw_if_deduplication_in_dependent_materialized_views_enabled_with_async_insert
2024-07-24 14:05:50 +02:00
Nikita Taranov
ea61af961a
impl
2024-07-23 13:36:26 +01:00
Sema Checherinda
20f22278bd
Merge branch 'master' into chesema-processor-onCancel
2024-07-23 14:32:11 +02:00
Nikita Taranov
c15699e32d
Merge pull request #66652 from ClickHouse/separate_macro_for_debug_or_san_build
...
Introduce separate DEBUG_OR_SANITIZER_BUILD macro
2024-07-22 14:52:13 +00:00
Yakov Olkhovskiy
dac5996dda
Merge branch 'master' into ft-chunked-protocol
2024-07-20 23:01:56 +00:00
Sema Checherinda
43cebcd505
Merge branch 'master' into chesema-processor-onCancel
2024-07-19 15:00:39 +02:00
Arthur Passos
f2c22408da
Merge branch 'master' into multi_auth_methods
2024-07-18 17:13:50 -03:00
Raúl Marín
68cd15a18c
Merge remote-tracking branch 'blessed/master' into getSettingsCopy
2024-07-18 14:25:10 +02:00
Han Fei
2b7ad9c54c
Merge pull request #66531 from hanfei1991/hanfei/fix_keeper_tcp_log
...
fix log in keeper tcp handler
2024-07-17 21:04:24 +00:00
Nikita Taranov
5608914bca
impl
2024-07-17 16:59:31 +01:00
Vitaly Baranov
c8eac30108
Merge pull request #66621 from vitlibar/fix-logical-error-in-prometheus-request-handler
...
Fix logical error in PrometheusRequestHandler
2024-07-17 12:35:46 +00:00
Vitaly Baranov
d579e9f64f
Fix logical error in PrometheusRequestHandler.
2024-07-16 23:12:02 +02:00
morning-color
564429cb85
Merge branch 'master' into rows_before_group_by_counter
2024-07-16 16:26:56 +08:00
morning-color
8aaf9c1d98
Fix tests
2024-07-16 11:00:55 +08:00
Alexander Tokmakov
09dc79ad3a
Merge branch 'master' into reject_poco
2024-07-15 20:17:28 +02:00
Sema Checherinda
1d9a06be46
Merge branch 'master' into chesema-processor-onCancel
2024-07-15 17:45:46 +02:00
Sema Checherinda
344e5b716d
cancel method is noexcept
2024-07-15 17:41:32 +02:00
Han Fei
dec5931262
log session id
2024-07-15 16:43:41 +02:00
Han Fei
e346535641
fix log in keeper tcp handler
2024-07-15 16:27:53 +02:00
Arthur Passos
cc02ebca75
Merge branch 'master' into multi_auth_methods
2024-07-15 10:55:40 -03:00
Sema Checherinda
39dd15fe20
Merge branch 'master' into revert-66134-revert-61601-chesema-dedup-matview
2024-07-15 14:35:44 +02:00
Raúl Marín
b2466466d4
Rename Context::getSettings()
2024-07-15 14:28:12 +02:00
Yakov Olkhovskiy
1836a69b33
Merge branch 'master' into ft-chunked-protocol
2024-07-12 15:43:25 +00:00
Sema Checherinda
55724a1bcd
Merge branch 'master' into chesema-processor-onCancel
2024-07-12 13:59:20 +02:00
serxa
bf125d5da6
Merge branch 'master' into fix-use-concurrency-control
2024-07-12 08:44:12 +00:00
Alexander Tokmakov
243edcc8aa
add logs and metrics about rejected connections in Poco
2024-07-12 01:11:18 +02:00
Raúl Marín
1b75b8f4eb
Merge remote-tracking branch 'blessed/master' into mergetree_private
2024-07-11 19:58:54 +02:00
Sema Checherinda
a8e55ac816
Merge branch 'master' into revert-66134-revert-61601-chesema-dedup-matview
2024-07-11 18:01:12 +02:00
Raúl Marín
56f497bf7f
Remove some unnecessary copies
2024-07-11 14:09:00 +02:00
Raúl Marín
9e599576ab
Hide Settings object from Context.h
2024-07-11 14:00:05 +02:00
Sema Checherinda
614e899e8d
onCancel is concurrent call
2024-07-10 19:13:00 +02:00
Raúl Marín
d2f89a044a
Reduce dependencies on CoordinationSettings.h
2024-07-10 18:20:39 +02:00
Raúl Marín
314174013b
Reduce dependencies on ServerSettings.h
2024-07-10 18:10:19 +02:00
Antonio Andelic
65dc1c8515
Merge pull request #66124 from ClickHouse/keeper-correct-log-long-total
...
Correctly print long processing requests in Keeper
2024-07-10 11:34:28 +00:00
Yakov Olkhovskiy
2794b7bf84
defaults to notchunked, add docs to server's and client's configs
2024-07-10 00:20:11 +00:00
Raúl Marín
a339dd020f
Reduce dependencies on MergeTreeSettings.h
2024-07-09 19:39:41 +02:00
Kruglov Pavel
f3bfe8d881
Merge branch 'master' into data-types-binary-encoding
2024-07-09 12:27:06 +02:00
Vitaly Baranov
6d0bf97476
Merge pull request #66067 from vitlibar/move-http-handler-stuff-to-separate-files
...
Move some of HTTPHandler stuff to separate source files in order to reuse it in PrometheusRequestHandler
2024-07-08 21:03:22 +00:00
Vitaly Baranov
5ac5a4b2fe
Add check that user name is not empty to authenticateUserByHTTP().
2024-07-08 13:05:34 +02:00
Antonio Andelic
b04f210dec
Merge branch 'master' into keeper-correct-log-long-total
2024-07-08 10:05:09 +02:00
Vitaly Baranov
c42b5eddd4
Fix error messages in authenticateUserByHTTP() when multiple authentication methods are used simultaneously.
2024-07-05 21:36:13 +02:00
Vitaly Baranov
e572dfd2dc
Use Common/Base64.h
2024-07-05 20:15:19 +02:00
Sema Checherinda
5e4a244faf
Revert "Revert "insertion deduplication on retries for materialised views""
2024-07-05 16:52:51 +02:00
Antonio Andelic
bf0b782960
Correctly print long processing requests in Keeper
2024-07-05 15:16:08 +02:00
Sema Checherinda
77e60543fd
Revert "insertion deduplication on retries for materialised views"
2024-07-05 14:58:17 +02:00
Kruglov Pavel
6239f7d62f
Merge branch 'master' into data-types-binary-encoding
2024-07-05 13:20:31 +02:00
Nikita Mikhaylov
3a7c98399f
Merge pull request #65777 from ClickHouse/make_analyzer_important
...
Make `allow_experimental_analyzer` be controlled by the initiator for distributed queries
2024-07-04 20:38:40 +00:00
Vitaly Baranov
6bf1320870
Merge pull request #66061 from vitlibar/fix-shutdown-in-grpc-server
...
Fix shutdown in GRPCServer
2024-07-04 14:33:59 +00:00
Sema Checherinda
19816401c4
Merge pull request #61601 from ClickHouse/chesema-dedup-matview
...
insertion deduplication on retries for materialised views
2024-07-04 13:52:52 +00:00
Nikita Mikhaylov
fe6a875c74
Make the setting back IMPORTANT + fix build
2024-07-04 11:12:27 +00:00
Nikita Mikhaylov
fcabefa8f3
Automatically disabling
2024-07-04 11:12:27 +00:00
Nikita Mikhaylov
dd3eb538f6
Better
2024-07-04 11:12:27 +00:00
morning-color
a99c803ddf
Rename rows_before_group_by_at_least to rows_before_aggregation_at_least
2024-07-04 17:26:06 +08:00
Vitaly Baranov
ecfe6fddcf
Move function HTTPHandler::formatExceptionForClient() to a separate header in order to reuse it.
2024-07-03 21:23:09 +02:00
Vitaly Baranov
49b982747a
Move function authenticateUserByHTTP() to a separate header in order to reuse it.
2024-07-03 21:23:09 +02:00
Vitaly Baranov
25dc96aaca
Simplify initialization of settings in HTTPHandler.
2024-07-03 21:23:09 +02:00
Vitaly Baranov
bf56ad69dd
Make Context::setCurrentRoles() check that new current roles are granted in order to make HTTPHandler's implementation easier.
2024-07-03 21:23:09 +02:00
Vitaly Baranov
29ed1c9bf8
Move function exceptionCodeToHTTPStatus() from HTTPHandler.cpp to a separate header in order to reuse it.
2024-07-03 21:23:09 +02:00
Vitaly Baranov
e8701dc4e4
Fix shutdown in GRPCServer.
2024-07-03 18:18:23 +02:00
Antonio Andelic
cddd2312fb
Merge branch 'master' into keeper-remove-standalone-build
2024-07-03 16:23:31 +02:00
Antonio Andelic
ce4d361cd7
Merge branch 'master' into keeper-remove-standalone-build
2024-07-03 16:23:06 +02:00
Antonio Andelic
e3beff45c1
Merge pull request #65918 from ClickHouse/add-some-tools-for-keeper-profiling
...
Add extra profiling helpers for Keeper
2024-07-03 07:01:13 +00:00
Sema Checherinda
06e235024f
work with review
2024-07-02 15:16:57 +02:00
Arthur Passos
cc13783acd
Merge branch 'master' into multi_auth_methods
2024-07-02 09:11:20 -03:00
Kruglov Pavel
15b32b6d0c
Merge branch 'master' into data-types-binary-encoding
2024-07-02 13:26:43 +02:00
Konstantin Bogdanov
138eb924fa
Merge pull request #65626 from tonickkozlov/tonickkozlov/x509-san-validation
...
Add support for x509 SubjectAltName identification
2024-07-02 11:20:01 +00:00
Antonio Andelic
a0f6751c4d
Merge branch 'master' into add-some-tools-for-keeper-profiling
2024-07-02 10:50:24 +02:00
Azat Khuzhin
4f2a0e8eeb
Fix possible issues with MySQL server protocol TLS connections
...
The problem here is that retries (in SecureSocketImpl.cpp::mustRetry())
relies on non-zero socket timeout, but MySQL handler does not set
timeouts for the socket (like other does), and this leads to a problem
when OpenSSL returns SSL_ERROR_WANT_READ/SSL_ERROR_WANT_WRITE, the
connection will be simply terminated.
I've played with this patch, by hacking the openssl sources:
diff --git a/crypto/bio/bss_sock.c b/crypto/bio/bss_sock.c
index 82f7be85ae..a399291ff4 100644
--- a/crypto/bio/bss_sock.c
+++ b/crypto/bio/bss_sock.c
@@ -124,7 +125,18 @@ static int sock_read(BIO *b, char *out, int outl)
ret = ktls_read_record(b->num, out, outl);
else
# endif
- ret = readsocket(b->num, out, outl);
+ {
+ /* pthread_kill(pthread_self(), SIGUSR1); */
+ static int i = 0;
+ if (!(++i % 2))
+ {
+ fprintf(stderr, "sock_read: inject EAGAIN\n");
+ ret = -1;
+ errno = EAGAIN;
+ }
+ else
+ ret = readsocket(b->num, out, outl);
+ }
BIO_clear_retry_flags(b);
if (ret <= 0) {
if (BIO_sock_should_retry(ret))
And after this patch this succeed without errors:
ch benchmark -c10 -q "SELECT * FROM mysql('127.0.0.1:9004', system, one, 'default', '', SETTINGS connection_pool_size=1, connect_timeout = 100, connection_wait_timeout = 100)"
Note, that this also fixes the timeouts for plain (non-TLS) connections
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-07-01 15:22:33 +02:00
Antonio Andelic
1a95259182
Add extra profiling helpers for Keeper
2024-07-01 15:17:41 +02:00
avogar
22eb2fe006
Merge branch 'master' of github.com:ClickHouse/ClickHouse into data-types-binary-encoding
2024-07-01 10:19:31 +00:00
Anton Kozlov
b1b9aaf2ec
Add support for x509 SubjectAltName identification
2024-07-01 09:47:28 +00:00
Antonio Andelic
4a9daa202d
Remove Keeper standalone build
2024-07-01 11:24:45 +02:00
Sema Checherinda
abe58184df
Merge branch 'master' into chesema-dedup-matview
2024-06-29 01:35:32 +02:00
Alexander Tokmakov
4748e2929f
Merge pull request #65570 from ClickHouse/keeper_az
...
Improve ZooKeeper load balancing
2024-06-28 22:57:20 +00:00
Kruglov Pavel
6436bd9cf3
Merge branch 'master' into data-types-binary-encoding
2024-06-27 17:19:36 +02:00
morning-color
71d71bd5fe
Add rows_before_group_by_counter
2024-06-27 20:06:14 +08:00
Kseniia Sumarokova
7892e77d9d
Merge pull request #65744 from ClickHouse/try-fix-race-in-tcp-handler
...
Try fix data race in TCPHandler between `processOrdinaryQuery -> sendProgress` and `fatal_error_callback -> sendLogs`
2024-06-27 10:27:24 +00:00
Sema Checherinda
92375ec052
Merge branch 'master' into chesema-dedup-matview
2024-06-27 02:12:32 +02:00
Sema Checherinda
d485606e94
fix header in async insert and projections
2024-06-27 02:09:45 +02:00
Sema Checherinda
4d409831a0
Merge pull request #64478 from ClickHouse/chesema-fix-buffer-cancelation
...
make writebuffers cancelable
2024-06-26 22:12:30 +00:00
Sema Checherinda
8efa045a97
fix resolving conflicts with squashing
2024-06-27 00:09:55 +02:00
kssenii
2e7c23b82c
Try fix data race in TCPHandler
2024-06-26 19:49:14 +02:00
Sema Checherinda
5d2e2a9f44
Merge branch 'master' into chesema-dedup-matview
2024-06-26 17:03:05 +02:00
Yakov Olkhovskiy
57ea611876
Merge branch 'master' into ft-chunked-protocol
2024-06-26 10:12:38 -04:00
Arthur Passos
c2dd3bb5d2
Merge branch 'master' into multi_auth_methods
2024-06-26 09:03:58 -03:00
Konstantin Bogdanov
665b4a9d1d
Merge pull request #62829 from ClickHouse/jwt-auth-in-client
...
Support JWT in `clickhouse-client`
2024-06-26 07:56:28 +00:00
Yakov Olkhovskiy
3f3305a63a
fix server settings
2024-06-26 04:33:52 +00:00
Yakov Olkhovskiy
6112ef710c
fix style
2024-06-26 03:43:28 +00:00
